Re: Buildbot failure in Wildebeest Builder on whole buildset

2022-02-17 Thread Marc via Gcc-rust
build...@builder.wildebeest.org writes: > Build Reason: > Blamelist: Philip Herron g++ -fno-PIE -c -DIN_GCC_FRONTEND -g -O2 -DIN_GCC -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Woverloaded-vir

Re: Buildbot failure in Wildebeest Builder on whole buildset

2022-01-24 Thread Marc via Gcc-rust
Mark Wielaard writes: > Sorry, I don't immediately know what is happening. > I assume some merge took place and the buildbot doesn't know what are > good/bad commits and just tries to do builds for everything in the > merge. I have shutdown the buildbot till I have time to figure out what > is go

Re: UTF-8 BOM handling

2021-07-06 Thread Marc via Gcc-rust
Mark Wielaard writes: > Hi, > > A rust source file can start with a UTF-8 BOM sequence (EF BB > BF). This simply indicates that the file is encoded as UTF-8 (all rust > input is interpreted as asequence of Unicode code points encoded in > UTF-8) so can be skipped before starting real lexing. > >

Re: shebang handling

2021-07-04 Thread Marc via Gcc-rust
Mark Wielaard writes: > [PATCH 1/2] Handle shebang line, plus any whitespace and comment > [PATCH 2/2] Remove has_shebang flag from AST and HIR Crate classes Pushed to githup: https://github.com/Rust-GCC/gccrs/pull/546 Marc -- Gcc-rust mailing list Gcc-rust@gcc.gnu.org https://gcc.gnu.org/ma

Re: [PATCH 2/2] Remove unused have_more_segments from TypeCheckExpr::resolve_root_path

2021-06-29 Thread Marc via Gcc-rust
Mark Wielaard writes: > It isn't necessary to know whether there are more segments while > iteration through the expression segements. Both patches in GH: https://github.com/Rust-GCC/gccrs/pull/537/commits Fixed a small typo in the commit message while creating the PR :) Marc -- Gcc-rust mail

Re: [PATCH] Suppress warning in rust-ast-lower-type.h ASTLowerGenericParam.visit.

2021-06-28 Thread Marc via Gcc-rust
Mark Wielaard writes: > On Tue, Jun 29, 2021 at 12:47:07AM +0200, Mark Wielaard wrote: >> On Tue, Jun 29, 2021 at 12:06:56AM +0200, Marc wrote: >> > Hi, >> > >> > > Translating the AST LifetimeType to the HIR LifetimeType causes a >> > > warning: >> > > warning: ‘ltt’ may be used uninitialized

Re: [PATCH] Suppress warning in rust-ast-lower-type.h ASTLowerGenericParam.visit.

2021-06-28 Thread Marc via Gcc-rust
Hi, > Translating the AST LifetimeType to the HIR LifetimeType causes a warning: > warning: ‘ltt’ may be used uninitialized Was wondering why this is needed as the switch case covers all enum variants, how can ltt be uninitialized ? I have the same fix locally but was thinking something else was

Re: [PATCH] Fix inner attribute parsing

2021-06-27 Thread Marc via Gcc-rust
Mark Wielaard writes: > parse_inner_attribute tried to skip the right square token twice. This caused > odd error > messages in case there were multiple inner attributes. This bug masked > another bug in > parse_attr_input where when the (optional) attr input was an assignment to a > literal >