Re: libgrust: 'AM_ENABLE_MULTILIB' only for target builds [PR113056]

2024-01-04 Thread Pierre-Emmanuel Patry
Hello Thomas, On 12/18/23 17:58, Thomas Schwinge wrote: --- a/libgrust/configure.ac +++ b/libgrust/configure.ac -# AM_ENABLE_MULTILIB(, ..) +AM_ENABLE_MULTILIB(, ..) Such a change was applied eventually, and is necessary for target builds -- but potentially harmful for host builds. OK to

[COMMITTED] libcpp: add function to check XID properties

2024-01-04 Thread Arthur Cohen
From: Raiki Tamura This commit adds a new function intended for checking the XID properties of a possibly unicode character, as well as the accompanying enum describing the possible properties. libcpp/ChangeLog: * charset.cc (cpp_check_xid_property): New. * include/cpplib.h

Re: [PATCH v3] libcpp: add function to check XID properties

2024-01-04 Thread Arthur Cohen
Hi Joseph, Thanks for the review! On 12/18/23 20:00, Joseph Myers wrote: On Fri, 8 Sep 2023, Arthur Cohen wrote: + if (c < 0x80) + { +if (('A' <= c && c <= 'Z') || ('a' <= c && c <= 'z')) + return CPP_XID_START | CPP_XID_CONTINUE; +if (('0' <= c && c <= '9') || c == '_') + return