Re: [PATCH 2/2] Remove unused have_more_segments from TypeCheckExpr::resolve_root_path

Mark Wielaard writes: > It isn't necessary to know whether there are more segments while > iteration through the expression segements. Both patches in GH: https://github.com/Rust-GCC/gccrs/pull/537/commits Fixed a small typo in the commit message while creating the PR :) Marc -- Gcc-rust mail

[PATCH 2/2] Remove unused have_more_segments from TypeCheckExpr::resolve_root_path

It isn't necessary to know whether there are more segments while iteration through the expression segements. --- gcc/rust/typecheck/rust-hir-type-check-expr.h | 1 - 1 file changed, 1 deletion(-) diff --git a/gcc/rust/typecheck/rust-hir-type-check-expr.h b/gcc/rust/typecheck/rust-hir-type-check-

[PATCH 1/2] Remove unused default_ty_param from TypeResolveGenericParam::visit

The default_ty_param was set, but not used. We do need to call TypeCheckType::Resolve on the default param, but don't need the result. --- gcc/rust/typecheck/rust-hir-type-check-type.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/gcc/rust/typecheck/rust-hir-type-check

Re: [PATCH] Suppress warning in rust-ast-lower-type.h ASTLowerGenericParam.visit.

Hi Marc, On Tue, Jun 29, 2021 at 08:28:51AM +0200, Marc wrote: > Mark Wielaard writes: > > I just tried to make LifetimeType an enum class and that doesn't help. > > So I was wrong. I don't know why the compiler doesn't see this? It > > should know since if not all switch cases were covered, -Wsw