Re: [patch, fortran] Handling of .and. and .or. expressions

2018-06-27 Thread Thomas Koenig
a value. If the value is not needed to produce the correct result, the function need not be called. Regards Thomas

Re: [patch, fortran] Handling of .and. and .or. expressions

2018-06-27 Thread Thomas Koenig
Hi Janus, if we add a warning, we should add it both for if (flag .and. func()) and for if (func() .and. flag) because the standard also allows reversing the test (which my original test did). Regards Thomas

Re: [patch, fortran] Handling of .and. and .or. expressions

2018-06-28 Thread Thomas Koenig
Am 28.06.2018 um 19:21 schrieb Janus Weil: One thing that I always failed to comprehend is people's fixation on optimization. What's so great about your code running 0.1% faster if the second compiler you try gives you totally different results, with no hints The warning added for my patch is s

Re: [PATCH] PR Fortran/79383 -- Testcase from PR

2018-01-11 Thread Thomas Koenig
.f03: New test. OK to commit? Yes, thanks! As a general principle, I think that test cases from bugs that have been fixed by other commits fall under the "obvious and simple" rule. I don't think that special approval is needed. Regards Thomas

[patch, fortran, committed] Fix PR 83803

2018-01-13 Thread Thomas Koenig
Hello world, I have committed the patch below as obvious. This one had the distinction that two people came up with exactly the same pach independently :-) Regards Thomas 2018-01-13 Thomas Koenig PR fortran/83803 * dump-parse-tree.c (write_ Index: dump

Re: [PATCH] PR 78534, 83704 Large character lengths

2018-01-14 Thread Thomas Koenig
ggest using %ld and casting the value to long int, or %lld and casting to long long int, at least for the time being. Regards Thomas

[patch, fortran] Change ABI for F2008 - minloc/maxloc BACK argument

2018-01-14 Thread Thomas Koenig
? Regards Thomas 2018-01-14 Thomas Koenig PR fortran/54613 * gfortran.h (gfc_check_f): Rename f4ml to f5ml. (gfc_logical_4_kind): New macro * intrinsic.h (gfc_simplify_minloc): Add a gfc_expr *argument. (gfc_simplify_maxloc): Likewise

Re: [PATCH 0/5] x86: CVE-2017-5715, aka Spectre

2018-01-14 Thread Thomas Gleixner
On Sun, 14 Jan 2018, David Woodhouse wrote: > On Sun, 2018-01-14 at 13:07 -0800, Linus Torvalds wrote: > > On Sun, Jan 14, 2018 at 1:02 PM, David Woodhouse > > wrote: > > > Review on the GCC patches has led to a request that the thunk symbols > > > be changed from e.g. __x86_indirect_thunk_rax t

Re: [patch, fortran] Change ABI for F2008 - minloc/maxloc BACK argument

2018-01-15 Thread Thomas Koenig
. Also fixed, committed as r256705. Thanks a lot for the thorough review! Regards Thomas

Re: [Patch, fortran] PR37577 - [meta-bug] change internal array descriptor format for better syntax, C interop TR, rank 15

2018-01-22 Thread Thomas Koenig
Am 22.01.2018 um 20:59 schrieb Janne Blomqvist: On Mon, Jan 22, 2018 at 9:12 PM, Paul Richard Thomas wrote: This patch has been triggered by Thomas's recent message to the list. Not only did I start work late relative to stage 3 but debugging took somewhat longer than anticipated. Ther

Re: [PATCH] PR 83975 Set character length to 0 if unknown

2018-01-23 Thread Thomas Koenig
tails. Regtested on x86_64-pc-linux-gnu, Ok for trunk? Does the code which is accepted then execute correctly? Personally, I would prefer an ICE over a silent wrong-code. Regards Thomas

Re: [Patch, fortran] PR37577 - [meta-bug] change internal array descriptor format for better syntax, C interop TR, rank 15

2018-01-23 Thread Thomas Koenig
line; CHARACTER2 (iomsg); GFC_INTEGER_4 *iostat; + void *reserved; } st_parameter_common; Yes, this is what I had in mind. Regards Thomas

Re: [Patch, fortran] PR37577 - [meta-bug] change internal array descriptor format for better syntax, C interop TR, rank 15

2018-01-23 Thread Thomas Koenig
Hi Paul, Could somebody please review the patch? I'd say the patch is OK for trunk. I have also tested this on a big-endian system, and things worked. I will look at the resulting fallout of the GFC_DTYPE_TYPE_SIZE stuff. Thanks a lot for your work! Regards Thomas

Re: [PATCH] PR fortran/83998 -- fix dot_product on 0-sized arrays

2018-01-24 Thread Thomas Koenig
.0] real, parameter :: c = dot_product(a,b) ? Regards Thomas

Re: [PATCH] PR fortran/83998 -- fix dot_product on 0-sized arrays

2018-01-25 Thread Thomas Koenig
Hi Steve, thanks for your explanations. The patch is OK for trunk. Thanks a lot! Regards Thomas

[patch, fortran] Reject character lengths unequal to one in BIND(C)

2018-01-28 Thread Thomas Koenig
which has the broken code above will then likely crash and burn when using a gfortran-generated prototype. The attached patch solves that particular problem by issuing errors in this case. OK for trunk? Regards Thomas 2017-01-28 Thomas Koenig PR fortran/84073 * reso

[patch, libfortran] Adapt handling of derived types to new dtype

2018-01-29 Thread Thomas Koenig
fine, because the sizes are known to fit. For derived types or characters, there could be a problem if a user specified a very large size. Regression-tested. OK for trunk? Regards Thomas 2018-01-29 Thomas Koenig PR fortran/37577 * libgfortran.h: Remove GFC_DTYPE_DERI

Re: [PATCH] Use pointer sized array indices.

2018-01-30 Thread Thomas Koenig
Hi Janne, PING**2 OK. Regards, Thomas

[patch, fortran, committed] Fix PR 84133, regression with matmul

2018-01-30 Thread Thomas Koenig
Hello world, I have just committed the attached patch as obvious, after regtesting. Regards Thomas 2018-01-30 Thomas Koenig PR fortran/84133 * frontend-passes (matmul_to_var_expr): Return early if in association list. (inline_matmul_assign

[patch, fortran, committed] Fix PR 84134

2018-01-30 Thread Thomas Koenig
Hello world, another obvious fix, this time for an ice-on-invalid regression, committed after regression-testing. Regards Thomas 2017-01-30 Thomas Koenig PR fortran/84134 * array.c (gfc_ref_dimen_size): Whitespace fixes. If stride is zero, return false

[patch, fortran, committed] Fix symbol name for prototypes generated by -fc-prototypes

2018-01-31 Thread Thomas Koenig
Hello world, I have just committed the attached patch as obvious and simple. Before, the C binding label was ignored for generating function prototypes with the -fc-prototypes option. 2018-01-31 Thomas Koenig * dump-parse-tree.c (write_proc): Use sym_name (which may be sym

Re: [PATCH] PR 83975 Associate target with non-constant character length

2018-02-01 Thread Thomas Koenig
ances. OK for trunk. Thanks! Regards Thomas

[patch, fortran] Fix PR 68560

2018-02-01 Thread Thomas Koenig
function. Regression-testing as I write this. If it passes (which I expect), OK for trunk? Regards Thomas 2018-02-01 Thomas Koenig PR fortran/68560 * trans-intrinsic.c (gfc_conv_intrinsic_shape): New function. (gfc_conv_intrinsic_function): Call it. 2018-02-01

[patch, libfortran] Use flexible array members for array descriptor

2018-02-04 Thread Thomas Koenig
g LTO for the library :-) and this, I think, will be a prerequisite. OK for trunk? Regards Thomas 2018-02-04 Thomas Koenig * libgfortran.h (GFC_ARRAY_DESCRIPTOR): Remove dimension of descriptor to use vaiable members for dim. Change usage of GFC_ARRAY_DESCR

Re: [patch, libfortran] Use flexible array members for array descriptor

2018-02-05 Thread Thomas Koenig
Am 05.02.2018 um 13:09 schrieb Janne Blomqvist: On Sun, Feb 4, 2018 at 9:49 PM, Thomas Koenig wrote: Hello world, in the attached patch, I have used flexible array members for using the different descriptor types (following Richi's advice). This does not change the binary ABI, but the li

Re: [patch, libfortran] Use flexible array members for array descriptor

2018-02-06 Thread Thomas Koenig
we introduce a bug. This way is safer. According to the C standard (C11 6.7.2.1.18 and example 6.7.2.1.20), this is guaranteed to work. OK, I didn't know that, and I see how that would save memory. I'll make that change (with a comment) if this patch ends up being committed. Regards Thomas

Re: [patch, fortran] Fix PR 68560

2018-02-07 Thread Thomas Koenig
Here's an update on the patch - I realized that it is not necessary to check for the actual argument, it is always present. OK for trunk? Regards Thomas 2018-02-01  Thomas Koenig  PR fortran/68560 * trans-intrinsic.c (gfc_conv_intrinsic_shape): New fun

[patch, fortran] Fix handling of assumed-size arrays in inline matmul

2018-02-12 Thread Thomas Koenig
Hello world, the attached patch fixes a regression where a rejects-valid would be issued. OK for the affected branches, trunk and gcc-7? Regards Thomas 2018-02-12 Thomas Koenig PR fortran/84270 * frontend-passes (scalarized_expr): If the expression is an

Re: [patch, libfortran] Use flexible array members for array descriptor

2018-02-12 Thread Thomas Koenig
ettle here. All right. I have attached the patch updated with Janne's comments. Regression-tested. OK for trunk then? Regards Thomas 2018-02-12 Thomas Koenig * libgfortran.h (GFC_ARRAY_DESCRIPTOR): Remove dimension of descriptor to use vaiable members for dim.

[patch, testcase, fortran, committed] Fix read_dir.f90

2018-02-12 Thread Thomas Koenig
gards Thomas -! { dg-do run { xfail *-*-freebsd* *-*-dragonfly* hppa*-*-hpux* powerpc-ibm-aix* } } +! { dg-do run } ! PR67367 program bug implicit none @@ -12,7 +11,7 @@ program bug call abort end if read(10, iostat=ios) c - if (ios.ne.21) then + if (ios.ne.21.and.ios.ne.0)

Re: [patch, libfortran] Use flexible array members for array descriptor

2018-02-12 Thread Thomas Koenig
procedures, for allocatable variables and for pointers. Pointers and allocatable variables can also be passed to procedures. So, not so easy (unfortunately). Regards Thomas

[PATCH, GCC/ARM] Multilib mapping for Armv8-R

2018-02-13 Thread Thomas Preudhomme
, -march=armv8-r+fp.sp is mapped to -march=armv7 ie. Armv7 with softfloat floating-point. Changelog entry is as follows: *** gcc/ChangeLog *** 2018-02-12 Thomas Preud'homme * config/arm/t-multilib: Map Armv8-R to Armv7 multilibs. Testing: Ran -print-multi-directory for all combina

[fortran, test case, committed]

2018-02-15 Thread Thomas Koenig
Hi, I just committed the test case below as obvious, after testing. Just to make sure that, when we convert all test cases from CALL ABORT to "STOP 1" (or whatever), we actually get a failure when we have a regression. Regards Thomas 2018-02-15 Thomas Koenig

Re: [fortran, test case, committed]

2018-02-15 Thread Thomas Koenig
Hi Janus, apparently your commit only includes the ChangeLog addition, but not the new test case itself. I guess you missed an "svn add"? :) Actually, I messed up the ChangeLog entry in r257702 and corrected that one in r257703 :-) The test case is there. Regards Thomas

Re: [ patch, testsuite, fortran] Replace "call abort" by "stop n"

2018-02-15 Thread Thomas Koenig
I wrote: OK for trunk? Following a remark by Steve, here is an additional test case which checks if abort actually works. I'll add that to the patch when it is committed. Regards Thomas ! { dg-do run } ! { dg-shouldfail "Program aborted." } program main call ab

Re: [PATCH, GCC/ARM] Multilib mapping for Armv8-R

2018-02-16 Thread Thomas Preudhomme
t. Changelog entry is as follows: *** gcc/ChangeLog *** 2018-02-12 Thomas Preud'homme * config/arm/t-multilib: Map Armv8-R to Armv7 multilibs. *** gcc/testsuite/ChangeLog *** 2018-02-13 Thomas Preud'homme * gcc.target/arm/multilib.exp: Add tests for Armv8-R multi

Re: [ patch, testsuite, fortran] Replace "call abort" by "stop n"

2018-02-17 Thread Thomas Koenig
the output "STOP 1" for a STOP 1 statement. Should not be too hard to find in the source. Regards Thomas

*ping* [patch, fortran] Fix handling of assumed-size arrays in inline matmul

2018-02-17 Thread Thomas Koenig
Am 12.02.2018 um 11:46 schrieb Thomas Koenig: Hello world, the attached patch fixes a regression where a rejects-valid would be issued. OK for the affected branches, trunk and gcc-7? PING ** (5.D0/7.D0) ?

Re: [ patch, testsuite, fortran] Replace "call abort" by "stop n"

2018-02-17 Thread Thomas Koenig
STOP [1-9] after my patch; I didn't look at any other use of -fall-intrinsics. Would you mind if I applied the patch in attachment? Not at all - if the test cases pass without the option, just go ahead and commit the patch. Regards Thomas

[patch, fortran] Remove workaround introduced because of PR80945

2018-02-18 Thread Thomas Koenig
ested. OK for trunk? Regards Thomas 2018-02-18 Thomas Koenig PR fortran/35339 * frontend-passes.c (traverse_io_block): Remove workaround for PR 80945. 2018-02-18 Thomas Koenig PR fortran/35339 * gfortran.dg/implied_do_io_4.f90: New test.

[patch, fortran] Fix character length in constructors

2018-02-19 Thread Thomas Koenig
attached patch fixes that. Regression-tested. OK for trunk? Regards Thomas 2018-02-19 Thomas Koenig PR fortran/48890 PR fortran/83823 * primary.c (gfc_convert_to_structure_constructor): For a constant string constructor, make sure the length is

Re: [patch, fortran] Fix character length in constructors

2018-02-20 Thread Thomas Koenig
w and the heads_up about gfc_mpz_get_hwi. I also changed the "call abort" to "STOP 1" at the last second (old habits are hard to break, it seems :-) Regards Thomas

Re: [patch, fortran] Fix character length in constructors

2018-02-20 Thread Thomas Koenig
Am 20.02.2018 um 20:10 schrieb Janne Blomqvist: Shouldn't the second one be "stop 2"? Corrected, r257859. Regards Thomas

Re: [PATCH] PR fortran/84346 -- Keywords invalid in statement functions

2018-02-22 Thread Thomas Koenig
Hi Steve, The attached patch fixes PR fortran/84346. A statement function always has an implicit interface. The use of keywords in a function with an implicit interface is invalid. Regression tested on x86_64-*-freebsd. OK to commit? OK. Thanks for the patch! Regards Thomas

Re: [PATCH] PR fortran/30792 -- Substring data-implied-do is invalid

2018-02-24 Thread Thomas Koenig
Hi Steve, The attached patch fixes PR fortran/30792. A substring reference is invalid for a data-implied-do. Regression tested on x86_64-*-freebsd. OK to commit. This should be safe enough, OK for trunk. Thanks for the patch! Regards Thomas

[patch, fortran] Fix PR 78238, ICE with SELECT TYPE with -fdefault-integer-8

2018-02-24 Thread Thomas Koenig
Hello world, the attached patch fixes a 7/8 regression with SELECT TYPE where the constant had the wrong type with -fdefault-integer-8. Regression-tested. OK for trunk and gcc-7? Regards Thomas 2018-01-24 Thomas Koenig PR fortran/78238 * gfortran.h

Re: [Patch fortran] PR32957 - C/Fortran interoperability and -fdefault-integer-8

2018-02-25 Thread Thomas Koenig
Hi Dominique, OK for trunk? back port? OK for trunk. The tests were non-conforming before, so this is also a step in making our testsuite better. For gcc-7, I'm not sure I would bother, but OK if you want to do it. Regards Thomas

Re: [PATCH,PTX] Add support for CUDA 9

2018-02-27 Thread Thomas Schwinge
le mode 100644 > > index 000..39992a7137b > > --- /dev/null > > +++ b/gcc/testsuite/gcc.target/nvptx/indirect_call.c > > @@ -0,0 +1,19 @@ > > +/* { dg-options "-O2 -msoft-stack" } */ > > +/* { dg-do run } */ > > + > > +int > > +f1 (int a) > > +{ > > + return a + 1; > > +} > > + > > +int (*f2)(int) = f1; > > + > > +int > > +main () > > +{ > > + if (f2 (100) != 101) > > +__builtin_abort(); > > + > > + return 0; > > +} Grüße Thomas

[PATCH, arm-embedded] Multilib mapping for Armv8-R

2018-02-27 Thread Thomas Preudhomme
instead to the existing Armv7 multilibs. Note that mapping for single-precision Armv8-R has been left out due to there being no Arm implementation of that architecture variant. Changelog entry is as follows: *** gcc/ChangeLog *** 2018-02-26 Thomas Preud'homme * config/arm/t-rmpr

[arm-embedded] Allow -mcpu=cortex-m33+nodsp

2018-02-27 Thread Thomas Preudhomme
-02-26 Thomas Preud'homme * config/arm/arm-cpus.in (cortex-m33+nodsp): New CPU. * config/arm/arm-cpu-cdata.h: Regenerate. * config/arm/arm-cpu-data.h: Likewise. * config/arm/arm-cpu.h: Likewise. * config/arm/arm-tables.opt: Likewise. * config/ar

Re: [PATCH, GCC/testsuite] Fix dump-noaddr dumpbase

2018-03-01 Thread Thomas Preudhomme
Finally committed to gcc-7-branch, sorry for doing this so late. I've merged the two commits into one. Patch attached for reference. Best regards, Thomas On 05/12/17 21:26, Mike Stump wrote: On Dec 5, 2017, at 12:56 PM, Thomas Preudhomme wrote: Thanks, I've tested after the t

[PATCH, GCC/testsuite/ARM] Fix copysign_softfloat_1.c option directives

2018-03-01 Thread Thomas Preudhomme
at is enough to select Thumb-2. This fixes warning on the command line when having -mcpu=cortex-m3 in RUNTESTFLAGS for instance. ChangeLog entry is as follows: *** gcc/testsuite/ChangeLog *** 2018-03-01 Thomas Preud'homme diff --git a/gcc/testsuite/gcc.target/arm/copysign_softfloat_1.c b/gcc

Re: [PATCH] PR fortran/51434 -- ICE in gfc_simplify_transfer

2018-03-01 Thread Thomas Koenig
Hi Steve, 2018-02-26 Steven G. Kargl PF fortran/51434 * simplify.c (gfc_simplify_transfer): Reduce mold. I think this should be "Resolve" (at least that is what your patch shows). OK for trunk, thanks for the patch! Regards Thomas

Re: [PATCH,PTX] Add support for CUDA 9

2018-03-02 Thread Thomas Schwinge
Hi! On Tue, 27 Feb 2018 15:12:47 +0100, Richard Biener wrote: > On Tue, 27 Feb 2018, Thomas Schwinge wrote: > > Given that several users have run into this, is this (trunk r256891) OK > > to commit to open release branches, too. > > Sure. Committed to gcc-7-branc

Re: [PATCH] Fix test-suite fallout of default -Wreturn-type.

2018-03-02 Thread Thomas Schwinge
Hi! On Mon, 20 Nov 2017 09:11:19 -0500, Jason Merrill wrote: > On Sun, Nov 19, 2017 at 7:56 AM, Thomas Schwinge > wrote: > > OK to fix the first four issues as follows? > > OK. > > Reviewed-by: Jason Merrill Better late than never, committed to t

Re: [patch] remove cilk-plus

2018-03-02 Thread Thomas Schwinge
cc/c-family/ChangeLog | 5 + gcc/c-family/c-attribs.c| 2 -- gcc/doc/invoke.texi | 4 ++-- 6 files changed, 16 insertions(+), 6 deletions(-) diff --git contrib/ChangeLog contrib/ChangeLog index 627cafd..6bb3b6f 100644 --- contrib/ChangeLog +++ contrib/ChangeLog @

Re: [PATCH][OBVIOUS] Fix ifunc detection.

2018-03-02 Thread Thomas Schwinge
> + F* g (void) { return 0; } > void f () __attribute__ ((ifunc ("g"))); > #ifdef __cplusplus > } Is it OK to "return 0" from this ifunc handler, or might some analysis in GCC trip over that (at some later point)? In my patch, I returned the address of an "extern" function. Grüße Thomas

Re: [PATCH] PR fortran/56667 -- Issue a sane error message

2018-03-05 Thread Thomas Koenig
. Regression tested on x86_64-*-freebsd. OK for trunk. Thanks for the patch! Regards Thomas

[patch, fortran] Fix PR 84697

2018-03-06 Thread Thomas Koenig
this is committed, I'll also look if there is anything left in PR66128, and close that bug if appropriate Regression-tested. OK for trunk? 2017-03-06 Thomas Koenig PR fortran/84697 PR fortran/66128 * expr.c (simplify_parameter_variable): If p is a size zero

Re: [og7] vector_length extension part 1: generalize function and variable names

2018-03-09 Thread Thomas Schwinge
|| (mask & GOMP_DIM_MASK (GOMP_DIM_VECTOR))); > + gcc_assert (!(oa.mask & GOMP_DIM_MASK (GOMP_DIM_WORKER)) > + || (oa.mask & GOMP_DIM_MASK (GOMP_DIM_VECTOR))); > >/* Discover & process partitioned regions. */ >parallel *pars = nvptx_discover_pars (&bb_insn_map); >nvptx_process_pars (pars); > - nvptx_neuter_pars (pars, mask, 0); > + nvptx_neuter_pars (pars, oa.mask, 0); >delete pars; > } Grüße Thomas

[patch, fortran] Some more corrections to zero-size simplification

2018-03-11 Thread Thomas Koenig
Hello world, the attached patch fixes a few corner cases of a corner case in simplification, i.e. empty arrays where array intrinsics can actually have a non-empty array result. Regression-tested. OK for trunk? Regards Thomas 2017-06-11 Thomas Koenig PR fortran/66128

[PATCH, GCC/testsuite] Fix FAIL display for some scan-*-times directives

2018-03-13 Thread Thomas Preudhomme
with -v. ChangeLog entry is as follows: *** gcc/testsuite/ChangeLog *** 2018-03-13 Thomas Preud'homme * lib/scanasm.exp (scan-assembler-times): Move FAIL debug info into a separate verbose message. * lib/scandump.exp (scan-dump-times): Likewise. Testing: M

[arm-embedded][PATCH] Add multilib mapping for -mcpu=cortex-m33+nodsp

2018-03-15 Thread Thomas Preudhomme
appropriate mapping. ChangeLog entry is as follows: *** gcc/ChangeLog.arm *** 2018-03-14 Thomas Preud'homme * config/arm/t-rmprofile: Add mapping from -mcpu=cortex-m33+nodsp to -march=armv8-m.main. Testing: A hello world fails to link without the patch with a multilib

[arm-embedded][PATCH] Add multilib mapping for -mcpu=cortex-r52

2018-03-15 Thread Thomas Preudhomme
/ChangeLog.arm *** 2018-03-15 Thomas Preud'homme * config/arm/t-rmprofile: Add mapping from -mcpu=cortex-r52 to -march=armv7. Testing: -mcpu=cortex-r52 -print-multi-directory prints . (ie. default mutlilib) without the patch with a multilib build but prints the expected thumb/

Re: [PATCH] PR fortran/69395 -- don't exceed max allowed array dimensions

2018-03-15 Thread Thomas Koenig
Hi Steve, The attachedi patch detects situations where the sum of an array's rank and corank exceeds the maximum allowed by the Standard. Regression tested on x86_64-*-freebsd. OK for trunk. Thanks for the patch! Regards, Thomas

Re: [og7] vector_length extension part 5: libgomp and tests

2018-03-16 Thread Thomas Schwinge
re is precedent for the nvptx BE to emit a warning when > vector length != 32, but that might be too verbose. On one hand, it > could be argued that the compiler should error if it cannot satisfy the > user's request. On the other hand, falling back to a smaller vector > length

Re: [PATCH] PR fortran/65453 -- procedure statement vs subprogram name clash

2018-03-18 Thread Thomas König
Hi Steve, The attached patch fixes an ICE by detecting a name clash between a procedure statement and a contained subprogram. Regression tested on x86_64-*-freebsd. The patch is OK. Thanks! Regards Thomas (In case anybody is wondering about my e-mail address: I have a new one and

Re: [PATCH] PR fortran/77414 -- catch re-declaration of subroutines

2018-03-18 Thread Thomas Koenig
Hi Steve, The attached patch fixes an ICE by reporting an error for the re-declaration of a subroutine by trying to include itself as an internal subprogram. Regression tested on x86_64-*-freebsd and i568-*-freebsd. OK to commit? Also ok. Thanks for the patch! Regards Thomas

[patch, fortran] Fix type conversion in large array constructors with iterators

2018-03-18 Thread Thomas König
-code issue. Regards Thomas 2018-03-18 Thomas Koenig PR fortran/84931 * simplify.c (gfc_convert_constant): Correctly handle iterators for type conversion. 2018-03-18 Thomas Koenig PR fortran/84931 * gfortran.dg/array_constructor_52.f90: New

Re: [PATCH, fortran] PR84957 - [8 Regression] ICE in gfc_sym_type, at fortran/trans-types.c:2255

2018-03-21 Thread Thomas Koenig
Hi Harald, The attached obvious patch fixes a NULL pointer dereference. Testcase derived from report. Changelogs below. Regtested on i686-pc-linux-gnu. Whoever reviews this, please feel free to commit. Reviewed and committed as r258745. Thanks for the patch! Regards Thomas

Re: [PATCH] PR fortran/42651 -- Fix accepts-invalid

2018-03-22 Thread Thomas Koenig
Hi Steve, ping Pong! OK for trunk, and thanks for the patch. Regards Thomas

[patch, fortran] Fix empty substrings when simplifying

2018-03-24 Thread Thomas Koenig
Hell world, the attached patch is fairly self-explanatory, it fixes an out-of-memory condition. Regression-tested. OK for trunk? Regards Thomas 2018-03-24 Thomas Koenig PR fortran/70068 * expr.c (find_substring_ref): Change types of start, end and length

Re: [patch, fortran] Fix empty substrings when simplifying

2018-03-24 Thread Thomas Koenig
Am 24.03.2018 um 16:18 schrieb Jerry DeLisle: On 03/24/2018 05:46 AM, Thomas Koenig wrote: Hell world, the attached patch is fairly self-explanatory, it fixes an out-of-memory condition. Regression-tested. OK for trunk? Yes, and thanks for fix. Committed as r258835, with Steve&#

[patch, fortran] Simplify constants which come from parameter arrays

2018-03-25 Thread Thomas König
Hello world, the attached patch potentially saves some space in the object file by simplifying access to individual elements of a parameter array, which means that the original parameter may not be needed any more. Regression-tested. OK for trunk? Regards Thomas 2018-03-25 Thomas

Re: [patch fortran] PR 84924 - Erroneous error in C_F_POINTER

2018-03-25 Thread Thomas König
Hi Dominique, The attached patch allows scalar noninteroperable scalar derived type with -std=f2003 and -std=f2008. Regstrapped on x86_64-apple-darwin17. OK for trunk? OK. Regards Thomas

[patch, libgomp testsuite] Replace non-standard call abort by STOP n

2018-03-25 Thread Thomas Koenig
[This is take two, the first one was rejected due to size]. Hello world, the does what the ChangeLog and the Subject say. Regression-tested on x86_64-pc-linux-gnu. OK for trunk? Regards Thomas 2018-03-25 Thomas Koenig PR fortran/84381 * testsuite/libgomp.fortran

[patch, fortran] Fix character parameter arrays as formats

2018-03-25 Thread Thomas Koenig
Hello world, the attached pach fixes the PR by creating one single big string from a parameter array. OK for trunk? Regards Thomas 2018-03-25 Thomas Koenig PR fortran/66709 * io.c: Include constructor.h. (resolve_tag_format): For a constant character array

Re: [Patch, fortran] PR84931 - Expansion of array constructor with constant implied-do-object goes sideways

2018-03-25 Thread Thomas König
. Regards Thomas

Re: [PATCH, fortran] PR85083 - [8 Regression] ICE in gfc_convert_to_structure_constructor, at fortran/primary.c:2915

2018-03-27 Thread Thomas Koenig
changed the test case name to structure_constructor_15.f90 because this sort of name allows running tests on a meaningful subset of interest, for example with make check-fortran RUNTESTFLAGS="dg.exp=gfortran.dg/*constructor*". Thanks a lot for the patch! Regards Thomas

[patch, fortran, committed] Fix error caused by running front-end optimizatins after error

2018-03-27 Thread Thomas König
ected branches, gcc-7 and gcc-6, over the next few days. Regards Thomas 2018-03-27 Thomas Koenig PR fortran/85084 * frontend-passes.c (gfc_run_passes): Do not run front-end optimizations if a previous error occurred. 2018-03-27 Thomas Koenig PR fortran/

[patch, fortran] Fix PR 85111, some more zero size stuff

2018-03-29 Thread Thomas Koenig
Hello world, the attached patch fixes PR 85111, a regression introduced with my recent simplification patches. Seems like the zero-size saga has yet another chapter :-) Regression-tested. OK for trunk? Regards Thomas 2017-03-29 Thomas Koenig PR fortran/85111

[patch, fortran, testsuite, committed] Remove illegal code from substr_6.f90

2018-03-30 Thread Thomas Koenig
, has been committed as obvious. What's left is the accepts-invalid bug. Regards Thomas 2018-03-30 Thomas Koenig PR fortran/85130 * gfortran.dg/substr_6.f90: Remove illegal test for out-of-bounds substring. Index: gfortran.

Re: [patch, fortran] Simplify constants which come from parameter arrays

2018-03-31 Thread Thomas König
.f90 (PR85130), and the error is now suppressed in the attached patch. Re-regression-tested. OK for trunk? Regards Thomas 2018-03-25 Thomas Koenig PR fortran/51260 * resolve.c (resolve_variable): Simplify cases where access to a parameter array results in a

[patch, fortran] Fix PR 85102

2018-04-01 Thread Thomas Koenig
Hello world, this is a minimal-invasive patch to fix the case where array specs starting with a parenthesis were not handled correctly. Regression-tested. OK for trunk? Regards Thomas 2018-04-01 Thomas Koenig PR fortran/85102 * array.c (strip_parens): New function

Re: [patch, fortran] Fix PR 85102

2018-04-01 Thread Thomas Koenig
Hi everybody, Regression-tested. OK for trunk? Not OK, since it misses integer, parameter :: a((1+1)+1) = 1 as asked by Dominique on IRC. Good catch! I'll look at this tomorrow. Regards thomas

[patch, fortran] Fix PR 85102, take 2

2018-04-02 Thread Thomas König
h my first patch. Regression-tested. OK for trunk? Regards Thomas 2018-04-02 Thomas Koenig PR fortran/85102 * decl.c (variable_decl): If upper or lower bounds simplify to a constant, use that. 2018-04-02 Thomas Koenig PR fortran/85102 * g

Re: [patch, fortran] Fix PR 85102, take 2

2018-04-02 Thread Thomas König
Hi Steve, else gfc_free_expr (n); Don't you need the above changes to avoid leaking memory? Correct. OK with those changes? Regards Thomas

Re: [patch, fortran] Simplify constants which come from parameter arrays

2018-04-03 Thread Thomas König
n adding the -Wdo-subsript code, and I think we should fix this, but not in time for gcc 8. Suggested way forward: Apply the patch as is and open an PR to sort out the warning/error stuff for out-of-bounds access to be resolved consistently for gcc-9. OK? Regards Thomas

[patch, libfortran, committed] Implement stop_numeric for minimal targets

2018-04-04 Thread Thomas König
after Tom de Vries had confirmed that it solves the problem. Regards Thomas 2018-04-04 Thomas Koenig PR libfortran/85166 * runtime/minimal.c (stop_numeric): Add new function in order to implement numeric stop on minimal targets. Index: runtime/minimal.c

[PATCH, GCC/ARM] Fix PR85203: cmse_nonsecure_caller returns wrong result

2018-04-04 Thread Thomas Preudhomme
ngeLog entry is as follows: *** gcc/ChangeLog *** 2018-04-04 Thomas Preud'homme PR target/85203 * config/arm/arm-builtins.c (arm_expand_builtin): Change expansion to perform a bitwise AND of the argument followed by a boolean negation of the result. *** gcc

Re: [PATCH, GCC/ARM] Fix PR85203: cmse_nonsecure_caller returns wrong result

2018-04-04 Thread Thomas Preudhomme
Oops, forgot the link. On 04/04/18 18:03, Thomas Preudhomme wrote: Hi, __builtin_cmse_nonsecure_caller implementation returns true in almost all cases due to 2 separate bugs: * gen_addsi is used instead of gen_andsi to retrieve the lsb * the lsb boolean value is not negated but the

Re: [PATCH, GCC/ARM] Fix PR85203: cmse_nonsecure_caller returns wrong result

2018-04-04 Thread Thomas Preudhomme
Hi Kyrill, On 04/04/18 18:19, Kyrill Tkachov wrote: Hi Thomas, On 04/04/18 18:03, Thomas Preudhomme wrote: Hi, __builtin_cmse_nonsecure_caller implementation returns true in almost all cases due to 2 separate bugs: * gen_addsi is used instead of gen_andsi to retrieve the lsb * the lsb

Re: [PATCH, GCC/ARM] Fix PR85203: cmse_nonsecure_caller returns wrong result

2018-04-05 Thread Thomas Preudhomme
Hi Kyrill, On 04/04/18 18:20, Thomas Preudhomme wrote: Hi Kyrill, On 04/04/18 18:19, Kyrill Tkachov wrote: Hi Thomas, On 04/04/18 18:03, Thomas Preudhomme wrote: Hi, __builtin_cmse_nonsecure_caller implementation returns true in almost all cases due to 2 separate bugs: * gen_addsi is used

[PATCH, GCC/ARM] Fix PR85261: ICE with FPSCR setter builtin

2018-04-06 Thread Thomas Preudhomme
value into a register. It also remove the unneeded volatile in the existing fpscr test and fixes the function prototype. ChangeLog entries are as follows: *** gcc/ChangeLog *** 2018-04-06 Thomas Preud'homme PR target/85261 * config/arm/arm-builtins.c (arm_expand_builtin):

Re: [PATCH, GCC/ARM] Fix PR85261: ICE with FPSCR setter builtin

2018-04-06 Thread Thomas Preudhomme
On 06/04/18 17:08, Ramana Radhakrishnan wrote: On 06/04/2018 16:54, Thomas Preudhomme wrote: Instruction pattern for setting the FPSCR expects the input value to be in a register. However, __builtin_arm_set_fpscr expander does not ensure that this is the case and as a result GCC ICEs when the

[patch, libfortran] Fix PR 88235, buffer overrun in matmul

2018-04-06 Thread Thomas König
Hello world, the attached patch fixes a buffer overrun in matmul, an 8 regression. No test case since this was only detectable with the address sanitizer or with valgrind. Regression-tested on trunk. OK? Regards Thomas 2018-04-06 Thomas Koenig PR libfortran/85253

[patch, middle-end] Fix PR 82976, non-trivial conversion at assignment

2018-04-07 Thread Thomas König
for trunk? Regards Thomas 2018-04-07 Thomas Koenig Andrew Pinski PR middle-end/82976 * match.pd: Use constant_boolean_node of correct type instead of boolean_true_node or boolean_false_node for simplifying pointer comparisons to zero. 2018-

Re: [PATCH, GCC/ARM] Fix PR85261: ICE with FPSCR setter builtin

2018-04-09 Thread Thomas Preudhomme
Hi Ramana, On 06/04/18 17:17, Thomas Preudhomme wrote: On 06/04/18 17:08, Ramana Radhakrishnan wrote: On 06/04/2018 16:54, Thomas Preudhomme wrote: Instruction pattern for setting the FPSCR expects the input value to be in a register. However, __builtin_arm_set_fpscr expander does not

[patch, fortran] Remove parallell annotation from DO CONCURRENT

2018-04-09 Thread Thomas Koenig
. Regression-tested. OK for trunk? Regards Thomas 2018-04-09 Thomas Koenig PR fortran/83064 * trans-stmt.c (gfc_trans_forall_loop): Remove annotation for parallell processing of DO CONCURRENT. 2018-04-09 Thomas Koenig PR fortran/83064

Re: [patch, fortran] Remove parallell annotation from DO CONCURRENT

2018-04-09 Thread Thomas Koenig
Hi Steve, On Mon, Apr 09, 2018 at 10:10:13PM +0200, Thomas Koenig wrote: the attached patch removes the parallel annotation from DO CONCURRENT. As discussed in the PR, the autoparallellizer currently generates wrong code. The only feasible way is to disable the annotation for gcc-8 and work

<    17   18   19   20   21   22   23   24   25   26   >