nvptx, libgfortran: Switch out of "minimal" mode

2024-06-06 Thread Thomas Schwinge
es that I shall detail at some later point in time.) (No progress.) Pushed to trunk branch commit 3a4775d4403f2e88b589e88a9937cc1fd45a0e87 'nvptx, libgfortran: Switch out of "minimal" mode', see attached. This, unsurprisingly, also greatly improves GCC/Fortran test results fo

Re: [PATCH 6/6] Add a late-combine pass [PR106594]

2024-06-25 Thread Thomas Schwinge
s = 0; > + >rs6000_override_options_after_change (); ..., this needs to be done in 'rs6000_override_options_after_change' instead of 'rs6000_option_override_internal', to address the PRs under discussion. I'm testing such a patch. Grüße Thomas

rs6000: Properly default-disable late-combine passes [PR106594, PR115622, PR115633] (was: [PATCH 6/6] Add a late-combine pass [PR106594])

2024-06-25 Thread Thomas Schwinge
Hi! On 2024-06-25T10:07:47+0100, Richard Sandiford wrote: > Thomas Schwinge writes: >> On 2024-06-20T14:34:18+0100, Richard Sandiford >> wrote: >>> This patch adds a combine pass that runs late in the pipeline. >>> [...] >> >> Nice! >> >&

Re: [PATCH][v2] Support single def-use cycle optimization for SLP reduction vectorization

2024-06-25 Thread Thomas Schwinge
[...] [...]/gcc.dg/vect/slp-reduc-12.c:10:21: optimized: loop vectorized using 256 byte vectors [...] [...]/gcc.dg/vect/slp-reduc-12.c:10:21: note: Reduce using direct vector reduction. [...]/gcc.dg/vect/slp-reduc-12.c:10:21: note: vectorizing stmts using SLP. [...] How to

[PATCH] nvptx: Specify '-mno-alias' for 'gcc.dg/pr60797.c' [PR60797, PR104957] (was: [PATCH] Fix PR60797)

2024-07-22 Thread Thomas Schwinge
to 'dg-skip-if' -- unless there's a way to disable this support, which there is for GCC/nvptx: '-mno-alias'. OK to push the attached "nvptx: Specify '-mno-alias' for 'gcc.dg/pr60797.c' [PR60797, PR104957]"? Grüße Thomas >From 7236549

Re: [C++ coroutines 6/6] Testsuite.

2024-07-29 Thread Thomas Schwinge
per my experience at least? Should we therefore add a short rationale comment to the 'find' in 'g++.dg/coroutines/coroutines.exp', why 'g++.dg/coroutines/torture/' test cases are not being filtered out there, despite more specific 'g++.dg/coroutines/torture/coro-tort

Re: [PATCH v1 1/2] PR116080: Fix tail call dejagnu checks

2024-07-29 Thread Thomas Schwinge
c -fplugin=./must_tail_call_plugin.so (test for errors, line 49)-] [-PASS: gcc.dg/plugin/must-tail-call-2.c -fplugin=./must_tail_call_plugin.so (test for errors, line 58)-] [-PASS: gcc.dg/plugin/must-tail-call-2.c -fplugin=./must_tail_call_plugin.so (test for excess errors)-] Similarly for ppc64le GNU/Linux. Is that intentional? Grüße Thomas

Re: [PATCHv2 2/2] libiberty/buildargv: handle input consisting of only white space

2024-07-29 Thread Thomas Schwinge
f (*argvp == original_argv) > *argvp = dupargv (*argvp); With that (single) use of 'only_whitespace' now gone: [...]/source-gcc/libiberty/argv.c:128:1: warning: ‘only_whitespace’ defined but not used [-Wunused-function] 128 | only_whitespace (const char* input) | ^~~ Grüße Thomas

Polish libstdc++ 'dg-final' action 'file-io-diff' (was: [PATCH 4/8] libstdc++: Add file-io-diff to replace @diff@ markup in I/O tests)

2024-07-29 Thread Thomas Schwinge
S: [...] file-io-diff [...]' appear, and the unspecific 'FAIL: files differ' (near the end) turn into specific: FAIL: 27_io/basic_istream/extractors_other/char/2.cc -std=gnu++17 file-io-diff istream_extractor_other-2 (Again, that FAIL's injected for demonstration purpo

Re: [PATCH] fortran: Support optional dummy as BACK argument of MINLOC/MAXLOC.

2024-08-01 Thread Thomas Koenig
ress... Best regards Thomas

Don't override 'LIBS' if '--enable-languages=rust'; use 'CRAB1_LIBS' (was: [PATCH 005/125] gccrs: libgrust: Add format_parser library)

2024-08-05 Thread Thomas Schwinge
f29b2b033f5b136 "Don't override 'LIBS' if '--enable-languages=rust'; use 'CRAB1_LIBS'", see attached. Grüße Thomas >From 816c4de4d062c89f5b7a68f68f29b2b033f5b136 Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Mon, 5 Aug 2024 10:06:05 +0200 Su

Inline 'gcc/rust/Make-lang.in:RUST_LIBDEPS' (was: [PATCH 006/125] gccrs: Add 'gcc/rust/Make-lang.in:LIBFORMAT_PARSER')

2024-08-05 Thread Thomas Schwinge
hed to trunk branch commit aab9f33ed1f1b92444a82eb3ea5cab1048593791 "Inline 'gcc/rust/Make-lang.in:RUST_LIBDEPS'", see attached -- this commit apparently had been omitted from the 2024-08-01 upstream submission. Grüße Thomas >From aab9f33ed1f1b92444a82eb3ea5cab1048593791 M

Re: [PATCH 0/8] fortran: Inline MINLOC/MAXLOC without DIM argument [PR90608]

2024-08-06 Thread Thomas Koenig
gards Thomas

Re: [Patch] libgomp: Fix declare target link with offset array-section mapping [PR116107]

2024-08-07 Thread Thomas Schwinge
__builtin_abort (); + + #pragma omp target exit data map(release:arr[3:10]) device(dev) } return 0; } ... was missing, but that doesn't resolve the issue: same error state. Could you please have a look what other state needs to be reset, in which w

Re: [PATCH] PR116080: Fix test suite checks for musttail

2024-08-07 Thread Thomas Schwinge
ptimize the call into a sibling call (Again, I'm just mentioning the latter "regressions" in case those are unexpected.) So: looks good, all FAILs resolved (in these GCC configurations). Grüße Thomas > This is a new attempt to fix PR116080. The previous try was reverted &g

Re: [PATCH, OpenACC 2.7, v3] Adjust acc_map_data/acc_unmap_data interaction with reference counters

2024-04-12 Thread Thomas Schwinge
Hi Chung-Lin! On 2024-04-11T22:08:47+0800, Chung-Lin Tang wrote: > On 2024/3/15 7:24 PM, Thomas Schwinge wrote: >> - if (n->refcount != REFCOUNT_INFINITY) >> + if (n->refcount != REFCOUNT_INFINITY >> + && n->refcount != RE

Re: [PATCH] contrib/check-params-in-docs.py: Ignore target-specific params

2024-04-12 Thread Thomas Schwinge
Hi! On 2024-04-12T09:08:13+0200, Filip Kastl wrote: > On Thu 2024-04-11 20:51:55, Thomas Schwinge wrote: >> On 2024-04-11T19:52:51+0200, Martin Jambor wrote: >> > contrib/check-params-in-docs.py is a script that checks that all >> > options reported with ./gcc/xgc

Re: [PATCH] Regenerate opt.urls

2024-04-12 Thread Thomas Schwinge
rs -- I think the actual contents are the same, but > I didn't actually run the regenerate script. So > > Reviewed-by: Palmer Dabbelt > Acked-by: Palmer Dabbelt ..., I've now pushed this to trunk branch in commit c9500083073ff5e0f5c1c9db92d7ce6e51a62919 "Regenerate opt.urls". Grüße Thomas

Re: [nvptx PATCH] Correct pattern for popcountdi2 insn in nvptx.md.

2024-04-12 Thread Thomas Schwinge
ocating proper time for better learning GCC back end. But, fortunately, we've been able to switch employers! Grüße Thomas > 2023-01-09 Roger Sayle > > gcc/ChangeLog > * config/nvptx/nvptx.md (popcount2): Split into... > (popcountsi2): define_insn handling SImode

Re: [gcc r14-7544] gccrs: libproc_macro: Build statically

2024-04-15 Thread Thomas Schwinge
'libgrust/libproc_macro_internal' from 'gcc/rust/Make-lang.in:RUST_LDFLAGS'" - commit f7c8fa7280c85cbdea45be9c09f36123ff16a78a "Inline 'gcc/rust/Make-lang.in:RUST_LDFLAGS' into single user" - commit 24d92f65f9ed9b3c730c59f700ce2f5c038c8207 "

Re: [PATCH] build: Check for cargo when building rust language

2024-04-15 Thread Thomas Schwinge
'? (We always want plain 'cargo', not host-prefixed 'aarch64-linux-gnu-cargo' etc., right?) I'll look into changing this. Grüße Thomas > Prevent rust language from building when cargo is > missing. > > config/ChangeLog: > >

build: Don't check for host-prefixed 'cargo' program (was: [PATCH] build: Check for cargo when building rust language)

2024-04-15 Thread Thomas Schwinge
t; I now wonder: instead of 'AC_CHECK_TOOL', shouldn't this use > 'AC_CHECK_PROG'? (We always want plain 'cargo', not host-prefixed > 'aarch64-linux-gnu-cargo' etc., right?) I'll look into changing this. OK to push "build: Don't chec

build: Use of cargo not yet supported here in Canadian cross configurations (was: [PATCH] build: Check for cargo when building rust language)

2024-04-15 Thread Thomas Schwinge
OK to push the attached "build: Use of cargo not yet supported here in Canadian cross configurations"? Grüße Thomas >From eb38990b4147951dd21f19def43072368f782af5 Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Mon, 15 Apr 2024 14:27:45 +0200 Subject: [PATCH] build: Use

GCN: Enable effective-target 'vect_long_long'

2024-04-16 Thread Thomas Schwinge
Hi! OK to push the attached "GCN: Enable effective-target 'vect_long_long'"? (Or is that not what you'd expect to see for GCN? I haven't checked the actual back end code...) Grüße Thomas >From d74cc9caadfe36652503782a8da172ae1975915c Mon Sep 17 00:00:00 2001

Re: [PATCH] rtlanal: Fix set_noop_p for volatile loads or stores [PR114768]

2024-04-19 Thread Thomas Schwinge
596 +0200 +++ ./pr114768.s2024-04-19 12:08:00.118312524 +0200 @@ -13,5 +13,10 @@ { .reg.u64 %ar0; ld.param.u64 %ar0, [%in_ar0]; + .reg.u32 %r22; + .reg.u64 %r23; + mov.u64 %r23, %ar0; + ld.u32 %r22, [%r23]; + st.u32 [%r23], %r22; ret; } Grüße Thomas

Enable 'gcc.dg/pr114768.c' for nvptx target [PR114768] (was: [PATCH] rtlanal: Fix set_noop_p for volatile loads or stores [PR114768])

2024-04-19 Thread Thomas Schwinge
Hi! On 2024-04-19T12:30:25+0200, Jakub Jelinek wrote: > On Fri, Apr 19, 2024 at 12:23:03PM +0200, Thomas Schwinge wrote: >> On 2024-04-19T08:24:03+0200, Jakub Jelinek wrote: >> > --- gcc/testsuite/gcc.dg/pr114768.c.jj 2024-04-18 15:37:49.139433678 >> > +0200 &g

Re: [nvptx] Fix code-gen for alias attribute

2024-09-04 Thread Thomas Schwinge
lias_target_node->decl); >NVPTX_ASM_OUTPUT_DEF (stream, IDENTIFIER_POINTER (id), > - IDENTIFIER_POINTER (value)); > + IDENTIFIER_POINTER (alias_target_id)); > } > > #undef NVPTX_ASM_OUTPUT_DEF Please put some rationale comment before the 'ultimate_alias_target'. All that said, I'm currently working on <https://gcc.gnu.org/PR105018> "[nvptx] Need better alias support", via <https://github.com/SourceryTools/nvptx-tools/issues/32> "[LD] Handle alias in nvptx-ld as nvptx's .alias does not handle it fully". Grüße Thomas

Add 'gcc.target/nvptx/alias-weak-1.c' (was: [nvptx] Fix code-gen for alias attribute)

2024-09-04 Thread Thomas Schwinge
cef7b462f2bb2128bc8ace30 "Add 'gcc.target/nvptx/alias-weak-1.c'", see attached. Grüße Thomas >From 2267d254eb6ad782cef7b462f2bb2128bc8ace30 Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Wed, 4 Sep 2024 09:58:32 +0200 Subject: [PATCH] Add 'gcc.target/nvptx/a

Add 'gcc.target/nvptx/alias-to-alias-1.c' (was: [nvptx] Fix code-gen for alias attribute)

2024-09-04 Thread Thomas Schwinge
a 'ultimate_alias_target': + { dg-final { scan-assembler-times "\\.alias baz,foo;" 1 } } */ /* { dg-final { scan-assembler-times "\\.visible \\.func baz;" 1 } } */ Grüße Thomas >From a89321c890b96c583671b73fc802e87545e4a2b1 Mon Sep 17 00:00:00 2001 From:

[PING] Handle 'NUM' in 'PUSH_INSERT_PASSES_WITHIN' (was: [PATCH 03/11] Handwritten part of conversion of passes to C++ classes)

2024-09-04 Thread Thomas Schwinge
PUSH_INSERT_PASSES_WITHIN'"? > > This depends on > <https://inbox.sourceware.org/87jzi9tgcw@euler.schwinge.ddns.net> > "Rewrite usage comment at the top of 'gcc/passes.def'" to avoid running > into the 'ERROR: Can't locate [...]'

Fix gimple_debug_cfg declaration (was: [PATCH v2 2/N] Introduce dump_flags_t type and use it instead of int, type)

2024-09-04 Thread Thomas Schwinge
/gcc/tree-cfg.h | +++ b/gcc/tree-cfg.h | extern void gimple_debug_cfg (int); ..., and (unfortunately only) fixed that on a development branch. As obvious, I've now pushed to trunk branch commit 347a953d855c6b246b1604bdf4728f615cb471b6 "Fix gimple_debug_cfg declaration", see a

Fix branch prediction dump message (was: Predict loops containing recursive call with fewer iterations)

2024-09-04 Thread Thomas Schwinge
ed this (unfortunately only) on a development branch. As obvious, I've now pushed to trunk branch commit 35e4414bac06927387fb7a6fe10b373e766da1c1 "Fix branch prediction dump message", see attached. Grüße Thomas >From 35e4414bac06927387fb7a6fe10b373e766da1c1 Mon Sep 17 00:00:00 20

nvptx: Use 'enum ptx_version', 'enum ptx_isa' instead of 'int'

2024-09-04 Thread Thomas Schwinge
Hi! Pushed to trunk branch in commit fee2fbedbb43ad7a017a33ed2b820be79b75e7e5 "nvptx: Use 'enum ptx_version', 'enum ptx_isa' instead of 'int'", see attached. Grüße Thomas >From fee2fbedbb43ad7a017a33ed2b820be79b75e7e5 Mon Sep 17 00:00:00 2001 From:

Re: New version of unsiged patch

2024-09-05 Thread Thomas Koenig
Ping (a little bit)? With another weekend coming up, I would have some time to work on incorporating any feedback, or on putting in more intrinsics. Best regards Thomas

Move from 'gcc.target/nvptx/nvptx.exp' into 'target-supports.exp' additions for nvptx target (was: [PATCH] Make 'target-supports.exp' additions for nvptx target generally available)

2024-09-05 Thread Thomas Schwinge
branch commit a121af90fe9244258c8620901dd6fa22537767bb "Move from 'gcc.target/nvptx/nvptx.exp' into 'target-supports.exp' additions for nvptx target", see attached. Grüße Thomas >From a121af90fe9244258c8620901dd6fa22537767bb Mon Sep 17 00:00:00 2001 From: Thomas

Fix 'gcc.target/nvptx/alias-2.c' comment (was: [committed][nvptx] Use .alias directive for mptx >= 6.3)

2024-09-05 Thread Thomas Schwinge
t;\\.alias.*;" } } */ > +/* { dg-final { scan-assembler-not "\\.visible \\.func f;" } } */ > + > +/* Note static and inlined, so still there. */ > +/* { dg-final { scan-assembler-times "\\.visible \\.func __f;" 1 } } */ Actua

Re: [committed][nvptx] Use .alias directive for mptx >= 6.3

2024-09-05 Thread Thomas Schwinge
stringstream &s, bool is_defn, > const char *name, const_tree decl) > { > - write_fn_marker (s, is_defn, TREE_PUBLIC (decl), name); > + if (lookup_attribute ("alias", DECL_ATTRIBUTES (decl)) == NULL) > +write_fn_marker (s, is_defn, TREE_PUBLIC (decl), name); This non-emitting of DECL and DEF linker markers for aliases is problematic, as I'll discuss in the following. Grüße Thomas

Enhance 'gcc.target/nvptx/alias-*.c' assembler scanning (was: [committed][nvptx] Use .alias directive for mptx >= 6.3)

2024-09-05 Thread Thomas Schwinge
mmit d0f02538494ded78cac12c63f5708a53f5a77bda "Enhance 'gcc.target/nvptx/alias-*.c' assembler scanning", see attached. Grüße Thomas >From d0f02538494ded78cac12c63f5708a53f5a77bda Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Wed, 17 Jul 2024 15:27:51 +0200 Subject: [P

Add 'g++.target/nvptx/alias-g++.dg_init_dtor2-1.C' (was: Enhance 'gcc.target/nvptx/alias-*.c' assembler scanning (was: [committed][nvptx] Use .alias directive for mptx >= 6.3))

2024-09-05 Thread Thomas Schwinge
discuss in the following. > > First, to show what currently is (not) happening, I've pushed to trunk > branch commit d0f02538494ded78cac12c63f5708a53f5a77bda > "Enhance 'gcc.target/nvptx/alias-*.c' assembler scanning", see attached. Then, commit a1865fd33897bc6c6e010

nvptx: Emit DECL and DEF linker markers for aliases [PR104957] (was: Add 'g++.target/nvptx/alias-g++.dg_init_dtor2-1.C' (was: Enhance 'gcc.target/nvptx/alias-*.c' assembler scanning (was: [committed][

2024-09-05 Thread Thomas Schwinge
quot;Enhance 'gcc.target/nvptx/alias-*.c' assembler scanning", see attached. > > Then, commit a1865fd33897bc6c6e0109df0a12ee73ce386315 > "Add 'g++.target/nvptx/alias-g++.dg_init_dtor2-1.C'", see attached, as > one representative example of C++ code where

RE: [nvptx] Pass -m32/-m64 to host_compiler if it has multilib support

2024-09-06 Thread Thomas Schwinge
Hi! On 2024-08-16T15:36:29+, Prathamesh Kulkarni wrote: >> > Am 13.08.2024 um 17:48 schrieb Thomas Schwinge >> : >> > On 2024-08-12T07:50:07+, Prathamesh Kulkarni >> wrote: >> >>> From: Thomas Schwinge >> >>> Sent: Friday, Aug

Re: New version of unsiged patch

2024-09-07 Thread Thomas Koenig
d as array indices. which is clearer, I think. Best regards Thomas

Re: New version of unsiged patch

2024-09-07 Thread Thomas Koenig
_8 print *,12 u_8 print *,12u _8 print *,12u_ 8 end as unsigned_24.f, which passes, so that should be OK. Thanks for the review! Best regards Thomas

[patch, fortran] Matmul and dot_product for unsigned

2024-09-08 Thread Thomas Koenig
Hello world, like the subject says. The patch is gzipped because it is large; it contains multiple MATMUL library implementations. OK for trunk? Implement MATMUL and DOT_PRODUCT for unsgigned. gcc/fortran/ChangeLog: * arith.cc (gfc_arith_uminus): Fix warning. (gfc_arith_minus)

Match: Fix ordered and nonequal: Fix 'gcc.dg/opt-ordered-and-nonequal-1.c' re 'LOGICAL_OP_NON_SHORT_CIRCUIT' [PR116635] (was: [PATCH] Match: Fix ordered and nonequal)

2024-09-08 Thread Thomas Schwinge
h: Fix ordered and nonequal: Fix 'gcc.dg/opt-ordered-and-nonequal-1.c' re 'LOGICAL_OP_NON_SHORT_CIRCUIT' [PR116635]", see attached? Grüße Thomas >From 3e85cb373fb86db5fad86a452a69e713c7050f16 Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Mon, 9 Sep 2024 08:39:10

RE: [nvptx] Pass -m32/-m64 to host_compiler if it has multilib support

2024-09-09 Thread Thomas Schwinge
Hi Prathamesh! On 2024-09-09T06:31:18+, Prathamesh Kulkarni wrote: >> -Original Message- >> From: Thomas Schwinge >> Sent: Friday, September 6, 2024 2:31 PM >> On 2024-08-16T15:36:29+, Prathamesh Kulkarni >> wrote: >> >> > A

Re: [patch, fortran] Matmul and dot_product for unsigned

2024-09-09 Thread Thomas Koenig
ake a look if I can make it work. Best regards Thomas

Re: [patch, fortran] Matmul and dot_product for unsigned

2024-09-09 Thread Thomas Koenig
f rtype_name happens to match ^GFC_INTEGER, in matmul.m4. Best regards Thomas

RE: [nvptx] Pass -m32/-m64 to host_compiler if it has multilib support

2024-09-10 Thread Thomas Schwinge
Hi Prathamesh! On 2024-09-10T13:22:10+, Prathamesh Kulkarni wrote: >> -Original Message- >> From: Thomas Schwinge >> Sent: Monday, September 9, 2024 8:50 PM >> > Could you please test the patch for gcn backend ? I've successfully tested x86_6

[patch, fortran, committed] module support for UNSIGNED

2024-09-12 Thread Thomas Koenig
Hello world, I just pushed Steve's patch for module support to trunk as obvious, as https://gcc.gnu.org/g:2847a541c1f19b67ae84be8d0f6dc8e1f9371d16 . Best regards Thomas gcc/fortran/ChangeLog: * module.cc (bt_types): Add BT_UNSIGNED. gcc/testsuite/Chan

[patch, teststuite, Fortran, committed] Fix endianness issue on test case

2024-09-12 Thread Thomas Koenig
I just committed the fix for PR 116653 as obvious. Unfortunately, I left out the description in the ChangeLog, I hope it is clear enough. Best regards Thomas https://gcc.gnu.org/g:5d9486c29938d79beb798dce1a5509da54fe8c9f commit r15-3619-g5d9486c29938d79beb798dce1a5509da54fe8c9f

[Patch, Fortran] Implement Unsigned for SUM and PRODUCT

2024-09-14 Thread Thomas Koenig
data in SUM and PRODUCT in the integer library version, and call the integer library version for unsigned. Regression-tested. OK for trunk? Best regards Thomas gcc/fortran/ChangeLog: * gfortran.texi: Document SUM and PRODUCT. * iresolve.cc (resolve_transformational): New

Re: [Patch, Fortran] Implement Unsigned for SUM and PRODUCT

2024-09-14 Thread Thomas Koenig
As Jerry wrote (thanks!), this was missing the attached patch. Best regards Thomasdiff --git a/gcc/fortran/gfortran.texi b/gcc/fortran/gfortran.texi index 829ab00c665..e5ffe67 100644 --- a/gcc/fortran/gfortran.texi +++ b/gcc/fortran/gfortran.texi @@ -2788,7 +2788,7 @@ As of now, the

Re: libgomp: with USM, init 'link' variables with host address

2024-09-17 Thread Thomas Schwinge
Hi Tobias! On 2024-09-15T00:32:21+0200, Tobias Burnus wrote: > The idea of link variables is to replace he full device variable by a > pointer, permitting to map only parts of the variable to the device, > saving memory. > > However, having a pointer permits for (unified) shared memory to point

Re: [Patch, fortran] PR57798 uninitialized loop bound with sum and array-returning function.

2013-08-21 Thread Thomas Koenig
Hi Mikael, > Regression tested on x86_64-unknown-linux-gnu. OK for trunk/4.8? OK for both. Thanks for the patch! Thomas

[Patch, fortran] PR 52243 - avoid reallocation checks on assignment when possible

2013-08-28 Thread Thomas Koenig
Hello world, the attached patch avoids checks for reallocation on assignment when the same variable is on both sides of the assignment. Regression-tested. OK for trunk? Thomas 2013-08-29 Thomas Koenig PR fortran/52243 * trans-expr.c (is_runtime_conformable): New

[patch, fortran] PR 56519: Reject impure intrinsic subroutines in DO CONCURRENT

2013-08-29 Thread Thomas Koenig
Hello world, the attached patch rejects impure subroutines, such as RANDOM_NUMBER, within DO CONCURRENT. Regression-tested. OK for trunk? Regards Thomas 2013-08-29 Thomas Koenig PR fortran/PR56519 * gfortran.h: Declare gfc_do_concurrent_flag as extern

[patch, fortran, docs] Unformatted sequential and special files

2013-08-30 Thread Thomas Koenig
Hello world, the attached patch documents the format for unformatted sequential files and what is, and is not, supported with special files. Tested with "make dvi" and "make info". OK for trunk? Thomas 2013-08-30 Thomas Koenig PR fortran/30162

Re: [patch, fortran, docs] Unformatted sequential and special files

2013-09-01 Thread Thomas Koenig
. > - Special files which are special in other ways. E.g. block special > files tend to allow seeking, but IO must be block aligned. Also listed as not supported; I suspect buffering could cause grief there. I have updated an attached patch. OK? Thomas 2013-08-30 Thomas

*ping* [patch, fortran] PR 56519: Reject impure intrinsic subroutines in DO CONCURRENT

2013-09-02 Thread Thomas Koenig
Ping**0.5714 ? > the attached patch rejects impure subroutines, such as RANDOM_NUMBER, > within DO CONCURRENT. > > Regression-tested. OK for trunk?

Re: [patch, fortran, docs] Unformatted sequential and special files

2013-09-03 Thread Thomas Koenig
Any more suggestions? OK for trunk otherwise? Thomas Index: gfortran.texi === --- gfortran.texi (Revision 201996) +++ gfortran.texi (Arbeitskopie) @@ -1121,6 +1121,8 @@ * Internal representation of LOGICAL variables:: * T

gcc_GAS_FLAGS: Add more gcc_cv_as_flags overrides

2013-09-11 Thread Thomas Schwinge
ncompatible. +gcc_cv_as_flags=--x32 +;; + x86_64-*-linux*) +dnl Override the default, which may be incompatible. +gcc_cv_as_flags=--64 ;; powerpc*-*-darwin*) dnl Always pass -arch ppc to assembler. Grüße, Thomas pgpZ5wqwwOBcc.pgp Description: PGP signature

Re: gcc_GAS_FLAGS: Add more gcc_cv_as_flags overrides

2013-09-11 Thread Thomas Schwinge
Hi! On Wed, 11 Sep 2013 14:53:58 -0700, "H.J. Lu" wrote: > On Wed, Sep 11, 2013 at 2:23 PM, Thomas Schwinge > wrote: > > --- gcc/acinclude.m4 > > +++ gcc/acinclude.m4 > > @@ -444,8 +444,16 @@ AC_DEFUN([gcc_GAS_FLAGS], > > [AC_CACHE_CHECK([assembler flags

Re: [Ping^2 PATCH] VAX: Fix ICE during operand output

2013-09-13 Thread Matt Thomas
On Sep 13, 2013, at 4:21 AM, Jan-Benedict Glaw wrote: > On Wed, 2013-07-31 18:34:26 +0200, Jan-Benedict Glaw > wrote: >> We've seen ICEs while outputting an operand (not even the excessive >> CISC of a VAX could do that), which should be fixed by this patch: >> >> 2013-07-31 Jan-Benedict Gla

Re: [Patch, Fortran] PR57697 - Fix an issue with defined assignment

2013-09-15 Thread Thomas Koenig
to do this in the FE code, you might want to consider doing so. I would advise against spending a lot of work on this, though :-) Thomas

Re: [Patch, Fortran] PR57697 - Fix an issue with defined assignment

2013-09-15 Thread Thomas Koenig
uot;ax"! > > Build and regtested on x86-64-gnu-linux. > OK? The patch is OK, also for 4.8. Please add a test case which also checks for the ForTrilinos failure. Thomas

Re: [PATCH] target/56875: Work around buggy GAS

2013-09-20 Thread Matt Thomas
On Sep 20, 2013, at 9:58 AM, Jan-Benedict Glaw wrote: > Hi! > > VAX GAS has a glitch when generating a 64bit value from a small > negative integer, which isn't properly sign-extended. (I'll see if > this can be fixed without breaking other cases.) > > However, GCC should work around this by si

Re: *PING* Re: [Patch, Fortran] PR57697/58469 - Fix another defined-assignment issue

2013-09-25 Thread Thomas Koenig
Hi Tobias, > * PING * http://gcc.gnu.org/ml/fortran/2013-09/msg00039.html > > Additionally pinging for: > http://gcc.gnu.org/ml/fortran/2013-09/msg00031.html Both are OK. Thanks a lot for the patches! Thomas

*ping* [patch, fortran] Handle -Wextra, -fcompare-reals is implied with -Wextra

2012-09-28 Thread Thomas Koenig
I wrote: the attatched patch (this time for real!) implements -Wextra for the Fortran front end, and adds -fcompare-reals to -Wextra. Ping?

Re: [patch, fortran] Fix PR 52724, internal list-directed read/write with kind=4

2012-09-29 Thread Thomas Koenig
think I'll close the PR. Thomas

[patch, libfortran] Fix PR 54736, memory corruption with GFORTRAN_CONVERT_UNIT

2012-09-29 Thread Thomas Koenig
possible to set environment variables from the testsuite. Regression-tested. OK for trunk? I would also like to backport this to 4.7, and maybe 4.6. What do you think? Thomas 2012-09-29 Thomas König PR libfortran/54736 * runtime/environ.c (search_unit): Correct

Re: [PATCH] Disable updating VRSAVE everywhere except Darwin

2012-09-29 Thread Matt Thomas
On Sep 29, 2012, at 8:08 AM, Segher Boessenkool wrote: >> The following proposed patch disables setting, saving and restoring >> the VRSAVE register on all targets except Darwin. >> >> VRSAVE was removed from the AIX ABI and was suppose to have been >> removed from the PPC SVR4 ABI. All recent

Re: [Patch, Fortran, OOP] PR 54667: gimplification failure with c_f_pointer

2012-09-30 Thread Thomas Koenig
Hi Janus, Regtested on x86_64-unknown-linux-gnu. Ok for trunk? This looks all right to me (although I'm not really an expert :-) OK, and thanks for the patch! Thomas

Re: [patch, libfortran] Fix PR 54736, memory corruption with GFORTRAN_CONVERT_UNIT

2012-10-01 Thread Thomas Koenig
Hello world, the previous version of the patch has an issue that Shane pointed out in the PR. This version should work; at least it survived all the test cases I could come up with. Regression-tested (again). OK for trunk? Also for 4.6 and 4.7? Thomas 2012-10-01 Thomas König

[patch, fortran] PR 54833 Don't wrap calls to free(a) in if (a != NULL)

2012-10-06 Thread Thomas Koenig
Hello world, the attached patch removes wrapping calls to free(a) by if (a != NULL) for some cases. It is not complete, because automatic deallocation of allocatable structure components is not yet covered. OK for trunk? Thomas 2012-10-06 Thomas König PR fortran/54833

Re: [patch, fortran] PR 54833 Don't wrap calls to free(a) in if (a != NULL)

2012-10-06 Thread Thomas Koenig
missing an "else"). Regression-tested. OK for trunk? Thomas 2012-10-06 Thomas König PR fortran/54833 * trans.c (gfc_call_free): Do not wrap the call to __builtin_free in check for NULL. (gfc_deallocate_with_status): For automatic deallocati

*ping* [patch, libfortran] Fix PR 54736, memory corruption with GFORTRAN_CONVERT_UNIT

2012-10-06 Thread Thomas Koenig
Am 01.10.2012 20:34, schrieb Thomas Koenig: Hello world, the previous version of the patch has an issue that Shane pointed out in the PR. This version should work; at least it survived all the test cases I could come up with. Regression-tested (again). OK for trunk? Also for 4.6 and 4.7

Re: *ping* [patch, libfortran] Fix PR 54736, memory corruption with GFORTRAN_CONVERT_UNIT

2012-10-06 Thread Thomas Koenig
Hi Steven, Ping? I would like to start committing patches so I don't have too many of them in my tree at the same time :-) This looks OK to me. Committed as rev. 192158. I'll commit to 4.7 and after that to 4.6 in a few days. Thanks a lot for the review! Thomas

Re: [Patch, Fortran] PR 40453: Enhanced (recursive) argument checking

2012-10-11 Thread Thomas Koenig
Hi Janus, ping! 2012/10/7 Janus Weil : Hi all, here is a rather straightforward patch, which does 'recursive' checking of dummy procedures. Regtested on x86_64-unknown-linux-gnu. Ok for trunk? This is OK. Thanks for the patch! Thomas

Re: *ping* [patch, fortran] Handle -Wextra, -fcompare-reals is implied with -Wextra

2012-10-21 Thread Thomas Koenig
Here is the patch as I committed it. Thanks a lot for your review! Now we can start thinking if we want to add other flags to -Wextra. Regards Thomas 012-10-21 Thomas Koenig PR fortran/54465 * lang.opt (Wextra): Add. * invoke.texi: Document that -Wc-bi

[patch, wwwdocs, committed] Fortran changes for 4.8

2012-10-21 Thread Thomas Koenig
Hello world, I have committed the attached patch as obvious after checking with "tidy". Best regards Thomas 2012-10-21 Thomas Koenig * gcc-4.8/changes.html: Document that -Wc-binding-type is enabled by -Wall. Document that -Wcompare-reals is

Re: *ping* [patch, fortran] Handle -Wextra, -fcompare-reals is implied with -Wextra

2012-10-27 Thread Thomas Koenig
Am 27.10.2012 01:41, schrieb Andreas Schwab: Thomas Koenig writes: Index: trans.c === --- trans.c (revision 192638) +++ trans.c (working copy) @@ -814,26 +814,23 @@ gfc_allocate_allocatable (stmtblock_t * block, tre

Re: [patch, fortran] PR 54833 Don't wrap calls to free(a) in if (a != NULL)

2012-10-27 Thread Thomas Koenig
Hi Andreas, Thomas Koenig writes: PR fortran/54833 * trans.c (gfc_call_free): Do not wrap the call to __builtin_free in check for NULL. (gfc_deallocate_with_status): For automatic deallocation without status for non-coarrays, don't wrap ca

Re: *ping* Re: [Patch, Fortran] Fix some libgfortran issues found by coverity

2012-10-28 Thread Thomas Koenig
Hi Tobias, * ping * On 16.10.2012 23:18, Tobias Burnus wrote: In the Bessel-function algorithm, there was the useless code: ret->base_addr = ret->base_addr; The patch is OK. Thanks a lot! Thomas

Re: *ping* Re: [Patch, Fortran] PR54958 - Allow ac-implied-do and data-implied-do with INTENT(IN)

2012-10-28 Thread Thomas Koenig
Hi Tobias, * ping * This is OK. Thanks for the patch! Thomas

[patch, RFC] PR 30146, warning/errors for potentially changing values in DO loops

2012-10-28 Thread Thomas Koenig
more comments, a ChangeLog entry and a deja-gnuified test case. Thomas Index: frontend-passes.c === --- frontend-passes.c (Revision 192894) +++ frontend-passes.c (Arbeitskopie) @@ -39,6 +39,7 @@ static bool optimize_trim (gfc

Cleanup patches

2013-10-08 Thread Thomas Schwinge
/gcc.dg/gomp/appendix-a/a.35.5.c +++ gcc/testsuite/gcc.dg/gomp/appendix-a/a.35.5.c @@ -9,7 +9,7 @@ wrong5 (int n) { work (n, 0); /* incorrect nesting of barrier region in a critical region */ -#pragma omp barrier +#pragma omp barrier/* { dg-error "may not be closely nested" } */ work (n, 1); } } Grüße, Thomas pgpe8UlaakhYe.pgp Description: PGP signature

Re: Cleanup patches

2013-10-09 Thread Thomas Schwinge
Hi! On Tue, 8 Oct 2013 22:04:23 +0200, Jakub Jelinek wrote: > On Tue, Oct 08, 2013 at 09:17:35AM +0200, Thomas Schwinge wrote: > > Here are a few cleanup patches, mostly in the realm of OpenMP, so Jakub > > gets a CC. OK to commit? > > They look ok to me, but I'd

Re: Cleanup patches

2013-10-09 Thread Thomas Schwinge
've been aware of that, but posted the patch I had tested based on yesterday's trunk. > * gfortran's preprocessor also defines _OPENMP. Thus, you could also add > test cases for _OPENMP. That's what I'm testing in the new file gcc/testsuite/gfortran.d

Re: [gomp4] Adjust some gcc.dg/autopar/ tests

2013-10-09 Thread Thomas Schwinge
patch, but it would be much harder to test it for me (no isl nor cloog readily built) jakub: Testing. OK to commit -- on gomp-4_0-branch, or trunk after your merge patches have gone in, or are you going to fold it into the respective merge patch (and later merge it back into gomp-4_0-branch

Re: lto-plugin: mismatch between ld's architecture and GCC's configure --host

2013-10-14 Thread Thomas Schwinge
m to override those in BASE_FLAGS_TO_PASSS. +# built for the build system to override those in BASE_FLAGS_TO_PASS. EXTRA_BUILD_FLAGS = \ CFLAGS="$(CFLAGS_FOR_BUILD)" \ LDFLAGS="$(LDFLAGS_FOR_BUILD)" diff --git Makefile.tpl Makefile.tpl index 3233a78..2695a2b 10

Re: [PATCH] Move effective target check after other directives in c-c++-common/cpp/openmp-define-3.c

2013-10-16 Thread Thomas Schwinge
+1,6 @@ > -/* { dg-require-effective-target fopenmp } */ > /* { dg-options "-fopenmp" } */ > /* { dg-do preprocess } */ > +/* { dg-require-effective-target fopenmp } */ The other testsuite files that I added in r203417 should also be adapted accordingly. Do you want

Re: [PATCH] Move effective target check after other directives in c-c++-common/cpp/openmp-define-3.c

2013-10-16 Thread Thomas Schwinge
986 100644 --- gcc/testsuite/gfortran.dg/openmp-define-3.f90 +++ gcc/testsuite/gfortran.dg/openmp-define-3.f90 @@ -1,6 +1,6 @@ -! { dg-require-effective-target fopenmp } ! { dg-options "-cpp -fopenmp" } ! { dg-do preprocess } +! { dg-require-effective-target fopenmp } #ifndef _OPENMP # error _OPENMP not defined Grüße, Thomas pgp0HJQRNg51x.pgp Description: PGP signature

Re: lto-plugin: mismatch between ld's architecture and GCC's configure --host

2013-10-25 Thread Thomas Schwinge
index 90bd0bd..23ff04a 100644 > --- gcc/doc/sourcebuild.texi > +++ gcc/doc/sourcebuild.texi > @@ -120,7 +120,7 @@ The Stack protector runtime library. > The C++ runtime library. > > @item lto-plugin > -Plugin used by @command{gold} if link-time optimizations are enabled. > +Plugin used by the linker if link-time optimizations are enabled. > > @item maintainer-scripts > Scripts used by the @code{gccadmin} account on @code{gcc.gnu.org}. > Fix typo. > > * Makefile.tpl: Fix typo. > * Makefile.in: Regenerate. > > --- > Makefile.in | 2 +- > Makefile.tpl | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git Makefile.in Makefile.in > index a13771d..67d8cfb 100644 > --- Makefile.in > +++ Makefile.in > @@ -166,7 +166,7 @@ BUILD_EXPORTS = \ > WINDMC="$(WINDMC_FOR_BUILD)"; export WINDMC; > > # These variables must be set on the make command line for directories > -# built for the build system to override those in BASE_FLAGS_TO_PASSS. > +# built for the build system to override those in BASE_FLAGS_TO_PASS. > EXTRA_BUILD_FLAGS = \ > CFLAGS="$(CFLAGS_FOR_BUILD)" \ > LDFLAGS="$(LDFLAGS_FOR_BUILD)" > diff --git Makefile.tpl Makefile.tpl > index 3233a78..2695a2b 100644 > --- Makefile.tpl > +++ Makefile.tpl > @@ -169,7 +169,7 @@ BUILD_EXPORTS = \ > WINDMC="$(WINDMC_FOR_BUILD)"; export WINDMC; > > # These variables must be set on the make command line for directories > -# built for the build system to override those in BASE_FLAGS_TO_PASSS. > +# built for the build system to override those in BASE_FLAGS_TO_PASS. > EXTRA_BUILD_FLAGS = \ > CFLAGS="$(CFLAGS_FOR_BUILD)" \ > LDFLAGS="$(LDFLAGS_FOR_BUILD)" Grüße, Thomas pgpDFYKNoEh1u.pgp Description: PGP signature

Re: lto-plugin: mismatch between ld's architecture and GCC's configure --host

2013-11-02 Thread Thomas Schwinge
+--enable-linker-plugin-flags='CC=gcc\ -m32' \ > > +--enable-linker-plugin-configure-flags=--host=i686-pc-linux-gnu > > +@end smallexample > > + > > @item --with-plugin-ld=@var{pathname} > > Enable an alternate linker to be used at link-time optimization (LTO) > > link time when @option{-fuse-linker-plugin} is enabled. > > > GNU ld can use linker plugins, too. > > > > gcc/ > > * doc/sourcebuild.texi (Top Level) : GNU ld can use > > linker plugins, too. > > > > --- > > gcc/doc/sourcebuild.texi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git gcc/doc/sourcebuild.texi gcc/doc/sourcebuild.texi > > index 90bd0bd..23ff04a 100644 > > --- gcc/doc/sourcebuild.texi > > +++ gcc/doc/sourcebuild.texi > > @@ -120,7 +120,7 @@ The Stack protector runtime library. > > The C++ runtime library. > > > > @item lto-plugin > > -Plugin used by @command{gold} if link-time optimizations are enabled. > > +Plugin used by the linker if link-time optimizations are enabled. > > > > @item maintainer-scripts > > Scripts used by the @code{gccadmin} account on @code{gcc.gnu.org}. > > > Fix typo. > > > > * Makefile.tpl: Fix typo. > > * Makefile.in: Regenerate. > > > > --- > > Makefile.in | 2 +- > > Makefile.tpl | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git Makefile.in Makefile.in > > index a13771d..67d8cfb 100644 > > --- Makefile.in > > +++ Makefile.in > > @@ -166,7 +166,7 @@ BUILD_EXPORTS = \ > > WINDMC="$(WINDMC_FOR_BUILD)"; export WINDMC; > > > > # These variables must be set on the make command line for directories > > -# built for the build system to override those in BASE_FLAGS_TO_PASSS. > > +# built for the build system to override those in BASE_FLAGS_TO_PASS. > > EXTRA_BUILD_FLAGS = \ > > CFLAGS="$(CFLAGS_FOR_BUILD)" \ > > LDFLAGS="$(LDFLAGS_FOR_BUILD)" > > diff --git Makefile.tpl Makefile.tpl > > index 3233a78..2695a2b 100644 > > --- Makefile.tpl > > +++ Makefile.tpl > > @@ -169,7 +169,7 @@ BUILD_EXPORTS = \ > > WINDMC="$(WINDMC_FOR_BUILD)"; export WINDMC; > > > > # These variables must be set on the make command line for directories > > -# built for the build system to override those in BASE_FLAGS_TO_PASSS. > > +# built for the build system to override those in BASE_FLAGS_TO_PASS. > > EXTRA_BUILD_FLAGS = \ > > CFLAGS="$(CFLAGS_FOR_BUILD)" \ > > LDFLAGS="$(LDFLAGS_FOR_BUILD)" Grüße, Thomas pgpvaQ2TILcLo.pgp Description: PGP signature

Re: gomp_target_fini

2016-01-20 Thread Thomas Schwinge
to avoid the > > > follow-on failures of cuMemFreeHost just described above, for example?) > > > > > > <http://pubs.opengroup.org/onlinepubs/9699919799/functions/atexit.html> > > > tells us: > > > > > > Since the behavior is undefi

Re: [PATCH] Fix up reduction-1{1,2} testcases (PR middle-end/68221)

2016-01-20 Thread Thomas Schwinge
POINTER_PLUS_EXPR, > > > > > -TREE_TYPE (x), x, bias); > > > > > + bias = fold_convert_loc (clause_loc, > > > > > pointer_sized_int_node, > > > > > + bias); > > > > &

Re: [PATCH, GCC] Fix PR67781: wrong code generation for partial load on big endian targets

2016-01-20 Thread Thomas Preud'homme
On Friday, January 08, 2016 10:05:25 AM Richard Biener wrote: > On Tue, 5 Jan 2016, Thomas Preud'homme wrote: > > Hi, > > > > bswap optimization pass generate wrong code on big endian targets when the > > result of a bit operation it analyzed is a partial load of

Re: [PATCH, GCC] Fix PR67781: wrong code generation for partial load on big endian targets

2016-01-21 Thread Thomas Preud'homme
On Thursday, January 21, 2016 09:21:52 AM Richard Biener wrote: > On Thu, 21 Jan 2016, Thomas Preud'homme wrote: > > On Friday, January 08, 2016 10:05:25 AM Richard Biener wrote: > > > On Tue, 5 Jan 2016, Thomas Preud'homme wrote: > > > > Hi, > > >

[gomp4] Un-parallelized OpenACC kernels constructs with nvptx offloading: "avoid offloading" (was: [PATCH] Add fopt-info-oacc)

2016-01-21 Thread Thomas Schwinge
84 files changed, 700 insertions(+), 78 deletions(-) diff --git gcc/ChangeLog.gomp gcc/ChangeLog.gomp index cdd279b..f991b91 100644 --- gcc/ChangeLog.gomp +++ gcc/ChangeLog.gomp @@ -1,3 +1,17 @@ +2016-01-21 Thomas Schwinge + + * common.opt: Add -foffload-force. + * lto-wrapper.c (merge_an

<    6   7   8   9   10   11   12   13   14   15   >