The conversion of a MEM address to ptr_mode in
try_store_by_multiple_pieces was misguided: copy_addr_to_reg expects
Pmode for addresses.
Regstrapped on x86_64-linux-gnu, testcase verified with a cross to
aarch64. Ok to install?
for gcc/ChangeLog
PR target/100518
* builtins.c
On Dec 10, 2021, Jeff Law wrote:
> The patch is clearly safe. My question is should we have caught this
> earlier in the call chain?
Callers will call try_store_by_multiple_pieces if set_storage_via_setmem
fails. setmem doesn't necessarily need min and max len to do its job,
so if we were to m
On Oct 12, 2022, Jonathan Wakely wrote:
> On Wed, 12 Oct 2022 at 12:41, Jonathan Wakely wrote:
>>
>> On Thu, 23 Jun 2022 at 12:38, Alexandre Oliva via Libstdc++
>> wrote:
>> >
>> > On Jun 22, 2022, Alexandre Oliva wrote:
>> >
>> > > Regstrapped on x86_64-linux-gnu, also tested with a cross to
On Oct 13, 2022, Richard Biener wrote:
> On Tue, Oct 11, 2022 at 3:33 PM Alexandre Oliva wrote:
>>
>> On Oct 11, 2022, Richard Biener wrote:
>>
>> > On Tue, Oct 11, 2022 at 1:57 PM Alexandre Oliva wrote:
>> >>
>> >> On Oct 10, 2022, Richard Biener wrote:
>> >>
>> >> > As noted in the Cauldr
Introduce 'leafy' to auto-select between 'used' and 'all' for leaf and
nonleaf functions, respectively.
Regstrapped on x86_64-linux-gnu. Ok to install?
for gcc/ChangeLog
* doc/extend.texi (zero-call-used-regs): Document leafy and
variants thereof.
* flag-types.h (zero_
Hello, Qing,
It was a pleasure to meet you at the Cauldron.
On Oct 21, 2022, Qing Zhao wrote:
> Hi, Alexandre,
> Could you please explain a little bit on the motivation of this patch first?
It was a suggestion I got after the Cauldron presentation.
It made sense to me, and was easy enough to
On Oct 25, 2022, Qing Zhao wrote:
>> 'all' for leaf functions is likely wasteful. If no other functions are
>> called, one can determine exactly which registers might carry
>> information out and thus need zeroing, and 'used' is thus likely enough,
>> depending on the purpose of register scrubbi
On Aug 24, 2022, Jonathan Wakely via Gcc-patches
wrote:
>* include/bits/basic_string.h (operator+(const string&,
> const char*)):
>Remove naive implementation.
>* include/bits/basic_string.tcc (operator+(const string&,
> const char*)):
>Add single-
On Aug 31, 2022, Xi Ruoyao wrote:
> On Sat, 2022-07-09 at 10:11 -0600, Jeff Law via Gcc-patches wrote:
>> Once Alex is OK with this patch, then it'll be good to go.
>>
>> jeff
> Gentle ping as a distro maintainer :).
Oops, thanks, sorry, I seem to have missed it the first time around.
The pat
On Apr 14, 2022, Alexandre Oliva wrote:
> * gcc.target/powerpr/pr79004.c: Add -mlong-double-128.
Just like pr79004, float128-hw.c requires -mlong-double-128 for some
the expected asm opcodes to be output on target variants that have
64-bit long doubles. That's because their expanders,
e.g
On Apr 26, 2022, Segher Boessenkool wrote:
> The testcase uses _Float128, what code that
> generates should not depend on your long double setting.
Good, that means my hunch that it shouldn't is on the right track.
> Please file a PR instead?
I filed https://gcc.gnu.org/bugzilla/show_bug.cgi?i
gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c covers ppc variants
that accept and reject misaligned accesses. The message that it
expects for rejection was removed in the gcc-11 development cycle by
commit r11-1969. The patch adjusted multiple tests to use the message
introduced in r11-1945, b
libstdc++'s bits/simd.h section for PPC (Altivec) defines various
intrinsic vector types that are only available along with VSX: 64-bit
long double, double, (un)signed long long, and 64-bit (un)signed long.
experimental/simd/standard_abi_usable{,_2}.cc tests error out reporting
the unmet require
On Apr 28, 2022, Segher Boessenkool wrote:
> On Thu, Apr 28, 2022 at 03:09:54AM -0300, Alexandre Oliva wrote:
>> +# ifdef __VSX__
> No space after # (here and everywhere else).
'k, thanks
>> + "no __intrinsic_type support for [long] double on PPC w/o
>> VSX");
> This change isn
On May 2, 2022, Segher Boessenkool wrote:
> Send full patches always please.
I'll try to remember that. In case I fail, I hope you won't mind too
much reminding me.
(You'd also asked me not to send patches as followups, but... revised
versions of a patch still belong in the same thread, righ
On Apr 28, 2022, Richard Biener wrote:
> On Thu, 28 Apr 2022, Alexandre Oliva wrote:
>>
>> gcc.dg/vect/costmodel/ppc/costmodel-vect-31a.c covers ppc variants
>> that accept and reject misaligned accesses. The message that it
>> expects for rejection was removed in the gcc-11 development cycle b
The floating-point overloads of from_char are only declared if
_GLIBCXX_HAVE_USELOCALE is #defined as nonzero. That's exposed from
charconv as _cpp_lib_to_chars >= 201611L, so guard the test body with
that.
Regstrapped on ppc64le-linux-gnu, and tested on
x86_64-linux-gnu-x-ppc{,64}-vx7r2 (witho
vec-mul is an execution test, but it only requires a powerpc_vsx_ok
effective target, which is enough only for compile tests. In order to
To check for runtime and execution environment support, we need to
require vsx_hw. Make that a condition for execution, but still
perform a compile test if t
On May 3, 2022, Jonathan Wakely wrote:
> That macro should start with two underscores.
Doh! Wow, eagle eyes! :-) Good catch, thanks!
Here's the corrected patch I'm installing, trunk for now, 12 and 11 once
it's allowed in 12.
> OK for trunk and gcc-11 with that change.
> gcc-12 branch nee
The testcase for pr100106, compiled with optimization for 32-bit
powerpc -mcpu=604 with -mstrict-align expands the initialization of a
union from a float _Complex value into a load from an SCmode
constant pool entry, aligned to 4 bytes, into a DImode pseudo,
requiring 8-byte alignment.
The patch
The async call and future variable initialization may take a while to
complete on uniprocessors, especially if the async call and other
unrelated processes run before context switches back to the main
thread.
Taking steady_begin only then sometimes causes the 11*100ms in the
slow clock, counted
On May 5, 2022, Segher Boessenkool wrote:
> On Thu, May 05, 2022 at 03:52:01AM -0300, Alexandre Oliva wrote:
>> + else if (reg && MEM_P (reg)
>> + && STRICT_ALIGNMENT && MEM_ALIGN (reg) < GET_MODE_ALIGNMENT (omode))
>> +return false;
> Please fix the line breaks? Either do a break b
On May 5, 2022, Segher Boessenkool wrote:
> On Thu, May 05, 2022 at 08:59:21AM +0100, Richard Sandiford wrote:
>> Alexandre Oliva via Gcc-patches writes:
>> I know this is the best being the enemy of the good, but given
>> that we're at the start of stage 1, would i
On May 6, 2022, Jonathan Wakely wrote:
> On Fri, 6 May 2022 at 17:17, Segher Boessenkool wrote:
>> > +#if defined __VSX__ || __LONG_WIDTH__ == 32
>> > _GLIBCXX_SIMD_PPC_INTRIN(signed long);
>> > _GLIBCXX_SIMD_PPC_INTRIN(unsigned long);
>> > +#endif
>>
>> Is __LONG_WIDTH__ the right macro to u
Reverse iteration over blocks, in gimple-harden-conditionals.cc, was
supposed to avoid visiting blocks introduced by hardening and
introducing further reversed conditionals and traps for them, but
newly-created blocks may be inserted before the current block, as
shown by the PR105455 testcase.
N
When turning unconditional edges into conditional, as in
gimple-harden-conditionals.cc:insert_check_and_trap, the newly-created
edge's probability comes out uninitialized, while the previously
unconditional edge's probability is presumably
profile_probability::always.
Mixing initialized and unin
There is an assumption in force_edge_cold that, if any edge out of the
same src block has uninitialized probability, then a conditional
branch out of src won't have REG_BR_PROB set.
This assumption is supposed to hold, but buggy gimple passes may turn
unconditional edges into conditional ones, a
On May 12, 2022, Richard Biener wrote:
>> Regstrapped on x86_64-linux-gnu. Ok to install?
> OK.
Thanks. I failed to ask, but I'm confident this is also ok for gcc-12,
so I'm putting it in there as well. Please let me know otherwise.
>> PR rtl-optimization/105455
>> * gimple-harden-condition
On May 12, 2022, Richard Biener wrote:
> Note you are relying on an implementation detail here, it might be
> better to mark blocks visited or iterate over the CFG in a more
> defined manner
*nod*, I was wondering whether that property could be relied on. I also
see BB_NEW set in bb->flags in t
On May 12, 2022, Pierre-Marie de Rodat wrote:
> Implement and document hardened booleans, from nonstandard boolean types
> with representation clauses to the extra validity checking performed on
> boolean types annotated with the "hardbool" Machine_Attribute pragma.
And here is a test for testsu
The compiler is allowed to assume it can access String bounds, such as
the prefix passed to Get_External_Name, even in circumstances in which
the prefix is not going to be used and has_prefix is false, so, from
the C side, we have to build a proper String_Template for the
String_Pointer.
Regstra
On May 13, 2022, Richard Biener wrote:
> Yeah, I'm not sure who clears that bit - grepping shows no user
> besides the setter...
*nod*, that's what I'd found out myself. Oh well...
>> Though I suppose it might be useful to document and enforce the property
>> that a newly-created block takes u
On May 18, 2022, Andrew MacLeod via Gcc-patches wrote:
> I'm open to suggestions for a better term!
How about inference?
--
Alexandre Oliva, happy hackerhttps://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
Disinformation flourishes
On May 11, 2022, Martin Liška wrote:
> Ready to be installed?
Hmm... I don't like that --disable-fixincludes would still configure,
build and even install fixincludes. This would be surprising, given
that the semantics of disabling a component is to not even configure it.
How about leaving th
This patch introduces -multiflags, short for multilib TFLAGS, as an
option that does nothing by default, but that can be added to TFLAGS
and mapped to useful options by driver self-specs.
I realize -m is reserved for machine-specific flags, which this option
sort-of isn't, but its intended use i
On May 24, 2022, Martin Liška wrote:
> Allways install limits.h and syslimits.h header files
> to include folder.
typo: s/Allways/Always/
I'm a little worried about this bit, too. limitx.h includes
"syslimits.h", mentioning it should be in the same directory. Perhaps
it could be left in inclu
FYI, I'm putting in this follow-up tweak to the GNAT manual.
Implied compares in Ada Harded Conditionals documentation
From: Alexandre Oliva
Improve the wording on optimizations that prevent compare hardening,
so as to also cover cases in which explicit compares get combined into
operations wi
On Oct 5, 2021, Pierre-Marie de Rodat wrote:
> * gcc-interface/utils.c (handle_strub_attribute): New.
> (gnat_internal_attribute_table): Add strub.
FTR, this is just a dummy. The actual implementation was submitted
along with the language- and machine-independent infrastructure at
Hello, Jakub,
On Oct 4, 2021, Jakub Jelinek wrote:
> Finally, patch2, the shortest patch, uses MO_VAL_SET whenever destination
> is not sp and otherwise drops the micro-operation on the floor.
That sounds quite reasonable to me, and it is indeed my favorite of the
3 proposed patches, because t
This patch introduces optional passes to harden conditionals used in
branches, and in computing boolean expressions, by adding redundant
tests of the reversed conditions, and trapping in case of unexpected
results. Though in abstract machines the redundant tests should never
fail, CPUs may be le
On Oct 9, 2021, Richard Biener wrote:
> Why two passes (and two IL traverses?)
Different traversals, no reason to force them into a single pass. One
only looks at the last stmt of each block, where cond stmts may be,
while the other has to look at every stmt.
> How do you prevent RTL optimiz
On Oct 12, 2021, Richard Biener wrote:
> Are there any issues with respect to debugging when using such
> asm()s?
Not in this case. When creating short-lived copies for immediate use,
like I do in the proposed patch, either the original value remains live
in its original location and we use an
The condition of the 'if' encompassed that of the 'elsif', so the error
message wouldn't get a chance to be printed.
Regstrapped on x86_64-linux-gnu. I'm checking this in.
for gcc/ada/ChangeLog
* par-ch10.adb (P_Compilation_Unit): Reenable ada83 library
unit renaming test and
On Oct 14, 2021, Richard Biener wrote:
> Yeah, I think that eventually marking the operation we want to preserve
> (with volatile?) would be the best way. On GIMPLE that's difficult,
> it's easier on GENERIC (we can set TREE_THIS_VOLATILE on the
> expression at least), and possibly also on RTL (
On Oct 18, 2021, Richard Biener wrote:
> Yes, it is (just having had a quick look most of the functions in the
> pass lack function-level comments).
Oh my, I'm so sorry, please accept my apologies. I stepped away from
this patch for a few weeks, and when I got back to it, I did not realize
it w
On Oct 20, 2021, Alexandre Oliva wrote:
> I suppose it's a latent issue exposed by the patch,
I was mistaken. Though I even had bisected the -fcompare-debug problem
back to a patch from back in May, that added a new sink_code pass before
store_merging, it was actually a bug in my patch, it was
On Oct 26, 2021, Richard Biener wrote:
> OK.
Thanks. I've just fixed the ChangeLog entry and pushed it:
>> * common.opt (fharden-compares): New.
>> (fharden-conditional-branches): New.
>> * doc/invoke.texi: Document new options.
>> * gimple-harden-conditionals.cc: New.
+ * Makefile.in (OBJS)
On May 9, 2021, "sunil.k.pandey" wrote:
> On Linux/x86_64,
> da9e6e63d1ae22e530ec7baf59f6ed028bf05776 is the first bad commit
Thanks, this fallout from a commit race was fixed in
commit 5fbe6a8e73b52c6ebc28b9111456226c1cda6472
Author: Prathamesh Kulkarni
Date: Tue May 4 11:11:18 2021 +0530
try_store_by_multiple_pieces was added not long ago, enabling
variable-sized memset to be expanded inline when the worst-case
in-range constant length would, using conditional blocks with powers
of two to cover all possibilities of length and alignment.
This patch extends the memset expansion to
While looking into another issue that corrupted hash tables, I added
code to check consistency of element counts, and hit numerous issues
that were concerning, of three kinds: insertion of entries that seem
empty, dangling insertions, and lookups during insertions.
These problems may all have th
Avoid hash table lookups between requesting an insert and storing the
inserted value in avail_exprs_stack. Lookups before the insert is
completed could fail to find double-hashed elements.
Regstrapped on x86_64-linux-gnu. Ok to install?
for gcc/ChangeLog
* tree-ssa-scopedtables.cc
Avoid adding NULL vnodes to referenced tables.
Regstrapped on x86_64-linux-gnu. Ok to install?
for gcc/ChangeLog
* varpool.c (symbol_table::remove_unreferenced_decls): Do not
add NULL vnodes to referenced table.
---
gcc/varpool.cc |4 +++-
1 file changed, 3 insertions(+
Mapping a NULL key is no use, skip it.
Regstrapped on x86_64-linux-gnu. Ok to install?
for gcc/ChangeLog
* tree-inline.cc (insert_decl_map): Skip mapping a NULL decl
as value to itself.
---
gcc/tree-inline.cc |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --
Use NO_INSERT to test whether inserting should be attempted.
Regstrapped on x86_64-linux-gnu. Ok to install?
for gcc/cp/ChangeLog
* constraint.cc (normalize_concept_check): Use NO_INSERT for
pre-insertion check.
---
gcc/cp/constraint.cc |8 +---
1 file changed, 5 in
When a TREE_OPERAND is NULL, do not cache it.
Regstrapped on x86_64-linux-gnu. Ok to install?
for gcc/ChangeLog
* tree-ssa-loop-niter.cc (expand_simple_operands): Refrain
from caching NULL TREE_OPERANDs.
---
gcc/tree-ssa-loop-niter.cc |2 ++
1 file changed, 2 insertions
lookup_expr_in_table is not used for insertions, but it mistakenly
used INSERT rather than NO_INSERT.
Regstrapped on x86_64-linux-gnu. Ok to install?
for gcc/ChangeLog
* postreload-gcse.cc (lookup_expr_in_table): Use NO_INSERT.
---
gcc/postreload-gcse.cc |2 +-
1 file changed,
If a result doesn't have a default def, don't attempt to remap it.
Regstrapped on x86_64-linux-gnu. Ok to install?
for gcc/ChangeLog
* tree-inline.cc (declare_return_variable): Don't remap NULL
default def of result.
---
gcc/tree-inline.cc |9 +
1 file changed,
Insertion of a tm_restart_node in tm_restart failed to record the
newly-allocated node in the hash table.
Regstrapped on x86_64-linux-gnu. Ok to install?
for gcc/ChangeLog
* trans-mem.cc (split_bb_make_tm_edge): Record new node in
tm_restart.
---
gcc/trans-mem.cc |2 +-
cxx_eval_call_expression requests an INSERT even in cases when it
would later decide not to insert. This could break double-hashing
chains. Arrange for it to use NO_INSERT when the insertion would not
be completed.
Regstrapped on x86_64-linux-gnu. Ok to install?
for gcc/cp/ChangeLog
When adding a catch-all partition, we map NULL to it. That mapping is
ineffective and unnecessary. Drop it.
Regstrapped on x86_64-linux-gnu. Ok to install?
for gcc/lto/ChangeLog
* lto-partition.cc (lto_1_to_1_map): Drop NULL partition
mapping.
---
gcc/lto/lto-partition.cc
When decl is NULL, don't record its mapping in the
decl_to_instance_map.
Regstrapped on x86_64-linux-gnu. Ok to install?
for gcc/ada/ChangeLog
* gcc-interface/trans.cc (Sloc_to_locus): Don't map NULL decl.
---
gcc/ada/gcc-interface/trans.cc |2 +-
1 file changed, 1 insertion(+)
Check, after adding a key to a hash set, that the entry does not look
empty.
Regstrapped on x86_64-linux-gnu. Ok to install?
for gcc/ChangeLog
* hash-set.h (add): Check that the inserted entry does not
look empty.
---
gcc/hash-set.h |6 +-
1 file changed, 5 insertio
Check, after inserting entries, that they don't look empty.
Regstrapped on x86_64-linux-gnu. Ok to install?
for gcc/ChangeLog
* hash-map.h (put, get_or_insert): Check that entry does not
look empty after insertion.
---
gcc/hash-map.h |4 +++-
1 file changed, 3 insertion
Hello, Jeff,
On Dec 27, 2022, Jeff Law wrote:
>> * tree-ssa-loop-niter.cc (expand_simple_operands): Refrain
>> from caching NULL TREE_OPERANDs.
> I must admit some curiosity about the NULL operand though. Do you
> recall what kind of node had a NULL operand and whether or not that
> was a vali
In take_address_of, we may refrain from completing a decl_address
INSERT if gsi is NULL, so dnn't even ask for an INSERT in this case.
Regstrapped on x86_64-linux-gnu. Ok to install?
for gcc/ChangeLog
* tree-parloops.cc (take_address_of): Skip INSERT if !gsi.
---
gcc/tree-parloops.
On Dec 27, 2022, David Malcolm wrote:
> Would it make sense to also add assertions that such entries aren't
> Traits::is_deleted? (both for hash_map and hash_set)
Yeah, I guess so. I've come up with something for hash-table proper
too, coming up in 17/17.
Just like the recently-added checks
On Dec 28, 2022, Martin Liška wrote:
> I really like the verification code you added. It's quite similar to what
> I added to hash-table.h:
*nod*
Prompted by your encouragement, I've combined the element count
verification code with the verify() loop, and also added it to expand,
where it can b
On Dec 27, 2022, Alexandre Oliva wrote:
> The number of bugs it revealed tells me that leaving callers in charge
> of completing insertions is too error prone. I found this
> verification code a bit too expensive to enable in general.
Here's a relatively cheap, checking-only test to catch dangl
On Dec 28, 2022, Richard Biener wrote:
> I wonder if on INSERT, pushing a DELETED marker would fix the dangling
> insert and search during delete problem be whether that would be
> better from a design point of view? (It of course requires a DELETED
> representation)
I'm undecided whether a desi
On Dec 29, 2022, Richard Biener wrote:
>> Am 29.12.2022 um 00:06 schrieb Alexandre Oliva :
>>
>> On Dec 28, 2022, Richard Biener wrote:
>>
>>> I wonder if on INSERT, pushing a DELETED marker would fix the dangling
>>> insert and search during delete problem be whether that would be
>>> better
On Dec 30, 2022, Richard Biener wrote:
> Ah, OK, so the completion is checked at the next conflicting
> operation. Yeah, that makes sense I guess.
*nod*
> Thus OK (I think Jeff already approved the patch).
Thanks, 16/ and 17/ were still pending reviews.
I'm installing 17/ now.
> Thanks and h
Existing hash_table traits that use the same representation for empty
and deleted slots reject marking slots as deleted, and to not pass
is_deleted for slots that pass is_empty.
Nevertheless, nearly everywhere, we only test for is_deleted after
checking that !is_empty first. The one exception w
Hello, Richard,
Thank you for the feedback.
On Jan 12, 2023, Richard Biener wrote:
> On Tue, Dec 27, 2022 at 5:12 AM Alexandre Oliva via Gcc-patches
> wrote:
>> This patch extends the memset expansion to start with a loop, so as to
>> still take advantage of known alignm
Hello, Paul,
On Jan 13, 2023, Paul Koning wrote:
>> On Jan 13, 2023, at 8:54 PM, Alexandre Oliva via Gcc-patches
>> wrote:
>> Target-specific code is great for tight optimizations, but the main
>> purpose of this feature is not an optimization. AFAICT it actually
The testcase used to get scheduled differently depending on the
presence of debug insns with MEMs. It's not clear to me why those
MEMs affected scheduling, but the cselib pre-canonicalization of the
MEM address is not used at all when analyzing debug insns, so the
memory allocation and lookup ar
On Jan 16, 2023, Richard Biener wrote:
> On Sat, Jan 14, 2023 at 2:55 AM Alexandre Oliva wrote:
>> Target-specific code is great for tight optimizations, but the main
>> purpose of this feature is not an optimization. AFAICT it actually
>> slows things down in general (due to code growth, and t
Back when I introduced debug markers, I seem to have been under the
impression that location line 0 would only ever occur for unknown and
builtin locations.
Though line 0 never comes up in normal processing of source files, and
debug info formats often cannot represent them, I suppose there's no
On Oct 6, 2022, Alexandre Oliva wrote:
> I'd much rather we could use -fmultiflags, a far more elegant
> arrangement IMHO, so...
> Ping? https://gcc.gnu.org/pipermail/gcc-patches/2022-June/597419.html
>> for gcc/ChangeLog
>> * common.opt (fmultiflags): New.
>> * doc/invoke.texi: Document it
On Apr 14, 2023, Alexandre Oliva wrote:
> On Mar 23, 2023, Alexandre Oliva wrote:
>> This patch introduces infrastructure for targets to add an offset to
>> the label issued after the call_insn to set the call_return_pc
>> attribute. This will be used on rs6000, that sometimes issues another
>>
The optimization barriers inserted after compares enable GCC to derive
information about the values from e.g. the taken paths, or the absence
of exceptions. Move them before the original compares, so that the
reversed compares test copies of the original operands, without
further optimizations.
There are still shells on some systems that lack the ability to start
scripts when not using the shell name explicitly. Adjust genmultilib
to use ${CONFIG_SHELL-/bin/sh} the same way configure does.
Regstrapped on x86_64-linux-gnu. Also built riscv64-elf on an affected
platform. I'm checking
When we're using fast_float for 32- and 64-bit floating point, use
strtold for wider long double, even if locales are unavailable.
On vxworks, test for strtof's and strtold's declarations, so that they
can be used even when cross compiling.
Include stdlib.h in the decl-checking macro, so that i
On vxworks, isunordered is defined as a macro that ultimately calls a
_Fpcomp function, that GCC doesn't recognize as a builtin, so it
can't optimize accordingly.
Use __builtin_isunordered instead to get the desired code for the
test.
Regstrapped on x86_64-linux-gnu. Also tested on aarch64-vx7
On May 4, 2023, Jonathan Wakely wrote:
> And we could use strtod for a target that doesn't support locales *at all*
> (so strtod always behaves as specified for LANG=C).
Oh, sorry, I misread the *_USELOCALE macro as *_USE_LOCALE, and I
thought this was what I was doing. Nevermind, patch withdr
Here's a patch to skip/xfail the bits that are expected to fail on
aarch64-vxworks.
[libstdc++] [testsuite] xfail double-prec from_chars for ldbl
When long double is wider than double, but from_chars is implemented
in terms of double, tests that involve the full precision of long
double are expe
Back in 2017, I made -g* options implicitly negatable, without
realizing there was documentation that required updating. Oops.
Fixed, at last!
Regstrapped on x86_64-linux-gnu. I'm installing this as obvious.
for gcc/ChangeLog
* doc/options.texi (option, RejectNegative): Mention that
On Jan 27, 2023, Jakub Jelinek wrote:
> Now, 1) is precondition of 2), we can only subst the VALUEs if we
> have actually looked the address up, but as can be seen on that testcase,
> we are relying on at least the 1) to be done because we subst the values
> later on even on DEBUG_INSNs and actua
The patch for PR 100810 tested for undefined SSA_NAMEs appearing
directly in the base expression of the potential IV candidate, but
that's not enough. The testcase for PR105665 shows an undefined
SSA_NAME has the same ill effect if it's referenced as an PHI_NODE arg
in the referenced SSA_NAME.
Several gnatlib* targets perform, with a subshell and sed, the same
GCC_FOR_TARGET pathname transformation that OSCONS_CC performs with
make subst macros. Rename OSCONS_CC to a more general name, and use
it for gnatlib as well.
Tested on x86_64-linux-gnu, checking in.
for gcc/ada/ChangeLog
On May 20, 2022, Alexandre Oliva wrote:
> Regstrapped on x86_64-linux-gnu. Ok to install?
Ping? https://gcc.gnu.org/pipermail/gcc-patches/2022-May/595356.html
> for gcc/ChangeLog
> * common.opt (multiflags): New.
> * doc/invoke.texi: Document it.
> * gcc.cc (driver_self_sp
On May 30, 2022, Richard Biener wrote:
> I don't think you can rely on TREE_VISITED not set at the start of the
> pass (and you don't clear it either).
I don't clear it, but I loop over all SSA names and set TREE_VISITED to
either true or false, so that's covered.
I even had a test patch that c
On Jun 1, 2022, Richard Biener wrote:
> On Tue, May 31, 2022 at 3:27 PM Alexandre Oliva wrote:
>int i;
>if (flag)
> i = init;
>i++;
> still would (the propagation stops at i++).
Uh, are you sure? That doesn't sound right. I meant for the
propagation to affect the incremente
On Jun 1, 2022, Alexandre Oliva wrote:
> Now I'm thinking we can go for an even stricter predicate to disable
> the optimization: if a non-PHI use of a maybe-undefined dominates the
> loop, then we can still perform the optimization:
Here it is.
[PR105665] ivopts: check defs of names in base
On Jun 2, 2022, Jan Beulich via Gcc-patches wrote:
> * Makefile.in (ORIGINAL_OBJCOPY_FOR_TARGET): New.
> * configure.ac: Check for objcopy, producing
> ORIGINAL_OBJCOPY_FOR_TARGET.
> * configure: Update accordingly.
> * exec-tool.in (ORIGINAL_OBJCOPY_FOR_TARGET): Ne
On Jun 2, 2022, Richard Biener wrote:
>> + if (is_a (USE_STMT (use_p)))
> I think you also want to skip debug stmts here?
Indeed, thanks!
(live by the sword, die by the sword ;-)
>> + if (dump_file)
> && (dump_flags & TDF_DETAILS) please
ack
>> + if (dump_file)
> li
Two non-portable shell constructs have been long present in libcody's
build rule for revision.stamp: $() instead of ``, and += to append to
a shell variable. The former seems to work even when bash is
operating as /bin/sh, but += doesn't, and it ends up trying to run
revision+=M as a command nam
On Jun 1, 2022, Hans-Peter Nilsson wrote:
> On Fri, 20 May 2022, Alexandre Oliva via Gcc-patches wrote:
>>
>> This patch introduces -multiflags, short for multilib TFLAGS, as an
>> option that does nothing by default, but that can be added to TFLAGS
>> and mapped
Hello, Eric,
On Jun 9, 2022, Eric Gallager wrote:
> (cc-ing the build machinery maintainers listed in MAINTAINERS this time)
Thanks, I'd missed it the first time.
> On Thu, Jun 2, 2022 at 11:53 AM Eric Gallager wrote:
>> So, I'm working on fixing PR bootstrap/44425, and have this patch to
>
rtems6 declares a global struct bitset in a header file included
indirectly by sys/types.h, that ambiguates the unqualified references
to bitset after "using namespace std" in the testsuite.
Work around the namespace pollution with using declarations of
std::bitset.
Regstrapped on x86_64-linux-
nexttowardl is only expected to be available with C99 math, but
20_util/to_chars/long_double.cc uses it unconditionally.
State the cmath requirement in the test.
Regstrapped on x86_64-linux-gnu, also tested with a cross to
aarch64-rtems6. Ok to install?
for libstdc++-v3/ChangeLog
*
201 - 300 of 408 matches
Mail list logo
