Re: [PATCH] Add missing noexpect causes in tuple for move functions

2018-11-30 Thread nick
es will each patch touching one of the tuple clases as I assume your the maintainer. Cheers, Nick

Re: [PATCH] Use proper print formatter in main function in fixincl.c

2018-12-20 Thread nick
again and sorry for wasting your time Joseph, Nick

Ping: [PATCH] PR88395 Fix Nullptr when compiling with -fconcepts

2019-04-25 Thread nick
I'm pinging this patch as it's old now and should be applied to fix the bug. Nick On 2019-04-08 7:20 p.m., Nicholas Krause wrote: > This fixes the caller in tsubst_requires_expr to > tsubst_constraint_variables to wrap their respective > trees in PARM_CONSTR_PARMS. This is

Patch I have Formatted in Git

2017-09-29 Thread nick
Greetings All, I have this patch formatted in git, I was unable to figure out how the whole svn works. I am new to svn. Here is the patch below so any comments on this patch or how to format it properly would be great: >From a86173b1cab13a8fe5615c53005adcfafb97415f Mon Sep 17 00:00:00 2001 From:

Patch that fix PR80188

2017-09-29 Thread nick
or_at (EXPR_LOCATION (call_expr), "cannot tail-call: %s", reason); + error_at (EXPR_LOCATION (call_expr), "cannot tail-call: %s", N_(reason)); } /* Fill in ARGS_SIZE and ARGS array based on the parameters found in Thanks, Nick

Re: Patch that fix PR80188

2017-09-29 Thread nick
gt; - error_at (EXPR_LOCATION (call_expr), "cannot tail-call: %s", reason); > > + error_at (EXPR_LOCATION (call_expr), "cannot tail-call: %s", > N_(reason)); > > } > > > > /* Fill in ARGS_SIZE and ARGS array based on the parameters found in >

Re: Patch I have Formatted in Git

2017-09-29 Thread nick
On 2017-09-29 04:25 PM, Joseph Myers wrote: > On Fri, 29 Sep 2017, nick wrote: > >> - error_at (EXPR_LOCATION (call_expr), "cannot tail-call: %s", reason); >> + error_at (EXPR_LOCATION (call_expr), "cannot tail-call: %s", N_(reason)); > > This c

Re: [PATCH 0/2] Introduce a new GCC option, --record-gcc-command-line

2019-11-07 Thread Nick Clifton
--frecord-options=object is a synonym for your option The user could supply one or more of the selectors to have the recording happen in multiple places. Just an idea. Cheers Nick

[PATCH] libiberty, include: add bsearch_r

2020-01-10 Thread Nick Alcock
libctf wants a bsearch that takes a void * arg pointer to avoid a nonportable use of __thread. bsearch_r is required, not optional, at this point because as far as I can see this obvious-sounding function is not implemented by anyone's libc. We can easily move it to AC_LIBOBJ later if it proves n

RFA: Fix libiberty testsuite failure

2020-01-20 Thread Nick Clifton
ix this. Is this OK ? Cheers Nick libiberty/ChangeLog 2020-01-20 Nick Clifton * testsuite/demangle-expected: Fix expected demangling. Index: libiberty/testsuite/demangle-expected === --- libiberty/testsuite/demangle-

Re: [PATCH] wwwdocs: contribute.html: Update consensus on patch content.

2024-05-20 Thread Nick Clifton
Hi Christophe, I have a follow-up one: I think the same applies to binutils, but I don't think any maintainer / contributor expressed an opinion, and IIUC patch policy for binutils is (lightly) documented at https://sourceware.org/binutils/wiki/HowToContribute Maybe Nick can update it?

Re: [PATCH 14/52] fr30: Remove macros {FLOAT,DOUBLE,LONG_DOUBLE}_TYPE_SIZE

2024-06-03 Thread Nick Clifton
Hi Kewen, This is to remove macros {FLOAT,{,LONG_}DOUBLE}_TYPE_SIZE defines in fr30 port. gcc/ChangeLog: * config/fr30/fr30.h (FLOAT_TYPE_SIZE): Remove. (DOUBLE_TYPE_SIZE): Likewise. (LONG_DOUBLE_TYPE_SIZE): Likewise. Approved - please apply. Cheers Nick

Re: [PATCH 15/52] frv: Remove macros {FLOAT,DOUBLE,LONG_DOUBLE}_TYPE_SIZE

2024-06-03 Thread Nick Clifton
Hi Kewen, This is to remove macros {FLOAT,{,LONG_}DOUBLE}_TYPE_SIZE defines in frv port. gcc/ChangeLog: * config/frv/frv.h (FLOAT_TYPE_SIZE): Remove. (DOUBLE_TYPE_SIZE): Likewise. (LONG_DOUBLE_TYPE_SIZE): Likewise. Approved - please apply. Cheers Nick

Re: [PATCH 18/52] iq2000: Remove macros {FLOAT,DOUBLE,LONG_DOUBLE}_TYPE_SIZE

2024-06-03 Thread Nick Clifton
Hi Kewen, This is to remove macros {FLOAT,{,LONG_}DOUBLE}_TYPE_SIZE defines in iq2000 port. gcc/ChangeLog: * config/iq2000/iq2000.h (FLOAT_TYPE_SIZE): Remove. (DOUBLE_TYPE_SIZE): Likewise. (LONG_DOUBLE_TYPE_SIZE): Likewise. Approved - please apply. Cheers Nick

Re: [PATCH 20/52] m32c: Remove macros {FLOAT,DOUBLE,LONG_DOUBLE}_TYPE_SIZE

2024-06-03 Thread Nick Clifton
Hi Kewen, This is to remove macros {FLOAT,{,LONG_}DOUBLE}_TYPE_SIZE defines in m32c port. gcc/ChangeLog: * config/m32c/m32c.h (FLOAT_TYPE_SIZE): Remove. (DOUBLE_TYPE_SIZE): Likewise. (LONG_DOUBLE_TYPE_SIZE): Likewise. Approved - please apply. Cheers Nick

Re: [PATCH 21/52] m32r: Remove macros {FLOAT,DOUBLE,LONG_DOUBLE}_TYPE_SIZE

2024-06-03 Thread Nick Clifton
Hi Kewen, This is to remove macros {FLOAT,{,LONG_}DOUBLE}_TYPE_SIZE defines in m32r port. gcc/ChangeLog: * config/m32r/m32r.h (FLOAT_TYPE_SIZE): Remove. (DOUBLE_TYPE_SIZE): Likewise. (LONG_DOUBLE_TYPE_SIZE): Likewise. Approved - please apply. Cheers Nick

Re: [PATCH 25/52] msp430: Remove macros {FLOAT,DOUBLE,LONG_DOUBLE}_TYPE_SIZE

2024-06-03 Thread Nick Clifton
Hi Kewen, This is to remove macros {FLOAT,{,LONG_}DOUBLE}_TYPE_SIZE defines in msp430 port. gcc/ChangeLog: * config/msp430/msp430.h (FLOAT_TYPE_SIZE): Remove. (DOUBLE_TYPE_SIZE): Likewise. (LONG_DOUBLE_TYPE_SIZE): Likewise. Approved - please apply. Cheers Nick

Re: [PATCH 32/52] stormy16: Remove macros {FLOAT,DOUBLE,LONG_DOUBLE}_TYPE_SIZE

2024-06-03 Thread Nick Clifton
Nick

Re: [PATCH 43/52] rx: New hook implementation rx_c_mode_for_floating_type

2024-06-03 Thread Nick Clifton
): New macro. * config/rx/rx.h (FLOAT_TYPE_SIZE): Remove. (DOUBLE_TYPE_SIZE): Likewise. (LONG_DOUBLE_TYPE_SIZE): Likewise. Approved - please apply. Cheers Nick

Re: [PATCH] RISC-V: Minimal support for Zimop extension.

2024-08-06 Thread Nick Clifton
Hi Jeff, 2.43 was released over an weekend.  Is it possible to let it be supported after 2.44? cc Nick and jan. I don't think it's critical enough to backport to 2.43.  I'd just put it on the trunk so that it's available in 2.44. It might be worth adding it to the 2.43

Re: [PATCH] RISC-V: Minimal support for Zimop extension.

2024-08-07 Thread Nick Clifton
Hi Nelson, Sounds good to me, too.  Once get the approval, I will backport them to binutils-2_43-branch :-) Please could you ping me once you have done that. I will make sure not to make the point release before receiving your message. Cheers Nick

Re: RFA: Fix declaration of default value of TARGET_NARROW_VOLATILE_BITFIELD

2013-08-20 Thread nick clifton
commit an update patch? Thanks. I have gone ahead and checked in this patch: Cheers Nick gcc/ChangeLog 2013-08-20 Nick Clifton * target.def (narrow_volatile_bitfield): Note that the default value is false, not !TARGET_STRICT_ALIGN. * doc/tm.texi: Regenerate. Index

Re: RFA: AVR: Support building AVR Linux targets

2013-08-23 Thread nick clifton
t fix it. C. Draw up another patch that restricts the AVR patterns in config.gcc to -none and -elf. Cheers Nick

Re: RFA: AVR: Support building AVR Linux targets

2013-08-27 Thread nick clifton
was not sure whether it was better to accept avr-*-elf or avr-*-elf*. I went for the latter in case there were AVR ELF variants, but I defer to your superior knowledge. OK to apply ? Cheers Nick gcc/ChangeLog 2013-08-27 Nick Clifton * config.gcc (AVR): Restrict allowed targets to

Re: [PING 3] [Patch RX] Add assembler option "-mcu" for generating assembler

2013-08-27 Thread nick clifton
Hi Sandeep, gas/config: 2013-07-18 Sandeep Kumar Singh * rx.h: Add option -mcpu for target variants RX100 and RX200. Approved - please apply. Cheers Nick

RFA: Testsuite: Add exceptions for MSP430

2013-09-16 Thread Nick Clifton
). OK to apply ? Cheers Nick gcc/testsuite/ChangeLog 2013-09-16 Nick Clifton * lib/target-supports.exp (check_effective_target_trampolines): Add MSP430 to the list of targets that do not support trampolines. (check_profiling_available): Add MSP430 to the list of

Commit: MSP430: Add support for interrupt handlers

2013-09-17 Thread Nick Clifton
functions (which disable interrupts whilst they execute) and reentrant functions (which disable interrupts but always reenable them upon exit). Tested with no regressions on an msp430-elf toolchain. Cheers Nick gcc/ChangeLog 2013-09-17 Nick Clifton * config/msp430/msp430-protos.h

Re: RFA: Testsuite: Add exceptions for MSP430

2013-09-17 Thread nick clifton
up. Cheers Nick

Commit: MSP430: Pass -md on to assembler

2013-09-18 Thread Nick Clifton
the function in the assembler output. This is mainly for debugging purposes. Cheers Nick gcc/ChangeLog 2013-09-18 Nick Clifton * config/msp430/msp430.h (ASM_SPEC): Pass -md on to the assembler. (ASM_DECLARE_FUNCTION_NAME): Define. Index: gcc/config/msp430/msp430.h

Commit: MSP430: Code gen improvements

2013-09-26 Thread Nick Clifton
PSI to SI conversion pattern for when signed pointer values need to be stored in an SI pair of registers. Cheers Nick gcc/ChangeLog 2013-09-26 Nick Clifton * config/msp430/msp430.c (msp430_expand_epilogue): Fix compile time warning message. (msp430_print_operand_raw

Re: Commit: MSP430: Pass -md on to assembler

2013-09-27 Thread nick clifton
object; __register_frame_info (__EH_FRAME_BEGIN__, &object); This only happens for the LARGE model (when pointers are PSImode) but I was baffled as to where it could be happening. Have you come across anything like this ? Cheers Nick

RFA: GCC Testsuite: Annotate compile tests that need at least 32-bit pointers/integers

2013-09-30 Thread Nick Clifton
regressions on msp430-elf, rl78-elf and xstormy16-elf targets. OK to apply ? Cheers Nick gcc/testsuite/ChangeLog 2013-09-30 Nick Clifton * gcc.c-torture/compile/20010327-1.c: Only run the test for int32plus targets. * gcc.c-torture/compile/990617-1.c: Likewise.

Re: RFA: GCC Testsuite: Annotate compile tests that need at least 32-bit pointers/integers

2013-10-01 Thread nick clifton
t have a good handle on wether this is better or not, so, I'll let you decide what you think is best. Thanks - that is a good idea. (I am embarrassed that I did not think of it myself). I have checked the patch in with this change added. Cheers Nick

RFC: Using DECL_NO_LIMIT_STACK as a backend specific flag

2012-10-03 Thread Nick Clifton
(no_limit_stack in this case). Is there a proper way to do this ? I have attached my current implementation to demonstrate the problem. Cheers Nick Index: gcc/config/rx/rx.c === --- gcc/config/rx/rx.c (revision 192034) +++ gcc/config/rx

Re: RFC: Using DECL_NO_LIMIT_STACK as a backend specific flag

2012-10-03 Thread nick clifton
very many. Maybe two or three at most. But I am interested to know if there is a way for targets to add their own information to function decls (and decls in general). If not for this particular case, then for problems to come in the future. Cheers Nick

Commit: RX: Warn about multiple fast interrupt routines.

2012-10-03 Thread Nick Clifton
problem. Cheers Nick PS. I have even remembered to include a patch to the html documentation as well! gcc/ChangeLog 2012-10-03 Nick Clifton * config/rx/rx.c (struct decl_chain): New local structure. (warned_decls): New local variable. Contains a stack of decls for

Re: [patch] unbreak iq2000 build a bit

2012-10-17 Thread nick clifton
00 port to build successfully. I have not submitted it upstream yet because I am not sure if it is the correct fix for the problem. Cheers Nick Index: gcc/dwarf2out.c === --- gcc/dwarf2out.c (revision 192527) +++ gcc/d

Re: Top Level GCC change questions

2012-10-26 Thread nick clifton
still up to individual contributors to keep these files in sync. Cheers Nick

RFA: Change behaviour of %* in spec strings

2013-10-17 Thread Nick Clifton
toolchain. OK to apply ? Cheers Nick gcc/ChangeLog 2013-10-17 Nick Clifton * gcc.c (do_spec_1): Do not insert a space after a %* substitution unless it is the last part of a spec substring. * doc/invoke.texi (Spec Files): Document space insertion behaviour of

Commit: testsuite/gcc.dg/20020312-2.c: Update for RL78 and MSP430

2013-10-24 Thread Nick Clifton
Hi Guys, I am applying the patch below as an obvious update to the 20020312-2.c test for the RL78 and MSP430 targets. Neither of them use a specific regiser for PIC support, but the test needs to be explicitly told that. Cheers Nick gcc/testsuite/ChangeLog 2013-10-24 Nick Clifton

RFA: Remove some assumptions from gcc.dg tests

2013-10-24 Thread Nick Clifton
-gnu toolchain with no regressions and several improvements. OK to apply ? Cheers Nick gcc/testsuite/ChangeLog 2013-10-24 Nick Clifton * c-c++-common/pr57793.c: Add expected error messages for targets with small integers. * gcc.dg/c99-stdint-1.c: Only run on 32-bit

Re: RFA: MIPS: Fix race condition causing PR 69129

2016-01-21 Thread Nick Clifton
Hi Matthias, https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69129 this fixes the bootstrap errors for me, seen in both libgnat and libgfortran. Great - I have gone ahead and checked the patch in. Cheers Nick

RFA: Fix for cygwin/mingw PR 66655

2016-01-26 Thread Nick Clifton
does turn out that these kinds of functions can also trigger this kind of bug, then the patch could be extended later. Plus a new bug report is likely to include a new testcase that can be added to the testsuite. So ... OK to apply ? Cheers Nick gcc/ChangeLog 2016-01-26 Nick Clifton

Re: [PATCH][ARM][2/4] Fix operand costing logic for SMUL[TB][TB]

2016-02-03 Thread Nick Clifton
Hi Kyrill, > 2016-01-22 Kyrylo Tkachov > > * config/arm/arm.c (arm_new_rtx_costs, MULT case): Properly extract > the operands of the SIGN_EXTENDs from a SMUL[TB][TB] rtx. Approved - please apply. Cheers Nick

Re: [PATCH][ARM][1/4] PR target/65932: Add testcase

2016-02-03 Thread Nick Clifton
Hi Kyrill, I would like to approve this patch, but cannot, since it is not ARM specific. I think that if you ping the list you may be able to get a response, and it would be nice to see this whole patch series checked in before the gcc 6 branch occurs. Cheers Nick PS. If necessary

Re: [PATCH][ARM][4/4] Adjust gcc.target/arm/wmul-[123].c tests

2016-02-03 Thread Nick Clifton
> 2016-01-22 Kyrylo Tkachov > > * gcc.target/arm/wmul-3.c: Simplify test to generate just > a single smulbb instruction. > * gcc.target/amr/wmul-1.c: Add -mtune=cortex-a9 to dg-options. > * gcc.target/amr/wmul-2.c: Likewise. Approved - please apply. Cheers Nick

RFC: Fix ARMv3 support

2016-02-16 Thread Nick Clifton
ode generation, so I added a fix to (silently) disable interworking if the target architecture does not support Thumb instructions. Any comments or criticisms before I apply the patch ? Cheers Nick gcc/ChangeLog 2016-02-16 Nick Clifton PR target/62554 PR target/69

Commit: MSP430: Update devices list

2016-02-17 Thread Nick Clifton
Hi Guys, I am checking in this patch to update the list of MSP430 devices built in to the msp430 backend. Cheers Nick gcc/ChangeLog 2016-02-17 Nick Clifton * config/msp430/msp430.c (msp430_mcu_data): Sync with data from TI's devices.csv file as of March 2016.

Re: [PATCH][ARM] PR target/69161: Don't ignore mode when matching comparison operator in cstore-like patterns

2016-02-17 Thread Nick Clifton
kewise, but don't ignore the mode. > +(define_predicate "arm_comparison_operator_mode" Please could you extend the comment here to reference the PR. That way anyone reading this code who wonders why we need to have two versions of the same predicate will be able understand what is happening. Cheers Nick

RFA: Prevent an ICE when redeclaring a static function as weak

2016-02-17 Thread Nick Clifton
/show_bug.cgi?id=49899 This submission is an updated version of that patch, made against the latest gcc sources. It still chooses to generate an error message and disallow the conversion, which I hope is the correct action. OK to apply ? Cheers Nick gcc/ChangeLog 2016-02-17 Nick

Re: RFC: Fix ARMv3 support

2016-02-18 Thread Nick Clifton
ure how important v3 support is any more (or support for any ARM architecture prior to v4t). Do you know of anyone who still needs it ? Cheers Nick

Re: RFA: Prevent an ICE when redeclaring a static function as weak

2016-02-22 Thread Nick Clifton
ght to be for gcc-7. It just feels wrong to have a patch to fix a known bug, but not to be able to apply it because the bug has always existed... Cheers Nick

Re: RFA: Prevent an ICE when redeclaring a static function as weak

2016-02-23 Thread Nick Clifton
Hi Jeff, > My inclination would be to defer to gcc-7. Richi, Jakub or Joseph, as > release managers, would have the final say though. It's OK. I will resubmit after gcc 6 branches. Cheers Nick

Commit: CR16: Add newlib-stdint.h to tm_file.

2016-03-01 Thread Nick Clifton
heers Nick gcc/ChangeLog 2016-03-01 Nick Clifton * config.gcc (cr16-*-elf): Add newlib-stdint.h to tm_file. Index: gcc/config.gcc === --- gcc/config.gcc (revision 233857) +++ gcc/config.gcc (working copy) @@ -1

RFA: MEP: Add newlib-stdint.h to tm_file.

2016-03-01 Thread Nick Clifton
OK to apply ? Tested with an mep-elf toolchain. Cheers Nick gcc/ChangeLog 2016-03-01 Nick Clifton * config.gcc (mep-*-elf): Add newlib-stdint.h to tm_file. Index: gcc/config.gcc === --- gcc/config.gcc (revision

Re: RFA: MEP: Add newlib-stdint.h to tm_file.

2016-03-02 Thread Nick Clifton
Hi DJ, > Ok. Thanks - patch committed. (I know that you have now deprecated the MeP port, but at least with this patch in place the toolchain can now be built if obsolete targets are enabled). Cheers Nick

RFA: PR 70044: Catch a second call to aarch64_override_options_after_change

2016-03-04 Thread Nick Clifton
, but using a special value of 2 to do so. Then when the second call occurs we can detect this case and ensure that we do not set flag_omit_leaf_frame_pointer to false. Tested with no regressions on an aarch64-elf toolchain. OK to apply ? Cheers Nick gcc/ChangeLog 2016-03-04 Nick Clifton

Commit: MSP430: Add wakeup function attribute

2013-12-13 Thread Nick Clifton
Hi Guys, I have applied the patch below to add support for a wakeup function attribute to the MSP430 backend. The wakeup attribute applies to interrupt functions, and it makes them wake the processor from low power sleep states when the interrupt handler exits. Cheers Nick gcc

Commit: MSP430: Add wakeup function attribute

2013-12-13 Thread Nick Clifton
interrupt handler exits. Cheers Nick gcc/ChangeLog 2013-12-13 Nick Clifton * config/msp430/msp430.c (is_wakeup_func): New function. Returns true if the current function has the wakeup attribute. (msp430_start_function): Note if the function has the wakeup

RFA: Fix test pr32912-2.c for 16-bit targets

2013-12-18 Thread Nick Clifton
place, not three. There were no regressions when tested with a i686-pc-linux-gnu or a x86_64-pc-linux-gnu toolchain, and the test was fixed for a rl78-elf toolchain. OK to apply ? Cheers Nick gcc/testsuite/ChangeLog 2013-12-18 Nick Clifton * gcc.dg/pr32912-2.c: Fix for 16

RFA: Use precision in get_mode_bounds()

2013-12-30 Thread Nick Clifton
so maybe there is a situation where using the bitsize is correct. There were no regressions and several fixed test cases with the msp430-elf toolchain that I was using, and no regressions with an i686-pc-linux-gnu toolchain. OK to apply ? Cheers Nick PS. Just found out that the same

Commit: MSP430: Add %A, %B, %C and %D as selectors for 16-bit parts of a 64-bit operand.

2013-12-30 Thread Nick Clifton
Hi Guys, I am applying the patch below to the MSP430 backend to enable the use of %A, %B, %C and %D in asm statements as selectors of 16-bit parts of a 64-bit value. This is at the request of TI, for compatibility with their compiler. Cheers Nick gcc/ChangeLog 2013-12-30 Nick

Re: RFA: Use precision in get_mode_bounds()

2013-12-31 Thread nick clifton
Hi Volker, apparently you added the wrong PR number to the patch. You probably meant PR 59613. Would you mind fixing that in the ChangeLog? Doh! Sorry - fixed. Cheers Nick

RFA: Fix assembler data directives emitted for variable length structures

2014-01-14 Thread Nick Clifton
couple of tests to the testsuite to check that the desired behaviour is achieved. Tested without regressions on i686-pc-linux-gnu and aarch64-elf toolchains, as well as bootstrapping and regression testing a powerpc64-linux toolchain. OK to apply ? Cheers Nick gcc/ChangeLog 2014-01

s390-linux fails to build

2015-07-23 Thread Nick Clifton
The patch below fixes the problem for me by adding a stub function in s390-common.c, but I am not sure if it is the correct solution. Please can you advise ? Cheers Nick Index: gcc/common/config/s390/s390-common.c === --- gcc/com

RFA: RL78: Add an optimization to the addsi3 pattern

2015-07-27 Thread Nick Clifton
anything in high memory relative to this symbol. Tested with no regressions on an rl78-elf toolchain. OK to apply ? Cheers Nick gcc/ChangeLog 2015-07-27 Nick Clifton * config/rl78/rl78.c (rl78_addsi3_internal): New function. Optimizes the case where -mes0 is active and

Commit: M32R: Fix handling of the __model__ attribute

2015-07-31 Thread Nick Clifton
Hi Guys, I am checking in the patch below to fix the M32R port's handling of its __model__ attribute. This attribute takes a parameter identifying the memory model to use, but gcc was not being told to expect this identifier. Cheers Nick gcc/ChangeLog 2015-07-31 Nick Cl

RFA: RL78: Remove far operand optimization in rl78_force_nonfar_3

2015-08-04 Thread Nick Clifton
? Cheers Nick gcc/ChangeLog 2015-08-04 Nick Clifton * config/rl78/rl78.c (rl78_force_nonfar_3): Remove optimization to allow identical far pointers to remain. gcc/testsuite/ChangeLog 2015-08-04 Nick Clifton * gcc.target/rl78: New directory. * gcc.target/rl78

RFA: RL78: Fix multiply costs when optimizing for size

2015-08-05 Thread Nick Clifton
regressions on an rl78-elf toolchain. OK to apply ? Cheers Nick gcc/ChangeLog 2015-08-05 Nick Clifton * config/rl78/rl78.c (rl78_rtx_costs): Treat MULT insns as cheap if optimizing for size. Index: gcc/config/rl78/rl78.c

Re: RFA: RL78: Remove far operand optimization in rl78_force_nonfar_3

2015-08-05 Thread Nick Clifton
Hi DJ, This is OK, but note that it prevents some operations like: __far int i; foo() { i ++; } from being implemented with a minimum set of opcodes. This might be particularly troublesome for volatile far things. Right - it is something I will have to look into. Cheers Nick

RFA: LM32: Configure with newlib-stdint.h

2015-10-06 Thread Nick Clifton
newlib stdint types were not being defined. So please may I apply the patch below to correct this problem ? Cheers Nick gcc/ChangeLog 2015-10-06 Nick Clifton * config.gcc (lm32-elf): Add newlib-stdint.h to tm_file. Index: gcc/config.gcc

Commit: RL78: Improve multiplication cost estimate

2015-10-06 Thread Nick Clifton
Hi DJ, This is the patch that I have checked in. Cheers Nick gcc/ChangeLog 2015-10-06 Nick Clifton * config/rl78/rl78.c (rl78_rtx_costs): Improve cost estimates for multiplication. Index: gcc/config/rl78/rl78.c

Commit: MSP430: Add support for persistent data

2015-10-06 Thread Nick Clifton
regressions on an msp430-elf toolchain. Cheers Nick gcc/ChangeLog 2015-10-06 Nick Clifton * config/msp430/msp430.c (ATTR_NOINIT): New constant. (ATTR_PERSIST): New constant. (msp430_data_attr): New function - verifies an attribute that only applies to variables

RFA/RFC: insns that do not start a source line

2015-10-22 Thread Nick Clifton
val ? Cheers Nick gcc/ChangeLog 2015-10-22 Nick Clifton * cfgrtl.c (not_a_stmt_hasher): New struct. (not_a_stmt_htab): New hash table. (is_a_stmt): New function. Returns true iff the given insn is on the list of insns known not to start a line of source c

Re: RFA/RFC: insns that do not start a source line

2015-10-22 Thread Nick Clifton
was investigating gdb's failure to apply breakpoints to the correct locations under some circumstances (such as the code in the testcase). There may well be other tests that have similar properties, especially loops that are unrolled or goto statements that cross basic blocks. Cheers Nick

Commit: MSP430: Pass silicon errata options on to the assembler

2015-10-22 Thread Nick Clifton
Hi Guys, I am checking in the patch below to allow gcc to pass the new MSP430 -msilicon-errata and -msilicon-errata-warn option on to the assembler. Cheers Nick gcc/ChangeLog 2015-10-22 Nick Clifton * config/msp430/msp430.opt: Add -msilicon-errata and -msilicon

Commit: Fix spelling mistake in RL78 documentation

2015-10-26 Thread Nick Clifton
Hi Guys, I am checking in the patch below to fix a small spelling mistake that I recently introduced to the RL78 documentation: gcc/ChangeLog 2015-10-26 Nick Clifton * doc/invoke.texi (RL78 Options): Fix spelling mistake. Index: gcc/doc/invoke.texi

RFC/RFA: Fix bug with REE optimization corrupting extended registers

2015-11-18 Thread Nick Clifton
and the extension instructions, but also where the extra hard registers are used for another purpose as well ? Tested with no regressions (or fixes) on an x86-pc-linux-gnu target. Also tested with no regression and 7 fixes on an rl78-elf target. Cheers Nick gcc/ChangeLog 2015-11-18 Nick

Re: RFC/RFA: Fix bug with REE optimization corrupting extended registers

2015-11-19 Thread Nick Clifton
that the extra hard registers are no used. (This is certainly true for the RL78, where the (patched) optimization does improve code, even though the widening does use extra registers). Cheers Nick

Re: RFC/RFA: Fix bug with REE optimization corrupting extended registers

2015-11-20 Thread Nick Clifton
certainly true for the RL78, where the (patched) optimization does improve code, even though the widening does use extra registers). Nick -- can you pass along your testcode? Sure - this is for the RL78 toolchain. In theory the problem is generic, but I have not tested other toolchains

Commit: MSP430: Reduce number of multilibs

2015-12-04 Thread Nick Clifton
/cleanup-[12|13|5].c). It also adds some new tests the MSP430 specific section of the gcc testsuite that check the behaviour of the multiply functions for all possible variations oh hardware multiply support. Cheers Nick [*] There is an exception to the all-files-call-software-multiply rule

Re: Type representation in CTF and DWARF

2019-10-15 Thread Nick Alcock
On 9 Oct 2019, Indu Bhagat told this: > Yes, CTF does not support C++ at this time. To cover all of C (including > GNU C extensions), we need to add representation for things like Vector type, > non IEEE float etc. (somewhat infrequently occurring constructs) One note: adding C++ support will not

Re: Type representation in CTF and DWARF

2019-10-17 Thread Nick Alcock
On 11 Oct 2019, Indu Bhagat stated: > Compile with -g -gdwarf-like-ctf and use dwz -o (using > dwz compiled from the master branch) on the generated binaries: > > (coreutils-0.22) > .debug_info(D1) | .debug_abbrev(D2) | .debug_str(D4) | .ctf > (uncompressed) | ratio (.ctf/(D1+D2+0.5*D4)) >

Re: Type representation in CTF and DWARF

2019-10-17 Thread Nick Alcock
On 17 Oct 2019, Richard Biener verbalised: > On Thu, Oct 17, 2019 at 7:36 PM Nick Alcock wrote: >> >> On 11 Oct 2019, Indu Bhagat stated: >> > Compile with -g -gdwarf-like-ctf and use dwz -o >> > (using >> > dwz compiled from the master branch) on th

Re: Type representation in CTF and DWARF

2019-10-18 Thread Nick Alcock
On 18 Oct 2019, Pedro Alves stated: > On 10/18/19 2:21 PM, Richard Biener wrote: > In most cases local types etc are a fairly small contributor to the total volume -- but macros can contribute a lot in some codebases. >>> (The Linux kernel's READ_ONCE macro is one I've personally be

RFA: Enhance information recorded by -frecord-gcc-switches

2017-06-08 Thread Nick Clifton
recording options already, c) it does not conflict with the current use of -fverbose-asm and d) it ties in nicely with the name of the option. Tested, with no regressions on an x86_64-pc-linux-gnu target, and built for a variety of other targets. OK to apply ? Cheers Nick gcc/ChangeLog 2017

Re: RFA: Enhance information recorded by -frecord-gcc-switches

2017-06-08 Thread Nick Clifton
route, in the binaries. This can be useful to users, or distributors, who want to check that, for example, a specific security option was enabled, or that a particular a particular optimization was run. Cheers Nick

Re: RFA: Enhance information recorded by -frecord-gcc-switches

2017-06-08 Thread Nick Clifton
ferent compiler versions, some of the options > are ignored, others are added, others change meaning, and expanding the list > of guarded options isn't really useful. OK -so we need some other way of recording what optimization passes were actually run. Fortunately I have something in mind. Patch withdrawn. Cheers Nick

Re: [PATCH 2/2] [MSP430] Fix issues handling .persistent attribute (PR 78818)

2017-06-13 Thread Nick Clifton
Hi Jozef, > Ok for trunk and gcc-7-branch? Approved - please apply (to both). Cheers Nick

Re: [PATCH 2/2] [MSP430] Fix issues handling .persistent attribute (PR 78818)

2017-06-15 Thread Nick Clifton
Hi Jozef, > Sorry, didn't mention in that last post that I don't have write access, > could someone please apply this for me. Applied. Sorry about the delay (again). Cheers Nick

Re: [PATCH 0/3] Add __builtin_load_no_speculate

2018-01-08 Thread Nick Clifton
that I am an expert in this area, but I do think that it is something that should be discussed... Cheers Nick

RFA: Restore ability to build zlib in a srcdir == builddir

2018-06-18 Thread Nick Clifton
? Cheers Nick ./ChangeLog * zlib/configure.ac: Restore old behaviour of only enabling multilibs when a target subdirectory is defined. This allows building with srcdir == builddir. * zlib/configure: Regenerate. diff --git a/zlib/configure.ac b/zlib/configure.ac

Re: [tree.c] Replace cast to (char *) by const_cast

2018-06-18 Thread Nick Clifton
y thanks very much for catching this problem and proposing a fix. I guess that I must be using an old version of g++ for my testing as this error did not show up. :-( Cheers Nick

Re: RFA: Sanitize deprecation messages (PR 84195)

2018-06-18 Thread Nick Clifton
Hi Martin, > I'm getting a bootstrap failure: *sigh* yes - my bad. Fortunately a patch has already been posted: https://gcc.gnu.org/ml/gcc-patches/2018-06/msg01039.html And I think that it has now been approved. Cheers Nick

Re: [RX] Fix PR 81821

2018-01-11 Thread Nick Clifton
Hi Oleg, > OK for trunk and GCC 7? Approved. Do you have access to the repository, or would you like me to apply the patch for you ? Cheers Nick

Re: [RX] Fix PR 81819

2018-01-11 Thread Nick Clifton
Hi Oleg, > gcc/ChangeLog: > PR target/81819 > * config/rx/rx.c (rx_is_restricted_memory_address): > Handle SUBREG case. Go ahead make my day^H^H^H^H^H^H Approved - please apply. Cheers Nick

RFA: PR 84154: Fix checking -mibt and -mshstk options for control flow protection

2018-02-05 Thread Nick Clifton
hstk to enable CET % gcc -c main.c -fcf-protection=return -mshstk % What do you think ? Is the patch OK for the mainline ? Cheers Nick gcc/ChangeLog 2018-02-05 Nick Clifton PR 84145 * config/i386/i386.c (ix86_option_override_internal): Rework checks fo

RFA: Sanitize deprecation messages (PR 84195)

2018-02-05 Thread Nick Clifton
it simple. :-) No regressions with an x86_64-pc-linux-gnu toolchain. OK to apply ? Cheers Nick gcc/ChangeLog 2018-02-05 Nick Clifton PR 84195 * tree.c (warn_deprecated_use): Sanitize deprecation messages. Index: gcc/tree.c

Re: PR 84154: Fix checking -mibt and -mshstk options for control flow protection

2018-02-06 Thread Nick Clifton
ld you incorporate my changes and proceed? Or would you like me to finish > the fix? If you are happy to finish the fix then please do so. Your fix is more thorough than mine, so I am happy to see it go on. Although I should say that I am not an x86 maintainer, so I cannot approve it. Cheers Nick

Re: RFA: Sanitize deprecation messages (PR 84195)

2018-02-06 Thread Nick Clifton
racters so a very long, single word message will not be split...) Cheers Nick

  1   2   3   4   5   6   >