Re: [pph] Add initial support for including nested pph images (issue4847044)

So if I understand correctly, the reference system doesn't work yet, you just put out the design in this patch and you'll fill up functionality in an upcoming patch so that's it's clearer what you're adding? Cheers, Gab http://codereview.appspot.com/4847044/diff/1/gcc/cp/pph-streamer-in.c File

Re: [pph] Stream and merge line table. (issue4836050)

Fixed all, committing to pph. Regarding builtins, it looked like some builtins like "int type" were streamed out as part of streaming out a non-builtin decl, i.e. a non-builtins with builtins in it's transitive closure. http://codereview.appspot.com/4836050/diff/1/gcc/cp/pph-streamer-out.c File

Re: [pph] Allocate string tables separately. (issue4843044)

Yep this fixes the problem I had with the strings being freed early. See comments inline below. http://codereview.appspot.com/4843044/diff/1/gcc/cp/pph-streamer-in.c File gcc/cp/pph-streamer-in.c (right): http://codereview.appspot.com/4843044/diff/1/gcc/cp/pph-streamer-in.c#newcode157 gcc/cp/p

Re: [pph] Reorganize pph read/write file into their respective streamers (issue4657042)

Note: There might now be unused headers in pph.c (although I didn't need to add any headers to the streamers, so it would have to be one of the headers they all use). http://codereview.appspot.com/4657042/

Re: [pph] Stream scope_chain->bindings instead of global namespace (issue4661045)

So it looks like my mail using the upload script didn't make it out... let me retype it... On 2011/06/22 20:51:58, Diego Novillo wrote: http://codereview.appspot.com/4661045/diff/1/gcc/cp/pph-streamer-in.c File gcc/cp/pph-streamer-in.c (right): http://codereview.appspot.com/4661045/diff/1/gcc

Re: [pph] Stream chain of struct fields (issue4631072)

Fixes two pph BOGUS bugs which now result in an asm diff. Tested with bootstrap build and pph regression testing. http://codereview.appspot.com/4631072/

Re: [pph] Fix var order when streaming in. (issue4635074)

On 2011/06/28 11:27:56, Diego Novillo wrote: http://codereview.appspot.com/4635074/diff/1/gcc/cp/pph-streamer-in.c File gcc/cp/pph-streamer-in.c (right): http://codereview.appspot.com/4635074/diff/1/gcc/cp/pph-streamer-in.c#newcode1144 gcc/cp/pph-streamer-in.c:1144: /* The chains are built ba

Re: [pph] Add cp_global_trees to cache in preload (issue4635077)

Commited as r175595. http://codereview.appspot.com/4635077/

Re: [pph] Fix executable test detection (issue4635087)

I should add that this exposed two assembly comparison failures which slipped in a previous check-in when this problem was still up. Namely: FAIL: g++.dg/pph/x1dynarray0.cc (assembly comparison) FAIL: g++.dg/pph/x1dynarray1.cc (assembly comparison) Lawrence is reorganizing those tests as we spe

Re: [pph] Stream first/weak_object_global_name (issue4641086)

So I did find a better way of doing this, see Issue #4627087. I'll go ahead and close this issue. On 2011/07/01 01:27:26, Gabriel Charette wrote: notice_global_symbol is actually called in the parser (before we stream out). I just confirmed this by setting a break point on the function in th

Re: [pph] Expect checksums for tests marked with pph asm xdiff (issue4744043)

See below. http://codereview.appspot.com/4744043/diff/3001/gcc/testsuite/lib/dg-pph.exp File gcc/testsuite/lib/dg-pph.exp (right): http://codereview.appspot.com/4744043/diff/3001/gcc/testsuite/lib/dg-pph.exp#newcode131 gcc/testsuite/lib/dg-pph.exp:131: set adiff [catch {exec diff "$bname.s-pph"

Re: Remove unused line_maps field last_listed (issue4810058)

Forgot to mention: Tested with bootstrap build and full regression testing. On 2011/07/28 17:55:15, Gabriel Charette wrote: The last_listed field in struct line_maps was never used, removed it. Gab 2011-07-28 Gabriel Charette * libcpp/include/line-m

Re: [pph] Put tinst_level list in forward order (issue4823059)

LGTM http://codereview.appspot.com/4823059/