Re: [PATCH, RFC]: Next stage1, refactoring: propagating rtx subclasses

2015-05-08 Thread Trevor Saunders
On Mon, May 04, 2015 at 11:32:38PM +0300, Mikhail Maltsev wrote: > > You'd probably be better off creating a unique rtx_insn * object and > > using that as the marker. > OK. Fixed the patch. Rebased and tested on x86_64-linux (fortunately, it > did not conflict with Trevor's series of rtx_insn-rela

Re: [PATCH 2/4] New data structure for cgraph_summary introduced.

2014-11-13 Thread Trevor Saunders
On Thu, Nov 13, 2014 at 03:48:34PM +0100, Markus Trippelsdorf wrote: > On 2014.11.13 at 15:11 +0100, mliska wrote: > > Just two remarks: > > > +template > > +class GTY((user)) cgraph_summary > > +{ > > +public: > > + /* Default construction takes SYMTAB as an argument. */ > > + cgraph_summar

Re: [PATCH 2/4] New data structure for cgraph_summary introduced.

2014-11-13 Thread Trevor Saunders
On Thu, Nov 13, 2014 at 11:23:31PM +0100, Markus Trippelsdorf wrote: > On 2014.11.14 at 01:19 -0500, Trevor Saunders wrote: > > On Thu, Nov 13, 2014 at 03:48:34PM +0100, Markus Trippelsdorf wrote: > > > On 2014.11.13 at 15:11 +0100, mliska wrote: > > >

Re: [PATCH 1/5] add an alternative to if_marked using hash_table

2014-11-13 Thread Trevor Saunders
On Thu, Nov 13, 2014 at 05:27:13PM -0700, Jeff Law wrote: > On 11/12/14 22:55, tsaund...@mozilla.com wrote: > >From: Trevor Saunders > > > >Hi, > > > > This adds a gty cache attribute that calls user code after marking and > > before > >sweeping all

Re: [PATCH 5/5] use vec in lto_tree_ref_table

2014-11-13 Thread Trevor Saunders
On Thu, Nov 13, 2014 at 05:52:51PM -0700, Jeff Law wrote: > On 11/12/14 22:55, tsaund...@mozilla.com wrote: > >From: Trevor Saunders > > > >Hi, > > > >gengtype fails to create valid user marking functions for this type, which is > >fixed by usi

Re: [PATCH 4/5] remove param$N_is usage

2014-11-13 Thread Trevor Saunders
On Thu, Nov 13, 2014 at 05:49:47PM -0700, Jeff Law wrote: > On 11/12/14 22:55, tsaund...@mozilla.com wrote: > >From: Trevor Saunders > > > >Hi, > > > >The only user of this is splay_tree. We only have a couple splay trees in > >ggc > >memory, an

Re: [PATCH 2/5] remove the remaining uses of if_marked

2014-11-13 Thread Trevor Saunders
On Thu, Nov 13, 2014 at 05:32:08PM -0700, Jeff Law wrote: > On 11/12/14 22:55, tsaund...@mozilla.com wrote: > >From: Trevor Saunders > > > >Hi, > > > >$subject. > > > >bootstrapped + regtested x86_64-unknown-linux-gnu, ok? > > > >Tre

Re: [PATCH 8/9] Negative numbers added for sreal class.

2014-11-13 Thread Trevor Saunders
On Fri, Nov 14, 2014 at 12:40:23AM +0100, Jan Hubicka wrote: > Hello, > in general I like this addition - I was not aware that sreal has no support > for negative values. > This would be serious maintainance burden if sreals was used for profile > updating - it is very > easy to get negative temp

Re: [PATCH 4/4] Data structure is used for inline_summary struct.

2014-11-18 Thread Trevor Saunders
On Tue, Nov 18, 2014 at 07:59:26PM +0100, Jan Hubicka wrote: > > Hi, > > > > On Tue, Nov 18, 2014 at 04:39:00PM +0100, Jan Hubicka wrote: > > > > On Fri, Nov 14, 2014 at 08:59:10PM +0100, Jan Hubicka wrote: > > > > > > > > > > > > > > > b) with GTY, we cannot call destructor > > > > > > > > > >

Re: [PATCH 17/21] PR jit/63854: Fix leaking vec in jit

2014-11-19 Thread Trevor Saunders
On Wed, Nov 19, 2014 at 05:46:17AM -0500, David Malcolm wrote: > This fixes various leaks of vec buffers seen via valgrind within jit > (both recording and playback). > > Various vec<> within jit::recording are converted to auto_vec<>. > > Various playback::wrapper subclasses containing vec<> gai

Re: [PATCH] pr63856 - test case

2014-11-23 Thread Trevor Saunders
> > +{ > > + return ((v4hi) A)[N]; > > +} > > + > > +int __attribute__ ((noinline, noclone)) g (v2si A, int N) > > +{ > > + return ((v4hi) A)[N]; > > +} > > -- > > 2.1.3 > > Jakub From 1b9dc2c209614d598658579ad6faba112c64ca0f Mon Sep 17 00:00

Re: [PATCH] pr61324 pr 63649 - fix crash in ipa_comdats

2014-11-25 Thread Trevor Saunders
On Tue, Nov 25, 2014 at 09:59:46PM +0100, Jan Hubicka wrote: > > From: Trevor Saunders > > > > Hi, > > > > the interesting symbol in the test case for pr61324 is __GLOBAL__sub_I_s. > > It > > refers to nothing, and is called by nothing, however i

Re: [PATCH 04/08] PR jit/63854: Remove xstrdup from ipa/cgraph fprintf calls

2014-11-26 Thread Trevor Saunders
On Wed, Nov 26, 2014 at 09:49:52AM -0500, David Malcolm wrote: > On Wed, 2014-11-26 at 09:13 +0100, Uros Bizjak wrote: > > Hello! > > > > > cgraph*.c and ipa-*.c use xstrdup on strings when dumping them via > > > fprintf, leaking all of the duplicated buffers. > > > > > > Is/was there a reason for

Re: [PATCH] pr61324 pr 63649 - fix crash in ipa_comdats

2014-11-27 Thread Trevor Saunders
On Tue, Nov 25, 2014 at 09:59:46PM +0100, Jan Hubicka wrote: > > From: Trevor Saunders > > > > Hi, > > > > the interesting symbol in the test case for pr61324 is __GLOBAL__sub_I_s. > > It > > refers to nothing, and is called by nothing, however i

Re: [PATCH, RFC]: Next stage1, refactoring: propagating rtx subclasses

2015-03-31 Thread Trevor Saunders
On Tue, Mar 31, 2015 at 07:37:40AM +0300, Mikhail Maltsev wrote: > Hi! > > I'm currently working on the proposed task of replacing rtx objects > (i.e. struct rtx_def) with derived classes. I would like to get some > feedback on this work (it's far from being finished, but basically I > would like

Re: [PATCH] Move gen_* stubs from defaults.h to genflags

2015-06-10 Thread Trevor Saunders
On Wed, Jun 10, 2015 at 07:28:10AM +0300, Mikhail Maltsev wrote: > Hi, all. > > I noticed that defaults.h file contains stub generator functions which > simply call gcc_unreachable. FWIW, Trevor added them to remove some > conditional compilation which depends on HAVE_ macros (I mean > something l

Re: Add .def file for public target instructions

2015-07-01 Thread Trevor Saunders
On Tue, Jun 23, 2015 at 07:41:42PM +0100, Richard Sandiford wrote: > [A fair bit later than promised, sorry...] > > Mikhail posted a patch to make genflags generate the default HAVE_foo > and gen_foo definitions that have recently been added to defaults.h: > > https://gcc.gnu.org/ml/gcc-patches

Re: [02/13] Replace handle_cache_entry with new interface

2015-07-01 Thread Trevor Saunders
On Tue, Jun 16, 2015 at 09:45:56AM +0100, Richard Sandiford wrote: > As described in the covering note, this patch replaces handle_cache_entry > with a new function keep_cache_entry. It also ensures that elements are > deleted using the proper function, so that m_n_deleted is updated. Thanks for

Re: [02/13] Replace handle_cache_entry with new interface

2015-07-01 Thread Trevor Saunders
On Wed, Jul 01, 2015 at 10:59:15AM +0100, Richard Sandiford wrote: > Trevor Saunders writes: > > On Tue, Jun 16, 2015 at 09:45:56AM +0100, Richard Sandiford wrote: > >> I couldn't tell whether the unusual name of the function > >> ("gt_cleare_cache&quo

Re: [RFC, PATCH] Split pool_allocator and create a new object_allocator

2015-07-02 Thread Trevor Saunders
On Thu, Jul 02, 2015 at 09:09:31PM +0100, Richard Sandiford wrote: > Martin Liška writes: > > diff --git a/gcc/asan.c b/gcc/asan.c > > index e89817e..dabd6f1 100644 > > --- a/gcc/asan.c > > +++ b/gcc/asan.c > > @@ -362,20 +362,20 @@ struct asan_mem_ref > >/* Pool allocation new operator. */ >

Re: [PATCH] pr 64076 - tolerate different definitions of symbols in lto

2015-01-20 Thread Trevor Saunders
On Tue, Jan 20, 2015 at 10:18:25AM +0100, Richard Biener wrote: > On Tue, Jan 20, 2015 at 3:31 AM, wrote: > > From: Trevor Saunders > > > > Hi, > > > > when doing an lto link we can have some symbols be ir only and others be > > machine code, which trips t

patch ping

2015-02-09 Thread Trevor Saunders
Hi, I'd like to ping these patches http://gcc.gnu.org/ml/gcc-patches/2015-01/msg02716.html pr 61889 - p1 don't require ftw.h in gcov-tool.c http://gcc.gnu.org/ml/gcc-patches/2015-01/msg01869.html pr 64076 - p2 - don't ICE on invalid code that has ironly and not ironly thunks thanks! Trev

Re: Chromium: LTO

2015-02-15 Thread Trevor Saunders
Hi, > +symtab_node::iterate_direct_aliases (unsigned i, ipa_ref *&ref) > +{ > + ref_list.referring.iterate (i, &ref); > + > + if (ref && ref->use != IPA_REF_ALIAS) > +return NULL; > + > + return ref; > +} it seems a little weird the out arg can return a non alias, and so if you only want t

Re: hash-table violation in gcc/fortran/trans-decl.c

2018-10-31 Thread Trevor Saunders
On Tue, Oct 30, 2018 at 11:07:16AM +0100, Martin Li??ka wrote: > On 10/29/18 12:04 PM, Martin Li??ka wrote: > > 2) gfc_find_module > > > > $ ./xgcc -B. > > /home/marxin/Programming/gcc/gcc/testsuite/gfortran.dg/coarray/alloc_comp_2.f90 > > -fcoarray=single -fchecking=3 > > hash table checking fa

Re: protected alloca class for malloc fallback

2016-08-08 Thread Trevor Saunders
On Mon, Aug 08, 2016 at 11:00:28AM -0600, Jeff Law wrote: > On 08/06/2016 09:08 AM, Richard Biener wrote: > > On August 6, 2016 12:15:26 PM GMT+02:00, Aldy Hernandez > > wrote: > > > On 08/05/2016 04:07 PM, Richard Biener wrote: > > > > On August 5, 2016 8:15:54 PM GMT+02:00, Oleg Endo > > > wro

Re: protected alloca class for malloc fallback

2016-08-09 Thread Trevor Saunders
On Tue, Aug 09, 2016 at 08:33:49PM +0900, Oleg Endo wrote: > On Mon, 2016-08-08 at 13:39 -0400, Trevor Saunders wrote: > > > > First sizeof std::string is 32 on x86_64, a char *, a size_t for the > > length, and a 16 byte union of a size_t for allocated size and a 16 >

Re: protected alloca class for malloc fallback

2016-08-10 Thread Trevor Saunders
On Thu, Aug 11, 2016 at 02:03:29AM +0900, Oleg Endo wrote: > On Tue, 2016-08-09 at 13:41 -0400, Trevor Saunders wrote: > > > If what you want is the ability to put the buffer on the stack > > instead of the heap then I think a stack_string class that > > interoperates wi

Re: protected alloca class for malloc fallback

2016-08-11 Thread Trevor Saunders
On Thu, Aug 11, 2016 at 09:18:34PM +0900, Oleg Endo wrote: > On Wed, 2016-08-10 at 21:31 -0400, Trevor Saunders wrote: > > > > > Well, I'd say the compromises made in std::string make it pretty > > terrible for general purpose use accept where perf and mem

Re: [PATCH 3/4] Add support to run auto-vectorization tests for multiple effective targets

2016-08-15 Thread Trevor Saunders
On Tue, Jul 26, 2016 at 01:51:33PM +, Robert Suchanek wrote: > Hi, > > > On May 5, 2016, at 8:14 AM, Robert Suchanek > > wrote: > > > > > > I'm resending this patch as it has been rebased and updated. I reverted a > > change > > > to check_effective_target_vect_call_lrint procedure because

Re: [PATCH] DWARF: space-optimize loc. descr. for integer literals on 32-bit targets

2016-08-18 Thread Trevor Saunders
On Thu, Aug 18, 2016 at 11:33:06AM +0200, Pierre-Marie de Rodat wrote: > Hello, > > This enhances location description generation so that the generated > opcodes for integer literals are as space-efficient when HOST_WIDE_INT > is 64-bits large than when it's 32-bits large. In particular, this > re

Re: [PATCH] - improve sprintf buffer overflow detection (middle-end/49905)

2016-08-19 Thread Trevor Saunders
> > > Patch #5 and beyond: Further optimization work. > > > > As one of the next steps I'd like to make this feature available > > to user-defined sprintf-like functions decorated with attribute > > format. To do that, I'm thinking of adding either a fourth > > (optional) argument to attribute fo

Re: [PATCH] remove HARD_FRAME_POINTER_IS_ARG_POINTER macro

2016-08-21 Thread Trevor Saunders
On Sat, Aug 20, 2016 at 06:46:22PM +, Bernd Edlinger wrote: > > its kind of silly, and this allows us to remove a few more #ifdefs. > > > > bootstrapped + regtest x86_64-linux-gnu, ok? > > No, I don't think so, because: > > > #if FRAME_POINTER_REGNUM != ARG_POINTER_REGNUM > > -#if HARD_

Re: C++11? (Re: protected alloca class for malloc fallback)

2016-08-22 Thread Trevor Saunders
On Sun, Aug 21, 2016 at 09:00:26PM +0100, Pedro Alves wrote: > On 08/20/2016 03:29 AM, Mike Stump wrote: > > On Aug 10, 2016, at 10:03 AM, Oleg Endo wrote: > >> > >> Or just wait until people have agreed to switch to C++11 or C++14. I > >> don't think in practice anybody uses an C++11-incapable G

Re: [patch] [gsoc] [gimplefe] GIMPLE FE Project

2016-08-22 Thread Trevor Saunders
On Sun, Aug 21, 2016 at 10:35:17PM +0530, Prasad Ghangal wrote: > Hi all, > > As a part of my gsoc project. I have completed the following tasks: > > * Parsed gimple-expression > * Parsed gimple-labels > * Parsed local declaration > * Parsed gimple-goto statement > * Parsed gimple-if-else stateme

Re: [PATCH] remove HARD_FRAME_POINTER_IS_ARG_POINTER macro

2016-08-22 Thread Trevor Saunders
On Mon, Aug 22, 2016 at 11:25:01AM +0200, Bernd Schmidt wrote: > On 08/20/2016 07:07 PM, tbsaunde+...@tbsaunde.org wrote: > > From: Trevor Saunders > > > > Hi, > > > > its kind of silly, and this allows us to remove a few more #ifdefs. > > > #if

Re: [patch] [gsoc] [gimplefe] GIMPLE FE Project

2016-08-22 Thread Trevor Saunders
On Tue, Aug 23, 2016 at 12:10:29AM +0530, Prasad Ghangal wrote: > On 22 August 2016 at 16:55, Trevor Saunders wrote: > > On Sun, Aug 21, 2016 at 10:35:17PM +0530, Prasad Ghangal wrote: > >> Hi all, > >> > >> As a part of my gsoc project. I have completed the

Re: [patch] [gsoc] [gimplefe] GIMPLE FE Project

2016-08-23 Thread Trevor Saunders
On Tue, Aug 23, 2016 at 09:46:50AM +0200, Richard Biener wrote: > On Mon, Aug 22, 2016 at 11:54 PM, Pedro Alves wrote: > > On 08/22/2016 10:26 PM, David Malcolm wrote: > > > >> it has no problems, whereas with the default for gcc 5 and earlier: > >> > >> $ gcc -c test.cc -std=gnu++98 > >> test

Re: [PATCH 3/4] Add support to run auto-vectorization tests for multiple effective targets

2016-08-23 Thread Trevor Saunders
On Tue, Aug 23, 2016 at 09:52:23AM -0600, Jeff Law wrote: > On 08/23/2016 02:15 AM, Robert Suchanek wrote: > > Hi, > > > > > unfortunately this broke make check-c > > > RUNTESTFLAGS='vect.exp=*no-vfa-vect-dv-2.c > > > --target_board=unix\{-m32,-m64\}', causing the check if > > > vect_aligned_array

Re: [PATCH 0/4] Applying fix-its on behalf of the user to their code

2016-08-24 Thread Trevor Saunders
On Wed, Aug 24, 2016 at 09:59:18AM +0200, Richard Biener wrote: > On Wed, Aug 24, 2016 at 3:28 AM, David Malcolm wrote: > > Currently our diagnostics subsystem can emit fix-it hints > > suggesting edits the user can make to their code to fix warnings/errors, > > but currently the user must make th

Re: [PATCH 3/3] make stack_slot_list a vec

2016-08-26 Thread Trevor Saunders
On Thu, Aug 25, 2016 at 10:46:14AM +0200, Bernd Schmidt wrote: > On 08/25/2016 08:50 AM, tbsaunde+...@tbsaunde.org wrote: > > @@ -2626,8 +2626,10 @@ unshare_all_rtl_1 (rtx_insn *insn) > > This special care is necessary when the stack slot MEM does not > > actually appear in the insn cha

Re: [PATCH 3/4] (v2) Introduce class edit_context

2016-08-28 Thread Trevor Saunders
On Wed, Aug 24, 2016 at 09:13:51PM -0400, David Malcolm wrote: > This version removes edit_context::apply_changes and related > functionality, retaining the ability to generate diffs. > > It also improves error-handling (adding a selftest for this). > > gcc/ChangeLog: > * Makefile.in (OBJS-

Re: [PATCH 3/4] (v2) Introduce class edit_context

2016-08-29 Thread Trevor Saunders
On Mon, Aug 29, 2016 at 02:53:43PM -0400, David Malcolm wrote: > On Sun, 2016-08-28 at 11:13 -0400, Trevor Saunders wrote: > > On Wed, Aug 24, 2016 at 09:13:51PM -0400, David Malcolm wrote: > > > + > > > + const char *m_filename; > > > + char *m_content; &g

Re: More backwards/FSM jump thread refactoring and extension

2016-05-24 Thread Trevor Saunders
On Tue, May 24, 2016 at 10:58:18AM -0600, Jeff Law wrote: > --- a/gcc/tree-ssa-threadbackward.c > +++ b/gcc/tree-ssa-threadbackward.c > @@ -356,6 +356,44 @@ profitable_jump_thread_path (vec > *&path, >return taken_edge; > } > > +/* PATH is vector of blocks forming a jump threading path in r

Re: [PATCH] Selftest framework (v7)

2016-06-06 Thread Trevor Saunders
> > As far as I can > > tell this just involves moving the start of namespace selftest > > upwards a > > bit in the files where we have tests. > > Yes, and it does seem cleaner to have all of the selftest code start > like this: > > #if CHECKING_P What are we gaining by ifdefing this? I woul

Re: [PATCH] Selftest framework (v7)

2016-06-06 Thread Trevor Saunders
On Mon, Jun 06, 2016 at 11:57:49PM +0200, Jakub Jelinek wrote: > On Mon, Jun 06, 2016 at 05:53:50PM -0400, Trevor Saunders wrote: > > > > As far as I can > > > > tell this just involves moving the start of namespace selftest > > > > upwards a >

Re: [PATCH] Selftest framework (v7)

2016-06-07 Thread Trevor Saunders
On Tue, Jun 07, 2016 at 10:18:32AM -0400, David Malcolm wrote: > On Mon, 2016-06-06 at 22:14 -0400, Trevor Saunders wrote: > > On Mon, Jun 06, 2016 at 11:57:49PM +0200, Jakub Jelinek wrote: > > > On Mon, Jun 06, 2016 at 05:53:50PM -0400, Trevor Saunders wrote: > >

Re: [PATCH 1/3] config-list.mk: add KNOWN_BROKEN

2016-06-09 Thread Trevor Saunders
On Thu, Jun 09, 2016 at 04:25:32PM +, Joseph Myers wrote: > On Thu, 9 Jun 2016, Jeff Law wrote: > > > On 05/26/2016 09:04 AM, David Malcolm wrote: > > > When using config-list.mk to build all configurations, it's useful > > > to filter out the configurations that are known to be broken. > > >

Re: [PATCH 0/6] remove some usage of rtx_{insn,expr}_list

2016-06-21 Thread Trevor Saunders
On Mon, Jun 20, 2016 at 06:52:35PM +0200, Bernd Schmidt wrote: > On 06/20/2016 12:22 PM, tbsaunde+...@tbsaunde.org wrote: > > In theory I would expect if anything this helps performance since it isn't > > necessary to malloc every time a node is added, however the data is less > > clear. > > Well

Re: [PATCH 6/6] loop-iv.c: make cond_list a vec

2016-06-21 Thread Trevor Saunders
On Mon, Jun 20, 2016 at 09:11:21PM +0100, Richard Sandiford wrote: > tbsaunde+...@tbsaunde.org writes: > > diff --git a/gcc/loop-iv.c b/gcc/loop-iv.c > > index 57fb8c1..21c3180 100644 > > --- a/gcc/loop-iv.c > > +++ b/gcc/loop-iv.c > > @@ -1860,7 +1860,6 @@ simplify_using_initial_values (struct loo

Re: [PATCH 2/9] c-decl.c: add [cd]tors to c_struct_parse_info

2016-06-29 Thread Trevor Saunders
On Wed, Jun 29, 2016 at 09:21:01AM -0400, David Malcolm wrote: > On Wed, 2016-06-29 at 08:26 -0400, tbsaunde+...@tbsaunde.org wrote: > > From: Trevor Saunders > > > > gcc/c/ChangeLog: > > I may be missing my coffee here but you mention adding a constructor in > th

Re: [committed][PATCH] Convert sprintf warning code to a dominator walk

2017-10-29 Thread Trevor Saunders
On Fri, Oct 27, 2017 at 02:03:59PM -0400, David Malcolm wrote: > On Fri, 2017-10-27 at 10:55 -0600, Jeff Law wrote: > > Prereq for eventually embedding range analysis into the sprintf > > warning > > pass. The only thing that changed since the original from a few days > > ago was the addition of F

Re: [RFA][PATCH] Provide a class interface into substitute_and_fold.

2017-10-29 Thread Trevor Saunders
On Wed, Oct 25, 2017 at 11:20:38AM -0600, Jeff Law wrote: > On 10/24/2017 03:45 PM, Jeff Law wrote: > > On 10/24/2017 02:57 PM, David Malcolm wrote: > >> On Tue, 2017-10-24 at 12:44 -0600, Jeff Law wrote: > >>> This is similar to the introduction of the ssa_propagate_engine, but > >>> for > >>> the

Re: [09/nn] Add a fixed_size_mode_pod class

2017-10-29 Thread Trevor Saunders
On Thu, Oct 26, 2017 at 09:37:31PM +0200, Eric Botcazou wrote: > > Can you figure what oldest GCC release supports the C++11/14 POD handling > > that would be required? > > GCC needs to be buildable by other compilers than itself though. It sounds like people are mostly concerned about sun studio

Re: [006/nnn] poly_int: tree constants

2017-10-29 Thread Trevor Saunders
On Sun, Oct 29, 2017 at 10:25:38AM -0600, Martin Sebor wrote: > On 10/27/2017 02:08 AM, Richard Sandiford wrote: > > Martin Sebor writes: > > > On 10/26/2017 11:52 AM, Richard Sandiford wrote: > > > > Martin Sebor writes: > > > > > For offset_int the default precision is 128-bits. Making that >

Re: [09/nn] Add a fixed_size_mode_pod class

2017-10-31 Thread Trevor Saunders
On Mon, Oct 30, 2017 at 11:11:12AM +0100, Eric Botcazou wrote: > > It sounds like people are mostly concerned about sun studio and xlc? It > > doesn't seem that hard to provide precompiled binaries for those two > > platforms, and maybe 4.8 binaries for people who want to compile theire > > own gcc

Re: [09/nn] Add a fixed_size_mode_pod class

2017-10-31 Thread Trevor Saunders
On Tue, Oct 31, 2017 at 11:38:48AM -0600, Jeff Law wrote: > On 10/31/2017 11:22 AM, Eric Botcazou wrote: > >> I don't see a reason not to other than a pretty small amount of work > >> each time we make a release. > > > > I'm not sure it would be so small an amount of work, especially on > > non-L

Re: [09/nn] Add a fixed_size_mode_pod class

2017-11-01 Thread Trevor Saunders
On Wed, Nov 01, 2017 at 10:30:29AM -0600, Jeff Law wrote: > On 10/31/2017 08:47 PM, Trevor Saunders wrote: > > On Tue, Oct 31, 2017 at 11:38:48AM -0600, Jeff Law wrote: > > > On 10/31/2017 11:22 AM, Eric Botcazou wrote: > > > > > I don't see a reason not to ot

Re: [PATCH 1/3] c-family: add name_hint/deferred_diagnostic

2017-07-10 Thread Trevor Saunders
On Mon, Jul 03, 2017 at 01:32:46PM -0400, David Malcolm wrote: > On Mon, 2017-07-03 at 10:25 -0600, Jeff Law wrote: > > On 05/05/2017 11:51 AM, David Malcolm wrote: > > > In various places we use lookup_name_fuzzy to provide a hint, > > > and can report messages of the form: > > > error: unknown

Re: [PATCH][RFA/RFC] Stack clash mitigation patch 07/08

2017-07-12 Thread Trevor Saunders
On Tue, Jul 11, 2017 at 08:02:26PM -0600, Jeff Law wrote: > On 07/11/2017 06:20 PM, Wilco Dijkstra wrote: > > Jeff Law wrote: > >> aarch64 is the first target that does not have any implicit probes in > >> the caller. Thus at prologue entry it must make conservative > >> assumptions about the offs

Re: [PATCH 3/3] matching tokens: C++ parts

2017-07-12 Thread Trevor Saunders
On Tue, Jul 11, 2017 at 11:24:45AM -0400, David Malcolm wrote: > +/* Some tokens naturally come in pairs e.g.'(' and ')'. > + This class is for tracking such a matching pair of symbols. > + In particular, it tracks the location of the first token, > + so that if the second token is missing, w

Re: [PATCH 3/3] matching tokens: C++ parts

2017-07-16 Thread Trevor Saunders
On Wed, Jul 12, 2017 at 09:11:55AM -0600, Martin Sebor wrote: > On 07/12/2017 07:13 AM, Trevor Saunders wrote: > > On Tue, Jul 11, 2017 at 11:24:45AM -0400, David Malcolm wrote: > > > +/* Some tokens naturally come in pairs e.g.'(' and ')'. > > > +

Re: [PATCH][RFA/RFC] Stack clash mitigation patch 07/08

2017-07-16 Thread Trevor Saunders
On Wed, Jul 12, 2017 at 03:08:28PM -0600, Jeff Law wrote: > On 07/12/2017 06:47 AM, Trevor Saunders wrote: > > On Tue, Jul 11, 2017 at 08:02:26PM -0600, Jeff Law wrote: > >> On 07/11/2017 06:20 PM, Wilco Dijkstra wrote: > >>> Jeff Law wrote: > >>>> a

Re: [PATCH][PING] Improve extraction of changed file in contrib/mklog

2017-07-17 Thread Trevor Saunders
On Mon, Jul 17, 2017 at 08:22:56AM +0100, Yuri Gribov wrote: > Hi, > > Currently mklog will fail to analyze lines like this in patches: > diff -rupN gcc/gcc/testsuite/lib/profopt.exp > gcc-compare-checks/gcc/testsuite/lib/profopt.exp > (it fails with "Error: failed to parse diff for ... and ...").

Re: [PATCH][RFA/RFC] Stack clash mitigation patch 07/08

2017-07-17 Thread Trevor Saunders
On Mon, Jul 17, 2017 at 09:51:40AM -0600, Jeff Law wrote: > On 07/16/2017 12:36 PM, Trevor Saunders wrote: > >>> On the other hand if probing is fast enough that it can be on by default > >>> in gcc there should be much less of it. Even if you did change the ABI > &

Re: [PATCH 15/17] Language Server Protocol: add lsp::server abstract base class

2017-07-26 Thread Trevor Saunders
On Mon, Jul 24, 2017 at 04:05:12PM -0400, David Malcolm wrote: > This patch adds an lsp::server abstract base class for implementing > servers for the Language Server Protocol: > https://github.com/Microsoft/language-server-protocol > > along with supporting classes mirroring those from the prot

Re: [PATCH 00/19] cleanup of memory stats prototypes

2017-07-28 Thread Trevor Saunders
On Fri, Jul 28, 2017 at 06:31:05PM +0200, Bernhard Reutner-Fischer wrote: > On 27 July 2017 10:43:09 CEST, Richard Biener > wrote: > >On Thu, Jul 27, 2017 at 10:30 AM, wrote: > >> From: Trevor Saunders > >> > >> The preC++ way of passing information abou

Re: [PATCH 00/19] cleanup of memory stats prototypes

2017-07-28 Thread Trevor Saunders
On Thu, Jul 27, 2017 at 10:43:09AM +0200, Richard Biener wrote: > On Thu, Jul 27, 2017 at 10:30 AM, wrote: > > From: Trevor Saunders > > > > The preC++ way of passing information about the call site of a function was > > to > > use a macro that passed __file__

Re: [PATCH 00/19] cleanup of memory stats prototypes

2017-07-31 Thread Trevor Saunders
On Mon, Jul 31, 2017 at 02:56:40PM -0600, Martin Sebor wrote: > On 07/27/2017 02:30 AM, tbsaunde+...@tbsaunde.org wrote: > > From: Trevor Saunders > > > > The preC++ way of passing information about the call site of a function was > > to > > use a macro th

Re: [PATCH 00/19] cleanup of memory stats prototypes

2017-07-31 Thread Trevor Saunders
On Mon, Jul 31, 2017 at 04:58:15PM -0600, Martin Sebor wrote: > On 07/31/2017 03:34 PM, Trevor Saunders wrote: > > On Mon, Jul 31, 2017 at 02:56:40PM -0600, Martin Sebor wrote: > > > On 07/27/2017 02:30 AM, tbsaunde+...@tbsaunde.org wrote: > > > > From: Trevor Saund

Re: [PATCH 0/3 v2] C/C++: show pertinent open token when missing a close token

2017-08-01 Thread Trevor Saunders
On Tue, Aug 01, 2017 at 04:21:41PM -0400, David Malcolm wrote: > On Wed, 2017-07-12 at 09:13 -0400, Trevor Saunders wrote: > > On Tue, Jul 11, 2017 at 11:24:45AM -0400, David Malcolm wrote: > > > + public: > > > + /* token_pair's ctor. */ > > > + tok

Re: [PATCH 1/2] add unique_ptr header

2017-08-01 Thread Trevor Saunders
On Tue, Aug 01, 2017 at 10:40:53AM -0400, David Malcolm wrote: > On Mon, 2017-07-31 at 19:46 -0400, tbsaunde+...@tbsaunde.org wrote: > > From: Trevor Saunders > > > > For most of the history of this see > > https://sourceware.org/ml/gdb-patches/2016-10/msg00223.html &

Re: [PATCH 0/2] add unique_ptr class

2017-08-04 Thread Trevor Saunders
On Fri, Aug 04, 2017 at 04:43:32PM -0600, Martin Sebor wrote: > On 07/31/2017 05:46 PM, tbsaunde+...@tbsaunde.org wrote: > > From: Trevor Saunders > > > > Hi, > > > > I've been saying I'd do this for a long time, but I'm finally getting to >

Re: [PATCH 0/2] add unique_ptr class

2017-08-04 Thread Trevor Saunders
On Fri, Aug 04, 2017 at 07:52:18PM +0100, Jonathan Wakely wrote: > On 31/07/17 19:46 -0400, tbsaunde+...@tbsaunde.org wrote: > > I've been saying I'd do this for a long time, but I'm finally getting to > > importing the C++98 compatable unique_ptr class Pedro wrote for gdb a while > > back. I beli

Re: [PATCH 1/2] add unique_ptr header

2017-08-04 Thread Trevor Saunders
On Fri, Aug 04, 2017 at 08:55:50PM +0100, Jonathan Wakely wrote: > On 01/08/17 23:09 -0400, Trevor Saunders wrote: > > aiui C++03 is C++98 with a few additions to the stl. > > Again, STL != C++ Standard Library. > > C++03 made some important changes to the core language, par

Re: backwards threader cleanups

2017-09-01 Thread Trevor Saunders
On Fri, Sep 01, 2017 at 04:18:20PM -0400, Aldy Hernandez wrote: > Hi. > > Attached are misc cleanups to tree-ssa-threadbackwards.c and friends. > The main gist of the patch is making the path vectors live in the > heap, not GC. But I also cleaned up some comments to reflect reality, > and renamed

Re: [PATCH 00/22] RFC: integrated 3rd-party static analysis support

2017-09-01 Thread Trevor Saunders
On Fri, Sep 01, 2017 at 11:46:41AM -0600, Jeff Law wrote: > On 08/04/2017 04:04 PM, David Malcolm wrote: > > This patch kit clearly isn't ready yet as-is (see e.g. the > > "known unknowns" below), but I'm posting it now in the hope of > > getting early feedback. > [ ... ] > > > > > > > Statement

Re: [PATCH 0/2] add unique_ptr class

2017-09-02 Thread Trevor Saunders
HI, figured I'd ping this to see if we can come to some concensus, I don't care much what we choose as a namespace, I just want to get this in so we can use it more. On Fri, Aug 11, 2017 at 09:43:21PM +0100, Jonathan Wakely wrote: > On 05/08/17 20:05 +0100, Pedro Alves wrote: > > On 08/04/2017 07

Re: [PATCH 1/N] Introduce dump_flags_t type and use it instead of int type.

2017-05-06 Thread Trevor Saunders
On Fri, May 05, 2017 at 01:38:21PM +0200, Richard Biener wrote: > On Fri, May 5, 2017 at 12:41 PM, Martin Liška wrote: > > Hello. > > > > There's first patch that just defines dump_flags_t as uint64_t and changes > > all > > corresponding interfaces that do use it. There's a problematic impact th

Re: [PATCH 2/n] [PR tree-optimization/78496] Simplify ASSERT_EXPRs to facilitate jump threading

2017-05-06 Thread Trevor Saunders
> +simplify_assert_expr_using_ranges (gimple *stmt) > +{ > + return false; I assume you didn't mean to leave that in? Trev

Re: [PATCH, RFC] warn about raw pointers that can be unique_ptr

2017-05-07 Thread Trevor Saunders
On Sun, May 07, 2017 at 07:32:48PM +0200, Marc Glisse wrote: > On Sun, 7 May 2017, tbsaunde+...@tbsaunde.org wrote: > > > This is a start at warning about various resource allocation issues that > > can be > > improved. Currently it only warns about functions that call malloc and then > > always

Re: [PATCH, RFC] warn about raw pointers that can be unique_ptr

2017-05-08 Thread Trevor Saunders
On Mon, May 08, 2017 at 10:28:13AM +0200, Marc Glisse wrote: > On Sun, 7 May 2017, Trevor Saunders wrote: > > > On Sun, May 07, 2017 at 07:32:48PM +0200, Marc Glisse wrote: > > > On Sun, 7 May 2017, tbsaunde+...@tbsaunde.org wrote: > > > > > > > This is

Re: [PATCH 01/13] improve safety of freeing bitmaps

2017-05-10 Thread Trevor Saunders
On Wed, May 10, 2017 at 10:14:17AM +0200, Richard Biener wrote: > On Tue, May 9, 2017 at 10:52 PM, wrote: > > From: Trevor Saunders > > > > There's two groups of changes here, first taking a sbitmap &, so that we > > can assign null to the pointer afte

Re: [PATCH 05/13] allow constructing a auto_vec with a preallocation, and a possibly larger actual allocation size

2017-05-11 Thread Trevor Saunders
On Wed, May 10, 2017 at 07:54:13AM +0100, Richard Sandiford wrote: > tbsaunde+...@tbsaunde.org writes: > > From: Trevor Saunders > > > > This allows us to set the capacity of the vector when we construct it, > > and still use a stack buffer when the size is small en

Re: [PATCH 02/13] improve bitmap / sbitmap compatability of bitmap_set_bit

2017-05-11 Thread Trevor Saunders
On Wed, May 10, 2017 at 07:44:17AM +0100, Richard Sandiford wrote: > tbsaunde+...@tbsaunde.org writes: > > From: Trevor Saunders > > > > This make the sbitmap version return true if the bit was previously > > unset to make it similar to the bitmap version. > > &

Re: [PATCH 05/13] allow constructing a auto_vec with a preallocation, and a possibly larger actual allocation size

2017-05-11 Thread Trevor Saunders
On Thu, May 11, 2017 at 10:01:51AM +0200, Richard Biener wrote: > On Thu, May 11, 2017 at 9:45 AM, Trevor Saunders > wrote: > > On Wed, May 10, 2017 at 07:54:13AM +0100, Richard Sandiford wrote: > >> tbsaunde+...@tbsaunde.org writes: > >> > From: Trevor Saunders

Re: [PATCH] plugin.c (try_init_one_plugin): Fix ressource leaks (CID 726637)

2017-05-14 Thread Trevor Saunders
On Sun, May 14, 2017 at 11:59:40AM +0200, Sylvestre Ledru wrote: > Add missing dlclose() > > S > > > From d0926b84047f281a29dc51bbd0a4bdda01a5c63f Mon Sep 17 00:00:00 2001 > From: Sylvestre Ledru > Date: Sun, 14 May 2017 11:28:38 +0200 > Subject: [PATCH 4/5] 2017-05-14 Sylvestre Ledru > >

Re: [PATCH] Try harder to fix recently introduced crashes in ggc_collect

2017-05-24 Thread Trevor Saunders
On Fri, May 19, 2017 at 10:10:23AM -0400, Nathan Sidwell wrote: > On 05/19/2017 10:05 AM, Bernd Edlinger wrote: > > > hwi cannot be the root cause of the problem, > > because it can only be long_integer_type_node > > or long_long_integer_type_node, otherwise > > an error would be triggered. > > t

Re: C/C++ PATCH to implement -Wmultiline-expansion (PR c/80116)

2017-06-01 Thread Trevor Saunders
On Thu, Jun 01, 2017 at 06:45:17PM +0200, Marek Polacek wrote: > A motivating example for this warning can be found e.g. in > > PRE10-C. Wrap multistatement macros in a do-while loop > https://www.securecoding.cert.org/confluence/x/jgL7 > > i.e., > > #define SWAP(x, y) \ > tmp = x; \ >

Re: [RFA] [PR tree-optimization/33562] [PATCH 1/4] Byte tracking in DSE

2016-12-21 Thread Trevor Saunders
On Sat, Dec 17, 2016 at 01:19:41AM -0700, Jeff Law wrote: > On 12/16/2016 12:29 AM, Trevor Saunders wrote: > > On Thu, Dec 15, 2016 at 06:54:43PM -0700, Jeff Law wrote: > > >unsigned cnt = 0; > > > + bitmap live_bytes = NULL; > > > + bitmap orig_live_byt

Re: [PR tree-optimization/71691] Fix unswitching in presence of maybe-undef SSA_NAMEs (take 2)

2017-01-04 Thread Trevor Saunders
On Fri, Dec 16, 2016 at 09:41:33AM -0500, Aldy Hernandez wrote: > Hi folks. > > This is a follow-up on Jeff and Richi's interaction on the aforementioned PR > here: > > https://gcc.gnu.org/ml/gcc-patches/2016-08/msg01397.html > > I decided to explore the idea of analyzing may-undefness on-

Re: [PATCH GCC8][04/33]Single interface finding invariant variables

2017-04-18 Thread Trevor Saunders
On Tue, Apr 18, 2017 at 10:39:30AM +, Bin Cheng wrote: > -find_depends (tree *expr_p, int *ws ATTRIBUTE_UNUSED, void *data) > +find_inv_vars_cb (tree *expr_p, int *ws ATTRIBUTE_UNUSED, void *data) > { > - bitmap *inv_vars = (bitmap *) data; > + struct walk_tree_data *wdata = (struct walk_tre

Re: [PATCH GCC8][04/33]Single interface finding invariant variables

2017-04-18 Thread Trevor Saunders
On Tue, Apr 18, 2017 at 01:58:43PM +0100, Bin.Cheng wrote: > On Tue, Apr 18, 2017 at 1:20 PM, Trevor Saunders > wrote: > > On Tue, Apr 18, 2017 at 10:39:30AM +, Bin Cheng wrote: > >> -find_depends (tree *expr_p, int *ws ATTRIBUTE_UNUSED, void *data) > >> +find_

Re: [PATCH] RFC: spellchecker for comments, plus -Wfixme and -Wtodo

2017-05-02 Thread Trevor Saunders
On Tue, May 02, 2017 at 03:08:01PM -0400, David Malcolm wrote: > Currently the C/C++ frontends discard comments when parsing. > It's possible to set up libcpp to capture comments as tokens, > by setting CPP_OPTION (pfile, discard_comments) to false), > and this can be enabled using the -C command l

Re: PR80613

2017-05-04 Thread Trevor Saunders
On Thu, May 04, 2017 at 11:52:31AM -0600, Martin Sebor wrote: > On 05/04/2017 10:00 AM, Prathamesh Kulkarni wrote: > > Hi, > > As mentioned in PR, the issue is that cddce1 marks the call to > > __builtin_strdup as necessary: > > marking necessary through .MEM_6 stmt p_7 = __builtin_strdup (&d); > >

Re: [committed][PATCH] Simplify relationals into simple equality conditionals in DOM

2017-10-02 Thread Trevor Saunders
On Sun, Oct 01, 2017 at 09:22:56AM -0600, Jeff Law wrote: > > A short while ago Martin Liska posted a patch that lowered certain > switch statements into cascading conditionals. > > His work tripped two regressions in the testsuite, both cases where we > did not optimize as well as we should have

Re: [PATCH 1/2] add unique_ptr header

2017-10-12 Thread Trevor Saunders
On Wed, Oct 11, 2017 at 02:16:38PM -0400, David Malcolm wrote: > On Sat, 2017-08-05 at 01:39 -0400, Trevor Saunders wrote: > > On Fri, Aug 04, 2017 at 08:55:50PM +0100, Jonathan Wakely wrote: > > > On 01/08/17 23:09 -0400, Trevor Saunders wrote: > > > > aiui C++03 is

Re: [PATCH] Fix PR79278, amend ADJUST_FIELD_ALIGN interface

2017-02-01 Thread Trevor Saunders
On Wed, Feb 01, 2017 at 09:42:08AM +0100, Richard Biener wrote: > On Tue, 31 Jan 2017, Jeff Law wrote: > > > On 01/31/2017 02:01 AM, Richard Biener wrote: > > > > > > This amends ADJUST_FIELD_ALIGN to always get the type of the field > > > as argument but make the field itself optional. All actu

Re: [wwwdocs, coding conventions] Mention OVERRIDE/FINAL

2017-02-03 Thread Trevor Saunders
On Fri, Feb 03, 2017 at 09:34:52AM +0100, Gerald Pfeifer wrote: > On Fri, 14 Oct 2016, David Malcolm wrote: > > On Fri, 2016-10-14 at 16:27 +0100, Pedro Alves wrote: > >> FYI, I pushed these in now. I also bootstrapped with the > >> jit included in the selected languages, and hacked the > >> jit c

Re: [PATCH 2/5][P1][tree-optimization/71437] Record more equivalences in some cases

2017-03-16 Thread Trevor Saunders
On Wed, Mar 15, 2017 at 09:18:27PM -0600, Jeff Law wrote: > On 03/15/2017 09:17 PM, Jeff Law wrote: > > > > Patch #3 will remove handle_dominating_asserts from the core of the jump > > threading code and push it into VRP's callbacks where it should always > > have been. > > > > As a side effect i

Re: [PATCH 2/5][P1][tree-optimization/71437] Record more equivalences in some cases

2017-03-16 Thread Trevor Saunders
On Thu, Mar 16, 2017 at 09:03:43AM -0600, Jeff Law wrote: > On 03/16/2017 06:54 AM, Trevor Saunders wrote: > > > + if (TREE_CODE (op0) == SSA_NAME && integer_zerop (op1)) > > > + { > > > + enum tree_code code = eq->cond.ops.binary.op; > &

<    1   2   3   4   5   >