Re: [PATCH] [LIBPHOBOS] Fix multi-lib RUNTESTFLAGS handling

2019-10-30 Thread Thomas Schwinge
gcc.gnu.org/svn/gcc/branches/gcc-9-branch@277611 138bc75d-0d04-0410-961f-82ee72b054a4 --- libphobos/ChangeLog | 9 + libphobos/testsuite/lib/libphobos.exp | 19 +++ 2 files changed, 28 insertions(+) diff --git a/libphobos/ChangeLog b/libphobos/ChangeLog ind

Re: [PATCH 14/14] Add D Phobos config, makefiles, and testsuite.

2019-10-30 Thread Thomas Schwinge
Hi! Just for posterity. On 2019-04-20T23:22:31+0200, Iain Buclaw wrote: > On Sat, 20 Apr 2019 at 22:30, Thomas Schwinge wrote: >> On Tue, 18 Sep 2018 02:39:46 +0200, Iain Buclaw >> wrote: >> > This patch adds the configure and make files used for building D >>

Re: [PATCH] OpenACC reference count overhaul

2019-10-31 Thread Thomas Schwinge
ing it with generic and/or well-explained code. Question, for my understanding: > On Mon, 21 Oct 2019 16:14:11 +0200 > Thomas Schwinge wrote: >> On 2019-10-03T09:35:04-0700, Julian Brown >> wrote: >> > @@ -577,17 +551,14 @@ present_create_copy (unsigned

Re: [PATCH] Report errors on inconsistent OpenACC nested reduction clauses

2019-11-05 Thread Thomas Schwinge
Hi Frederik! On 2019-10-29T13:20:53+0100, "Harwath, Frederik" wrote: > On 24.10.19 16:31, Thomas Schwinge wrote: >> So just C/C++ testing, no Fortran at all. This is not ideal, but >> probably (hopefully) acceptable given that this is working on the middle >> en

Re: [Patch] Add OpenACC 2.6's no_create

2019-11-05 Thread Thomas Schwinge
tgt->list[i].offset = OFFSET_INLINED; > + tgt->list[i].length = sizes[i]; > + tgt->list[i].copy_from = false; > + tgt->list[i].always_copy_from = false; > + break; >

Re: [Patch] Add OpenACC 2.6's no_create

2019-11-06 Thread Thomas Schwinge
was right that this patch doesn't have sufficient test coverage at all. Or, I'm completely confused -- we still have that option, too. ;-\ Grüße Thomas From 38fcb35dcb98b0fd709db72896455895243d8e54 Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Wed, 6 Nov 2019 13:39:12 +0100 S

Re: introduce -fcallgraph-info option

2019-11-06 Thread Thomas Schwinge
Hi Alexandre! On 2019-10-26T01:35:43-0300, Alexandre Oliva wrote: > This was first submitted many years ago > https://gcc.gnu.org/ml/gcc-patches/2010-10/msg02468.html > > The command line option -fcallgraph-info is added and makes the > compiler generate another output file (xxx.ci) for each comp

Re: [PATCH, OpenACC, v2] Non-contiguous array support for OpenACC data clauses

2019-11-06 Thread Thomas Schwinge
Hi Chung-Lin! On 2019-11-05T22:35:43+0800, Chung-Lin Tang wrote: > Hi Thomas, > after your last round of review, I realized that the bulk of the compiler > omp-low work was > simply a case of dumb over-engineering in the wrong direction :P > (although it did painstakingly function correctly) He

Re: [build] Properly track GCC language configure fragments

2019-11-11 Thread Thomas Schwinge
04d 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,10 @@ +2019-11-11 Thomas Schwinge + + * Makefile.in (LANG_CONFIGUREFRAGS): Define. + (config.status): Use/depend on it. + * configure.ac (all_lang_configurefrags): Track, 'AC_SUBST'. + * configure: Regenerate. + 2019-11-11 Jiufu

Re: [gomp4.1] Start of structure element mapping support

2019-11-11 Thread Thomas Schwinge
Hi! On 2019-10-16T18:52:55+0200, Jakub Jelinek wrote: > On Wed, Oct 16, 2019 at 03:22:52PM +0200, Thomas Schwinge wrote: >> Stumbled over this while reviewing Julian's "Factor out duplicate code in >> gimplify_scan_omp_clauses": >

[8/9/10 Regression] [PR87833] Intel MIC (emulated) offloading still broken

2019-11-11 Thread Thomas Schwinge
Hi! On 2019-05-29T09:50:42-0600, Jeff Law wrote: > On 5/29/19 8:32 AM, Thomas Schwinge wrote: >> On Thu, 9 May 2019 15:46:06 +0300, Ilya Verbin wrote: >>> I have left Intel 3 years ago. If you have any questions regarding MIC >>> offloading, you can reach me by iver..

Re: [Patch][OpenMP] use_device_addr/use_device_ptr with Fortran allocatable/pointer arrays (= array descriptor)

2019-11-11 Thread Thomas Schwinge
diff --git a/libgomp/ChangeLog b/libgomp/ChangeLog index 067d247da9ac..0e73cadb6cd0 100644 --- a/libgomp/ChangeLog +++ b/libgomp/ChangeLog @@ -1,3 +1,10 @@ +2019-11-11 Thomas Schwinge + + * testsuite/libgomp.fortran/use_device_addr-3.f90: Specify 'dg-do + run'. + * testsuite/libgomp.fortr

Re: [Patch][Fortran/OpenMP] Don't create "alloc:" for 'target exit data'

2019-11-11 Thread Thomas Schwinge
-- a/libgomp/ChangeLog +++ b/libgomp/ChangeLog @@ -1,5 +1,7 @@ 2019-11-11 Thomas Schwinge + * testsuite/libgomp.fortran/target9.f90: Specify 'dg-do run'. + * testsuite/libgomp.fortran/use_device_addr-3.f90: Specify 'dg-do run'. * testsuite/libgomp.fortran/use_device_ad

Re: [Patch][Fortran] OpenACC – permit common blocks in some clauses

2019-11-11 Thread Thomas Schwinge
Hi Tobias! By the way, do you know what's the status is for Fortran common blocks in OpenMP: supported vs. expected per the specification? On 2019-10-25T16:36:10+0200, Tobias Burnus wrote: > On 10/25/19 10:43 AM, Thomas Schwinge wrote: >> Or, would it be easy to add an OpenACC

Re: [PATCH] Add OpenACC 2.6 `serial' construct support

2019-11-11 Thread Thomas Schwinge
tc., plus a few more things, see my comments in the patch review below. To record the review effort, please include "Reviewed-by: Thomas Schwinge " in the commit log, see <https://gcc.gnu.org/wiki/Reviewed-by>. I'm working on an additional patch to handle 'serial

Re: [Patch][OpenMP][Fortran] Support absent optional args with use_device_{ptr,addr} (+ OpenACC's use_device clause)

2019-11-11 Thread Thomas Schwinge
Hi Tobias! Thanks for looking into this mess ;-) of Fortran optional arguments support for OMP, based on what Kwok has already developed. On 2019-11-08T16:41:23+0100, Tobias Burnus wrote: > --- /dev/null > +++ b/libgomp/testsuite/libgomp.fortran/use_device_ptr-optional-2.f90 When adding '{ dg-

Re: libgomp testsuite: tell warning from error diagnostics, etc. [PR80219, PR85303]

2020-11-02 Thread Thomas Schwinge
Hi! On 2020-10-30T12:25:38+0100, Jakub Jelinek via Gcc-patches wrote: > On Fri, Oct 30, 2020 at 12:22:31PM +0100, Thomas Schwinge wrote: >> Turns out that GCC PR85303 "[testsuite, libgomp] dg-message not >> supported" is the very same problem as (the libgomp aspect of)

Re: [Patch, Fortran] PR 92793 - fix column used for error diagnostic

2020-11-02 Thread Thomas Schwinge
Hi Tobias! On 2020-10-30T12:16:05+0100, Tobias Burnus wrote: > On 30.10.20 11:47, Thomas Schwinge wrote: >>>> Fixed by introducing a new function; now one only needs to make sure >>>> that no new code will re-introduce "lb->location":-) >> .

Re: [PATCH 6/9] [nvptx] Force vl32 if calling vector-partitionable routines -- test-cases

2020-11-02 Thread Thomas Schwinge
Hi Tom! On 2020-10-30T17:32:56+0100, Tom de Vries wrote: > On 10/30/20 5:16 PM, Thomas Schwinge wrote: >> OK to simplify and enhance the >> testcases as attached, "Simplify and enhance >> 'libgomp.oacc-c-c++-common/pr85486*.c' [PR85486]"? > > Ye

Re: [PATCH 0/2] Add tests to verify OpenACC clause locations

2020-11-03 Thread Thomas Schwinge
6ce4c2f8d4018206c12e131c49ca6ce, see attached. Grüße Thomas - Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander Walter >From beddd1762ad2bbe84dd776c54489153f83f21e56 M

Re: [PATCH] Fix column information for omp_clauses in Fortran code

2020-11-03 Thread Thomas Schwinge
- Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander Walter >From 41f7f6178e2d35288273656dc55dae8fcf3edeb5 Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Tue, 27 Oct 2020 17:

Re: [og8] Report errors on missing OpenACC reduction clauses in nested reductions

2020-11-03 Thread Thomas Schwinge
fstraße 201, 80634 München / Germany Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander Walter >From fedf3e94efe774b8c0539d344130a7b25f50a881 Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Thu, 22 Oct 2020 09:45:31 +0200 Subject: [PATCH] [OpenACC] Split up test

Re: [og8] Report errors on missing OpenACC reduction clauses in nested reductions

2020-11-03 Thread Thomas Schwinge
and backported to releases/gcc-10 branch in commit 217fb4d4e59e7d6e03a3704f80f401e2a641dbe5, see attached. Grüße Thomas - Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander

Re: [PATCH 0/2] Add tests to verify OpenACC clause locations

2020-11-03 Thread Thomas Schwinge
raphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander Walter >From fab72592d86d11b89a01f0f3c2c9c329d43466c1 Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Tue, 3 Nov 2020 22:06:29 +0100

Re: [PATCH] dumpfile.c: use prefixes other that 'note: ' for MSG_{OPTIMIZED_LOCATIONS|MISSED_OPTIMIZATION}

2020-11-06 Thread Thomas Schwinge
g.) Grüße Thomas - Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander Walter >From f3046b8bea6a2a6489dd10d72cb038b92aa4fc38 Mon Sep 17 00

Re: [PATCH] dumpfile.c: use prefixes other that 'note: ' for MSG_{OPTIMIZED_LOCATIONS|MISSED_OPTIMIZATION}

2020-11-06 Thread Thomas Schwinge
Hi! On 2018-09-25T16:00:14-0400, David Malcolm wrote: > The patch adds "dg-optimized" and "dg-missed" directives Another small thing I just noticed: > --- a/gcc/testsuite/lib/gcc-dg.exp > +++ b/gcc/testsuite/lib/gcc-dg.exp > +# Handle output from -fopt-info for MSG_OPTIMIZED_LOCATIONS: > +# a

Add 'dg-note' next to 'dg-optimized', 'dg-missed' (was: [PATCH] dumpfile.c: use prefixes other that 'note: ' for MSG_{OPTIMIZED_LOCATIONS|MISSED_OPTIMIZATION})

2020-11-06 Thread Thomas Schwinge
, 'dg-missed') TODO 'gcc/testsuite/lib/lto.exp' change necessary/desirable? The latter got added in commit 824721f0905478ebc39e6a295cc8e95c22fa9d17 "lto, testsuite: Fix ICE in -Wodr (PR lto/83121)". David, do you happen to have an opinion on that one? Grüße Thomas

Re: Split up "gfortran.dg/goacc/loop-2.f95"

2020-11-06 Thread Thomas Schwinge
- Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander Walter >From 4dfa1789ab6560a69de22afe7982f372f598c5b8 Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Tue, 27 Oct 2020 10:

Re: Use existing middle end checking for Fortran OpenACC loop clauses

2020-11-06 Thread Thomas Schwinge
r Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander Walter >From 4c27f900950ed0ecb2897a8931c5cc348b1980be Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Tue, 27 Oct 2020 10:43:27 +0100 Subject: [PATCH]

Re: RFC: Monitoring old PRs, new dg directives [v2]

2020-11-10 Thread Thomas Schwinge
Hi! On 2020-08-10T17:30:21-0400, Marek Polacek via Gcc-patches wrote: > This patch adds a new DejaGNU directive, dg-ice, as outlined in the > proposal here: > https://gcc.gnu.org/pipermail/gcc-patches/2020-July/550913.html > > It means that it's expected that the compiler crashes with an interna

Re: [committed] gfortran.dg/gomp/workshare-reduction-*.f90: Fix dumps for -m32 (was: Re: [Patch] Fortran: OpenMP 5.0 (in_, task_)reduction clause extensions)

2020-11-11 Thread Thomas Schwinge
Hi Tobias! On 2020-11-11T09:25:25+0100, Tobias Burnus wrote: > As Sunil's regression tester pointed out, the testcases fail on x86-64 with > -m32. > > The reason is that then the _ull_ variants of the GOMP functions are called; > in the C equivalent, those are always called – I assume that's bec

Re: [Patch] Fortran: improve location data for OpenACC/OpenMP directives [PR97782]

2020-11-12 Thread Thomas Schwinge
milar testsuite coverage with other pending patches of mine. > In principle, it should also have an effect on warnings (if there are > any) and it unsurprisingly affects --fdump-tree-*-lineno. > > Comments, remarks, does it look good to you? I have not verified all the details,

Re: [Patch] Fortran: improve location data for OpenACC/OpenMP directives [PR97782]

2020-11-12 Thread Thomas Schwinge
äftsführer: Thomas Heurung, Alexander Walter >From 9106c51e57c06e88a0dddf994fb5432b4bbe68c0 Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Thu, 12 Nov 2020 20:07:25 +0100 Subject: [PATCH] Adjust 'libgomp.oacc-fortran/attach-descriptor-1.f90' for improved location informat

Add 'libgomp.oacc-fortran/pr94358-1.f90' [PR94358] (was: [PATCH, OpenACC] Rework OpenACC Fortran DO loop initialization)

2020-11-13 Thread Thomas Schwinge
libgomp/ PR fortran/94358 * testsuite/libgomp.oacc-fortran/pr94358-1.f90: New. Co-authored-by: Thomas Schwinge --- .../libgomp.oacc-fortran/pr94358-1.f90| 34 +++ 1 file changed, 34 insertions(+) create mode 100644 libgomp/testsuite/libgomp.oacc-fortran/pr94358-1.f90

Attach an attribute to all outlined OpenACC compute regions

2020-11-13 Thread Thomas Schwinge
Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander Walter >From 703e4f86496214e4915db898397fcd0ae1d955e0 Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Wed, 28 Oct 2020 11:4

More explicit checking of which OMP constructs we're expecting

2020-11-13 Thread Thomas Schwinge
hed. Grüße Thomas - Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander Walter >From bd7885755405bc9947ebe805a53d6100c78c8e82 Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Tue, 13

Decompose OpenACC 'kernels' constructs into parts, a sequence of compute constructs (was: [og8] OpenACC 'kernels' construct changes: splitting of the construct into several regions)

2020-11-13 Thread Thomas Schwinge
ernels-decompose-1.c: Likewise. * testsuite/libgomp.oacc-c-c++-common/declare-vla.c: Adjust. * testsuite/libgomp.oacc-fortran/pr94358-1.f90: Likewise. Co-authored-by: Thomas Schwinge --- gcc/Makefile.in |1 + gcc/c-family/c.opt| 1

In 'gcc/omp-oacc-kernels-decompose.cc', use langhook instead of accessing language-specific decl information (was: [PATCH 04/10, OpenACC] Turn OpenACC kernels regions into a sequence of, parallel regi

2020-11-13 Thread Thomas Schwinge
Hi! On 2019-08-05T22:51:22+0100, Kwok Cheung Yeung wrote: > On 18/07/2019 10:30 am, Jakub Jelinek wrote: >> On Wed, Jul 17, 2019 at 10:06:07PM +0100, Kwok Cheung Yeung wrote: >>> --- a/gcc/omp-oacc-kernels.c >>> +++ b/gcc/omp-oacc-kernels.c >>> @@ -30,6 +30,7 @@ along with GCC; see the file COPYI

Re: OpenACC 'kernels' testsuite failures

2020-11-16 Thread Thomas Schwinge
Hi David! Thanks for reporting. On 2020-11-15T15:47:15-0500, David Edelsohn wrote: > I am seeing a number of new failures on AIX related to the OpenACC > kernels patches. > > c-c++-common/goacc/kernels-decompose-1.c > c-c++-common/goacc/kernels-decompose-2.c > gfortran.dg/goacc/kernels-decompose

Re: OpenACC 'kernels' testsuite failures

2020-11-16 Thread Thomas Schwinge
Hi David! While you were writing your email, I've also been busy: On 2020-11-16T11:32:46-0500, David Edelsohn wrote: > On Mon, Nov 16, 2020 at 9:16 AM Thomas Schwinge > wrote: >> On 2020-11-15T15:47:15-0500, David Edelsohn wrote: >> > I am seeing a number of new

Re: [Patch] OpenACC – support "if" + "if_present" clauses with "host_data"

2020-01-09 Thread Thomas Schwinge
Hi! Jakub, please see one question below. On 2019-12-24T15:23:56+0100, Tobias Burnus wrote: > OK for the trunk? Tobias, thanks for taking over this patch. I have a few additional small changes that I'd like to do (have WIP patches already), but what we've got here already is OK for trunk with

Re: [Patch] OpenACC – support "if" + "if_present" clauses with "host_data"

2020-01-10 Thread Thomas Schwinge
16 ++--- gcc/tree-core.h | 3 + gcc/tree-pretty-print.c | 16 ++--- gcc/tree.h| 5 ++ libgomp/ChangeLog | 6 ++ libgomp/target.c | 61

Re: [PATCH] Add OpenACC 2.6 `acc_get_property' support

2020-01-10 Thread Thomas Schwinge
| 3 +- libgomp/oacc-host.c | 47 +++--- libgomp/oacc-init.c | 10 +- libgomp/openacc.f90 | 2 +- libgomp/openacc.h | 3 +- libgomp/plugin/plugin-gcn.c | 22 +-- lib

Re: [PATCH] Add OpenACC 2.6 `acc_get_property' support

2020-01-16 Thread Thomas Schwinge
Hi Frederik! On 2019-12-20T17:46:57+0100, "Harwath, Frederik" wrote: > --- /dev/null > +++ b/libgomp/testsuite/libgomp.oacc-c-c++-common/acc_get_property-2.c I suggest to rename this one to 'acc_get_property-nvptx.c'. > @@ -0,0 +1,68 @@ > +/* Test the `acc_get_property' and '`acc_get_property_

Re: Fix false -Wodr warnings

2020-01-23 Thread Thomas Schwinge
)) >> f2 = TREE_CHAIN (f2); >> if (!f1 || !f2) >> break; From 8e55f241ab8c754a2ab8ec2fe39afd9173589401 Mon Sep 17 00:00:00 2001 From: Dominique d'Humieres Date: Tue, 16 Apr 2019 15:24:58 +0200 Subject: [PATCH] pr89358_0.C:

Re: [PATCH] Add OpenACC 2.6 `acc_get_property' support

2020-01-23 Thread Thomas Schwinge
Hi Frederik! On 2020-01-20T15:01:01+0100, "Harwath, Frederik" wrote: > I have attached a patch containing the changes that you suggested. > On 16.01.20 17:00, Thomas Schwinge wrote: >> On 2019-12-20T17:46:57+0100, "Harwath, Frederik" >> wrote: > Ok

Fortran 'acc_get_property' return type (was: [PATCH] Add OpenACC 2.6 `acc_get_property' support)

2020-01-27 Thread Thomas Schwinge
Hi! On 2019-12-20T17:46:57+0100, "Harwath, Frederik" wrote: >> > --- a/libgomp/libgomp-plugin.h >> > +++ b/libgomp/libgomp-plugin.h >> > @@ -54,6 +54,13 @@ enum offload_target_type >> >OFFLOAD_TARGET_TYPE_GCN =3D 8 >> > }; >> >=20=20 >> > +/* Container type for passing device properties. *

[PR93488] [OpenACC] ICE in type-cast 'async', 'wait' clauses (was: [patch, openacc] Fix ICE verifying gimple)

2020-01-29 Thread Thomas Schwinge
Hi Andrew! On 2019-11-22T11:06:14+, Andrew Stubbs wrote: > This test case causes an ICE (reformatted for email): > >void test(int k) >{ > unsigned int x = 1; >#pragma acc parallel loop async(x) > for (int i = 0; i < k; i++) { } >} Curious, why didn't you include suc

Re: [PATCH][OpenACC] Add acc_device_radeon to name_of_acc_device_t function

2020-01-29 Thread Thomas Schwinge
trunk commit of the AMD GCN offloading support, given that we did have it on the development branch.) > Ok to commit this patch to master? Thanks, OK. Reviewed-by: Thomas Schwinge This also supersedes Tobias' earlier patch, <http://mid.mail-archive.com/a1ae248c-ce70-f501-d421

Re: [PATCH] Add OpenACC acc_get_property support for AMD GCN

2020-01-29 Thread Thomas Schwinge
Hi! On 2020-01-29T10:52:57+0100, "Harwath, Frederik" wrote: > On 28.01.20 16:42, Andrew Stubbs wrote: >> On 28/01/2020 14:55, Harwath, Frederik wrote: >> >> If we're going to use a fixed-size buffer then we should use snprintf and >> emit GCN_WARNING if the return value is greater than >> "si

Re: [PATCH] OpenACC reference count consistency checking

2020-01-30 Thread Thomas Schwinge
Hi Julian! Notwithstanding the open question about how to implement this checking in libgomp in a non-intrusive (performance-wise) yet maintainable (avoid '#if 0') way, I have two more questions. Is there a specific reason why this checking isn't also enabled for libgomp OpenMP 'target' entry po

Make OpenACC 'acc_get_property' with 'acc_device_current' work (was: [PATCH] Add OpenACC 2.6 `acc_get_property' support)

2020-01-30 Thread Thomas Schwinge
us guy that I am sometimes ;-) I gave that a try, and... "of course"... it doesn't work. Please review the attached (Tobias the Fortran test cases, please), and test with AMD GCN offloading. If approving this patch, please respond with "Reviewed-by: NAME " so tha

Re: [PATCH] Add OpenACC acc_get_property support for AMD GCN

2020-01-30 Thread Thomas Schwinge
Hi! Andrew and Frederik, thanks for your emails reminding/educating me about 'snprintf' as well as this HSA fixed-size buffer API. There doesn't happen to be something available in the HSA API available so that we could use 'sizeof [something]' instead of hard-coding '64' etc.? I understand cor

Re: [PATCH] Add OpenACC acc_get_property support for AMD GCN

2020-01-31 Thread Thomas Schwinge
Hi! On 2020-01-30T16:45:39+, Andrew Stubbs wrote: > On 30/01/2020 16:08, Thomas Schwinge wrote: >> Andrew and Frederik, thanks for your emails reminding/educating me about >> 'snprintf' as well as this HSA fixed-size buffer API. There doesn't >> happen

Re: [PATCH] Add OpenACC acc_get_property support for AMD GCN

2020-01-31 Thread Thomas Schwinge
Hi Frederik! On 2020-01-31T13:17:52+0100, "Harwath, Frederik" wrote: > On 30.01.20 17:08, Thomas Schwinge wrote: > >> I understand correctly that the only reason for: >> >> On 2020-01-29T10:52:57+0100, "Harwath, Frederik" >> wr

Re: [PATCH 1/13] v2 [PATCH 1/13] Add support for per-location warning groups (PR 74765)

2021-09-01 Thread Thomas Schwinge
there's an entry in the map the no-warning bit must be set. */ > + gcc_assert (get_no_warning_bit (from)); > + > + if (!nowarn_map) > + nowarn_map = xint_hash_map_t::create_ggc (32); > + > + nowarn_map->put (to_key, *from_map); > + set_no_warning

Re: [Committed] [PATCH 2/4] (v4) On-demand locations within string-literals

2021-09-02 Thread Thomas Schwinge
München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955 >From 521c94471ae2f044f8cca8025bfa8db2d2936aea Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Tue, 31 Aug 2021 23:05:46 +0

Re: [Committed] [PATCH 2/4] (v4) On-demand locations within string-literals

2021-09-02 Thread Thomas Schwinge
Hi! On 2021-09-02T15:59:14+0200, I wrote: > On 2016-08-05T14:16:58-0400, David Malcolm wrote: >> Committed to trunk as r239175; I'm attaching the final version of the >> patch for reference. > > David, you've added here 'gcc/input.h:struct location_hash' (see quoted > below), which will be useful

Re: [Committed] [PATCH 2/4] (v4) On-demand locations within string-literals

2021-09-03 Thread Thomas Schwinge
OK? ... and then re: >>> --- a/gcc/input.h >>> +++ b/gcc/input.h >> >>> +struct location_hash : int_hash { }; >>> + >>> +class GTY(()) string_concat_db >>> +{ >>> +[...] >>> + hash_map *m_table; >>> +}; >>

Re: [PATCH 1/13] v2 [PATCH 1/13] Add support for per-location warning groups (PR 74765)

2021-09-03 Thread Thomas Schwinge
Hi! Martin, thanks for your review. Now need someone to formally approve the third patch. On 2021-09-01T18:14:46-0600, Martin Sebor wrote: > On 9/1/21 1:35 PM, Thomas Schwinge wrote: >> On 2021-06-23T13:47:08-0600, Martin Sebor via Gcc-patches >> wrote: >>> On 6/22/2

Re: [committed] openmp: Improve expand_omp_atomic_pipeline

2021-09-06 Thread Thomas Schwinge
- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955 >From 086bb917d6efa32d9841c34a3b762f4278c762cd Mon Sep 17 00:00:0

[PING] Don't maintain a warning spec for 'UNKNOWN_LOCATION'/'BUILTINS_LOCATION' [PR101574] (was: [PATCH 1/13] v2 [PATCH 1/13] Add support for per-location warning groups (PR 74765))

2021-09-10 Thread Thomas Schwinge
Hi! Ping. On 2021-09-03T21:16:46+0200, Thomas Schwinge wrote: > Martin, thanks for your review. Now need someone to formally approve the > third patch. Again attached for easy reference. Grüße Thomas > On 2021-09-01T18:14:46-0600, Martin Sebor wrote: >> On 9/1/21

[PING] Re: [Committed] [PATCH 2/4] (v4) On-demand locations within string-literals

2021-09-10 Thread Thomas Schwinge
cing "Harden 'gcc/input.c:string_concat_db::get_key_loc'" as > originally proposed). OK? > > > ... and then re: > >>>> --- a/gcc/input.h >>>> +++ b/gcc/input.h >>> >>>> +struct location_hash : int_hash { }; >>>> + >>>&g

[PING] Re: Fix 'hash_table::expand' to destruct stale Value objects

2021-09-10 Thread Thomas Schwinge
Hi! On 2021-09-01T19:31:19-0600, Martin Sebor via Gcc-patches wrote: > On 8/30/21 4:46 AM, Thomas Schwinge wrote: >> Ping -- we still need to plug the memory leak; see patch attached, and/or >> long discussion here: > > Thanks for answering my questions. I have no concerns

Re: Host and offload targets have no common meaning of address spaces

2021-09-10 Thread Thomas Schwinge
wrote: >>> On Mon, Aug 16, 2021 at 10:08:42AM +0200, Thomas Schwinge wrote: >> |> Concerning the current 'gcc/omp-low.c:omp_build_component_ref', for the >> |> current set of offloading testcases, we never see a >> |> '!ADDR_SPACE_GENERIC_P' t

Re: [COMMITTED][patch][version 9]add -ftrivial-auto-var-init and variable attribute "uninitialized" to gcc

2021-09-10 Thread Thomas Schwinge
. Unrelated to the above, I've pushed as obvious "Fix 'dg-do run' syntax in 'c-c++-common/auto-init-padding-{2,3}.c'" to master branch in commit 5c5c2d86e520c3bf37368309b2fe932c88bdd14f, see attached. (All-PASS per my testing.) Grüße Thomas - Sie

Re: [committed] Fortran: Add missing ST_OMP_END_SCOPE handling [PR102313]

2021-09-15 Thread Thomas Schwinge
!.OMP END TASK" } > + > +!$omp end TASKGROUP ! { dg-error "Unexpected !.OMP END TASKGROUP" } > + > +!$omp end TASKLOOP ! { dg-error "Unexpected !.OMP END TASKLOOP" } > + > +!$omp end TASKLOOP SIMD ! { dg-error "Unexpected !.OMP END TASKLOOP SIMD

Re: GNU Tools @ LPC 2021: Program is published

2021-09-15 Thread Thomas Schwinge
chaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955 >From 51e2e792d8a66436df126a28e870ac9f38767600 Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Wed, 15 Sep 2021 17:08:12 +0200 Subject: [PATCH] G

Re: GNU Tools @ LPC 2021: Program is published

2021-09-16 Thread Thomas Schwinge
Hi! On 2021-09-16T05:58:22+0200, Gerald Pfeifer wrote: > On Wed, 15 Sep 2021, Thomas Schwinge wrote: >>> The program for the GNU Tools Track at Linux Plumbers Conference is >>> published: >>> >>> https://linuxplumbersconf.org/event/11/sessions/109/

Re: [PATCH] Fix PR 67102: Add libstdc++ dependancy to libffi

2021-09-17 Thread Thomas Schwinge
Hi Andrew! First, I appreciate you working through all these old PRs! On 2021-09-15T13:56:37-0700, apinski--- via Gcc-patches wrote: > The error message is obvious -funconfigured-libstdc++-v3 is used > on the g++ command line. So we just add the dependancy. > --- a/Makefile.def > +++ b/Makef

[PING^2] Re: [Committed] [PATCH 2/4] (v4) On-demand locations within string-literals

2021-09-17 Thread Thomas Schwinge
ditionally using >>> 'BUILTINS_LOCATION' as spare value for 'Deleted'. >> >> ... I didn't do this, but instead would like to push the attached >> "Don't record string concatenation data for 'RESERVED_LOCATION_P'"

[PING^2] Re: Fix 'hash_table::expand' to destruct stale Value objects

2021-09-17 Thread Thomas Schwinge
Hi! On 2021-09-10T10:00:25+0200, I wrote: > On 2021-09-01T19:31:19-0600, Martin Sebor via Gcc-patches > wrote: >> On 8/30/21 4:46 AM, Thomas Schwinge wrote: >>> Ping -- we still need to plug the memory leak; see patch attached, and/or >>> long discussion here:

Re: [PATCH] [og10] OpenACC: Shared memory layout optimisation

2021-09-17 Thread Thomas Schwinge
Hi Julian! Three quick questions here: On 2020-06-29T13:16:52-0700, Julian Brown wrote: > This patch implements an algorithm to lay out local data-share (LDS) space. > It currently works for AMD GCN. [...] Thanks! > @@ -1449,8 +1634,120 @@ oacc_do_neutering (void) > + addr_range ar >

Re: [PING^2] Re: Fix 'hash_table::expand' to destruct stale Value objects

2021-09-17 Thread Thomas Schwinge
Hi! On 2021-09-17T15:03:18+0200, Richard Biener wrote: > On Fri, Sep 17, 2021 at 2:39 PM Jonathan Wakely wrote: >> On Fri, 17 Sept 2021 at 13:08, Richard Biener >> wrote: >> > On Fri, Sep 17, 2021 at 1:17 PM Thomas Schwinge >> > wrote: >> > > On 2

Re: [PATCH] [og10] OpenACC: Shared memory layout optimisation

2021-09-17 Thread Thomas Schwinge
Hi! On 2020-06-29T13:16:52-0700, Julian Brown wrote: > --- /dev/null > +++ b/libgomp/testsuite/libgomp.oacc-c-c++-common/broadcast-many.c That one already/currently works without any code changes. > @@ -0,0 +1,79 @@ > +/* { dg-additional-options "-foffload=-mgang-local-size=64" } */ ... just w

Re: [PATCH] [og10] OpenACC: Turn off worker partitioning if num_workers==1

2021-09-17 Thread Thomas Schwinge
ion is one. In that case, we do not need to perform the broadcasting/neutering code transformation. gcc/ * omp-oacc-neuter-broadcast.cc (pass_omp_oacc_neuter_broadcast::gate): Disable if num_workers is 1. (execute_omp_oacc_neuter_broadcast): Adjust. Co-Authored-By: Thomas Schwinge --- gc

Re: [PATCH] [og10] OpenACC: Shared memory layout optimisation

2021-09-17 Thread Thomas Schwinge
Hi! On 2020-06-29T13:16:52-0700, Julian Brown wrote: > This patch implements an algorithm to lay out local data-share (LDS) space. > It currently works for AMD GCN. [...] Thanks. (... but I have not verified the algorithmic/behavioral changes in detail.) I've merged in PR96334 "openacc: Uns

Re: [PATCH] [og10] OpenACC: Remove unnecessary barriers (gimple worker partitioning/broadcast)

2021-09-17 Thread Thomas Schwinge
Hi! On 2020-06-29T13:17:30-0700, Julian Brown wrote: > This is an optimisation for middle-end worker-partitioning support (used > to support multiple workers on AMD GCN). At present, [...] Thanks. (... but I have not verified the algorithmic/behavioral changes.) I've removed (trivial) now-unt

Re: [PATCH] [og10] OpenACC: Shared memory layout optimisation

2021-09-21 Thread Thomas Schwinge
Hi! On 2021-09-20T13:46:03+0100, Julian Brown wrote: > On Fri, 17 Sep 2021 16:26:50 +0200 > Thomas Schwinge wrote: > >> > @@ -1449,8 +1634,120 @@ oacc_do_neutering (void) >> >> > + addr_range ar >> > + = first_fit_range (

Re: [Patch] Fortran: Improve -Wmissing-include-dirs warnings [PR55534]

2021-09-22 Thread Thomas Schwinge
Hi Tobias! On 2021-09-21T21:22:44+0200, Tobias Burnus wrote: > While the previous patch fixed -Wno-missing-include-dirs and sorted > out some inconsistencies with libcpp warnings, it had two issues: > > * Some superfluous warnings were printed, e.g. for > gfortran nonexisting/file.f90 >t

Re: [committed] Make test names unique for a couple of goacc tests

2021-09-22 Thread Thomas Schwinge
sure that we get unique test names if several DejaGnu directives refer to the same line", once and for all? OK to push after proper testing? Grüße Thomas - Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftun

Re: [PATCH] top-level configure: setup target_configdirs based on repository

2021-09-23 Thread Thomas Schwinge
Hi! I only had a curious look here; hope that's still useful. On 2021-09-22T16:30:42+0100, Andrew Burgess wrote: > The top-level configure script is shared between the gcc repository > and the binutils-gdb repository. > > The target_configdirs variable in the configure.ac script, defines > sub-d

Re: [PATCHv2] top-level configure: setup target_configdirs based on repository

2021-09-27 Thread Thomas Schwinge
; target_configdirs if we're not also building gcc. Thanks, that looks better in line with how that script generally appears to work (... per my not-in-depth understanding). (But I can't formally approve.) Reviewed-by: Thomas Schwinge Grüße Thomas > commit 84c8b7f160

Re: [committed] libgomp.oacc-fortran/privatized-ref-2.f90: Fix dg-note (was: [Patch] Fortran: Fix assumed-size to assumed-rank passing [PR94070])

2021-09-28 Thread Thomas Schwinge
schaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955 >From a43ae03a053faad871e6f48099d21e64b8e316cf Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Tue, 28 Sep 2021 08:05:28 +0200 Subject: [PATCH]

Re: [Patch] Fortran: Fix assumed-size to assumed-rank passing [PR94070]

2021-09-28 Thread Thomas Schwinge
nfuse DejaGnu... As obvious, pushed to master branch commit 95540a6d1d7b29cdd3ed06fbcb07465804504cfd "'gfortran.dg/assumed_rank_22_aux.c' messages printed vs. DejaGnu", see attached. Grüße Thomas - Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra

[ping] Make sure that we get unique test names if several DejaGnu directives refer to the same line (was: [committed] Make test names unique for a couple of goacc tests)

2021-09-29 Thread Thomas Schwinge
e 54+} (test for warnings, line 29) PASS: gfortran.dg/goacc/privatization-1-compute.f90 -O (test for excess errors) Given that we now amend the 'comment' by 'at line $useline"', and given that only ever one DejaGnu directive may appear on one source line, all th

[PING^3] Generalize 'gcc/input.h:struct location_hash' (was: [Committed] [PATCH 2/4] (v4) On-demand locations within string-literals)

2021-09-29 Thread Thomas Schwinge
s GTY(()) string_concat_db >>>>>> +{ >>>>>> +[...] >>>>>> + hash_map *m_table; >>>>>> +}; >>>>> >>>>> OK to push the attached >>>>> "Generalize 'gcc/input.h:struct location_hash

Re: [Ada] Gigi support for OpenACC pragmas

2019-12-04 Thread Thomas Schwinge
/19 10:29 AM, Thomas Schwinge wrote: >> On 2018-12-03T10:50:44-0500, Pierre-Marie de Rodat >> wrote: >>> Matching front-end bits to support Acc_Kernels, Acc_Parallel, >>> Acc_Loop and Acc_Data. See here: <https://gcc.gnu.org/ml/gcc-patches/2018-12/>. Grüße Thomas signature.asc Description: PGP signature

[RFC] Characters per line: from punch card (80) to line printer (132) (was: [Patch][OpenMP/OpenACC/Fortran] Fix mapping of optional (present|absent) arguments)

2019-12-05 Thread Thomas Schwinge
Hi! ;-P Jakub, thanks for furnishing me a fit occasion here: On 2019-12-05T16:15:15+0100, Jakub Jelinek wrote: > [...] much more indented though, but you could > use a temporary, like: > tree nullarg = null_pointer_node; I object to cluttering the code by introducing tempora

Re: [PATCH] [libgomp, amdgcn] Fix Fortran linker errors on AMD GCN

2019-12-06 Thread Thomas Schwinge
clear description. I suppose this hasn't been a problem for nvptx, as we're not supporting/using the symbol aliasing machinery there. > Tested on an x86_64 host with both NVPTX and GCN offloading. Okay to > commit to trunk? Yes, thanks. To record the review effort, please inc

Re: [RFC] Offloading Support in libgomp

2019-12-07 Thread Thomas Schwinge
target.c:gomp_unmap_vars_internal' that we're not unmapping 'tgt' while it's still in use": the following 'tgt->list_count' iterations as well as the following 'gomp_unref_tgt' would read 'free'd memory. OK to commit? If approving this p

Re: [Patch][OpenMP/OpenACC/Fortran] Fix mapping of optional (present|absent) arguments

2019-12-07 Thread Thomas Schwinge
Hi Tobias! On 2019-11-20T14:06:18+0100, Tobias Burnus wrote: > This patch does two things regarding explicit and automatical variable > mapping to offloaded devices: Thanks! > Compared to the previous patch set,** I added several OpenMP test cases > – and fixed the fallout. I'm seeing:

In 'libgomp/target.c:gomp_exit_data', remove open-coded 'gomp_remove_var' (was: [OpenACC] Update OpenACC data clause semantics to the 2.5 behavior - runtime)

2019-12-09 Thread Thomas Schwinge
chwinge Date: Mon, 9 Dec 2019 11:39:57 + Subject: [PATCH] In 'libgomp/target.c:gomp_exit_data', remove open-coded 'gomp_remove_var' libgomp/ * target.c (gomp_exit_data): Use 'gomp_remove_var'. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@279118 138bc75d-

Add 'libgomp.oacc-c-c++-common/host_data-6.c'

2019-12-09 Thread Thomas Schwinge
++-common/host_data-6.c | 47 +++ 2 files changed, 49 insertions(+) create mode 100644 libgomp/testsuite/libgomp.oacc-c-c++-common/host_data-6.c diff --git a/libgomp/ChangeLog b/libgomp/ChangeLog index c5541bcec81..6ef2f24e4d5 100644 --- a/libgomp/ChangeLog +++ b/libgomp/ChangeLog @@ -1,5 +1,7 @

[PR92854] Add 'libgomp.oacc-c-c++-common/pr92854-1.c'

2019-12-09 Thread Thomas Schwinge
common/pr92854-1.c diff --git a/libgomp/ChangeLog b/libgomp/ChangeLog index 6ef2f24e4d5..aac3b1887b0 100644 --- a/libgomp/ChangeLog +++ b/libgomp/ChangeLog @@ -1,5 +1,8 @@ 2019-12-09 Thomas Schwinge + PR libgomp/92854 + * testsuite/libgomp.oacc-c-c++-common/pr92854-1.c: New file. + * testsuite

Add 'libgomp.oacc-c-c++-common/map-data-1.c'

2019-12-09 Thread Thomas Schwinge
++-common/map-data-1.c| 53 +++ 2 files changed, 55 insertions(+) create mode 100644 libgomp/testsuite/libgomp.oacc-c-c++-common/map-data-1.c diff --git a/libgomp/ChangeLog b/libgomp/ChangeLog index aac3b1887b0..51a00a3a46c 100644 --- a/libgomp/ChangeLog +++ b/libgomp/ChangeLog @@ -1,5 +1,7 @

Re: [PATCH] OpenACC "present" subarrays: runtime API return value and unmapping fixes

2019-12-09 Thread Thomas Schwinge
e/libgomp.oacc-c-c++-common/lib-30.c create mode 100644 libgomp/testsuite/libgomp.oacc-c-c++-common/subset-subarray-mappings-1-d-a.c create mode 100644 libgomp/testsuite/libgomp.oacc-c-c++-common/subset-subarray-mappings-1-d-p.c create mode 100644 libgomp/testsuite/libgomp.oacc-c-c++-common/subset-subarra

Re: [PATCH] OpenACC reference count overhaul

2019-12-09 Thread Thomas Schwinge
Hi Julian! On 2019-10-03T09:35:04-0700, Julian Brown wrote: > --- a/libgomp/oacc-mem.c > +++ b/libgomp/oacc-mem.c > @@ -715,48 +684,34 @@ delete_copyout (unsigned f, void *h, size_t s, int > async, const char *libfnname) >if (f & FLAG_COPYOUT) > [...] > gomp_copy_dev2host (acc_

[PR92840] [OpenACC] Refuse 'acc_unmap_data' unless mapped by 'acc_map_data'

2019-12-09 Thread Thomas Schwinge
ommon/acc_unmap_data-pr92840-2.c create mode 100644 libgomp/testsuite/libgomp.oacc-c-c++-common/acc_unmap_data-pr92840-3.c diff --git a/libgomp/ChangeLog b/libgomp/ChangeLog index 739a76d48ac..7606f17825d 100644 --- a/libgomp/ChangeLog +++ b/libgomp/ChangeLog @@ -1,5 +1,17 @@ 2019-12-09 Thomas

[PR92503] [OpenACC] Don't silently 'acc_unmap_data' in 'acc_free'

2019-12-09 Thread Thomas Schwinge
diff --git a/libgomp/ChangeLog b/libgomp/ChangeLog index 7606f17825d..62092a2d765 100644 --- a/libgomp/ChangeLog +++ b/libgomp/ChangeLog @@ -1,5 +1,30 @@ 2019-12-09 Thomas Schwinge + PR libgomp/92503 + * oacc-mem.c (acc_free): Error out instead of 'acc_unmap_data'. + * testsuite

<    1   2   3   4   5   6   7   8   9   10   >