ef: b/10191963.
Sterling
2013-10-09 Sterling Augustine
* dwarf2out.c (include_pubname_in_output): Add conditional on
is_declaration_die
and debug_generate_pubnames.
patch.diff
Description: Binary data
On Wed, Oct 9, 2013 at 2:51 PM, Cary Coutant wrote:
>> 2013-10-09 Sterling Augustine
>>
>> * dwarf2out.c (include_pubname_in_output): Add conditional on
>> is_declaration_die
>> and debug_generate_pubnames.
>
> OK for google 4.8 branch. Than
by gdb and binutils, and it's addition here has been OK'd
by the gdb maintainers.
I'm not sure of the proper mechanics for adding a file already in src
to gcc, so if this is best done a different way, I'm happy to do so.
Thanks,
Sterling
include/ChangeLog:
2013-10-17 S
The enclosed patch (which depends on
http://gcc.gnu.org/ml/gcc-patches/2013-10/msg01395.html), ports the
new -ggnu-pubnames option from google 4.8 to trunk.
-gnu-pubnames enable the gold linker to to generate a better
.gdb_index section by including various bits of data about the symbol.
OK for t
DJ,
Is the below patch your purview? If not, do you know whose it is?
Sterling
-- Forwarded message --
From: Sterling Augustine
Date: Thu, Oct 17, 2013 at 11:52 AM
Subject: [PATCH] Add gdb/gdb-index.h to gcc tree.
To: gcc-patches , d...@redhat.com
The enclosed patch to
On Fri, Oct 18, 2013 at 4:45 PM, DJ Delorie wrote:
>
> I'm not sure either, but if it's been approved in gdb and you're
> willing to cede control of it to gcc's policies, I'm OK with it.
>
> Note that this will be a new directory in gcc, and I think the
> automerge scripts will automatically pick
I have checked in the enclosed patch, which makes GCC ignore
unrecognized DW_TAGs when building gnu-pubnames, instead of ICEing.
This matches GDB behavior.
Google ref:11307370
Sterling
Index: dwarf2out.c
===
--- dwarf2out.c (revision
On Thu, Oct 17, 2013 at 12:09 PM, Sterling Augustine
wrote:
> The enclosed patch (which depends on
> http://gcc.gnu.org/ml/gcc-patches/2013-10/msg01395.html), ports the
> new -ggnu-pubnames option from google 4.8 to trunk.
>
> -gnu-pubnames enable the gold linker to to ge
On Tue, Oct 22, 2013 at 12:05 PM, Sterling Augustine
wrote:
> On Thu, Oct 17, 2013 at 12:09 PM, Sterling Augustine
> wrote:
>> The enclosed patch (which depends on
>> http://gcc.gnu.org/ml/gcc-patches/2013-10/msg01395.html), ports the
>> new -ggnu-pubnames option
12-02 Sterling Augustine
* dwarf2out.c (output_pubnames): Use comp_unit_die ()->die_offset
when there
isn't a skeleton die.
pubtypes-bug.tot-patch
Description: Binary data
On Mon, Dec 2, 2013 at 1:59 PM, Cary Coutant wrote:
> This is OK, but your patch also has a local change to contrib/mklog.
> Please be careful not to commit that.
Committed without the contrib/mklog portion.
Also committing on google/gcc-4_8 and google/main.
On Wed, Jan 8, 2014 at 8:27 AM, Felix Yang wrote:
> Hi Sterling,
>
> This patch implements zero-overhead looping for xtensa backend using
> hw-doloop facility.
> If OK for trunk, please apply it for me. Thanks.
Hi Felix,
I last worked on zero-overhead loops for Xtensa in the gcc 4.3
timefram
On Thu, Jan 9, 2014 at 7:48 PM, Yangfei (Felix) wrote:
> And here is the xtensa configuration tested (include/xtensa-config.h):
>
> #define XCHAL_HAVE_BE 0
> #define XCHAL_HAVE_LOOPS1
Hi Felix,
I like this patch, and expect I will approve it. However, I would like
you
On Tue, Jan 14, 2014 at 7:20 AM, Felix Yang wrote:
> Hi Sterling,
>
> I found that we can avoid emitting excessive literal loading
> instructions with with section anchors.
> This patch also passed the cases in testsuite/gcc.c-torture/execute/ dir.
> Please apply it if OK for trunk.
Hi Feli
On Tue, Jan 14, 2014 at 7:14 AM, Felix Yang wrote:
> Hi Sterling,
>
> The xtensa backend uses register windows, and we need to define
> LOCAL_REGNO for it.
Hi Felix,
How does this change the produced code? In particular, please identify
a problem this patch is solving. I know that the docume
The enclosed patch for google 4.9 is a backport of r210828 from
trunk.
googleref:b/14623977
The given tests now pass when run by hand, but timeout under dejagnu
I will be sending a different change to fix that.
OK for google 4.9?
The enclosed patch for google 4.9 is a backport of r210828 from
tr
On Thu, Oct 9, 2014 at 10:21 AM, Carrot Wei wrote:
> LGTM.
> Your description could be more detail, such as which tests on which target.
Committed with a much improved message as r216291
On Mon, Nov 10, 2014 at 3:56 PM, Cary Coutant wrote:
> Backport pending upstream patch to fix demangler crash.
>
> https://gcc.gnu.org/ml/gcc-patches/2014-05/msg02279.html
>
> This patch is for the google/gcc-4_9 branch.
>
> Google ref: 17891596
>
> -cary
OK for Google branches.
Hi Jason,
Just wanted to be sure you saw this. I'm hoping to get it in for stage 1.
http://gcc.gnu.org/ml/gcc-patches/2012-10/msg02684.html
Sterling
Hi Jakub,
I would like to get the fission implementation in before stage 1. It
has been under review for some time, and is awaiting another round of
review now.
More info here:
http://gcc.gnu.org/ml/gcc-patches/2012-10/msg02684.html
Sterling
On Mon, Nov 5, 2012 at 3:18 PM, Cary Coutant wrote:
>> +/* %:replace-extension spec function. Replaces the extension of the
>> + first argument with the second argument. */
>> +
>> +const char *
>> +replace_extension_spec_func (int argc, const char **argv)
>> +{
>> + char *name;
>> + char *p
out.named_section at line 8837 is not protected by an
> #if defined (OBJECT_FORMAT_ELF)
> as elsewhere.
>
> TIA
>
> Dominique
I'm testing the enclosed patch on my end. Does it happen to work for you?
Sterling
2012-11-06 Sterling Augustine
* dwarf2out.c (output_comdat_type_unit): Check for OBJECT_FORMAT_ELF.
newpatch.diff
Description: Binary data
On Tue, Nov 6, 2012 at 5:02 PM, Dominique Dhumieres wrote:
>> I'm testing the enclosed patch on my end. Does it happen to work for you?
>
> I am now past the previous error. Full answer tomorrow morning.
>
> Thanks
>
> Dominique
I have committed the above fix as obvious. If there is additional
br
Thanks for testing this.
Enclosed is a simple fix for this ICE--address_table_entries that have
zero refcounts shouldn't be assigned an index.
OK for trunk?
Sterling
2012-11-14 Sterling Augustine
* dwarf2out.c (index_address_table_entry): Check a node's refcount.
On Wed, Nov 14, 2012 at 3:19 PM, Cary Coutant wrote:
>> Enclosed is a simple fix for this ICE--address_table_entries that have
>> zero refcounts shouldn't be assigned an index.
>>
>> OK for trunk?
>>
>> Sterling
>>
>> 2012-11
On Thu, Nov 29, 2012 at 10:26 AM, Sterling Augustine
wrote:
> This patch backports to gcc-google-4_7 the many changes to the fission
> implementation required to merge fission into trunk.
Committed as posted. Thanks!
The enclosed patch puts strings in the .debug_str section in the .o
file with -gsplit-dwarf. It is backported from from trunk (which, in turn,
was ported from google_4.7).
http://gcc.gnu.org/ml/gcc-patches/2013-04/msg01355.html
The patch itself is no different from the one finally applied to trun
On Tue, Apr 30, 2013 at 4:47 PM, Cary Coutant wrote:
>> The enclosed patch puts strings in the .debug_str section in the .o
>> file with -gsplit-dwarf. It is backported from from trunk (which, in turn,
>> was ported from google_4.7).
>>
>> http://gcc.gnu.org/ml/gcc-patches/2013-04/msg01355.html
>>
On Tue, Jul 2, 2013 at 1:37 PM, Cary Coutant wrote:
>
> This patch is for the google/gcc-4_7 and google/gcc-4_8 branches.
>
> When using -gsplit-dwarf, we use die_checksum to calculate a hash
> over the compilation unit for the DW_AT_dwo_id attribute. When
> hashing location expressions, the hash
Hi Cary,
Google 4.8 calculates the size of pubnames incorrectly in the presence
of pruned enumerators. The logic in size_of_pubnames should match that
in output_pubnames.
The enclosed patch fixes that.
OK for google 4.8?
Sterling
gcc/ChangeLog
2013-07-12 Sterling Augustine
On Mon, Jul 15, 2013 at 9:32 AM, Sterling Augustine
wrote:
> Hi Cary,
>
> Google 4.8 calculates the size of pubnames incorrectly in the presence
> of pruned enumerators. The logic in size_of_pubnames should match that
> in output_pubnames.
After some discussion off line, I hav
#x27;t
use the size field, so the bug was latent. Newer editions of gold will
use the size field, exposing the bug.
Google has been using a nearly identical patch for some time.
OK for trunk?
Sterling
gcc/ChangeLog
013-07-25 Sterling Augustine
* dwarf2out.c (size_of_pubnames): Mo
I have committed the following change from Google 4.7 (which is a
typo-fix) as obvious.
saugustine@sterling: ~/gcc-google-4_8/gcc/gcc $ svn diff dwarf2out.c
Index: dwarf2out.c
===
--- dwarf2out.c (revision 201717)
+++ dwarf2out.c (wor
not observing new failures.
OK for trunk?
Sterling
2013-04-22 Sterling Augustine
* dwarf2out.c (skeleton_debug_str_hash, comp_dir_string,
add_skeleton_AT_string. comp_dir_string, debug_str_dwo_section): New.
(DEBUG_STR_DWO_SECTION): Rename to
On Sun, Jan 19, 2014 at 1:21 AM, Baruch Siach wrote:
> The xtensa port uses __xtensa_libgcc_window_spill in libgcc to implement
> __builtin_frame_address. This symbol is local/hidden in libgcc. This is not a
> problem when linking against static libgcc. But g++ defaults to
> -shared-libgcc, thus b
On Mon, Jan 20, 2014 at 9:46 PM, Baruch Siach wrote:
> Hi Sterling,
>> This is OK for mainline.
>
> Thanks. This is needed for the 4.7 and 4.8 branches as well.
>
>> I assume your copyright assignment is on file?
>
> According to
> https://www.gnu.org/prep/maintain/html_node/Legally-Significant.ht
On Mon, Jan 20, 2014 at 9:46 PM, Baruch Siach wrote:
> Hi Sterling,
>
> On Mon, Jan 20, 2014 at 12:06:59PM -0800, Sterling Augustine wrote:
>> On Sun, Jan 19, 2014 at 1:21 AM, Baruch Siach wrote:
>> > The xtensa port uses __xtensa_libgcc_window_spil
commit 257910a4dd56ac0c95ad79053a4364a3ff34a674
Author: Sterling Augustine
Date: Wed Jan 16 13:22:59 2013 -0800
Fix for PR 8013197.
Address table entries will already have been removed at this point in
resolve_addr, so no need to call again.
M gcc/dwarf2out.c
Tested
On Wed, Jan 16, 2013 at 4:21 PM, Cary Coutant wrote:
>
> > 2013-01-16 Sterling Augustine
> >
> > * gcc/dwarf2out.c (resolve_addr): Delete call to
> > remove_addr_table_entry.
>
> OK for google/gcc-4_7. The commit log entry should say "G
commit dc0b9bc855444332e7a3b1f3473a70ce0c72d66c
Author: Sterling Augustine
Date: Fri Jan 18 10:38:30 2013 -0800
Fix for Google Ref: b/8028506
Calling find_AT_string can resize the debug_str hash table, even if the
string is already present in the hash table--go figure. So
On Fri, Jan 18, 2013 at 11:04 AM, Cary Coutant wrote:
>> commit dc0b9bc855444332e7a3b1f3473a70ce0c72d66c
>> Author: Sterling Augustine
>> Date: Fri Jan 18 10:38:30 2013 -0800
>>
>> Fix for Google Ref: b/8028506
>>
>> Calling find_AT_string ca
The enclosed patch for Google 4.7 is an optimization for debug strings
under -gsplit-dwarf. Currently under -gsplit-dwarf, all strings with
DW_FORM_strp end up in the .debug_str.dwo section, which requires any
string not destined for the .dwo to use DW_FORM_string, disallowing any
duplication remo
On Mon, Feb 4, 2013 at 11:56 AM, Cary Coutant wrote:
>> @@ -22385,21 +22448,21 @@
>> static void
>> output_indirect_strings (void)
>> {
>> + switch_to_section (debug_str_section);
>>if (!dwarf_split_debug_info)
>> -{
>> - switch_to_section (debug_str_section);
>> - htab_trave
On Mon, Feb 4, 2013 at 1:45 PM, Cary Coutant wrote:
>> Ahh, good catch. Fixed as attached.
>
> Looks good, thanks. OK for the google/gcc-4_7 branch.
>
> (And, yes, please do port this to trunk when Stage 1 reopens.)
Thanks. Committed.
On Sun, Aug 12, 2012 at 12:46 PM, Jack Howarth wrote:
> This patch introduces the regressions...
>
> FAIL: g++.dg/debug/dwarf2/pubnames-2.C scan-assembler
> .section\t.debug_pubnames
> FAIL: g++.dg/debug/dwarf2/pubnames-2.C scan-assembler
> "_GLOBAL__sub_I__ZN3one3c1vE0"+[ \t]+[#;]+[ \t]+exte
On Sun, Aug 12, 2012 at 12:46 PM, Jack Howarth wrote:
> On Sun, Jul 01, 2012 at 09:33:06AM -0500, Gabriel Dos Reis wrote:
>> On Thu, Jun 28, 2012 at 12:50 PM, Sterling Augustine
>> wrote:
>> > The enclosed patch adds a fix for the pubnames anonymous namespaces
>>
On Mon, Aug 13, 2012 at 6:18 PM, Mike Stump wrote:
> On Aug 13, 2012, at 4:56 PM, Sterling Augustine wrote:
>> The enclosed patch adjusts the test so it will pass on darwin. The
>> issue was that it looked for some elf-specific assembly directives,
>> which it shouldn
can't generate the index entry directly
because the cu_index is calculated during the link, but we can generate the
flag byte.
Of particular note is the fact that this patch adds include/gdb/gdb-index.h
from the gdb and binutils trees.
OK for google 4.7?
Sterling
2012-08-16 Sterling August
On Fri, Aug 17, 2012 at 6:59 AM, David Edelsohn wrote:
>
> On Fri, Aug 17, 2012 at 9:39 AM, H.J. Lu wrote:
>
> > Here is the updated patch. Steve, David, Sterling, can you take a
> > look
> > at ia64, rs6000 and xtensa changes?
>
> > * config/rs6000/rs6000.c (TARGET_MEMBER_TYPE_FORCES_
On Fri, Aug 17, 2012 at 3:09 PM, Cary Coutant wrote:
> This patch is for the google/gcc-4_7 branch. I'll submit it for trunk
> after the Fission patches have gone in.
>
> When adding names to the pubnames table (-gsplit-dwarf or -gpubnames),
> a method within a union may not get handled properly,
On Thu, Aug 16, 2012 at 5:32 PM, Cary Coutant wrote:
>> +/* Output a single entry in the pubnames table. */
>> +
>> +static void
>> +output_pubname (dw_offset die_offset, pubname_entry *entry)
>
> For this function, I'd suggest a comment to the effect that the logic
> is lifted from GDB.
>
>> @@
On Mon, Aug 20, 2012 at 5:30 PM, Cary Coutant wrote:
> This patch is for the google/gcc-4_7 branch.
>
> When a location list or location expression is removed from a DIE, we
> need to remove entries in the .debug_addr table that were referenced
> by those location expressions. Except for one case
My last change to google 4.7 that included gdb/gdb-index.h as it
exists in binutils, but it included a trailing comma in an enumerator.
I have checked in as obvious the patch below which eliminates the
trailing comma.
Sterling
2012-08-20 Sterling Augustine
* gdb/gdb-index.h: Remove
> Google ref b/7041390.
>
>
> 2012-08-25 Cary Coutant
>
> gcc/
> * dwarf2out.c (is_template_instantiation): New function.
> (should_move_die_to_comdat): Reject types that are template
> instantiations.
This patch is OK for google 4.7
Sterling
On Wed, Aug 29, 2012 at 12:03 PM, Cary Coutant wrote:
>> This patch is for trunk and the google/gcc-4_7 branch.
>>
>> 2012-08-28 Cary Coutant
>>
>> * gcc/dwarf2out.c (clone_tree_partial): Remove.
>> (copy_decls_walk): Don't copy children of a declaration
>> into a type
On Sat, Sep 1, 2012 at 1:44 PM, wrote:
> From: ccout...@google.com (Cary Coutant)
> To: d...@google.com, gcc-patches@gcc.gnu.org
> Cc:
> Date: Fri, 31 Aug 2012 16:55:40 -0700 (PDT)
> Subject: [google/gcc-4_7] Fix GDB test suite regression with
> -fdebug-types-section patch
> This patch is for th
comp_unit_die instead.
This problem doesn't exist in later editions of the code because
GCC has been patched to ensure that all pubtypes will have a skeleton
die. So this is for Google 4.7 only.
OK for Google 4.7?
Sterling
2012-09-07 Sterling Augustine
* gcc/dwarf2out.c (output_pub
On Fri, Sep 7, 2012 at 3:44 PM, Cary Coutant wrote:
>> 2012-09-07 Sterling Augustine
>>
>> * gcc/dwarf2out.c (output_pubnames): Call comp_unit_die.
>
> OK for google/gcc-4_7.
>
> -cary
Committed as r191084.
On Sun, Sep 9, 2012 at 11:31 PM, Chung-Lin Tang wrote:
> On 2012/8/28 下午 04:15, Chung-Lin Tang wrote:
>> On 12/7/12 下午2:52, Chung-Lin Tang wrote:
>> Xtensa parts updated to use MD pattern.
>>
>> Thanks,
>> Chung-Lin
>>
>> * config/xtensa/xtensa.md (get_thread_pointersi): Renamed from
>> lo
The enclosed patch fixes a reversed conditional when calculating the
is_static flag while generating gdb index--is_static is the opposite
of the DW_AT_external flag.
OK for google 4.7?
Sterling
2012-09-10 Sterling Augustine
* dwarf2out.c (output_pubname): Correct conditional.
Index
On Mon, Sep 10, 2012 at 3:05 PM, Cary Coutant wrote:
>> The enclosed patch fixes a reversed conditional when calculating the
>> is_static flag while generating gdb index--is_static is the opposite
>> of the DW_AT_external flag.
>>
>> OK for google 4.7?
>>
&g
The enclosed patch fixes yet another bug with the gdb-index v7 flag byte
by reporting certain structs and types as static only for non-C++ and
non-java.
OK for Google 4.7?
Sterling
2012-09-11 Sterling Augustine
* dwarf2out.c (output_pubname):
Index: dwarf2out.c
On Tue, Sep 11, 2012 at 5:13 PM, Cary Coutant wrote:
>> The enclosed patch fixes yet another bug with the gdb-index v7 flag byte
>> by reporting certain structs and types as static only for non-C++ and
>> non-java.
>>
>> OK for Google 4.7?
>>
>> Ste
On Wed, Sep 12, 2012 at 4:18 PM, Cary Coutant wrote:
> 2012-09-12 Cary Coutant
>
> gcc/
> * gcc.c (replace_extension_spec_func): Restrict search for
> extension to last component of path.
>
> Index: gcc/gcc.c
> ===
> I lean toward -g myself, since there doesn't seem to be a strong rule one
> way or the other.
Unless there are further comments, I'll stick with -g then.
I think that covers all the comments, so I think I will commit this
Friday morning unless I hear anything further.
Sterling
the comdat_type_p field.
It sticks with -gpubnames as earlier discussed.
Anything else?
Sterling
2012-06-14 Sterling Augustine
Cary Coutant
* dwarf2out.c (is_cu_die, is_namespace_die, is_class_die,
add_AT_pubnames, add_enumerator_pubname, want_pubnames): New functi
On Wed, Jun 13, 2012 at 10:47 PM, Jason Merrill wrote:
> On 06/13/2012 04:26 PM, Sterling Augustine wrote:
>>>
>>> I lean toward -g myself, since there doesn't seem to be a strong rule one
>>> way or the other.
>>
>>
>> Unless there are fur
Committed as attached. Thanks for your reviews.
Sterling
gcc/ChangeLog
2012-06-21 Sterling Augustine
Cary Coutant
* dwarf2out.c (is_cu_die, is_namespace_die, is_class_die,
add_AT_pubnames, add_enumerator_pubname, want_pubnames): New functions
On Fri, Jun 22, 2012 at 2:47 AM, Dominique Dhumieres wrote:
>> I've heard reports of new test failures due to this patch:
>>
>> FAIL: gcc.dg/pubtypes-2.c scan-assembler long+[ \\t]+0x6a+[ \\t]+[#;]+[
>> \\t]+Length of Public Type Names Info
>> FAIL: gcc.dg/pubtypes-3.c scan-assembler long+[ \\t]+
gcc/ChangeLog
2012-06-22 Sterling Augustine
* dwarf2out.c (add_enumerator_pubname): Use pubtypes_table.
On Fri, Jun 22, 2012 at 2:47 AM, Dominique Dhumieres wrote:
>> I've heard reports of new test failures due to this patch:
>>
>> FAIL: gcc.dg/pubtypes-2.c scan-assembler long+[ \\t]+0x6a+[ \\t]+[#;]+[
>> \\t]+Length of Public Type Names Info
>> FAIL: gcc.dg/pubtypes-3.c scan-assembler long+[ \\t]+
On Sat, Jun 23, 2012 at 3:55 AM, Dominique Dhumieres wrote:
>> As I don't have access to a Darwin machine to test a fix, would you
>> mind updating the test?
>
> The failures are gone with the obvious patch:
>
> diff -up ../_clean/gcc/testsuite/gcc.dg/pubtypes-2.c
> gcc/testsuite/gcc.dg/pubtypes-
he pubtypes
table, but I am happy to do it whichever way you want.
Let me know,
Sterling
gcc/ChangeLog
2012-06-25 Sterling Augustine
* dwarf2out.c (output_pubnames): Add check for DW_TAG_enumerator.
(prune_unused_types): Add check for DW_TAG_enumerator.
enum.patch
Description: Binary data
Committed as posted.
On Mon, Jun 25, 2012 at 8:35 PM, Jason Merrill wrote:
> OK.
>
> Jason
On Mon, Jun 25, 2012 at 7:13 PM, Mike Stump wrote:
> On Jun 25, 2012, at 3:15 PM, Sterling Augustine wrote:
>> On Sat, Jun 23, 2012 at 3:55 AM, Dominique Dhumieres
>> wrote:
>>>> As I don't have access to a Darwin machine to test a fix, would you
>>
test suite.
OK for mainline?
Sterling
gcc/cp/ChangeLog
2012-06-28 Sterling Augustine
* error.c (lang_decl_name): Use TFF_UNQUALIFIED_NAME flag.
gcc/testsuite/ChangeLog
2012-06-28 Sterling Augustine
* g++.dg/debug/dwarf2/pubnames-2.C: New.
Index:
Enclosed is a patch that fixes indention and adds an already-approved
comment that I missed when porting the previous patch. I have checked
it in under the obvious rule.
Sterling
obvious.patch
Description: Binary data
Committed as posted.
Thanks.
On Sun, Jul 1, 2012 at 7:33 AM, Gabriel Dos Reis
wrote:
> On Thu, Jun 28, 2012 at 12:50 PM, Sterling Augustine
> wrote:
>> The enclosed patch adds a fix for the pubnames anonymous namespaces contained
>> within named namespaces, and adds an exte
On Tue, Jul 10, 2012 at 6:51 AM, Dominique Dhumieres wrote:
> Hi Sterling,
>
> On x86_64-apple-darwin10 the test fails with
>
> FAIL: g++.dg/debug/dwarf2/pubnames-2.C scan-assembler
> .section\t.debug_pubnames
> FAIL: g++.dg/debug/dwarf2/pubnames-2.C scan-assembler
> "_GLOBAL__sub_I__ZN3one3c1vE
On Tue, Jul 24, 2012 at 5:08 PM, Cary Coutant wrote:
> This patch is for the google/gcc-4_7 branch.
>
> Backport Fission patches from trunk at r186934, r187061, and r188759.
> Backport pending Fission patch at http://codereview.appspot.com/6305113.
>
> Patches for include/dwarf2.def have been back
On Tue, Jul 24, 2012 at 5:51 PM, Cary Coutant wrote:
> This patch is for the google/gcc-4_7 branch.
>
> Add -gfission as alias for -gsplit-dwarf.
>
> Tested by bootstrap and regression testing.
>
>
> * common.opt (-gfission): Alias for -gsplit-dwarf.
> (-gno-fission): Alias for -gn
On Wed, Jul 25, 2012 at 11:45 AM, Cary Coutant wrote:
> This patch is for the google/gcc-4_7 branch.
>
> Backport pending upstream patch to output DW_AT_high_pc as a constant
> instead of a relocated address. This significantly reduces the number
> of entries used in the .debug_addr table with -g
On Wed, Jul 25, 2012 at 4:00 PM, Cary Coutant wrote:
>>> +/* Remove an entry from the addr table. Since we have already numbered
>>> + all the entries, the best we can do here is null it out. */
>>
>> This sounds like a design flaw. Since we have everything in memory, there's
>> no reason we
On Wed, Jul 25, 2012 at 5:06 PM, Cary Coutant wrote:
> This patch is for the google/gcc-4_7 branch.
>
> Compute a dwo_id and write the DW_AT_GNU_dwo_id attribute to both the
> skeleton compile unit DIE and the DWO compile unit DIE.
>
This is OK for google 4.7.
Sterling
mous}" to "(anonymous namespace)".
Tested in conjunction with the second patch in this series by running
the testsuite and observing no regresssions other than those fixed by this
patch.
OK for mainline?
Sterling
2012-05-07 Sterling Augustine
* gcc/testsuite/g++.old-deja/g+
This is the second in the series of patches to make c decl pretty printing
more closely match the demangler. A full explanation is here:
http://gcc.gnu.org/ml/gcc-patches/2012-05/msg00512.html
OK for mainline?
Sterling
2012-05-07 Sterling Augustine
* c-family/c-pretty-print.c
On Mon, May 7, 2012 at 6:44 PM, Gabriel Dos Reis
wrote:
> On Mon, May 7, 2012 at 7:10 PM, Sterling Augustine
> wrote:
>> This is the second in the series of patches to make c decl pretty printing
>> more closely match the demangler. A full explanation is here:
>>
>
patch in
to the front end under review at
http://gcc.gnu.org/ml/gcc-patches/2012-05/msg00512.html.
Tested with bootstrap and running the test_pubnames_and_indices.py script
recently contributed to the GDB project.
OK for mainline?
Sterling
2012-05-10 Sterling Augustine
* dwarf2out.c
nline?
Sterling
2012-05-16 Sterling Augustine
* gcc/c-family/c-pretty-print.h (pp_c_flag_gnu_v3): New enumerator.
* gcc/c-family/c-pretty-print.c (pp_c_specifier_qualifier_list): Check
it at both the start and end of the function.
* gcc/cp/cp-t
On Thu, May 10, 2012 at 9:08 AM, Sterling Augustine
wrote:
> The enclosed patch fixes many issues with pubnames and pubtypes. It generates
> them for many more variables and with mostly correct and canonical dwarf
> names.
>
> This patch should not affect any target that does n
On Wed, May 16, 2012 at 1:03 PM, Sterling Augustine
wrote:
> This patch adds new flags and defines such that the C++ decl pretty printer
> prints both canonical dwarf names for decls without perturbing normal error
> message output.
>
> It addresses the issues with the earlier pa
On Tue, May 22, 2012 at 10:19 AM, Jason Merrill wrote:
I'll let Cary handle the other questions.
> Yes, I agree that we want to put "some_function" in pubnames. I still don't
> see how putting the anonymous namespace itself in pubnames helps at all. As
> far as pubnames is concerned, the anony
On Wed, May 16, 2012 at 1:03 PM, Sterling Augustine
wrote:
> This patch adds new flags and defines such that the C++ decl pretty printer
> prints both canonical dwarf names for decls without perturbing normal error
> message output.
>
> It addresses the issues with the earlier pa
On Wed, May 30, 2012 at 2:15 PM, Gabriel Dos Reis
wrote:
> On Tue, May 29, 2012 at 5:32 PM, Sterling Augustine
> wrote:
>
>>> Index: gcc/c-family/c-pretty-print.h
>>> ===
>>> --- gcc/c-family/c-p
s users
to generate pubtypes even if the target disables them by default.
Tested with bootstrap and running the test_pubnames_and_indices.py script
recently contributed to the GDB project.
OK for mainline?
Sterling
2012-05-10 Sterling Augustine
Cary Coutant
* gcc/d
cxx_dwarf_name with new functions that set the
appropriate flag on the pretty printer. This is much cleaner and avoids
the need for translating flags for C++ pretty-printing into standard C
pretty printing flags.
OK for mainline?
Sterling
2012-06-01 Sterling Augustine
* gcc/c-family/c-pretty
On Fri, Jun 1, 2012 at 4:38 PM, Gabriel Dos Reis
wrote:
> On Fri, Jun 1, 2012 at 6:07 PM, Sterling Augustine
> wrote:
>> After finding yet another bug in the previous patch dealing with
>> pretty-printing
>> decls for dwarf in canonical form, I have figured out a way
On Wed, Jun 6, 2012 at 3:49 PM, Steven Bosscher wrote:
> On Mon, Jun 4, 2012 at 7:53 PM, Sterling Augustine
> wrote:
>> On Fri, Jun 1, 2012 at 4:38 PM, Gabriel Dos Reis
>> wrote:
>>> On Fri, Jun 1, 2012 at 6:07 PM, Sterling Augustine
>>> wrote:
>&
On Wed, Jun 6, 2012 at 11:23 PM, Cary Coutant wrote:
> This patch is for the google/gcc-4_6 branch.
>
> In porting the earlier patch to use constant forms for DW_AT_high_pc,
> the code in dwarf2out_finish was inadvertently changed to use an
> indirect form for DW_AT_low_pc in the main compile_unit
On Fri, Jun 8, 2012 at 2:22 PM, Cary Coutant wrote:
>> Hmm, I thought the convention for this sort of flag was to start with -f,
>> that -g flags were only for selecting the type and level of debug info. But
>> I see that there are other debug dialect switches that use -g, so I guess
>> this is O
1 - 100 of 112 matches
Mail list logo
