On Fri, Aug 30, 2013 at 9:58 PM, Teresa Johnson wrote:
> Besides, we might also want to
> use the same machinery (dump_printf_loc etc) for dump file dumping.
> The current behavior of using '-details' to turn on opt-info-all
> messages for dump files are not desirable.
In
On Thu, Sep 27, 2012 at 4:35 AM, Sharad Singhai
>> wrote:
>> > Thanks for the review. A couple of comments inline:
>> >
>> >> Some minor issues:
>> >>
>> >> * c/c-decl.c (c_write_global_declarations): Use different
>> &g
I am sorry, I didn't enable all the languages. Will fix the fortran
test breakage shortly.
Thanks,
Sharad
Sharad
On Mon, Oct 1, 2012 at 4:50 AM, H.J. Lu wrote:
> On Sun, Sep 30, 2012 at 11:36 PM, Sharad Singhai wrote:
>> Resend to gcc-patches
>>
>> I have addressed
On Mon, Oct 1, 2012 at 6:52 AM, H.J. Lu wrote:
> On Mon, Oct 1, 2012 at 6:49 AM, Sharad Singhai wrote:
>> I am sorry, I didn't enable all the languages. Will fix the fortran
>> test breakage shortly.
>
> It is not just Fortran. There are some failures in C testcases.
Okay, I am retesting without any special configs and with multilibs as
you suggested.
Thanks,
Sharad
On Mon, Oct 1, 2012 at 7:00 AM, Richard Guenther
wrote:
> On Mon, Oct 1, 2012 at 3:55 PM, Sharad Singhai wrote:
>> On Mon, Oct 1, 2012 at 6:52 AM, H.J. Lu wrote:
>>> On Mon
make check. Is it ok to install?
>>
>> 2012-10-01 Michael Meissner
>>
>> * config/rs6000/rs6000.c (toplevel): Include dumpfile.h.
>> (rs6000_density_test): Rework to accomidate 09-30 change by Sharad
>> Singhai.
>>
>>
Here is a patch to fix test breakage caused by r191883. Bootstrapped
on x86_64 and tested with
make -k check RUNTESTFLAGS="--target_board=unix/\{,-m32\}".
Okay for trunk?
Thanks,
Sharad
2012-10-01 Sharad Singhai
* tree-vect-stmts.c (vectorizable_operation): Add miss
I have mailed a patch to fix test failures caused by r191884. Waiting
for an okay.
http://gcc.gnu.org/ml/gcc-patches/2012-10/msg00109.html
Thanks,
Sharad
Sharad
On Mon, Oct 1, 2012 at 11:39 AM, Gabriel Dos Reis
wrote:
> On Mon, Oct 1, 2012 at 1:27 PM, Michael Meissner
> wrote:
>> On Mon, Oct
are available.
I have bootstrapped and tested on x86_64. Okay for trunk?
Thanks,
Sharad
2012-10-18 Sharad Singhai
* dumpfile.c (dump_enabled_phase): New function.
(dump_enabled_p): Rename to dump_enabled_phase. Update all callers.
A new function with the same name to check if any of the
observe any new test
failures. Okay for trunk?
Thanks,
Sharad
2012-10-19 Sharad Singhai
* dumpfile.c (dump_phase_enabled_p): Renamed dump_enabled_p. Update
all callers.
(dump_enabled_p): A new function to check if any of the dump files
is available.
(dump_kind_p): Remove check for curre
+cc richard.guent...@gmail.com
If it is approved, I will be happy to commit it for you.
Thanks,
Sharad
Sharad
On Tue, Oct 23, 2012 at 6:52 AM, Dominique Dhumieres wrote:
> Following the changes in [PATCH] Add option for dumping to stderr
> (issue6190057)
> the tests gcc.dg/vect/vect-8[23]_64.
The trunk seems to be broken at r192749 due to this patch.
../../srctrunk/gcc/tree-ssa-threadedge.c: In function ‘void
thread_across_edge(gimple_statement_d*, edge_def*, bool,
vec_t**, tree_node* (*)(gimple_statement_d*,
gimple_statement_d*))’:
../../srctrunk/gcc/tree-ssa-threadedge.c:583: error:
E_DFS_BACK) == 0
- || ! cond_arg_set_in_bb (e3, e->dest, 3))
+ || ! cond_arg_set_in_bb (e3, e->dest))
e2 = thread_around_empty_block (e3,
dummy_cond,
handle_dominating_asserts,
Sharad
On Tue, Oct 23, 2012 at 4:48 PM, Sharad Singhai wrote:
> The trunk seems to be brok
Committed in r192750.
Thanks,
Sharad
On Tue, Oct 23, 2012 at 2:46 PM, Mike Stump wrote:
> On Oct 23, 2012, at 6:52 AM, Dominique Dhumieres wrote:
>> Following the changes in [PATCH] Add option for dumping to stderr
>> (issue6190057)
>> the tests gcc.dg/vect/vect-8[23]_64.c fails on powerpc*-*-
Added myself as write after approval maintainer in r192781.
Thanks,
Sharad
Index: ChangeLog
===
--- ChangeLog (revision 192779)
+++ ChangeLog (working copy)
@@ -1,3 +1,7 @@
+2012-10-24 Sharad Singhai
+
+ * MAINTAINERS (Write
As per discussion in http://gcc.gnu.org/ml/gcc/2012-10/msg00366.html.
I have applied the following obvious fix for rs6000 broken bootstrap.
2012-10-24 Sharad Singhai
* config/rs6000/rs6000.c (rs6000_density_test): Use dump_enabled_p
instead of dump_kind_p.
Index: config
Hi Jakub,
My -fopt-info pass filtering patch
(http://gcc.gnu.org/ml/gcc-patches/2012-10/msg02704.html) is being
reviewed and I hope to get this in by Nov. 5 for inclusion in gcc
4.8.0.
Thanks,
Sharad
On Mon, Oct 29, 2012 at 10:56 AM, Jakub Jelinek wrote:
> Status
> ==
>
> I'd like to close
ay
for the trunk?
Thanks,
Sharad
2013-10-29 Sharad Singhai
PR middle-end/58134
* opts.c (common_handle_option): Remove deprecated option
-ftree-vectorizer-verbose.
* doc/invoke.texi (Debugging Options): Ditto.
* common.opt: Ditto.
* opt
I am really sorry, I forgot to add gcc internal documentation for dump
functions. Sorry about a very long delay.
The attached patch adds some documentation about how to use the new
dump infrastructure. This doc is attached to 'passes' documentation
node as that seemed the most logical place. Also,
Committed documentation as r206161. Sorry about the delay.
Thanks,
Sharad
On Thu, Nov 28, 2013 at 10:03 AM, Martin Jambor wrote:
> Hi,
>
> On Tue, Aug 06, 2013 at 10:18:05AM -0700, Sharad Singhai wrote:
>> On Tue, Aug 6, 2013 at 10:10 AM, Martin Jambor wrote:
>> > On Tu
On Tue, Oct 30, 2012 at 4:04 PM, Sharad Singhai wrote:
> Hi Jakub,
>
> My -fopt-info pass filtering patch
> (http://gcc.gnu.org/ml/gcc-patches/2012-10/msg02704.html) is being
> reviewed and I hope to get this in by Nov. 5 for inclusion in gcc
> 4.8.0.
I just committed -fopt-i
I am really sorry about that. I am looking and will fix the breakage
or revert the patch shortly.
Thanks,
Sharad
On Thu, Nov 1, 2012 at 5:28 AM, Jakub Jelinek wrote:
> On Thu, Nov 01, 2012 at 12:52:04AM -0700, Sharad Singhai wrote:
>> On Tue, Oct 30, 2012 at 4:04 PM, Sharad Singh
ure.
Assuming tests pass, is it okay to commit the following?
Thanks,
Sharad
2012-11-01 Sharad Singhai
PR other/55164
* dumpfile.h (struct dump_file_info): Fix order of flags.
Index: dumpfile.h
===
--- dumpfile.h (revision 19
On Thu, Nov 1, 2012 at 9:44 AM, Diego Novillo wrote:
> On Thu, Nov 1, 2012 at 12:40 PM, Sharad Singhai wrote:
>> I found the problem and the following patch fixes it. The issue with
>> my testing was that I was only looking at 'FAIL' lines but forgot to
>> tally t
Hi,
This patch forward ports r175134 from google/gcc-4.7 into
google/gcc-4.8. The intermediate format is a bit simplified. I am also
planning to propose this for trunk in a separate message.
Bootstrapped and tested on x86_64. Okay for google/gcc-4_8?
Thanks,
Sharad
2013-05-24 Sharad Singhai
tion
(generate_results): Handle new option.
(release_function): Relase demangled name.
(read_graph_file): Handle demangled name.
(output_lines): Ditto.
* doc/gcov.texi: Document gcov intermediate format.
testsuite/ChangeLog:
2013-05-28 Sharad Singhai
* g++.dg/gcov/gcov-8.C: New
.
(output_gcov_file): New function
(generate_results): Handle new option.
(release_function): Relase demangled name.
(read_graph_file): Handle demangled name.
(output_lines): Ditto.
* doc/gcov.texi: Document gcov intermediate format.
testsuite/ChangeLog:
2013-05-28 Sharad Singhai
* g++.dg
On Fri, May 24, 2013 at 7:42 PM, Xinliang David Li wrote:
> On Fri, May 24, 2013 at 2:32 PM, Sharad Singhai wrote:
>>if (flag_gcov_file)
>> {
>> - char *gcov_file_name
>> -= make_gcov_file_name (file_name, src->coverage.name);
>> +
All tests passed. Committed as r199390 in google/gcc-4_8.
Thanks,
Sharad
On Tue, May 28, 2013 at 11:45 AM, Sharad Singhai wrote:
> On Fri, May 24, 2013 at 7:42 PM, Xinliang David Li wrote:
>> On Fri, May 24, 2013 at 2:32 PM, Sharad Singhai wrote:
>>>
Ping.
Thanks,
Sharad
On Tue, May 28, 2013 at 11:35 AM, Sharad Singhai wrote:
> Sorry, my patch had bad formatting in one of the functions
> (output_gcov_file). Here is the corrected version.
>
> Thanks,
> Sharad
>
> (2013-05-28
>
> * gcov.c (print_usage): Handle
1.cmo.3:
... ...
Tested on powerpc as well as ran manual tests. Okay for google/4_9 branch?
Thanks,
Sharad
2014-09-15 Sharad Singhai
Google Ref b/17114943
* l-ipo.c (promote_static_var_func): Update RTL with the unique name.
testsuite/Chan
Ping.
Thanks,
Sharad
On Wed, Jun 5, 2013 at 11:18 AM, Sharad Singhai wrote:
> Ping.
>
> Thanks,
> Sharad
>
>
> On Tue, May 28, 2013 at 11:35 AM, Sharad Singhai wrote:
>> Sorry, my patch had bad formatting in one of the functions
>> (output_gcov_fil
On Tue, Jun 18, 2013 at 3:28 AM, Jan Hubicka wrote:
>> Ping.
> Th patch is OK, thanks!
> I see you added gcov.exp file support, do you have a testcases?
Yes, I added support for verifying intermediate format in gcov.exp. I
also added a minimal testcase for intermediate format in
testsuite/g++.dg/
Hi,
This patch forward ports the -Wreal-conversion warning to
google/gcc-4_8 branch (google ref 39133-p2). I tweaked the patch a
little bit to avoid printing duplicate warnings when both -Wconversion
and -Wreal-conversion are specified. Also, I trimmed the test case to
avoid testing for integer-to
On Mon, Jun 24, 2013 at 9:14 PM, Xinliang David Li wrote:
> To avoid printing twice, can you just do
>
> opt_type = (warn_conversion ? OPT_Wconversion : OPT_Wreal_conversion);
> warning_at (loc, opt_type, ...);
Thanks for the suggestion. I have updated the enclosed patch and
retested. Okay for go
AT_TYPE_P (expr_type)))
> ? OPT_Wreal_conversion
> : OPT_Wconversion;
>
> Also why did you put the warn_type code inside the default?
>
> David
>
>
> On Mon, Jun 24, 2013 at 10:03 PM, Sharad Singhai wrote:
>> On Mon, Jun 24, 2013 at 9:14 PM, Xinliang David Li
&
I reverted the earlier broken patch. I am including an updated patch
which warns only for real conversion, not for integral conversions. I
also updated the test case to include an integral conversion (int to
char) which doesn't emit the warning with the -Wreal-conversion flag.
Bootstrapped and tes
On Tue, Aug 6, 2013 at 8:57 AM, Xinliang David Li wrote:
> On Tue, Aug 6, 2013 at 5:37 AM, Martin Jambor wrote:
>> Hi,
>>
>> On Mon, Aug 05, 2013 at 10:37:00PM -0700, Teresa Johnson wrote:
>>> This patch ports messages to the new dump framework,
>>
>> It would be great this new framework was docu
On Tue, Aug 6, 2013 at 10:10 AM, Martin Jambor wrote:
> On Tue, Aug 06, 2013 at 09:22:02AM -0700, Sharad Singhai wrote:
>> On Tue, Aug 6, 2013 at 8:57 AM, Xinliang David Li wrote:
>> > On Tue, Aug 6, 2013 at 5:37 AM, Martin Jambor wrote:
>> >> Hi,
>> >>
fixes.
Also I would appreciate the exact command which produces these warnings.
Thanks,
Sharad
2014-02-05 Sharad Singhai
* doc/optinfo.texi: Fix order of nodes.
Index: doc/optinfo.texi
===
--- doc/optinfo.texi (revision 207525)
++
Committed as r207767.
Indeed, I had an older version of makeinfo. Once I updated to the
latest version 5.2, I saw the warnings. Those are fixed by this patch.
Thanks,
Sharad
> On Tue, Feb 11, 2014 at 11:42 PM, Thomas Schwinge
> wrote:
>>
>> Hi!
>>
>> On Wed, 5 F
Hi,
As per discussion in http://gcc.gnu.org/ml/gcc/2012-12/msg00056.html,
the attached patch updates loop unroll passes to use new dump
infrastructure.
This patch filters relevant dump messages into the following
three categories
- optimized: an optimization was successfully applied
- missed: an
.
>>
>> 4) the existing dump (into the dump file) can be changed to use the
>> same dump format above
>> 5) For loop unroll/peeling, the dumping code can be refactorized using
>> one report function -- see the code in google branch
>>
>> 6) do not for
This patch fixes an ICE in vectorization dump when section anchors are present.
Bootstrapped/tested on x86_64 and PPC 64 and found no new failures. OK
for trunk?
Thanks,
Sharad
2013-01-18 Sharad Singhai
PR tree-optimization/55995
* dumpfile.c (dump_loc): Print location only if available
On Wed, Oct 5, 2011 at 9:58 AM, Mike Stump wrote:
>
> On Oct 5, 2011, at 12:47 AM, Sharad Singhai wrote:
> > This patch adds an intermediate coverage format (enabled via 'gcov
> > -i'). This is a compact format as it does not require source files.
>
> I don'
Since the updated patch already uses unmangled function names, is it
good to commit then?
Sharad
On Wed, Oct 19, 2011 at 1:48 AM, Jan Hubicka wrote:
>> On Oct 18, 2011, at 4:19 PM, Sharad Singhai wrote:
>> > Okay, I liked the idea of self-descriptive tags. I have updated the
&
Sorry, I misunderstood your comment. I see that you are asking for
unmangled function names whereas the current patch supports only
mangled names. I can print unmangled names under another option. Would
that work?
Thanks,
Sharad
On Wed, Oct 19, 2011 at 12:06 PM, Sharad Singhai wrote:
> Si
Sorry about the delay. I have updated the patch to output demangled
names under a new option (-m) and added a test case. Okay for trunk?
Sharad
2011-11-06 Sharad Singhai
* doc/gcov.texi: Document gcov intermediate format.
* gcov.c (print_usage): Handle new option
Honza,
Sorry, I forgot about this. Could you please put this on your TODO list?
David,
While a proper fix is pending for the trunk, we need this interim fix
internally. Okay for google/main?
Thanks,
Sharad
On Sun, Oct 2, 2011 at 3:08 AM, Jan Hubicka wrote:
>>
>> I believe Richi opent PR back wh
Ping.
Thanks,
Sharad
Sharad
On Wed, Sep 5, 2012 at 10:34 AM, Sharad Singhai wrote:
> Ping.
>
> Thanks,
> Sharad
>
> Sharad
>
>
>
>
> On Fri, Aug 24, 2012 at 1:06 AM, Sharad Singhai wrote:
>>
>> Sorry about the delay. Please see comments inline.
, 2012 at 4:08 AM, Richard Guenther
wrote:
> On Wed, Sep 12, 2012 at 6:46 PM, Xinliang David Li wrote:
>> On Wed, Sep 12, 2012 at 3:30 AM, Richard Guenther
>> wrote:
>>> On Wed, Sep 12, 2012 at 10:12 AM, Sharad Singhai wrote:
>>>> Thanks for your comm
> Is -fopt-info-rtl-all also accepted?
Currently it is accepted. However, based on the recent comments, I am
going to remove the pass name from the flags.
>
> It would be useful to have a good default for -fopt-info so that users
> can get high level info about optimizations without having to spe
On Sep 18, 2012 8:43 AM, "Xinliang David Li" wrote:
>
> On Tue, Sep 18, 2012 at 1:48 AM, Sharad Singhai wrote:
> > In response to the recent comments, I have updated the patch to do the
> > following:
> >
> > - Remove pass handling from -fopt-info
> &g
Ping.
Thanks for the review. A couple of comments inline:
> Some minor issues:
>
> * c/c-decl.c (c_write_global_declarations): Use different method to
> determine if the dump has ben initialized.
> * cp/decl2.c (cp_write_global_declarations): Ditto.
> * testsuite/gcc.targ
Thanks for your comments. Responses inline.
On Wed, Jun 13, 2012 at 4:48 AM, Richard Guenther
wrote:
> On Fri, Jun 8, 2012 at 7:16 AM, Sharad Singhai wrote:
>> Okay, I have updated the attached patch so that the output from
>> -ftree-vectorizer-verbose is considered diagnostic
On Wed, Jun 13, 2012 at 4:48 AM, Richard Guenther
wrote:
> On Fri, Jun 8, 2012 at 7:16 AM, Sharad Singhai wrote:
>> Okay, I have updated the attached patch so that the output from
>> -ftree-vectorizer-verbose is considered diagnostic information and is
>> always
>
implemented in
form of -fdump-xxx-stderr.
Bootstrapped and tested on x86_64 with one added testcase. Okay for
trunk?
Thanks,
Sharad
2012-05-07 Sharad Singhai
* doc/invoke.texi: Add documentation for new option.
* tree-dump.c (dump_begin): Handle stderr appropriately.
(dump_end
That is certainly a possibility. The original motivation was to
implement -fopt-info correctly. If there are other use cases, then I
can enhance the patch.
Thanks,
Sharad
On Mon, May 7, 2012 at 3:02 PM, Gabriel Dos Reis
wrote:
> On Mon, May 7, 2012 at 4:58 PM, Sharad Singhai wrote:
>>
Sharad Singhai
* doc/invoke.texi: Add documentation for new option.
* tree-dump.c (dump_stream_p): New function.
(dump_files): Update for new field.
(dump_switch_p_1): Handle user provided filenames.
(dump_begin): Likewise.
(get_dump_file_name
dump goes to ira.dump.
Thanks,
Sharad
2012-05-09 Sharad Singhai
* doc/invoke.texi: Add documentation for the new option.
* tree-dump.c (dump_get_standard_stream): New function.
(dump_files): Update for new field.
(dump_switch_p_1): Handle dump filenames
lower
precedence. Also this works as expected,
gcc -O2 -fdump-tree-pre=pre.txt -fdump-tree-all=stderr ...
It outputs PRE dump to pre.txt while the remaining tree dumps are
output on to stderr. Does it look okay?
Thanks,
Sharad
2012-05-09 Sharad Singhai
* doc
Ping.
Thanks,
Sharad
On Thu, Jun 7, 2012 at 10:16 PM, Sharad Singhai wrote:
> Okay, I have updated the attached patch so that the output from
> -ftree-vectorizer-verbose is considered diagnostic information and is
> always
> sent to stderr. Other functionality remains unchanged.
regression tests passed.
Okay for google/gcc-4_6?
2011-09-30 Sharad Singhai
* gcc.c (cc1_options): Added -fno-early-inlining for coverage.
Index: gcc.c
===
--- gcc.c (revision 179402)
+++ gcc.c (working copy
FNDA:1,main
DA:4,2
BA:8,2
DA:7,1
I have bootstrapped and tested this patch on x86_64-linux. No new test
failures were observed.
Okay for trunk?
Thanks,
Sharad
2011-10-04 Sharad Singhai
* doc/gcov.texi: Document gcov intermediate format.
* gcov.c (print_usage
This patch improves locus information during the if-conversion. Okay for
google/main?
Thanks,
Sharad
2011-06-01 Sharad Singhai
Google Ref 39994
* ifcvt.c (noce_try_cmove_arith): Use the locus information
from the if-statment rather than the then path.
Index: ifcvt.c
This patch adds an intermediate gcov text format which does not require
source code. This format can be used by lcov or other tools.
I have bootstrapped it on x86 and all tests pass. Okay for main?
Thanks,
Sharad
2011-06-13 Sharad Singhai
Google Ref 3
* doc/gcov.texi
This patch adds new parameters to control peeling when profile
feedback information is available.
For google/main.
Tested:
bootstrapped on x86_64.
2011-04-27 Sharad Singhai
* gcc/params.def: Add new parameters to control peeling.
* gcc/tree-ssa-loop-ivcanon.c
Hi Diego,
Thanks for the quick feedback. Here is a an updated version of the patch.
2011-04-27 Sharad Singhai
ChangeLog.google-main
* params.def: Add new parameters to control peeling.
* tree-ssa-loop-ivcanon.c (try_unroll_loop_completely): Use
different
This patch disables -ftracer for profile use. Okay for google/main?
Thanks,
Sharad
2011-04-28 Sharad Singhai
Google Ref 40087
* opts.c (common_handle_option): Disable -ftracer for profile use.
* doc/invoke.texi: Update doc that -ftracer is no longer enabled for
FDO
-28 Sharad Singhai
gcc/ChangeLog.google-main
* params.def: Add new parameters to control peeling.
* tree-ssa-loop-ivcanon.c (try_unroll_loop_completely): Use
different peeling parameters when profile feedback is available.
* loop-unroll.c
71 matches
Mail list logo
