[PATCH v3 04/12] OpenMP: C front end support for metadirectives

2024-07-20 Thread Sandra Loosemore
/testsuite/ChangeLog * gcc.dg/gomp/metadirective-1.c: New. Co-Authored-By: Kwok Cheung Yeung Co-Authored-By: Sandra Loosemore --- gcc/c-family/c-common.h | 4 +- gcc/c-family/c-gimplify.cc | 27 + gcc/c-family/c-omp.cc | 60

[PATCH v3 12/12] OpenMP: Update documentation of metadirective implementation status.

2024-07-20 Thread Sandra Loosemore
libgomp/ChangeLog * libgomp.texi (OpenMP 5.0): Mark metadirective and declare variant as implemented. (OpenMP 5.1): Mark target_device as supported. Add changed interaction between declare target and OpenMP context and dynamic selector support. (OpenM

[PATCH v3 05/12] OpenMP: C++ front-end support for metadirectives

2024-07-20 Thread Sandra Loosemore
++/metadirective-template-2.C: New. * testsuite/libgomp.c++/metadirective-template-3.C: New. Co-Authored-By: Kwok Cheung Yeung Co-Authored-By: Sandra Loosemore --- gcc/cp/parser.cc | 524 +- gcc/cp/parser.h | 7 + gcc

[PATCH v3 06/12] OpenMP: common c/c++ testcases for metadirectives

2024-07-20 Thread Sandra Loosemore
. * testsuite/libgomp.c-c++-common/metadirective-target-device.c: New. Co-Authored-By: Kwok Cheung Yeung Co-Authored-By: Sandra Loosemore --- .../c-c++-common/gomp/attrs-metadirective-1.c | 41 .../c-c++-common/gomp/attrs-metadirective-2.c | 75 .../c-c++-common/gomp/attrs

[PATCH v3 10/12] OpenMP: Remove dead code from declare variant reimplementation

2024-07-20 Thread Sandra Loosemore
After reimplementing late resolution of "declare variant" to use the same mechanisms as metadirective, the declare_variant_alt and calls_declare_variant_alt flags on struct cgraph_node are no longer used by anything. For the purposes of marking functions that need late resolution, the has_metadire

[PATCH v3 09/12] OpenMP: Extend dynamic selector support to declare variant

2024-07-20 Thread Sandra Loosemore
This patch extends the mechanisms previously added to support dynamic selectors in metavariant constructs to also apply to "declare variant". The front-end mechanisms used to handle "declare variant" via attributes attached to the function decls remain the same, but the gimplifier now uses the sam

[PATCH v3 11/12] OpenMP: Update "declare target"/OpenMP context interaction

2024-07-20 Thread Sandra Loosemore
The code and test case previously implemented the OpenMP 5.0 spec, which said in section 2.3.1: "For functions within a declare target block, the target trait is added to the beginning of the set..." In OpenMP 5.1, this was changed to "For device routines, the target trait is added to the beginni

[PATCH v3 07/12] OpenMP: Fortran front-end support for metadirectives.

2024-07-20 Thread Sandra Loosemore
irective-5.f90: New. * testsuite/libgomp.fortran/metadirective-6.f90: New. Co-Authored-By: Kwok Cheung Yeung Co-Authored-By: Sandra Loosemore Co-Authored-By: Tobias Burnus Co-Authored-By: Paul-Antoine Arras --- gcc/fortran/decl.cc | 29 + gcc/fortran/dump-parse-tre

Re: [PATCH v3 01/12] OpenMP: metadirective tree data structures and front-end interfaces

2024-07-25 Thread Sandra Loosemore
xist. Can you eventually take care of the last two items? Yes. (For the last item: e.g. 'target_device' for declare_variant, for which 'sorry' already existed.) * * * I might have asked the following question before – and you might have answered it already: Sandra Loo

Re: [Patch] libgomp.texi: Update 'Device Information Routines' section

2024-07-29 Thread Sandra Loosemore
On 7/29/24 06:12, Tobias Burnus wrote: I recently stumbled over omp_get_default_device returning -1 (= omp_initial_device) vs. returning omp_get_num_devices(). Thus, it makes sense to document this properly. I also updated some wording and made a tiny step to documenting the missing functions

[committed] Add nios2*-*-* to the list of obsolete targets

2024-04-18 Thread Sandra Loosemore
I've committed the attach patch, per https://gcc.gnu.org/pipermail/gcc/2024-April/243749.html -SandraFrom 71ba5a721749174815dec712d113f3afb251deda Mon Sep 17 00:00:00 2001 From: Sandra Loosemore Date: Mon, 8 Apr 2024 14:36:08 + Subject: [committed] Add nios2*-*-* to the list of obs

[committed, wwwdocs] gcc-14/changes.html: nios2 target is obsolete

2024-04-18 Thread Sandra Loosemore
I've committed the attached patch, per https://gcc.gnu.org/pipermail/gcc/2024-April/243749.html -SandraFrom a6afbd07ee3d669dc6ac396d68a99926a30818f9 Mon Sep 17 00:00:00 2001 From: Sandra Loosemore Date: Mon, 15 Apr 2024 17:17:35 + Subject: [committed, wwwdocs] gcc-14/changes.html:

[PATCH, obvious] Fix for ICE in tree-nested.cc

2024-05-03 Thread Sandra Loosemore
E_OMP_TARGET in the same way. I think this patch is a candidate for backporting to the GCC 14 branch once it is unfrozen after the release, too. -SandraFrom 001d166819525dcef43b980298c2f85af77cd8ad Mon Sep 17 00:00:00 2001 From: Sandra Loosemore Date: Mon, 22 Apr 2024 18:24:25 + Subj

[PATCH 01/12] OpenMP: metadirective tree data structures and front-end interfaces

2024-05-04 Thread Sandra Loosemore
re_variant): Update calls to omp_check_context_selector and omp_context_selector_matches. * types.def (BT_FN_BOOL_INT_CONST_PTR_CONST_PTR_CONST_PTR): New. Co-Authored-By: Kwok Cheung Yeung Co-Authored-By: Sandra Loosemore --- gcc/Makefile.in | 2 +- gcc/builtin

[PATCH 00/12] OpenMP: Metadirective support + "declare variant" improvements

2024-05-04 Thread Sandra Loosemore
think both of those issues could be addressed with follow-up patches. This is already a large and complicated patch set, and I hope that by submitting it for review early in stage 1 it will be possible to get at least some parts of it committed in a timely manner and reduce the burden of maintainin

[PATCH 02/12] OpenMP: middle-end support for metadirectives

2024-05-04 Thread Sandra Loosemore
. (tree_function_versioning): Likewise. * tree-ssa-operands.cc: Include omp-general.h. (operands_scanner::parse_ssa_operands): Handle GIMPLE_OMP_METADIRECTIVE. Co-Authored-By: Kwok Cheung Yeung Co-Authored-By: Sandra Loosemore Co-Authored-By: Marcel Vollweiler --- gcc

[PATCH 03/12] libgomp: runtime support for target_device selector

2024-05-04 Thread Sandra Loosemore
plugin function. Co-Authored-By: Kwok Cheung Yeung Co-Authored-By: Sandra Loosemore --- include/cuda/cuda.h | 2 + libgomp/Makefile.am | 2 +- libgomp/Makefile.in | 5 +- libgomp/config/gcn/selector.c | 102 +++ libgomp/config

[PATCH 12/12] OpenMP: Update documentation of metadirective implementation status.

2024-05-04 Thread Sandra Loosemore
libgomp/ChangeLog * libgomp.texi (OpenMP 5.0): Mark metadirective and declare variant as implemented. (OpenMP 5.1): Mark target_device as supported. Add changed interaction between declare target and OpenMP context and dynamic selector support. (OpenM

[PATCH 04/12] OpenMP: C front end support for metadirectives

2024-05-04 Thread Sandra Loosemore
y: Kwok Cheung Yeung Co-Authored-By: Sandra Loosemore --- gcc/c-family/c-common.h | 4 +- gcc/c-family/c-gimplify.cc | 27 ++ gcc/c-family/c-omp.cc | 60 ++- gcc/c-family/c-pragma.cc| 1 + gcc

[PATCH 08/12] OpenMP: Reject other properties with kind(any)

2024-05-04 Thread Sandra Loosemore
The OpenMP spec says: "If trait-property any is specified in the kind trait-selector of the device selector set or the target_device selector sets, no other trait-property may be specified in the same selector set." GCC was not previously enforcing this restriction and several testcases included

[PATCH 06/12] OpenMP: common c/c++ testcases for metadirectives

2024-05-04 Thread Sandra Loosemore
. * testsuite/libgomp.c-c++-common/metadirective-4.c: New. * testsuite/libgomp.c-c++-common/metadirective-5.c: New. Co-Authored-By: Kwok Cheung Yeung Co-Authored-By: Sandra Loosemore --- .../c-c++-common/gomp/metadirective-1.c | 52 + .../c-c++-common/gomp/metadirective-2.c

[PATCH 05/12] OpenMP: C++ front-end support for metadirectives

2024-05-04 Thread Sandra Loosemore
-metadirective-8.C: New. libgomp/ChangeLog * testsuite/libgomp.c++/metadirective-template-1.C: New. * testsuite/libgomp.c++/metadirective-template-2.C: New. * testsuite/libgomp.c++/metadirective-template-3.C: New. Co-Authored-By: Kwok Cheung Yeung Co-Authored-By: Sandra

[PATCH 10/12] OpenMP: Remove dead code from declare variant reimplementation

2024-05-04 Thread Sandra Loosemore
After reimplementing late resolution of "declare variant" to use the same mechanisms as metadirective, the declare_variant_alt and calls_declare_variant_alt flags on struct cgraph_node are no longer used by anything. For the purposes of marking functions that need late resolution, the has_metadire

[PATCH 11/12] OpenMP: Update "declare target"/OpenMP context interaction

2024-05-04 Thread Sandra Loosemore
The code and test case previously implemented the OpenMP 5.0 spec, which said in section 2.3.1: "For functions within a declare target block, the target trait is added to the beginning of the set..." In OpenMP 5.1, this was changed to "For device routines, the target trait is added to the beginni

[PATCH 07/12] OpenMP: Fortran front-end support for metadirectives.

2024-05-04 Thread Sandra Loosemore
irective-5.f90: New. * testsuite/libgomp.fortran/metadirective-6.f90: New. Co-Authored-By: Kwok Cheung Yeung Co-Authored-By: Sandra Loosemore Co-Authored-By: Tobias Burnus Co-Authored-By: Paul-Antoine Arras --- gcc/fortran/decl.cc | 29 + gcc/fortran/dump-parse-tre

[PATCH 09/12] OpenMP: Extend dynamic selector support to declare variant

2024-05-04 Thread Sandra Loosemore
This patch extends the mechanisms previously added to support dynamic selectors in metavariant constructs to also apply to "declare variant". The front-end mechanisms used to handle "declare variant" via attributes attached to the function decls remain the same, but the gimplifier now uses the sam

Re: [PATCH v3 04/12] OpenMP: C front end support for metadirectives

2024-08-31 Thread Sandra Loosemore
On 8/16/24 04:30, Jakub Jelinek wrote: On Sat, Jul 20, 2024 at 02:42:23PM -0600, Sandra Loosemore wrote: --- a/gcc/c/c-parser.cc +++ b/gcc/c/c-parser.cc @@ -263,9 +263,24 @@ struct GTY(()) c_parser { otherwise NULL. */ vec *in_omp_attribute_pragma; + /* When

Re: [PATCH v3 08/12] OpenMP: Reject other properties with kind(any)

2024-09-08 Thread Sandra Loosemore
ched; I'll push it in the next day or two if there is no further objection. -SandraFrom 23a82bea26805f2a430354d56b444d5bb7eaed3f Mon Sep 17 00:00:00 2001 From: Sandra Loosemore Date: Fri, 6 Sep 2024 20:58:13 + Subject: [PATCH] OpenMP: Reject other properties with kind(any) TR13 (pre-6.0

Re: [PATCH v3 08/12] OpenMP: Reject other properties with kind(any)

2024-09-09 Thread Sandra Loosemore
On 9/9/24 05:01, Jakub Jelinek wrote: I think also testing the device={kind(any,any)} and device={kind("any",any)} and device={kind(any,"any"))} would be useful. Hmmm, it looks like GCC does not presently check for the restriction "Each trait-property may only be specified once in a trait sel

Re: [ping**4] Re: [patch 0/4] reimplement -fstrict-volatile-bitfields, v3

2013-08-26 Thread Sandra Loosemore
On 08/26/2013 01:16 AM, Bernd Edlinger wrote: PING! This issue is really important. It does not only affect bitfields but all kinds of packed structures. Starting from gcc 4.6.0 there is not a single released version that handles the packed structures correctly. So could some one please approv

[ping**n] reimplement -fstrict-volatile-bitfields, v3

2013-09-02 Thread Sandra Loosemore
version of Bernd's followup patch is. On 07/09/2013 10:23 AM, Sandra Loosemore wrote: On 06/30/2013 09:24 PM, Sandra Loosemore wrote: Here is my third attempt at cleaning up -fstrict-volatile-bitfields. Part 1 removes the warnings and packedp flag. It is the same as in the last version, and h

[ping**(n+1)] reimplement -fstrict-volatile-bitfields, v3

2013-09-11 Thread Sandra Loosemore
Ping? On 09/02/2013 12:56 PM, Sandra Loosemore wrote: On 09/02/2013 03:10 AM, Richard Biener wrote: Can someone, in a new thread, ping the patches that are still in flight? ISTR having approved bits of some patches before my leave. Here's the current state of the patch set I put tog

Re: [PATCH] Portable Volatility Warning

2013-09-24 Thread Sandra Loosemore
I have some nit-picky documentation suggestions about this patch http://gcc.gnu.org/ml/gcc-patches/2013-09/msg00100.html + warning_at (input_location, OPT_Wportable_volatility, + "the code to accesses this volatile member is dependent on" + " whether -fstrict-volati

Re: [PATCH] Portable Volatility Warning

2013-09-25 Thread Sandra Loosemore
On 09/25/2013 07:23 AM, Bernd Edlinger wrote: Richard: I do not know, is this a political issue, that is blocking the whole of Sandra's patch? Actually we (softing.com) do not really care what happens to the default setting of -fstrict-volatile-bitfields. Maybe you could look at reviewing Sandr

[PATCH] reimplement -fstrict-volatile-bitfields v4, part 0/2

2013-09-27 Thread Sandra Loosemore
Here is the latest version of my -fstrict-volatile-bitfields patches. I have gone ahead and committed part 1 of the previous version of this patch series, which was approved back in mid-June. That part just removes the warning about conflicts with packed structs (which everybody seemed to agr

[PATCH] reimplement -fstrict-volatile-bitfields v4, part 1/2

2013-09-27 Thread Sandra Loosemore
posted in June and re-pinged many times since then), but for this version I have cleaned up the test cases to remove dependencies on header files, as Bernd requested. -Sandra 2013-09-28 Sandra Loosemore PR middle-end/23623 PR middle-end/48784 PR middle-end/56341 PR middle-end/56997 gcc

[PATCH] reimplement -fstrict-volatile-bitfields v4, part 2/2

2013-09-27 Thread Sandra Loosemore
is was the last version posted: http://gcc.gnu.org/ml/gcc-patches/2013-09/msg00100.html -Sandra 2013-09-28 Sandra Loosemore gcc/ * config/aarch64/aarch64.c (aarch64_override_options): Don't override flag_strict_volatile_bitfields. * config/arm/arm.c (arm_option_override): Likewise.

Re: [PATCH] reimplement -fstrict-volatile-bitfields v4, part 2/2

2013-10-16 Thread Sandra Loosemore
On 10/16/2013 05:46 PM, DJ Delorie wrote: As it looks like, the -fstrict-volatile-bitfields are already totally broken, I tested your example on rl78-elf, with and without -fstrict-volatile-bitfields, and it generates correct code with it and incorrect code without it. Same for m32c-elf. Sa

Re: [PATCH] reimplement -fstrict-volatile-bitfields v4, part 1/2

2013-10-18 Thread Sandra Loosemore
On 10/18/2013 04:50 AM, Richard Biener wrote: On Sat, Sep 28, 2013 at 4:19 AM, Sandra Loosemore wrote: This patch fixes various -fstrict-volatile-bitfields wrong-code bugs, including instances where bitfield values were being quietly truncated as well as bugs relating to using the wrong width

Re: [PATCH] reimplement -fstrict-volatile-bitfields v4, part 1/2

2013-10-20 Thread Sandra Loosemore
On 10/18/2013 10:38 AM, Richard Biener wrote: Sandra Loosemore wrote: On 10/18/2013 04:50 AM, Richard Biener wrote: On Sat, Sep 28, 2013 at 4:19 AM, Sandra Loosemore wrote: This patch fixes various -fstrict-volatile-bitfields wrong-code bugs, including instances where bitfield values were

Re: [PATCH] reimplement -fstrict-volatile-bitfields v4, part 1/2

2013-10-28 Thread Sandra Loosemore
On 10/28/2013 03:20 AM, Bernd Edlinger wrote: On Sun, 20 Oct 2013 20:23:49, Sandra Loosemore wrote: I tried a backport to GCC 4.8 and tested on arm-none-eabi. On the new pr56997-1.c testcase, it got stuck in infinite recursion between store_split_bit_field/store_fixed_bit_field and/or

Re: [PATCH] reimplement -fstrict-volatile-bitfields v4, part 1/2

2013-10-29 Thread Sandra Loosemore
On 10/29/2013 02:51 AM, Bernd Edlinger wrote: On Mon, 28 Oct 2013 21:29:24, Sandra Loosemore wrote: I again tried backporting the patch series along with your fix to GCC 4.8 and tested on arm-none-eabi. I found that it was still getting stuck in infinite recursion unless the test from this

Re: [PATCH] reimplement -fstrict-volatile-bitfields v4, part 1/2

2013-10-30 Thread Sandra Loosemore
On 10/29/2013 02:51 AM, Bernd Edlinger wrote: On Mon, 28 Oct 2013 21:29:24, Sandra Loosemore wrote: On 10/28/2013 03:20 AM, Bernd Edlinger wrote: I have attached an update to your patch, that should a) fix the recursion problem. b) restrict the -fstrict-volatile-bitfields to not violate the C

Re: [doc, dwarf] Update bit-rotten DWARF option documentation

2016-01-20 Thread Sandra Loosemore
On 01/20/2016 06:52 AM, Jason Merrill wrote: On 01/19/2016 11:31 PM, Sandra Loosemore wrote: -@option{-gdwarf-2} does not accept a concatenated debug level, because -GCC used to support an option @option{-gdwarf} that meant to generate -debug information in version 1 of the DWARF format (which

Re: [patch] Document restriction of scalar_storage_order

2016-01-21 Thread Sandra Loosemore
On 01/21/2016 09:34 AM, Eric Botcazou wrote: Tested on x86_64-suse-linux, OK for the mainline? 2016-01-21 Eric Botcazou * doc/extend.texi (scalar_storage_order type attribute): Document restriction on type punning and aliasing. This patch is OK. I wish somebody could fix

Re: Patch RFA: Add option -fcollectible-pointers, use it in ivopts

2016-01-23 Thread Sandra Loosemore
On 01/22/2016 12:03 PM, Ian Lance Taylor wrote: Index: common.opt === --- common.opt (revision 232580) +++ common.opt (working copy) @@ -1380,6 +1380,10 @@ Enable hoisting adjacent loads to encourage generating conditional move i

Re: new port: vn8

2016-01-27 Thread Sandra Loosemore
Where is the patch under discussion here? I can't find it in the archives. -Sandra

Re: new port: vn8

2016-01-27 Thread Sandra Loosemore
On 01/27/2016 08:47 PM, Nguyễn Sinh Ngọc wrote: Where is the patch under discussion here? I can't find it in the archives. This is the source code of VN8 target: https://drive.google.com/file/d/0B169XTHeyQCfb2ZVak5VRm4tcHc/view?usp=sharing Thanks. I skimmed it over quickly to see if the doc

Re: [PING] Add new mexecute-only arm option.

2016-02-02 Thread Sandra Loosemore
On 02/02/2016 02:06 AM, mickael guene wrote: Hi All, Ping for following thread : https://gcc.gnu.org/ml/gcc-patches/2016-01/msg01968.html https://gcc.gnu.org/ml/gcc-patches/2016-01/msg01969.html https://gcc.gnu.org/ml/gcc-patches/2016-01/msg01970.html Two comments: (1) MIPS has had a simil

Re: [PATCH] c/69540 - update documentation on -l

2016-02-02 Thread Sandra Loosemore
On 01/30/2016 10:33 AM, Arkadiusz Drabczyk wrote: * doc/invoke.texi: update documentation WRT .so libraries in -l --- gcc/ChangeLog | 4 gcc/doc/invoke.texi | 8 +--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 1d60690..0a6

Re: [PATCH] [documentation] Fix documentation of --param

2016-02-04 Thread Sandra Loosemore
On 02/04/2016 07:42 AM, Jeremy Bennett wrote: The attached patch corrects some errors in documentation of the --param option to gcc. Mostly they are corrections to the names of options, but two parameters are documented which do not exist in trunk. gcc/ChangeLog: * doc/invoke.texi (Opt

[doc, committed] fix PR 69722

2016-02-08 Thread Sandra Loosemore
I've checked in this patch to fix a texinfo warning about a mismatch between a menu and corresponding sectioning commands, introduced in r225122. I did a little bit of copy-editing of the text added in that revision while I was in there. -Sandra 2016-02-08 Sandra Loosemore PR

Re: AW: Wonly-top-basic-asm

2016-02-11 Thread Sandra Loosemore
On 02/11/2016 08:40 AM, Bernd Schmidt wrote: But again, if someone feels the docs patch as posted is preferrable, go ahead and approve it (for stage1 I assume). TBH, I haven't looked at the documentation patch at all; I've been ignoring this issue because (a) I thought the technical details w

Re: AW: Wonly-top-basic-asm

2016-02-12 Thread Sandra Loosemore
On 02/12/2016 05:51 AM, Bernd Schmidt wrote: On 02/12/2016 08:05 AM, David Wohlferd wrote: Actually, it was my intent that this apply to v6. It's not like there is a significant change here. We're documenting long-time behavior, and adding a (disabled) warning. The doc patch (minus mentionin

Re: [PATCH] Fix driver handling of multiple -ftree-parallelize-loops= options (PR driver/69805)

2016-02-17 Thread Sandra Loosemore
On 02/17/2016 12:14 AM, Tom de Vries wrote: Here's the documentation entry for the gt spec function (I forgot to add it when introducing the function), using the new semantics. Copy-pasting from the resulting .info viewed in emacs for a human-readable version: ... 'gt' The 'gt'

Re: [patch] Clarify interaction of -Wnarrowing with -std

2016-02-19 Thread Sandra Loosemore
On 02/19/2016 12:01 PM, Jason Merrill wrote: On 02/19/2016 07:42 AM, Jonathan Wakely wrote: In PR69864 Manu suggests improving the docs to explain that -Wnarrowing sometimes produces errors not warnings. I think the right way to do that is clarify how it interacts with -std. Specifically that t

[patch, nios2] stack limit checking improvements

2015-07-14 Thread Sandra Loosemore
llows cases where multiple stack adjustments are emitted to do only a single stack limit check. While I was at it, I also added support for -fstack-limit-symbol as well as -fstack-limit-register. -Sandra 2015-07-14 Sandra Loosemore gcc/ * config/nios2/nios2.c (TEMP_REG_NUM): Move define

[nios2] [0/7] Support for Nios II R2

2015-07-14 Thread Sandra Loosemore
I will shortly begin committing a patch series to add GCC support for Nios II R2, a revision of the original Nios II instruction set. I previously wrote up some notes on the technical changes from R1 to R2 when I posted the corresponding binutils patches, here: https://sourceware.org/ml/binutils

[nios2] [1/7] Add -march=, -mbmx, -mcdx flags

2015-07-14 Thread Sandra Loosemore
ch is sufficient to compile programs correctly for R2 provided that they don't use load/store IO instructions (fixed in part 2) or nested functions (fixed in part 3). Committed as r225791. -Sandra 2015-07-14 Sandra Loosemore Cesar Philippidis Chung-Lin Tang gcc/ * config/n

[nios2] [2/7] Adjust for reduced offsets in R2 load/store IO insns

2015-07-14 Thread Sandra Loosemore
ict the size of the small data area to only 4K. Moreover, we'd expect IO peripherals to be mapped somewhere other than the normal small data section. So, we just tell GCC not to emit GP-relative addresses for anything that might be used in a R2 load/store IO instruction. Committed as r225792

[nios2] [3/7] Correct nested function trampolines for R2 encodings

2015-07-14 Thread Sandra Loosemore
This patch adds R2 encodings for the instructions used in nested function trampolines in libgcc. Committed as r225794. -Sandra 2015-07-14 Sandra Loosemore Cesar Philippidis Chung-Lin Tang libgcc/ * config/nios2/tramp.c (MOVHI, ORI, JMP): Conditionalize for __nios2_arch__

[nios2] [4/7] Support new R2 instructions

2015-07-14 Thread Sandra Loosemore
w_form_p. Then nios2_print_operand maps "%." onto ".n" or not depending on the length. Committed as 225796. -Sandra 2015-07-14 Sandra Loosemore Cesar Philippidis Chung-Lin Tang gcc/ * config/nios2/nios2.h (LABEL_ALIGN): Define. (REG_ALLOC_ORDER): Define

[nios2] [5/7] Support R2 CDX load/store multiple instructions

2015-07-14 Thread Sandra Loosemore
s were not promising. It might be worth revisiting that later, but presently the only things that generate them are the peephole optimizers and the prologue/epilogue changes coming along in part 6 of the patch series. Committed as r225798. -Sandra 2015-07-14 Sandra Loosemore Cesar Philippi

[nios2] [6/7] Update function prologues/epilogues for R2 CDX

2015-07-14 Thread Sandra Loosemore
return. Committed as r225799. -Sandra 2015-07-14 Sandra Loosemore Cesar Philippidis Chung-Lin Tang gcc/ * config/nios2/nios2-protos.h (nios2_expand_return): Declare. * config/nios2/nios2.c (struct GTY (()) machine_function): Add callee_save_reg_size and uses_anonymous_args fields

[nios2] [7/7] Add new intrinsics

2015-07-14 Thread Sandra Loosemore
. Committed as r225800. -Sandra 2015-07-14 Sandra Loosemore Cesar Philippidis Chung-Lin Tang gcc/ * config/nios2/constraints.md (U, v): New constraints. * config/nios2/predicates.md (rdprs_dcache_operand): New. (ldstex_memory_operand): New. * config/nios2/sync.md: New file

Re: [patch, nios2] stack limit checking improvements

2015-07-15 Thread Sandra Loosemore
On 07/14/2015 01:31 PM, Sandra Loosemore wrote: 2015-07-14 Sandra Loosemore gcc/ * config/nios2/nios2.c (TEMP_REG_NUM): Move define up in file. (nios2_emit_stack_limit_check): Add size parameter. Handle -fstack-limit-symbol as well as -fstack-limit-register

Re: [PATCH][doc][13/14] Document AArch64 target attributes and pragmas

2015-07-16 Thread Sandra Loosemore
On 07/16/2015 09:21 AM, Kyrill Tkachov wrote: Hi all, This patch adds the documentation for the AArch64 target attributes and pragmas. Ok for trunk? The content looks OK, but I have a bunch of nit-picky comments about grammar, typos, markup, etc +The following target-specific function

Re: [PATCH][doc][13/14] Document AArch64 target attributes and pragmas

2015-07-17 Thread Sandra Loosemore
On 07/17/2015 06:37 AM, Kyrill Tkachov wrote: Hi Sandra, On 17/07/15 04:21, Sandra Loosemore wrote: On 07/16/2015 09:21 AM, Kyrill Tkachov wrote: Hi all, This patch adds the documentation for the AArch64 target attributes and pragmas. Ok for trunk? The content looks OK, but I have a bunch

Re: [doc patch] Rename "Language Independent Options" @node in invoke.texi

2015-07-21 Thread Sandra Loosemore
On 07/21/2015 06:52 AM, Jonathan Wakely wrote: This texinfo @node seems misnamed: https://gcc.gnu.org/onlinedocs/gcc/Language-Independent-Options.html#Language-Independent-Options It should be something like "Diagnostic Message Formatting Options" not "Language Independent Options". The misnom

Re: [doc patch] Rename "Language Independent Options" @node in invoke.texi

2015-07-21 Thread Sandra Loosemore
On 07/21/2015 04:55 PM, Jonathan Wakely wrote: On 21/07/15 09:07 -0600, Sandra Loosemore wrote: On 07/21/2015 06:52 AM, Jonathan Wakely wrote: This texinfo @node seems misnamed: https://gcc.gnu.org/onlinedocs/gcc/Language-Independent-Options.html#Language-Independent-Options It should be

[doc, committed] clean up Asm Labels documentation

2015-09-28 Thread Sandra Loosemore
I've committed the attached patch on behalf of David Wohlferd, who doesn't have SVN write access. Jeff Law already approved the technical content off-list, and I'm not sure the final version of the patch was ever posted here previously. -Sandra 2015-09-28 David Wohlferd * doc/ex

Re: [PATCH] Clarify __atomic_compare_exchange_n docs

2015-09-29 Thread Sandra Loosemore
On 09/29/2015 06:00 AM, Jonathan Wakely wrote: Someone on IRC incorrectly parsed the docs at https://gcc.gnu.org/onlinedocs/gcc-5.2.0/gcc/_005f_005fatomic-Builtins.html#index-g_t_005f_005fatomic_005fcompare_005fexchange_005fn-3536 as: IF ( desired is written into *ptr AND the execu

Re: [PATCH] Clarify __atomic_compare_exchange_n docs

2015-10-01 Thread Sandra Loosemore
On 10/01/2015 05:28 AM, Andrew Haley wrote: On 09/29/2015 04:21 PM, Sandra Loosemore wrote: What is "weak compare_exchange", and what is "the strong variation", and how do they differ in terms of behavior? It's in C++11 29.6.5: Remark: The weak compare-and-exc

Re: [patch] Update template instantiation documentation

2015-10-03 Thread Sandra Loosemore
On 10/03/2015 06:47 AM, Jonathan Wakely wrote: https://gcc.gnu.org/onlinedocs/gcc/Template-Instantiation.html currently says that using -frepo "is your best option for application code written for the Borland model, as it just works." That was true at one point, but as can be seen from the menti

Re: [patch] Update template instantiation documentation

2015-10-05 Thread Sandra Loosemore
On 10/05/2015 10:40 AM, Jason Merrill wrote: Looks good to me, thanks. Jason Looks good to me, too. -Sandra

[committed, nios2] fix link error from gcc.dg/pr65658.c

2015-10-06 Thread Sandra Loosemore
ng to do -- it should be treating uninitialized common symbols similarly to weak definitions. I've checked in the attached patch to fix it. -Sandra 2015-10-06 Sandra Loosemore gcc/ * config/nios2/nios2.c (nios2_symbol_ref_in_small_data_p): For -mgpopt=local, also exclude unintiali

RFC: always default to -mno-unaligned-access for bare-metal ARM

2015-10-16 Thread Sandra Loosemore
Recently I tracked down a target crash problem in an ARM EABI configuration running on a Cortex-A9 board to an unaligned access fault. The startup code provided by the customer for this board doesn't enable the MMU, and unaligned access support requires the MMU to be enabled per http://infoc

Re: [PATCH v2 08/13] Add TARGET_ADDR_SPACE_ZERO_ADDRESS_VALID

2015-10-21 Thread Sandra Loosemore
On 10/20/2015 03:27 PM, Richard Henderson wrote: +@deftypefn {Target Hook} bool TARGET_ADDR_SPACE_ZERO_ADDRESS_VALID (addr_space_t @var{as}) +Define this to modify the default handling of address 0 for the +address space. Return true if 0 should be considered a valid address. +@end deftypefn +

Re: [PATCH v2 12/13] Document the x86 address spaces

2015-10-21 Thread Sandra Loosemore
On 10/20/2015 03:27 PM, Richard Henderson wrote: --- gcc/doc/extend.texi | 46 -- 1 file changed, 44 insertions(+), 2 deletions(-) diff --git a/gcc/doc/extend.texi b/gcc/doc/extend.texi index bdbf513..677a4d4 100644 --- a/gcc/doc/extend.texi +++ b/g

Re: [PATCH v2 08/13] Add TARGET_ADDR_SPACE_ZERO_ADDRESS_VALID

2015-10-23 Thread Sandra Loosemore
On 10/22/2015 01:58 AM, Richard Biener wrote: On Thu, Oct 22, 2015 at 5:12 AM, Sandra Loosemore wrote: On 10/20/2015 03:27 PM, Richard Henderson wrote: +@deftypefn {Target Hook} bool TARGET_ADDR_SPACE_ZERO_ADDRESS_VALID (addr_space_t @var{as}) +Define this to modify the default handling of

Re: [PATCH v2 12/13] Document the x86 address spaces

2015-10-23 Thread Sandra Loosemore
On 10/22/2015 02:25 PM, Richard Henderson wrote: I believe I've addressed all of your comments like so. This looks much better, except for this hunk: diff --git a/gcc/doc/extend.texi b/gcc/doc/extend.texi index e54fe67..5793868 100644 --- a/gcc/doc/extend.texi +++ b/gcc/doc/extend.texi @@ -12

Re: [Docs] Reword the documentation for -fdump-rtl-

2015-10-29 Thread Sandra Loosemore
On 10/29/2015 09:52 AM, James Greenhalgh wrote: diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi index 76fdc31..148f063 100644 --- a/gcc/doc/invoke.texi +++ b/gcc/doc/invoke.texi @@ -6665,17 +6665,19 @@ Says to make debugging dumps during compilation at times specified by @var{letters}.

Re: [Docs] Reword the documentation for -fdump-rtl-

2015-10-29 Thread Sandra Loosemore
On 10/29/2015 10:55 AM, James Greenhalgh wrote: diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi index 76fdc31..5549f17 100644 --- a/gcc/doc/invoke.texi +++ b/gcc/doc/invoke.texi @@ -6665,17 +6665,19 @@ Says to make debugging dumps during compilation at times specified by @var{letters}.

Re: [PATCH] clarify documentation of -Q --help=optimizers

2015-11-04 Thread Sandra Loosemore
On 11/04/2015 04:52 PM, Martin Sebor wrote: gcc/ChangeLog: 2015-11-04 Martin Sebor * opts.c (print_filtered_help): Indicate when an optimization option is disabled as a result of -O0. * doc/invoke.texi: Further clarify the effect of -O options on individual op

Re: RFC: Experimental use of Sphinx for GCC documentation

2015-11-09 Thread Sandra Loosemore
On 11/08/2015 06:55 AM, David Malcolm wrote: I've been experimenting with using Sphinx [1] for GCC's documentation. [snip] The primary advantages of .rst/sphinx over .texi/texinfo I see are in the generated HTML: * sane, stable URLs (so e.g. there is a reliable URL for the docs for, say, "-Wal

Re: RFC: Experimental use of Sphinx for GCC documentation

2015-11-10 Thread Sandra Loosemore
[resending, gcc-patches won't allow a screenshot attachment] On 11/10/2015 03:27 PM, David Malcolm wrote: Correct, readable and well-organized documentation are laudable goals... but I think that, to a first approximation, we're already there: I just feel that the content is hidden behind a poo

[patch, doc] fix PR65129, markup on __builtin_assume_aligned

2015-11-16 Thread Sandra Loosemore
I've checked in this trivial patch to fix a markup error on the return type for __builtin_assume_aligned. I scanned through all the builtin documentation but didn't spot any similar instances of missing braces. -Sandra 2015-11-16 Sandra Loosemore PR 65129 * doc/e

[patch, doc] PR 56036, misplaced @end table

2015-11-16 Thread Sandra Loosemore
I've checked in the patch suggested by Thomas in PR 56036 to fix a misplaced @end table in the discussion of -O options. -Sandra 2015-11-16 Thomas Preud'homme PR 56036 * doc/invoke.texi (Optimize Options): Move @end table to the right place. Index: gcc/doc/invoke.texi

[patch, doc] fix PR53587, missing documentation for -mms-bitfields

2015-11-17 Thread Sandra Loosemore
ry or index. I thought the primary documentation should be in options.texi with pointers to it from the variable and type attribute entries, rather than vice-versa, so I've checked in this patch to move things around and add more cross-references. -Sandra 2015-11-17 Sandra Loosemore

[patch, doc] PR 48568, missing docs for visibility attribute on variables

2015-11-17 Thread Sandra Loosemore
variable in the function attributes section. I also did confirm that the attribute does work on variables. -Sandra 2015-11-17 Sandra Loosemore PR 48568 * doc/extend.texi (Common Function Attributes) [visibility]: Add cross-references to matching variable and type attributes. (Common Vari

[nios2, committed] remove duplicates in || expression

2015-11-18 Thread Sandra Loosemore
I've checked in this patch to fix PR 68410. David, thanks for pointing out the think-o here. -Sandra 2015-11-18 Sandra Loosemore PR target/68410 * config/nios2/nios2.c (cdx_and_immed): Remove duplicate tests from || expression. Index: gcc/config/nios2/ni

[PATCH V2 2/4] Use C-style loop lowering instead of C++-style.

2020-08-13 Thread Sandra Loosemore
h (support for constexpr evaluation) has been solved in other ways meanwhile. 2020-08-12 Sandra Loosemore gcc/c-family/ * c-gimplify.c (genericize_c_loop): Rewrite to match c_finish_loop in c-typeck.c. --- gcc/c-family/c-gimpli

[PATCH V2 0/4] Unify C and C++ handling of loops and switches

2020-08-13 Thread Sandra Loosemore
give g++ a hint. Unfortunately I had no luck in trying to reduce this to a standalone test case, but I did observe that the failure went away when I compiled that file with debugging enabled. :-S I could file a PR to look into this further if the workaround is good enough for now. -Sandra Sandra Loosemore (

[PATCH V2 1/4] Move loop and switch tree data structures from cp/ to c-family/.

2020-08-13 Thread Sandra Loosemore
similar OMP constructs is also moved. 2020-08-12 Sandra Loosemore gcc/c-family/ * c-common.c (c_block_may_fallthrough): New, split from cxx_block_may_fallthrough in the cp front end. (c_common_init_ts): Move handling of loop and switch-related statements

[PATCH V2 3/4] Work around bootstrap failure in Fortran front end.

2020-08-13 Thread Sandra Loosemore
t;next = NULL; | ~^ Work around this by adding an assertion, which seems appropriate for documentation and good coding practices anyway. 2020-08-12 Sandra Loosemore gcc/fortran/ * interface.c (gfc_compare_actual_formal): Add assertion after main processing lo

[PATCH V2 4/4] Change C front end to emit structured loop and switch tree nodes.

2020-08-13 Thread Sandra Loosemore
2020-08-12 Sandra Loosemore gcc/c * c-decl.c (c_break_label, c_cont_label): Delete, and replace with... (in_statement): New. (start_function): Adjust for above change. (c_push_function_context, c_pop_function_context): Likewise. * c

[committed 3/3] [OG10] Annotate inner loops in "acc kernels loop" directives (Fortran).

2020-08-20 Thread Sandra Loosemore
loop" directive should still allow annotation of inner loops. This patch implements this behavior in Fortran. 2020-08-19 Sandra Loosemore gcc/fortran/ * openmp.c (annotate_do_loops_in_kernels): Handle EXEC_OACC_KERNELS_LOOP separately to permit annotation of inner

[committed 1/3] [OG10] Add a "combined" flag for "acc kernels loop" etc directives.

2020-08-20 Thread Sandra Loosemore
2020-08-19 Sandra Loosemore gcc/ * tree.h (OACC_LOOP_COMBINED): New. gcc/c/ * c-parser.c (c_parser_oacc_loop): Set OACC_LOOP_COMBINED. gcc/cp/ * parser.c (cp_parser_oacc_loop): Set OACC_LOOP_COMBINED. gcc/fortran/ * trans

[committed 2/3] [og10] Annotate inner loops in "acc kernels loop" directives (C/C++).

2020-08-20 Thread Sandra Loosemore
loop" directive should still allow annotation of inner loops. This patch implements this behavior for C and C++. 2020-08-19 Sandra Loosemore gcc/c-family/ * c-omp.c (annotate_loops_in_kernels_regions): Process inner loops in combined "acc kernels loop" dire

[committed 0/3] [OG10] openacc: Fix annotation of inner loops in combined "acc kernels loop" directives

2020-08-20 Thread Sandra Loosemore
e course they will be combined with the original annotation patches (which haven't been reviewed properly yet either) and any other bug fixes or tweaks to the behavior, and resubmitted for mainline. -Sandra Sandra Loosemore (3): Add a "combined" flag for "acc kernels lo

<    1   2   3   4   5   6   7   8   9   10   >