Re: [PATCH] Support g++ 4.8 as a host compiler.

2023-10-07 Thread Sam James
Jeff Law writes: > On 10/4/23 16:19, Roger Sayle wrote: >> The recent patch to remove poly_int_pod triggers a bug in g++ >> 4.8.5's >> C++ 11 support which mistakenly believes poly_uint16 has a non-trivial >> constructor. This in turn prohibits it from being used as a member in >> a union (rtx

Re: [PATCH] Do not prepend target triple to -fuse-ld=lld,mold.

2023-10-15 Thread Sam James
Tatsuyuki Ishi writes: > lld and mold are platform-agnostic and not prefixed with target triple. > Prepending the target triple makes it less likely to find the intended > linker executable. > > A potential breaking change is that we no longer try to search for > triple-prefixed lld/mold binari

Re: [PATCH] genemit: Split insn-emit.cc into ten files.

2023-10-16 Thread Sam James
Robin Dapp writes: > Hi, > > the attached v2 includes Tamar's suggestion of keeping the current > stdout behavior. When no output files are passed (via -O) the output > is written to stdout as before. > > Tamar also mentioned off-list that, similar to match.pd, it might make > sense to balance

Re: [PATCH] genemit: Split insn-emit.cc into ten files.

2023-10-16 Thread Sam James
Robin Dapp writes: > Hi, > > the attached v2 includes Tamar's suggestion of keeping the current > stdout behavior. When no output files are passed (via -O) the output > is written to stdout as before. > > Tamar also mentioned off-list that, similar to match.pd, it might make > sense to balance

Re: [PATCH v2] gcc: Introduce -fhardened

2023-10-19 Thread Sam James
Richard Biener writes: > On Wed, Oct 11, 2023 at 10:48 PM Marek Polacek wrote: >> >> On Tue, Sep 19, 2023 at 10:58:19AM -0400, Marek Polacek wrote: >> > On Mon, Sep 18, 2023 at 08:57:39AM +0200, Richard Biener wrote: >> > > On Fri, Sep 15, 2023 at 5:09 PM Marek Polacek via Gcc-patches >> > >

[PATCH htdocs] bugs: Mention -D_GLIBCXX_ASSERTIONS and -D_GLIBCXX_DEBUG

2023-10-26 Thread Sam James
built with it (as it breaks ABI). Signed-off-by: Sam James --- htdocs/bugs/index.html | 7 +++ 1 file changed, 7 insertions(+) diff --git a/htdocs/bugs/index.html b/htdocs/bugs/index.html index da3d4c0d..a5a38f42 100644 --- a/htdocs/bugs/index.html +++ b/htdocs/bugs/index.html @@ -56,6 +

Re: [PATCH htdocs] bugs: Mention -D_GLIBCXX_ASSERTIONS and -D_GLIBCXX_DEBUG

2023-10-26 Thread Sam James
Jonathan Wakely writes: > On Thursday, 26 October 2023, Sam James wrote: >> These options both enabled more checking within the C++ standard library >> and can expose errors in submitted code. >> >> -D_GLIBCXX_DEBUG is mentioned separately because while we want pe

[PATCH htdocs v2] bugs: Mention -D_GLIBCXX_ASSERTIONS and -D_GLIBCXX_DEBUG

2023-10-26 Thread Sam James
built with it (as it breaks ABI). Signed-off-by: Sam James --- v2: Improve phrasing for the types of checks and be less scornful about ABI changes. htdocs/bugs/index.html | 7 +++ 1 file changed, 7 insertions(+) diff --git a/htdocs/bugs/index.html b/htdocs/bugs/index.html index da3

[PATCH htdocs v3] bugs: Mention -D_GLIBCXX_ASSERTIONS and -D_GLIBCXX_DEBUG

2023-10-26 Thread Sam James
built with it (as it breaks ABI). Signed-off-by: Sam James --- v3: Link to debug mode docs. v2: Improve phrasing for the types of checks and be less scornful about ABI changes. htdocs/bugs/index.html | 8 1 file changed, 8 insertions(+) diff --git a/htdocs/bugs/index.html b/htdocs

Re: [PING][PATCH] Include safe-ctype.h after C++ standard headers, to avoid over-poisoning

2023-10-29 Thread Sam James
Dimitry Andric writes: > Ping. It would be nice to get this QoL fix in. > Yes please - we've been using this in Gentoo since around when it was first posted. No complaints. I cannot approve but it looks good to me. > -Dimitry > >> On 28 Sep 2023, at 18:37, Dimitry Andric wrote: >> >> Ref:

[PATCH 2/4] maintainer-scripts/gcc_release: create index between snapshots <-> commits

2023-11-02 Thread Sam James
reports. maintainer-scripts/ * gcc_release: Create known_snapshots.txt as an index between snapshots and commits. Signed-off-by: Sam James --- Note that there's a few different approaches we can take here. I've gone for the simpler one of having it still fetch from the r

[PATCH 1/4] contrib: add generate_snapshot_index.py

2023-11-02 Thread Sam James
oking up the information from bug reports. contrib/: * generate_snapshot_index.py: New file. Signed-off-by: Sam James --- contrib/generate_snapshot_index.py | 79 ++ 1 file changed, 79 insertions(+) create mode 100755 contrib/generate_snapshot_index.py diff --

[PATCH 3/4] maintainer-scripts/gcc_release: use HTTPS for links

2023-11-02 Thread Sam James
maintainer-scripts/ * gcc_release: Use HTTPS for links. Signed-off-by: Sam James --- maintainer-scripts/gcc_release | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/maintainer-scripts/gcc_release b/maintainer-scripts/gcc_release index 4cd1fa799660..cf6a5731c609

[PATCH 4/4] maintainer-scripts/gcc_release: cleanup whitespace

2023-11-02 Thread Sam James
maintainer-scripts/ * gcc_release: Cleanup whitespace. Signed-off-by: Sam James --- maintainer-scripts/gcc_release | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/maintainer-scripts/gcc_release b/maintainer-scripts/gcc_release index cf6a5731c609

[PATCH] doc: explicitly say 'lifetime' for DCE

2023-11-02 Thread Sam James
xi (Dead code elimination): Explicitly say 'lifetime' as this has become the standard term for what we're doing here. Signed-off-by: Sam James --- gcc/doc/passes.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/doc/passes.texi b/gcc/doc/passes.texi index

Re: [PATCH] doc: explicitly say 'lifetime' for DCE

2023-11-02 Thread Sam James
Richard Biener writes: > On Thu, Nov 2, 2023 at 10:03 AM Sam James wrote: >> >> Say 'memory lifetime' rather than 'memory life' as lifetime is the more >> standard term nowadays (indeed we have e.g. -fno-lifetime-dse). >> >> It&#x

Re: [PATCH] doc: explicitly say 'lifetime' for DCE

2023-11-02 Thread Sam James
Richard Biener writes: > On Thu, Nov 2, 2023 at 11:25 AM Sam James wrote: >> >> >> Richard Biener writes: >> >> > On Thu, Nov 2, 2023 at 10:03 AM Sam James wrote: >> >> >> >> Say 'memory lifetime' rather than 'memory

Re: [PATCH] libstdc++: avoid uninitialized read in basic_string constructor

2023-11-03 Thread Sam James
Jonathan Wakely writes: > On Thu, 2 Nov 2023 at 19:58, Ben Sherman > wrote: >> >> Tested on x86_64-pc-linux-gnu, please let me know if there's anything >> else needed. I haven't contributed before and don't have write access, so >> apologies if I've missed anything. > > This was https://gcc.g

Re: [PATCH][_Hashtable] Add missing destructor call

2023-11-06 Thread Sam James
François Dumont writes: > Noticed looking for other occasion to replace __try/__catch with RAII > helper. > >     libstdc++: [_Hashtable] Add missing node destructor call > >     libstdc++-v3/ChangeLog: > >     * include/bits/hashtable_policy.h >     (_Hashtable_alloc<>::_M_allo

Re: [PATCH] Include safe-ctype.h after C++ standard headers, to avoid over-poisoning

2024-03-06 Thread Sam James
FX Coudert writes: > I would like to patch this patch from September 2023: > https://gcc.gnu.org/pipermail/gcc-patches/2023-September/631611.html > > This bug is now hitting macOS in the latest version of Xcode (it was > originally seen on freebsd). > I confirm that the patch is restoring bootst

[PATCH] contrib: Improve dg-extract-results.sh's Python detection

2024-03-07 Thread Sam James
'python' on some systems (e.g. SLES 15) might be Python 2. Prefer ${EPYTHON} if defined (used by Gentoo's python-exec wrapping), then python3, then python. contrib/ChangeLog: * dg-extract-results.sh: Check for python3 before python. --- contrib/dg-extract-results.sh | 17 ++--- 1

Re: [PATCH] contrib: Improve dg-extract-results.sh's Python detection

2024-03-07 Thread Sam James
Jakub Jelinek writes: > On Thu, Mar 07, 2024 at 02:16:37PM +0000, Sam James wrote: >> 'python' on some systems (e.g. SLES 15) might be Python 2. Prefer ${EPYTHON} >> if defined (used by Gentoo's python-exec wrapping), then python3, then >> python. > &

[PATCH v2] contrib: Improve dg-extract-results.sh's Python detection

2024-03-07 Thread Sam James
'python' on some systems (e.g. SLES 15) might be Python 2. Prefer python3, then python, then python2 (as the script still tries to work there). contrib/ChangeLog: * dg-extract-results.sh: Check for python3 before python. Check for python2 last. --- v2: Add python2 and drop EPYTHON. contrib

Re: [PATCH] testsuite: Fix vfprintf-chk-1.c with -fhardened

2024-03-12 Thread Sam James
Sam James writes: > With _FORTIFY_SOURCE >= 2 (enabled by -fhardened), vfprintf-chk-1.c's > __vfprintf_chk ends up calling __vprintf_chk rather than vprintf. > > ``` > --- a/fortify.s > +++ b/no-fortify.s > @@ -8,27 +8,28 @@ > [...] > __vfprint

Re: [PATCH] Predefine __STRICT_ALIGN__ if STRICT_ALIGNMENT

2024-03-16 Thread Sam James
YunQiang Su writes: > Arm32 predefines __ARM_FEATURE_UNALIGNED if -mno-unaligned-access, > and RISC-V predefines __riscv_misaligned_avoid, while other ports > that support -mstrict-align/-mno-unaligned-access don't have such > macro, and these backend macros are only avaiable for c-family. > Note

Re: [PATCH 0/2] Condition coverage fixes

2024-04-07 Thread Sam James
Jørgen Kvalsvik writes: > Hi, > > I propose these fixes for the current issues with the condition > coverage. > > Rainer, I propose to simply delete the test with __sigsetjmp. I don't > think it actually detects anything reasonable any more, I kept it around > to prevent a regression. Since then

Re: [PATCH v3 06/11] c: Turn -Wimplicit-function-declaration into a permerror

2024-04-09 Thread Sam James
Sebastian Huber writes: > On 20.11.23 10:56, Florian Weimer wrote: >> In the future, it may make sense to avoid cascading errors from >> the implicit declaration, especially its assumed int return type. >> This change here only changes the kind of the diagnostic, not >> its wording or consequence

Re: [PATCH v3 06/11] c: Turn -Wimplicit-function-declaration into a permerror

2024-04-09 Thread Sam James
Sebastian Huber writes: > On 09.04.24 14:10, Sam James wrote: >> Sebastian Huber writes: >> >>> On 20.11.23 10:56, Florian Weimer wrote: >>>> In the future, it may make sense to avoid cascading errors from >>>> the implicit declaration, especial

Re: [PATCH 0/2] mmap: Avoid the sanitizer configure check failure

2024-04-09 Thread Sam James
"H.J. Lu" writes: > When -fsanitize=address,undefined is used to build, the mmap configure > check failed with I think Paul fixed this in autoconf commit 09b6e78d1592ce10fdc975025d699ee41444aa3f, so we should add a comment about that so we can clean this up in future. > > ==

Re: [PATCH]middle-end: check memory accesses in the destination block [PR113588].

2024-02-03 Thread Sam James
Toon Moene writes: > On 2/1/24 22:33, Tamar Christina wrote: > >> Bootstrapped Regtested on aarch64-none-linux-gnu and x86_64-pc-linux-gnu no >> issues. >> Also checked both with --enable-lto --with-build-config='bootstrap-O3 >> bootstrap-lto' --enable-multilib >> and --enable-lto --with-buil

Re: [PATCH] Notes on the warnings-as-errors change in GCC 14

2024-02-07 Thread Sam James
Florian Weimer writes: > --- > htdocs/gcc-14/porting_to.html | 465 > ++ > 1 file changed, 465 insertions(+) > Can't approve but LGTM. Thank you for being so thorough - it'll be helpful when showing upstreams. > diff --git a/htdocs/gcc-14/porting_to.ht

Re: [PATCH V1] Common infrastructure for load-store fusion for aarch64 and rs6000 target

2024-02-14 Thread Sam James
Ajit Agarwal writes: > Hello Richard: > > > On 14/02/24 4:03 pm, Richard Sandiford wrote: >> Hi, >> >> Thanks for working on this. >> >> You posted a version of this patch on Sunday too. If you need to repost >> to fix bugs or make other improvements, could you describe the changes >> that y

Re: [PATCH] Notes on the warnings-as-errors change in GCC 14

2024-02-15 Thread Sam James
Florian Weimer writes: > * Sam James: > >> It's fine if you leave this out, but consider mentioning the common >> pitfall of autoconf projects not including config.h consistently before >> all inclues. We could also mention AC_USE_SYSTEM_EXTENSIONS. > > I adde

Re: [PATCH] Turn on LRA on all targets

2024-02-15 Thread Sam James
Sam James writes: > [[PGP Signed Part:Undecided]] > > "Maciej W. Rozycki" writes: > >> On Sun, 23 Apr 2023, Segher Boessenkool wrote: >> >>> > There are extra ICEs in regression testing and code quality is poor; cf. >>> > <https

[PATCH] testsuite: Fix vfprintf-chk-1.c with -fhardened

2024-02-15 Thread Sam James
intf_chk + jmp vfprintf@PLT ``` 2024-02-15 Sam James gcc/testsuite/ChangeLog: * gcc.c-torture/execute/vfprintf-chk-1.c (__vfprintf_chk): Undefine _FORTIFY_SOURCE to call the real vfprintf. --- The test, AIUI, is trying to test GCC's own basic _chk bits rather th

Re: [PATCH wwwdocs] gcc-14: Some very common historic Autoconf probes that no longer work

2024-02-17 Thread Sam James
Florian Weimer writes: > --- > htdocs/gcc-14/porting_to.html | 43 > +++ > 1 file changed, 43 insertions(+) > > diff --git a/htdocs/gcc-14/porting_to.html b/htdocs/gcc-14/porting_to.html > index 123b5e9f..ab65c5e7 100644 > --- a/htdocs/gcc-14/porting_to.

Re: [PATCH wwwdocs] gcc-14: Add code examples for -Wreturn-mismatch

2024-02-17 Thread Sam James
Florian Weimer writes: > --- > htdocs/gcc-14/porting_to.html | 46 > --- > 1 file changed, 43 insertions(+), 3 deletions(-) > > diff --git a/htdocs/gcc-14/porting_to.html b/htdocs/gcc-14/porting_to.html > index bbbaa25a..123b5e9f 100644 > --- a/htdocs/gc

Re: [PATCH] Add ia64*-*-* to the list of obsolete targets

2024-02-23 Thread Sam James
Richard Biener writes: > The following deprecates ia64*-*-* for GCC 14. Since we plan to > force LRA for GCC 15 and the target only has slim chances of getting > updated this notifies people in advance. Given both Linux and > glibc have axed the target further development is also made difficu

Re: [PATCH v2] Do not emulate vectors containing floats.

2024-02-23 Thread Sam James
Juergen Christ writes: > The emulation via word mode tries to perform integer arithmetic on floating > point values instead of floating point arithmetic. This leads to > mis-compilations. Is the bug ref + test missing? > > Failure occured on s390x on these existing test cases: > gcc.dg/vect/

Re: [PATCH] libstdc++: hashtable: No need to update before begin node in _M_remove_bucket_begin

2024-01-16 Thread Sam James
Huanghui Nie writes: > Hi. Please CC the libstdc++ LM for libstdc++ patches, per https://gcc.gnu.org/onlinedocs/libstdc++/manual/appendix_contributing.html#list.patches. > [...]

Re: [PING][PATCH] Include safe-ctype.h after C++ standard headers, to avoid over-poisoning

2024-01-20 Thread Sam James
Sam James writes: > Dimitry Andric writes: > >> Ping. It would be nice to get this QoL fix in. >> > > Yes please - we've been using this in Gentoo since around when it was > first posted. No complaints. > > I cannot approve but it looks good to me. Ping

Re: [PATCH v1 2/4] C++: Support clang compatible [[musttail]]

2024-01-24 Thread Sam James
Andi Kleen writes: > This patch implements a clang compatible [[musttail]] attribute for > returns. This is PR83324. See also PR52067 and PR110899. > > musttail is useful as an alternative to computed goto for interpreters. > With computed goto the interpreter function usually ends up very bi

Re: [PING][PATCH] Include safe-ctype.h after C++ standard headers, to avoid over-poisoning

2024-01-30 Thread Sam James
Sam James writes: > Sam James writes: > >> Dimitry Andric writes: >> >>> Ping. It would be nice to get this QoL fix in. >>> >> >> Yes please - we've been using this in Gentoo since around when it was >> first posted. No complaint

Re: [PING][PATCH] Include safe-ctype.h after C++ standard headers, to avoid over-poisoning

2024-01-30 Thread Sam James
Sam James writes: > [[PGP Signed Part:Undecided]] > > Sam James writes: > >> Sam James writes: >> >>> Dimitry Andric writes: >>> >>>> Ping. It would be nice to get this QoL fix in. >>>> >>> >>> Yes pl

Re: About 31109 - gprofng not built and installed in a combined binutils+gcc build

2024-01-31 Thread Sam James
Richard Biener writes: > On Wed, Jan 31, 2024 at 4:46 AM Vladimir Mezentsev > wrote: >> >> Hi, >> >> I asked in https://sourceware.org/bugzilla/show_bug.cgi?id=31109 >> > I prepared a patch for the releases/gcc-13 branch. >> > Richard Biener rejected my patch for >> this branch. >> > Which

Re: [PATCH 2/6] c: Turn int-conversion warnings into permerrors

2023-12-01 Thread Sam James
钟居哲 writes: > Hi, This patch cause error on building newlib/glibc/musl on RISC-V port: > > /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_access.c:8:40: > error: passing argument 3 of 'syscall_errno' makes integ

[11 PATCH] libiberty, Darwin: Fix a build warning. [PR112823]

2023-12-01 Thread Sam James
From: Iain Sandoe r12-3005-g220c410162ebece4f missed a cast for the set_32 call. Fixed thus. Signed-off-by: Iain Sandoe Signed-off-by: Sam James libiberty/ChangeLog: PR other/112823 * simple-object-mach-o.c (simple_object_mach_o_write_segment): Cast the first argument

Re: [PATCH 2/6] c: Turn int-conversion warnings into permerrors

2023-12-01 Thread Sam James
Jeff Law writes: > On 12/1/23 18:13, Sam James wrote: >> 钟居哲 writes: >> >>> Hi, This patch cause error on building newlib/glibc/musl on RISC-V port: >>> >>> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newl

Re: [11 PATCH] libiberty, Darwin: Fix a build warning. [PR112823]

2023-12-01 Thread Sam James
Iain Sandoe writes: > HI Sam, Hi Iain, > > I think this qualifies as obvious (it’s on my list, but I did not get to it > yet, > so go ahead). Thanks. I can't push it myself - could you do that for me? thanks again, sam > > Iain > >> On 2 Dec 2023, at 0

Re: [PATCH] testsuite: Adjust for the new permerror -Wincompatible-pointer-types

2023-12-06 Thread Sam James
Yang Yujie writes: > On Wed, Dec 06, 2023 at 10:45:22AM -0700, Jeff Law wrote: >> >> >> On 12/6/23 05:12, Florian Weimer wrote: >> > * Yang Yujie: >> > >> > > From: Yang Yujie >> > > Subject: [PATCH] testsuite: Adjust for the new permerror >> > > -Wincompatible-pointer-types >> > > To: gc

Re: Introduce -finline-stringops (was: Re: [RFC] Introduce -finline-memset-loops)

2023-12-11 Thread Sam James
Alexandre Oliva via Gcc-patches writes: > On Jun 2, 2023, Alexandre Oliva wrote: > >> Introduce -finline-stringops > > Ping? https://gcc.gnu.org/pipermail/gcc-patches/2023-June/620472.html Should the docs for the x86-specific -minline-all-stringops refer to the new -finline-stringops? than

Re: [PATCH 4/4] maintainer-scripts/gcc_release: cleanup whitespace

2023-11-10 Thread Sam James
Joseph Myers writes: > On Thu, 2 Nov 2023, Sam James wrote: > >> maintainer-scripts/ >> * gcc_release: Cleanup whitespace. > > OK. Thanks. Would you mind pushing the two you approved?

[PATCH] MAINTAINERS: Fix formatting

2023-11-10 Thread Sam James
ChangeLog: * MAINTAINERS (Write After Approval): Fix indentation and missing email bracket. Signed-off-by: Sam James --- MAINTAINERS | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index c43167d9a752..9ad68687f769 100644

Re: [PATCH] C99 testsuite readiness: -fpermissive tests

2023-11-11 Thread Sam James
Florian Weimer writes: > * Eric Gallager: > >>> diff --git a/gcc/testsuite/gcc.c-torture/compile/20080910-1.c >>> b/gcc/testsuite/gcc.c-torture/compile/20080910-1.c >>> index bf32775d401..911fb562790 100644 >>> --- a/gcc/testsuite/gcc.c-torture/compile/20080910-1.c >>> +++ b/gcc/testsuite/gcc.

Re: [RFC PATCH] Detecting lifetime-dse issues via Valgrind [PR66487]

2023-11-11 Thread Sam James
exactl...@ispras.ru writes: > From: Daniil Frolov > > PR 66487 is asking to provide sanitizer-like detection for C++ object lifetime > violations that are worked around with -fno-lifetime-dse in Firefox, LLVM, > OpenJade. > > The discussion in the PR was centered around extending MSan, but MSan

Re: [RFC PATCH] Detecting lifetime-dse issues via Valgrind [PR66487]

2023-11-12 Thread Sam James
Alexander Monakov writes: > On Sat, 11 Nov 2023, Sam James wrote: > >> > Valgrind client requests are offered as macros that emit inline asm. For >> > use >> > in code generation, we need to wrap it in a built-in. We know that >> > implementing >

Re: [RFC PATCH] Detecting lifetime-dse issues via Valgrind [PR66487]

2023-11-12 Thread Sam James
Sam James writes: > Alexander Monakov writes: > [...] >> >> I'm very curious what you mean by "this has come up with LLVM [] too": >> ttbomk, >> LLVM doesn't do such lifetime-based optimization yet, which is why compiling >> LLVM with L

Re: [PATCH 3/6] c: Turn -Wimplicit-function-declaration into a pedpermerror [PR91092]

2023-11-13 Thread Sam James
Florian Weimer writes: > In the future, it may make sense to avoid cascading errors from > the implicit declaration, especially its assumed int return type. > This change here only changes the kind of the diagnostic, not > its wording or consequences. > > gcc/c/ > > * doc/invoke.texi (War

Re: [PATCH 0/6] Turn some C warnings into errors by default

2023-11-13 Thread Sam James
Florian Weimer writes: > This patch series converts the following warnings into errors by > default: > > -Wint-conversion > -Wimplicit-function-declaration > -Wimplicit-int > -Wreturn-mismatch > -Wincompatible-pointer-types > > As explained in the first commit, I decided not to use pe

Re: [PATCH 2/6] c: Turn int-conversion warnings into permerrors [PR106416]

2023-11-13 Thread Sam James
Florian Weimer writes: > gcc/ > > * doc/invoke.texi (Warning Options): Document changes. > > gcc/c/ > > * c-typeck.cc (build_conditional_expr): Use pedpermerror for > pointer/integer type mismatches, based on -Wint-conversion. > (pedwarn_pedpermerror_init, permerror_init

Re: [PATCH 4/6] c: Turn -Wimplicit-int into a pedpermerror [PR91093]

2023-11-13 Thread Sam James
Florian Weimer writes: > There is a missed opportunity here to issue spelling diagnostics > in prototype declarations (e.g., for “extern int foo (int32t);”). > > gcc/ > > * doc/invoke.texi (Warning Options): Document changes. > > gcc/c/ > > * c-decl.cc (warn_defaults_to): Call emit_

Re: [PATCH v2 5/8] c: Do not ignore some forms of -Wimplicit-int in system headers

2023-11-14 Thread Sam James
Florian Weimer writes: > Most -Wimplicit-int warnings were unconditionally disabled for system > headers. Only missing types for parameters in old-style function > definitions resulted in warnings. This is inconsistent with the > treatment of other permerrors, which are active in system heade

Re: [PATCH v2 5/8] c: Do not ignore some forms of -Wimplicit-int in system headers

2023-11-14 Thread Sam James
Florian Weimer writes: > * Sam James: > >> Florian Weimer writes: >> >>> Most -Wimplicit-int warnings were unconditionally disabled for system >>> headers. Only missing types for parameters in old-style function >>> definitions resulte

Re: [PATCH v2 0/8] Turn some C warnings into errors by default

2023-11-14 Thread Sam James
Florian Weimer writes: > This new series covers: > > -Wint-conversion > -Wimplicit-function-declaration > -Wimplicit-int > -Wreturn-mismatch > -Wincompatible-pointer-types > -Wdeclaration-missing-parameter-type (new) > > There are now gcc.dg/permerror-*.c tests which track the gradu

Re: [PATCH 1/4] libsanitizer: merge from upstream (c425db2eb558c263)

2023-11-15 Thread Sam James
Jakub Jelinek writes: > Hi! > > The following patch is result of libsanitizer/merge.sh > from c425db2eb558c263 (yesterday evening). > > Bootstrapped/regtested on x86_64-linux and i686-linux (together with > the follow-up 3 patches I'm about to post). > > Iain, could you please check Darwin? > >

Re: [committed] hppa: Revise REG+D address support to allow long displacements before reload

2023-11-16 Thread Sam James
John David Anglin writes: > On 2023-11-16 4:52 p.m., Jeff Law wrote: >> >> >> On 11/16/23 10:54, John David Anglin wrote: >>> Tested on hppa-unknown-linux-gnu and hppa64-hp-hpux11.11.  Committed >>> to trunk. >>> >>> This patch works around problem compiling python3.11 by improving >>> REG+D ad

Re: [committed] hppa: Revise REG+D address support to allow long displacements before reload

2023-11-16 Thread Sam James
Sam James writes: > John David Anglin writes: > >> On 2023-11-16 4:52 p.m., Jeff Law wrote: >>> >>> >>> On 11/16/23 10:54, John David Anglin wrote: >>>> Tested on hppa-unknown-linux-gnu and hppa64-hp-hpux11.11.  Committed >>>>

Re: [PATCH V3 4/7] ira: Support subreg copy

2023-11-18 Thread Sam James
Lehua Ding writes: > Hi Vladimir, > > On 2023/11/17 22:05, Vladimir Makarov wrote: >> On 11/16/23 21:06, Lehua Ding wrote: >>> Hi Vladimir, >>> >>> Thank you so much for your review. Based on your comments, I feel >>> like there are a lot of issues, especially the long compile time >>> issue. S

Re: [PATCH V3 4/7] ira: Support subreg copy

2023-11-18 Thread Sam James
Lehua Ding writes: > Hi Sam, > > On 2023/11/18 16:06, Sam James wrote: >> Lehua Ding writes: >> >>> Hi Vladimir, >>> >>> On 2023/11/17 22:05, Vladimir Makarov wrote: >>>> On 11/16/23 21:06, Lehua Ding wrote: >>>>>

Re: Propagate value ranges of return values

2023-11-19 Thread Sam James
Jan Hubicka writes: > Hi, > this patch implements very basic propaation of return value ranges from VRP > pass. This helps std::vector's push_back since we work out value range of > allocated block. This propagates only within single translation unit. I > hoped > we will also do the propaga

Re: [PATCH v3 00/11] : More warnings as errors by default

2023-11-27 Thread Sam James
Florian Weimer writes: > * Jeff Law: > >> On 11/20/23 02:55, Florian Weimer wrote: >>> This revision addresses Marek's comment about handing >>> -Wdeclaration-missing-parameter-type properly in conjunction with >>> -fpermissive. A new test (permerror-fpermissive-nowarning.c) >>> demonstrates t

Re: [PATCH] i386: Fix regression after refactoring legitimize_pe_coff_symbol, ix86_GOT_alias_set and PE_COFF_LEGITIMIZE_EXTERN_DECL

2024-06-27 Thread Sam James
Evgeny Karpov writes: > Thank you for reporting the issues and discussing the root causes. > It helped in preparing the patch. Thanks. I'll test it shortly but it looks equivalent to my local changes, so LGTM. > > This patch fixes 3 bugs reported after merging > the "Add DLL import/export impl

Re: [PATCH V2] rs6000: Don't pass -many to the assembler [PR112868]

2024-07-11 Thread Sam James
jeevitha writes: > Hi All, > > The following patch has been bootstrapped and regtested with default > configuration > [--enable-checking=yes] and with --enable-checking=release on > powerpc64le-linux. > > This patch removes passing the -many assembler option for release builds. Now, > GCC no lo

Re: [avr,patch,applied] testsuite - Add noipa function attribute to noclone functions.

2024-07-16 Thread Sam James
Georg-Johann Lay writes: > Applied as obvious. > > Johann I think you can change all of those to just noipa which implies noclone and noinline.

[PATCH] testsuite: Add dg-do run to more tests

2024-07-17 Thread Sam James
All of these are for wrong-code bugs. Confirmed to be used before but with no execution. 2024-07-17 Sam James PR/96369 PR/102124 PR/108692 * c-c++-common/pr96369.c: Add dg-do run directive. * gcc.dg/torture/pr102124.c: Ditto. * gcc.dg/pr108692.c

[PATCH v2] testsuite: Add dg-do run to more tests

2024-07-17 Thread Sam James
All of these are for wrong-code bugs. Confirmed to be used before but with no execution. Tested on x86_64-pc-linux-gnu and checked test logs before/after. 2024-07-17 Sam James PR/96369 PR/102124 PR/108692 * c-c++-common/pr96369.c: Add dg-do run directive

[PATCH v3] testsuite: Add dg-do run to more tests

2024-07-17 Thread Sam James
All of these are for wrong-code bugs. Confirmed to be used before but with no execution. Tested on x86_64-pc-linux-gnu and checked test logs before/after. 2024-07-18 Sam James PR c++/53288 PR c++/57437 PR c/65345 PR libstdc++/88101 PR tree-optimization

[PATCH] testsuite: Add dg-do run to even more tests, fix typo

2024-07-18 Thread Sam James
All of these are for wrong-code bugs. Confirmed to be used before but with no execution. Tested on x86_64-pc-linux-gnu and checked test logs before/after. 2024-07-18 Sam James PR target/7559 PR c++/9704 PR c++/16115 PR c++/19317 PR rtl-optimization

[PATCH] testsuite: powerpc: fix dg-do run typo

2024-07-18 Thread Sam James
'dg-run' is not a valid dejagnu directive, 'dg-do run' is needed here for the test to be executed. 2024-07-18 Sam James PR target/108699 * gcc.target/powerpc/pr108699.c: Fix 'dg-run' typo. --- Kewen, could you check this on powerpc to ensure it

Re: [PATCH] c-family: Introduce the -Winvalid-noreturn flag from clang with extra tuneability

2024-07-18 Thread Sam James
Julian Waters writes: > Darn, not even sending it from my friend's mail account worked to combat the > patch formatting issues. Not only is the > patch a complete wreck on the mailing list archive, but my friend's mail > account has now somehow merged into mine on the > list, resulting in a tru

Re: [PATCH] testsuite: powerpc: fix dg-do run typo

2024-07-19 Thread Sam James
"Kewen.Lin" writes: > Hi Sam, Hi Kewen, > > on 2024/7/19 11:28, Sam James wrote: >> 'dg-run' is not a valid dejagnu directive, 'dg-do run' is needed here >> for the test to be executed. >> >> 2024-07-18 Sam James >> >

[PATCH] gcc: stop adding -fno-common for checking builds

2024-07-19 Thread Sam James
Originally added in r0-44646-g204250d2fcd084 and r0-44627-gfd350d241fecf6 whic moved -fno-common from all builds to just checking builds. Since r10-4867-g6271dd984d7f92, GCC defaults to -fno-common. There's no need to pass it specially for checking builds. We could keep it for older bootstrap com

[PATCH] testsuite: fix pr115929-1.c with -Wformat-security

2024-07-19 Thread Sam James
Some distributions like Gentoo make -Wformat and -Wformat-security enabled by default. Pass -Wno-format to the test to avoid a spurious fail in such environments. gcc/testsuite/ PR rtl-optimization/115929 * gcc.dg/torture/pr115929-1.c: Pass -Wno-format. --- Richard, is this OK? I c

Re: [PATCH] testsuite: fix pr115929-1.c with -Wformat-security

2024-07-19 Thread Sam James
Xi Ruoyao writes: > On Sat, 2024-07-20 at 06:52 +0100, Sam James wrote: >> Some distributions like Gentoo make -Wformat and -Wformat-security >> enabled by default. Pass -Wno-format to the test to avoid a spurious >> fail in such environments. >> >> gcc/tests

[PATCH] modula2: Fully respect DESTDIR in texi rule

2024-05-20 Thread Sam James
This was originally reported in Gentoo at https://bugs.gentoo.org/930014. 2024-05-20 Sam James gcc/m2/ * Make-lang.in (m2.install-info): Pass --destdir for dir index. --- gcc/m2/Make-lang.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/m2/Make-lang.in b/gcc

Re: [PATCH] Fix -Wstringop-overflow warning in 23_containers/vector/types/1.cc

2024-05-27 Thread Sam James
François Dumont writes: > In C++98 this test fails with: For this, and your other -Wfree-nonheap-object patches, could you see if it helps with any of the bugs reported for both -Wstringop-overflow and -Wfree-nonheap-object in libstdc++? There's a bunch of (possible) dupes that it'd be worth tag

Re: [PATCH] testsuite: Fix fam-in-union-alone-in-struct-2.c with unsigned char [PR116148]

2024-08-09 Thread Sam James
"Kewen.Lin" writes: > Hi, > > As PR116148#c7 shows, fam-in-union-alone-in-struct-2.c still > fails on hppa which is a BE environment, but by checking more > (also confirmed by John in PR116148#c12), it's due to that > signedness of plain char on hppa is signed therefore the value > of with_fam_3_

Re: [PATCH] [x86] Mention _Float16 and __bf16 changes in GCC14.

2024-08-12 Thread Sam James
Gerald Pfeifer writes: > On Wed, 31 Jul 2024, liuhongt wrote: >> + The _Float16 and __bf16 type are supported >> +independent of SSE2. W/o SSE2, these types are storage-only, compiler >> will >> +issue an error when they're used in conversion, unary operation, >> +binary operation,

Re: [PATCH] ifcvt: Fix force_operand ICE due to noce_convert_multiple_sets [PR116353]

2024-08-13 Thread Sam James
Manolis Tsamis writes: > Now that more operations are allowed for noce_convert_multiple_sets, we need > to > check noce_can_force_operand on the sequence before calling > try_emit_cmove_seq. > Otherwise an inappropriate argument may be given to copy_to_mode_reg and > result > in an ICE. > > Fi

Re: [PATCH v2] genoutput: Accelerate the place_operands function.

2024-08-13 Thread Sam James
Xianmiao Qu writes: > On Wed, Aug 14, 2024 at 01:01:35AM +0800, Xianmiao Qu wrote: >> static void scan_operands (class data *, rtx, int, int); >> -static int compare_operands (struct operand_data *, >> - struct operand_data *); >> static void place_operands (class data *

Re: Ping: [PATCH] testsuite: Fix struct size check [PR116155]

2024-08-13 Thread Sam James
Hans-Peter Nilsson writes: > I stumbled on this being a regression for cris-elf as well; > the patch expectedly fixes the test-case for CRIS as well. > It's been a week since the patch was posted and as I see no > replies, I'm pinging this in behalf of Dimitar. I can't formally approve it but I

Re: [PATCH v4] genoutput: Accelerate the place_operands function.

2024-08-13 Thread Sam James
Xianmiao Qu writes: > With the increase in the number of modes and patterns for some > backend architectures, the place_operands function becomes a > bottleneck int the speed of genoutput, and may even become a > bottleneck int the overall speed of building the GCC project. > This patch aims to a

Re: Ping: [PATCH] testsuite: Fix struct size check [PR116155]

2024-08-13 Thread Sam James
Hans-Peter Nilsson writes: >> From: Sam James >> Date: Tue, 13 Aug 2024 18:17:29 +0100 > >> Hans-Peter Nilsson writes: >> >> > I stumbled on this being a regression for cris-elf as well; >> > the patch expectedly fixes the test-case for CRIS as we

Re: [PATCH] ifcvt: Fix force_operand ICE due to noce_convert_multiple_sets [PR116353]

2024-08-13 Thread Sam James
"H.J. Lu" writes: > On Tue, Aug 13, 2024 at 4:57 AM Manolis Tsamis > wrote: >> >> Now that more operations are allowed for noce_convert_multiple_sets, we need >> to >> check noce_can_force_operand on the sequence before calling >> try_emit_cmove_seq. >> Otherwise an inappropriate argument may

Re: [PATCH v5] genoutput: Accelerate the place_operands function.

2024-08-13 Thread Sam James
Xianmiao Qu writes: > With the increase in the number of modes and patterns for some > backend architectures, the place_operands function becomes a > bottleneck int the speed of genoutput, and may even become a > bottleneck int the overall speed of building the GCC project. > This patch aims to a

[PATCH] ltmain.sh: allow more flags at link-time

2024-08-14 Thread Sam James
libtool defaults to filtering flags passed at link-time. This brings the filtering in GCC's 'fork' of libtool into sync with upstream libtool commit 22a7e547e9857fc94fe5bc7c921d9a4b49c09f8e. In particular, this now allows some harmless diagnostic flags (especially useful for things like -Werror=o

Re: [PATCH-1v4] Value Range: Add range op for builtin isinf

2024-08-14 Thread Sam James
Vineet Gupta writes: > Ping - looks like this is blocking the patches for builtin_isnormal and > builtin_isfinite ! > See https://inbox.sourceware.org/gcc-patches/d9459db0-7301-40f6-a3cf-077017b8c...@gmail.com/. It appears to be approved. (Please also avoid topposting.) > Thx, > -Vineet > >

Re: [PATCH] ltmain.sh: allow more flags at link-time

2024-08-14 Thread Sam James
Eric Gallager writes: > On Wed, Aug 14, 2024 at 8:50 AM Sam James wrote: >> >> libtool defaults to filtering flags passed at link-time. >> >> This brings the filtering in GCC's 'fork' of libtool into sync with >> upstream libtool commit 22a7e547e9

[PATCH 1/2] Makefile.tpl: drop leftover intermodule cruft

2024-08-14 Thread Sam James
intermodule supported was dropped in r0-103106-gde6ba7aee152a0 with some remaining bits for Fortran removed in r14-1696-gecc96eb5d2a0e5. Remove some small leftovers. * Makefile.in: Regenerate. * Makefile.tpl (STAGE1_CONFIGURE_FLAGS: Remove --disable-intermodule. --- Makefile.in

[PATCH 2/2] Makefile.tpl: fix whitespace in licence header

2024-08-14 Thread Sam James
* Makefile.tpl: Fix whitespace. --- Makefile.tpl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.tpl b/Makefile.tpl index cbb3c6789dcf..da38dca697ad 100644 --- a/Makefile.tpl +++ b/Makefile.tpl @@ -13,12 +13,12 @@ in # it under the terms of the GNU General

  1   2   3   4   5   >