Re: [V850] Hookize LIBCALL_VALUE

Hi Anatoliy, OK for trunk? 2015-07-26 Anatoly Sokolov * config/v850/v850.h (LIBCALL_VALUE): Remove macros. * config/v850/v850.md (RV_REGNUM): New constants. * config/v850/v850.c (v850_libcall_value): New functions. (v850_function_value_regno_p, v850_function_value): Use

Re: rx: remove some asserts

Hi DJ, There is no need to assert these just to say "not supported" and gcc may rarely generate addresses from valid code which trigger these asserts. Ok? OK - please apply. Cheers Nick

Re: [BUILDROBOT] [PATCH] rx-elf: error: logical not is only applied to the left hand side of comparison

Hi Jan-Benedict, 2014-09-04 Jan-Benedict Glaw * config/rx/rx.h (HARD_REGNO_MODE_OK): Add braces. Approved - please apply - thanks! Cheers Nick

Re: [BUILDROBOT] v850 fallout

Hi Guys, > Jan-Benedict Glaw wrote: I've been away for holidays and other stuff, so this is a bit late, but nevermind... The stringification of DECL_SECTION_NAME had some fallout, see eg. http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=272454 /home/jbglaw/repos/gcc/gcc/config/v

Re: RFA: RL78: Place zero-initialised data into the .bss section

Hi DJ, Ok but.. +case SECCAT_TBSS: + return default_select_section (decl, reloc, align); + +default: + gcc_unreachable (); Would it be better to just "default:" everything to default_select_section, instead of enumerating everything we know about today? Yes it would. :-}

Re: [BUILDROBOT] RFA: RL78: Add support for G13 and G14 multiply and divide

Hi Jan-Benedict. ../../../gcc/gcc/config/rl78/rl78.c:390:14: error: enumeration value ‘MUL_RL78’ not handled in switch [-Werror=switch] switch (rl78_mul_type) ../../../gcc/gcc/config/rl78/rl78.c:4649:34: error: unused parameter ‘x’ [-Werror=unused-parameter] rl78_preferred_reload_

Re: Fix xstormy16 handling of HImode predicates

Hi Richard, gcc/ * config/stormy16/predicates.md (xs_hi_general_operand): Delete. (xs_hi_nonmemory_operand): Remove error. * config/stormy16/stormy16.md (movhi, movhi_internal): Use general_operand rather than xs_hi_general_operand. Approved - please apply. Che

Re: RFA: Doc update: Describe new MSP430 feature

Hi Gerald, as maintainer of the port you do not need anyone else's approval. Thanks - have checked the (editted) patch in. That said, I am always happy to provide a second pair of eyes, so here are some comments: Thanks for those too. I have made the appropriate changes following your su

Re: RFA: RL78: Save the frame pointer if it is used.

Hi DJ, OK to apply ? Ok, but... Thanks - committed. - if (regno == FRAME_POINTER_REGNUM && frame_pointer_needed) + if (regno == FRAME_POINTER_REGNUM + && (frame_pointer_needed || df_regs_ever_live_p (regno))) Do we want regs_ever_live or regs_ever_written_to ? I seem to recall

Re: RFC: Avoid calling convert_to_mode with invalid rtl.

Hi Eric, Note that the very same code is in expand_assignment, so they probably should be kept in sync. Oops - I had missed that. The patch adds a second call to expand_expr(), giving the address mode as the suggested mode, and using a normal expansion, rather than EXPAND_SUM. This

RFA: Updated gcc-5 html documentation for new RX option

Hi Gerald, The attached patch updates the gcc html documentation to mention the new RX command line option that I checked in today. Is this patch OK to apply ? Cheers Nick Index: htdocs/gcc-5/changes.html === RCS file: /cvs

Re: RFA: Fix isl-ast-gen-if-1.c test

Hi Jeff, I'd tend to prefer to change the size of the array -- adding another conditional in the loop may have unintended consequences that possibly scramble things just enough to compromise the test. Okey dokey, here is a revised version. Is this one OK ? Cheers Nick gcc/ChangeLog Index

RFA: FT32: Fix building gcc.

Hi Guys, It seems that the FT32 port of GCC does not have a maintainer at the moment. Nevertheless I have a patch to fix a couple of build time problems compiling gcc for the FT32. Is this OK to apply ? Cheers Nick gcc/ChangeLog 2015-06-23 Nick Clifton * config/ft32/ft32.c

Re: RFA: RL78: Fix gcc testsuite failures

Hi Jan-Benedict, Seems you accidentally committed quite some more code you're currently working on in that very commit, which is now breaking Doh! Yes, sorry about that. I have now reverted the DIV attribute part of the patch. (I am hoping that this work will be ready for contributing soo

Re: [PATCH] [BUILDROBOT] RX: Mark unused argument

Hi Jan-Benedict, 2014-11-03 Jan-Benedict Glaw * config/rx/rx.c (rx_handle_func_attribute): Mark unused argument. Approved - please apply. Cheers Nick

Re: Ping: FR-V rtx iterator patches

Hi Richard, Ping for these FR-V patches: https://gcc.gnu.org/ml/gcc-patches/2014-10/msg02645.html https://gcc.gnu.org/ml/gcc-patches/2014-10/msg02646.html https://gcc.gnu.org/ml/gcc-patches/2014-10/msg02647.html https://gcc.gnu.org/ml/gcc-patches/2014-10/msg02648.html which convert callers of

Re: [BUILDROBOT, PATCH] MSP430: Fix unused arg warning

Hi Jan-Benedict, 2014-12-17 Jan-Benedict Glaw * config/msp430/msp430.c (msp430_asm_output_addr_const_extra): Fix unused argument warning. Approved - please apply. Cheers Nick

Re: [PATCH] msp430: inhibit automatic link of -lnosys in absence of -msim

Hi Peter, > gcc/ChangeLog > 2014-09-22 Peter A. Bigot > >* config/msp430/msp430.h: Remove automatic -lnosys when -msim absent. Approved and applied. Cheers Nick

Re: RFA: Fix calculation of size of builtin setjmp buffer

Hi Jakub, /* builtin_setjmp takes a pointer to 5 words. */ - tmp = size_int (5 * BITS_PER_WORD / POINTER_SIZE - 1); + tmp = size_int (5 * POINTER_SIZE / BITS_PER_WORD - 1); That doesn't look correct to me. If the code wants to create 5 words long array, but with pointer el

Re: RFA: Fix calculation of size of builtin setjmp buffer

Hi Jakub, But what will this do on targets where POINTER_SIZE is smaller than BITS_PER_WORD? E.g. I think some options on s390 or ppc. If you want it to be always 5 pointers, then you want tmp = size_int (4); and not something else, otherwise it really depends on how exactly it is used, perh

Re: RFA: Fix calculation of size of builtin setjmp buffer

Hi Mike, How about GET_MODE_SIZE (STACK_SAVEAREA_MODE (SAVE_NONLOCAL)) / GET_MODE_SIZE (Pmode) + 2 + /* slop for mips, see builtin_setjmp_setup */ 1 - 1. This retains the slop for mips, and fixes ports like ia64 and s390 (see STACK_SAVEAREA_MODE on those ports, it is larger one might expect)

Re: RFA: Fix calculation of size of builtin setjmp buffer

Hi Eric, 2014-05-06 Nick Clifton * except.c (init_eh): Fix computation of builtin setjmp buffer size. That's the same patch as https://gcc.gnu.org/ml/gcc-patches/2011-11/msg00272.html and is still incorrect. Ah - you are worried about the case where STACK_SAVEAREA_MODE

Re: RFA: Fix calculation of size of builtin setjmp buffer

Hi Eric, OK - here is your version of the patch, extended with a comment which I think is helpful for other people reading the code, and with the changes to builtins.c and md.texi removed, since the size of the buffer is not changing. Is this version OK to apply ? Cheers Nick gcc/Cha

Re: RFA: x86 backend: Add default-manifest to Cygwin/MinGW links

Hi Kai, The default manifest file contains a resource section (.rsrc) holding information necessary for the binary to be run under Windows 8. It is placed last on the linker command line so that a user provided manifest, if there is one, will take precedence over the default mani

Re: RFA: x86 backend: Add default-manifest to Cygwin/MinGW links

Hi Corinna, However, we know that the act of merging will currently result in broken resources in the executable. Wouldn't it be better to apply the above patch only after the resource merge fix? No. Well not in my opinion. :-) The reason is that this patch only makes a difference if the d