Re: [PATCH 4/7 v2] lto: Implement ltrans cache

2024-06-21 Thread Michal Jireš
On 6/20/24 7:45 PM, Andi Kleen wrote: There are much faster/optimized modern hashes for good collision detection over MD5 especially when it's not needed to be cryptographically secure. Pick something from smhasher. Also perhaps the check sum should be cached in the file? I assume it's cheap to

Re: [PATCH 3/3] dwarf: lto: Stabilize external die references.

2024-12-06 Thread Michal Jireš
On 11/27/24 3:12 PM, Richard Biener wrote: I wonder why you could not always do this for a subset of symbols, namely those exported from the current TU and building a symbol based on the symbols assembler name? That is, I dislike relying on a new flag_lto_debuginfo_assume_unique_filepaths fla

Re: [PATCH 1/3] dwarf: Delete dead code.

2024-12-06 Thread Michal Jireš
On 11/27/24 2:59 PM, Richard Biener wrote: Did you test with -fdebug-types-section? This code should be still needed to generate the linkonce debug-type sections. Note it doesn't work (very well) when combined with LTO. I used the tests in testsuite and now I also tested it with nontrivia

Re: [PATCH] lto: Fix missing cleanup with incremental LTO.

2025-03-06 Thread Michal Jireš
On 3/6/25 9:49 AM, Richard Biener wrote: On Thu, 6 Mar 2025, Michal Jires wrote: Incremental LTO disabled cleanup of output_files since they have to persist in ltrans cache. This unintetionally also kept temporary early debug "*.debug.temp.o" files. Bootstrapped/regtested on x86_64-linux. Ok f

Re: [PATCH 13/17] lto-ltrans-cache: Remove unused private member

2025-06-26 Thread Michal Jireš
On 6/25/25 4:14 PM, Martin Jambor wrote: Hi, when building GCC with clang, it warns that the private member suffix in class ltrans_file_cache (defined in lto-ltrans-cache.h) is not used which indeed looks like it is the case. This patch therefore removes it along with its initialization in the