((interrupt_handler && !prologue) ||( fast_interrupt && !prologue) )
+ if ((interrupt_handler && prologue) || (fast_interrupt && prologue))
Refactor. Fix spacing around parens.
--
Michael Eagerea...@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
On 02/27/2013 06:42 AM, David Holsgrove wrote:
Hi Michael,
Thanks for the review, please find comments inline below.
-Original Message-
From: Michael Eager [mailto:ea...@eagerm.com]
Sent: Wednesday, 27 February 2013 3:50 am
To: David Holsgrove
Cc: gcc-patches@gcc.gnu.org; Michael
revision 196315.
--
Michael Eagerea...@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
On 02/27/2013 04:36 PM, David Holsgrove wrote:
-Original Message-
From: Michael Eager [mailto:ea...@eagercon.com]
Sent: Thursday, 28 February 2013 3:06 am
To: David Holsgrove
Cc: Michael Eager; gcc-patches@gcc.gnu.org; John Williams; Edgar E. Iglesias
(edgar.igles...@gmail.com); Vinod
On 02/10/2013 10:40 PM, David Holsgrove wrote:
Setup stack protection at entry.
libgcc/Changelog
2013-02-11 Edgar E. Iglesias
* config/microblaze/crti.S: Setup stack protection at entry
Committed revision 196432.
--
Michael Eagerea...@eagercon.com
1960 Park Blvd., Palo Alto, CA
/predicates.md (call_insn_simple_operand):
New predicate for supported rtx code types.
* config/microblaze/microblaze.md (call_internal1): Use
call_insn_simple_operand predicate.
Committed revision 196433.
--
Michael Eagerea...@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650
*, const char *, const char *,
const char *, int);
extern void microblaze_asm_output_ident (const char *);
+extern int microblaze_legitimate_pic_operand (rtx);
#endif /* RTX_CODE */
/* Declare functions in microblaze-c.c. */
--
Michael Eagerea...@eagercon.com
1960 Park Blvd., Palo Alto
On 03/05/2013 06:54 AM, David Holsgrove wrote:
Hi Michal,
-Original Message-
From: Michael Eager [mailto:ea...@eagerm.com]
Sent: Monday, 4 March 2013 3:37 am
To: David Holsgrove
Cc: Michael Eager; gcc-patches@gcc.gnu.org; John Williams; Edgar E. Iglesias
(edgar.igles...@gmail.com
On 03/05/2013 07:09 AM, David Holsgrove wrote:
Hi Michael,
-Original Message-
From: Michael Eager [mailto:ea...@eagerm.com]
Sent: Wednesday, 27 February 2013 4:12 am
To: David Holsgrove
Cc: gcc-patches@gcc.gnu.org; Michael Eager (ea...@eagercon.com); John
Williams; Edgar E. Iglesias
dition rather that at end of
previous line
- Some places where the indenting is incorrect
Should this patch be combined with the other patch adding TLS checking to
configure?
--
Michael Eagerea...@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
On 03/14/2013 01:07 AM, David Holsgrove wrote:
Hi Michael,
-Original Message-
From: Michael Eager [mailto:ea...@eagerm.com]
Sent: Thursday, 14 March 2013 1:34 am
To: David Holsgrove
Cc: gcc-patches@gcc.gnu.org; Edgar Iglesias; John Williams; Vinod Kathail;
Vidhumouli Hunsigida
after applying this patch. I haven't looked at the
failures in detail.
--
Michael Eagerea...@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
(microblaze_is_break_handler ())
+return "rtbd\tr16, 0\;%#";
Ditto.
+if (microblaze_is_break_handler ())
+return "rtbd\tr16, 0\;%#";
Ditto.
Mailing list conventions do not permit restrictive annotations.
--
Michael Eagerea...@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
/config/microblaze/microblaze-protos.h
b/gcc/config/microblaze/microblaze-protos.h
index b03e9e1..f3cc099 100644
--- a/gcc/config/microblaze/microblaze-protos.h
+++ b/gcc/config/microblaze/microblaze-protos.h
Please include the patch only once, not both inline and again as an
attachment.
--
Michael
On 05/13/14 12:15, Ajit Kumar Agarwal wrote:
Hello Michael:
Thanks for the comments on ChangeLog. Modified ChangeLog is inlined below.
Please resubmit the patch with documentation for _break_handler.
--
Michael Eagerea...@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
, but there are no changes to
gcc/doc/extend.texi in your patch.
--
Michael Eagerea...@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
return "rtid\tr14,0 \;%#";
Please remove trailing white space in future patches.
The code in the "call_internal" pattern does not follow GNU indent
conventions. If you are modifying code which does not follow these
conventions, please bring it up to date, rather than repeating the
indent violations.
Committed revision 210559.
--
Michael Eagerea...@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
add a test case to the patch.
Changelog entries saying "fix XYZ" are not as useful as a description
of the changes made. A better Changelog would be:
* config/microblaze/microblaze.md (cstoresf4, cbranchsf4): Replace
comparison_operator with ordered_comparison_operator.
--
Signed-off-by: Edgar E. Iglesias
Signed-off-by: Peter A. G. Crosthwaite
Patch remains the same, please apply when ready.
thanks,
David
Hi David --
Is it possible to add a test case which shows the ICE?
Thanks.
--
Michael Eagerea...@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
On 01/22/14 02:50, David Holsgrove wrote:
Hi Michael,
On 22 January 2014 13:43, David Holsgrove wrote:
-Original Message-
From: Michael Eager [mailto:ea...@eagerm.com]
Sent: Friday, 17 January 2014 4:36 am
To: David Holsgrove; gcc-patches@gcc.gnu.org
Cc: Edgar Iglesias; John Williams
i2 / bswapsi2 insn
testsuite/ChangeLog
2014-01-22 David Holsgrove
* gcc/testsuite/gcc.target/microblaze/others/bswap16.c: New test.
Thanks for the test case.
I had verified that the code was correct by hand, but tests are always
a good addition.
--
Michael Eagerea...@eagercon.com
196
On 01/22/14 07:43, Michael Eager wrote:
On 01/22/14 02:55, David Holsgrove wrote:
Hi Michael,
On 26 November 2013 17:48, David Holsgrove wrote:
Hi Michael,
Please find attached same patch based against latest from gcc master.
Can this be applied and backported to gcc-4_8-branch when
On 01/22/14 09:02, Michael Eager wrote:
On 01/22/14 07:43, Michael Eager wrote:
On 01/22/14 02:55, David Holsgrove wrote:
Hi Michael,
On 26 November 2013 17:48, David Holsgrove wrote:
Hi Michael,
Please find attached same patch based against latest from gcc master.
Can this be applied and
4_8-branch: Committed revision 206969.
--
Michael Eagerea...@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
On 07/14/13 21:37, David Holsgrove wrote:
Hi Michael,
-Original Message-
From: Michael Eager [mailto:ea...@eagerm.com]
Sent: Saturday, 13 July 2013 9:33 am
To: David Holsgrove
Cc: gcc-patches@gcc.gnu.org; Edgar Iglesias; John Williams; Vinod Kathail;
Vidhumouli Hunsigida; Nagaraju
On 01/22/14 02:50, David Holsgrove wrote:
Hi Michael,
On 22 January 2014 13:43, David Holsgrove wrote:
-Original Message-
From: Michael Eager [mailto:ea...@eagerm.com]
Sent: Friday, 17 January 2014 4:36 am
To: David Holsgrove; gcc-patches@gcc.gnu.org
Cc: Edgar Iglesias; John Williams
of the patch in the text of the email,
rather than hiding it within an attached patch.
The patch describes a very specific situation where this patch
will have an effect. Please provide a test case.
--
Michael Eagerea...@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
07679.
--
Michael Eagerea...@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
mcpu version format.
Parsing a version number could be better done in fewer lines using sscanf()
instead of 50 lines.
GCC-head: Committed revision 207680.
GCC-4.8-branch: Committed revision 207681.
--
Michael Eagerea...@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
On 02/13/14 21:48, David Holsgrove wrote:
Hi Michael,
-Original Message-
From: Michael Eager [mailto:ea...@eagerm.com]
Sent: Sunday, 9 February 2014 2:58 am
To: David Holsgrove; gcc-patches@gcc.gnu.org
Cc: Edgar Iglesias; John Williams; Vidhumouli Hunsigida; Nagaraju Mekala
Subject: Re
On 02/13/14 21:48, David Holsgrove wrote:
Hi Michael, List,
-Original Message-
From: David Holsgrove
Sent: Wednesday, 22 January 2014 1:43 pm
To: 'Michael Eager'; gcc-patches@gcc.gnu.org
Cc: Edgar Iglesias; John Williams; Vidhumouli Hunsigida; Nagaraju Mekala
Subject:
On 02/13/14 21:48, David Holsgrove wrote:
Hi Michael,
-Original Message-
From: Michael Eager [mailto:ea...@eagerm.com]
Sent: Sunday, 26 January 2014 1:57 am
To: David Holsgrove
Cc: gcc-patches@gcc.gnu.org; Edgar Iglesias; John Williams; Vinod Kathail;
Vidhumouli Hunsigida; Nagaraju
On 02/14/14 09:41, Michael Eager wrote:
On 02/13/14 21:48, David Holsgrove wrote:
Hi Michael,
-Original Message-
From: Michael Eager [mailto:ea...@eagerm.com]
Sent: Sunday, 26 January 2014 1:57 am
To: David Holsgrove
Cc: gcc-patches@gcc.gnu.org; Edgar Iglesias; John Williams; Vinod
On 02/14/14 09:42, Michael Eager wrote:
On 02/13/14 21:48, David Holsgrove wrote:
Hi Michael, List,
-Original Message-
From: David Holsgrove
Sent: Wednesday, 22 January 2014 1:43 pm
To: 'Michael Eager'; gcc-patches@gcc.gnu.org
Cc: Edgar Iglesias; John Williams; Vidhumouli
rom branch insn.
thanks,
David
gcc-head: Committed revision 208055.
gcc-4_8_branch: Committed revision 208056.
--
Michael Eagerea...@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
David Holsgrove
* gcc/config/microblaze/microblaze.md: Correct ashrsi_reg / lshrsi_reg names.
gcc-head: Committed revision 208061.
gcc-4_8_branch: Committed revision 208062.
--
Michael Eagerea...@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
On 02/26/14 16:29, David Holsgrove wrote:
Hi Mike S., Michael E.,
-Original Message-
From: Mike Stump [mailto:mikest...@comcast.net]
Sent: Friday, 21 February 2014 6:17 am
To: David Holsgrove
Cc: gcc-patches@gcc.gnu.org; Michael Eager (ea...@eagerm.com); Vidhumouli
Hunsigida; Nagaraju
On 07/08/14 00:38, Nagaraju Mekala wrote:
Hi Michael,
-Original Message-
From: Michael Eager [mailto:ea...@eagerm.com]
Sent: Tuesday, July 01, 2014 11:12 AM
To: David Holsgrove; gcc-patches@gcc.gnu.org
Cc: Edgar Iglesias; John Williams; Vidhumouli Hunsigida; Nagaraju Mekala; Ajit
Kumar
ap_1): Fix bswap detection.
+
2014-02-23 David Holsgrove
* config/microblaze/microblaze.md: Correct ashrsi_reg / lshrsi_reg names
Don't include the ChangeLog entry as part of your patch.
It isn't likely to apply.
--
Michael Eagerea...@eagercon.com
1960 Park Blvd., Palo
identical the existing microblaze*-*-* target.
Why is an -elf target needed?
--
Michael Eagerea...@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
: Set LIB2FUNCS_EXCLUDE
to exclude functions from being built with libgcc.c and use
the microblaze assembly.
Hi David --
The patch is OK, but I'm confused about the PR mentioned. GCC PR54662
doesn't seem to be related.
--
Michael Eagerea...@eagercon.com
1960
flags": no such variable
gcc/testsuite/Changelog:
2013-01-21 David Holsgrove
* gcc.target/microblaze/microblaze.exp: Remove target_config_cflags check
Committed.
--
Michael Eagerea...@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
On 01/20/2013 09:46 PM, David Holsgrove wrote:
gcc/Changelog
2013-01-21 Edgar E. Iglesias
* gcc/config/microblaze/linux.h: Add TARGET_OS_CPP_BUILTINS
Committed revision 195408.
--
Michael Eagerea...@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
On 01/23/2013 08:24 PM, David Holsgrove wrote:
Hi Michael,
On 24 January 2013 00:58, Michael Eager wrote:
On 01/20/2013 09:42 PM, David Holsgrove wrote:
gcc/Changelog
2013-01-21 Edgar E. Iglesias
* config.gcc (microblaze*-*-elf): Add new target
libgcc/Changelog
2013-01-21
On 01/24/2013 04:37 PM, David Holsgrove wrote:
On 25 January 2013 01:38, Michael Eager wrote:
On 01/23/2013 08:24 PM, David Holsgrove wrote:
Hi Michael,
On 24 January 2013 00:58, Michael Eager wrote:
On 01/20/2013 09:42 PM, David Holsgrove wrote:
gcc/Changelog
2013-01-21 Edgar E
On 01/23/2013 01:13 PM, David Holsgrove wrote:
Hi Michael,
On 24 January 2013 01:07, Michael Eager wrote:
On 01/20/2013 09:46 PM, David Holsgrove wrote:
gcc/Changelog
2013-01-21 David Holsgrove
* config.gcc (microblaze*-linux*): Add tmake_file to allow
building
of
/Changelog
2013-01-25 Edgar E. Iglesias
* 20101011-1.c: Add __MICROBLAZE__ exception to set DO_TEST 0
Committed revision 195893.
--
Michael Eagerea...@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
microblaze.
* config/microblaze/microblaze.h
(TRAMPOLINE_SIZE): Adapt for microblaze.
Committed revision 196103.
--
Michael Eagerea...@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
.
* config/microblaze/microblaze.c (microblaze_option_override):
Bail out early for PIC modes when target does not support PIC.
gcc/testsuite/Changelog
2013-02-11 Edgar E. Iglesias
* gcc.dg/20020312-2.c: Define MicroBlaze PIC register
Committed revision 196104.
--
Michael Eagerea
On 02/10/2013 10:38 PM, David Holsgrove wrote:
Free variable local allocs at block ends.
Changelog
2013-02-11 Edgar E. Iglesias
* config/microblaze/microblaze.md (save_stack_block):
Define.
(restore_stack_block): Likewise.
Committed revision 196110.
--
Michael Eagerea
On 02/10/2013 10:38 PM, David Holsgrove wrote:
Handle 0x8000 as 32bit signed dividend
Changelog
2013-02-11 Edgar E. Iglesias
* config/microblaze/modsi3.S (modsi3): Fix case with
0x8000 as dividend.
Is there a test case?
--
Michael Eagerea...@eagercon.com
1960 Park
On 02/10/2013 10:38 PM, David Holsgrove wrote:
Handle 0x8000 as 32bit signed dividend
Changelog
2013-02-11 Edgar E. Iglesias
* config/microblaze/modsi3.S (modsi3): Fix case with
0x8000 as dividend.
Committed revision 196156.
--
Michael Eagerea...@eagercon.com
1960 Park
(call_value_intern):
Check symbol is function before branching
Committed revision 196157.
--
Michael Eagerea...@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
v8.10.a to enable microblaze_has_clz
* config/microblaze/microblaze.h: Add TARGET_HAS_CLZ as
combined version and TARGET_PATTERN_COMPARE check
* config/microblaze/microblaze.md: New clzsi2 instruction
Committed revision 196158.
--
Michael Eagerea...@eagercon.com
1960 Park Blvd
'ed):
microblaze:
The microblaze_address_cost takes the mode of the address rtx.
Maybe it is meant to take the mode of the MEM?
The address cost calculation looks OK. I'm not sure why the mode of
MEM is relevant to this computation.
No objections to the patch.
--
Michael Eagerea...@eager
for declaring size at the end of the function. */
OK.
--
Michael Eagerea...@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
e #ident
situation is solved.
Re: MicroBlaze mods: "MICROBLASE_SECTION_THRESHOLD" should be
"microblaze_section_threshold". This value may usually be smaller than an
ident string, but it can be set by the -G command line option to any value
the user desires. I don'
assembler output
are negligible (only #APP / #NO_APP, which is emitted for all
top-level asms, and an extra blank line). I have also tested mips-sim
and compared the test results without and with patch.
OK for trunk?
Please eliminate the comment before microblaze_asm_output_ident().
--
Michael
On 06/06/2012 03:31 PM, Steven Bosscher wrote:
On Thu, Jun 7, 2012 at 12:00 AM, Michael Eager wrote:
This is the patch to deal with #ident. It removes the ASM_OUTPUT_IDENT
and IDENT_ASM_OP target macros, and replaces them with a single target
hook. For targets that treat front-end #idents
On 09/13/2011 10:58 AM, Richard Sandiford wrote:
As per the subject. Tested by making sure that there were no new
warnings building microblaze-elf, and that there were no changes
in the assembly output for the C and C++ testsuite. OK to install?
OK.
--
Michael Eagerea...@eagercon.com
xtensa-elf
OK to install?
* config/microblaze/microblaze.c (double_memory_operand)
(microblaze_block_move_loop): Likewise.
OK.
--
Michael Eagerea...@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
This patch makes MicroBlaze handle return and simple_return in
the same fashion as MIPS.
2011-12-29 Michael Eager
* config/microblaze/microblaze.md: Add expander for simple_return,
return, add return_internal and simple_return_internal insns.
Checked in, revision 182725
The branch test after a pattern compare instruction was backwards.
2012-01-27 Michael Eager
* config/microblaze.c (microblaze_emit_compare): Correct
test after pcmp instruction.
Index: config/microblaze/microblaze.c
lse wants to approve this patch...
Microblaze change OK.
--
Michael Eagerea...@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
ffset into either
.debug_macinfo or .debug_macro, depending on which was present.
I think that your modifications would be a significant improvement to DWARF.
Please submit a proposal at http://dwarfstd.org/Comment.php.
--
Michael Eagerea...@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
On 07/20/2011 11:00 AM, Jakub Jelinek wrote:
On Wed, Jul 20, 2011 at 10:16:10AM -0700, Michael Eager wrote:
It took me a few days to review the current DWARF macinfo specification
and review this proposal.
The existing macro data format is clearly in need of revision. I don't
think
max_depth is greater than 17. If -g is
specified, this later results in attempting to generate a DWARF location
list much larger than the 0x size limit, resulting in an assert failure.
Changelog:
2011-07-20 Michael Eager
* params.def (PARAM_MAX_VARTRACK_EXPR_DEPTH): Defaul
On 07/20/2011 01:23 PM, Jakub Jelinek wrote:
On Wed, Jul 20, 2011 at 01:07:40PM -0700, Michael Eager wrote:
I've run into a problem with this change when building microblaze-xilinx-elf.
When compiling _divdi3.o, cselib_expand_value_rtx_1 returns a huge rtx
tree for variable _r1 when max_
On 07/20/2011 01:48 PM, Jakub Jelinek wrote:
On Wed, Jul 20, 2011 at 01:28:46PM -0700, Michael Eager wrote:
On 07/20/2011 01:23 PM, Jakub Jelinek wrote:
On Wed, Jul 20, 2011 at 01:07:40PM -0700, Michael Eager wrote:
I've run into a problem with this change when building microblaze-xilin
s unlikely that different targets would have different meanings
for the macro opcodes.
--
Michael Eagerea...@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
On 07/22/2011 02:08 PM, Richard Henderson wrote:
On 07/22/2011 12:54 PM, Michael Eager wrote:
The definition of opcodes in the line number table is different from
opcodes in other tables, including a modified macro table. There
are many opcodes (essentially every possible value is used) and
On 07/22/2011 02:20 PM, Richard Henderson wrote:
On 07/22/2011 02:16 PM, Michael Eager wrote:
On 07/22/2011 02:08 PM, Richard Henderson wrote:
On 07/22/2011 12:54 PM, Michael Eager wrote:
The definition of opcodes in the line number table is different from
opcodes in other tables, including a
OFT_FLOAT;
+ opts_set->x_target_flags |= MASK_SOFT_FLOAT;
+ opts->x_rs6000_single_float = opts->x_rs6000_double_float = 0;
+ }
+ /* Fall through. */
--
Michael Eagerea...@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
Joseph S. Myers wrote:
On Thu, 5 May 2011, Michael Eager wrote:
David Edelsohn wrote:
On Wed, May 4, 2011 at 7:54 AM, Joseph S. Myers
wrote:
Two options, -mcmodel= and -mfpu=, had cases that fell through to the
next case without comments to indicate if this was intended. I added
comments
laze.c: Don't include opts.h.
(microblaze_handle_option, TARGET_HANDLE_OPTION): Remove.
* config/microblaze/microblaze.opt (mxl-stack-check): Use Warn.
(mno-clearbss): Use Var and Warn.
OK to apply.
--
Michael Eagerea...@eagercon.com
1960 Park Blvd., Palo Alto, CA
disabling it for MicroBlaze is no longer needed.
--
Michael Eagerea...@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
101 - 176 of 176 matches
Mail list logo
