Re: Add polymorphic call context propagation to ipa-prop

Hi, On Thu, Oct 02, 2014 at 09:00:12AM +0200, Jan Hubicka wrote: > Hi, > this patch makes ipa-prop to use ipa-polymorphic-call-context infrastructure > for forward propagation (in a very minimal and simple way). > > At the moment only static type info is propagated and it is used only > specula

[hsa] Simple cleanup of different offsets in hsa-gen.h

Hi, this is a very simple cleanup, renaming two fields of different classes called offset to a more descriptive name and removal of one which is no longer used. Committed to the branch. Thanks, Martin 2014-10-24 Martin Jambor * hsa.h (hsa_symbol): Renamed offset to

[hsa] Better workaround in locating the file with HSAIL

. Committed to the branch. Thanks, Martin 2014-10-24 Ganesh Gopalasubramanian Martin Jambor gcc/ * README.hsa: Removed the part about extracting the HSA ELF sections. * hsa-gen.c (wrap_hsa): Deduce the file name and pass it to libgomp. libgomp

Re: Eliminate write-only variables

On Mon, Jun 02, 2014 at 08:59:35PM +0200, Jan Hubicka wrote: > > > > Yeah, I discussed this with martin today on irc. For aliasing we'd like to > > know whether a decl possibly has its address taken. Currently we only trust > > TREE_ADDRESSABLE for statics - and lto might change those to hidden

[PATCH, PR 61340] Add default label to two switches on enum ipa_ref_use

which we cannot encounter because 1) in ipa-pure-const.c we are not processing aliases and 2) in ipa-reference.c we analyze references of a function to a variable and that cannot be an alias. OK for trunk? Thanks, Martin 2014-06-03 Martin Jambor PR ipa/61340 * ipa-pure-co

[4.8, PR 61393] Disable IPA-CP of transactional memory clones

suite testcase within a few minutes). OK for 4.8? Thanks, Martin 2014-06-04 Martin Jambor PR ipa/61393 * ipa-cp.c (determine_versionability): Pretend that tm_clones are not versionable. diff --git a/gcc/ipa-cp.c b/gcc/ipa-cp.c index d9d69b3..bd45575 100644 --- a/gcc/ipa

[4.9, PR 61393] Disable IPA-CP of transactional memory clones

06-04 Martin Jambor PR ipa/61393 * ipa-cp.c (determine_versionability): Pretend that tm_clones are not versionable. diff --git a/gcc/ipa-cp.c b/gcc/ipa-cp.c index 7fb7ae6..93b60d6 100644 --- a/gcc/ipa-cp.c +++ b/gcc/ipa-cp.c @@ -433,6 +433,8 @@ determine_versionability (s

Re: [PATCH 4/7] Break up determine_known_aggregate_parts

; > OK for trunk after the preceeding patches get in? > > > > Thanks, > > > > Martin > > > > > > 2014-02-19 Martin Jambor > > > > * ipa-prop.c (get_place_in_agg_contents_list): New function. > > (build_agg_jump_func_from

Re: [PATCH, Pointer Bounds Checker 28/x] IPA CP

Hi, On Wed, Jun 11, 2014 at 12:24:57PM +0400, Ilya Enkovich wrote: > Hi, > > This patch fixes IPA CP pass to handle instrumented code correctly. > > Bootstrapped and tested on linux-x86_64. > > Thanks, > Ilya > -- > gcc/ > > 2014-06-11 Ilya Enkovich > > * ipa-cp.c (initialize_node_la

[PATCH, PR 61186]

times). It just seemed quite a lot easier and also avoids making the same mistake elsewhere in future. Bootstrapped and tested on x86_64-linux, I have of course also verified it fixes the bug. OK for trunk? And perhaps also the 4.9 branch? Thanks, Martin 2014-06-11 Martin Jambor PR

Re: [PATCH, Pointer Bounds Checker 28/x] IPA CP

Hi, On Wed, Jun 11, 2014 at 05:47:36PM +0400, Ilya Enkovich wrote: > > Here is fixed verison. I'm fine with the ipa-cp hunks but I cannot approve them, Honza is the right person to ask. Thanks, Martin > > Thanks, > Ilya > -- > gcc/ > > 2014-06-11 Ilya Enkovich > > * cgraph.h (cgra

Re: Regimplification enhancements 3/3

On Mon, Jun 16, 2014 at 01:38:49PM +0200, Richard Biener wrote: > On Mon, Jun 16, 2014 at 12:57 PM, Bernd Schmidt > wrote: > > There's code in regimplification that makes us use an extra temporary > > when we encounter a call returning a non-BLKmode structure. This seems > > somewhat inefficient

Re: [PATCH, PR 61211] Fix a bug in clone_of_p verification

Ping. Thanks, Martin On Sat, May 31, 2014 at 12:46:03AM +0200, Martin Jambor wrote: > Hi, > > after a clone is materialized, its clone_of field is cleared which in > PR 61211 leads to a failure in the skipped_thunk path in clone_of_p in > cgraph.c, which then leads to a

Re: [PATCH, PR 61160] Artificial thunks need combined_args_to_skip

Hi, Ping. Thanks, Martin On Sat, May 31, 2014 at 01:08:31AM +0200, Martin Jambor wrote: > Hi, > > the second issue in PR 61160 is that because artificial thunks > (produced by duplicate_thunk_for_node) do not have > combined_args_to_skip, calls to them do not get actual argu

[PATCH, PR 61540] Do not ICE on impossible devirtualization

but we should not ICE). Fixed thusly. Bootstrapped and tested on x86_64-linux. OK for trunk and the 4.9 branch? Thanks, Martin 2014-06-17 Martin Jambor PR ipa/61540 * ipa-prop.c (impossible_devirt_target): New function. (try_make_edge_direct_virtual_call): Use it

Re: [PATCH, PR 61540] Do not ICE on impossible devirtualization

Hi, On Wed, Jun 18, 2014 at 06:12:34PM +0200, Bernhard Reutner-Fischer wrote: > On 18 June 2014 10:24:16 Martin Jambor wrote: > > >@@ -3002,10 +3014,8 @@ try_make_edge_direct_virtual_call (struct > >cgraph_edge *ie, > > > > if (target) > > { > >-#

Re: [PATCH] Change default for --param allow-...-data-races to off

Hi, On Thu, Jun 19, 2014 at 06:18:47PM +0200, Bernd Edlinger wrote: > Hi, > > from a recent discussion on g...@gcc.gnu.org I have learned that the default > of > --param allow-store-data-races is still 1, and it is causing problems. > Therefore I would like to suggest to change the default of th

Re: [PATCH] Trust TREE_ADDRESSABLE

Hi, On Mon, Jun 23, 2014 at 04:55:36AM +0200, Jan Hubicka wrote: > > > On Fri, 13 Jun 2014, Jan Hubicka wrote: > > > > > > > > > > > > > When you extract the address and use it. For example when you > > > > > do auto-parallelization and outline a part of your function it > > > > > passes arrays

Re: [PATCH] Change default for --param allow-...-data-races to off

. > > > > Thanks, > > Richard. > > > > OK, please go ahead with your patch. Perhaps not unsurprisingly, the patch is very similar. Bootstrapped and tested on x86_64-linux. OK for trunk? Thanks, Martin 2014-06-24 Martin Jambor * params.def (PARAM_ALLOW_LOAD_DATA_R

Re: [PATCH, PR 61540] Do not ICE on impossible devirtualization

Hi, On Mon, Jun 23, 2014 at 01:38:03PM +0100, James Greenhalgh wrote: > On Thu, Jun 19, 2014 at 12:49:55PM +0100, Martin Jambor wrote: > > Hi, > > > > On Wed, Jun 18, 2014 at 06:12:34PM +0200, Bernhard Reutner-Fischer wrote: > > > On 18 June 2014

Re: [PATCH] Change default for --param allow-...-data-races to off

Hi, On Wed, Jun 25, 2014 at 03:14:31PM -0600, Jeff Law wrote: > On 06/24/14 14:19, Martin Jambor wrote: > >On Mon, Jun 23, 2014 at 03:35:01PM +0200, Bernd Edlinger wrote: > >>Hi Martin, > >> > >>>> > >>>>Well actually, I am not su

[PATCH] Fix the "inconsident" devirtualization typo and consolidate the related code

2014-06-25 Martin Jambor * ipa-prop.c (ipa_impossible_devirt_target): No longer static, renamed to ipa_impossible_devirt_target. Fix typo. * ipa-prop.h (ipa_impossible_devirt_target): Declare. * ipa-cp.c (ipa_get_indirect_edge_target_1): Use ipa_impossible_dev

Re: [PATCH, PR 61160] Artificial thunks need combined_args_to_skip

On Sat, May 31, 2014 at 01:08:31AM +0200, Martin Jambor wrote: > Hi, > > the second issue in PR 61160 is that because artificial thunks > (produced by duplicate_thunk_for_node) do not have > combined_args_to_skip, calls to them do not get actual arguments > removed, while the a

Re: Fix alignment propagation

linux without any issues. So, OK for trunk now? Thanks, Martin On Wed, Feb 25, 2015 at 08:38:26PM +0100, Martin Jambor wrote: > Hi, > > On Fri, Feb 20, 2015 at 07:22:02PM +0100, Jan Hubicka wrote: > > > > +/* Decrease alignment info DEST to be at most CUR. */ >

[PATCH 1/3] Generalize IPA-CP lattices

and testing. The patch passes bootstrap and testing on x86_64-linux and has been privately approved by Honza. As per his request I will commit it at some point on Friday after some additional testing on ppc64-aix and 32bit i686. Thanks, Martin 2014-10-17 Martin Jambor * ipa-cp.c

[PATCH 2/3] IPA-CP propagation of polymorphic contexts

. Honza has privately approved the patch and asked me to commit it soon, so I will do that if this testing turns out OK and after some additional tests on ppc64-aix and 32bit i686-linux. Thanks, Martin 2014-11-14 Martin Jambor * ipa-prop.h (ipa_get_jf_pass_through_type_preserved): use

[PATCH 3/3] Remove known_type jump functions, type_preserved flags and more from ipa-prop

l? Thanks, Martin 2014-11-14 Martin Jambor * ipa-prop.h (jump_func_type): Removed value IPA_JF_KNOWN_TYPE. (ipa_pass_through_data): Removed field type_preserved. (ipa_ancestor_jf_data): removed fields type and type_preserved. (ipa_jump_func): Removed field

Re: [PATCH 3/4] First usage of cgraph_summary in ipa-prop pass.

Hi, On Fri, Nov 14, 2014 at 04:23:41PM +0100, Martin Liska wrote: > Patch v3. > > Martin > From 7255ffaf7bb416037baa14499b197bac3be8c222 Mon Sep 17 00:00:00 2001 > From: mliska > Date: Fri, 14 Nov 2014 16:14:28 +0100 > Subject: [PATCH 2/3] First usage of cgraph_summary in ipa-prop pass. > > gc

Re: [PATCH 4/4] Data structure is used for inline_summary struct.

On Fri, Nov 14, 2014 at 05:06:44PM +0100, Jan Hubicka wrote: > > > > > >In a way I would like to see these to be methods of the underlying type > > >rather than > > >virtual methods of the summary, becuase these are operations on the data > > >themselves. > > >I was thinking to model these by spe

[PATCH] Make IPA-CP propagate alignment information of pointers

replace this by a more fancy VRP-based IPA-CP but I think it is worth having this simple addition in 5.0. Bootstrapped and tested on x86_64-linux. OK for trunk? Thanks, Martin 2014-11-15 Martin Jambor * ipa-prop.h (ipa_alignment): New type. (ipa_jump_func): New field alignment

Re: [PATCH 4/4] Data structure is used for inline_summary struct.

On Fri, Nov 14, 2014 at 08:59:10PM +0100, Jan Hubicka wrote: > > > > > > > b) with GTY, we cannot call destructor > > > > > > Everything in symbol table is expecitely memory managed (i.e. enver left > > > to be freed by garbage collector). It resists in GTY only to allow linking > > > garbage col

Re: Fix speculation in ipa-cp

Hi, On Sun, Nov 16, 2014 at 12:56:45AM +0100, Jan Hubicka wrote: > Hi, > this patch enables propagation of speculative contextes I promised to fix > after Martin's > merge. There were few bugs that ended up disturbing testsuite: Wonderful, thanks a lot. > > 1) ipa_polymorphic_call_context::co

Re: [PATCH 4/4] Data structure is used for inline_summary struct.

Hi, On Tue, Nov 18, 2014 at 04:39:00PM +0100, Jan Hubicka wrote: > > On Fri, Nov 14, 2014 at 08:59:10PM +0100, Jan Hubicka wrote: > > > > > > > > > > > b) with GTY, we cannot call destructor > > > > > > > > > > Everything in symbol table is expecitely memory managed (i.e. enver > > > > > left >

Re: [PATCH 4/4] Data structure is used for inline_summary struct.

On Tue, Nov 18, 2014 at 07:59:26PM +0100, Jan Hubicka wrote: > > Hi, > > > > On Tue, Nov 18, 2014 at 04:39:00PM +0100, Jan Hubicka wrote: > > > > On Fri, Nov 14, 2014 at 08:59:10PM +0100, Jan Hubicka wrote: > > > > > > > > > > > > > > > b) with GTY, we cannot call destructor > > > > > > > > > >

Re: Audit some ipa passes for optimization attribute

On Tue, Nov 18, 2014 at 09:48:52PM +0100, Jan Hubicka wrote: > Hi, > this patch goes through most of ipa passes: ipa-devirt, ipa-cp, > ipa-pure-const, > ipa-profile and ipa-inline and audits them for opt_for_fn. > I did not converted yet ipa-reference because the code is organized in a way > makin

Re: [PATCH] Make IPA-CP propagate alignment information of pointers

Hi, On Mon, Nov 17, 2014 at 01:05:23PM +0100, Richard Biener wrote: > On Sat, Nov 15, 2014 at 2:04 AM, Martin Jambor wrote: > > Hi, > > > > this patch adds very simple propagation of alignment of pointers to > > IPA-CP. Because I have not attempted to estimat

Re: SRA: don't drop clobbers

Hi, On Mon, Nov 03, 2014 at 10:46:49PM +0100, Marc Glisse wrote: > On Mon, 3 Nov 2014, Marc Glisse wrote: > > >On Mon, 3 Nov 2014, Martin Jambor wrote: > > > >>I just applied your patch on top of trunk revision 217032 on my > > > >Ah, that explains i

[PATCH 1/2, PR 63814] Strengthen cgraph_edge_brings_value_p

where the value is supposed to go and can check that it goes there and not anywhere else. It also adds an extra availability check that was probably missing in it. Bootstrapped and tested on x86_64-linux, and i686-linux. OK for trunk? Thanks, Martin 2014-11-20 Martin Jambor PR ipa

[PATCH 2/2, PR 63814] Do not re-create expanded artificial thunks

uses the flag to identify such expanded thunks. Bootstrapped and tested on x86_64-linux and i686-linux. Honza, do you think this is a good approach? Is the patch OK for trunk? Thanks, Martin 2014-11-21 Martin Jambor * cgraph.h (cgraph_thunk_info): Converted thunk_p to a bit-field

[PATCH, PR 63551] Use proper type in evaluate_conditions_for_known_args

value is taken from the corresponding gimple_cond statement in which types must match. Bootstrapped and tested on x86_64-linux. OK for trunk? Thanks, Martin 2014-11-21 Martin Jambor PR ipa/63551 * ipa-inline-analysis.c (evaluate_conditions_for_known_args): Convert

Re: [PATCH, PR 63551] Use proper type in evaluate_conditions_for_known_args

On Fri, Nov 21, 2014 at 09:07:50PM +0100, Martin Jambor wrote: > Hi, > > the testcase of PR 63551 passes a union between a signed and an > unsigned integer between two functions as a parameter. The caller > initializes to an unsigned integer with the highest order bit set, the >

Re: [PATCH, PR 63551] Use proper type in evaluate_conditions_for_known_args

Hi, On Fri, Nov 21, 2014 at 09:18:03PM +0100, Richard Biener wrote: > On November 21, 2014 9:07:50 PM CET, Martin Jambor wrote: > >the testcase of PR 63551 passes a union between a signed and an > >unsigned integer between two functions as a parameter. The caller > >initi

Re: [PATCH, PR 63551] Use proper type in evaluate_conditions_for_known_args

On Sat, Nov 22, 2014 at 07:36:59PM +0100, Richard Biener wrote: > On November 22, 2014 12:45:58 PM CET, Jakub Jelinek wrote: > >On Sat, Nov 22, 2014 at 12:09:46PM +0100, Martin Jambor wrote: > >> 2014-11-21 Martin Jambor > >> > >>PR ipa/6

Re: [PATCH 2/2, PR 63814] Do not re-create expanded artificial thunks

Ping. Thx, Martin On Fri, Nov 21, 2014 at 08:18:12PM +0100, Martin Jambor wrote: > Hi, > > when debugging PR 63814 I noticed that when cgraph_node::create_clone > was using redirect_edge_duplicating_thunks to redirect two edges to a > thunk of a clone, two thunks were create

Re: [PATCH 1/2, PR 63814] Strengthen cgraph_edge_brings_value_p

Ping. Thx, Martin On Fri, Nov 21, 2014 at 07:59:11PM +0100, Martin Jambor wrote: > Hi, > > PR 63814 is caused by cgraph_edge_brings_value_p misidentifying an > edge to an expanded artificial thunk as an edge to the original node, > which then leads to crazy double-cloning a

Re: [PATCH] Make IPA-CP propagate alignment information of pointers

Ping (this is a new feature submitted in stage1 so I'd really appreciate a review before it is going to be deemed "too late"). Thanks, Martin On Wed, Nov 19, 2014 at 12:32:53AM +0100, Martin Jambor wrote: > Hi, > ... > > 2014-11-19 Martin Jambor > >

Re: [PATCH] Make IPA-CP propagate alignment information of pointers

Hi, thanks for the comments. On Mon, Dec 01, 2014 at 11:40:59PM +0100, Jan Hubicka wrote: > > > 2014-11-19 Martin Jambor > > > > > > * ipa-prop.h (ipa_alignment): New type. > > > (ipa_jump_func): New field alignment. > >

Re: [PATCH 2/2, PR 63814] Do not re-create expanded artificial thunks

Hi, On Mon, Dec 01, 2014 at 10:43:19PM +0100, Jan Hubicka wrote: > > On Fri, Nov 21, 2014 at 08:18:12PM +0100, Martin Jambor wrote: > > > Hi, > > > > > > when debugging PR 63814 I noticed that when cgraph_node::create_clone > > > was using redirect_edg

[PATCH, PR 64153] Check type sizes before V_C_Eing in evaluate_conditions_for_known_args

generated assembly is the same as before the commit which introduced the problem). OK for trunk and (after a bootstrap and testing there) the 4.9 branch? Thanks, Martin 2014-12-02 Martin Jambor PR ipa/64153 * ipa-inline-analysis.c (evaluate_conditions_for_known_args): Check

Re: [patch] Fix ICE on unaligned record field

e not double checked that get_inner_reference is cfun-agnostic. Hope it helps, Martin 2014-12-03 Martin Jambor * tree-sra.c (ipa_sra_check_caller_data): New type. (has_caller_p): Removed. (ipa_sra_check_caller): New function. (ipa_sra_preliminary_function_chec

Re: [PATCH] Make IPA-CP propagate alignment information of pointers

Hi, thank you very much for pointing out all the spelling mistakes. I suppose you could tell I was writing this in a hurry :-) Nevertheless I should probably make a habit of spell checking stuff before sending it out. As far as your question is concerned: On Wed, Dec 03, 2014 at 10:53:54AM +0

[wwwdocs] List IPA-CP of alignments in changes.html

Hi, I'd like to commit the following to gcc-5/changes.html so that IPA-CP alignment propagation is listed among other new features. OK? Thanks, Martin Index: changes.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-5/changes.html,v

Re: [patch] Fix ICE on unaligned record field

lier, but today I have re-bootstrapped the following (the only change is the added testcase) on x86_64-linux and it passes OK. Should I commit it to trunk then? Thanks, Martin 2015-02-25 Martin Jambor Eric Botcazou gcc/ * tree-sra.c (ipa_sra_check_caller_data):

[hsa] Do not ICE when regallocating function with zero pseudoregisters

after rudimentary testing. Thanks, Martin 2015-02-25 Martin Jambor * hsa-regalloc.c (regalloc): Bail out if there are no registers. diff --git a/gcc/hsa-regalloc.c b/gcc/hsa-regalloc.c index 94c88dc..8f0b4bb 100644 --- a/gcc/hsa-regalloc.c +++ b/gcc/hsa-regalloc.c @@ -745,6 +745,10

Re: Fix alignment propagation

y there will be comments I'll need to incorporate, but I would like to commit this soon to avoid the confusion the multiple uses of ipa_alignment structure apparently caused. Thanks, Martin 2015-02-25 Martin Jambor Jan Hubicka * ipa-cp.c (ipcp_alignment_lattice): N

Re: ipa-cp heuristic tweek

Hi, On Sun, Mar 29, 2015 at 05:43:20PM +0200, Jan Hubicka wrote: > Hi, thanks for committing the patch, I'm just wondering why... > this patch improve crafty performance by avoiding ipa-cp clonning of > Search function that specializes the first iteration of the recursion. > The patch is by Mart

[hsa] Integrate into the existing accelerator framework, libgomp plugin

the branch as well as on corresponding trunk revision. I'm looking forward to any comments and suggestions, meanwhile I have committed the patch to the branch as r224284. Thanks, Martin 2015-06-09 Martin Jambor libgomp/ * Makefile.in: Regenerated. * config.h.in: Lik

[PATCH] Fix PR 66301

it did not seem worth reducing. OK for trunk and the 5 branch? Martin diff --git a/gcc/ChangeLog.mine b/gcc/ChangeLog.mine new file mode 100644 index 000..a26c4d4 --- /dev/null +++ b/gcc/ChangeLog.mine @@ -0,0 +1,6 @@ +2015-06-11 Martin Jambor + + PR debug/66301 + * tree-ssa

Re: New type-based pool allocator code miscompiled due to aliasing issue?

Hi, On Tue, Jun 16, 2015 at 05:31:57PM +0200, Martin Liska wrote: > On 06/16/2015 04:02 PM, Richard Biener wrote: > > On Tue, Jun 16, 2015 at 3:38 PM, Martin Liška wrote: ... > >> Do you mean Richard following changes: > >> > >> alloc-pool.h (allocate): > >> ... > >> + /* Placement new contruc

[hsa] Support for vector immediates

Hi, the patch below adds support for HSA vector immediates and instructions storing them directly to memory, which was hitherto missing on the branch. Committed as r224554. Thanks, Martin 2015-06-16 Martin Jambor * hsa-brig.c (hsa_get_imm_brig_type_len): New function

[hsa] Move some stuff from hsa-gen.c to new file hsa.c

Hi, Some functionality does not belong neither to hsa-gen.c not to hsa-brig.c and there is enough of it to warrant a separate file. This is the initial movement of such things to a new file hsa.c. Martin 2015-06-18 Martin Jambor * hsa.c: New file. * Makefile.in (OBJS): Add

[hsa] Switch from bittype_for_type to hsa_type_bit_size

Hi, except for one use, from bittype_for_type was used as a poor-man's type size function. That is confusing, so I added a real type size function. The new implementation of hsa_bittype_for_type then uses that as its basis too. Martin 2015-06-18 Martin Jambor *

[hsa] Support for local aggregate variables

arrays, records as arrays of bytes. Martin 2015-06-19 Martin Jambor * hsa-gen.c (hsa_type_for_scalar_tree_type): Use hsa_get_segment_addr_type. Assert type is not scalar. Rename last argument. (hsa_type_for_tree_type): Handle aggregates. Return dimension in

[hsa] Unify two copies of hsa_sanitize_name

Hi, sanitize_hsa_name attracted my attention because it had no comment but then I found out we had two copies of the function in two different files. So I moved the definition to hsa.c. Martin 2015-06-19 Martin Jambor * hsa.c (hsa_sanitize_name): Moved here from... * hsa

[hsa] Fix spelling and coding style errors

Hi, I've run comments through spell-checker, added a few missing comments and also fixed some other coding-style errors such as lines exceeding 80 characters. Martin 2015-06-19 Martin Jambor * hsa.h: Fixed spelling and coding style errors, added missing com

[hsa] Unify two implementations of hsa_type_float_p

Hi, hsa_type_float_p is another function that we had implemented twice on the HSA branch, unified thusly. Martin 2015-06-19 Martin Jambor * hsa-brig.c (float_type_p): Moved from here... * hsa-gen.c (hsa_type_float_p): ...and here... * hsa.c (hsa_type_float_p): ...to

Cleanup of hsa_spill_out

Hi, hsa_spill_out appends two HSA instructions after another one and is not the last function that is going to do that, so I factored that code out. I also updated the comment to fit reality. Conversly for hsa_insert_insn_before and hsa_spill_in. Martin 2015-06-19 Martin Jambor

[hsa] C++ification of operands and instructions

which will change how we do some necessary destruction of the HSAIL representation soon. Thanks, Martin 2015-06-26 Martin Jambor * hsa.h (hsa_bb): Made a class with constructors, destructor and a new operator. (hsa_function_representation): Turned into a class, added

Re: [RFC, PATCH] Split pool_allocator and create a new object_allocator

Hi, On Fri, Jul 03, 2015 at 09:55:58AM +0100, Richard Sandiford wrote: > Trevor Saunders writes: > > On Thu, Jul 02, 2015 at 09:09:31PM +0100, Richard Sandiford wrote: > >> Martin Liška writes: > >> > diff --git a/gcc/asan.c b/gcc/asan.c > >> > index e89817e..dabd6f1 100644 > >> > --- a/gcc/asan

Re: [PATCH, testcase, committed] Exit with zero status from g++.dg/ipa/pr61160-3.C

+0200, Martin Jambor wrote: > Hi, > > in order to avoid spurious testsuite failures, I've checked in the > following obvious patch so that the testcase always returns zero. I > have verified it still properly tests for non-existence of the bug. > > Thanks, > >

Re: [PATCH][RFC][OpenMP] Forbid target* pragmas in target regions

Hi, On Mon, Jan 12, 2015 at 12:22:44AM +0300, Ilya Verbin wrote: > Hi! > > Currently if a target* pragma appears within a target region, GCC successfully > compiles such code (with a warning). But the binary fails at run-time, since > it > tries to call GOMP_target* functions on target. > > Th

Re: Fix alignment propagation

Hi, On Fri, Feb 20, 2015 at 06:16:47AM +0100, Jan Hubicka wrote: > > ... > > This is followup patch that also fixes ;; issue. > It makes the alignment propagation to do proper lattice operations instead > of requiring perfect match and dropping everything to bottom otherwise. > Martin, does it lo

[hsa] Reimplementation of expansion of memory references to HSA

our friends at AMD. Thanks, Martin 2015-02-20 Martin Jambor * hsa.h (hsa_op_with_type): New type. (hsa_op_immed): Base on hsa_op_with_type. (hsa_op_reg): Likewise. Removed the type field. * hsa-gen.c (hsa_reg_for_gimple_ssa_reqtype): New function

Re: SRA: don't drop clobbers

Hi, On Mon, Nov 03, 2014 at 01:59:24PM +0100, Marc Glisse wrote: > Hello, > > now that the update_address_taken patch is in, let me re-post the > SRA follow-up. With this patch, testcase pr60517.C (attached) has a > use of an undefined variable at the time of the uninit pass. Sadly, > while this

Re: SRA: don't drop clobbers

Hi, On Mon, Nov 03, 2014 at 05:17:22PM +0100, Marc Glisse wrote: > On Mon, 3 Nov 2014, Martin Jambor wrote: > >On Mon, Nov 03, 2014 at 01:59:24PM +0100, Marc Glisse wrote: > >> > >>now that the update_address_taken patch is in, let me re-post the > >>SRA

[PATCH] Fix dump scan in test devirt-40.C

y. Thanks, Martin gcc/testsuite/ 2014-11-04 Martin Jambor * devirt-40.C: Changed dump to not matching OBJ_TYPE_REF in function body. Index: src/gcc/testsuite/g++.dg/ipa/devirt-40.C === --- src.orig/gcc/testsuite/

Re: [PATCH] Fix dump scan in test devirt-40.C

On Tue, Nov 04, 2014 at 04:47:18PM +0100, Richard Biener wrote: > On Tue, Nov 4, 2014 at 4:37 PM, Martin Jambor wrote: > > Hi, > > > > since revision 216728, testsuite/g++.dg/ipa/devirt-40.C is failing > > because although the tested-for devirtualization does happen, it

Re: [debug-early] emit locals early patchset

On Tue, Oct 28, 2014 at 03:57:43PM +0100, Richard Biener wrote: > On Tue, Oct 28, 2014 at 1:00 AM, Aldy Hernandez wrote: > > Gentlemen! > > > > My apologies for the big patch. In getting locals emitted early (parameters > > and locally scoped variables), I ran into many things which were in need

[PATCH, testsuite, obvious] Do not produce optimized dump in devirt-4[45].C

Hi, g++.dg/ipa/devirt-44.C and g++.dg/ipa/devirt-45.C leave behind an optimized dump which they don't even use. Fixed thusly, tested by runing make -k check RUNTESTFLAGS="dg.exp=ipa/*.C", will commit shortly as obvious. Thanks, Martin 2014-11-06 Martin Jambor * g+

[PATCH] Reset contexts in possible_polymorphic_call_targets properly

outer_type(otr_type) instead, which I believe is the proper way of doing it. However, I had to make that method public to do so. Bootstrapped and tested on x86_64-linux. OK for trunk? Thanks, Martin 2014-11-08 Martin Jambor * cgraph.h (clear_outer_type): Make public. Fix comment.

Re: [PATCH] Handle loop fields in IPA ICF (PR ipa/90555).

Hi, On Tue, May 28 2019, Jakub Jelinek wrote: > On Tue, May 28, 2019 at 01:29:54PM +0200, Martin Liška wrote: >> Yes, makes sense. >> >> Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ok, thanks. > >> > BTW, unrelated to this patch, what does ICF do if e.g. SSA_NAME_PT

Re: Teach same_types_for_tbaa to structurally compare arrays, pointers and vectors

;> > I see no reason why we should not constant propagate the return value. >> >> Indeed a good example. Make it work and add it to the testsuite ;) > > I think Martin Jambor is working on it. One needs -fno-tree-sra to > get this optimized :) > Othewise we punt

Re: Teach same_types_for_tbaa to structurally compare arrays, pointers and vectors

Hi, (now even including gcc-patches mailing list which we managed to drop again and Honza whom I forgot to CC the last time) On Thu, Jun 06 2019, Richard Biener wrote: > yOn Tue, 4 Jun 2019, Martin Jambor wrote: >> >> @@ -1822,9 +1863,19 @@ build_ref_for_model (location_t

Re: [PATCH V4] Find constant definition for by-ref argument using dominance information (PR ipa/90401)

Hi, On Thu, Jun 13 2019, Richard Biener wrote: > On Tue, Jun 11, 2019 at 4:22 AM Feng Xue OS > wrote: >> >> > For future reference, there should be two spaces at the end of the sentence >> > before */. You can use gcc/contrib/check_GNU_style.sh foo.patch to catch >> > stuff like this before pos

[PR 90889] Fix IPA-CP topological sorting

m now running LTO bootstrap and testing with all languages, OK if it passes? Thanks, Martin 2019-06-17 Martin Jambor PR ipa/90889 * ipa-cp.c (ignore_edge_p): Do not ignore edges when only the caller does not have flag_ipa_cp set. --- gcc/ipa-cp.c | 1 - 1 file chang

Re: [PING v2][PATCH] Make function clone name numbering independent.

Hi, On Tue, Sep 04 2018, Michael Ploujnikov wrote: > > I've tried building with numbered_clone_function_name replaced by > suffixed_function_name and with --enable-offload-targets=hsa and > didn't see any errors in gomp.exp. I don't have a readily available > HSA setup so if you could do a quick t

[PR 87615] Limit AA walking in hopefully all of IPA summary generation

os in -ftime-reportbut we still do not reach the 40 second compile time we get with -fno-ipa-cp -fno-inline. Bootstrapped and tested on x86_64-linux. OK for trunk? Thanks, Martin 2018-12-06 Martin Jambor PR ipa/87615 * ipa-prop.h (struct ipa_func_body_info): Replaced field aa_w

[PR 88214] Check that an argument is pointer before attempting agg jf construction from it

is simple enough that I believe that is good enough. 2018-12-06 Martin Jambor PR ipa/88214 * ipa-prop.c (determine_locally_known_aggregate_parts): Make sure we check pointers against pointers. testsuite/ * gcc.dg/ipa/pr88214.c: New test. --- gcc/

Re: [PATCH] error on missing LTO symbols

Hi, On Fri, Dec 14 2018, Jakub Jelinek wrote: > On Fri, Dec 14, 2018 at 10:21:35AM +0100, Tom de Vries wrote: >> --- /dev/null >> +++ b/libgomp/testsuite/libgomp.c-c++-common/variable-not-offloaded.c >> @@ -0,0 +1,21 @@ >> +/* { dg-do link } */ >> +/* { dg-excess-errors "lto1, mkoffload and lto-wr

Re: [PR 88214] Check that an argument is pointer before attempting agg jf construction from it

Hi, On Mon, Dec 10 2018, Richard Biener wrote: > On Fri, Dec 7, 2018 at 3:59 PM Martin Jambor wrote: >> ... >> >> On a related note, would people object to adding the following assert, >> which would have made this bug much more straightforward to find? > > Tha

Re: [PR 87615] Limit AA walking in hopefully all of IPA summary generation

Hi, Ping: On Fri, Dec 07 2018, Martin Jambor wrote: Hi, the patch below adds alias analysis (AA) walk limiting to all walk_alias_vdefs calls invoked as IPA-CP and ipa-fnsummary summary generation. Eventually the two should be unified into just one phase but that is something for stage1. This

[PATCH] Avoid carrying around jump functions with no information

2018-12-20 Martin Jambor * ipa-prop.c (determine_locally_known_aggregate_parts): Return true iff any aggregate value has been discovered. (ipa_compute_jump_functions_for_edge): Assert that jump_functions have not been already calculated, use vec_safe_reserve_exact to

Subject: [PATCH] [PR 89330] Remove non-useful speculations from new_edges

expect. That latter change requires disabling speculation on a testcase through adding -fno-profile-values, otherwise a devirtualziation happens before it is dump-scanned for. Bootstrapped and tested on an x86_64-linux, OK for trunk? Thanks, Martin 2019-07-25 Martin Jambor PR ipa

Re: [PATCH] Builtin function roundeven folding implementation

Hi Joseph, can you please have look at this patch from Tejas, whether it is perhaps ready to be committed to trunk or what things still need to be addressed? Thanks a lot, Martin On Fri, Jun 28 2019, Tejas Joshi wrote: > Hi. > This patch includes implementation of new function roundeven along

Re: [PATCH] Detect not-cloned new/delete operators in DCE.

Hi, unfortunately I cannot look into the problem now and I don't have my phone set up to review patches in a sane way, but to answer your question below... On Tue, Aug 06 2019, Martin Liška wrote: > On 8/6/19 2:42 PM, Martin Liška wrote: ... >> Hm, strange that the ISRA clones don't have n->cl

Re: [PATCH] Builtin function roundeven folding implementation

Hi Tejas, On Wed, Aug 14 2019, Tejas Joshi wrote: > Hi. > Here is a clean patch that does not fold roundeven resulting for > integer type and the conditions for folding functions > round/ceil/floor/roundeven and trunc only checks for signaling NaN. wouldn't checking for *signalling* NaNs mean usi

[PATCH 0/4] True IPA reimplementation of IPA-SRA (v4)

rm/ipa-sra). Thanks in advance for any questions, comments and suggestions, Martin 2019-08-20 Martin Jambor * coretypes.h (cgraph_edge): Declare. * ipa-param-manipulation.c: Rewrite. * ipa-param-manipulation.h: Likewise. * Makefile.in (GTFILES): Added ipa-param-mani

[PATCH 1/4] Remove old IPA-SRA, introduce tree-sra.h

This patch removes the old IPA-SRA. Please see the covert letter for more information about the whole patch-set. Martin 2019-07-23 Martin Jambor * dbgcnt.def: Remove eipa_sra. * passes.def: Remove old IPA-SRA. * tree-pass.h (make_pass_early_ipa_sra): Remove

[PATCH 3/4] New IPA-SRA implementation

the whole patch-set for more information. This is mostly only a rebase on the current trunk of the earlier submission, the only functional change is that the pass does not clone when all the work (unused parameter removal) has already been done by IPA-CP. Martin 2019-08-20 Martin Jambor

[PATCH 4/4] Modifications to the testsuite

n the options of an LTO testcase, that is the only change compared to the previous submission. Martin 2019-08-20 Martin Jambor * g++.dg/ipa/pr81248.C: Adjust dg-options and dump-scan. * gcc.dg/ipa/ipa-sra-1.c: Likewise. * gcc.dg/ipa/ipa-sra-10.c: Likewise. * gcc.dg/ip

<    4   5   6   7   8   9   10   11   12   13   >