[PATCH] ipa: Fix double reference-count decrements for the same edge (PR 107769, PR 109318)

and testing and LTO bootstrap on an x86_64. I will commit it to master after rebasing in a few moments (and then to the gcc-12 branch in a week or so). Thanks, Martin gcc/ChangeLog: 2023-04-14 Martin Jambor PR ipa/107769 PR ipa/109318 * cgraph.h (symtab_node

[PATCH] [C] Warn when calculating abs(unsigned_value)

moment is implicit), if someone really used it for some bit-tricks. Bootstrapped and tested on x86_64-linux, also with make info. What do you think, is this a good idea? Is it perhaps OK for trunk? Thanks, Martin 2018-08-14 Martin Jambor * doc/invoke.texi (Warning Options): Document

Re: [PATCH] Add -Wabsolute-value

Hi On Wed, Aug 15 2018, Eric Gallager wrote: > On 8/14/18, Joseph Myers wrote: >> On Tue, 14 Aug 2018, Martin Jambor wrote: >> >>> when you try compiling a call to function abs and provide an unsigned >>> int in the argument in C++, you will get an error ab

[PATCH] Fix thinko in estimate_local_effects in IPA-CP

ffect SPEC 2006 and 2017 -Ofast. OK for trunk? Thanks, Martin 2018-08-23 Martin Jambor * ipa-cp.c (estimate_local_effects): Replace wrong MAX with MIN. --- gcc/ipa-cp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/ipa-cp.c b/gcc/ipa-cp.c index 42dd4cc2904..2

Re: [PATCH] Add -Wabsolute-value

Hi, thank you very much for your comments. On Fri, Aug 24 2018, Joseph Myers wrote: > On Fri, 24 Aug 2018, Martin Jambor wrote: > >> +/* Assuming we have encountered a call to a probably wrong kind of abs, >> issue a >> + warning. LOC is the location of the

Re: [PING v2][PATCH] Make function clone name numbering independent.

Hi, On Fri, Aug 31 2018, Michael Ploujnikov wrote: > I've done some more digging into the current uses of > numbered_clone_function_name and checked if any tests fail if I change > it to suffixed_function_name: > > - gcc/cgraphclones.c: DECL_NAME (new_decl) = numbered_clone_function_name > (th

Re: [PING v2][PATCH] Make function clone name numbering independent.

Hi, On Mon, Sep 03 2018, Richard Biener wrote: > On Mon, Sep 3, 2018 at 12:02 PM Martin Jambor wrote: >> >> Hi, >> >> On Fri, Aug 31 2018, Michael Ploujnikov wrote: >> > I've done some more digging into the current uses of >> > numbered_clon

Re: [PATCH] Add -Wabsolute-value

Hi, On Fri, Aug 31 2018, Joseph Myers wrote: > On Fri, 31 Aug 2018, Martin Jambor wrote: > >> diff --git a/gcc/common.opt b/gcc/common.opt >> index ebc3ef43ce2..2950760fb2a 100644 >> --- a/gcc/common.opt >> +++ b/gcc/common.opt >> @@ -815,6 +815,10 @@ Wvector-

[PATCH] Trivial fix in dump_access_tree_1

). Thanks, Martin 2017-06-12 Martin Jambor * tree-sra.c (dump_access_tree_1): Fix accidental dumping to stderr instead of f. --- gcc/tree-sra.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/tree-sra.c b/gcc/tree-sra.c index f25818f4481..42879adbad1

[PR80803 1/2] Streamline SRA access enqueuing

Go), powerpc64le-linux (all languages except Ada but including Go) and Aarch64-linux (the same). OK for trunk? Thanks, Martin 2017-06-08 Martin Jambor * tree-sra.c (add_access_to_work_queue): Only enqueue accesses that have a first_link. (sort_and_splice_var_accesses): Do

[PR80803 2/2] Diligent queuing in SRA grp_write prop

Martin Jambor PR tree-optimization/80803 PR tree-optimization/81063 * tree-sra.c (subtree_mark_written_and_enqueue): Move up in the file. (propagate_subaccesses_across_link): Enqueue subtree whneve necessary instead of relying on the caller. testsuite

[PATCH 1/2] Moving parameter manipulation into its own file

08-23 Martin Jambor * ipa-param-manipulation.c: New file. * ipa-param-manipulation.h: Likewise. * Makefile.in (OBJS): Add ipa-param-manipulation.o. (PLUGIN_HEADERS): Addded ipa-param-manipulation.h * ipa-param.h (ipa_parm_op): Moved to ipa-param-manipulat

[PATCH 2/2] Reimplementation of param-manipulation

now in GC memory, which will be necessary once they are attached to call graph but now it is just useless. It is not a lot of memory though. In any event, this patch also passes bootstrap and testing on x86_64-linux. Thanks, Martin 2017-11-07 Martin Jambor * ipa-param

Re: [RFC, PR 80689] Copy small aggregates element-wise

will get back to this matter next week at the latest. On Fri, Nov 03, 2017 at 05:38:30PM +0100, Martin Jambor wrote: > ... > > Anyway, here are the numbers. They were taken on two different > Zen-based machines. I am also in the process of measuring at least > something on a

Re: [RFC][PATCH] Extend DCE to remove unnecessary new/delete-pairs

On Tue, Nov 21 2017, Jeff Law wrote: > On 11/21/2017 04:14 AM, Dominik Inführ wrote: >> Hi, >> >> this patch tries to extend tree-ssa-dce.c to remove unnecessary >> new/delete-pairs (it already does that for malloc/free). Clang does it too >> and it seems to be allowed by >> http://www.open-std

Re: [RFC, PR 80689] Copy small aggregates element-wise

testcase, I agree that is a fairly big problem. Do you think that the following (untested) patch is an appropriate way of fixing it and generally of extending gimple to capture that a statement is a bit-copy? If so, I'll add the testcase, bootstrap it and formally propose it.

Re: [RFC, PR 80689] Copy small aggregates element-wise

Hi Richi, On Fri, Nov 24 2017, Richard Biener wrote: > On Fri, Nov 24, 2017 at 11:57 AM, Richard Biener > wrote: >> On Fri, Nov 24, 2017 at 11:31 AM, Richard Biener .. > And yes, I've been worried about SRA as well here... it _does_ > have some early outs when seeing VIEW_CONVERT_EXPR

Re: [RFC, PR 80689] Copy small aggregates element-wise

On Fri, Nov 24 2017, Richard Biener wrote: > On Fri, Nov 24, 2017 at 12:53 PM, Martin Jambor wrote: >> Hi Richi, >> >> On Fri, Nov 24 2017, Richard Biener wrote: >>> On Fri, Nov 24, 2017 at 11:57 AM, Richard Biener >>> wrote: >>>&g

[PR 81248] Fix ipa-sra size check

stage 1, and that should fix this issue, among others. The patch has passed bootstrap and testing on x86_64-linux, OK for trunk? Thanks, Martin 2017-11-23 Martin Jambor PR tree-optimization/81248 * tree-sra.c (splice_param_accesses): Remove size check

[PR 82808] Use result types for arithmetic jump functions

al with it by only going forward if we know the operation at hand does not change type. I have added a special predicate for this purpose to tree.c but I am opened to suggestions for better place or name or how/whether to integrate them to gimple verifier. Bootstrapped and tested on x86_6

Re: [PR 82808] Use result types for arithmetic jump functions

Hi, On Tue, Nov 28 2017, Richard Biener wrote: > On Tue, Nov 28, 2017 at 12:35 AM, Martin Jambor wrote: ... >> index 7efd644fb27..2a25c657f8b 100644 >> --- a/gcc/tree.c >> +++ b/gcc/tree.c >> @@ -13893,6 +13893,52 @@ arg_size_in_bytes (const_tree type) >

Re: [PR 82808] Use result types for arithmetic jump functions

On Tue, Nov 28 2017, Martin Jambor wrote: > ... > > Done, this is what I have just committed. I will prepare a conservative > fix for gcc 7 with only the expr_type_first_operand_type_p part. > The following is what I have committed to the gcc-7-branch after a round of bootstrap an

[PR 83141] Prevent SRA from removing type changing assignment

arization in vain. This is also tested by the dump scan in the added testcase. A very similar patch has passed bootstrap and testing on x86_64, this exact one is undergoing both now. OK for trunk if it passes too? Thanks, Martin 2017-12-04 Martin Jambor PR tree-optimizatio

Re: [PR 83141] Prevent SRA from removing type changing assignment

On Tue, Dec 05 2017, Martin Jambor wrote: Hi, > Hi, > > this is a followup to Richi's > https://gcc.gnu.org/ml/gcc-patches/2017-11/msg02396.html to fix PR > 83141. The basic idea is simple, be just as conservative about type > changing MEM_REFs as we are about actual VCEs.

Re: [PR 83141] Prevent SRA from removing type changing assignment

On Tue, Dec 05 2017, Martin Jambor wrote: > On Tue, Dec 05 2017, Martin Jambor wrote: > Hi, > >> Hi, >> >> this is a followup to Richi's >> https://gcc.gnu.org/ml/gcc-patches/2017-11/msg02396.html to fix PR >> 83141. The basic idea is simple, be

Re: [PR 83141] Prevent SRA from removing type changing assignment

Hi, On Tue, Dec 05 2017, Richard Biener wrote: > On Tue, 5 Dec 2017, Martin Jambor wrote: > >> On Tue, Dec 05 2017, Martin Jambor wrote: >> > On Tue, Dec 05 2017, Martin Jambor wrote: >> > Hi, >> > >> >> Hi, >> >> >> >>

Re: [PATCH] Fix 2 typos

Hi, On Fri, Dec 08 2017, Jakub Jelinek wrote: > Hi! > > There is no get_base_ref_and_offset function and AFAIK never has been, > my guess is these comments meant get_ref_base_and_extent. I am quite sure that is the case. > Ok for trunk? Well, my opinion is that it obviously is. Thanks, Marti

[PR 81616] Deferring FMA transformations in tight loops

d run-times of all benchmarks in SPEC 2006 FP and SPEC 2017 FPrate and the only changes are the big improvements of calculix and parest. After I address any comments and/or suggestions, would it be OK for trunk? Thanks, Martin 2017-12-13 Martin Jambor PR target/81616

[PR 82027] Also stream opt_info of former_clones

rapped and tested on x86_64-linux, I will attempt an LTO bootstrap overnight, OK for trunk, gcc 7 and gcc 6 if it passes? Thanks, Martin 2017-12-21 Martin Jambor PR lto/82027 * lto-cgraph.c (output_cgraph_opt_summary_p): Also check former clones. testsuite/ *

Re: [PR 81616] Deferring FMA transformations in tight loops

Hi, On Mon, Dec 18 2017, Richard Biener wrote: > On Fri, Dec 15, 2017 at 3:19 PM, Martin Jambor wrote: >> >> Hello, >> >> the patch below prevents creation if fused-multiply-and-add instructions >> in the widening_mul gimple pass on the Zen-based AMD CPUs and as

Re: [PATCH 04/14] Add {symbol,call}_summary::get method and use it in HSA.

write_summary): Likewise. >> * symbol-summary.h (symtab_duplication): Use ::get function/ >> (get): New function. > > OK if Martin (Jambor) is happy with HSA changes :) > I assume this is the version which I have tested for Martin (and which passed all tests). So OK from me too. Thanks, Martin

Re: [PATCH 08/14] Convert IPA CP to symbol_summary.

nsformation. >> (class ipcp_transformation_t): New function summary. >> (ipcp_get_transformation_summary): Use ipcp_transformation_sum. >> (ipa_get_agg_replacements_for_node): Likewise. > > I will delegate this one to Martin Jambor. it looks fine to me in genera

Re: [PATCH 11/14] Port IPA CP to edge_clone_summaries.

): Likewise. >> (ipcp_driver): Initialize edge_clone_summaries and do not >> register hooks. > > I will be happy to leave this one to Martin Jambor as well. Looks fine to me > :) > As I wrote yesterday, I'm fine with all IPA-CP/ipa-prop bits in the series (assuming it did not substantially change since the last time I saw it). Martin

Re: [PATCH 03/14] Rename get methods in symbol-summary.h to get_create.

et): Likewise. >> * ipa-prop.h (IPA_NODE_REF): Likewise. >> (IPA_EDGE_REF): Likewise. >> * ipa-pure-const.c (malloc_candidate_p): Likewise. >> (propagate_malloc): Likewise. >> * ipa-split.c (execute_split_functions): Likewise. >> * symbol-s

Re: [PATCH 1/N] Clean-up usage of ipa_fn_summary and ipa_call_summary summaries.

Hi, On Fri, Jun 15 2018, Martin Liška wrote: > Hi. > > This is first part of IPA summary conversion clean-up. It removes > ::get_create and > uses ::get for ipa-inline related symbol (and call) summaries. I'm planning to > investigate also other summaries. > > Patch can bootstrap on x86_64-linux-

Re: RFA: Sanitize deprecation messages (PR 84195)

Hi Nick, On Fri, Feb 16 2018, Nick Clifton wrote: > Hi David, > > Attached is a revised version of the patch which I hope addresses all > of your (very helpful) comments on the v3 patch. > > OK to apply once the sources are back on stage 1 ? > > Cheers > Nick > > gcc/ChangeLog > 2018-02-0

Re: [PR 81616] Deferring FMA transformations in tight loops

is just that the internal split FMAs can be scheduled so that while one is still waiting for its addend, another can already execute. Thanks, Martin On Fri, Dec 15 2017, Martin Jambor wrote: > Hello, > > the patch below prevents creation if fused-multiply-and-add instructions

[PR 83178] Adjust scan-dump-times count of devirt-22.C

t the behavior of IPA-CP and also reviewed the new profile info, which seems better or at least not worse than before (more info in my comment to the bug) and therefore I would like to propose to adjust the test dump scan expected count in the patch below. OK for trunk? Thanks, Martin 2018-01-11 M

Re: [PATCH 2/5] x86: Add -mindirect-branch-loop=

Hi, On Thu, Jan 11 2018, Jeff Law wrote: > On 01/07/2018 03:59 PM, H.J. Lu wrote: >> Add -mindirect-branch-loop= option to control loop filler in call and >> return thunks generated by -mindirect-branch=. 'lfence' uses "lfence" >> as loop filler. 'pause' uses "pause" as loop filler. 'nop' uses

Re: New code merge optimization?

Hi, On Thu, Jan 18 2018, Sebastian Perta wrote: > Hello, > > I am interested in implementing a new pass in gcc to merge identical > sequences of code in GCC to be used mainly for RL78. > The commercial RL78 compilers have such algorithms implemented and they make > quite good use of it. > Opportu

Re: [PATCH] Fix ICEs with "omp declare simd" attribute on versioned fns or omp_fn* (PR middle-end/83977)

On Wed, Jan 24 2018, Richard Biener wrote: > On January 24, 2018 5:16:45 PM GMT+01:00, Jakub Jelinek > wrote: >>On Wed, Jan 24, 2018 at 05:08:10PM +0100, Richard Biener wrote: >>> >The "omp declare simd" attribute refers to argument numbers of the >>> >functions, so trying to apply it on versione

[hsa] Set program allocation for static local variables

-02-08 Martin Jambor * hsa-gen.c (get_symbol_for_decl): Set program allocation for static local variables. libgomp/ * testsuite/libgomp.hsa.c/staticvar.c: New test. Added testcase --- gcc/hsa-gen.c | 10 +++--- libgomp/testsuite

[hsa] Fix PR82416 testcase

clone them. Fixed by rearranging the functions somewhat. The attribute is probably actually not necessary now but let's be future-proof. Martin 2018-02-08 Martin Jambor * testsuite/libgomp.hsa.c/pr82416.c: Make the function with target clonable. --- libgomp/test

Re: [RFC][PATCH] Stabilize a few qsort comparison functions

On Wed, Feb 07 2018, Franz Sirl wrote: > Hi, > > this is the result of an attempt to minimize the differences between the > compile results of a Linux-based and a Cygwin64-based powerpc-eabi cross > toolchain. > The method used was: > >     - find the -fverbose-asm assembler files that differ >  

[PR 83990] Fix location handling in ipa_modify_call_arguments

fixed in the patch below. I have bootstrapped and tested the patch on an x86_64-linux and consider it pre-approved by Jakub in bugzilla so plan to commit it to trunk tomorrow and to the gcc-7-branch soon afterwards (after testing there). Thanks, Martin 2018-01-30 Martin Jambor PR c

[PR 84947] Bits propagation only for int and ptr types

reflect that there is another reason to bail out early. LTO-bootstrapped and tested on x86_64-linux, OK for trunk? Thanks, Martin 2018-03-29 Martin Liska Martin Jambor PR ipa/84947 * ipa-cp.c (propagate_bits_across_jump_function): Bail out if param_type

[PR 84149] From 3b967c133f7f62e3c2951a971d8690d242364f5d Mon Sep 17 00:00:00 2001

benchmarks, but so it did on trunk). I have also LTO built Firefox with it and it browsed a few pages fine too. OK for trunk? Thanks, Martin 2018-04-08 Martin Jambor PR ipa/84149 * ipa-cp.c (propagate_vals_across_pass_through): Expand comment. (cgraph_edge_brings_val

[PR 87347] Prevent segfaults if TYPE_ARG_TYPES is NULL

x86_64-linux and aarch64-linux, the same on i686-linux is pending. OK for trunk? Thanks, Martin 2018-09-24 Martin Jambor PR c/87347 c/ * c-parser.c (warn_for_abs): Bail out if TYPE_ARG_TYPES is NULL. testsuite/ * gcc.dg/pr87347.c: New test. --- gcc/c

[PR 87339, testsuite] Fix failure of gcc.dg/warn-abs-1.c on some targets

2018-09-24 Martin Jambor PR testsuite/87339 * gcc.dg/warn-abs-1.c: Do not test _Float128. Remove dg-skip-if. * gcc.target/i386/warn-abs-3.c: New test. --- gcc/testsuite/gcc.dg/warn-abs-1.c | 4 +--- gcc/testsuite/gcc.target/i386/warn-abs-3.c | 12

Re: [patch] Extend thunk support and use it in Ada

Hi, On Tue, Sep 25 2018, Eric Botcazou wrote: > Hi, > > this extends the support for thunks present in the middle-end to accomodate > the Ada language, which can generate more diverse thunks than C++. The main > couple of enhancements are: > 1. Indirect offsets used to implement thunks for sel

Re: [patch,openacc] Fix PR71959: lto dump of callee counts

Hi, I have noticed a few things... On Thu, Sep 20 2018, Cesar Philippidis wrote: > This is another old gomp4 patch that demotes an ICE in PR71959 to a > linker warning. One problem here is that it is not clear if OpenACC > allows individual member functions in C++ classes to be marked as acc > ro

Re: [PR 87347] Prevent segfaults if TYPE_ARG_TYPES is NULL

Hi, On Tue, Sep 25 2018, Jakub Jelinek wrote: > On Mon, Sep 24, 2018 at 08:40:13PM +0200, Martin Jambor wrote: >> Hi, >> >> the warning for suspicious calls of abs-like functions segfaults if a >> user declared their own parameter-less-ish variant of abs like in the &

Re: [PR 87339, testsuite] Fix failure of gcc.dg/warn-abs-1.c on some targets

Hi, On Mon, Sep 24 2018, Christophe Lyon wrote: > On Mon, 24 Sep 2018 at 20:46, Martin Jambor wrote: >> >> Hi, >> >> the test added to check whether _Float128 types are handled correctly by >> the new warning about suspicious calls to abs-like functions fails

Re: [PR 87339, testsuite] Fix failure of gcc.dg/warn-abs-1.c on some targets

Hi, On Wed, Sep 26 2018, Christophe Lyon wrote: > On Tue, 25 Sep 2018 at 17:50, Martin Jambor wrote: >> >> Hi, >> >> On Mon, Sep 24 2018, Christophe Lyon wrote: >> > On Mon, 24 Sep 2018 at 20:46, Martin Jambor wrote: >> >> >> >> Hi,

Re: GCC options for kernel live-patching (Was: Add a new option to control inlining only on static functions)

Hi, (this message is a part of the thread originating with https://gcc.gnu.org/ml/gcc-patches/2018-09/msg01018.html) On Thu, Sep 27 2018, Jan Hubicka wrote: >> > If you make this to be INTERPOSABLE (which means it can be replaced by >> > different >> > implementation by linker and that is probab

Re: GCC options for kernel live-patching (Was: Add a new option to control inlining only on static functions)

't. Martin > > a little confused here. > > thanks. > > Qing >> On Sep 27, 2018, at 7:19 AM, Martin Jambor wrote: >> >> Hi, >> >> (this message is a part of the thread originating with >> https://gcc.gnu.org/ml/gcc-patches/2018-09

Re: GCC options for kernel live-patching (Was: Add a new option to control inlining only on static functions)

Hi, On Wed, Oct 03 2018, Jan Hubicka wrote: >> >> That was promised to be done by Honza Hubička. He's very skilled in IPA >> optimizations and he's aware >> of optimizations that cause troubles for live-patching. > > :) I am not sure how skilful I am, but here is what I arrived to. > > We have

Re: [PATCH] Remove dead functions and fix VMS target by moving back some functions.

On Tue, Oct 09 2018, Martin Liška wrote: > Hi. > > Utilizing rtags' --find-dead-functions I'm suggesting a removal of part > of the functions reported with the script. I built all cross compilers > defined in contrib/config-list.mk and I fixed VMS targets that I broke > in previous removal. > > If

Re: [PATCH] Remove dead functions and fix VMS target by moving back some functions.

Hi, On Wed, Oct 10 2018, Martin Liška wrote: > On 10/9/18 10:34 PM, Martin Jambor wrote: >> On Tue, Oct 09 2018, Martin Liška wrote: >>> * ipa-cp.c (ipcp_vr_lattice::meet_with): Likewise. >> >> Interesting, I believe that a class representing a lattice should ha

Re: [PR 87339, testsuite] Fix failure of gcc.dg/warn-abs-1.c on some targets

Hi, On Wed, Sep 26 2018, Joseph Myers wrote: > On Wed, 26 Sep 2018, Martin Jambor wrote: > >> I see, I guess the easiest is to skip the test on targets that do not >> really have long double, although if someone thinks that is too >> restrictive, I can also split the

Re: [PR 87339, testsuite] Fix failure of gcc.dg/warn-abs-1.c on some targets

Hi, On Wed, Oct 10 2018, Christophe Lyon wrote: > On 10/10/2018 13:17, Martin Jambor wrote: >> Hi, >> >> On Wed, Sep 26 2018, Joseph Myers wrote: >>> On Wed, 26 Sep 2018, Martin Jambor wrote: >>> >>>> I see, I guess the easiest is to skip th

[PR 85421] Call expand_all_artificial_thunks in ipa-cp if necessary

sooner or later, like we did in this bug. Fixed with the patch below, bootstrapped, LTO-bootstrapped and tested on x86_64-linux. OK for trunk? I'm sorry for introducing an ICE so late in stage4, Martin 2018-04-17 Martin Jambor PR ipa/85421 * ipa-cp.c (create_specialized

[PR 85447] Check that clones of edges exist during IPA-CP

), I will commit it to trunk in a few moments. Thanks, Martin 2018-04-19 Martin Jambor ipa/85447 * ipa-cp.c (create_specialized_node): Check that clones of self-recursive edges exist during IPA-CP. testsuite/ * g++.dg/ipa/pr85447.C: New file. * gcc.dg

[PR 85449] Fix IPA-CP test for self-feeding recursive dependency

LTO-build all of spec 2006 and 2017 and Firefox. I am going to commit it to trunk in a few moments. Martin 2018-04-19 Martin Jambor ipa/85449 * ipa-cp.c (cgraph_edge_brings_value_p): Move check for self-feeding recursion dependency to only apply to non-clones

Re: PR85463 '[nvptx] "exit" in offloaded region doesn't terminate process' (was: [patch, libfortran, committed] Implement stop_numeric for minimal targets)

Hi, On Thu, Apr 19 2018, Thomas Schwinge wrote: > > Per PR85463 '[nvptx] "exit" in offloaded region doesn't terminate > process' that I just filed, we currently have to use "abort" instead of > "exit" for nvptx offloading, so I have applied the following in trunk > r259491, where I completed this

Re: PR85463 '[nvptx] "exit" in offloaded region doesn't terminate process'

Hi, On Thu, Apr 26 2018, Thomas Schwinge wrote: > Hi Martin! > > On Wed, 25 Apr 2018 15:56:26 +0200, Martin Jambor wrote: >> On Thu, Apr 19 2018, Thomas Schwinge wrote: >> > * testsuite/libgomp.oacc-fortran/error_stop-1.f: New file. >> >

[PR 85549] Add mising check to aggregate IPA-CP propagation

Hi, this is a fix for another fallout from the fix for 84149 2018-04-27 Martin Jambor PR ipa/85549 * ipa-cp.c (find_aggregate_values_for_callers_subset): Make sure the jump function allows for passing through aggregate values. testsuite/ * g++.dg/ipa

Re: [PR 85549] Add mising check to aggregate IPA-CP propagation

Hi, On Fri, Apr 27 2018, Martin Jambor wrote: > Hi, > > this is a fix for another fallout from the fix for 84149 sorry, I have mistakenly hit the send key. Anyway, this is a fix for another fallout from the fix for 84149, in which I have relaxed conditions to propagate values a

Re: Incremental LTO linking part 7: documentation

Hi, just small nits: On Tue, May 08 2018, Jan Hubicka wrote: > Hi, > this patch adds documentation of -flinker-output. > > * doc/invoke.texi (-flinker-output): Document > Index: doc/invoke.texi > === > --- doc/invoke.texi (re

[PR 85655] Check is_single_const in intersect_with_plats

passes? OK for gcc-7 and gcc-6 branches after testing thee too? Thanks, Martin 2018-05-10 Martin Jambor PR ipa/85655 * ipa-cp.c (intersect_with_plats): Check that the lattice contains single const. testsuite/ * g++.dg/lto/pr85655_0.C: New test. --- gcc/ipa

Re: Replace FMA_EXPR with one internal fn per optab

Hi, On Fri, May 11 2018, Richard Sandiford wrote: > There are four optabs for various forms of fused multiply-add: > fma, fms, fnma and fnms. Of these, only fma had a direct gimple > representation. For the other three we relied on special pattern- > matching during expand, although tree-ssa-mat

Re: RFA (ipa-prop): PATCHes to avoid use of deprecated copy ctor and op=

ctions to be stored in call graph edge summaries. So thanks lot for spotting this but I'd prefer the following (compiled but untested) patch: Martin 2018-05-16 Martin Jambor * ipa-prop.c (ipa_free_all_edge_args): Remove. * ipa-prop.h (ipa_free_all_edge_args): Likewise. d

Re: RFA (ipa-prop): PATCHes to avoid use of deprecated copy ctor and op=

Hi, On Wed, May 16 2018, Jason Merrill wrote: > On Wed, May 16, 2018 at 6:35 AM, Martin Jambor wrote: >> On Tue, May 15 2018, Jason Merrill wrote: >>> In C++11 and up, the implicitly-declared copy constructor and >>> assignment operator are deprecated if one of them

Re: [PATCH, trans-mem, PR 61393] Copy tm_clone field of cgraph_node when cloning the node

Hi, On Thu, Aug 07, 2014 at 08:10:51AM +0200, Patrick Marlier wrote: > Hi Martin, > > On Wed, Aug 6, 2014 at 4:02 PM, Martin Jambor wrote: > > Hi, > > > > On Wed, Jul 30, 2014 at 06:56:05PM +0200, Martin Jambor wrote: > >> Hi, > >> > >> IPA

Re: [PATCH 005/236] Introduce as_a_nullable

Hi, On Wed, Aug 06, 2014 at 01:19:44PM -0400, David Malcolm wrote: > In many circumstances, is_a_helper ::test assumes that the pointer is > non-NULL, but sometimes you have a pointer of type T that can be NULL. > > Earlier versions of this patch kit made numerous uses of the ternary > operator t

[PATCH 1/2, PR 61654] Handle newly truly expanded artificial_thunks

. Bootstrapped and tested on x86_64-linux and i686-linux (where the bug triggered), OK for trunk and the 4.9 branch? Thanks, Martin 2014-09-01 Martin Jambor PR ipa/61654 * cgraphclones.c (duplicate_thunk_for_node): Copy arguments of the new decl properly. Analyze the new thunk

[PATCH 2/2] Set analyzed flag of unexpanded thunks in expand_thunk

ght it would be much nicer to set the analyzed flag in expand_thunk itself when it returns false, especially given that we probably want to set the flag at as few places as reasonably possible. Bootstrapped and tested on x86_64-linux. OK for trunk? Thanks, Martin 2014-09-01 Martin

[PATCH, PR 61986] Produce aggregate replacement nodes in ascending order of offsets

makes us miss an item in the intersection and assert later. The ordering is fixed by the following patch. Bootstrapped and tested on x86_64-linux. OK for the trunk and all problematic branches (4.9 for sure, I am not sure about 4.8 at this moment). Thanks, Martin 2014-09-02 Martin Jambor

[PATCH, PR 62015] Clear aggregate values intersection when jump function flag require us to punt

-linux (so far only on trunk, testing on branches in progress). OK for trunk and all the problematic branches (IIRC both 4.9 and 4.8)? Thanks, Martin 2014-09-02 Martin Jambor PR ipa/62015 * ipa-cp.c (intersect_aggregates_with_edge): Handle impermissible pass-trough

[PATCH, PR 10474] Take two on splitting live-ranges of function arguments to help shrink-wrapping

lot and sorry for the breakage, Martin 2013-11-04 Martin Jambor PR rtl-optimization/10474 * ira.c (interesting_dest_for_shprep): New function. (split_live_ranges_for_shrink_wrap): Likewise. (find_moveable_pseudos): Move calculation of dominance info

Re: RFC: simd enabled functions (omp declare simd / elementals)

Hi, On Thu, Oct 31, 2013 at 10:04:45PM -0500, Aldy Hernandez wrote: > Hello gentlemen. I'm CCing all of you, because each of you can > provide valuable feedback to various parts of the compiler which I > touch. I have sprinkled love notes with your names throughout the > post :). sorry it took

Re: [gomp4] rewrite simd clone argument adjustment to avoid regimplification

Hi, On Wed, Nov 06, 2013 at 05:37:03PM -0700, Aldy Hernandez wrote: > On 11/06/13 15:48, Jakub Jelinek wrote: > >On Wed, Nov 06, 2013 at 03:24:40PM -0700, Aldy Hernandez wrote: > >>I have checked the following patch with the attached testcases that > >>were previously ICEing, and with a handful of

Re: RFC: simd enabled functions (omp declare simd / elementals)

Hi, thanks for the followup. I like it, I only don't understand... On Fri, Nov 08, 2013 at 10:48:43AM -0700, Aldy Hernandez wrote: > On 11/07/13 09:09, Martin Jambor wrote: > <...> > --- a/gcc/ipa-prop.h > +++ b/gcc/ipa-prop.h > @@ -609,6 +609,31 @@ extern a

Re: [gomp4] rewrite simd clone argument adjustment to avoid regimplification

Hi, On Mon, Nov 11, 2013 at 10:15:24AM -0700, Aldy Hernandez wrote: > On 11/07/13 10:58, Martin Jambor wrote: > > >Sorry for the delay. I'd just like to re-iterate one comment from my > >previous email which is that I do not think tree-sra.c should export > >any

Re: [PATCH] Avoid some unnecessary set_cfun calls

Hi, On Wed, Nov 13, 2013 at 10:49:09AM +0100, Jakub Jelinek wrote: > Hi! > > void f1 (void) {} > __attribute__((target ("avx"))) void f2 (void) {} > __attribute__((target ("avx2"))) void f3 (void) {} > __attribute__((target ("sse3"))) void f4 (void) {} > __attribute__((target ("ssse3"))) void f5

Re: [PATCH] Avoid some unnecessary set_cfun calls

On Wed, Nov 13, 2013 at 01:53:00PM +0100, Richard Biener wrote: > On Wed, 13 Nov 2013, Martin Jambor wrote: > > > Hi, > > > > On Wed, Nov 13, 2013 at 10:49:09AM +0100, Jakub Jelinek wrote: > > > Hi! > > > > > > void f1 (void) {}

[PATCH] Merge cgraph_get_create_node and cgraph_get_create_real_symbol_node

cgraph_get_body (visionary points to Richi for putting the assert there). The patch successfully passed bootstrap and testing ("all" languages + Ada) and LTO-bootstrap (C and C++ only) on x86_64-linux. OK for trunk? Thanks, Martin 2013-11-12 Martin Jambor * cgraph.c (cgraph_get_c

[PATCH, testsuite] Add lp64 to target requirements of new IRA shrink wrapping preparation testcases

was recommended by Richi on IRC, I will commit the change in a few minutes. Thanks, Martin 2013-11-13 Martin Jambor * testsuite/gcc.dg/ira-shrinkwrap-prep-1.c: Add lp64 to target requirements. * testsuite/gcc.dg/ira-shrinkwrap-prep-2.c: Likewise. * testsuite/g

Re: [PATCH, testsuite] Add lp64 to target requirements of new IRA shrink wrapping preparation testcases

On Wed, Nov 13, 2013 at 12:41:54PM -0800, H.J. Lu wrote: > On Wed, Nov 13, 2013 at 7:27 AM, Martin Jambor wrote: > > Hi, > > > > the testcases I have added for IRA shrink wrapping preparation code > > were not intended for -m32 on x86_64 and should not be tested with i

Re: [PATCH, PR 10474] Take two on splitting live-ranges of function arguments to help shrink-wrapping

Hi, On Thu, Nov 14, 2013 at 09:24:54AM +0100, Jakub Jelinek wrote: > On Wed, Nov 06, 2013 at 05:26:08PM +0100, Martin Jambor wrote: > > So, Vlad, Steven, do you think that this time I have re-computed all > > that is necessary? Do you think the patch is OK? > > > >

Re: [PATCH, PR 10474] Take two on splitting live-ranges of function arguments to help shrink-wrapping

Hi, On Thu, Nov 14, 2013 at 12:18:24PM +, Matthew Leach wrote: > Martin Jambor writes: > > > Hi, > > Hi Martin, > > [...] > > > > > 2013-11-04 Martin Jambor > > > > PR rtl-optimization/10474 > >

Re: [PATCH, PR 10474] Take two on splitting live-ranges of function arguments to help shrink-wrapping

Hi, On Fri, Nov 15, 2013 at 09:22:01AM +, Matthew Leach wrote: > Martin Jambor writes: > > > Hi, > > > > On Thu, Nov 14, 2013 at 12:18:24PM +, Matthew Leach wrote: > >> Martin Jambor writes: > >> > >> > Hi, > >> > >

Re: [PATCH, MPX, 2/X] Pointers Checker [15/25] IPA Propagation

On Mon, Nov 18, 2013 at 02:28:58PM +0400, Ilya Enkovich wrote: > Hi, > > Here is a patch to disable propagation of bounded values. > Why do ypu need to do this? If the problem is that IPA-CP can remove parameter it knows is a constant, which somehow confuses how you pass bounds, then it is much

Re: [PATCH, MPX, 2/X] Pointers Checker [15/25] IPA Propagation

Hi, On Mon, Nov 18, 2013 at 10:38:49PM +0400, Ilya Enkovich wrote: > 2013/11/18 Martin Jambor : > > On Mon, Nov 18, 2013 at 02:28:58PM +0400, Ilya Enkovich wrote: > >> Hi, > >> > >> Here is a patch to disable propagation of bounded values. > >> > &

[PATCH] Make the IRA shrink-wrapping preparation also work on ppc64

pr10474.c) and that is probably most important. Bootstrapped and tested on ppc64-linux ("all" languages), x86_64-linux ("all" languages + Ada and ObjC++) and on ia64-linux (C, C++ and Fortran). OK for trunk? Thanks, Martin 2013-11-20 Martin Jambor PR rt

Re: [PATCH] Make the IRA shrink-wrapping preparation also work on ppc64

Hi, On Thu, Nov 21, 2013 at 05:55:21PM +, Ramana Radhakrishnan wrote: > On Thu, Nov 21, 2013 at 5:09 PM, Martin Jambor wrote: > > Hi, > > > > the patch below enables IRA live-range splitting that later > > facilitates shrink-wrapping also work on ppc64. The diff

Re: [PATCH] OpenMP #pragma omp declare simd support

Hi, On Fri, Nov 22, 2013 at 12:19:33PM +0100, Jakub Jelinek wrote: > On Fri, Nov 22, 2013 at 11:08:41AM +0100, Richard Biener wrote: > > > @@ -284,6 +382,12 @@ public: > > >/* Declaration node used to be clone of. */ > > >tree former_clone_of; > > > > > > + /* If this is a SIMD clone, t

Re: [PATCH] Make the IRA shrink-wrapping preparation also work on ppc64

Hi, On Fri, Nov 22, 2013 at 12:36:55PM -0700, Jeff Law wrote: > On 11/21/13 10:09, Martin Jambor wrote: > > PR rtl-optimization/10474 > > * ira.c (interesting_dest_for_shprep_1): New function. > > (interesting_dest_for_shprep): Use interesting_dest_for_shprep_

Re: [RFC, PATCH]: Introduction of callgraph annotation class

Hi, On Wed, Oct 15, 2014 at 06:26:34PM +0200, Martin Liska wrote: > Hello. > > Following patch introduces a new class called callgraph_annotation. Idea > behind the patch is to provide a generic interface one can use to register > custom info related to a cgraph_node. As you know, symbol_table

Re: [RFC, PATCH]: Introduction of callgraph annotation class

Hi, On Thu, Oct 16, 2014 at 01:44:05PM +0200, Richard Biener wrote: > On Thu, Oct 16, 2014 at 1:40 PM, Jan Hubicka wrote: > >> > >> I don't like "generic annotation" facilities at all. Would it be possible > > > > Why? > > Because it's the way to hell if the IL has "magic" things only one > pas

<    3   4   5   6   7   8   9   10   11   12   >