Re: [PATCH 1/4] Remove build dependence on HSA run-time

. > > This is commit b8d89b03db5f212919e4571671ebb4f5f8b1e19d (r242749) "Remove > build dependence on HSA run-time": > > On 2016-11-22T14:27:44+0100, Martin Jambor wrote: >> --- a/libgomp/plugin/configfrag.ac >> +++ b/libgomp/plugin/configfrag.ac > >>

[PATCH] ipa: Fix resolving speculations through cgraph_edge::set_call_stmt (PR 98078)

link it is deemed very important. Bootstrapped and tested on x86_64-linux, also profile-LTO-bootstrapped on the same system. OK for trunk? What about gcc10, where we cannot trigger it but I suppose the bug is there? Thanks, Martin gcc/ChangeLog: 2021-01-20 Martin Jambor PR ipa/

Re: [PATCH RFC] bootstrap: Update requirement to C++11.

Hi, On Fri, May 15 2020, Jason Merrill via Gcc-patches wrote: > commit f466a9f3f121f16b97071162806255fb464718f2 > Author: Jason Merrill > Date: Fri May 15 17:15:38 2020 -0400 > > bootstrap: Update requirement to C++11. > > There was general agreement last November that we would mov

Re: [PATCH 2/4] ipa-sra: Introduce a mini-DCE to tree-inline.c (PR 93385)

Hi, On Tue, Jun 02 2020, Richard Biener wrote: > On Thu, 28 May 2020, Martin Jambor wrote: > >> PR 93385 reveals that if the user explicitely disables DCE, IPA-SRA >> can leave behind statements which are useless because their results >> are eventually not used but c

Re: [PATCH 4/4] ipa-sra: Fix debug info for removed args passed to other functions (PR 93385, 95343)

Hi, On Thu, May 28 2020, Martin Jambor wrote: > This patch arguably finishes what I was asked to do in bugzilla PR > 93385 and remaps *all* occurrences of SSA names discovered to be dead > in the process of parameter removal during clone materialization > either to error_mar

BRIG FE testsuite: Fix all dump-scans (Was: Re: drop -aux{dir, base}, revamp -dump{dir, base})

dre's revamp of dump files handling in r11-627-g1dedc12d186, BRIG FE has been receiving slightly different -dumpbase (e.g. smoke_test.brig instead of smoke_test.hsail.brig when compiling file smoke_test.hsail.brig) and the testsuite then could not find the generated dump files it wanted to

Re: [patch] Fix ICE in verify_sra_access_forest

Hi, On Thu, Jun 11 2020, Eric Botcazou wrote: > Hi, > > this fixes an issue with reverse storage order in SRA, which is caught by the > built-in verifier: > > ===GNAT BUG DETECTED==+ > | 11.0.0 20200610 (experimental) (x86_64-suse-linux) GCC err

Re: BRIG FE testsuite: Fix all dump-scans (Was: Re: drop -aux{dir, base}, revamp -dump{dir, base})

tcases broken until that happens. Thanks, Martin > > On Jun 9, 2020, at 5:42 AM, Martin Jambor wrote: [...] >> >> >> I looked into the issue yesterday and decided the simplest fix is >> probably the following. I am going to use my BRIG maintainer hat to >

[PATCH] ipa: special pass-through op for Fortran strides

ure and is simple to pattern match. Encoding that zero needs to be changed to one would need another field and matching it would be slightly more complicated too. Bootstrapped and tested on x86_64-linux, LTO bootstrap is underway. OK if it passes? Thanks, Martin 2020-06-12 Martin Jambor

Re: [PATCH] ipa: special pass-through op for Fortran strides

Hi, On Mon, Jun 15 2020, Jan Hubicka wrote: >> On Fri, Jun 12, 2020 at 11:28 PM Martin Jambor wrote: >> > >> > Hi, >> > >> > when Fortran functions pass array descriptors they receive as a >> > parameter to another function, they actually rebuil

Re: drop -aux{dir,base}, revamp -dump{dir,base}

Hi, On Tue, Jun 23 2020, Alexandre Oliva wrote: > Hello, Thomas, > > On Jun 9, 2020, Thomas Schwinge wrote: > >> We're trying to scan 'variables.hsail.brig.*', but for input file name >> 'variables.hsail.brig', we're now creating: > > I understand this was fixed by Martin Jambor's last week's pa

[PATCH] ipa-sra: Prevent constructing debug info from wrong argument

strap on top of the gcc-10 branch is underway? OK for both if it passes? Thanks, Martin gcc/ChangeLog: 2020-07-01 Martin Jambor PR guality/95343 * ipa-param-manipulation.c (ipa_param_adjustments::modify_call): Adjust argument index if necessary. gcc/testsuite/ChangeL

[PATCH] ipa-sra: Avoid transitive splits with type mismatches (PR 96040)

top of it finishes. Thanks, Martin gcc/ChangeLog: 2020-07-03 Martin Jambor PR ipa/96040 * ipa-sra.c (all_callee_accesses_present_p): Do not accept type mismatched accesses. gcc/testsuite/ChangeLog: 2020-07-03 Martin Jambor PR ipa/96040 * gcc.dg

Re: [PATCH] ipa-cp: Avoid unwanted multiple propagations (PR 97816)

cost a tiny bit more than the estimated time benefit but both increases were small. Bootstrapped and LTO bootstrapped on x86_64-linux. OK for trunk? Thanks, Martin gcc/ChangeLog: 2020-11-20 Martin Jambor PR ipa/97816 * ipa-cp.c (safe_add): Removed

Re: [PATCH] ipa: special pass-through op for Fortran strides

Hi Jeff, On Fri, Nov 20 2020, Jeff Law wrote: > On 6/12/20 3:25 PM, Martin Jambor wrote: >> [...] >> >> 2020-06-12 Martin Jambor >> >> * ipa-prop.h (ipa_pass_through_data): Expand comment describing >> operation. >> * ipa-prop.c (a

Re: [PATCH] ipa: do not DECL_IS_MALLOC for void fns

Hi, On Wed, Dec 02 2020, Jan Hubicka wrote: >> We create an IPA SRA (which has DECL_IS_MALLOC set to false), but later >> IPA pure const propagates malloc attributes. I think we should not set >> it for a void returning functions. >> >> Patch can bootstrap on x86_64-linux-gnu and survives regress

Re: Fix handling of access ranges in ipa-modref

Hi, On Sun, Oct 11 2020, Jan Hubicka wrote: > Hi, > this patch fixes the range tracking in argument and re-enables it for clones > (the bug that broke dealII and x264 benchmarks) > > It turned out that there was three problems > 1) for SRA/ipa-cp clones we did not update summarries to represent n

Re: Support ofsetted parameters in local modref

Hi, On Wed, Oct 14 2020, Jan Hubicka wrote: > Hi, > here is updated patch with cap on number of iterations. > I set the limit to 8 and bootstrapped it with additional assert that the > limit is not met, it did not fire. > > Bootstrapped/regtested x86_64-linux, OK? > > gcc/ChangeLog: > > 2020-10-14

Re: Fix possible overflow in ipa-fnsummary

Hi, On Wed, Oct 14 2020, Jan Hubicka wrote: > Hi, > while looking into jump functions I noticed that offset_map in > ipa-fnsummary is array of integers while everywhere else the offsets are > HOST_WIDE_INTs (for good reason since the offsets are pointer > adjustments moreover multplied by UNIT_SIZ

Re: [PATCH] IPA: compare VRP types.

On Thu, Oct 15 2020, Martin Liška wrote: > Hello. > > As mentioned in the PR, since 74ca1c01d02e548f32aa26f9a887dcc0730703fb we > wrongly > merge a pair of VRP ranges with a different TREE_TYPE (in the PR one is char > and second > one is short). Then we merge 2 ranges and make an anti-range and

[PATCH] cplxlower: Avoid a transform when looking at a default definition

and the gcc-10 branch? Thanks, Martin gcc/ChangeLog: 2020-10-16 Martin Jambor PR tree-optimization/97456 * tree-complex.c (set_component_ssa_name): Do not replace ignored decl default definitions with new component vars. Reorder if conditions. gcc/testsuite

Re: [PATCH] cplxlower: Avoid a transform when looking at a default definition

Hi, On Sat, Oct 17 2020, Richard Biener wrote: > On October 16, 2020 8:46:39 PM GMT+02:00, Martin Jambor > wrote: >>Hi, >> >>in PR 97456, IPA-SRA triggers a bug in tree-complex.c where it >>converts: >> >> >> a$_M_value_21 = COMPLEX_EXPR ;

Re: [PATCH] LTO: get_section: add new argument

Hi, On Thu, Oct 22 2020, Martin Liška wrote: > All right, there's a patch that works for me. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? > Thanks, > Martin > From 33c58cab6bc0d779b11e7ffb36bfb485d73d6816 Mon Sep 17 00:00:00 2001 > From: Mar

Re: Materialize clones on demand

right thing at WPA time (still > not good idea for production patch). I did not test this path. > > Martin (Jambor), Jakub, there is one FIXME in ipa-param-manipulation. > We seem to ICE when we redirect to a call before callee is materialized > (this should be possible to trigger on

ipa-cp: New debug counters for IPA-CP

testing on x86_64-linux. OK for trunk? Thanks, Martin gcc/ChangeLog: 2020-10-30 Martin Jambor * dbgcnt.def (ipa_cp_values): New counter. (ipa_cp_vr): Likewise. * ipa-cp.c (decide_about_value): Check and bump ipa_cp_values debug counter

[PATCH 01/12] ipa: IPA-SRA split detection simplification

for master? Thanks, Martin gcc/ChangeLog: 2022-11-10 Martin Jambor * ipa-param-manipulation.cc (ipa_param_body_adjustments::common_initialization): Do not set m_split_modifications_p. (ipa_param_body_adjustments::ipa_param_body_adjustments): Remove

[PATCH 02/12] ipa-cp: Do not consider useless aggregate constants

Hi, When building vectors of known aggregate values, there is no point in including those for parameters which are not used in any way whatsoever. Bootstrapped and tested on x86_64-linux. OK for master? Thanks, Martin gcc/ChangeLog: 2022-11-11 Martin Jambor * ipa-cp.cc

[PATCH 03/12] ipa-cp: Write transformation summaries of all functions

/ChangeLog: 2022-11-11 Martin Jambor * ipa-prop.cc (useful_ipcp_transformation_info_p): New function. (write_ipcp_transformation_info): Added a parameter, simplified given that is known not to be NULL. (ipcp_write_transformation_summaries): Write out

[PATCH 04/12] ipa: Better way of applying both IPA-CP and IPA-SRA (PR 103227)

do not come through parameters. Bootstrapped and tested on x86_64-linux. OK for master? Thanks, Martin gcc/ChangeLog: 2022-11-11 Martin Jambor PR ipa/103227 * ipa-param-manipulation.h (class ipa_param_adjustments): Removed member function get_updated_index_or_s

[PATCH 06/12] ipa-cp: Leave removal of unused parameters to IPA-SRA

gcc/ChangeLog: 2022-11-11 Martin Jambor * ipa-cp.cc (estimate_local_effects): Do not clone potentionally local nodes for all contexts just to remove unused parameters. --- gcc/ipa-cp.cc | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gcc/ipa-cp.cc b

[PATCH 05/12] ipa-sra: Dump edge summaries also for non-candidates

x27;t dump them, which makes the dumops quite incomplete. This patch fixes that. Bootstrapped and tested on x86_64-linux. OK for master? Thanks, Martin gcc/ChangeLog: 2021-12-14 Martin Jambor * ipa-sra.c (ipa_sra_dump_all_summaries): Dump edge summaries even for non-candi

[PATCH 09/12] ipa-sra: Be optimistic about Fortran descriptors

: 2022-11-11 Martin Jambor * ipa-sra.c (isra_param_desc): New field not_specially_constructed. (struct isra_param_flow): New field constructed_for_calls. (isra_call_summary::dump): Dump the new flag. (loaded_decls): New variable. (dump_isra_param_descri

[PATCH 07/12] ipa-sra: Treat REFERENCE_TYPES as always dereferencable

invocations. Bootstrapped and tested on x86_64-linux. OK for master? Thanks, Martin gcc/ChangeLog: 2022-11-11 Martin Jambor PR ipa/103585 * ipa-sra.c (struct gensum_param_access): New field load_count. (struct gensum_param_desc): New field safe_ref, adjusted

[PATCH 08/12] ipa-sra: Move caller->callee propagation before callee->caller one

change to test ir independently and make those subsequent patches cleaner. While at it, I also replaced couple of FOR_EACH_VEC_ELT macros with C++11 style iteration. Bootstrapped and tested on x86_64-linux. OK for master? Thanks, Martin gcc/ChangeLog: 2022-11-11 Martin Jambor

[PATCH 11/12] ipa-sra: Make scan_expr_access bail out on uninteresting expressions

, Martin gcc/ChangeLog: 2021-12-14 Martin Jambor * ipa-sra.c (scan_expr_access): Bail out early if expr is something we clearly do not need to pass to get_ref_base_and_extent. --- gcc/ipa-sra.cc | 5 + 1 file changed, 5 insertions(+) diff --git a/gcc/ipa-sra.cc b/gcc

[PATCH 12/12] ipa: Avoid looking for IPA-SRA replacements where there are none

otherwise removed parameters that need to be removed from the statements too. Bootstrapped and tested on x86_64-linux. OK for master? Thanks, Martin gcc/ChangeLog: 2022-11-11 Martin Jambor * ipa-param-manipulation.cc (ipa_param_body_adjustments::modify_expression): Bail out

[PATCH 10/12] ipa-sra: Forward propagation of sizes which are safe to dereference

x86_64-linux. OK for master? Thanks, Martin gcc/ChangeLog: 2022-11-11 Martin Jambor * ipa-sra.cc (isra_param_desc): New fields safe_size, conditionally_dereferenceable and safe_size_set. (struct gensum_param_desc): New field conditionally_dereferenceable

Re: [PATCH 02/12] ipa-cp: Do not consider useless aggregate constants

On Sat, Nov 12 2022, Martin Jambor wrote: > Hi, > > When building vectors of known aggregate values, there is no point in > including those for parameters which are not used in any way > whatsoever. > > Bootstrapped and tested on x86_64-linux. OK for master? > > Thanks,

Re: [PATCH] ipa/109607 - properly gimplify conversions introduced by IPA param manipulation

Hi, On Thu, Apr 27 2023, Richard Biener wrote: > The following addresses IPA param manipulation (through IPA SRA) > replacing > > BIT_FIELD_REF <*this_8(D), 8, 56> > > with > > BIT_FIELD_REF (ISRA.814), 8, > 56> > > which is supposed to be invalid GIMPLE (ISRA.814 is a register). > There's cu

Re: [COMMITTED] Remove deprecated range_fold_{unary, binary}_expr uses from ipa-*.

Hello, On Wed, Apr 26 2023, Aldy Hernandez via Gcc-patches wrote: > gcc/ChangeLog: > > * ipa-cp.cc (ipa_vr_operation_and_type_effects): Convert to ranger API. > (ipa_value_range_from_jfunc): Same. > (propagate_vr_across_jump_function): Same. > * ipa-fnsummary.cc (evaluate_c

Re: [PATCH] ipa: check if cache_token != NULL before hash_set::add call

On Tue, Jan 24 2023, Martin Liška wrote: > We should not insert an empty value to the container. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? > Thanks, > Martin > > PR ipa/108509 > > gcc/ChangeLog: > > * cgraphunit.cc (walk_polymo

Re: [PATCH] ipa: silent -Wodr notes with -w

Hi, On Fri, Dec 02 2022, Martin Liška wrote: > If -w is used, warn_odr properly sets *warned = false and > so it should be preserved when calling warn_types_mismatch. > > Noticed that during a LTO reduction where I used -w. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests.

Re: Remove support for Intel MIC offloading (was: [PATCH] Remove dead code.)

Hello, On Thu, Oct 20 2022, Richard Biener via Gcc-patches wrote: >> Am 20.10.2022 um 14:41 schrieb Jakub Jelinek via Gcc-patches >> : >> >> On Thu, Oct 20, 2022 at 12:33:28PM +, Michael Matz wrote: >>> Hey, >>> On Thu, 20 Oct 2022, Thomas Schwinge wrote: This had been done

[PATCH] ipa: Avoid invalid gimple when IPA-CP and IPA-SRA disagree on types (108384)

-CP and when it sees a value on the same offset but with a mismatching size, it just decides to leave that particular parameter be. Bootstrapped and tested on x86_64-linux, OK for master? Thanks, Martin gcc/ChangeLog: 2023-02-02 Martin Jambor PR ipa/108384 * ipa-sra.cc

Re: [PATCH] ipa: Avoid invalid gimple when IPA-CP and IPA-SRA disagree on types (108384)

On Fri, Feb 03 2023, Richard Biener wrote: > On Thu, Feb 2, 2023 at 5:20 PM Martin Jambor wrote: >> >> Hi, >> >> when the compiled program contains type mismatches between callers and >> callees when it comes to a parameter, IPA-CP can try to propagate one >&

Re: [PATCH] ipa: Avoid invalid gimple when IPA-CP and IPA-SRA disagree on types (108384)

wing as an obvious fix. Martin A fix to a typo spotted by Bernhard Reutner-Fischer. Tested by building the compiler with the fix. gcc/ChangeLog: 2023-02-06 Martin Jambor * ipa-sra.cc (adjust_parameter_descriptions): Fix a typo in a dump. --- gcc/ipa-sra.cc | 4 ++-- 1 file ch

[PATCH] ipa: Check cst type when propagating controled uses info (PR 105639)

x86_64. OK for trunk and then gcc 12? Thanks, Martin gcc/ChangeLog: 2022-05-25 Martin Jambor PR ipa/105639 * ipa-prop.cc (propagate_controlled_uses): Check type of the constant before adding a LOAD reference. gcc/testsuite/ChangeLog: 2022-05-25 Martin Jambor

Re: [PATCH] ipa: Check cst type when propagating controled uses info (PR 105639)

Hi, On Fri, May 27 2022, Richard Biener wrote: > On Thu, May 26, 2022 at 4:47 PM Martin Jambor wrote: >> >> Hi, >> >> PR 105639 shows that code with type-mismatches can trigger an assert >> after runnning into a branch that was inteded only for reference

Re: Fix ipa-prop wrt volatile memory accesses

Hi, On Fri, Jun 10 2022, Jan Hubicka wrote: > Hi, > this patch prevents ipa-prop from propagating aggregates when load is > volatile. Martin, does this look OK? It seem to me that ipa-prop may > need some additional volatile flag checks. load_from_unmodified_param_or_agg checks for it, although

Re: ipa-sra is mostly disabled by -mlongcall

Hi, On Thu, Mar 11 2021, Alexandre Oliva wrote: > Several ipa-sra tests fail because -mlongcall on powerpc is a > TYPE_ATTRIBUTE, and those disable ipa-sra. > > This local workaround disables -mlongcall for the failing tests on > powerpc*-*-vxworks*, so they get a chance to run even in kernel mode

[PATCH 1/2] ipa-sra: Introduce a mini-DCE to tree-inline.c (PR 93385)

using call summaries in GCC 12. (Or we can of course decide to do nothing for 11.1 and wait for the final patch in GCC 12.) Thanks, Martin gcc/ChangeLog: 2021-03-10 Martin Jambor PR ipa/93385 * ipa-param-manipulation.h (class ipa_param_body_adjustments): New

[PATCH 2/2] ipa-sra: Improve debug info for removed parameters (PR 93385)

nly stage1 material, your call. It has passed bootstrap, and (profiled) LTO bootstrap and testing on x86_64-linux. Thanks, Martin gcc/ChangeLog: 2021-03-10 Martin Jambor PR ipa/93385 * ipa-param-manipulation.h (class ipa_param_body_adjustments): New

[GCC 12 PATCH 1/2] ipa-sra: Introduce a mini-DCE to tree-inline.c (PR 93385)

any feedback. Thanks, Martin gcc/ChangeLog: 2021-03-24 Martin Jambor PR ipa/93385 * symtab-clones.h (clone_info): Removed member param_adjustments. * ipa-param-manipulation.h: Adjust initial comment to reflect how we deal with pass-through splits now

[GCC 12 PATCH 2/2] ipa-sra: Improve debug info for removed parameters (PR 93385)

artin gcc/ChangeLog: 2021-03-29 Martin Jambor PR ipa/93385 * ipa-param-manipulation.h (class ipa_param_body_adjustments): New members remap_with_debug_expressions, m_dead_ssa_debug_equiv, m_dead_stmt_debug_equiv and prepare_debug_expressions. Added pa

[PATCH] sra: Fix bug in grp_write propagation (PR 97009)

grp_write flag. Bootstrap and testing on top of trunk and the gcc-10 branch is underway and I also plan to backport this to gcc-9. OK if they pass? Thanks, Martin gcc/ChangeLog: 2021-03-31 Martin Jambor PR tree-optimization/97009 * tree-sra.c (access_or_its_child_wri

[PATCH] ipa-sra: Release dead LHS SSA_NAME when removing it (PR 99951)

hanks, Martin gcc/ChangeLog: 2021-04-08 Martin Jambor PR ipa/99951 * ipa-param-manipulation.c (ipa_param_adjustments::modify_call): If removing a call statement LHS SSA name, release it. --- gcc/ipa-param-manipulation.c | 4 1 file changed, 4 insertions(+) diff --git

[wwwdocs] Add znver3 support to changes.html

Hi, Martin Liška correctly observed that the newly added support for AMD zenver3 in GCC 11 and 10.3 is not reflected in the changes.html files. Would the following be OK? Thanks, Martin diff --git a/htdocs/gcc-10/changes.html b/htdocs/gcc-10/changes.html index d5166879..d9971ffb 100644 --- a/

Re: [wwwdocs] Add znver3 support to changes.html

Hi, I'd like to ping the following, since we already have an RC. Thanks, On Tue, Apr 13 2021, Martin Jambor wrote: > Hi, > > Martin Liška correctly observed that the newly added support for AMD > zenver3 in GCC 11 and 10.3 is not reflected in the changes.html files. > >

Re: [PATCH 0/4] Remove BRIG FE and libhsail

Hi, On Wed, Apr 21 2021, Martin Liska wrote: > Based on the discussion with Martin Jambor, I'm suggesting removal > of the HSA front-end and BRIG FE. Both were marked as obsolete in GCC 11. > > Ready to be installed once GCC 11.1 is released? Yes, it is. Thanks for prepar

Re: [PATCH 4/4] Remove dead components from MAINTAINERS.

Arnaud Charlet > Ada front endEric Botcazou > > Ada front endPierre-Marie de Rodat > -BRIG (HSAIL) front end Pekka Jääskeläinen > > -BRIG (HSAIL) front end Martin Jambor > c++

Re: [PATCH] Test simlified call in cgraph_node::analyze().

Hi, On Wed, Apr 21 2021, Martin Liška wrote: > As mentioned and explained in the PR, the calls are redundant. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? Yes. Thanks, Martin > Thanks, > Martin > > gcc/ChangeLog: > > PR ipa/98815

[PATCH] tree-sra: Do not refresh readonly decls (PR 100453)

. Bootstrapped and tested on x86_64-linux, i686-linux and aarch64-linux (this time With Ada enabled on all three platforms). OK for trunk? Thanks, Martin gcc/ChangeLog: 2021-06-11 Martin Jambor PR tree-optimization/100453 * tree-sra.c (create_access): Disqualify any const

Re: [PATCH] tree-sra: Do not refresh readonly decls (PR 100453)

Hi Richi, On Tue, Jun 15 2021, Richard Biener wrote: > On June 15, 2021 5:09:40 PM GMT+02:00, Martin Jambor wrote: >>Hi, >> >>When SRA transforms an assignment where the RHS is an aggregate decl >>that it creates replacements for, the (least efficient) fallback metho

Re: [PATCH] tree-sra: Do not refresh readonly decls (PR 100453)

Hi, On Wed, Jun 16 2021, Jakub Jelinek wrote: > On Tue, Jun 15, 2021 at 06:11:27PM +0200, Richard Biener wrote: >> >--- a/gcc/tree-sra.c >> >+++ b/gcc/tree-sra.c >> >@@ -915,6 +915,12 @@ create_access (tree expr, gimple *stmt, bool >> >write) >> >if (!DECL_P (base) || !bitmap_bit_p (candidate_bitm

[PATCH] ipa-sra: Fix thinko when overriding safe_to_import_accesses (PR 101066)

This is fixed in the following patch. Bootstrapped, LTO-bootstrapped and tested on x86_64-linux, OK for trunk and the gcc-11 branch? On gcc-10, I might just remove the override altogether, the case might not be important enough to change LTO format. Thanks, Martin gcc/ChangeLog: 2021-

[PATCH] tree-inline: Fix TREE_READONLY of parameter replacements

? Thanks, Martin gcc/ChangeLog: 2021-06-22 Martin Jambor * tree-inline.c (setup_one_parameter): Set TREE_READONLY of the param replacement to zero if it is initialized, regardless if it needs constructing. --- gcc/tree-inline.c | 13 + 1 file changed, 1

Re: [PATCH] tree-inline: Fix TREE_READONLY of parameter replacements

Hi, On Wed, Jun 23 2021, Richard Biener wrote: > On Wed, 23 Jun 2021, Martin Jambor wrote: > >> Hi, >> >> tree-inline leaves behind VAR_DECLs which are TREE_READONLY (because >> they are copies of const parameters) but are written to because they >> need to be

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

Hi, On Tue, Jun 29 2021, Richard Biener via Gcc-patches wrote: > On Mon, Jun 28, 2021 at 8:07 PM Martin Sebor wrote: [...] >> >> vNULL can bind to a const vec& (via the vec conversion ctor) but >> not to vec&. The three functions that in the patch are passed >> vNULL modify the argument when i

[RFC] ipa: Adjust references to identify read-only globals

w. Martin gcc/ChangeLog: 2021-06-29 Martin Jambor * cgraph.h (ipa_replace_map): New field force_load_ref. * ipa-prop.h (ipa_param_descriptor): Reduce precision of move_cost, aded new flag load_dereferenced, adjusted comments. (ipa_get_param_dereferenced): Ne

Re: [PATCH] define auto_vec copy ctor and assignment (PR 90904)

Hi, On Wed, Jun 30 2021, Richard Biener wrote: > On Wed, Jun 30, 2021 at 3:46 AM Martin Sebor wrote: >> On 6/29/21 4:58 AM, Richard Biener wrote: [...] >> > >> > But I wonder if since you now identified them they could be massaged >> > prior to doing the change. >> > >> > I do hope we end up no

Re: [PATCH] ipa-sra: Fix thinko when overriding safe_to_import_accesses (PR 101066)

Ping. On Mon, Jun 21 2021, Martin Jambor wrote: > Hi, > > The "new" IPA-SRA has a more difficult job than the previous > not-truly-IPA version when identifying situations in which a parameter > passed by reference can be passed into a third function and only thee >

Re: Fix ICE when inlining into function containing polymorphic call

Hi, On Wed, Nov 13 2019, Jan Hubicka wrote: > Hi, > the testcase causes inline context cache to go out of sync because I > forgot to update used flags of parameters in one path of > update_indirect_edges_after_inlining. > > While debugging it I also added better consistency check to > ipa-inline-a

Re: Fix ICE when inlining into function containing polymorphic call

On Thu, Nov 14 2019, Jan Hubicka wrote: >> On Wed, Nov 13 2019, Jan Hubicka wrote: >> > Hi, >> > the testcase causes inline context cache to go out of sync because I >> > forgot to update used flags of parameters in one path of >> > update_indirect_edges_after_inlining. >> > >> > While debugging it

Re: Optimize handling of inline summaries

Hi, On Mon, Nov 04 2019, Jan Hubicka wrote: >> On 11/4/19 3:12 PM, Jan Hubicka wrote: >> > Martin, do you know why this flag was introduced? >> >> Hi. >> >> The flag is used in IPA CP: >> >> call_summary >> >> class edge_clone_summary >> { >> ... >> cgraph_edge *prev_clone; >> cgraph_edge

Re: Avoid trashing of polymorphic call cache during inlining

Hi, On Mon, Nov 04 2019, Jan Hubicka wrote: > Hi, > I am not really pround of this implementation (and will think of better > interface), but this patch saves about 10% of WPA time by avoiding > unnecesary invalidations of the polymorphic call target hash during > inlining. > > ipa-devirt register

Re: [PATCH 1/2] Update iterator of next

Hi, On Fri, Nov 15 2019, luoxhu wrote: > > Sorry to break the bootstrap. This was my lack of consideration when > splitting this small piece of code from the previous patch, the line > should be in the first line of the second loop. Could you please add > some comments that edge may be freed in

Re: Avoid trashing of polymorphic call cache during inlining

useless_jump_functions (); >> > + >> >> This is probably an unintended change? Can I remove it? > > Indeed, it is unrelated change. > Thanks for noticing it! > Honza OK, I have committed the following (after adding to a round of bootstrap and testing). Thanks,

[PATCH] Only warn for maybe-uninitialized SRAed bits in -Wextra (PR 80635)

Hi, On Fri, Nov 08 2019, Martin Jambor wrote: > Hi, > > this patch is an attempt to implement my idea from a previous thread > about moving -Wmaybe-uninitialized to -Wextra: > > https://gcc.gnu.org/ml/gcc-patches/2019-02/msg00220.html > > Specifically, it attempts to spl

[committed] Add testcase for already fixed PR ipa/92528

Hi, I have committed the patch below to add the testcase for the already fixed PR ipa/92528 to the testsuite. Thanks, Martin 2019-11-18 Martin Jambor PR ipa/92528 * g++.dg/ipa/pr92528.C: New test. Index: gcc/testsuite/g++.dg/ipa/pr92528.C

Re: [PATCH] Support multi-versioning on self-recursive function (ipa/92133)

Hi, On Fri, Nov 15 2019, Feng Xue OS wrote: > Honza, > > I made some changes: do not penalize self-recursive function, and > add --param ipa-cp-min-recursive-probability, similar to recursive > inline. Please review this new one. The patch and its effect on exchange is intriguing, I only have a f

[PATCH] Make IPA-SRA follow comdat-local rules (PR 91956)

outside of the comdat group to a private comdat symbol, which it does not like. Fixed by doing what IPA-split does in the patch below. Bootstrapped and tested on x86_64-linux. OK for trunk? Thanks, Martin 2019-11-21 Martin Jambor PR ipa/91956 * ipa-sra.c

[PATCH] ipa: Prevent materialization of clones with removed bodies (PR 92109)

with a small testcase, the bug is triggered by fragile partitioning decisions. I have bootstrapped, LTO-bootstrapped and tested the patch on an x86_64-linux, OK for trunk? Thanks, Martin 2019-11-21 Martin Jambor PR ipa/92109 * cgraph.h (cgraph_node::remove_from_clone_tree

[PATCH] cgraph: ifunc resolvers cannot be made local (PR 92697)

adds dumping of the symtab_node flag. Bootstrapped and tested on x86_64-linux, OK for trunk? Thanks, Martin 2019-11-27 Martin Jambor PR ipa/92697 * cgraph.c (cgraph_node_cannot_be_local_p_1): Return true for ifunc_resolvers. * symtab.c (symtab_node::dump_base):

[PATCH] ipa-cp: Avoid ICEs when looking at expanded thunks and unoptimized functions (PR 92476)

re all gone. OK for trunk? Thanks, Martin 2019-11-28 Martin Jambor Jan Hubicka PR ipa/92476 * ipa-cp.c (set_single_call_flag): Set node_calling_single_call in the summary only if the summary exists. (find_more_scalar_values_for_callers_subset)

Re: [PATCH] ipa-cp: Avoid ICEs when looking at expanded thunks and unoptimized functions (PR 92476)

dg-options { -fgnu89-inline } } */ > 20111207-1_1.c:/* { dg-options "-fno-lto" } */ > Ah, servers me right for only grepping for dg-lto-options. I have committed the fix and will commit the following testcase addition as a follow-up. Thanks, Martin 2019-11-29 Martin Jambor

Re: Fix jump function update in inliner

Hi, On Sun, Dec 01 2019, Jan Hubicka wrote: > Hi, > this patch fixes the problem with clearing bits and m_vr in inliner > update we discussed earlier. I am not sure if > dete_type_change_from_memory_writes needs the clear? No, they don't. Since your rewrite of devirtualization, the jfunc parame

[PATCH] ipa-cp: Do not be too optimistic about self-recursive edges (PR 107661)

and tested on x86_64-linux. OK for trunk? Thanks, Martin gcc/ChangeLog: 2022-11-22 Martin Jambor PR ipa/107661 * ipa-cp.cc (push_agg_values_from_edge): New parameter optimize_self_recursion, use it to decide whether to pass interim to the helper function

Re: [PATCH 03/12] ipa-cp: Write transformation summaries of all functions

eaming, I also simplified it a little a >> converted it writing to nicer C++ vector iterations. >> >> Bootstrapped and tested on x86_64-linux. OK for master? >> >> Thanks, >> >> Martin >> >> >> gcc/ChangeLog: >> >> 2022-11-11

Re: [PATCH] ipa: Careful processing ANCESTOR jump functions and NULL pointers (PR 103083)

On Mon, Dec 13 2021, Jan Hubicka wrote: >> >>> + || (only_for_nonzero && >> >>> !src_lats->bits_lattice.known_nonzero_p ())) >> >>> +{ >> >>> + if (jfunc->bits) >> >>> +return dest_lattice->meet_with (jfunc->bits->value, >> >>> +

Re: [patch] Fix reverse SSO issues in IPA-SRA

Hi Eric, On Tue, Jan 11 2022, Eric Botcazou via Gcc-patches wrote: > Hi, > > we recently received the report that the IPA-SRA pass introduced in GCC 10 > does not always play nice with the reverse scalar storage order that can be > used in structures/records/unions. Reading the code, the pass a

Re: [patch] Fix reverse SSO issues in IPA-SRA

Hi, On Wed, Jan 12 2022, Eric Botcazou wrote: >> Thanks for the fixes, the forgotten duplication and streaming were quite >> embarrassing, but one reason is that there are few reverse SSO testcases >> in the suite. Would it be difficult to add some covering the issues you >> fixed? > > No, I thin

Re: [PATCH] Mass rename of C++ .c files to .cc suffix

Hi, On Tue, Jan 11 2022, Martin Liška wrote: > Hello. > > I've got a patch series that does the renaming. It contains of 2 automatic > scripts ([1] and [2]) that were run as: > > $ gcc-renaming-candidates.py gcc --rename && git commit -a -m 'Rename files.' > && rename-gcc.py . -vv && git commit -

Re: [PATCH] Mass rename of C++ .c files to .cc suffix

On Thu, Jan 13 2022, Jakub Jelinek via Gcc-patches wrote: > On Thu, Jan 13, 2022 at 12:20:57PM +0100, Martin Liška wrote: >> On 1/13/22 12:14, Richard Biener wrote: >> > But please make sure all intermediate revs will still build. >> >> That's not possible :) I don't it's a good idea mixing .cc re

Re: [patch] Fix reverse SSO issues in IPA-SRA

Hi Eric, On Tue, Jan 11 2022, Eric Botcazou via Gcc-patches wrote: > Hi, > > we recently received the report that the IPA-SRA pass introduced in GCC 10 > does not always play nice with the reverse scalar storage order that can be > used in structures/records/unions. Reading the code, the pass a

[wwwdocs] Document support for znver4 in gcc-13/changes.html

Hello, is the following item documenting that gcc13 can generate code for Zen 4 OK for the changes.html file on the web? Thanks, Martin diff --git a/htdocs/gcc-13/changes.html b/htdocs/gcc-13/changes.html index 4fae1f7a..f8e9560c 100644 --- a/htdocs/gcc-13/changes.html +++ b/htdocs/gcc-13/chan

[PATCH] ipa: Avoid another ICE when dealing with type-incompatibilities (PR 108959)

so removes IPA value range and bits information associated with removed parameters stored in the same structure so that the useless information is not streamed later on. Bootstrapped and LTO-bootstrapped and tested on x86_64-linux. OK for trunk? Thanks, Martin gcc/ChangeLog: 2023-03-22 Mar

Re: [wwwdocs] Document support for znver4 in gcc-13/changes.html

Hello, On Wed, Mar 22 2023, Richard Biener wrote: > On Tue, Mar 21, 2023 at 8:25 PM Martin Jambor wrote: >> >> Hello, >> >> is the following item documenting that gcc13 can generate code for Zen 4 >> OK for the changes.html file on the web? > > OK. tha

Re: [PATCH RFC] c++: lambda mangling alias issues [PR107897]

Hello, On Wed, Mar 08 2023, Jason Merrill via Gcc-patches wrote: > On 3/8/23 11:15, Jason Merrill wrote: >> On 3/8/23 10:53, Jan Hubicka wrote: [...] >>> We have n->reset () for that which is used in similar situation when >>> frontends overwrites extern inline function by its different offline >>

[PATCH] ipa: Avoid constructing aggregate jump functions with huge offsets (PR 109303)

, Martin gcc/ChangeLog: 2023-03-30 Martin Jambor PR ipa/109303 * ipa-prop.cc (determine_known_aggregate_parts): Check that the offset + size will be representable in unsigned int. gcc/testsuite/ChangeLog: 2023-03-30 Jakub Jelinek Martin Jambor PR

Re: [PATCH] ipa: Avoid constructing aggregate jump functions with huge offsets (PR 109303)

Hi, On Fri, Mar 31 2023, Richard Biener wrote: > On Fri, Mar 31, 2023 at 10:46 AM Martin Jambor wrote: >> >> Hi, >> >> we are in the process of changing data structures holding information >> about constants passed by reference and in aggregates to use un

<    2   3   4   5   6   7   8   9   10   11   >