[PATCH 2/5] ipa: Do not emit info about temporary clones to ipa-clones dump (PR119852)

2025-04-28 Thread Martin Jambor
put either. Bootstrapped and tested on x86_64-linux. OK for master and gcc 15, 14 and 13? Thanks, Martin gcc/ChangeLog: 2025-04-23 Martin Jambor PR ipa/119852 * cgraphclones.cc (dump_callgraph_transformation): Document the function. Do not dump if suffix is NULL. gcc

[PATCH 1/5] Document option -fdump-ipa-clones

2025-04-28 Thread Martin Jambor
make html and manually inspecting the output. Is it perhaps OK for master and the branches or what would better be changed? Thanks, Martin gcc/ChangeLog: 2025-04-23 Martin Jambor * doc/invoke.texi (Developer Options): Document -fdump-ipa-clones. --- gcc/doc/invoke

[PATCH 4/5] ipa: Fix create_version_clone_with_body declaration and comment

2025-04-28 Thread Martin Jambor
(suffix) which is also used in related functions. The patch also updates the function comment in both places because it clearly became out of date. Bootstrapped and tested on x86_64-linux. OK for master? Thanks, Martin gcc/ChangeLog: 2025-04-25 Martin Jambor * cgraph.h (cgraph_node

[PATCH 5/5] ipa: Drop the default value of suffix parameter of create_clone (PR119852)

2025-04-28 Thread Martin Jambor
/ChangeLog: 2025-04-25 Martin Jambor PR ipa/119852 * cgraph.h (cgraph_node::create_clone): Remove the default value of argument suffix. Update function comment. * cgraphclones.cc (cgraph_node::create_clone): Update function comment. * ipa-inline-transform.cc

[PATCH 3/5] ipa: Dump cgraph_node UID instead of order into ipa-clones dump file

2025-04-28 Thread Martin Jambor
for master and gcc 15? Thanks, Martin gcc/ChangeLog: 2025-04-23 Martin Jambor * cgraph.h (symtab_node): Make member function get_uid const. * cgraphclones.cc (dump_callgraph_transformation): Dump m_uid of the call graph nodes instead of order. * cgraph.cc

[PATCH] ipa-cp: Avoid ICE when redistributing nodes among edges to recursive clones (PR 118318)

2025-03-03 Thread Martin Jambor
does. Bootstrapped and LTO-profile-bootstrapped and tested on x86_64. OK for master? (Should I then backport this to active release branches? I guess it would make sense.) Thanks, Martin gcc/ChangeLog: 2025-02-28 Martin Jambor PR ipa/118318 * ipa-cp.cc

Re: [PATCH] ipa-cp: Avoid ICE when redistributing nodes among edges to recursive clones (PR 118318)

2025-03-07 Thread Martin Jambor
Hello, On Mon, Mar 03 2025, Martin Jambor wrote: > Hi, > > PR 118318 reported an ICE during PGO build of Firefox when IPA-CP, in > the final stages of update_counts_for_self_gen_clones where it > attempts to guess how to distribute profile count among clones created > for recur

[PATCH] Fix a pasto in ao_compare::compare_ao_refs

2025-03-10 Thread Martin Jambor
Hi, when reading the function ao_compare::compare_ao_refs I came accross what I believe to ba a copy-and-paste error which this patch fixes. Bootstrapped, LTO-bootstrapped and tested on x86_64-linux. OK for master? Thanks, Martin gcc/ChangeLog: 2025-03-10 Martin Jambor * tree

Re: [PATCH] ipa-sra: Avoid clashes with ipa-cp when pulling accesses across calls (PR 118243)

2025-02-24 Thread Martin Jambor
Hello, and ping please. Thanks, Martin On Mon, Feb 10 2025, Martin Jambor wrote: > Hello, > > among other things, IPA-SRA checks whether splitting out a bit of an > aggregate or something passed by reference would lead into a clash > with an already known IPA-CP constant a

Re: [PATCH] ipa-vr: Handle non-conversion unary ops separately from conversions (PR 118756)

2025-02-26 Thread Martin Jambor
Hello, On Tue, Feb 25 2025, Jakub Jelinek wrote: > On Tue, Feb 25, 2025 at 04:48:37PM +0100, Martin Jambor wrote: >> --- /dev/null >> +++ b/gcc/testsuite/g++.dg/lto/pr118785_0.C >> @@ -0,0 +1,14 @@ >> +// { dg-lto-do link } >> +// { dg-require-effective-target fpi

[PATCH] ipa-vr: Handle non-conversion unary ops separately from conversions (PR 118756)

2025-02-25 Thread Martin Jambor
/ChangeLog: 2025-02-24 Martin Jambor PR ipa/118785 * ipa-cp.cc (ipa_vr_intersect_with_arith_jfunc): Handle non-conversion unary operations separately before doing any conversions. Check expr_type_first_operand_type_p for non-unary operations too. Fix type

[PATCH] sra: Clear grp_same_access_path of acesses created by total scalarization (PR118924)

2025-03-31 Thread Martin Jambor
. Bootstrapped on x86_64-linux and Aarch64-linux. OK for master and then for all active release branches? Thanks, Martin gcc/ChangeLog: 2025-03-26 Martin Jambor PR tree-optimization/118924 * tree-sra.cc (create_total_scalarization_access): Set grp_same_access_path flag to zero

Re: [PATCH] testsuite: add testcase for recent alias fix

2025-03-25 Thread Martin Jambor
Hi, On Tue, Mar 25 2025, Sam James wrote: > r15-7961-gdc47161c1f32c3 fixes a typo in ao_compare::compare_ao_refs > but there wasn't a testcase available at the time. Now there is. > > Thanks to Andrew for the testcase. > > gcc/testsuite/ChangeLog: > PR testsuite/119382 > > * gcc.dg/ipa

[PATCH] tree-sra: Do not create stores into const aggregates

2025-05-13 Thread Martin Jambor
convoluted. Anyway, it passes bootstrap and testing on x86_64-linux, bootstrap on Aarch64, testsuite is still running there. OK for master and all active release branches if it passes? Thanks, Martin gcc/ChangeLog: 2025-05-13 Martin Jambor PR tree-optimization/111873

[PATCH] ipa: Fix whitespace when dumping VR in jump_functions

2025-05-20 Thread Martin Jambor
Hi, lack of white space breakes the tree-visualisation structure and makes the dump unnecessarily difficult to read. I have bootstrapped and tested the patch on x86_64-linux. I plan to commit it soon as obvious. Thanks, Martin gcc/ChangeLog: 2025-05-19 Martin Jambor * ipa

[PATCH] ipa: When inlining, don't combine PT JFs changing signedness (PR120295)

2025-05-20 Thread Martin Jambor
situation with adding an extra conversion instead. Bootstrapped and LTO-bootstrapped on x86_64-linux. OK for master and gcc-15 branch? Thanks, Martin gcc/ChangeLog: 2025-05-19 Martin Jambor PR ipa/120295 * ipa-prop.cc (update_jump_functions_after_inlining): Do not combine

Re: [PATCH 3/5] ipa: Dump cgraph_node UID instead of order into ipa-clones dump file

2025-05-19 Thread Martin Jambor
t new clones to >> those about removed nodes (if any). >> >> gcc/ChangeLog: >> >> 2025-04-23 Martin Jambor >> >> * cgraph.h (symtab_node): Make member function get_uid const. >> * cgraphclones.cc (dump_callgraph_transformation): Du

Re: [PATCH] Fix IPA-SRA issue with reverse SSO on specific pattern

2025-05-27 Thread Martin Jambor
Hi, On Wed, May 21 2025, Eric Botcazou wrote: > Hi, > > IPA-SRA generally works fine in the presence of reverse Scalar_Storage_Order > by propagating the relevant flag onto the newly generated MEM_REFs. However > we have been recently faced with a specific Ada pattern that it doesn't > handle

[PATCH 02/17] Mark pass_sccopy gate and execute functions as final override

2025-06-25 Thread Martin Jambor
consider this obvious and will commit it shortly. Thanks, Martin gcc/ChangeLog: 2025-06-24 Martin Jambor * gimple-ssa-sccopy.cc (class pass_sccopy): Mark member functions gate and execute as final override. --- gcc/gimple-ssa-sccopy.cc | 4 ++-- 1 file changed, 2 insertions

[PATCH 11/17] tree-vect-stmts.cc: Remove an unused shadowed variable

2025-06-25 Thread Martin Jambor
s not used at all. This patch removes it. Bootstrapped and tested on x86_64-linx. OK for master? Thanks, Martin gcc/ChangeLog: 2025-06-24 Martin Jambor * tree-vect-stmts.cc (supportable_indirect_convert_operation): Remove an unused shadowed variable. --- gcc/tree-vect-st

[PATCH 09/17] jit: Silence clang warning in jit-builtins.cc

2025-06-25 Thread Martin Jambor
ested on x86_64-linx. OK for master? Alternatively, as with all of these clang warning issues, I'm perfectly happy to add an entry to contrib/filter-clang-warnings.py to ignore the warnings instead. Thanks, Martin gcc/jit/ChangeLog: 2025-06-23 Martin Jambor * jit-builtins.c

[PATCH 12/17] Silence a clang warning in tree-vect-slp.cc about an unused variable

2025-06-25 Thread Martin Jambor
. OK for master? Alternatively, as with all of these clang warning issues, I'm perfectly happy to add an entry to contrib/filter-clang-warnings.py to ignore the warning instead. Thanks, Martin gcc/ChangeLog: 2025-06-24 Martin Jambor * tree-vect-slp.cc (cond_expr_maps): R

[PATCH 06/17] value-relation.h: Mark dom_oracle::next_relation as override

2025-06-25 Thread Martin Jambor
entry to contrib/filter-clang-warnings.py to ignore the warning instead. Thanks, Martin gcc/ChangeLog: 2025-06-24 Martin Jambor * value-relation.h (class dom_oracle): Mark member function next_relation as override. --- gcc/value-relation.h | 2 +- 1 file changed, 1 insertion(

[PATCH 14/17] c-format: Removed unused private member

2025-06-25 Thread Martin Jambor
master? Alternatively, as with all of these clang warning issues, I'm perfectly happy to add an entry to contrib/filter-clang-warnings.py to ignore the warning instead. Thanks, Martin gcc/c-family/ChangeLog: 2025-06-24 Martin Jambor * c-format.cc (

[PATCH 01/17] Mark rtl_avoid_store_forwarding functions final override

2025-06-25 Thread Martin Jambor
precedent elsewhere I consider this obvious and will commit it shortly. Thanks, Martin gcc/ChangeLog: 2025-06-24 Martin Jambor * avoid-store-forwarding.cc (class pass_rtl_avoid_store_forwarding): Mark member function gate as final override. --- gcc/avoid-store

[PATCH 03/17] Diagnostics: Mark path_label::get_effects as final override

2025-06-25 Thread Martin Jambor
py to add an entry to contrib/filter-clang-warnings.py to ignore the warning(s) instead. Thanks, Martin gcc/ChangeLog: 2025-06-24 Martin Jambor * diagnostic-path-output.cc (path_label::get_effects): Mark as final override. * diagnostic-format-ht

[PATCH 05/17] tree-ssa-propagate.h: Mark two functions as override

2025-06-25 Thread Martin Jambor
he warning(s) instead. Thanks, Martin gcc/ChangeLog: 2025-06-24 Martin Jambor * tree-ssa-propagate.h (class substitute_and_fold_engine): Mark member functions value_of_expr and range_of_expr as override. --- gcc/tree-ssa-propagate.h | 4 ++-- 1 file changed, 2 insert

[PATCH 10/17] rust: Silence a clang warning in borrow-checker-diagnostics

2025-06-25 Thread Martin Jambor
from there? Thanks, Martin gcc/rust/ChangeLog: 2025-06-23 Martin Jambor * checks/errors/borrowck/rust-borrow-checker-diagnostics.cc (BorrowCheckerDiagnostics::get_loan): Type cast loan to uint32_t. --- .../checks/errors/borrowck/rust-borrow-checker-diagnostics.cc | 2 +- 1

[PATCH 08/17] ranger-op: Use CFN_ constant instead of plain BUILTIN_ one

2025-06-25 Thread Martin Jambor
. Thanks, Martin gcc/ChangeLog: 2025-06-23 Martin Jambor * gimple-range-op.cc (gimple_range_op_handler::maybe_builtin_call): Use CFN_BUILT_IN_ISINF instead of BUILT_IN_ISINF. --- gcc/gimple-range-op.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH 07/17] gfortran: Avoid freeing uninitialized value

2025-06-25 Thread Martin Jambor
e. Bootstrapped and tested on x86_64-linx. OK for master? Thanks, Martin gcc/fortran/ChangeLog: 2025-06-23 Martin Jambor * match.cc (gfc_match_nullify): Initialize p to NULL; --- gcc/fortran/match.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/fortran/ma

[PATCH 13/17] lto-ltrans-cache: Remove unused private member

2025-06-25 Thread Martin Jambor
x86_64-linx. OK for master? Alternatively, as with all of these clang warning issues, I'm perfectly happy to add an entry to contrib/filter-clang-warnings.py to ignore the warning instead. Thanks, Martin gcc/ChangeLog: 2025-06-24 Martin Jambor * lto-ltrans-cache.h (

[PATCH 17/17] Ignore more clang warnings in contrib/filter-clang-warnings.py

2025-06-25 Thread Martin Jambor
resting warnings. Since I don't think anyone else uses the script, I'm would like to declare these changes "obvious" in the sense that they are obviously useful for me and obviously nobody else will mind or even be affected. I'm going to hold off for a week though, pl

[PATCH 16/17] Fortran: Silence a clang warning (suggesting a brace) in io.cc

2025-06-25 Thread Martin Jambor
. OK for master? Alternatively, as with all of these clang warning issues, I'm perfectly happy to add an entry to contrib/filter-clang-warnings.py to ignore the warning instead. Thanks, Martin gcc/fortran/ChangeLog: 2025-06-24 Martin Jambor * io.cc (format_asterisk): Add a

Re: [PATCH 3/3] Assert finished vectorizer pattern COND_EXPR transition

2025-06-23 Thread Martin Jambor
Hi, On Fri, Oct 25 2024, Richard Biener wrote: > The following places a few strathegic asserts so we do not end up > with COND_EXPRs with a comparison as the first operand during > vectorization. > > Bootstrap and regtest running on x86_64-unknown-linux-gnu. > > These are the asserts I'd like to k

Re: [COMMITTED 02/12] - Move to an always available relation oracle.

2025-06-23 Thread Martin Jambor
Hello, On Thu, May 23 2024, Andrew MacLeod wrote: > This patch provides a basic oracle which doesn't do anything, but will > still respond when queried.  This allows passes to avoid the NULL check > for an oracle pointer before they do anything, and results in a slight > speedup in VRP, and a s

Re: [PATCH 13/17] lto-ltrans-cache: Remove unused private member

2025-06-26 Thread Martin Jambor
Hi, On Thu, Jun 26 2025, Michal Jireš wrote: > On 6/25/25 4:14 PM, Martin Jambor wrote: >> Hi, >> >> when building GCC with clang, it warns that the private member suffix >> in class ltrans_file_cache (defined in lto-ltrans-cache.h) is not used >> which indeed

[PATCH 04/17] ranger: Mark several member functions as final override

2025-06-25 Thread Martin Jambor
. Bootstrapped and tested on x86_64-linx. OK for master? Alternatively, as with all of these clang warning issues, I'm perfectly happy to add an entry to contrib/filter-clang-warnings.py to ignore the warnings instead. Thanks, Martin gcc/ChangeLog: 2025-06-24 Martin Jambor *

[PATCH 15/17] coroutines: Removed unused private member in cp_coroutine_transform

2025-06-25 Thread Martin Jambor
, as with all of these clang warning issues, I'm perfectly happy to add an entry to contrib/filter-clang-warnings.py to ignore the warning instead. Thanks, Martin gcc/cp/ChangeLog: 2025-06-24 Martin Jambor * coroutines.h (class cp_coroutine_transform): Remove m

Re: [PATCH 10/17] rust: Silence a clang warning in borrow-checker-diagnostics

2025-06-26 Thread Martin Jambor
On Wed, Jun 25 2025, Martin Jambor wrote: > Hi, > > when compiling > gcc/rust/checks/errors/borrowck/rust-borrow-checker-diagnostics.cc > with clang, it emits the following warning: > > gcc/rust/checks/errors/borrowck/rust-borrow-checker-diagnostics.cc:145:46: > warning:

<    13   14   15   16   17   18