Re: [hsa merge 10/10] HSA register allocator

2016-01-15 Thread Martin Jambor
Hi, On Thu, Jan 14, 2016 at 03:41:34PM +0100, Jakub Jelinek wrote: > On Wed, Jan 13, 2016 at 06:39:35PM +0100, Martin Jambor wrote: > > +for (phi = hbb->m_first_phi; > > +phi; > > +phi = phi->m_next ? as_a (phi->m_next): NULL) > > Space before :

Re: [hsa merge 07/10] IPA-HSA pass

2016-01-15 Thread Martin Jambor
Hi, On Fri, Jan 15, 2016 at 04:01:49PM +0100, Jakub Jelinek wrote: > On Fri, Jan 15, 2016 at 03:53:23PM +0100, Martin Jambor wrote: > > @@ -317,7 +319,7 @@ public: > > bool > > pass_ipa_hsa::gate (function *) > > { > > - return hsa_gen_requeste

Re: [hsa merge 08/10] HSAIL BRIG description header file

2016-01-15 Thread Martin Jambor
On Fri, Jan 15, 2016 at 01:03:35PM +0100, Jakub Jelinek wrote: > On Fri, Jan 15, 2016 at 11:37:32AM +0100, Jakub Jelinek wrote: > > On Fri, Jan 15, 2016 at 11:14:33AM +0100, Martin Jambor wrote: > > > > Martin, could you ask the HSA Foundation or AMD or whoever if there is

Re: [hsa merge 09/10] Majority of the HSA back-end

2016-01-15 Thread Martin Jambor
ickly by making most of the contents of hsa-*.c files compiled only conditionally (and leave potential hsa support on non-linux platforms for later), but I will not have time to do the change and test it properly until Monday. But that will hopefully really be it, Martin 2016-01-16 Martin J

Re: [hsa merge 08/10] HSAIL BRIG description header file

2016-01-18 Thread Martin Jambor
Hi, On Sat, Jan 16, 2016 at 12:43:07PM +0100, Jakub Jelinek wrote: > On Fri, Jan 15, 2016 at 06:23:05PM +0100, Martin Jambor wrote: > > BRIG_KIND_OPERAND_REGISTER = 0x300a, > > BRIG_KIND_OPERAND_STRING = 0x300b, > > BRIG_KIND_OPERAND_WAVESIZE = 0x3009c, > > BRI

Re: [hsa merge 09/10] Majority of the HSA back-end

2016-01-18 Thread Martin Jambor
Hi, On Sat, Jan 16, 2016 at 09:58:51AM +0100, Jakub Jelinek wrote: > On Sat, Jan 16, 2016 at 12:49:12AM +0100, Martin Jambor wrote: > > bootstrapping on i686-linux revealed the need for the following simple > > patch. I've run into two types of compilation errors on >

Re: [hsa merge 00/10] Merge of HSA branch

2016-01-19 Thread Martin Jambor
Hi, On Wed, Jan 13, 2016 at 06:39:25PM +0100, Martin Jambor wrote: > Hi, > > this is hopefully the last big re-post of the HSA patches... I have committed the combined patch as revision 232549 after bootstrapping and testing all languages on x86_64-linux and i686-linux and verifying

[PATCH, PR 64192] Add forgotten conversion from bits to bytes

2014-12-05 Thread Martin Jambor
, Martin 2014-12-05 Martin Jambor PR ipa/64192 * ipa-prop.c (ipa_compute_jump_functions_for_edge): Convert alignment from bits to bytes after checking they are byte-aligned. Index: src/gcc/ipa-prop.c

Re: Remove unused arguments of bulitin_unreachable

2014-12-11 Thread Martin Jambor
Hi, On Thu, Dec 11, 2014 at 07:16:43PM +0100, Jan Hubicka wrote: > > On Thu, Dec 11, 2014 at 06:06:55PM +0100, Jan Hubicka wrote: > > > Hi, > > > in firefox .optimized dumps one can see few places where > > > __builtin_unreachable > > > is called (as a result of devirtualization code proving the

[hsa] Fix wrong conversion ode and verification fallout

2015-01-08 Thread Martin Jambor
originating from default-def gimple SSA names which are not parameters not having a definition. Committed to the branch. Thanks, Martin 2015-01-08 Martin Liska Martin Jambor * hsa-brig.c (emit_cvt_insn): Add near rounding for integer to float conversion

Re: [tsan] ThreadSanitizer instrumentation part

2012-11-02 Thread Martin Jambor
Hi, On Thu, Nov 01, 2012 at 11:11:13AM -0700, Xinliang David Li wrote: > ... > The TREE_ADDRESSABLE check seems redundant -- if the var_decl (instead > of ssa name) appears in the assignment, why would it not be > 'addressable'? There are other reason beside being TREE_ADDRESSABLE that may ca

[PATCH] Minor ipa-prop.c internal interface tweak

2012-11-04 Thread Martin Jambor
for the aggregate IPA-CP. OK for trunk? Thanks, Martin 2012-10-31 Martin Jambor * ipa-prop.c (ipa_get_param_decl_index_1): New function. (ipa_get_param_decl_index): Just call ipa_get_param_decl_index_1. (ipa_populate_param_decls): Accept descriptors parameter rather

[PATCH] Disable aggregate jump functions for bit-field stores

2012-11-04 Thread Martin Jambor
IPA-CP. OK for trunk? Thanks, Martin 2012-11-02 Martin Jambor * ipa-prop.c (determine_known_aggregate_parts): Do not create aggregate jump functions for bit-fields. Index: src/gcc/ipa-prop.c === --- src.orig

[PATCH] Stream cgraph_node.ipa_transforms_to_apply

2012-11-04 Thread Martin Jambor
, required to make aggregate IPA-CP work in LTO. OK for trunk? Thanks, Martin 2012-11-03 Martin Jambor * lto-cgraph.c: Include tree-pass.h. (lto_output_node): Stream node->ipa_transforms_to_apply. (input_node): Likewise. * Makefile.in (lto-cgraph.o):

Re: [PATCH] Disable aggregate jump functions for bit-field stores

2012-11-05 Thread Martin Jambor
> the size of the memory reference alongside the offset in the jump > > functions (and IPA-CP lattices). > > > > Bootstrapped and tested on x86_64-linux, needed for the aggregate > > IPA-CP. OK for trunk? > > > > Thanks, > > > > Martin &g

Re: [PATCH] Stream cgraph_node.ipa_transforms_to_apply

2012-11-06 Thread Martin Jambor
ss.static_pass_number and then looking > > it up among all_regular_ipa_passes. > > > > Bootstrapped and tested on x86_64-linux, required to make aggregate > > IPA-CP work in LTO. > > > > OK for trunk? > > > > Thanks, > > > > Martin

Re: [PATCH] Make IPA-CP work on aggregates

2012-11-07 Thread Martin Jambor
On Tue, Nov 06, 2012 at 02:35:30PM +0100, Jakub Jelinek wrote: > On Tue, Nov 06, 2012 at 12:58:07AM +0100, Martin Jambor wrote: > > 2012-11-05 Martin Jambor > > > > PR tree-optimization/53787 > > * ipa-cp.c (ipcp_value_source): New field offset. > .

Re: [PATCH] Make IPA-CP work on aggregates

2012-11-08 Thread Martin Jambor
Hi, On Wed, Nov 07, 2012 at 03:55:16PM +0100, Jan Hubicka wrote: > > On Wed, Nov 07, 2012 at 03:39:15PM +0100, Martin Jambor wrote: > > > another bootstrap finishes. I'm not sure if it would be OK to commit > > > it now, given it is stage3, though. OTOH, I thi

[PR 55238] More careful pass-through handling in find_aggregate_values_for_callers_subset

2012-11-08 Thread Martin Jambor
x86_64-linux. OK for trunk? Thanks, Martin 2012-11-08 Martin Jambor PR tree-optimization/55238 * ipa-cp.c (agg_pass_through_permissible_p): New function. (propagate_aggs_accross_jump_function): Use it. (find_aggregate_values_for_callers_subset): Likewise and

[PATCH, PR 55253] Propagate aggs_contain_variable flag in aggregater IPA-CP

2012-11-13 Thread Martin Jambor
Hi, somehow the propagation of aggs_contain_variable in merge_aggregate_lattices got lost when I was shuffling the code around, leading to miscompilations. This patch puts it back in. Bootstrapped and tested on x86_64-linux, OK for trunk? Thanks, Martin 2012-11-13 Martin Jambor

Re: [PATCH, PR 55253] Propagate aggs_contain_variable flag in aggregater IPA-CP

2012-11-14 Thread Martin Jambor
Hi, On Tue, Nov 13, 2012 at 01:08:56PM -0800, Ian Lance Taylor wrote: > On Tue, Nov 13, 2012 at 9:03 AM, Martin Jambor wrote: > > > Index: src/gcc/ipa-cp.c > > === > > --- src.orig/gcc/ipa-cp.c

Re: VEC re-write [patch 03/25]

2012-11-16 Thread Martin Jambor
Hi, On Thu, Nov 15, 2012 at 04:53:25PM -0500, Diego Novillo wrote: > [ The patch is too big for e-mail. It's available at > http://www.airs.com/~dnovillo/pub/vec-rewrite/06vec.diff ] when I tried to wget it, I got ERROR 404: Not Found. (I downloaded 01vec.diff fine.) Thanks, Martin > > 201

[PATCH, PR 55260] Use info of the correct node in find_aggregate_values_for_callers_subset

2012-11-17 Thread Martin Jambor
hanks, Martin 2012-11-16 Martin Jambor PR tree-optimization/55260 * ipa-cp.c (find_aggregate_values_for_callers_subset): Rename info to dest_info, use caller_info instead of info when determining whether callee is a clone. * testsuite/g++.dg/torture/pr5526

Re: PATCH: Add --with-build-config=bootstrap-asan support

2012-11-19 Thread Martin Jambor
Hi, On Sat, Nov 17, 2012 at 03:54:41PM -0800, H.J. Lu wrote: > Hi, > > This patch adds --with-build-config=bootstrap-asan support. OK to > install? I suppose this should be also described in gcc/doc/install.texi? Thanks, Martin > > Thanks. > > > H.J. > --- > 2012-11-17 H.J. Lu > >

Re: [PR 55238] More careful pass-through handling in find_aggregate_values_for_callers_subset

2012-11-20 Thread Martin Jambor
ils on AIX. No, at least on my i686 desktop it does not rely on it. I will apply the following patch in a few hours (after I add it to some testing run on x86_64), unless someone objects. Thanks, Martin 2012-11-20 Martin Jambor * gcc.dg/torture/pr55238.c: Remove hidden attribute.

Re: rfc NOP vs CONVERT (was: Simplifying Gimple Generation)

2012-11-20 Thread Martin Jambor
Hi, On Mon, Nov 19, 2012 at 04:35:45PM +0100, Michael Matz wrote: > Hi, > > On Mon, 19 Nov 2012, Steven Bosscher wrote: > > > On Mon, Nov 19, 2012 at 2:10 PM, Michael Matz wrote: > > > Hi, > > > > > > On Fri, 16 Nov 2012, Andrew Pinski wrote: > > > > > >> >> Ah, yes. This one was amusing. When

[PATCH, PR 55260] Fix cgraph_edge_brings_all_agg_vals_for_node

2012-11-20 Thread Martin Jambor
times in the process but the list should be usually tiny and even in pathologic cases their size is limited by PARAM_IPA_MAX_AGG_ITEMS * number of parameters, so I do not think it's worth a bitmap. Bootstrapped and tested on x86_64-linux. OK for trunk? Thanks, Martin 2012-11-19 Martin J

[PATCH] Recognize clones for all contexts in SCCs in IPA-CP

2012-11-21 Thread Martin Jambor
ontexts to do_clone_for_all_contexts. Additionally, I discovered that decide_whether_version_node contains a bogus "|| !plats->aggs" in a test, which is harmless but just should not be there, so I removed it. Bootstrapped and tested on x86_64-linux. OK for trunk? Martin 2012-11-20 Martin Jambor

Re: [PATCH, RFC] PR 55415 : Pessimistic misalignment from eipa_sra pass

2012-11-21 Thread Martin Jambor
Hi, On Tue, Nov 20, 2012 at 09:24:20AM -0800, Richard Henderson wrote: > The get_pointer_alignment function can indicate that it does not know > what the alignment should be, and it always fills in worst-case values > for that case. We should not use these worst-case values to "optimize" > the in

Re: [PATCH, RFC] PR 55415 : Pessimistic misalignment from eipa_sra pass

2012-11-27 Thread Martin Jambor
Hi, On Tue, Nov 27, 2012 at 02:02:42PM +0100, Richard Biener wrote: > On Wed, Nov 21, 2012 at 5:58 PM, Martin Jambor wrote: > > Hi, > > > > On Tue, Nov 20, 2012 at 09:24:20AM -0800, Richard Henderson wrote: > >> The get_pointer_alignment function can indicate that

Re: [PATCH, RFC] PR 55415 : Pessimistic misalignment from eipa_sra pass

2012-11-29 Thread Martin Jambor
2012 at 02:11:51PM +0100, Richard Biener wrote: > On Tue, Nov 27, 2012 at 9:37 PM, Martin Jambor wrote: > > *** /tmp/Hp0Wyc_tree-sra.c Tue Nov 27 21:34:54 2012 > > --- gcc/tree-sra.c Tue Nov 27 21:28:53 2012 > > *** unmodified_by_ref_scalar_repres

Re: [PATCH, RFC] PR 55415 : Pessimistic misalignment from eipa_sra pass

2012-11-29 Thread Martin Jambor
Hi, On Thu, Nov 29, 2012 at 12:54:20PM +0100, Richard Biener wrote: > On Thu, Nov 29, 2012 at 11:06 AM, Martin Jambor wrote: > > Hi, > > > > thanks for the review. When writing a reply I realized I indeed made > > a mistake or two in the part concerning prev_base an

Re: [PATCH, RFC] PR 55415 : Pessimistic misalignment from eipa_sra pass

2012-11-30 Thread Martin Jambor
On Thu, Nov 29, 2012 at 11:06:41AM +0100, Martin Jambor wrote: > Hi, > > thanks for the review. When writing a reply I realized I indeed made > a mistake or two in the part concerning prev_base and the code was not > what it intended to be. I'll re-write it today. OK, this

[PATCH, PR 55590] Avoid more pessimistic alignments in SRA

2012-12-04 Thread Martin Jambor
on x86_64-linux and powerpc64-linux, the same is currently in progress on sparc64-linux. OK for trunk if it passes there as well? Thanks, Martin 2012-12-04 Martin Jambor PR tree-optimization/55590 * tree-sra.c (build_ref_for_offset): Use get_object_alignment to get

[PATCH, PR 55078] Let indirect inlining look at ipa-cp lattices

2012-12-06 Thread Martin Jambor
irect inlining slightly more powerful, the change is not big and so I hope it qualifies even though we are in stage 3 now. The patch has passed bootstrap and testing on x86_64-linux. OK for trunk? Thanks, Martin 2012-12-05 Martin Jambor PR middle-end/55078 * ipa-i

Re: [PATCH, PR 55590] Avoid more pessimistic alignments in SRA

2012-12-06 Thread Martin Jambor
27; plus offset 'offset', no? You're right, such situation can occur too, even though probably only rarely. Below is a patch that uses get_object_alignment_1, it has passed bootstrap and testing on x86_64-linux, and powerpc64-linux, the same on sparc64-linux is underway.

Ping: [PATCH, PR 42371] Remove references to functions from symbol table during inlining

2013-04-30 Thread Martin Jambor
Ping. Thanks, Martin - Forwarded message from Martin Jambor - Date: Wed, 17 Apr 2013 17:45:17 +0200 From: Martin Jambor To: GCC Patches Cc: Jan Hubicka Subject: [PATCH, PR 42371] Remove references to functions from symbol table during inlining Hi, the patch below is a fix for PR

Ping: [PATCH, PR 56988] Honor by_ref in IPA-CP transformation phase

2013-04-30 Thread Martin Jambor
Ping. Thanks, Martin - Forwarded message from Martin Jambor - Date: Fri, 19 Apr 2013 11:05:58 +0200 From: Martin Jambor To: GCC Patches Cc: Jan Hubicka Subject: [PATCH, PR 56988] Honor by_ref in IPA-CP transformation phase Hi, the following patch fixes PR 56988 by distinguishing

[PATCH, PR 57084] Create real cgraph node during late intraprocedural devirtualization

2013-05-07 Thread Martin Jambor
also LTO build Mozilla Firefox with it. OK for trunk? Thanks, Martin 2013-05-06 Martin Jambor PR lto/57084 * gimple-fold.c (canonicalize_constructor_val): Call cgraph_get_create_real_symbol_node instead of cgraph_get_create_node. Index: src/gcc/gimple-fold.c

Re: [PATCH, PR 57084] Create real cgraph node during late intraprocedural devirtualization

2013-05-09 Thread Martin Jambor
On Tue, May 07, 2013 at 11:43:33PM +0200, Jan Hubicka wrote: > > Hi, > > > > the problem in PR 57084 is that late PRE devirtualization creates a > > direct call to a decl fro which we only have an inlined call graph > > mode in the given partition. I tried to find a most universal place > > where

Re: [PATCH, PR 57084] Create real cgraph node during late intraprocedural devirtualization

2013-05-09 Thread Martin Jambor
On Thu, May 09, 2013 at 03:52:20PM +0200, Martin Jambor wrote: > On Tue, May 07, 2013 at 11:43:33PM +0200, Jan Hubicka wrote: > > > Hi, > > > > > > the problem in PR 57084 is that late PRE devirtualization creates a > > > direct call to a decl fro w

Re: Ping: [PATCH, PR 42371] Remove references to functions from symbol table during inlining

2013-05-10 Thread Martin Jambor
Hi, I thought I was hitting the ipa-inline-transform.c:263 assert with this patch when LTO-building Mozilla Firefox but it turned out it was caused by a different patch so I'm handling that there. On Thu, May 02, 2013 at 02:37:26PM +0200, Jan Hubicka wrote: > > 2013-03-22 Ma

[PATCH] Consistent and slightly better IPA dumps

2013-05-10 Thread Martin Jambor
out any problems. OK for trunk? Thanks, Martin 2013-05-07 Martin Jambor * ipa-prop.c (ipa_print_node_jump_functions): Print symbol order in header, print symbol order instead of node uid, print more information about indirect edge targ

[PATCH] Use types_compatible_p in get_binfo_at_offset

2013-05-10 Thread Martin Jambor
-flto -m32 (-m32 is not significant here, it was only required to trigger the bug and I made the measurements in the same environment). Bootstrapped and tested on x86_64-linux without any issues. OK for trunk? Thanks, Martin 2013-05-10 Martin Jambor * tree.c (get_binfo_at_offset

[PATCH] Redirect calls to non-functions to builtin_unreachable

2013-05-10 Thread Martin Jambor
-inline-transform.c:263. I have discussed this with Honza and he has agreed to switch the check off when there are newly discovered direct edges. The patch has passed bootstrap and is undergoing testing now. OK for trunk if it passes? Thanks, Martin 2013-05-09 Martin Jambor * ipa

Re: [PATCH] Use types_compatible_p in get_binfo_at_offset

2013-05-10 Thread Martin Jambor
Hi, On Fri, May 10, 2013 at 07:24:06PM +0200, Jan Hubicka wrote: > > 2013-05-10 Martin Jambor > > > > * tree.c (get_binfo_at_offset): Use types_compatible_p to compare > > types. > &

[PATCH, PR 57276] Add a missing break in cgraph_edge_brings_all_agg_vals_for_node

2013-05-15 Thread Martin Jambor
-15 Po-Chun Chang Martin Jambor PR middle-end/57276 * ipa-cp.c (cgraph_edge_brings_all_agg_vals_for_node): Break when a value that corresponds to the given aggval is found in values vector. Index: src/gcc/ipa-cp.c

[PATCH, PR 57289] Fix streaming order in ipa_read_node_info

2013-05-21 Thread Martin Jambor
also passes bootstrap and testing on x86_64-linux. OK for trunk? Thanks, Martin 2013-05-20 Martin Jambor PR lto/57289 * ipa-prop.c (ipa_read_node_info): Process param_used and controlled_uses in the same order as when writing. Index: src/gcc/ipa-prop.c

[PATCH] Do not allow non-top-level BIT_FIELD_REFs, IMAGPART_EXPRs or REALPART_EXPRs

2013-05-22 Thread Martin Jambor
whether that assumption is OK, I added the following into the gimple verifier and ran bootstrap and testsuite of all languages including Ada and ObjC++ on x86_64. It survived, which makes me wondering whether we do not want it in trunk. What do you think? Martin 2013-05-22 Martin Jambor

[PATCH, PR 57347] Do not create aggregate jump functions for bit-fields

2013-05-22 Thread Martin Jambor
, Martin 2013-05-21 Martin Jambor PR middle-end/57347 * tree.h (contains_bitfld_component_ref_p): Declare. * tree-sra.c (contains_bitfld_comp_ref_p): Move... * tree.c (contains_bitfld_component_ref_p): ...here. Adjust its caller. * ipa-prop.c

Re: [PATCH] Do not allow non-top-level BIT_FIELD_REFs, IMAGPART_EXPRs or REALPART_EXPRs

2013-05-24 Thread Martin Jambor
which is that the type of the 3 nodes is always scalar. > > The non-toplevelness of the nodes is merely a consequence of this property. > > Yeah. But please put the verification into tree-cfg.c:verify_expr > instead. > Like this? Also bootstrapped and tested on x86_64-lin

[PATCH, PR 57294] Update symbol table references in IPA-SRA

2013-05-24 Thread Martin Jambor
for trunk? Thanks, Martin 2013-05-24 Martin Jambor * cgraph.h (ipa_record_stmt_references): Declare. * cgraphbuild.c (ipa_record_stmt_references): New function. (build_cgraph_edges): Use ipa_record_stmt_references. (rebuild_cgraph_edges): Likewise

Re: [PATCH] Do not allow non-top-level BIT_FIELD_REFs, IMAGPART_EXPRs or REALPART_EXPRs

2013-05-28 Thread Martin Jambor
Hi, On Mon, May 27, 2013 at 10:02:19AM +0200, Richard Biener wrote: > On Fri, 24 May 2013, Martin Jambor wrote: > > > Hi, > > > > On Thu, May 23, 2013 at 11:38:10AM +0200, Richard Biener wrote: > > > On Thu, 23 May 2013, Eric Botcazou wrote: > > >

Re: [PATCH] Do not allow non-top-level BIT_FIELD_REFs, IMAGPART_EXPRs or REALPART_EXPRs

2013-05-29 Thread Martin Jambor
Hi, On Tue, May 28, 2013 at 03:40:25PM +0200, Richard Biener wrote: > On Tue, 28 May 2013, Martin Jambor wrote: > > I've committed it s revision 199379, thanks. As far as the > > non-top-levelness is concerned, the following (on top of the previous > > patch) a

Re: [GOOGLE] More strict checking for call args

2013-06-06 Thread Martin Jambor
f it does and the patch passes bootstrap and tests, is it OK for trunk and 4.8 branch? Thanks and sorry for the trouble, Martin 2013-06-06 Martin Jambor * ipa-cp.c (ipa_get_indirect_edge_target_1): Check that param_index is wi

Re: [GOOGLE] More strict checking for call args

2013-06-10 Thread Martin Jambor
n 2013-06-07 Martin Jambor * ipa-cp.c (ipa_get_indirect_edge_target_1): Check that param_index is within bounds at the beginning of the function. Index: src/gcc/ipa-cp.c === --- src.orig/gcc/ipa-cp.c +++ sr

[PATCH, PR 57539] Fix refdesc remapping during inlining

2013-06-12 Thread Martin Jambor
ost a testcase in a separate patch. This one bootstrapped and passed testsuite on x86_64-linux without any issues. OK for trunk? Thanks, Martin 2013-06-10 Martin Jambor PR tree-optimization/57539 * cgraphclones.c (cgraph_clone_node): Add parameter new_inlined_to

Re: [PATCH, PR 57539] Testcase produced by multidelta and indent

2013-06-12 Thread Martin Jambor
Hi, On Wed, Jun 12, 2013 at 01:59:29PM +0200, Martin Jambor wrote: > 2013-06-10 Martin Jambor > > PR tree-optimization/57539 > * cgraphclones.c (cgraph_clone_node): Add parameter new_inlined_to, set > global.inlined_to of the new node to it. All

[PATCH, 4.8, PR57358] Check if optimizing in parm_ref_data_preserved_p

2013-06-12 Thread Martin Jambor
Hi, this is the simplest fix for the PR which happens because there is no VDEF on a stmt if a particular function is not optimized. I'd like to fix the bug with it on the branch. Bootstrapped and tested on x86_64-linux. OK? Thanks, Martin 2013-06-11 Martin Jambor PR

[PATCH, trunk, PR57358] Avoid IPA-CP analysis if attribute optimize precludes it

2013-06-12 Thread Martin Jambor
/analysis. Bootstrapped and tested on x86_64-linux. OK for trunk? Thanks, Martin 2013-06-11 Martin Jambor PR tree-optimization/57358 * ipa-prop.c (ipa_func_spec_opts_forbid_analysis_p): New function. (ipa_compute_jump_functions_for_edge): Bail out if it returns true

Re: [PATCH, 4.9, PR 61654] Handle newly truly expanded artificial_thunks

2014-09-10 Thread Martin Jambor
On Wed, Sep 03, 2014 at 10:45:34AM +0200, Martin Jambor wrote: > Hi, > > I did not think it was possible, but it can happen that when > duplicate_thunk_for_node creates a duplicate of a thunk which > previously expand_thunk left alone to be expanded into assembly by the > b

[PATCH] Fix overactive reference removal with speculative devirtualization

2014-09-23 Thread Martin Jambor
later. Bootstrapped and tested on x86_64-linux, I have also successfully LTO-built Firefox with the patch (when before it was failing). Thanks, Martin 2014-09-19 Martin Jambor * ipa-prop.c (ipa_edge_duplication_hook): Update controlled_use_count when duplicating a PASS_THROUGH

[hsa] Pass kernel range to libgomp

2014-09-25 Thread Martin Jambor
e hsa branch. Thanks, Martin 2014-09-26 Martin Jambor gcc/ * hsa-gen.c (hsa_dim_array_type, hsa_range_dimnum_decl) (hsa_range_grid_decl, hsa_range_group_decl) (hsa_launch_range_type): New variables. (init_hsa_functions): Also build the type of range stru

[hsa] Introduce hsakernel function attribute

2014-09-25 Thread Martin Jambor
). Bootstrapping only showed there were no warnings, I have tested this with some later patches on a number of OMP testcases. Committed to the HSA branch. Thanks, Martin 2014-09-26 Martin Jambor gcc/ * hsa-gen.c (insert_store_range_dim): Make value parameter a tree. (wrap_hsa

[hsa] Identify simple omp loops

2014-09-25 Thread Martin Jambor
patches on a number of OMP testcases. Committed to the HSA branch. Thanks, Martin 2014-09-26 Martin Jambor * omp-low.c (struct omp_region): New flag kernelize. (analyze_kernelizability): New function. (expand_omp): Call it. New parameter within_parallel, update all

[hsa] Produce naked kernels for simple omp loops

2014-09-25 Thread Martin Jambor
and tested it on a number of OMP testcases and it did not introduce any new failures. Committed to the hsa branch. Thanks, Martin 2014-09-26 Martin Jambor * gimple.c (gimple_build_omp_for): Allocate prev_first_iter. * gimple.h (gimple_statement_omp_for): New field or

[hsa] Upgrade to HSAIL 1.0p

2014-09-25 Thread Martin Jambor
o the HSA branch. Thanks, Martin 2014-09-26 Ganesh Gopalasubramanian Martin Jambor * hsa-brig-format.h: Update to HSA 1.0p. * hsa-brig.c: Remove strtab, directives and debug sections. (hsa_brig_section): New fields section_name and header_byte_

[hsa] Feed OKRA with BRIG and new README.hsa

2014-09-25 Thread Martin Jambor
OKRA world. Verified by running the same set of OMP testcases, committed to the hsa branch. Thanks, Martin libgomp/ 2014-09-26 Saravanan Ekanathan * hsaokra.c (__hsa_launch_kernel): Use BRIG generated by GCC directly to launch kernel. gcc/ 2014-09-26 Martin Jambor

[PATCH, PR 63375] Make SRA check references for volatility

2014-10-01 Thread Martin Jambor
on x86_64-linux. OK for trunk and for the maintained release branches after re-testing there? Thanks, Martin 2014-09-26 Martin Jambor PR tree-optimization/63375 * tree-sra.c (build_access_from_expr_1): Disqualify volatile references. diff --git a/gcc/tree-sra.c b

Re: [PATCH, trunk, PR57358] Avoid IPA-CP analysis if attribute optimize precludes it

2013-06-20 Thread Martin Jambor
Hi, On Thu, Jun 20, 2013 at 01:32:38PM +0200, Jan Hubicka wrote: > > > > 2013-06-11 Martin Jambor > > > > PR tree-optimization/57358 > > * ipa-prop.c (ipa_func_spec_opts_forbid_analysis_p): New function. > > (ipa_compute_jump_functions_fo

Re: [PATCH] Redirect calls to non-functions to builtin_unreachable

2013-06-20 Thread Martin Jambor
sHi, On Thu, Jun 20, 2013 at 03:47:11PM +0100, Marcus Shawcroft wrote: > Hi, I've been looking at an issue in mysql compilation which appears > to be due to this patch. > > On 10 May 2013 18:27, Martin Jambor wrote: > > Hi, > > > > as we discover targets

[PATCH, PR 57670] Do not turn member pointers to builtin_unreachable

2013-06-24 Thread Martin Jambor
still available in indirect info and the added complexity of overloading the flag quickly turned ugly. Bootstrapped and tested on x86_64-linux. OK for trunk? Thanks and sorry for the confusion, Martin 2013-06-21 Martin Jambor PR middle-end/57670 * cgraph.h

Re: [PATCH] Redirect calls to non-functions to builtin_unreachable

2013-06-24 Thread Martin Jambor
Hi, On Thu, Jun 20, 2013 at 05:46:28PM +0200, Martin Jambor wrote: > On Thu, Jun 20, 2013 at 03:47:11PM +0100, Marcus Shawcroft wrote: > > Hi, I've been looking at an issue in mysql compilation which appears > > to be due to this patch. > > > > On 10 May

[PATCH, PR 57208] Add ipa-cp created references to the symbol table

2013-06-25 Thread Martin Jambor
2013-06-24 Martin Jambor PR lto/57208 * ipa-cp.c (create_specialized_node): Add newly created references to the symbol table. Index: src/gcc/ipa-cp.c === --- src.orig/gcc/ipa-cp.c +++ src/gcc/ipa-cp.c

Re: [PATCH, PR 57208] Add ipa-cp created references to the symbol table

2013-06-26 Thread Martin Jambor
> > infrastructure). > > > > Bootstrapped and tested on x86_64-linux. OK for trunk? > > > > Thanks, > > > > Martin > > > > > > 2013-06-24 Martin Jambor > > > > PR lto/57208 > > * ipa-cp.c (create_specializ

Re: [PATCH 3/4] Introduce NEXT_PASS_NUM macro

2013-07-22 Thread Martin Jambor
Hi, On Wed, Jul 17, 2013 at 09:18:22PM -0400, David Malcolm wrote: > gcc/ > > Explicitly number the instances of passes within passes.def. > > This is needed by a subsequent patch so that we can create > fields within the pipeline class for each pass instance (to help > l

Re: [PATCH 3/4] Introduce NEXT_PASS_NUM macro

2013-07-23 Thread Martin Jambor
Hi, On Mon, Jul 22, 2013 at 03:22:33PM -0400, David Malcolm wrote: > On Mon, 2013-07-22 at 20:25 +0200, Martin Jambor wrote: > > On Wed, Jul 17, 2013 at 09:18:22PM -0400, David Malcolm wrote: > > > gcc/ > > > > > > Explicitly number the i

Re: [PATCH 3/4] Introduce NEXT_PASS_NUM macro

2013-07-24 Thread Martin Jambor
Hi, On Tue, Jul 23, 2013 at 11:43:04AM -0400, David Malcolm wrote: > On Tue, 2013-07-23 at 16:46 +0200, Martin Jambor wrote: > > Hi, > > > > On Mon, Jul 22, 2013 at 03:22:33PM -0400, David Malcolm wrote: > > > On Mon, 2013-07-22 at 20:25 +0200, Martin Jambor wrote

Re: [PATCH 2/2] Introduce beginnings of a pipeline class.

2013-07-25 Thread Martin Jambor
Hi, On Wed, Jul 24, 2013 at 08:27:43PM -0400, David Malcolm wrote: > On Wed, 2013-07-24 at 19:10 -0400, Diego Novillo wrote: > > On Wed, Jul 24, 2013 at 6:56 PM, Diego Novillo wrote: > > > Could you please add a description of what this does? > > > > Sorry. You did, but in a previous message th

Re: [PATCH 2/2] Introduce beginnings of a pipeline class.

2013-07-25 Thread Martin Jambor
Hi, I don't know why it's me again but again I do have a few comments. One global remark first: If we are going to start using the gcc namespace (I understand it you need for isolation of symbols once you use gcc as library, right?), I'm wondering whether mixing "using namespace gcc" and explicit

Re: C++ coding conventions: namespaces, references and getters (was Re: [PATCH 2/2] Introduce beginnings of a pipeline class.)

2013-07-30 Thread Martin Jambor
Hi, thanks for the email I was supposed to write. On Mon, Jul 29, 2013 at 02:20:02PM -0400, David Malcolm wrote: > On Thu, 2013-07-25 at 15:08 +0200, Martin Jambor wrote: > > Hi, > > > > I don't know why it's me again but again I do have a few comments. > &

Re: C++ coding conventions: namespaces, references and getters (was Re: [PATCH 2/2] Introduce beginnings of a pipeline class.)

2013-07-30 Thread Martin Jambor
Hi, On Mon, Jul 29, 2013 at 09:02:53PM +0200, Oleg Endo wrote: > On Mon, 2013-07-29 at 14:20 -0400, David Malcolm wrote: > > > > > > The same here and at a few other places. It may be just me not being > > > used to references... nevertheless, if someone really wants to use > > > them like this,

Re: Do not use PARM_DECLs in ipa-cp and ipa-prop

2013-08-01 Thread Martin Jambor
Hi, On Thu, Aug 01, 2013 at 03:11:36PM +0200, Jan Hubicka wrote: > Hi, > this is preparation work to move DECL_ARGUMENTS and DECL_RESULT into function > sections during WPA. Even with some work to release unused ones, there are 4M > of PARM_DECLs and 2M of RESULT_DECLs streamed during LTO (for 6M

Re: Do not use PARM_DECLs in ipa-cp and ipa-prop

2013-08-01 Thread Martin Jambor
Hi, On Thu, Aug 01, 2013 at 03:59:01PM +0200, Richard Biener wrote: > Jan Hubicka wrote: > >Hi, > >this is preparation work to move DECL_ARGUMENTS and DECL_RESULT into > >function > >sections during WPA. Even with some work to release unused ones, there > >are 4M > >of PARM_DECLs and 2M of RESUL

Re: Do not use PARM_DECLs in ipa-cp and ipa-prop

2013-08-02 Thread Martin Jambor
Hi, On Thu, Aug 01, 2013 at 05:48:20PM +0200, Jan Hubicka wrote: > > On Thu, Aug 01, 2013 at 03:11:36PM +0200, Jan Hubicka wrote: > > > Hi, > > > this is preparation work to move DECL_ARGUMENTS and DECL_RESULT into > > > function > > > sections during WPA. Even with some work to release unused o

[PATCH, Fortran, PR 57987] Do not call cgraph_finalize_function multiple times on finalizers

2013-08-02 Thread Martin Jambor
any problems, OK for trunk? Thanks, Martin 2013-08-01 Martin Jambor * cgraphunit.c (cgraph_finalize_function): Assert that nested function is not re-finalized. Rename second parameter to no_collect. fortran/ * trans-decl.c (gfc_generate_functi

[PATCH, PR 57748] Set mode of structures with zero sized arrays to be BLK

2013-08-02 Thread Martin Jambor
this PR does not happen there despite the wrong mode so I'd ignore it for now.) Thanks, Martin 2013-08-01 Martin Jambor PR middle-end/57748 * stor-layout.c (compute_record_mode): Treat zero-sized array fields like incomplete types. testsuite/ * gcc.

Re: C++ coding conventions: namespaces, references and getters (was Re: [PATCH 2/2] Introduce beginnings of a pipeline class.)

2013-08-05 Thread Martin Jambor
Hi, On Fri, Aug 02, 2013 at 11:30:01PM -0500, Gabriel Dos Reis wrote: > [ Adding Benjamin, Diego, Lawrence ] > > General remarks first: > When we designed the coding standards for GCC, an overriding > philosophy was that we did not want to be prescriptive. Rather, we > explicitly wanted to encou

Re: [PATCH, Fortran, PR 57987] Do not call cgraph_finalize_function multiple times on finalizers

2013-08-05 Thread Martin Jambor
Hi, On Sat, Aug 03, 2013 at 01:12:41PM +0200, Dominique Dhumieres wrote: > Hi Martin, > > I have applied the patch on top of r201441 and I still get the warning for > gcc/testsuite/gfortran.dg/class_48.f90 with -m32 -O(2|s): > > /opt/gcc/work/gcc/testsuite/gfortran.dg/class_48.f90: In function

[PATCH, PR 58041] Make gimple-ssa-strenght-reduction.c create MEM_REFs with alignment information

2013-08-05 Thread Martin Jambor
on on x86_64-linux, Bill Schmidt did the same on powerpc64-unknown-linux-gnu and it also got some testing on ARM. OK for trunk (and I think also the 4.8 branch needs it)? Thanks, Martin 2013-08-05 Martin Jambor PR middle-end/58041 * gimple-ssa-strength-reduction.c (repla

Re: [PATCH] Convert more passes to new dump framework

2013-08-06 Thread Martin Jambor
Hi, On Mon, Aug 05, 2013 at 10:37:00PM -0700, Teresa Johnson wrote: > This patch ports messages to the new dump framework, It would be great this new framework was documented somewhere. I lost track of what was agreed it would be and from the uses in the vectorizer I was never quite sure how to

Re: [PATCH] Convert more passes to new dump framework

2013-08-06 Thread Martin Jambor
Hi, On Tue, Aug 06, 2013 at 07:14:42AM -0700, Teresa Johnson wrote: > On Tue, Aug 6, 2013 at 5:37 AM, Martin Jambor wrote: > > On Mon, Aug 05, 2013 at 10:37:00PM -0700, Teresa Johnson wrote: > >> This patch ports messages to the new dump framework, > > > > It wou

Re: [PATCH] Convert more passes to new dump framework

2013-08-06 Thread Martin Jambor
On Tue, Aug 06, 2013 at 09:22:02AM -0700, Sharad Singhai wrote: > On Tue, Aug 6, 2013 at 8:57 AM, Xinliang David Li wrote: > > On Tue, Aug 6, 2013 at 5:37 AM, Martin Jambor wrote: > >> Hi, > >> > >> On Mon, Aug 05, 2013 at 10:37:00PM -0700, Teresa Johnson wr

[PATCH] Fix PR 58041 testcase failuers on i686

2013-08-06 Thread Martin Jambor
testing, Martin 2013-08-06 Martin Jambor Bernd Edlinger testsuite/ * gcc.dg/torture/pr58041.c (foo): Accept z by reference. (a): Fix constructor. diff --git a/gcc/testsuite/gcc.dg/torture/pr58041.c b/gcc/testsuite/gcc.dg/torture/pr58041.c index e22ec3c..169a71a

Re: [PATCH, PR 57539] Testcase produced by multidelta and indent

2013-08-06 Thread Martin Jambor
there will be no problems but of course I'll revert it immediately if any occur (more information why trouble may happen below in the original mail). Martin On Wed, Jun 12, 2013 at 02:13:45PM +0200, Martin Jambor wrote: > Hi, > > On Wed, Jun 12, 2013 at 01:59:29PM +0200, Martin Jam

[PATCH, PR 56294] Create all replacements upfront

2013-02-27 Thread Martin Jambor
es an -fdebug-compare regression. OK for trunk? Thanks, Martin 2013-02-25 Martin Jambor PR tree-optimization/56294 * tree-sra.c (analyze_access_subtree): Create replacement declarations. Adjust dumping. (get_access_replacement): Do not

[PATCH] Avoid SRA-created debug binds with uninitialized RHSs

2013-02-27 Thread Martin Jambor
required to fix PR 56294 but the patch is tiny and simply avoids unnecessary work so I'd like to ask for approval to commit to trunk now. Thanks, Martin 2013-02-26 Martin Jambor * tree-sra.c (load_assign_lhs_subreplacements): Do not put replacements with no initializati

[PATCH] Make get_or_create_ssa_default_def consistently use the fn parameter

2013-03-04 Thread Martin Jambor
. Given that all current callers pass cfun as the first parameter I believe this is so low risk that I'd like to commit it to trunk even though it does not really cause any regression. However, I'm also fine with waiting for stage1. What do you think? Thanks, Martin 2013-03-04 Mar

[PATCH] Incorporate INLINE_HINT_array_index in IPA-CP heuristics

2013-03-20 Thread Martin Jambor
, I plan to re-examine them once we have better aggregate jump functions and we start getting these hints in real Fortran benchmarks. Bootstrapped and tested on x86_64-linux. OK for trunk? Thanks, Martin 2013-01-21 Martin Jambor * params.def (PARAM_IPA_CP_ARRAY_INDEX_HINT_BONUS

[PATCH] Remove the PR 55334 IPA-CP hack

2013-03-23 Thread Martin Jambor
well, it's really a rollback of my previous patch). We can continue to track the issue as PR 55334. Let's hope I won't be adding this very same hunk again in stage 3 ;-) Martin 2013-02-07 Martin Jambor PR tree-optimization/55334 * ipa-cp.c (initialize_node_lat

<    8   9   10   11   12   13   14   15   16   17   >