Go patch committed: Pass -t to native linker on Solaris

2014-06-13 Thread Ian Lance Taylor
case is useless. This patch passes the -t option to disable the warning. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Bootstrapped and ran a few tests on x86_64-sun-solaris. Committed to mainline. Ian 2014-06-13 Ian Lance Taylor PR go/61496

Re: Go patch committed: Pass -t to native linker on Solaris

2014-06-16 Thread Ian Lance Taylor
On Mon, Jun 16, 2014 at 3:56 AM, Rainer Orth wrote: > > Works fine, thanks. Just before your patch arrived, I meant to test the > following, slightly more general patch. Perhaps it's an option to > handle other quirks like this? This approach is fine with me, but the target macro should be docu

Re: Go patch committed: Pass -t to native linker on Solaris

2014-06-16 Thread Ian Lance Taylor
On Mon, Jun 16, 2014 at 6:58 AM, Ian Lance Taylor wrote: > On Mon, Jun 16, 2014 at 3:56 AM, Rainer Orth > wrote: >> >> Works fine, thanks. Just before your patch arrived, I meant to test the >> following, slightly more general patch. Perhaps it's an option to >

libgo patch committed: add benchmark input files

2014-06-24 Thread Ian Lance Taylor
This patch from Peter Collingbourne adds some benchmark input files that were missing from the gofrontend repository. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. The patch adds binary files. The size of the patch is too large to attach, and the files ar

libgo patch committed: Build targets for benchmarks

2014-07-01 Thread Ian Lance Taylor
This patch from Peter Collingbourne makes it easier to run the libgo benchmarks using "make bench" in the libgo build directory. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 7650eafca8af libgo/Makefile.am --- a/libgo/Makefile.am Tue Jun 24 16:4

libgo patch committed: Don't explicitly free tiny blocks

2014-07-02 Thread Ian Lance Taylor
This patch fixes libgo to not explicitly free tiny blocks when deleting an entry from a map. The memory allocator now has a special case for tiny objects (less than 16 bytes), and they can not be explicitly freed, only garbage collected. This is PR go/61620. Bootstrapped and ran Go testsuite on

Re: [PATCH, libbacktrace]: fix pointer from integer without a cast

2014-07-05 Thread Ian Lance Taylor
On Thu, Jul 3, 2014 at 2:34 AM, Duncan Mac-Vicar P. wrote: > > the following patch fixes some post-build-checks from our distro build > system, better to upstream it: > > [ 4077s] E: rust 64bit-portability-issue > /home/abuild/rpmbuild/BUILD/rust-0.11.0+git.1403898616.aa1163b/src/libbacktrace/dwar

gccgo patch committed: If unary & does not escape, variable does not escape

2015-05-12 Thread Ian Lance Taylor
This patch to the Go frontend notes that if a unary & of a variable was marked as not escaping, then we don't need to set it to be escaping based on the variable. Bootstrapped and ran ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r d50f4d14cfec go/expressions.cc

Re: [patch] Clean up detection of SJLJ exceptions in target libraries

2015-05-13 Thread Ian Lance Taylor
On Tue, May 12, 2015 at 9:42 AM, Eric Botcazou wrote: > > 6 target libraries in the tree detect whether they are being compiled by a > compiler configured for setjmp/longjmp exceptions: libada, libgcc, libgo, > libjava, libobjc and libstdc++. They can be divided into 3 categories: > 1) libada on

Re: [patch] Clean up detection of SJLJ exceptions in target libraries

2015-05-15 Thread Ian Lance Taylor
On Wed, May 13, 2015 at 10:52 AM, Eric Botcazou wrote: >> The libgo parts are fine, but since libgo is mirrored from an external >> repository I'll commit those parts myself. > > Thanks! > >> I assume I can go ahead and commit them now? > > Yes, you can, the libgo bits are independent. libgo port

Re: [PATCH/libiberty] fix build of gdb/binutils with clang.

2015-05-18 Thread Ian Lance Taylor
On Mon, May 18, 2015 at 4:26 PM, Yunlian Jiang wrote: > > Yes, the problem is libiberty is compiling some files > with _GNU_SOURCE defined and some not. So the configure > file does not include "#define _GNU_SOURCE". As far as I can see it should be fine to define _GNU_SOURCE when compiling all

Re: [PATCH/libiberty] fix build of gdb/binutils with clang.

2015-05-19 Thread Ian Lance Taylor
On Tue, May 19, 2015 at 11:08 AM, Yunlian Jiang wrote: > > I could do that and it make the compilation of libiberty passes. > However, I have some other problem when using clang to build gdb > because of libiberty. > > Some c file from other component may include 'libiberty.h' which contains > th

Re: [PATCH/libiberty] fix build of gdb/binutils with clang.

2015-05-20 Thread Ian Lance Taylor
Floor, Boston, MA > 02110-1301, USA. */ > > /* This is needed to pick up the NAN macro on some systems. */ > +#ifndef _GNU_SOURCE > #define _GNU_SOURCE > +#endif > > #ifdef HAVE_CONFIG_H > #include "config.h" > > On Tue, May 19, 2015 at 11:15 AM, Ian

Re: [PATCH/libiberty] fix build of gdb/binutils with clang.

2015-05-22 Thread Ian Lance Taylor
On Wed, May 20, 2015 at 3:58 PM, Yunlian Jiang wrote: > GCC bootstraps with this patch. Committed as follows. Ian include/: 2015-05-22 Yunlian Jiang * libiberty.h (asprintf): Don't declare if HAVE_DECL_ASPRINTF is not defined. libiberty/: 2015-05-22 Yunlian Jiang * configure.ac: Add

Re: [gofrontend-dev] Re: GO tools for gccgo cross

2015-05-22 Thread Ian Lance Taylor
On Fri, May 22, 2015 at 2:01 PM, Andrew Chambers wrote: >> >> For example, I've tested on an x86, built cross compilers for ppc64 and >> ppc64le and then can invoke the native go tool (built to run on x86) to >> compile with either target compiler by changing my GOARCH value. I don't >> want to h

Re: [gofrontend-dev] Re: GO tools for gccgo cross

2015-05-22 Thread Ian Lance Taylor
On Fri, May 22, 2015 at 3:11 PM, Andrew Chambers wrote: > > I'm not suggesting breaking go conventions, I just think the default if no > GOARCH is specified then it should match --target. Sounds good to me. > Perhaps we could check the symlink name for the target triple if no GOARCH > is set. W

Re: [Patch]: libbacktrace - add support of PE/COFF

2015-05-22 Thread Ian Lance Taylor
On Thu, May 21, 2015 at 5:41 AM, Tristan Gingold wrote: > > 2015-05-21 Tristan Gingold > > * pecoff.c: New file. > * Makefile.am (FORMAT_FILES): Add pecoff.c and dependencies. > * Makefile.in: Regenerate. > * filetype.awk: Detect pecoff. > * configure.ac:

Re: [gofrontend-dev] Re: GO tools for gccgo cross

2015-05-26 Thread Ian Lance Taylor
On Tue, May 26, 2015 at 9:17 AM, Lynn A. Boger wrote: > > On 05/22/2015 05:50 PM, Ian Lance Taylor wrote: >> >> On Fri, May 22, 2015 at 3:11 PM, Andrew Chambers >> wrote: >>> >>> I'm not suggesting breaking go conventions, I just think the default i

Re: [Patch]: libbacktrace - add support of PE/COFF

2015-05-27 Thread Ian Lance Taylor
On Wed, May 27, 2015 at 6:36 AM, Jeff Law wrote: > On 05/21/2015 06:41 AM, Tristan Gingold wrote: >> >> Hello, >> >> this patch adds basic support to libbacktrace for PE32 and PE32+ (Windows >> and Windows64 object formats). >> Support is ‘basic’ because neither DLL nor PIE (if that exists) are >>

Re: [Patch]: libbacktrace - add support of PE/COFF

2015-05-28 Thread Ian Lance Taylor
On Thu, May 28, 2015 at 5:01 AM, Tristan Gingold wrote: > >> On 28 May 2015, at 02:26, Ian Lance Taylor wrote: > >> The #include will break cross-compilers. It's not OK for >> trunk until that is fixed. > > I am confused by this comment, for two reasons: >

Re: [PATCH v3] libiberty: cleanup Makefile.in

2015-05-28 Thread Ian Lance Taylor
On Thu, May 28, 2015 at 1:57 AM, Bernhard Reutner-Fischer wrote: > > +stamp-pic-ofiles: $(CFILES:%=$(srcdir)/%) To the best of my knowledge, in POSIX make variable substitutions of this form do not recognize % specially. In POSIX make this kind of substitution can only be used to change the file

Re: [Patch]: libbacktrace - add support of PE/COFF

2015-05-29 Thread Ian Lance Taylor
On Fri, May 29, 2015 at 1:43 AM, Tristan Gingold wrote: > >> On 28 May 2015, at 17:14, Ian Lance Taylor wrote: >> >> The way you have written the code, I'm fairly sure that it will be >> compiled for an i386-coff target. > > And the only coff target supporte

Re: Go patch committed: Fix PR 65755 on GCC 5 branch

2015-04-17 Thread Ian Lance Taylor
On Tue, Apr 14, 2015 at 11:48 AM, Ian Lance Taylor wrote: > This patch to the GCC 5 branch fixes PR 65755. This is a conservative > patch for the branch. I will shortly apply a more complete, less > conservative, patch to trunk. This patch simply adds the receiver > type when p

libgo patch committed: Adjust libbacktrace PC value in runtime_callers callback

2015-04-17 Thread Ian Lance Taylor
The libbacktrace library returns a PC that was (usually) decremented to be part of the call instruction. The Go code that uses runtime.Callers does not expect this, and Go code that adjusts the PC value, such as libgo/go/runtime/pprof/pprof.go, can get fooled by it. This leads to GCC PRs 64999 and

Re: libgo patch committed: Adjust libbacktrace PC value in runtime_callers callback

2015-04-17 Thread Ian Lance Taylor
On Fri, Apr 17, 2015 at 1:03 PM, wrote: > On 04/17/2015 01:29 PM, Ian Lance Taylor wrote: >> >> The libbacktrace library returns a PC that was (usually) decremented >> to be part of the call instruction. The Go code that uses >> runtime.Callers does not expect this, a

libgo patch committed: Skip runtime functions with no name in runtime/pprof

2015-04-17 Thread Ian Lance Taylor
GCC PR 65797 causes some of the runtime functions to be compiled with no name in the debug info. This in turn causes the runtime/pprof test to fail as reported in GCC PR 64683. There are no good choices when a function has no name in the debug info, but this patch assumes that if we see such a fu

libgo patch committed: in runtime.Caller don't return ok as true if PC == 0

2015-04-17 Thread Ian Lance Taylor
PR 65798 says that in some cases runtime.Caller can return with ok == true when PC == 0. It's not clear to me quite how that can happen, but it's easy to avoid with this patch. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline and GCC 5 branch. Ian diff -r 400

libgo patch committed: Compile go-main with -fPIC

2015-04-24 Thread Ian Lance Taylor
PR 65616 points out that you can't use gccgo to build a PIE because go-main.c is not compiled with -fPIC. This patch fixes that. I could have used -fPIE, but -fPIC is essentially the same here and seems more flexible. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to m

libgo patch committed: Support -buildmode=c-archive

2015-04-29 Thread Ian Lance Taylor
The upcoming Go 1.5 release of the gc compiler adds support for "go build -buildmode=c-archive". This can be used to build Go code into an archive (a .a file) that can be linked with a non-Go program, such that the non-Go program can call into Go code. This patch adds support for that to gccgo.

Go patch committed: Propagate escape info from closures to enclosed variables

2015-04-29 Thread Ian Lance Taylor
This patch from Chris Manghane fixes the Go frontend to propagate escape information from closures to the enclosed variables to which they refer. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 0010ef165479 go/escape.cc --- a/go/escape.cc We

Go patch committed: Fix escape analysis for multi-result calls

2015-04-29 Thread Ian Lance Taylor
This patch from Chris Manghane fixes the handling of multi-result calls in escape analysis. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 76359c093067 go/escape.cc --- a/go/escape.cc Wed Apr 29 15:09:15 2015 -0700 +++ b/go/escape.cc W

Go patch committed: Mark non-escaping variables whose address is not taken

2015-04-30 Thread Ian Lance Taylor
This patch from Chris Manghane marks variables whose address is not taken as not escaping. This is needed because for some types there are ways for the variable to escape even without taking its address. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian dif

Go patch committed: escape analysis of function values and conversions

2015-04-30 Thread Ian Lance Taylor
This patch from Chris Manghane improves the analysis of function values and type conversions. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 4e348e019b8f go/escape.cc --- a/go/escape.cc Thu Apr 30 10:21:02 2015 -0700 +++ b/go/escape.cc

Go patch committed: Use alloca for non-escaping new expressions

2015-04-30 Thread Ian Lance Taylor
This patch from Chris Manghane changes the Go frontend to use allocate for non-escaping new expressions. Previously it was using a temporary variable, which failed when the new expression was in a loop. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian 20

Re: [PATCH/libiberty] fix build of gdb/binutils with clang.

2015-05-01 Thread Ian Lance Taylor
On Tue, Apr 28, 2015 at 2:59 PM, Yunlian Jiang wrote: > I believe this is the same problem as > https://gcc.gnu.org/ml/gcc-patches/2008-07/msg00292.html > > The asprinf declaration is messed up when using clang to build gdb. > > diff --git a/include/libiberty.h b/include/libiberty.h > index b33dd

Re: [PATCH/libiberty] fix build of gdb/binutils with clang.

2015-05-02 Thread Ian Lance Taylor
to set HAVE_DECL_ASPRINTF) not have #define _GNU_SOURCE? What is the background here? Ian > On Fri, May 1, 2015 at 3:45 PM, Ian Lance Taylor wrote: >> On Tue, Apr 28, 2015 at 2:59 PM, Yunlian Jiang wrote: >>> I believe this is the same problem as >>> https://gcc.gnu.org/ml/

Re: [PATCH/libiberty] fix build of gdb/binutils with clang.

2015-05-04 Thread Ian Lance Taylor
On Mon, May 4, 2015 at 3:49 PM, Yunlian Jiang wrote: > There was a similar disscussion here > https://gcc.gnu.org/ml/gcc/2005-11/msg01190.html That was a discussion about libiberty. Your subject says you have trouble building gdb. Can you describe the exact problem that you are having? What pr

libgo patch committed: Permit nil Func in Func.Name

2015-05-05 Thread Ian Lance Taylor
The gc toolchain permits Func to be nil when calling the runtime.Func.Name method, returning an empty string. This patch changes libgo to do the same, rather than crashing. This is GCC PR 66016. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline and 4.9 branch.

Re: libgo patch committed: Permit nil Func in Func.Name

2015-05-05 Thread Ian Lance Taylor
On Tue, May 5, 2015 at 10:35 AM, Andreas Schwab wrote: > Ian Lance Taylor writes: > >> Committed to mainline and 4.9 branch. > > What about the 5 branch? Oh yeah. Thanks. Committing to GCC 5 branch shortly, after tests complete. Ian

Go patch committed: Don't make temporaries for string concatenation of constants

2015-05-05 Thread Ian Lance Taylor
This patch from Chris Manghane changes the Go frontend to not use temporaries for constants when doing string concatenation. This fixes http://golang.org/issue/10642. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline and GCC 5 branch. Ian diff -r b2bef4b0764a

Go patch committed: Better escape analysis for interface parameters

2015-05-06 Thread Ian Lance Taylor
This patch from Chris Manghane improves escape analysis for interface parameters. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r aaa6df965e1f go/escape.cc --- a/go/escape.cc Tue May 05 13:56:24 2015 -0700 +++ b/go/escape.cc Wed May 06

Re: [patch 4/28] gotools: Use automake-1.11.6 (across the tree)

2015-05-07 Thread Ian Lance Taylor
The patches to gotools and libbacktrace are fine if the rest of the patches are approved. I will handle the patch to libgo, which is copied from a different repository. Please do not commit it yourself. Thanks. Ian Michael Haubenwallner writes: > Patch for gotools. > > Am 2015-05-05 um 18:0

Re: [debug-early] fix -fdump-go-spec

2015-05-08 Thread Ian Lance Taylor
On Wed, Apr 29, 2015 at 5:56 PM, Aldy Hernandez wrote: > > Despite what Go thinks: > > /* The debug hooks are used to implement -fdump-go-spec because it > gives a simple and stable API for all the information we need to > dump. */ > > ...the debug hooks are not stable... :). Alas.

Re: [patch 5/10] debug-early merge: Go front-end

2015-05-08 Thread Ian Lance Taylor
This is fine if it works. Thanks. Ian On Thu, May 7, 2015 at 5:36 PM, Aldy Hernandez wrote: >

libgo patch committed: Fix runtime/pprof test when libgo compiled with -O0

2015-05-11 Thread Ian Lance Taylor
The runtime/pprof package builds stack traces that skip runtime functions. When libgo is compiled with -O0, the function profilealloc appears on the stack trace, but the package doesn't know to skip it. Rename the function so that it is skipped. This lets the runtime/pprof test pass when libgo is

Re: [PATCH] libiberty: cleanup Makefile.in

2015-05-11 Thread Ian Lance Taylor
Joseph Myers writes: > On Mon, 11 May 2015, Bernhard Reutner-Fischer wrote: > >> +TARGETLIB_PIC = $(dir $(TARGETLIB))pic/$(notdir $(TARGETLIB)) >> +TARGETLIB_NOASAN = $(dir $(TARGETLIB))noasan/$(notdir $(TARGETLIB)) > > Is it OK to use GNU make features in libiberty now? That is, do binutils >

libgo patch committed: Use ppc64le for little-endian 64-bit PowerPC architecture

2014-11-21 Thread Ian Lance Taylor
This patch by Lynn A. Boger changes libgo to use ppc64le for little-endian 64-bit PowerPC. Bootstrapped and ran testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 96de84075614 libgo/configure.ac --- a/libgo/configure.acTue Nov 18 09:28:24 2014 -0800 +++ b/libgo/con

Re: [PATCH] Set goarch to ppc64le where needed for gccgo testing

2014-11-21 Thread Ian Lance Taylor
On Wed, Nov 19, 2014 at 12:55 PM, Lynn A. Boger wrote: > Updated patch: Thanks. Committed. Ian > On 11/19/2014 09:01 AM, Lynn A. Boger wrote: >> >> Hi, >> >> This change goes along with the change to the GOARCH setting in gccgo for >> ppc64le which will be done in gofrontend. The description

Re: [PATCH] Check for strtol, strtoul, strtoll and strtoull declarations

2014-11-22 Thread Ian Lance Taylor
Jakub Jelinek writes: > On Sat, Nov 22, 2014 at 09:40:58AM -0500, John David Anglin wrote: >> libiberty ChangeLog: >> 2014-11-22 John David Anglin >> >> PR other/63694 >> * configure.ac: Check for strtol, strtoul, strtoll and strtoull >> declarations. >> * configure: Regen

Go patch committed: Don't deref named pointer type for method

2014-11-24 Thread Ian Lance Taylor
This patch by Chris Manghane fixes the Go compiler to not dereference a named pointer type when looking up a method. Before this patch that could happen if the pointer type pointed to a struct with an inherited method. This is http://golang.org/issue/9018. Bootstrapped and ran testsuite on x86_6

libgo patch committed: Add local version of move-if-change

2014-11-30 Thread Ian Lance Taylor
This patch by Peter Collingbourne adds a local variant of the move-if-change script, called mvifdiff, so that libgo can be built outside of the GCC tree. Bootstrapped on x86_64-unknown-linux-gnu. Committed to mainline. Ian Index: libgo/Makefile.am =

Go patch commtited: Avoid crash with self-referential type

2014-11-30 Thread Ian Lance Taylor
This patch to the Go frontend, by Chris Manghane, avoids crashing on code with self-referential types like type T interface { m() [unsafe.Sizeof(T(nil).m())]int } This kind of code is perverse but of course the compiler should not crash. This is http://golang.org/issue/6637. Bootstrapped

Re: [gofrontend-dev] Re: Go patch committed: Don't strip Go programs

2015-02-27 Thread Ian Lance Taylor
On Fri, Feb 27, 2015 at 7:21 AM, wrote: > > As discussed in this bugzilla, the debug info from libgo should not be > stripped or some things won't work as documented, like runtime.Callers. Is > that information documented anywhere so that anyone who builds gccgo and > libgo and provides it to oth

Re: [gofrontend-dev] Re: Go patch committed: Don't strip Go programs

2015-02-27 Thread Ian Lance Taylor
On Fri, Feb 27, 2015 at 12:07 PM, Matthias Klose wrote: > > is there anything which could be stripped without scarifying functionality? > Linux distributions usually strip things by default, so a hint what exactly is > needed to keep the functionality would be appreciated. What is needed is file/

Re: [gofrontend-dev] Re: Go patch committed: Don't strip Go programs

2015-03-02 Thread Ian Lance Taylor
On Mon, Mar 2, 2015 at 11:50 AM, Lynn A. Boger wrote: > > objcopy -R .debug_aranges -R .debug_frame -R .debug_loc libgo.so.7.0.0 What percentage of the total size of .debug sections got removed by this process? A problem with that approach is that .debug_info and .debug_abbrevs sections are larg

Re: [gofrontend-dev] Re: Go patch committed: Don't strip Go programs

2015-03-02 Thread Ian Lance Taylor
dd up the total sizes of the original debug info sections, and the total sizes of the remaining debug info sections, what percentage of the total debug info did you remove? After all, the only point of removing debug info is to decrease the size of the files. Ian > On 03/02/2015 01:58 PM, Ian

Go testsuite patch committed: Disable nilptr test on s390*

2015-03-04 Thread Ian Lance Taylor
This patch to the Go testsuite driver disables the nilptr test on s390*. Committed to mainline. Ian 2015-03-04 Ian Lance Taylor * go.test/go-test.exp (go-gc-tests): Skip nilptr test on s390*. Index: go.test/go-test.exp

Go patch committed: Do not declare type switch variable outside case statements

2015-03-05 Thread Ian Lance Taylor
This patch by Chris Manghane fixes a bug for cases like this: switch x := v.(type) { case *x: in which the type name in the case happens to be the same as the variable name in the type switch. This is rather confusing code, but it should work. This is http://golang.org/issue/10047 . Boot

libgo patch committed: update go Go 1.4.2 release

2015-03-06 Thread Ian Lance Taylor
I committed this patch to update libgo to the Go 1.4.2 release (it was at 1.4 before). Bootstrapped and ran testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r d42a0819e2eb go/gogo.cc --- a/go/gogo.ccFri Feb 06 08:17:54 2015 -0800 +++ b/go/gogo.ccThu Mar 05

web site update: Note that GCC 5 includes Go 1.4.2

2015-03-06 Thread Ian Lance Taylor
I committed this patch to the GCC 5 changes.html file, to note that it includes Go 1.4.2. Ian Index: gcc-5/changes.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-5/changes.html,v retrieving revision 1.85 diff -u -r1.85 changes.html --

Re: [patch, build] Restore bootstrap in building libcc1 on darwin

2015-03-08 Thread Ian Lance Taylor
Iain Sandoe writes: > +Ian > + ping The patch is missing the change to maint-tool to generate the rules at the bottom of libiberty/Makefile.in. Right now the libiberty Makefile does not require GNU make, and it's not clear to me that we want to push that dependency onto all projects that use li

Mention go and gofmt tools in GCC 5 changes files

2015-03-09 Thread Ian Lance Taylor
I committed this patch to gcc-5/changes.html to mention the new go and gofmt programs. Ian Index: changes.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-5/changes.html,v retrieving revision 1.86 diff -u -r1.86 changes.html --- changes

libgo patch committed: Don't crash if crashing on signal due to heap corruption

2015-03-09 Thread Ian Lance Taylor
Previously, if a Go program was crashing due to a signal due to heap corruption, it could in some cases invoke the Go malloc function while the Go malloc lock was held, leading to a recursive crash. This patch fixes the problem by making __go_file_line simply assume that libbacktrace keeps strings

libgo patch committed: Don't crash if freeing small map

2015-03-09 Thread Ian Lance Taylor
This libgo patch fixes a crash when explicitly freeing a small map. This is PR 65349. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r cf89d7a7f372 libgo/runtime/go-map-index.c --- a/libgo/runtime/go-map-index.c Mon Mar 09 16:36:59 2015 -0700

libgo patch committed: Add all gccgo GOARCH values to cgo size maps

2015-03-09 Thread Ian Lance Taylor
This patch to libgo adds all the current gccgo GOARCH values to the size maps used by the cgo program. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 3a7299f45092 libgo/go/cmd/cgo/main.go --- a/libgo/go/cmd/cgo/main.go Mon Mar 09 16:42:06 2015

libgo patch committed: It's OK to use cgo on PPC

2015-03-12 Thread Ian Lance Taylor
The cgo tool installed by gccgo works fine on 32-bit PPC. This patch notes that fact in the gccgo version of the go tool. This is GCC PR 65404. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 81cc50c9140d libgo/go/go/build/build.go --- a/libgo/g

gotools patch committed: Build gotools with compiler options

2015-03-12 Thread Ian Lance Taylor
mainline. Ian 2015-03-12 Ian Lance Taylor * Makefile.am (GOLINK): Add GOCFLAGS. * Makefile.in: Rebuild. Index: gotools/Makefile.am === --- gotools/Makefile.am (revision 220066) +++ gotools/Makefile.am (working copy) @@ -39,7 +39,7

Re: libgo patch committed: It's OK to use cgo on PPC

2015-03-12 Thread Ian Lance Taylor
On Thu, Mar 12, 2015 at 10:00 AM, Matthias Klose wrote: > On 03/12/2015 05:41 PM, Ian Lance Taylor wrote: >> The cgo tool installed by gccgo works fine on 32-bit PPC. This patch >> notes that fact in the gccgo version of the go tool. This is GCC PR >> 65404. Bootstrapped

Re: [gofrontend-dev] Re: Go patch committed: Don't strip Go programs

2015-03-13 Thread Ian Lance Taylor
On Fri, Feb 27, 2015 at 8:37 AM, Lynn A. Boger wrote: > At a minimum I think it should be mentioned in libgo/README. (Where "it" means that libgo should not be stripped.) I've committed this minor update to libgo/README. Ian diff -r b0d3b9400c63 libgo/README --- a/libgo/README Thu Mar 12 1

Go patch committed: Permit label on fallthrough statement

2015-03-13 Thread Ian Lance Taylor
The gccgo parser had a bug: it rejected labels on fallthrough statements, because those statements can only appear in specific contexts (at the end of a switch block just before the next case statement). This patch fixes the problem. I will add a test to the master testsuite for this, which will

Re: [gofrontend-dev] GO tools for gccgo cross

2015-03-17 Thread Ian Lance Taylor
On Tue, Mar 17, 2015 at 7:36 AM, wrote: > I have a patch to get gccgo to work on cross. > > Is it too late to try and get this into gcc 5.0? I think it's still possible. Depends on how small and safe it is. Ian > On Tuesday, February 3, 2015 at 2:18:39 PM UTC-6, Ian L

libgo/gotools patch committed: Fix go get dependencies

2015-03-24 Thread Ian Lance Taylor
-unknown-linux-gnu. Committed to mainline. Ian gotools/ChangeLog: 2015-03-24 Ian Lance Taylor PR go/65462 * Makefile.am (go_cmd_go_files): Add $(libgodir)/zstdpkglist.go. * Makefile.in: Rebuild. Index: libgo/Makefile.am

libgo patch committed: Add support for PPC32 relocs to debug/elf

2015-03-24 Thread Ian Lance Taylor
PR 65417 points out that the gccgo debug/elf package does not support PPC32 relocations, which means that the cgo tool does not work correctly. This patch fixes that. This is a backport of http://golang.org/cl/7590 from the master library sources. Bootstrapped and ran Go testsuite on x86_64-unkno

libgo patch committed: Add runtime/cgo to list of standard packages

2015-03-25 Thread Ian Lance Taylor
PR 65570 points out that the recent patch to the go tool breaks the use of cgo (and obviously also points out that we need better testing for go and cgo). The problem is that the go tool treats the runtime/cgo package specially. Although gccgo doesn't use that package, the go tool needs to know t

libgo patch committed: Avoid some s390 failures

2015-03-25 Thread Ian Lance Taylor
This patch from Dominik Vogt fixes some s390 failures in libgo. Ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r bdce421e579e libgo/go/runtime/chan_test.go --- a/libgo/go/runtime/chan_test.go Wed Mar 25 14:16:52 2015 -0700 +++ b/libgo/go/runtime/chan_test.go

libgo patch committed: Complete support for 32-bit PPC relocations

2015-03-26 Thread Ian Lance Taylor
Due to differences between the master Go library and the Go 1.4 Go library used by gccgo, I left out a key part of the patch to support 32-bit PPC relocations in the debug/elf package, which is used by cgo. Matthias reported this as PR 65587. This patch fixes the problem. Bootstrapped and ran Go t

gccgo patch committed: Permit conversion from any uintptr type to unsafe.Pointer

2015-03-30 Thread Ian Lance Taylor
The Go language permits converting any type whose underlying type is uintptr to unsafe.Pointer. The Go frontend did not implement this correctly. This is http://golang.org/issue/10284. This patch from Minux fixes the problem. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Commi

Go patch committed: Mark erroneous builtin calls as erroneous

2015-03-30 Thread Ian Lance Taylor
This patch to the Go frontend marks some builtin calls with erroneous as erroneous. This avoids a compiler crash on invalid code (http://golang.org/issue/10285). Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 6780bf5a7069 go/expressions.cc ---

libgo patch committed: Fix go tool to put external tests first

2015-03-31 Thread Ian Lance Taylor
When a complex package has both external and internal tests, we need to link against the external tests first. This patch from Dave Cheney fixes this. Bootstrapped on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r c601118c5169 libgo/go/cmd/go/build.go --- a/libgo/go/cmd/go/build.g

libgo patch committed: Remove some accidentally committed files

2015-03-31 Thread Ian Lance Taylor
I noticed that I accidentally committed three generated files in libgo/runtime. They are unused. I committed this patch to remove them. Ian Index: libgo/runtime/chan.c === --- libgo/runtime/chan.c(revision 221440) +++ libgo/

libgo patch committed: Build libnetgo.a

2015-04-07 Thread Ian Lance Taylor
PR 63731 points out that when using gccgo there is no way to request a Go program that uses the native Go DNS lookup code rather than using the system libraries. This patch from Lynn Boger at least provides a mechanism for that, by adding a -lnetgo library that can be used to pick up the Go DNS lo

Re: [libgo] Remove Solaris 11.1+ zone_net_addr_t treatment

2015-04-08 Thread Ian Lance Taylor
On Wed, Apr 8, 2015 at 6:48 AM, Rainer Orth wrote: > Ian Lance Taylor writes: > >> On Mon, Nov 3, 2014 at 8:59 AM, Rainer Orth >> wrote: >>> >>> The recent godump changes broke Solaris 11.1+ bootstrap in libgo: >>> before, gen-sysinfo.so had >

Re: [libgo] Remove Solaris 11.1+ zone_net_addr_t treatment

2015-04-08 Thread Ian Lance Taylor
On Wed, Apr 8, 2015 at 7:10 AM, Rainer Orth wrote: > Ian Lance Taylor writes: > >> On Wed, Apr 8, 2015 at 6:48 AM, Rainer Orth >> wrote: >>> Ian Lance Taylor writes: >>> >>>> On Mon, Nov 3, 2014 at 8:59 AM, Rainer Orth >>>> wro

Go patch committed: discard carriage returns in raw string literals

2015-04-10 Thread Ian Lance Taylor
The Go spec says that carriage returns in raw string literals should be discarded. The Go frontend was not doing that. This is http://golang.org/issue/10407. This patch from Minux fixes it. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 2f1e891

Re: [gofrontend-dev] GO tools for gccgo cross

2015-04-14 Thread Ian Lance Taylor
On 03/17/2015 01:27 PM, Ian Lance Taylor wrote: >> >> On Tue, Mar 17, 2015 at 7:36 AM, wrote: >>> >>> I have a patch to get gccgo to work on cross. >>> >>> Is it too late to try and get this into gcc 5.0? >> >> I think it's still pos

Go patch committed: Fix PR 65755 on GCC 5 branch

2015-04-14 Thread Ian Lance Taylor
This patch to the GCC 5 branch fixes PR 65755. This is a conservative patch for the branch. I will shortly apply a more complete, less conservative, patch to trunk. This patch simply adds the receiver type when producing the pkgpath or the reflection string for a type defined within a method. I

Go patch committed: Don't crash when dumping AST of empty block

2015-06-15 Thread Ian Lance Taylor
This patch from Chris Manghane fixes the Go frontend so that when using the -fgo-dump-ast option it does not crash when dumping an empty block. This fixes http://golang.org/issue/10420 . Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian Index: gcc/go/gofr

Go patch committed: Add MERGE file

2015-06-15 Thread Ian Lance Taylor
The master gofrontend repository has changed to git, so I am using a different system for keeping the files up to date in GCC. I've added a MERGE file to the GCC repository to track the most recent change that has been merged over. Ian Index: gcc/go/gofrontend/MERGE ==

Go patch committed: Analyze binary expressions in escape analysis

2015-06-15 Thread Ian Lance Taylor
This patch from Chris Manghane analyzes binary expressions in escape analysis. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian Index: gcc/go/gofrontend/MERGE === --- gcc/go/gofrontend/MERGE

Re: [PATCH 4/7] Fix int overflow

2015-07-08 Thread Ian Lance Taylor
On Mon, Jul 6, 2015 at 12:36 PM, Mikhail Maltsev wrote: > > diff --git a/libiberty/cp-demangle.c b/libiberty/cp-demangle.c > index 44a0a9b..befa6b6 100644 > --- a/libiberty/cp-demangle.c > +++ b/libiberty/cp-demangle.c > @@ -103,6 +103,7 @@ > #include "config.h" > #endif > > +#include All exis

Re: [PATCH 3/7] Fix trinary op

2015-07-08 Thread Ian Lance Taylor
On Tue, Jul 7, 2015 at 3:40 PM, Jeff Law wrote: > > And a generic question on the testsuite -- presumably it turns on type > demangling?I wanted to verify the flow through d_expression_1 was what I > expected it to be and it took a while to realize that c++filt doesn't > demangle types by defa

Re: [PATCH 3/7] Fix trinary op

2015-07-08 Thread Ian Lance Taylor
On Wed, Jul 8, 2015 at 6:42 AM, Tom Tromey wrote: >>>>>> "Ian" == Ian Lance Taylor writes: > > Ian> I don't know of anybody who actually uses the DMGL_TYPES support. I > Ian> don't know why anybody would. > > It's used in gdb'

Re: [PATCH, libiberty]: Avoid "enum conversion when passing argument 1 of ‘getrusage’ is invalid in C++" warning

2015-07-09 Thread Ian Lance Taylor
On Wed, Jul 1, 2015 at 3:07 AM, Uros Bizjak wrote: > > This patch avoids "enum conversion when passing argument 1 of > ‘getrusage’ is invalid in C++" warning when compiling getruntime.c. > The condition is copied from sys/resource.h. Sorry, I've been on vacation. I think it would be a lot nicer

Re: [PATCH, libiberty]: Avoid "enum conversion when passing argument 1 of ‘getrusage’ is invalid in C++" warning

2015-07-09 Thread Ian Lance Taylor
On Thu, Jul 9, 2015 at 7:15 AM, Uros Bizjak wrote: > On Thu, Jul 9, 2015 at 3:00 PM, Ian Lance Taylor wrote: >> On Wed, Jul 1, 2015 at 3:07 AM, Uros Bizjak wrote: >>> >>> This patch avoids "enum conversion when passing argument 1 of >>> ‘getrusage’

Re: [Ping] Port of VTV for Cygwin and MinGW

2015-01-14 Thread Ian Lance Taylor
On Thu, Jan 8, 2015 at 12:33 PM, Patrick Wollgast wrote: > A short recap again: > > Latest patch, changelog and a test program (further information about > the program in the mail): > https://gcc.gnu.org/ml/gcc-patches/2014-11/msg03368.html In that patch, the change to varasm.c looks wrong if nei

Re: [Ping] Port of VTV for Cygwin and MinGW

2015-01-14 Thread Ian Lance Taylor
On Wed, Jan 14, 2015 at 12:28 PM, Patrick Wollgast wrote: > On 14.01.2015 20:00, Ian Lance Taylor wrote: >> On Thu, Jan 8, 2015 at 12:33 PM, Patrick Wollgast >> wrote: >>> A short recap again: >>> >>> Latest patch, changelog and a test program (furthe

libgo patch committed: Update to Go 1.4

2015-01-14 Thread Ian Lance Taylor
libgo. I will bump the libgo version number shortly. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian gotools/ChangeLog: 2015-01-14 Ian Lance Taylor * Makefile.am (go_cmd_go_files): Sort entries. Add generate.go. * Makefile.in: Rebuild. diff -r

libgo patch committed: Add missing files

2015-01-14 Thread Ian Lance Taylor
Somehow two files were omitted from the last commit upgrading to 1.4. This adds them. Committed to mainline. Ian Index: libgo/go/crypto/tls/testdata/Server-TLSv12-IssueTicketPreDisable === --- libgo/go/crypto/tls/testdata/Server-TLSv

libgo patch committed: Bump version number

2015-01-14 Thread Ian Lance Taylor
This patch bumps the version number of libgo, giving it a new soname. Bootstrapped on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r 530a9509c45c -r bdf59f9cfda8 libgo/configure.ac --- a/libgo/configure.acWed Jan 14 16:11:24 2015 -0800 +++ b/libgo/configure.acWed Jan

Re: [Ping] Port of VTV for Cygwin and MinGW

2015-01-15 Thread Ian Lance Taylor
On Wed, Jan 14, 2015 at 11:54 PM, Patrick Wollgast wrote: > Is there something I'm still supposed to do, since I don't have write > access and this was the last part missing an "OK"? Somebody with write access will need to commit the patch for you. You should send a new clean patch including all

<    6   7   8   9   10   11   12   13   14   15   >