Re: [PATCH] [testsuite] [ppc] expect vectorization in gen-vect-11c.c

2023-04-07 Thread Kewen.Lin via Gcc-patches
Hi Alexandre, on 2023/4/7 12:37, Alexandre Oliva wrote: > On Apr 6, 2023, "Kewen.Lin" wrote: > >> on 2023/4/6 13:20, Alexandre Oliva wrote: >>> I confirm I observe the problem with gcc-12 targeting ppc64-vx7r2, >>> containing the backported patch, and

Re: [PATCH] testsuite: update requires for powerpc/float128-cmp2-runnable.c

2023-04-10 Thread Kewen.Lin via Gcc-patches
Hi Jeff, on 2023/4/10 10:09, Jiufu Guo via Gcc-patches wrote: > Hi, > > In this test case (float128-cmp2-runnable.c), the instruction > xscmpexpqp is used to support a few builtins e.g. > __builtin_vsx_scalar_cmp_exp_qp_eq on _Float128. > This instruction handles the whole 128bits of the vector,

Re: [PATCH] testsuite: update requires for powerpc/float128-cmp2-runnable.c

2023-04-11 Thread Kewen.Lin via Gcc-patches
Hi Jeff, on 2023/4/11 17:14, guojiufu wrote: > Hi Kewen, > > Thanks a lot for your very helpful comments! > > On 2023-04-10 17:26, Kewen.Lin wrote: >> Hi Jeff, >> >> on 2023/4/10 10:09, Jiufu Guo via Gcc-patches wrote: >>> Hi, >>> &g

Re: [PATCH] testsuite: update requires for powerpc/float128-cmp2-runnable.c

2023-04-12 Thread Kewen.Lin via Gcc-patches
Hi Segher & Jeff, on 2023/4/11 23:13, Segher Boessenkool wrote: > On Tue, Apr 11, 2023 at 05:40:09PM +0800, Kewen.Lin wrote: >> on 2023/4/11 17:14, guojiufu wrote: >>> Thanks for raising this concern. >>> The behavior to check about bif on FLOAT128_H

Re: [PATCH] VECT: Add WHILE_LEN pattern for decrement IV support for auto-vectorization

2023-04-12 Thread Kewen.Lin via Gcc-patches
Hi! on 2023/4/12 19:37, juzhe.zh...@rivai.ai wrote: > Thank you. Richard. >> I think that already works for them (could be > misremembering). >> However, IIUC, they have no special instruction to > calculate the >> length (unlike for RVV), and so it's open-coded using > vect_get_len.  > > Than

Re: [PATCH] testsuite: update requires for powerpc/float128-cmp2-runnable.c

2023-04-13 Thread Kewen.Lin via Gcc-patches
on 2023/4/12 20:47, Kewen.Lin wrote: > Hi Segher & Jeff, > > on 2023/4/11 23:13, Segher Boessenkool wrote: >> On Tue, Apr 11, 2023 at 05:40:09PM +0800, Kewen.Lin wrote: >>> on 2023/4/11 17:14, guojiufu wrote: >>>> Thanks for raising this concern.

Re: [PATCH] VECT: Add WHILE_LEN pattern for decrement IV support for auto-vectorization

2023-04-13 Thread Kewen.Lin via Gcc-patches
Hi Juzhe, on 2023/4/12 21:22, 钟居哲 wrote: > Thanks Kewen.  > > It seems that this proposal WHILE_LEN can help s390 when using --param  > vect-partial-vector-usage=2 compile option. > Yeah, IMHO, the previous sequence vs. the proposed sequence are like: int foo (int *__restrict a, int *__restric

Re: [PATCH] testsuite: update requires for powerpc/float128-cmp2-runnable.c

2023-04-13 Thread Kewen.Lin via Gcc-patches
Hi Jeff, on 2023/4/13 15:45, guojiufu wrote: > Hi, > > On 2023-04-12 20:47, Kewen.Lin wrote: >> Hi Segher & Jeff, >> >> on 2023/4/11 23:13, Segher Boessenkool wrote: >>> On Tue, Apr 11, 2023 at 05:40:09PM +0800, Kewen.Lin wrote: >>>> on 2023/

Re: [PATCH, rs6000] xfail float128 comparison test case that fails on powerpc64 [PR108728]

2023-04-13 Thread Kewen.Lin via Gcc-patches
Hi Haochen, on 2023/4/12 10:27, HAO CHEN GUI wrote: > Hi, > This patch xfails a float128 comparison test case on powerpc64 that > fails due to a longstanding issue with floating-point compares. > > See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58684 for more > information. > > The patch

Re: [PATCH] VECT: Add WHILE_LEN pattern for decrement IV support for auto-vectorization

2023-04-13 Thread Kewen.Lin via Gcc-patches
Hi Juzhe, on 2023/4/13 21:44, 钟居哲 wrote: > Thanks Kewen. > > Current flow in this patch like you said: > > len = WHILE_LEN (n,vf); > ... > v = len_load (addr,len); > .. > addr = addr + vf (in byte align); > > > This patch is just keep adding address with a vector factor (adjust as byte

Re: [PATCH, rs6000] xfail float128 comparison test case that fails on powerpc64 [PR108728]

2023-04-13 Thread Kewen.Lin via Gcc-patches
Hi Haochen, on 2023/4/14 09:34, HAO CHEN GUI wrote: > Hi Kewen, > > 在 2023/4/13 16:32, Kewen.Lin 写道: >> xfail all powerpc*-*-* can have some XPASSes on those ENVs with >> software emulation. Since the related hw insn xscmpuqp is guarded >> with TARGET_FLOAT128_HW,

Re: [PATCH] VECT: Add WHILE_LEN pattern for decrement IV support for auto-vectorization

2023-04-13 Thread Kewen.Lin via Gcc-patches
Hi Juzhe, >>> Yes, we just wants to add the whole vector register length in bytes. > OK, I learn it and appreciate you give me the information. > >>> I wonder if you also want WHILE_LEN to have the implicit effect >>>to update vector length register? >>>From this perspective, Richi's >>>suggestio

Re: [PATCH] VECT: Add WHILE_LEN pattern for decrement IV support for auto-vectorization

2023-04-13 Thread Kewen.Lin via Gcc-patches
Hi Juzhe, on 2023/4/14 11:39, juzhe.zh...@rivai.ai wrote: > And also I already decided to make remove WHILE_LEN pattern since it seems to > be unnecessary. > And as Richard said, it's just a simple airthmetic and it's not worthwhile to > do that. > > So, I plan to replace WHILE_LEN into MIN_EXPR

Re: [PATCH] VECT: Add WHILE_LEN pattern for decrement IV support for auto-vectorization

2023-04-14 Thread Kewen.Lin via Gcc-patches
on 2023/4/14 14:39, juzhe.zh...@rivai.ai wrote: >>> Yeah, MIN_EXPR is enough for IBM ports, but with seeing the special >>> semantic of vsetvli on >>> "vl = ceil(AVL / 2) for VLMAX < AVL < 2*VLMAX", I'm not sure if it's a good >>>idea for RV, it seems >>> to put the burden to RV backend.  For one

Re: [PATCH] testsuite: update builtins-5-p9-runnable.c for BE

2023-04-14 Thread Kewen.Lin via Gcc-patches
Hi Jeff, on 2023/4/14 16:01, guojiufu wrote: > On 2023-04-14 15:30, Jiufu Guo wrote: >> Hi, >> >> As PR108809 mentioned, vec_xl_len_r and vec_xst_len_r are tested >> in gcc.target/powerpc/builtins-5-p9-runnable.c. >> The vector operand of these two bifs are different from the view >> of v16_int8 b

<    12   13   14   15   16   17