Re: [patch] PR 54930: add -Wreturn-local-addr

2012-10-29 Thread Jonathan Wakely
Ping - can I get this reviewed before stage 1 ends? On 21 October 2012 22:25, Dodji Seketeli wrote: > The C++ bits look good to my casual non-maintainer eyes. Let's CC > Jason. > > Thanks. > > Jonathan Wakely a écrit: > >> This adds a warning switch for th

[v3] fix PR 55123

2012-10-29 Thread Jonathan Wakely
3a994d1a811d62cd87a3e97accf655ef1c34eb51 Author: Jonathan Wakely Date: Mon Oct 29 21:20:05 2012 + PR libstdc++/55123 * include/bits/shared_ptr_base.h (__shared_count::_S_create_from_up): Do not instantiate allocator with element_type. * testsuite/20_util/shared_ptr/cons/55123.cc

Re: [patch] PR 54930: add -Wreturn-local-addr

2012-10-29 Thread Jonathan Wakely
On 29 October 2012 21:26, Jason Merrill wrote: > OK. Thanks, committed.

Re: [PATCH, libstdc++] Make empty std::string storage readonly

2012-10-30 Thread Jonathan Wakely
On 30 October 2012 09:05, Michael Haubenwallner wrote: > Any chance to get this in for 4.8? I'm looking into it today.

Re: [PATCH, libstdc++] Make empty std::string storage readonly

2012-10-30 Thread Jonathan Wakely
On 30 October 2012 09:28, Jonathan Wakely wrote: > On 30 October 2012 09:05, Michael Haubenwallner wrote: >> Any chance to get this in for 4.8? > > I'm looking into it today. Consider the case where one object file containing std::string().erase() is built with an older GCC wi

Re: [PATCH, libstdc++] Make empty std::string storage readonly

2012-10-30 Thread Jonathan Wakely
On 30 October 2012 10:11, Jonathan Wakely wrote: > On 30 October 2012 09:28, Jonathan Wakely wrote: >> On 30 October 2012 09:05, Michael Haubenwallner wrote: >>> Any chance to get this in for 4.8? >> >> I'm looking into it today. > > Consider the case where

Re: Is libstdcxx-time still experimental?

2012-10-30 Thread Jonathan Wakely
On 26 August 2012 18:20, Jonathan Wakely wrote: >> I'm working on a patch to enable it by default and to define >> this_thread::sleep_xxx and this_thread::yield unconditionally. > > For anyone interested, here's a work-in-progress patch that enables > this_thre

[v3] Fix memory leak in forward_list

2012-10-30 Thread Jonathan Wakely
are not equal. Tested x86_64-linux, committed to trunk. commit e4e5b11cf5f7ed7c8afe0fa4a5aedcb4102acb37 Author: Jonathan Wakely Date: Tue Oct 30 23:29:33 2012 + * include/bits/forward_list.h (forward_list): Adjust comments. (forward_list(const forward_list&, const _Alloc&)): Use _

Re: GCC 4.8.0 Status Report (2012-10-29), Stage 1 to end soon

2012-10-31 Thread Jonathan Wakely
On 31 October 2012 10:25, JonY wrote: > On 10/30/2012 01:56, Jakub Jelinek wrote: >> Status >> == >> >> I'd like to close the stage 1 phase of GCC 4.8 development >> on Monday, November 5th. If you have still patches for new features you'd >> like to see in GCC 4.8, please post them for review

[Patch] Remove _GLIBCXX_HAVE_BROKEN_VSWPRINTF from (was Re: GCC 4.8.0 Status Report (2012-10-29), Stage 1 to end soon)

2012-10-31 Thread Jonathan Wakely
On 31 October 2012 11:01, Jonathan Wakely wrote: > On 31 October 2012 10:25, JonY wrote: >> On 10/30/2012 01:56, Jakub Jelinek wrote: >>> Status >>> == >>> >>> I'd like to close the stage 1 phase of GCC 4.8 development >>> on Monday

Re: [Patch] Remove _GLIBCXX_HAVE_BROKEN_VSWPRINTF from (was Re: GCC 4.8.0 Status Report (2012-10-29), Stage 1 to end soon)

2012-10-31 Thread Jonathan Wakely
On 31 October 2012 11:23, JonY wrote: > On 10/31/2012 19:12, Jonathan Wakely wrote: >> >> It looks like the workaround is in mingw not in GCC, so is it a >> problem that it won't be possible to use GCC 4.8 with existing mingw >> versions, or are users required to us

[v3 patch] fix libstdc++/58594

2013-10-02 Thread Jonathan Wakely
Author: Jonathan Wakely Date: Wed Oct 2 19:34:01 2013 +0100 PR libstdc++/58594 * include/bits/shared_ptr_base.h (_Sp_counted_ptr_inplace::_M_get_deleter()): Cast away cv-quals. * testsuite/20_util/shared_ptr/creation/58594.cc: New. diff --git a/libstdc++-v3/include

[v3 patch] fix libstdc++/58569

2013-10-02 Thread Jonathan Wakely
2013-10-02 Jonathan Wakely Daniel Krugler PR libstdc++/58569 * include/std/functional (function::_CheckResult): Move to namespace scope and rename to __check_func_return_type. * testsuite/20_util/function/58569.cc: New. Tested x86_64-linux

Re: [Patch] Optimize _BFSExecutor in regex

2013-10-07 Thread Jonathan Wakely
On 6 October 2013 23:43, Tim Shen wrote: > Here's a simple piece of code > https://gist.github.com/innocentim/6849759 the reveals _BFSExecutor's > inefficiency. Some optimizations are here to reduce the unecessary > time complexity from O(n^2) to O(n). > > I'll do a bootstrap and full testing befor

Re: [Patch] Optimize _BFSExecutor in regex

2013-10-07 Thread Jonathan Wakely
On 7 October 2013 18:12, Tim Shen wrote: > On Mon, Oct 7, 2013 at 12:22 PM, Jonathan Wakely > wrote: >> because that turns into the equivalent of a std::memset() on integers. > > Here I catch your idea. But think about the following example: > _M_exists.size() == 10

Re: [Patch] Optimize _BFSExecutor in regex

2013-10-07 Thread Jonathan Wakely
On 7 October 2013 22:14, Tim Shen wrote: > On Mon, Oct 7, 2013 at 1:28 PM, Jonathan Wakely wrote: >> std::memset() on about 125 bytes is not a big deal, I doubt it's >> significantly more expensive than the calculations to find the right >> bits and do the necessary

Re: [patch] fix libstdc++/57641

2013-10-07 Thread Jonathan Wakely
On 18 June 2013 23:55, Jonathan Wakely wrote: > Instead of fixing the bug three times I refactored the try_lock_xxx > functions into a mixin template and used that in the various timed > mutexes. > > PR libstdc++/57641 > * include/std/mutex (timed_mutex, rec

Re: [Patch] Optimize _BFSExecutor in regex

2013-10-07 Thread Jonathan Wakely
On 8 October 2013 01:06, Tim Shen wrote: > On Mon, Oct 7, 2013 at 7:11 PM, Jonathan Wakely wrote: >> The version in your gist (which is *not* what your first patch did!) >> is faster for any size of _M_exists and any ratio of _M_states.size() >> / _M_exists.size(): > >

[patch] fix libstdc++/58659

2013-10-08 Thread Jonathan Wakely
to trunk. commit a6857ab59da2f7001495982dbcc2b58adcbe84e5 Author: Jonathan Wakely Date: Tue Oct 8 01:02:19 2013 +0100 PR libstdc++/58659 * include/bits/shared_ptr_base.h (__shared_count::__shared_count(P,D)): Delegate to constructor taking allocator. (__shar

Re: [patch] fix libstdc++/58659

2013-10-08 Thread Jonathan Wakely
On 8 October 2013 13:33, Jonathan Wakely wrote: > PR libstdc++/58659 > * include/bits/shared_ptr_base.h > (__shared_count::__shared_count(P,D)): > Delegate to constructor taking allocator. > (__shared_count::_S_create_from_u

[patch] Tweak some libstdc++ tests.

2013-10-08 Thread Jonathan Wakely
2013-10-08 Jonathan Wakely * testsuite/*: Remove stray semi-colons after function definitions. Tested x86_64-linux, committed to trunk. commit 2c5f00a242d9aaf12cfcad0d217c4cad5b25b711 Author: Jonathan Wakely Date: Tue Oct 8 14:16:59 2013 +0100 * testsuite/*: Remove stray

Re: [PATCH] Fix libstdc++/58659.cc test case.

2013-10-09 Thread Jonathan Wakely
On 9 October 2013 15:26, Marcus Shawcroft wrote: > The test case add here: > > http://gcc.gnu.org/ml/gcc-patches/2013-10/msg00474.html > > Introduced an unprototyped call to abort() resulting in failures due to > unexepected warnings in aarch64-none-elf cross testing. > > Committed to trunk as obvi

Re: [PATCH] Fix libstdc++/58659.cc test case.

2013-10-09 Thread Jonathan Wakely
On 9 October 2013 16:15, Jakub Jelinek wrote: > On Wed, Oct 09, 2013 at 04:12:21PM +0100, Jonathan Wakely wrote: >> On 9 October 2013 15:26, Marcus Shawcroft wrote: >> > The test case add here: >> > >> > http://gcc.gnu.org/ml/gcc-patches/2013-10/msg00474.html

Re: [PATCH] testsuite/29_atomics/atomic/cons/49445.cc missing dg-require-atomic-builtins

2013-10-10 Thread Jonathan Wakely
On 10 October 2013 16:53, Marcus Shawcroft wrote: > Hi, > > The libstdc++-v3 testcase atomic/cons/49445.cc fails for a variety of arm > configurations that do not provide atomic builtins because the test is not > gated by dg-require-atomic-builtins > > OK ? OK, thanks.

Re: [Patch] Fix PR58737

2013-10-15 Thread Jonathan Wakely
On 15 October 2013 15:56, Tim Shen wrote: > This memory leak is because forgetting virtual destructor of the base > class _Executor. > > Thanks! Great, if it passes the testsuite please commit it. Thanks for the quick fix, and to Paolo for identifying the cause!

Re: User-define literals for std::complex.

2013-10-22 Thread Jonathan Wakely
On 20 October 2013 22:18, Ed Smith-Rowland wrote: > On 09/27/2013 05:39 AM, Jonathan Wakely wrote: >> >> On 27 September 2013 05:17, Ed Smith-Rowland wrote: >>> >>> The complex user-defined literals finally passed (n3779) with the >>> resolution >>

Re: [Patch] Regex comments

2013-10-27 Thread Jonathan Wakely
+ // This function serves in different modes, DFS mode or BFS mode, indicated + // by template variable __dfs_mode. See _M_main for details. I think this would make more sense if you replace "serves" with "operates", and __dfs_mode is a template parameter, not a variable. + // It applys a Dept

Re: [Patch] Regex comments

2013-10-27 Thread Jonathan Wakely
On 28 October 2013 00:23, Tim Shen wrote: > Thank you for figuring out so many syntax errors, I'll be careful next time. No problem, I'm always happy to help review the grammar, syntax or spelling in documentation improvements. > On Sun, Oct 27, 2013 at 5:38 PM, Jonathan

Re: RE : Problem with _Hashtable_ebo_helper

2013-10-29 Thread Jonathan Wakely
This patch replaces the problematic use of _Hashtable_ebo_helper with a new type. 2013-10-29 Jonathan Wakely * include/bits/hashtable.cc (__access_protected_ctor): Define and use new type instead of _Hashtable_ebo_helper. * testsuite/23_containers/unordered_set

[patch] fix libstdc++/58839

2013-10-29 Thread Jonathan Wakely
This change fixes the unique_ptr testcase in the PR while preserving the extension that we allow initializing a shared_ptr from a unique_ptr that uses a custom pointer. I've added a test for that extension, and for assignment of enable_shared_from this. 2013-10-29 Jonathan Wakely

Re: [patch] fix libstdc++/58839

2013-10-29 Thread Jonathan Wakely
On 29 October 2013 21:33, Jonathan Wakely wrote: > This change fixes the unique_ptr testcase in the PR while > preserving the extension that we allow initializing a shared_ptr from > a unique_ptr that uses a custom pointer. > > I've added a test for that extension, a

[patch] fix libstdc++/58912

2013-10-30 Thread Jonathan Wakely
This isn't a regression but is tiny and removes an unnecessary pessimisation, so I'm committing it to the 4.7 and 4.8 branches. The problem doesn't exist on the trunk. Tested x86_64-linux. 2013-10-30 Chris Studholme PR libstdc++/58912 * include/bits/shared_ptr_base.h (_Sp_cou

[v3 patch] Extend smart ptr assertions to reject void*

2013-10-30 Thread Jonathan Wakely
Because of the GNU extension that allows sizeof(void) we fail to reject ill-formed programs. This patch fixes that. 2013-10-30 Jonathan Wakely * include/bits/shared_ptr (__shared_ptr): Assert non-void pointer. * include/bits/shared_ptr (default_delete): Likewise

[v3 patch] enable commented out tests

2013-10-30 Thread Jonathan Wakely
GCC allows arithmetic on void pointers so std::atomic does too, but the VERIFY checks in this test were commented out, probably because they failed due to using sizeof(void*) when they should have used sizeof(void), which is 1. 2013-10-30 Jonathan Wakely * testsuite/29_atomics/atomic

Re: [Patch] Fix canadian cross build on systems with no fenv.h

2013-10-31 Thread Jonathan Wakely
On 30 October 2013 17:17, Steve Ellcey wrote: > > Tested with both my canadian cross build and a standard cross build > targetting mips-mti-elf. > > OK for checkin? Yes, thanks.

Re: [v3 patch] Extend smart ptr assertions to reject void*

2013-10-31 Thread Jonathan Wakely
On 30 October 2013 19:49, Jonathan Wakely wrote: > Because of the GNU extension that allows sizeof(void) we fail to > reject ill-formed programs. This patch fixes that. > > 2013-10-30 Jonathan Wakely > > * include/bits/shared_ptr (__shared_ptr): Asser

[v3 patch] define std::integer_sequence et al

2013-10-31 Thread Jonathan Wakely
. * testsuite/20_util/integer_sequence/intseq.cc: New. * testsuite/20_util/integer_sequence/requirements/typedefs.cc: New. Tested x86_64-linux, committed to trunk. commit 29a1079a3edcb51833cf0739affb2d9b3a59d4c3 Author: Jonathan Wakely Date: Sun Apr 28 13:59:42 2013 +0100 * include

[v3 patch] Implement N3421 - make functors greater<>

2013-11-01 Thread Jonathan Wakely
27;s heterogeneous lookup soon. 2013-11-01 Jonathan Wakely N3421 C++1y Transparent functors * include/bits/stl_function.h (plus, minus, multiplies, divides, modulus, negate, equal_to, not_equal_to, greater, less, greater_equal, less_equal, logical_and,

Re: [v3 patch] Implement N3421 - make functors greater<>

2013-11-01 Thread Jonathan Wakely
On 1 November 2013 11:28, Marc Glisse wrote: > On Fri, 1 Nov 2013, Jonathan Wakely wrote: > >> 2013-11-01 Jonathan Wakely >> >>N3421 C++1y Transparent functors >>* include/bits/stl_function.h (plus, minus, >>multiplies, divides,

Re: [v3 patch] Implement N3421 - make functors greater<>

2013-11-01 Thread Jonathan Wakely
On 1 November 2013 11:48, Jonathan Wakely wrote: > On 1 November 2013 11:28, Marc Glisse wrote: >> On Fri, 1 Nov 2013, Jonathan Wakely wrote: >> >>> 2013-11-01 Jonathan Wakely >>> >>>N3421 C++1y Transparent functors >>>

Re: [Patch] Implementation of n3793

2013-11-01 Thread Jonathan Wakely
Doh, that had yesterday's date on the ChangeLog entry, I've just fixed it with the next commit. On 1 November 2013 20:09, Jonathan Wakely wrote: > Here's the final version of Luc's optional implementation that I'm > committing, tested on x86_64-linux. > > (

Re: [Patch] Implementation of n3793

2013-11-03 Thread Jonathan Wakely
On 3 November 2013 09:49, Andreas Schwab wrote: > Jonathan Wakely writes: > >> + { >> +std::experimental::optional o { std::experimental::in_place, >> 0x1234ABCDF1E2D3C4 }; >> +auto copy = o; >> +VERIFY( copy ); >> +VERIFY( *copy == 0x

[patch] libstdc++/69386 Ensure C++ language linkage in cmath and cstdlib

2016-01-20 Thread Jonathan Wakely
On 19/01/16 21:43 +, Jonathan Wakely wrote: On 08/01/16 19:18 +, Jonathan Wakely wrote: This resolves the longstanding issue that #include uses the C library header, which on most targets doesn't declare the additional overloads required by C++11 26.8 [c.math], and similarl

Re: [patch] libstdc++/14608 Add C++-conforming wrappers for stdlib.h and math.h

2016-01-20 Thread Jonathan Wakely
On 20/01/16 17:17 +0100, Dominik Vogt wrote: On Tue, Jan 19, 2016 at 09:43:59PM +, Jonathan Wakely wrote: On 08/01/16 19:18 +, Jonathan Wakely wrote: >This resolves the longstanding issue that #include uses the C >library header, which on most targets doesn't declare the

Re: TR29124 C++ Special Maths - Make pull functions into global namespace.

2016-01-21 Thread Jonathan Wakely
On 20/01/16 20:30 -0500, Ed Smith-Rowland wrote: Now that libstdc++ installs a proper math.h we can piggyback on that to put in the last bit of TR29124. This patch adds the math special functions to c_compatibility/math.h in the global namespace. I remove the XFAILs from the compile_2.cc test

Re: [patch] libstdc++/69386 Ensure C++ language linkage in cmath and cstdlib

2016-01-21 Thread Jonathan Wakely
ually supported, fixed like this. This also adds extern "C++" to some more headers, so that the order of including and doesn't matter. Tested powerpc64le-linux, committed to trunk. commit 77a9e07d731a90aceb17f6fded227003b1c9c510 Author: Jonathan Wakely Date: Thu Jan 21 13:07:01 201

Re: [patch] libstdc++/69386 Ensure C++ language linkage in cmath and cstdlib

2016-01-21 Thread Jonathan Wakely
On 20/01/16 12:34 +, Jonathan Wakely wrote: --- a/libstdc++-v3/include/c_global/ccomplex +++ b/libstdc++-v3/include/c_global/ccomplex @@ -35,6 +35,8 @@ # include #endif +extern "C++" { #include +} P.S. I would have preferred not to do this around and add the linkage spe

Re: [PATCH] libitm: Disable testing transaction-safe exceptions on Darwin and AIX.

2016-01-21 Thread Jonathan Wakely
On 21/01/16 10:19 -0800, Mike Stump wrote: On Jan 21, 2016, at 10:15 AM, Torvald Riegel wrote: On Thu, 2016-01-21 at 10:06 -0800, Mike Stump wrote: On Jan 21, 2016, at 9:29 AM, Dominique d'Humières wrote: // { dg-do run { target { ! { *-*-darwin* powerpc-ibm-aix* } } } } A comment to hint

Re: TR29124 C++ Special Maths - Make pull functions into global namespace.

2016-01-22 Thread Jonathan Wakely
On 21/01/16 19:07 -0500, Ed Smith-Rowland wrote: On 01/21/2016 07:29 AM, Jonathan Wakely wrote: On 20/01/16 20:30 -0500, Ed Smith-Rowland wrote: Now that libstdc++ installs a proper math.h we can piggyback on that to put in the last bit of TR29124. This patch adds the math special functions

[patch] libstdc++/69116 Constrain std::valarray functions and operators

2016-01-22 Thread Jonathan Wakely
an to backport it to the branches too. commit 64f205467ab5822f4b75f9ae14933c52d5062f66 Author: Jonathan Wakely Date: Fri Jan 22 17:09:06 2016 + Constrain std::valarray functions and operators PR libstdc++/69116 * include/bits/valarray_before.h (__fun, __fun_with_valarray): Only define result_type fo

[patch] bootstrap/69464 Avoid including all of in

2016-01-25 Thread Jonathan Wakely
se of this change, the fix will be to add the necessary headers. Tested x86_64-linux and powerpc64-linux, committed to trunk. commit b8cab1de33b9d3fbfbe984b6b7e9d3aa41b8e80e Author: Jonathan Wakely Date: Mon Jan 25 14:15:24 2016 + Avoid including all of in PR libst

Re: [PATCH, libstdc++-v3] Fix import of wide character related symbols in stdlib.h wraper

2016-01-26 Thread Jonathan Wakely
On 26/01/16 06:40 +0200, Andris Pavenis wrote: include/c_compatibility/stdlib.h imports wide character related symbols into global namespace unconditionaly which causes libstdc++-v3 build to fail when one or both of _GLIBCXX_USE_WCHAR_T and _GLIBCXX_HAVE_MBSTATE_T are not defined. Included patch

[patch] libstdc++/69478 Fix assertions for move assignment of trivial types

2016-01-26 Thread Jonathan Wakely
The PR shows that we are incorrectly asserting that types are copy-assignable when we are going to move-assign them. Tested powerpc64-linux, committed to trunk. Branch commits to follow shortly. commit d11631c7c7f6630e83fdbe7f8e16f55eea2dd773 Author: Jonathan Wakely Date: Tue Jan 26 13:38:33

[patch] libstdc++/69295 Set FP options for failing special functions tests

2016-01-27 Thread Jonathan Wakely
This should fix the FAILs seen on trunk for some targets. Tested powerpc64-linux, comitted to trunk. commit 6f952bce33752add3fd08efac03bc19782ef09b8 Author: Jonathan Wakely Date: Wed Jan 27 13:55:45 2016 + Set FP options for failing special functions tests PR libstdc

Re: [PATCH] Fix libstdc++-v3/include/math.h:66:1 2: error: 'constexpr bool std::isnan(double)' conflicts with a previous declaration

2016-01-28 Thread Jonathan Wakely
On 27/01/16 19:49 -0500, John David Anglin wrote: The attached patch fixes a stage1 build error compiling genautomata.c on hpux. We need to test for obsolete XOPEN declarations of isinf and isnan on hpux. Further, we need to check individually for isinf and isnan on hpux11 since only isnan ha

Re: [PATCH] PR c++/69462: Provide FLT_EVAL_METHOD and DECIMAL_DIG in float.h.

2016-01-28 Thread Jonathan Wakely
On 28/01/16 13:40 +0100, Dominik Vogt wrote: The attached patch (written by Jonathan, not me) makes FLT_EVAL_METHOD and DECIMAL_DIG available in C++-11 as they should be. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69462 Can this be committed (should it wait for stage1)? I've just noticed we

[patch] libstdc++/69506 Fix Cygwin bootstrap error due to TM symbols

2016-01-29 Thread Jonathan Wakely
Another target that doesn't have the necessary weak ref support for the TM-aware exception-handling. Bootrapped successfully by the reporter, committed to trunk. commit b7e2e38ab1d938ee19280eba11ed3643a140f86d Author: Jonathan Wakely Date: Fri Jan 29 10:38:45 2016 + Fix C

Re: [PATCH] PR c++/69462: Provide FLT_EVAL_METHOD and DECIMAL_DIG in float.h.

2016-01-29 Thread Jonathan Wakely
On 28/01/16 15:42 +0100, Jakub Jelinek wrote: On Thu, Jan 28, 2016 at 01:32:18PM +, Jonathan Wakely wrote: On 28/01/16 13:40 +0100, Dominik Vogt wrote: >The attached patch (written by Jonathan, not me) makes >FLT_EVAL_METHOD and DECIMAL_DIG available in C++-11 as they should >be.

[patch] libstdc++/69581 Don't define guard macros when doing #include_next in math.h and stdlib.h

2016-02-01 Thread Jonathan Wakely
r is found. Tested powerpc64-linux, committed to trunk. commit c501dcd83400039b74f79f338580f25e148556ac Author: Jonathan Wakely Date: Mon Feb 1 10:53:35 2016 + Don't define guard macros when doing #include_next in math.h and stdlib.h 2016-02-01 Bernd Edlinger

[wwwdocs] Add common C++ issues to /gcc-6/porting_to.html

2016-02-02 Thread Jonathan Wakely
This documents the most likely problems for C++ programs using GCC 6. Committed to CVS. Index: htdocs/gcc-6/porting_to.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-6/porting_to.html,v retrieving revision 1.2 diff -u -r1.2 porting_

Re: [wwwdocs] Update changes.html for LTO and IPA

2016-02-03 Thread Jonathan Wakely
On 19/01/16 16:45 +0100, Jan Hubicka wrote: Index: changes.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-6/changes.html,v retrieving revision 1.46 diff -u -r1.46 changes.html --- changes.html22 Dec 2015 19:23:31 - 1

Re: [PATCH] Re: [wwwdocs] Add common C++ issues to /gcc-6/porting_to.html

2016-02-03 Thread Jonathan Wakely
On 03/02/16 12:13 -0500, David Malcolm wrote: On Tue, 2016-02-02 at 20:36 +, Jonathan Wakely wrote: I had some difficulty reading the new section; mostly due to the leapfrogging of C++11 by the default (my immediate reaction was "why is it talking about C++11 when the option says GN

Re: [PATCH] [wwwdocs] Add common C++ issues to /gcc-6/porting_to.html

2016-02-03 Thread Jonathan Wakely
On 03/02/16 19:47 +0100, Jakub Jelinek wrote: On Wed, Feb 03, 2016 at 10:42:37AM -0800, Mike Stump wrote: On Feb 3, 2016, at 9:13 AM, David Malcolm wrote: >> +pointer constants, so other constants such as false and >> +(1 - 1) cannot be used where a null pointer is desired. So, I’d leave this

Re: [wwwdocs] Add some C++ bits to porting_to

2016-02-04 Thread Jonathan Wakely
On 04/02/16 13:37 +0100, Marek Polacek wrote: I spotted these two issues in real-world code when doing Fedora mass rebuild. It's C++ and so I don't really know what I'm talking about; Jon, could you please look at this? Thanks, Index: porting_to.html

[patch] Update copyright years in libstdc++ manual

2016-02-04 Thread Jonathan Wakely
Some minor doc updates. Committed to trunk. commit e7a4324d0f8bb8bd622e1412b7daf8b8a2d91430 Author: Jonathan Wakely Date: Thu Feb 4 21:41:31 2016 + Update copyright years in libstdc++ manual and add link * doc/xml/manual/containers.xml: Add cross-reference to Dual ABI

Re: [PATCH] Fix libstdc++-v3/include/math.h:66:1 2: error: 'constexpr bool std::isnan(double)' conflicts with a previous declaration

2016-02-04 Thread Jonathan Wakely
On 04/02/16 17:31 -0500, John David Anglin wrote: On 2016-02-04 5:11 PM, Gerald Pfeifer wrote: In file included from .././../gcc-6-20160131/gcc/genautomata.c:116:0: /wrkdirs/usr/ports/lang/gcc6-devel/work/gcc-6-20160131/libstdc++-v3/include/c_compatibility/math.h:65:12: error: 'constexpr bool st

Re: [PATCH] Fix libstdc++-v3/include/math.h:66:1 2: error: 'constexpr bool std::isnan(double)' conflicts with a previous declaration

2016-02-04 Thread Jonathan Wakely
On 04/02/16 23:11 +0100, Gerald Pfeifer wrote: It seems to break older versions of FreeBSD that have GCC 4.2 as their system compiler. (Those versions aren't actually all that old, they are stuck with GCC 4.2 as the last version under GPLv2.) The version of GCC doesn't matter, it's whether lib

[patch] libstdc++/69626 Test for C99 stdlib.h functions with -std=c++98

2016-02-04 Thread Jonathan Wakely
n't define _GLIBCXX98_USE_C99_STDLIB. Some other targets such as freebsd and dragonfly override _GLIBCXX98_USE_C99_STDLIB in os_defines.h so were unaffected anyway. Tested powerpc64-linux, committed to trunk. commit 9e58b6517b5886357b6bfce328dd8bd2b89497f9 Author: Jonathan Wakely Date: Thu Feb 4 21:4

Re: [PATCH] Fix libstdc++-v3/include/math.h:66:1 2: error: 'constexpr bool std::isnan(double)' conflicts with a previous declaration

2016-02-04 Thread Jonathan Wakely
On 04/02/16 22:41 +, Jonathan Wakely wrote: On 04/02/16 17:31 -0500, John David Anglin wrote: On 2016-02-04 5:11 PM, Gerald Pfeifer wrote: In file included from .././../gcc-6-20160131/gcc/genautomata.c:116:0: /wrkdirs/usr/ports/lang/gcc6-devel/work/gcc-6-20160131/libstdc++-v3/include

Re: [PATCH] Fix libstdc++-v3/include/math.h:66:1 2: error: 'constexpr bool std::isnan(double)' conflicts with a previous declaration

2016-02-06 Thread Jonathan Wakely
On 6 February 2016 at 12:51, Gerald Pfeifer wrote: > On Fri, 5 Feb 2016, Jonathan Wakely wrote: >> >> Can anyone else test this on an older FreeBSD or other target that >> isn't gnu/aix/hpux? > > > Thank you, Jonathan! > > I did not have such an old

Re: [PATCH] Fix libstdc++-v3/include/math.h:66:1 2: error: 'constexpr bool std::isnan(double)' conflicts with a previous declaration

2016-02-08 Thread Jonathan Wakely
On 06/02/16 15:31 +, Jonathan Wakely wrote: On 6 February 2016 at 12:51, Gerald Pfeifer wrote: On Fri, 5 Feb 2016, Jonathan Wakely wrote: Can anyone else test this on an older FreeBSD or other target that isn't gnu/aix/hpux? Thank you, Jonathan! I did not have such an

Re: testsuite fix

2016-02-09 Thread Jonathan Wakely
On 08/02/16 17:48 -0800, Mike Stump wrote: I’m running the pretty printer test cases on a target with status wrappers, and that system works by printing the return code on that output. It is dependent upon the last line being terminated by “\n”, as the code that looks for the return code requ

[wwwdocs] Document null 'this' dereference issue in /gcc-6/porting_to.html

2016-02-09 Thread Jonathan Wakely
This adds a note to the porting document about the (shockingly widespread) problem of calling member functions through null pointers, which GCC 6 no longer tolerates. Following some comments about (bool)os I'm also tweaking another part of the doc to use the plusplusgood static_cast form. Commit

Re: [patch] libstdc++/69116 Constrain std::valarray functions and operators

2016-02-10 Thread Jonathan Wakely
On 22/01/16 21:15 +, Jonathan Wakely wrote: This is a regression, caused by the front end starting to diagnose the invalid library instantiations more eagerly. The fix seems simple and safe, so I plan to backport it to the branches too. Committed to the branches too.

Re: [wwwdocs] New bits to porting_to

2016-02-10 Thread Jonathan Wakely
On 10/02/16 17:46 +0100, Marek Polacek wrote: +int +foo (unsigned x) +{ + abs (x); Let's make this "return abs (x);" so we don't have a missing return. +The std::auto_ptr template class was deprecated in C++11, so GCC s/template class/class template/

[patch] c++/61198 backport to gcc-4.9

2016-02-10 Thread Jonathan Wakely
nd so would let me also backport the libstdc++ change. Is this safe for 4.9? Tested powerpc64le-linux, no new failures. commit d98a90afa73cecd8c62a93381cde2077471753f2 Author: Jonathan Wakely Date: Wed Feb 10 12:41:26 2016 + Backport PR c++/61198 fix gcc: 2014-12-19 Kai

Re: [wwwdocs] Document null 'this' dereference issue in /gcc-6/porting_to.html

2016-02-11 Thread Jonathan Wakely
On 09/02/16 21:06 +, Jonathan Wakely wrote: This adds a note to the porting document about the (shockingly widespread) problem of calling member functions through null pointers, which GCC 6 no longer tolerates. Following some comments about (bool)os I'm also tweaking another part of th

Re: TR29124 C++ Special Maths - Make pull functions into global namespace.

2016-02-11 Thread Jonathan Wakely
On 10/02/16 22:36 -0800, Mike Stump wrote: I’m seeing: /home/mrs/work1/gcc/libstdc++-v3/testsuite/special_functions/18_riemann_zeta/check_value.cc: In function 'void test(const testcase_riemann_zeta (&)[Num], Tp)': /home/mrs/work1/gcc/libstdc++-v3/testsuite/special_functions/18_riemann_zeta/che

Re: [wwwdocs] Add a note about in-class initialization of static data member

2016-02-11 Thread Jonathan Wakely
On 11/02/16 15:20 +0100, Marek Polacek wrote: Does this look ok? Looks OK, although how about stressing that it was only allowed as an extension previously, e.g. ... Index: porting_to.html === RCS file: /cvs/gcc/wwwdocs/htdocs/g

Re: [wwwdocs] Add a note about in-class initialization of static data member

2016-02-11 Thread Jonathan Wakely
On 11/02/16 17:39 +0100, Marek Polacek wrote: On Thu, Feb 11, 2016 at 03:26:13PM +, Jonathan Wakely wrote: On 11/02/16 15:20 +0100, Marek Polacek wrote: >Does this look ok? Looks OK, although how about stressing that it was only allowed as an extension previously, e.g. ... So like t

Re: TR29124 C++ Special Maths - Make pull functions into global namespace.

2016-02-12 Thread Jonathan Wakely
On 12/02/16 09:52 -0800, Mike Stump wrote: On Feb 11, 2016, at 3:57 AM, Jonathan Wakely wrote: On 10/02/16 22:36 -0800, Mike Stump wrote: I’m seeing: /home/mrs/work1/gcc/libstdc++-v3/testsuite/special_functions/18_riemann_zeta/check_value.cc: In function 'void test(

Re: TR29124 C++ Special Maths - Make pull functions into global namespace.

2016-02-12 Thread Jonathan Wakely
On 12/02/16 12:39 -0800, Mike Stump wrote: On Feb 12, 2016, at 10:07 AM, Jonathan Wakely wrote: On 12/02/16 09:52 -0800, Mike Stump wrote: On Feb 11, 2016, at 3:57 AM, Jonathan Wakely wrote: On 10/02/16 22:36 -0800, Mike Stump wrote: I’m seeing: /home/mrs/work1/gcc/libstdc++-v3

Re: [wwwdocs] New bits to porting_to

2016-02-14 Thread Jonathan Wakely
On 14/02/16 14:14 +0100, Gerald Pfeifer wrote: Hi Marek, On Wed, 10 Feb 2016, Marek Polacek wrote: +The additional overloads can cause the compiler to reject invalid code that +was accepted before. An example of such code is the below: which additional overloads does this refer to? The clu

Re: [Patch, regex, libstdc++/69794] Unify special character parsing

2016-02-15 Thread Jonathan Wakely
On 13/02/16 11:13 -0800, Tim Shen wrote: I did it wrong in r227289 - I ignored the "\n" special case in grep. Turns out using code to handle special cases is error prone, so I turned to use data (_M_grep_spec_char and _M_egrep_spec_char). Those new members change the size of the type, so are an

Re: [Patch, regex, libstdc++/69794] Unify special character parsing

2016-02-16 Thread Jonathan Wakely
On 15/02/16 20:41 -0800, Tim Shen wrote: PR libstdc++/69794 * include/bits/regex_scanner.h: Add different special character sets for grep and egrep regex. * include/bits/regex_scanner.tcc: Use _M_spec_char more unifiedly. s/unifiedly/uniformly/ OK for trunk and

[wwwdocs] Fix broken links on /readings.html

2016-02-17 Thread Jonathan Wakely
The links to http://cm.bell-labs.com/cm/cs/who/dmr/ no logner work, these appear to be the right ones now. Committed to CVS. Index: htdocs/readings.html === RCS file: /cvs/gcc/wwwdocs/htdocs/readings.html,v retrieving revision 1.242

[patch] fix docs for C++ warn_unused type attribute

2016-02-17 Thread Jonathan Wakely
constructor and destructor). OK for trunk? commit 01e62a231d9a446130fec253a2001f1e844e184c Author: Jonathan Wakely Date: Wed Feb 17 14:08:39 2016 + * doc/extend.texi (C++ Attributes): Correct description of warn_unused type attribute. diff --git a/gcc/doc/extend.texi b/gcc/doc/ex

Re: [wwwdocs] Changes for LTO and IPA, ver 2

2016-02-18 Thread Jonathan Wakely
On 18/02/16 05:19 +0100, Jan Hubicka wrote: Hi, it seems I have updated the patch for comments received but did not send updated version to the ML. Here it is. Honza Index: changes.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-6/c

[patch] Clarify interaction of -Wnarrowing with -std

2016-02-19 Thread Jonathan Wakely
later modes (not just with -std=c++11 as it says now), narrowing conversions produce errors or warnings by default. OK for trunk? commit b78b2728d8d946bd92843f6155cdd2415682da09 Author: Jonathan Wakely Date: Fri Feb 19 12:14:33 2016 + * doc/invoke.texi (C++ Dialect Options): Clarify

Re: [patch] Clarify interaction of -Wnarrowing with -std

2016-02-19 Thread Jonathan Wakely
On 19/02/16 13:17 -0700, Sandra Loosemore wrote: On 02/19/2016 12:01 PM, Jason Merrill wrote: On 02/19/2016 07:42 AM, Jonathan Wakely wrote: In PR69864 Manu suggests improving the docs to explain that -Wnarrowing sometimes produces errors not warnings. I think the right way to do that is

Re: [PATCH] Add configure flag for operator new (std::nothrow)

2016-02-22 Thread Jonathan Wakely
On 19/02/16 18:56 -0300, Daniel Gutson wrote: On Mon, Nov 16, 2015 at 3:56 PM, Pedro Alves wrote: On 11/10/2015 01:10 PM, Jonathan Wakely wrote: On 06/11/15 09:59 +, Pedro Alves wrote: On 11/06/2015 01:56 AM, Jonathan Wakely wrote: On 5 November 2015 at 23:31, Daniel Gutson The issue

Re: [v3, 4.9] Handle C++11 overloads on Solaris 11, 12

2016-02-22 Thread Jonathan Wakely
On 22/02/16 16:38 +0100, Rainer Orth wrote: With the latest Solaris 11.3 SRU, the C++11 overloads have been backported to Solaris 11.3. While mainline and the gcc-5 branch already cope with this due to https://gcc.gnu.org/ml/gcc-patches/2015-11/msg02075.html this broke Solaris 11 boot

Re: [PATCH] Make cstddef / cstdarg more robust (PR 69881)

2016-02-23 Thread Jonathan Wakely
On 23/02/16 07:15 +, Bernd Edlinger wrote: as described in the PR 69881 it happens quite often that cstddef is called with __need_size_t because we still support gmp-4.3.2 which is installed by contrib/download_prerequisites. This causes a kind of undefined behavior. It is just by chance th

Re: [PATCH] Make cstddef / cstdarg more robust (PR 69881)

2016-02-23 Thread Jonathan Wakely
On 23/02/16 10:00 +, Bernd Edlinger wrote: On 23/02/15 10:42, Jonathan Wakely wrote: On 23/02/16 07:15 +, Bernd Edlinger wrote: as described in the PR 69881 it happens quite often that cstddef is called with __need_size_t because we still support gmp-4.3.2 which is installed by contrib

Re: [PATCH] Make cstddef / cstdarg more robust (PR 69881)

2016-02-23 Thread Jonathan Wakely
On 23/02/16 11:09 +0100, Jakub Jelinek wrote: On Tue, Feb 23, 2016 at 10:00:58AM +, Bernd Edlinger wrote: Previously the g++ default was --std=gnu++98, but gcc-6 changed the default to --std=gnu++14. And when building gcc-4.9, stage1 does not override that with --std=gnu++98. That has chan

Re: [patch] Clarify interaction of -Wnarrowing with -std

2016-02-23 Thread Jonathan Wakely
On 19/02/16 13:17 -0700, Sandra Loosemore wrote: On 02/19/2016 12:01 PM, Jason Merrill wrote: On 02/19/2016 07:42 AM, Jonathan Wakely wrote: In PR69864 Manu suggests improving the docs to explain that -Wnarrowing sometimes produces errors not warnings. I think the right way to do that is

[patch] libstdc++/69893 make work with C++11

2016-02-23 Thread Jonathan Wakely
problem being solved wasn't very clear to me at first (even though I was already dealing with the same issue for fabs!) Tested x86_64-linux, committed to trunk. commit e8c6279426372f6b4469ee09e61d8c95422d3aa7 Author: Jonathan Wakely Date: Mon Feb 22 23:52:26 2016 + libstdc++/6989

[patch] Document __STDCPP_WANT_MATH_SPEC_FUNCS__ macro

2016-02-23 Thread Jonathan Wakely
Committed to trunk. commit 6da32ab58d56e2909ed39e5fc2170717ad26e895 Author: Jonathan Wakely Date: Tue Feb 23 20:01:35 2016 + Document __STDCPP_WANT_MATH_SPEC_FUNCS__ macro * doc/xml/manual/using.xml: Document __STDCPP_WANT_MATH_SPEC_FUNCS__. * doc/html/*: Regenerate

Re: [patch, libstdc++] In debug mode, diagnose empty initializer_list in min/max/minmax

2016-02-23 Thread Jonathan Wakely
On 23/02/16 22:03 +0100, Eelis wrote: The std::min, std::max, and std::minmax overloads that take a std::initializer_list all require that the list is not empty. The attached patch adds debug mode checks for this. Nice, thanks for the patch. Thanks, Eelis Index: libstdc++-v3/include/deb

[patch] libstdc++/69939 Qualify get and forward

2016-02-24 Thread Jonathan Wakely
A trivial fix to . Tested x86_64-linux, committed to trunk and gcc-5-branch. commit 124d28afe0c515a5d60ba2bbe788c2029329dbc5 Author: Jonathan Wakely Date: Wed Feb 24 13:15:53 2016 + libstdc++/69939 Qualify get and forward PR libstdc++/69939 * include/experimental/tuple

<    10   11   12   13   14   15   16   17   18   19   >