Re: [Ping]: [Patch] [AArch64] PR target 66049: fix add/extend gcc test suite failures

2015-05-26 Thread James Greenhalgh
On Mon, May 25, 2015 at 06:39:36AM +0100, Kumar, Venkataramanan wrote: > Ping! > > -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches-ow...@gcc.gnu.org] On > Behalf Of Kumar, Venkataramanan > Sent: Tuesday, May 19, 2015 9:07 PM >

Re: [PATCH][ARM/AArch64] Properly cost rev16 operand

2015-05-26 Thread James Greenhalgh
On Fri, May 01, 2015 at 09:24:20AM +0100, Kyrill Tkachov wrote: > Hi all, > > It occurs to me that in the IOR-of-shifts form of the rev16 operation we > should be costing the operand properly. For that we'd want to reuse the > aarch_rev16_p function that does all the heavy lifting and get it to w

Re: [PATCH 3/3][Aarch64][PR target/65697] Add tests for __sync_builtins.

2015-05-26 Thread James Greenhalgh
On Fri, May 22, 2015 at 09:30:18AM +0100, Matthew Wahab wrote: > [Added PR number and updated patches] > > This patch adds tests for the code generated by the Aarch64 backend for the > __sync builtins. > > Tested aarch64-none-linux-gnu with check-gcc. > > Ok for trunk? > Matthew This is OK once

Re: [PATCH][wwwdocs] Mention native CPU detection in aarch64 notes for GCC 6

2015-05-26 Thread James Greenhalgh
On Tue, May 19, 2015 at 11:12:55AM +0100, Kyrill Tkachov wrote: > Hi all, > > This patch adds a mention of the new native cpu detection feature in aarch64 > GNU/Linux. Gerald, this is a patch against htdocs/gcc-6/changes.html and I > thought I had seen the 'changes' link in gcc.gnu.org earlier bu

Re: [PATCH 1/3][AArch64] Strengthen barriers for sync-fetch-op builtins.

2015-05-26 Thread James Greenhalgh
On Thu, May 21, 2015 at 04:57:00PM +0100, Matthew Wahab wrote: > On Aarch64, the __sync builtins are implemented using the __atomic operations > and barriers. This makes the the __sync builtins inconsistent with their > documentation which requires stronger barriers than those for the __atomic > bu

Re: [PATCH 3/13] aarch64 musl support

2015-05-27 Thread James Greenhalgh
On Mon, Apr 27, 2015 at 03:33:05PM +0100, Szabolcs Nagy wrote: > > On 21/04/15 15:16, pins...@gmail.com wrote: > > > > I don't think you need to check if defaulting to little or big-endian here > > are the specs always have one or the other passing through. > > > > Also if musl does not support

Re: [Patch AArch64] PR target/66200 - gcc / libstdc++ TLC for weak memory models.

2015-05-28 Thread James Greenhalgh
On Wed, May 20, 2015 at 02:58:09PM +0100, Ramana Radhakrishnan wrote: > Hi, > > Someone privately pointed out that the ARM and AArch64 ports do not > define TARGET_RELAXED_ORDERING given that the architecture(s) mandates a > weak memory model. This patch fixes it for AArch64, the ARM patch

Re: [Patch AArch64] PR target/66200 - gcc / libstdc++ TLC for weak memory models.

2015-05-28 Thread James Greenhalgh
On Thu, May 21, 2015 at 09:54:19AM +0100, Ramana Radhakrishnan wrote: > And here's an additional patch for the testsuite which was missed in the > original posting. > > This is a testism that's testing code generation as per > TARGET_RELAXED_ORDERING being false and therefore needs to be adjuste

Re: backport the fixes of PR target/64011 and /61749 to 4.9 gcc

2015-05-28 Thread James Greenhalgh
On Wed, May 27, 2015 at 03:49:24AM +0100, weixiangyu wrote: > Hi, Hi, > The first patch backports the fix of PR > target/64011(https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64011) to the 4.9 > branch from trunk r219717, I can't approve this patch to be backported, so please do not commit it witho

Re: [PATCH][ARM/AArch64 Testsuite] Cleanup advsimd-intrinsics.exp, removing unnecessary loop

2015-06-01 Thread James Greenhalgh
On Fri, May 29, 2015 at 11:48:34AM +0100, Alan Lawrence wrote: > Christophe Lyon wrote: > > > > This looks OK, but why can't you also drop the other torture-related > > lines as you did in your previous patch? > > I mean: > > load_lib c-torture.exp > > load_lib torture-options.exp > > etc... > >

[Patch Obvious] Fuseable is not a word -> s/fuseable/fusible/g

2015-06-01 Thread James Greenhalgh
-deps.c) under the obvious rule. Thanks, James --- [AArch64 Obvious] "Fuseable" is not a word -> s/fuseable/fusible/g 2015-06-01 James Greenhalgh * config/aarch64/aarch64-protos.h (tune_params): Rename fuseable_ops to fusible_ops. * config/aarc

Re: [PATCH 2/3][AArch64][PR target/65697] Strengthen barriers for sync-compare-swap builtins.

2015-06-01 Thread James Greenhalgh
On Mon, Jun 01, 2015 at 01:08:15PM +0100, Matthew Wahab wrote: > On 22/05/15 09:28, Matthew Wahab wrote: > > [Added PR number and updated patches] > > > > This patch changes the code generated for __sync_type_compare_and_swap to > > > > ldxr reg; cmp; bne label; stlxr; cbnz; label: dmb ish; mov

Re: [PATCH 1/3][AArch64][PR target/65797] Strengthen barriers for sync-fetch-op builtins.

2015-06-01 Thread James Greenhalgh
On Mon, Jun 01, 2015 at 01:06:08PM +0100, Matthew Wahab wrote: > On 26/05/15 10:32, James Greenhalgh wrote: > > Please tie this to the PR which was open in the ChangLog entry. > > > >>(aarch64_split_atomic_op): Check for __sync memory models, emit > >>appro

Re: [PATCH, AARCH64] make stdarg functions work with +nofp

2015-06-02 Thread James Greenhalgh
On Sat, May 23, 2015 at 12:24:00AM +0100, Jim Wilson wrote: > The compiler currently ICEs when compiling a stdarg function with > +nofp, as reported in PR 66258. > > The aarch64.md file disables FP instructions using TARGET_FLOAT, which > supports both -mgeneral-regs-only and +nofp. But there is

Re: [PATCH, AARCH64] make stdarg functions work with +nofp

2015-06-02 Thread James Greenhalgh
On Tue, Jun 02, 2015 at 11:38:29AM +0100, Kyrill Tkachov wrote: > Hi James, Jim, > > On 02/06/15 10:42, James Greenhalgh wrote: > > On Sat, May 23, 2015 at 12:24:00AM +0100, Jim Wilson wrote: > >> The compiler currently ICEs when compiling a stdarg function with >

Re: [patch, testsuite, ARM] don't try to execute advsimd-intrinsics tests on hardware without NEON

2015-06-03 Thread James Greenhalgh
On Thu, May 21, 2015 at 06:33:37AM +0100, Sandra Loosemore wrote: > ARM testing shares the AArch64 advsimd-intrinsics execution tests. On > ARM, though, the NEON support being tested is optional -- some arches > are compatible with the NEON compilation options but hardware available > for testi

Re: [patch, testsuite, ARM] don't try to execute advsimd-intrinsics tests on hardware without NEON

2015-06-03 Thread James Greenhalgh
On Wed, Jun 03, 2015 at 08:28:12PM +0100, Sandra Loosemore wrote: > On 06/03/2015 12:05 PM, James Greenhalgh wrote: > > > > This has caused some issues for my multilib testing. Summarised below, > > with some help from Alan Lawrence. > > > > Basically the problem

Re: [patch, testsuite, ARM] don't try to execute advsimd-intrinsics tests on hardware without NEON

2015-06-04 Thread James Greenhalgh
On Thu, Jun 04, 2015 at 09:27:25AM +0100, Richard Earnshaw wrote: > On 03/06/15 20:44, James Greenhalgh wrote: > > On Wed, Jun 03, 2015 at 08:28:12PM +0100, Sandra Loosemore wrote: > >> On 06/03/2015 12:05 PM, James Greenhalgh wrote: > >>> Basically the problem occurs

[Patch] The comparison in a compare exchange should not take place in VOIDmode

2015-06-04 Thread James Greenhalgh
ay be nonsense, so I defer to others' opinions. Bootstrapped on AArch64/x86_64. OK? Thanks, James --- 2015-06-04 James Greenhalgh * builtins.c (expand_builtin_atomic_compare_exchange): Call emit_cmp_and_jump_insns with the mode of target. diff --git a/gcc/builtins.c b/gcc

Re: [AArch64][PR65375] Fix RTX cost for vector SET

2015-04-20 Thread James Greenhalgh
On Fri, Apr 17, 2015 at 12:19:14PM +0100, Kugan wrote: > >> My point is that adding your patch while keeping the logic at the top > >> which claims to catch ALL vector operations makes for less readable > >> code. > >> > >> At the very least you'll need to update this comment: > >> > >> /* TODO:

Re: [PATCH][AArch64] Increase static buffer size in aarch64_rewrite_selected_cpu

2015-04-20 Thread James Greenhalgh
On Mon, Apr 20, 2015 at 05:24:39PM +0100, Kyrill Tkachov wrote: > Hi all, > > When trying to compile a testcase with -mcpu=cortex-a57+crypto+nocrc I got > the weird assembler error: > Assembler messages: > Error: missing architectural extension > Error: unrecognized option -mcpu=cortex-a57+crypto+

Re: [PATCH 02/12] remove some ifdef HAVE_cc0

2015-04-22 Thread James Greenhalgh
On Tue, Apr 21, 2015 at 04:24:44PM +0100, Trevor Saunders wrote: > On Tue, Apr 21, 2015 at 04:14:01PM +0200, Richard Biener wrote: > > On Tue, Apr 21, 2015 at 3:24 PM, wrote: > > > From: Trevor Saunders > > > > > > gcc/ChangeLog: > > > > > > 2015-04-21 Trevor Saunders > > > > > > * co

Re: [PATCH][AArch64] Improve spill code - swap order in shl pattern

2015-04-27 Thread James Greenhalgh
On Mon, Apr 27, 2015 at 02:37:12PM +0100, Wilco Dijkstra wrote: > Various instructions are supported as integer operations as well as SIMD on > AArch64. When register pressure is high, lra-constraints inserts spill code > without taking the allocation class into account, and basically chooses the >

Re: [PATCH][AArch64] Use conditional negate for abs expansion

2015-04-27 Thread James Greenhalgh
On Mon, Apr 27, 2015 at 02:42:36PM +0100, Wilco Dijkstra wrote: > > -Original Message- > > From: Wilco Dijkstra [mailto:wdijk...@arm.com] > > Sent: 03 March 2015 16:19 > > To: GCC Patches > > Subject: [PATCH][AArch64] Use conditional negate for abs expansion > > > > Expand abs into a compa

Re: [AArch64][PR65375] Fix RTX cost for vector SET

2015-05-04 Thread James Greenhalgh
On Sat, Apr 25, 2015 at 12:26:16AM +0100, Kugan wrote: > > Thanks for the review. I have updated the patch based on the comments > with some other minor changes. Bootstrapped and regression tested on > aarch64-none-linux-gnu with no-new regressions. Is this OK for trunk? > > > Thanks, > Kugan >

Re: [PING^3] [PATCH] [AArch64, NEON] Improve vmulX intrinsics

2015-05-04 Thread James Greenhalgh
On Sat, Apr 11, 2015 at 11:37:47AM +0100, Jiangjiji wrote: > Hi, > This is a ping for: https://gcc.gnu.org/ml/gcc-patches/2015-03/msg00772.html > Regtested with aarch64-linux-gnu on QEMU. > This patch has no regressions for aarch64_be-linux-gnu big-endian target > too. > OK for the trunk?

Re: [AArch64][PR65375] Fix RTX cost for vector SET

2015-05-07 Thread James Greenhalgh
On Wed, May 06, 2015 at 03:12:33AM +0100, Kugan wrote: > >> gcc/ChangeLog: > >> > >> 2015-04-24 Kugan Vivekanandarajah > >>Jim Wilson > >> > >>* config/arm/aarch-common-protos.h (struct mem_cost_table): Added > >>new fields loadv and storev. > >>* config/aarch64/aarch64-co

[RFC: AArch64] Parametrically set defaults for function and jump alignment

2014-11-14 Thread James Greenhalgh
ing on the existing alignment and the knock-on effects. Bootstrapped on aarch64-none-linux-gnu with no issues. Does anyone have any thoughts or preferences as to how we set these values in future? If not, OK For trunk? Thanks, James --- 2014-11-14 James Greenhalgh * config/aarch64

Re: [RFC: AArch64] Parametrically set defaults for function and jump alignment

2014-11-14 Thread James Greenhalgh
On Fri, Nov 14, 2014 at 10:42:27AM +, Andrew Pinski wrote: > On Fri, Nov 14, 2014 at 2:35 AM, James Greenhalgh > wrote: > > > > Hi, > > > > We currently do not set any interesting default values for jump and function > > alignment in AArch64. I've made

Re: [Patch] Improving jump-thread pass for PR 54742

2014-11-17 Thread James Greenhalgh
coding style issues it highlights. Thanks, James Greenhalgh > diff --git a/gcc/params.def b/gcc/params.def > index d2d2add..749f962 100644 > --- a/gcc/params.def > +++ b/gcc/params.def > @@ -123,6 +123,25 @@ DEFPARAM (PARAM_PARTIAL_INLINING_ENTRY_PROBABILITY, > &qu

Re: [AArch64, Patch] Restructure arm_neon.h vector types's implementation(Take 2).

2014-11-18 Thread James Greenhalgh
On Wed, Nov 05, 2014 at 11:31:24PM +, James Greenhalgh wrote: > On Wed, Nov 05, 2014 at 09:50:52PM +, Marc Glisse wrote: > > Thanks. Do you know if anyone is planning to "port" this patch to the arm > > target (which IIRC has the same issue)? No pressure, this is

[Patch] pr63937: TARGET_USE_BY_PIECES_INFRASTRUCTURE_P should take an unsigned HOST_WIDE_INT size argument

2014-11-18 Thread James Greenhalgh
ootstrap comes back clean, and I've built cross-compilers for the other touched targets Thanks, James --- 2014-11-18 James Greenhalgh PR target/63937 * target.def (use_by_pieces_infrastructure_p): Take unsigned HOST_WIDE_INT as the size parameter.

[AArch64, Obvious] Fix formatting of SHLL and friends

2014-11-21 Thread James Greenhalgh
un of aarch64.exp/simd.exp for aarch64-none-elf with no issues. Cheers, James --- 2014-11-21 James Greenhalgh * config/aarch64/aarch64-simd.md (aarch64_l): Add a tab between output mnemonic and operands. (aarch64_simd_vec_unpack_lo_): Lik

[wwwdocs] Document ARM --with-cpu changes for 5.0

2014-11-21 Thread James Greenhalgh
Hi, As requested by Ramana when he OKed the initial change, the attched patch documents the changes I made to --with-cpu and --with-tune in this patch: https://gcc.gnu.org/ml/gcc-patches/2014-05/msg02618.html in the changes for GCC 5.0. OK? Thanks, James --- ? .git ? foo.patch ? htdocs/.#ind

Re: [PATCH RFC]Pair load store instructions using a generic scheduling fusion pass

2014-11-24 Thread James Greenhalgh
On Fri, Nov 14, 2014 at 02:43:12AM +, Bin.Cheng wrote: > On Fri, Nov 7, 2014 at 7:13 AM, Jeff Law wrote: > > On 11/05/14 02:30, Bin.Cheng wrote: > >> Thanks very much for reviewing. I refined the patch according to your > >> comments. Also made two small changes: a) skip breaking dependency

Re: Ping with testcase: [PATCH][AArch64] Fix __builtin_aarch64_absdi, must not fold to ABS_EXPR

2014-11-26 Thread James Greenhalgh
On Wed, Nov 26, 2014 at 03:56:03PM +, Alan Lawrence wrote: > So in case there's any confusion about the behaviour expected of *the vabs > intrinsic*, here's a testcase (failing without patch, passing with it)... > > --Alan > > Alan Lawrence wrote: > > ...as the former is defined as returning

Re: [PATCH, 2/2][ARM]: New CPU support for Marvell Whitney

2015-02-25 Thread James Greenhalgh
On Wed, Feb 25, 2015 at 01:42:39PM +, Xingxing Pan wrote: > Hi, > > This patch expanding the following RTL types. And it has been merged to the > latest code base. > > (neon_logic): Expand to neon_logic_reg and neon_logic_imm. > (neon_logic_q): Expand to neon_logic_reg_q an

Re: [PATCH][AArch64]: Fix rtl type in aarch64.md.

2015-02-28 Thread James Greenhalgh
On Sat, Feb 28, 2015 at 01:29:15AM +, Xingxing Pan wrote: > On 02/27/2015 04:30 PM, Marcus Shawcroft wrote: > > On 26 February 2015 at 06:22, Xingxing Pan wrote: > >> This patch fix the type of mov_aarch64 in aarch64.md. > >> Is it OK for trunk? > > > > OK, thank you /Marcus > > > > Could some

Re: ipa-icf::merge TLC

2015-02-28 Thread James Greenhalgh
On Fri, Feb 27, 2015 at 02:10:47AM +, Jan Hubicka wrote: > * ipa-icf.c (symbol_compare_collection::symbol_compare_colleciton): > Use address_matters_p. > (redirect_all_callers, set_addressable): New functions. > (sem_function::merge): Reorganize and fix merging i

Re: [PATCH][ARM]Automatically add -mthumb for thumb-only target when mode isn't specified

2015-03-02 Thread James Greenhalgh
On Mon, Mar 02, 2015 at 01:08:13PM +, Maxim Kuvyrkov wrote: > > On Mar 2, 2015, at 4:44 AM, Terry Guo wrote: > > > > Hi there, > > > > If target mode isn't specified via either gcc configuration option > > --with-mode or command line, this patch intends to improve gcc driver to > > automatic

Re: ipa-icf::merge TLC

2015-03-04 Thread James Greenhalgh
ternally visible it decided to create a wrapper (to preserve > potential address compares) and to avoid wrapper cost redirect all direct > uses. Hi Honza, Thanks for the confirmation. It took me a while longer than expected to get round to it, but I've committed the attached (rev

Re: [PATCH] [ARM] Fix widen-sum pattern in neon.md.

2015-03-05 Thread James Greenhalgh
Hi Xingxing, I'm a little confused by your reasons for adding testcases marked XFAIL. On Thu, Mar 05, 2015 at 01:34:25PM +, Xingxing Pan wrote: > +/* { dg-final { scan-tree-dump-times "pattern recognized.*w\\\+" 1 "vect" { > xfail *-*-* } } } */ > +/* { dg-final { cleanup-tree-dump "vect" }

Re: [PATCH/AARCH64] Fix 64893: ICE with vget_lane_u32 with C++ front-end at -O0

2015-03-06 Thread James Greenhalgh
On Thu, Feb 12, 2015 at 03:37:33PM +, Christophe Lyon wrote: > On 8 February 2015 at 03:24, Andrew Pinski wrote: > > On Fri, Feb 6, 2015 at 5:02 PM, Andrew Pinski wrote: > > PR target/64893 > > * config/aarch64/aarch64-builtins.c > > (aarch64_init_simd_builtins): > >

Re: [PATCH/AARCH64] Fix 64893: ICE with vget_lane_u32 with C++ front-end at -O0

2015-03-06 Thread James Greenhalgh
On Fri, Mar 06, 2015 at 10:03:46AM +, pins...@gmail.com wrote: > > On Mar 6, 2015, at 1:45 AM, James Greenhalgh > > wrote: > > > >> On Thu, Feb 12, 2015 at 03:37:33PM +, Christophe Lyon wrote: > >>> On 8 February 2015 at 03:24, Andrew Pinski wrot

[ARM testsuite obvious] Fixup atomic-comp-swap-release-acquire.c to not use ICF

2015-03-06 Thread James Greenhalgh
On Wed, Mar 04, 2015 at 09:38:51AM +, James Greenhalgh wrote: > It took me a while longer than expected to get round to it, but > I've committed the attached (revision 221175) as the obvious fix, after > checking that it worked on aarch64-none-elf. > > Thanks, > James &

Re: [ARM testsuite obvious] Fixup atomic-comp-swap-release-acquire.c to not use ICF

2015-03-06 Thread James Greenhalgh
On Fri, Mar 06, 2015 at 04:09:40PM +, James Greenhalgh wrote: > On Wed, Mar 04, 2015 at 09:38:51AM +0000, James Greenhalgh wrote: > > It took me a while longer than expected to get round to it, but > > I've committed the attached (revision 221175) as the obvious fix, after

[Patch testsuite] Further reduce the alignment In gcc.dg/vect/pr65310.c

2015-03-10 Thread James Greenhalgh
reressions elsewhere, and to confirm the patch fixes the issue for ARM. Does this fixup make sense, and if it does, is it OK for trunk? Thanks, James --- 2015-03-10 James Greenhalgh * gcc.dg/vect/pr65310.c (c): Reduce alignment to 4-bytes. diff --git a/gcc/testsuite/gcc.dg/vect/pr653

Re: [PATCH/AARCH64] Add missing definition of crypto instruction on cortex-a57.md

2015-03-11 Thread James Greenhalgh
On Wed, Mar 11, 2015 at 04:24:07PM +, Ramana Radhakrishnan wrote: > > > > > Attached patch as text. > > > > 2015-03-11 Junmo Park > > > > * config/arm/cortex-a57.md (cortex_a57_crypto_simple): Add > > crypto_sha256_fast. > > (cortex_a57_crypto_complex): Add crypto

[Patch Testsuite] Make all_attributes.cc in to (almost_)all_attributes.cc for ARM.

2015-03-20 Thread James Greenhalgh
to '1', giving unsigned int 1:15; which is not going to work. This patch just disables the check in this test case for "unused" when testing for ARM, which resolves the issue. Tested on arm-none-linux-gnueabihf to confirm it clears the FAIL. OK? Thanks, Jame

Re: [PATCH][AArch64][Testsuite] Fix gcc.target/aarch64/c-output-template-3.c

2015-03-25 Thread James Greenhalgh
On Tue, Mar 24, 2015 at 05:46:57PM +, Alan Lawrence wrote: > Hmmm. This is not the right fix: the tests Richard fixed, were failing because > of lack of constant propagation and DCE at compile-time, which then didn't > eliminate the call to link_error. The AArch64 test is failing because this

Re: C++ PATCH for c++/65556 (ICE with switch and bit-fields)

2015-03-30 Thread James Greenhalgh
On Fri, Mar 27, 2015 at 11:14:31PM +, H.J. Lu wrote: > On Fri, Mar 27, 2015 at 7:38 AM, Marek Polacek wrote: > > In this testcase we were crashing while trying to gimplify a switch, because > > the types of the switch condition and case constants didn't match. This ICE > > started with my -Ws

Re: [PATCH] [ARM] PR45701 testcase fix.

2015-03-31 Thread James Greenhalgh
*ping* on Alex' behalf and CCing the ARM maintainers. This fix looks obvious to me, and cleans up another couple of FAILs for the ARM port. Richard/Ramana? Cheers, James On Thu, Mar 26, 2015 at 03:28:15PM +, Alex Velenko wrote: > On 04/03/15 11:13, Alex Velenko wrote: > > 2015-03-04 Alex V

Re: Announcing AArch64 and ARM port reviewers

2015-04-02 Thread James Greenhalgh
On Thu, Apr 02, 2015 at 06:39:57AM +0100, Jeff Law wrote: > I'm pleased to announce that James Greenhalgh has been appointed as a > reviewer for the AArch64 port and that Kyrylo Tkachov has been appointed > as a reviewer for the ARM port. > > James & Kyrylo, if you c

Re: [PATCH] Fix PR ipa/65557

2015-04-02 Thread James Greenhalgh
On Wed, Apr 01, 2015 at 11:42:28PM +0100, H.J. Lu wrote: > On Mon, Mar 30, 2015 at 3:19 PM, Martin Liška wrote: > > You are right, there's one more occurrence of the usage. > > I'm going to install the patch I've attached. > > > > This caused: > > FAIL: g++.dg/torture/pr64378.C -O2 -flto -fno-

Re: [PATCH] [ARM] Add support for the Samsung Exynos M1 processor

2015-04-02 Thread James Greenhalgh
On Thu, Apr 02, 2015 at 11:19:14PM +0100, Sebastian Pop wrote: > Hi, > > from what I understand, Evandro has addressed the comments from Kyrill. > Are there other problems to be addressed before the patches can go in? Trunk is currently in Stage 4 development, these patches are fairly low-risk, b

Re: [PATCH] [ARM] Add support for the Samsung Exynos M1 processor

2015-04-03 Thread James Greenhalgh
On Fri, Apr 03, 2015 at 07:53:12PM +0100, Ramana Radhakrishnan wrote: > On Fri, Apr 3, 2015 at 5:17 PM, Sebastian Pop wrote: > > Hi, > > > > On Thu, Apr 2, 2015 at 5:51 PM, James Greenhalgh > > wrote: > >> Trunk is currently in Stage 4 development, these p

Re: [PATCH][AArch64][Testsuite] Fix gcc.target/aarch64/c-output-template-3.c

2015-04-07 Thread James Greenhalgh
On Wed, Mar 25, 2015 at 06:27:49PM +, James Greenhalgh wrote: > I think your original patch to add -O is just fine, but Marcus or > Richard will need to approve it. I haven't seen any howls of objection from Marcus/Richard on this. As you say, your preferred fix for the "S&qu

Re: [AArch64][PR65375] Fix RTX cost for vector SET

2015-04-15 Thread James Greenhalgh
On Tue, Apr 14, 2015 at 11:08:55PM +0100, Kugan wrote: > Now that Stage1 is open, is this OK for trunk. Hi Kugan, > diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c > index cba3c1a..d6ad0af 100644 > --- a/gcc/config/aarch64/aarch64.c > +++ b/gcc/config/aarch64/aarch64.c >

Re: [AArch64][PR65375] Fix RTX cost for vector SET

2015-04-15 Thread James Greenhalgh
On Wed, Apr 15, 2015 at 11:14:11AM +0100, Kyrill Tkachov wrote: > > On 15/04/15 10:25, James Greenhalgh wrote: > > On Tue, Apr 14, 2015 at 11:08:55PM +0100, Kugan wrote: > >> Now that Stage1 is open, is this OK for trunk. > > Hi Kugan, > > > >> diff

Re: [AArch64][PR65375] Fix RTX cost for vector SET

2015-04-15 Thread James Greenhalgh
On Wed, Apr 15, 2015 at 11:45:36AM +0100, Kugan wrote: > > There are two ways I see that we could clean things up, both of which > > require some reworking of your patch. > > > > Either we remove my check above and teach the RTX costs how to properly > > cost vector operations, or we fix my check

[Patch testsuite obvious] g++.dg/ext/pr57735.C should not run if the testsuite is explicitly passing -mfloat-abi=hard

2015-06-09 Thread James Greenhalgh
. Fixed using the same mechanisms we use elsewhere in the gcc.target/arm/ tests with the attached, applied as obvious as revision 224280. Thanks, James --- gcc/testsuite/ 2015-06-09 James Greenhalgh * g++.dg/ext/pr57735.C: Do not override -mfloat-abi directives passed by the

[Patch testsuite obvious] gcc.target/arm/pr65710.c should not unconditionally set -mfloat-abi=soft

2015-06-10 Thread James Greenhalgh
Hi, This is another test which currently fails for -mfloat-abi multilib testing as it unconditionally sets -mfloat-abi=soft. Fixed as attached in the same way we deal with other tests like this, and committed as obvious as revision 224312. Thanks, James --- gcc/testsuite/ 2015-06-10 James

Re: [PATCH] Lift restrictions on SLP permutation for loop vect

2015-06-11 Thread James Greenhalgh
On Thu, Jun 11, 2015 at 03:08:59PM +0100, Richard Biener wrote: > On Thu, 11 Jun 2015, Uros Bizjak wrote: > > > > So this turned up other issues thus the following is what I have > > > committed after bootstrapping and testing on x86_64-unknown-linux-gnu. > > > > > > Richard. > > > > > > 2015-06-0

Re: [PATCH] Lift restrictions on SLP permutation for loop vect

2015-06-11 Thread James Greenhalgh
On Thu, Jun 11, 2015 at 03:23:21PM +0100, Richard Biener wrote: > I will have a look next week - mind opening a bugreport for this so > I dont' forget? Of course, I've opened https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66510 . Cheers, James

Re: [PATCH, ARM] (commited) attribute target (thumb,arm) [4/6]

2015-06-15 Thread James Greenhalgh
On Wed, Jun 10, 2015 at 08:57:37AM +0100, Christian Bruel wrote: > Hi, > > Commited [4/6] as attached (r224314) > > thanks > > Christian > > On 06/08/2015 11:26 AM, Ramana Radhakrishnan wrote: > > On 08/06/15 09:45, Christian Bruel wrote: > >> > >> do you have other feedbacks for the remaining

Re: [PATCH, AARCH64] make stdarg functions work with +nofp

2015-06-16 Thread James Greenhalgh
On Tue, Jun 09, 2015 at 03:18:05AM +0100, Jim Wilson wrote: > On Tue, Jun 2, 2015 at 3:45 AM, James Greenhalgh > wrote: > > On Tue, Jun 02, 2015 at 11:38:29AM +0100, Kyrill Tkachov wrote: > >> Hi James, Jim, > >> > >> On 02/06/15 10:42, James Greenhalgh wrot

Re: [PING^3] [PATCH] [AArch64, NEON] Improve vmulX intrinsics

2015-06-16 Thread James Greenhalgh
On Tue, May 05, 2015 at 02:14:16PM +0100, Jiangjiji wrote: > Hi James, > > Thanks for your comment. > > Seems we need a 'dup' before 'fmul' if we use the GCC vector extension syntax > way. > > Example: > dup v1.2s, v1.s[0] > fmulv0.2s, v1.2s, v0.2s > > And we need anoth

[ARM Churn] Rename LOGICAL_OP_NON_SC to LOGICAL_OP_NON_SHORT_CIRCUIT

2015-06-16 Thread James Greenhalgh
p the patch as too pedantic, but I'll leave that to the ARM reviewers. OK? Thanks, James --- gcc/ChangeLog: 2015-06-16 James Greenhalgh * config/arm/arm-protos.h (struct tune_params): Rename log_op_non_sc to log_op_non_short_circuit, and rename enum values to ex

[AArch64 Testsuite obvious] Reinstate torture-init and torture-finalize in advsimd-intrinsics.exp

2015-06-16 Thread James Greenhalgh
main loop of advsimd-intrinsics.exp in torture-init and torture-finish. Tested with an aarch64-none-linux-gnu cross build to ensure it clears the issue I was seeing. Applied as revision 224507. Thanks, James --- 2015-06-16 James Greenhalgh * gcc.target/aarch64/advsimd-intrinsics

[Patch Vax] zero/sign extend patterns need to be SUBREG aware

2015-06-16 Thread James Greenhalgh
. As far as I know, reload is going to get rid of these SUBREGs for us, so we don't need to modify the output statement. Tested that this restores the VAX build and that the code-gen is sensible for the testcase. OK? Thanks, James --- gcc/ 2015-06-16 James Greenhalgh * config/

Re: [Patch ARM-AArch64/testsuite Neon intrinsics 00/20] Executable tests

2015-06-16 Thread James Greenhalgh
On Mon, Jun 15, 2015 at 11:11:16PM +0100, Christophe Lyon wrote: > Ping? > > > On 27 May 2015 at 22:15, Christophe Lyon wrote: > > This patch series is a follow-up to the tests I already contributed, > > converted from my original testsuite. > > > > This series consists in 20 new patches, which

Re: [PATCH][AArch64] Fix ICEs with +nofp/-mgeneral-regs-only and improve error messages; clarify docs.

2015-06-16 Thread James Greenhalgh
On Thu, Jun 11, 2015 at 12:28:08PM +0100, Alan Lawrence wrote: > Hi, > > This is a follow-up to Jim Wilson's patch fixing ICE's with > -march=armv8-a+nofp, and the discussion here: > https://gcc.gnu.org/ml/gcc-patches/2015-06/msg00177.html > > The first patch improves the error messages to descri

[Patch Testsuite obvious] gcc.target/arm/pr65647.c should not unconditionally add -mfloat-abi=soft

2015-06-16 Thread James Greenhalgh
. Applied as obvious as r224512. Thanks, James --- 2015-06-16 James Greenhalgh * gcc.target/arm/pr65647.c: Do not override -mfloat-abi directives passed by the testsuite driver. diff --git a/gcc/testsuite/gcc.target/arm/pr65647.c b/gcc/testsuite/gcc.target/arm/pr65647.c index

Re: [C++/58583] ICE instantiating NSDMIs

2015-06-17 Thread James Greenhalgh
On Tue, Jun 16, 2015 at 05:44:49PM +0100, Nathan Sidwell wrote: > On 06/16/15 03:47, Andreas Schwab wrote: > > Nathan Sidwell writes: > > > >>PR c++/58583 > >>* g++.dg/cpp0x/nsdmi-template14.C: New test. > > > > spawn -ignore SIGHUP > > /usr/local/gcc/gcc-20150616/Build/gcc/testsuite/g++2

Re: [RFC][AARCH64] TARGET_ATOMIC_ASSIGN_EXPAND_FENV hook

2015-06-17 Thread James Greenhalgh
On Thu, May 22, 2014 at 03:24:23PM +0100, Marcus Shawcroft wrote: > On 2 May 2014 13:27, Kugan wrote: > > > +2014-05-02 Kugan Vivekanandarajah > > + > > + * config/aarch64/aarch64.c (TARGET_ATOMIC_ASSIGN_EXPAND_FENV): New > > + define. > > + * config/aarch64/aarch64-protos.h

Re: [PATCH, testsuite]: Fix PR 65944, FAIL: g++.dg/lto/pr65276: undefined reference to std2::exception::~exception()

2015-06-18 Thread James Greenhalgh
On Wed, Jun 17, 2015 at 11:04:24AM +0100, Uros Bizjak wrote: > On Tue, Jun 16, 2015 at 5:13 PM, Uros Bizjak wrote: > > Hello! > > > > Following patch fixes: > > > > cp_lto_pr65276_1.o: In function `std2::runtime_error::~runtime_error()':^M > > pr65276_1.C:(.text._ZN4std213runtime_errorD2Ev[_ZN4std

Re: [PATCH, AARCH64] improve float/double 0.0 support

2015-06-19 Thread James Greenhalgh
On Fri, Jun 19, 2015 at 05:43:01PM +0100, Jim Wilson wrote: > This is a follow on to the long double 0.0 patch. The float and > double support has similar problems and need similar fixes, though a > little smaller in scope. Before the patch this testcase > void sub1 (float *f) { *f = 0.0; } > vo

[Patch SRA] Fix PR66119 by calling get_move_ratio in SRA

2015-06-23 Thread James Greenhalgh
AArch64 with no issues. OK for trunk (and 5.2 after a few days watching for fallout)? Thanks, James --- gcc/ 2015-06-23 James Greenhalgh PR tree-optimization/66119 * doc/invoke.texi (sra-max-scalarization-size-Osize): Mention that "0" is used as a sent

[Patch AArch64 0/4] Add "-moverride" option for overriding tuning parameters

2015-06-23 Thread James Greenhalgh
example string above, and again in the standard configuration with no issues. OK for trunk? Thanks, James --- [Patch AArch64 1/4] Define candidates for instruction fusion in a .def file gcc/ 2015-06-23 James Greenhalgh * config/aarch64/aarch64-fusion-pairs.def: New. * co

[Patch AArch64 1/4] Define candidates for instruction fusion in a .def file

2015-06-23 Thread James Greenhalgh
Hi, This patch moves the instruction fusion pairs from a set of #defines to an enum which we can generate from a .def file. We'll use that .def file again, and the friendly names it introduces shortly. OK? Thanks, James --- 2015-06-23 James Greenhalgh * config/aarch64/aa

[Patch AArch64 3/4] De-const-ify struct tune_params

2015-06-23 Thread James Greenhalgh
ssues. OK? Thanks, James --- 2015-06-23 James Greenhalgh * config/aarch64/aarch64-protos.h (tune_params): Remove const from members. (aarch64_tune_params): Remove const, change to no longer be a pointer. * config/aarch64/aarch64.c (aarch64_tune_params): R

[Patch AArch64 4/4] Add -moverride tuning command, and wire it up for control of fusion and fma-steering

2015-06-23 Thread James Greenhalgh
--- 2015-06-23 James Greenhalgh * config/aarch64/aarch64.opt: (override): New. * doc/invoke.texi (override): Document. * config/aarch64/aarch64.c (aarch64_flag_desc): New (aarch64_fusible_pairs): Likewise. (aarch64_tuning_f

[Patch AArch64 2/4] Control the FMA steering pass in tuning structures rather than as core property

2015-06-23 Thread James Greenhalgh
e expected configurations. OK? Thanks, James --- 2015-06-23 James Greenhalgh * config/aarch64/aarch64.h (AARCH64_FL_USE_FMA_STEERING_PASS): Delete. (aarch64_tune_flags): Likewise. (AARCH64_TUNE_FMA_STEERING): Likewise. * config/aarch64/aarch64-cores.def (cortex-a57): Remove

Re: [Patch SRA] Fix PR66119 by calling get_move_ratio in SRA

2015-06-23 Thread James Greenhalgh
On Tue, Jun 23, 2015 at 09:52:01AM +0100, Jakub Jelinek wrote: > On Tue, Jun 23, 2015 at 09:18:52AM +0100, James Greenhalgh wrote: > > This patch fixes the issue by always calling get_move_ratio in the SRA > > code, ensuring that an up-to-date value is used. > > > > U

Re: [PATCH][testsuite] Fix TORTURE_OPTIONS overriding

2015-06-23 Thread James Greenhalgh
s to ensure this brings back the missing tests, and a full x86-64 testrun to make sure I haven't dropped any from there. OK for trunk? Thanks, James --- 2015-06-23 James Greenhalgh * lib/c-torture.exp: Don't call check_effective_target_lto before setting up envir

Re: [PATCH/AARCH64] Update ThunderX schedule model

2015-06-24 Thread James Greenhalgh
On Tue, Jun 23, 2015 at 10:00:21PM +0100, Andrew Pinski wrote: > Hi, > This patch updates the schedule model to be more accurate and model > SIMD and fp instructions that I had missed out when I had the last > patch. > > OK? Bootstrapped and tested on aarch64-linux-gnu with no regeessions. The

Re: [PATCH 3/3][AArch64 nofp] Fix another ICE with +nofp/-mgeneral-regs-only

2015-06-24 Thread James Greenhalgh
On Tue, Jun 23, 2015 at 05:03:28PM +0100, Alan Lawrence wrote: > This fixes another ICE, obtained with the attached testcase - yes, there was > a > way to get hold of a float, without passing an argument or going through > movsf/movdf! > > Bootstrapped + check-gcc on aarch64-none-linux-gnu. >

Re: [PATCH 2/3][AArch64 nofp] Clarify docs for +nofp/-mgeneral-regs-only

2015-06-24 Thread James Greenhalgh
On Tue, Jun 23, 2015 at 05:03:13PM +0100, Alan Lawrence wrote: > James Greenhalgh wrote: <> > To my eye, beginning a sentence in lowercase looks very odd in pdf, and still > a > bit odd in html. Have changed to "That is"...? > > Tested with make pdf & ma

Re: [PATCH 1/3][AArch64 nofp] Fix ICEs with +nofp/-mgeneral-regs-only and improve error messages

2015-06-24 Thread James Greenhalgh
On Tue, Jun 23, 2015 at 05:02:46PM +0100, Alan Lawrence wrote: > James Greenhalgh wrote: > Bootstrap + check-gcc on aarch64-none-linux-gnu. > > (ChangeLog's identical to v1) > > gcc/ChangeLog: > > * config/aarch64/aarch64-protos.h (aarch64_err_no_fpadvsi

Re: [Patch, C++, PR65882] Check tf_warning flag in build_new_op_1

2015-06-26 Thread James Greenhalgh
On Wed, Jun 24, 2015 at 09:28:34PM +0100, Mikhail Maltsev wrote: > On 06/24/2015 06:52 PM, Christophe Lyon wrote: > > Hi Mikhail, > > > > In the gcc-5-branch, I can see that your new inhibit-warn-2.C test > > fails (targets ARM and AArch64). > > > > I can see this error message in g++.log: > > /a

Re: [PATCH, ARM] Restrict pr65647 testcase to ARMv6-M effective target

2015-06-26 Thread James Greenhalgh
p;e, h, i = 7, l = 1, m, n, o, q = &m, r, s = &r, u, w = 9, > > x, > > > > > > Patch was tested by running the testcase once with -mcpu=cortex-a9 > > (skipped as expected) and once with -mcpu=cortex-m0 (passes). > > > > Is this ok for trunk?

Re: [Patch SRA] Fix PR66119 by calling get_move_ratio in SRA

2015-06-26 Thread James Greenhalgh
On Thu, Jun 25, 2015 at 05:05:22AM +0100, Jeff Law wrote: > On 06/23/2015 09:42 AM, James Greenhalgh wrote: > > > > On Tue, Jun 23, 2015 at 09:52:01AM +0100, Jakub Jelinek wrote: > >> On Tue, Jun 23, 2015 at 09:18:52AM +0100, James Greenhalgh wrote: > >>>

Re: [PATCH] [aarch64] Implemented reciprocal square root (rsqrt) estimation in -ffast-math

2015-06-29 Thread James Greenhalgh
On Mon, Jun 29, 2015 at 10:18:23AM +0100, Kumar, Venkataramanan wrote: > > > -Original Message- > > From: Dr. Philipp Tomsich [mailto:philipp.toms...@theobroma-systems.com] > > Sent: Monday, June 29, 2015 2:17 PM > > To: Kumar, Venkataramanan > > Cc: pins...@gmail.com; Benedikt Huber; gcc-

Re: [Patch Vax] zero/sign extend patterns need to be SUBREG aware

2015-06-29 Thread James Greenhalgh
On Fri, Jun 19, 2015 at 05:30:21PM +0100, Matt Thomas wrote: > > > On Jun 19, 2015, at 8:51 AM, Jan-Benedict Glaw wrote: > > > > Hi James, > > > > On Tue, 2015-06-16 10:58:48 +0100, James Greenhalgh > > wrote: > >> The testcase in this patch,

Re: [Patch SRA] Fix PR66119 by calling get_move_ratio in SRA

2015-06-30 Thread James Greenhalgh
On Fri, Jun 26, 2015 at 06:10:00PM +0100, Jakub Jelinek wrote: > On Fri, Jun 26, 2015 at 06:03:34PM +0100, James Greenhalgh wrote: > > --- /dev/null > > +++ b/gcc/testsuite/g++.dg/pr66119.C > > I think generally testcases shouldn't be added into g++.dg/ directly, > b

Re: [AArch64] Fall back to -fPIC if no support of -fpic relocation modifer in assembler

2015-07-01 Thread James Greenhalgh
On Mon, Jun 29, 2015 at 01:42:13PM +0100, Jiong Wang wrote: > > This patch fix the breakage caused by > > https://gcc.gnu.org/ml/gcc-patches/2015-06/msg01913.html > > We fall back to -fPIC if there is no assembler support on those new > relocation modifiers for -fpic. > > OK for trunk? > > g

Re: [AArch64/testsuite] Restrict pic-small.c by a new directive "check_effective_target_aarch64_small_fpic"

2015-07-01 Thread James Greenhalgh
On Tue, Jun 30, 2015 at 03:17:00PM +0100, Jiong Wang wrote: > > As discussed here > > https://gcc.gnu.org/ml/gcc-patches/2015-06/msg02151.html, > > Since have enabled binutils feature detection when configuring gcc, > -fpic will not be enabled if there is no binutils support on those new > rel

Re: [PATCH 4/4][PR target/65697][5.1][Aarch64] Backport tests for __sync_builtins.

2015-07-02 Thread James Greenhalgh
On Fri, Jun 26, 2015 at 01:10:21PM +0100, Matthew Wahab wrote: > This patch backports the tests added for the code generated by the Aarch64 > backend > for the __sync builtins. > > The trunk patch submission is at > https://gcc.gnu.org/ml/gcc-patches/2015-05/msg01992.html > The commit is at https

Re: [PATCH 3/4][PR target/65697][5.1][Aarch64] Backport stronger barriers for __sync,compare-and-swap builtins.

2015-07-02 Thread James Greenhalgh
On Fri, Jun 26, 2015 at 01:08:50PM +0100, Matthew Wahab wrote: > This patch backports the changes made to strengthen the barriers emitted for > the __sync compare-and-swap builtins. > > The trunk patch submission is at > https://gcc.gnu.org/ml/gcc-patches/2015-05/msg01990.html > The commit is at h

Re: [PATCH 2/4][PR target/65697][5.1][Aarch64] Backport stronger barriers for __sync,fetch-op builtins.

2015-07-02 Thread James Greenhalgh
On Fri, Jun 26, 2015 at 01:07:09PM +0100, Matthew Wahab wrote: > > This patch backports the changes made to strengthen the barriers emitted for > the __sync fetch-and-op/op-and-fetch builtins. > > The trunk patch submission is at > https://gcc.gnu.org/ml/gcc-patches/2015-05/msg01989.html > The co

<    2   3   4   5   6   7   8   9   10   11   >