Re: [PING^3][PATCH 3/3][DejaGNU] target: Wrap linker flags into `-largs'/`-margs' for Ada

2019-10-25 Thread Jacob Bachmeyer
Maciej W. Rozycki wrote: On Tue, 21 May 2019, Jacob Bachmeyer wrote: IOW I don't discourage you from developing a comprehensive solution, however applying my proposal right away will help at least some people and will not block you in any way. Correct, although, considerin

Generalizing DejaGnu timeout scaling (was: Re: [PATCH DejaGNU/GCC 0/1] Support per-test execution timeout factor)

2024-01-03 Thread Jacob Bachmeyer
Maciej W. Rozycki wrote: On Wed, 3 Jan 2024, Hans-Peter Nilsson wrote: The test execution timeout is different from the tool execution timeout where it is GCC execution that is being guarded against taking excessive amount of time on the test host rather than the resulting test case execu

Re: Generalizing DejaGnu timeout scaling

2024-01-04 Thread Jacob Bachmeyer
Hans-Peter Nilsson wrote: On Wed, 3 Jan 2024, Jacob Bachmeyer wrote: Comments before I start on an implementation? I'd suggest to await the conclusion of the debate: I *think* I've proved that dg-timeout-factor is already active as intended (all parts of a test), specifi

Re: [PATCH DejaGNU 1/1] Support per-test execution timeout factor

2023-12-12 Thread Jacob Bachmeyer
Maciej W. Rozycki wrote: Add support for the `test_timeout_factor' global variable letting a test case scale the wait timeout used for code execution. This is useful for particularly slow test cases for which increasing the wait timeout globally would be excessive. * baseboards/qemu.

Re: [PATCH] libstdc++-v3: testsuite: Prune uncapitalized "in function" linker warning

2024-08-14 Thread Jacob Bachmeyer
Hans-Peter Nilsson wrote: (CC to the dejagnu project as a heads-up) Regtested cris-elf with a fresh newlib checkout where 2640 libstdc++-v3 tests otherwise fail due to the stubbed newlib _getentropy. Ok to commit? -- >8 -- Newer newlib trigger warnings about certain functions not implemented (

Re: [PATCH] libstdc++-v3: testsuite: Prune uncapitalized "in function" linker warning

2024-08-14 Thread Jacob Bachmeyer
Hans-Peter Nilsson wrote: Date: Wed, 14 Aug 2024 20:58:04 -0500 From: Jacob Bachmeyer Reply-To: jcb62...@gmail.com [...] If this is correct, I will fix it in Git master. (The fix is trivial: change the "I" to "[Ii]" to accept both forms.) Yes, thanks; just do

Re: [PATCH 3/3][DejaGNU] target: Wrap linker flags into `-largs'/`-margs' for Ada

2019-05-21 Thread Jacob Bachmeyer
Maciej Rozycki wrote: On Thu, 16 May 2019, Jacob Bachmeyer wrote: I suspect the origins may be different, however as valuable as your observation is functional problems have precedence over issues with code structuring, so we need to fix the problem at hand first. I'm sure De

Re: [PATCH 2/3][GCC] GNAT/testsuite: Pass the `ada' option to target compilation

2019-05-15 Thread Jacob Bachmeyer
Maciej W. Rozycki wrote: [...] --- gcc/testsuite/lib/gnat.exp |2 ++ 1 file changed, 2 insertions(+) gcc-test-gnat-options-ada.diff Index: gcc/gcc/testsuite/lib/gnat.exp === --- gcc.orig/gcc/testsuite/lib/gnat.exp +++ gcc/gcc/t

Re: [PATCH 3/3][DejaGNU] target: Wrap linker flags into `-largs'/`-margs' for Ada

2019-05-15 Thread Jacob Bachmeyer
Maciej W. Rozycki wrote: Unrecognized `gnatmake' switches are not implicitly passed on to the linker, so just pasting board `ldflags' and any other linker flags verbatim into `add_flags' to use for the invocation line of `gnatmake' will make them ignored at best. [...] For `gnatmake' to pass

Re: [PATCH 2/3][GCC] GNAT/testsuite: Pass the `ada' option to target compilation

2019-05-16 Thread Jacob Bachmeyer
Maciej W. Rozycki wrote: On Wed, 15 May 2019, Jacob Bachmeyer wrote: [...] We are not consistent here in `gnat_target_compile' anyway, as you can see from the two existing `concat' invocations, and also the `timeout=300' element. That is the GCC testsuite rather than Dej

Re: [PATCH 3/3][DejaGNU] target: Wrap linker flags into `-largs'/`-margs' for Ada

2019-05-16 Thread Jacob Bachmeyer
Maciej W. Rozycki wrote: On Wed, 15 May 2019, Jacob Bachmeyer wrote: This patch really exposes a significant deficiency in our current implementation of default_target_compile: the order of various flags can be significant, but we only have that order implicitly expressed in the code