[PATCH, Darwin, testsuite] Fix PR67958

2019-05-21 Thread Iain Sandoe
This a series of tests that require specific scan-asms in some cases because of the different codegen for Dawin. Added some explanations too. tested on x86_64-darwin and x86_64-linux-gnu applied to mainline, Iain gcc/testsuite/ 2019-05-21 Iain Sandoe PR testsuite/67958

[PATCH, Darwin, testsuite] Fix PR27221.

2019-05-22 Thread Iain Sandoe
An old one… This test can never pass on 32b Darwin (or AIX) because the ABI demands a different result to that being tested. So XFAIL it. Tested on powerpc-darwin9, powerpc-ibm-aix Applied to mainline Iain gcc/testsuite/ 2019-05-22 Iain Sandoe PR testsuite/27221 * g++.dg/ext

Re: [PATCH] tree-ssa-uninit: suppress more spurious warnings

2019-05-22 Thread Iain Sandoe
> On 22 May 2019, at 16:19, Jeff Law wrote: > > On 5/22/19 8:44 AM, Vladislav Ivanishin wrote: >> Christophe, Rainer, >> >> Rainer Orth writes: >> >>> Hi Christophe, >>> On Fri, 17 May 2019 at 10:12, Vladislav Ivanishin wrote: > As you have probably noticed already, the new

[PATCH, X86] Revise fuse-caller-save-* to avoid XPASSes on PIC targets.

2019-05-22 Thread Iain Sandoe
As Dominque noted in PR 64895, somewhere between revisions r244915 and r244957 we see the fuse-caller-save* tests started to XPASS on Darwin, which is a PIC target by default. The XFAILed parts of the tests never seem to be exercised on Linux, and therefore the change would be unnoticed there.

[PATCH, X86] Disable mfentry for Darwin and amend testing.

2019-05-22 Thread Iain Sandoe
Although this is a Darwin-specific change, I need to touch target-supports.exp and several tests in i386.exp. tested on x86_64-darwin and x86_64-linux-gnu doc change tested with “make pdf”, OK for trunk? backports? (where the tests fail). gcc/ * config/i386/darwin.h: Reject -mfentry*.

Re: [PATCH, X86] Revise fuse-caller-save-* to avoid XPASSes on PIC targets.

2019-05-23 Thread Iain Sandoe
Hi Uros. > On 23 May 2019, at 07:23, Uros Bizjak wrote: > > On Wed, May 22, 2019 at 8:41 PM Iain Sandoe wrote: >> >> As Dominque noted in PR 64895, somewhere between revisions >> r244915 and r244957 we see the fuse-caller-save* tests started to >> XPASS on

Re: [PATCH, X86] Disable mfentry for Darwin and amend testing.

2019-05-23 Thread Iain Sandoe
Hi Uros, > On 23 May 2019, at 07:33, Uros Bizjak wrote: > > On Thu, May 23, 2019 at 1:09 AM Iain Sandoe wrote: >> >> Although this is a Darwin-specific change, I need to touch >> target-supports.exp and several tests in i386.exp. >> >> tested on x8

Re: [PATCH, X86] Revise fuse-caller-save-* to avoid XPASSes on PIC targets.

2019-05-23 Thread Iain Sandoe
> On 23 May 2019, at 16:17, H.J. Lu wrote: > > On Thu, May 23, 2019 at 6:09 AM Uros Bizjak wrote: >> >> On Thu, May 23, 2019 at 11:25 AM Iain Sandoe wrote: >> >>>> These changes are OK as long as they don't regress HJ's x86_64 and >>

[PATCH, Darwin, x86, testsuite] Disable tests that cannot pass for Darwin.

2019-05-24 Thread Iain Sandoe
86_64-linux (--target_board=unix\{-m32,-m64\}\{,-fpic\}) Applied to mainline, Iain 2019-05-24 Iain Sandoe * gcc.target/i386/falign-functions-2.c: Skip for Darwin. * gcc.target/i386/pr70738-7.c: Likewise. * gcc.target/i386/pr24414.c: Likewise.

[PATCH, Darwin, x86, testsuite] Adjust test labels for Darwin.

2019-05-24 Thread Iain Sandoe
A couple of the i386.exp tests fail because the label spelling used is different between ELF and Mach-O targets. Adjusted here. tested on x86_64-darwin and x86_64-linux (--target_board=unix\{-m32,-m64\}\{,-fpic\}) Applied as obvious to mainline, Iain 2019-05-24 Iain Sandoe

Re: [PATCH, Darwin, x86, testsuite] Disable tests that cannot pass for Darwin.

2019-05-24 Thread Iain Sandoe
> On 24 May 2019, at 08:29, Iain Sandoe wrote: > > A few of the i386.exp target tests cannot pass on Darwin > because either the port doesn't support a feature, or the > ABI demands sufficiently different codegen that matching > the output with scan-asms would r

[PATCH, Darwin, x86, testsuite] Make match strings more specific.

2019-05-24 Thread Iain Sandoe
Iain Sandoe * gcc.target/i386/pconfig-1.c: Scan for the string in the generated code, not in comments or miscellaneous directives. Adjust expected count. * gcc.target/i386/pr18041-1.c: Likewise. * gcc.target/i386/pr18041-2.c: Likewise. * gcc.target

[PATCH, x86, testsuite] Two tests that need to be native TLS?

2019-05-24 Thread Iain Sandoe
Hi Uros, The following two tests fail on Darwin, which is an emulated TLS target. ISTM that the tests really required native support, so that the right fix is to require that. (I can skip them for Darwin, if this isn’t the right solution). OK? thanks Iain gcc/testsuite/ * gcc.target/i

[PATCH, X86, Darwin, testsuite] Require alias support on a test using it.

2019-05-25 Thread Iain Sandoe
This test fails on Darwin because it requires alias support. Fixed by adding the necessary g-require. tested on x86_64-darwin16 and x86_64-linux-gnu (--target_board=unix\{-m32,-m64\}\{,-fpic\}) aplied to mainline, thanks Iain gcc/testsuite/ 2019-05-25 Iain Sandoe * gcc.target/i386

[PATCH, Darwin, X86, testsuite] Test for expected error on exceeding ofile alignment.

2019-05-25 Thread Iain Sandoe
The test requests an alignment which exceeds the maximum object file aligment for Darwin. Rather than skipping it - test that we see the expected error. tested on x86_64-darwin16 and x86_64-linux-gnu (--target_board=unix\{-m32,-m64\}\{,-fpic\}) aplied to mainline, thanks Iain 2019-05-25 Iain

[PATCH, Darwin, X86, testsuite] Adjust match string for Darwin popcnt spelling.

2019-05-25 Thread Iain Sandoe
Darwin uses a different spelling for popcnt (popcnt instead of popcntw). Check for this in the test. tested on x86_64-darwin16 and x86_64-linux-gnu (--target_board=unix\{-m32,-m64\}\{,-fpic\}) aplied to mainline, thanks Iain 2019-05-25 Iain Sandoe * gcc.target/i386/pr59874-3.c: Use

[PATCH, Darwin, X86, testsuite] Amend scan-asms on three PIE tests.

2019-05-26 Thread Iain Sandoe
Darwin requires PIC code in order to support PIE. Amend the test scan-asms to match this. tested on x86_64-darwin16 and x86_64-linux-gnu (--target_board=unix\{-m32,-m64\}\{,-fpic\}) aplied to mainline, thanks Iain 2019-05-26 Iain Sandoe * gcc.target/i386/pr39013-1.c: Adjust scan

[PATCH, Darwin, X86] We have .p2align, so declare its use.

2019-05-31 Thread Iain Sandoe
.p2align support is present in all x86 assemblers on released Darwin systems. This “fixes” most of the remaining alignment-related fails in i386.exp tested on x86_64-darwin16, x86_64-linux-gnu, applied to mainline, thanks Iain gcc/ 2019-05-31 Iain Sandoe * config/i386/darwin.h

[PATCH, Darwin, X86, testsuite] Adjust tests for Darwin's align syntax.

2019-05-31 Thread Iain Sandoe
-gnu (--target_board=unix\{-m32,-m64\}\{,-fpic\}) aplied as obvious to mainline, thanks Iain gcc/testsuite/ 2019-05-31 Iain Sandoe * gcc.target/i386/falign-functions-3.c: Adjust align syntax and label for Darwin. * gcc.target/i386/attr-aligned-2.c: Adjust align syntax for

[PATCH, C++, testsuite] Require alias support for a test.

2019-05-31 Thread Iain Sandoe
Hi, The test for pr84497 uses a facility that requires alias support from the target, and therefore fails on targets without. Fixed by adding a suitable dg-require statement. Tested on x86_64-linux-gnu, x86_64-darwin16, applied to mainline as obvious, thanks Iain 2019-05-31 Iain Sandoe

[Darwin, x86, testsuite] Adjust tests for Darwin PR90698.

2019-06-01 Thread Iain Sandoe
is implemented. tested on x86_64-darwin16 and x86_64-linux-gnu (--target_board=unix\{-m32,-m64\}\{,-fpic\}) applied to mainline, thanks Iain gcc/testsuite/ChangeLog: 2019-06-01 Iain Sandoe PR target/90698 * gcc.target/i386/pr49866.c: XFAIL for Darwin. * gcc.target

[PATCH, PPC, Darwin] Ensure unwinder is built with altivec enabled.

2019-06-06 Thread Iain Sandoe
G4+ at run- time. However, the unwinder itself needs to be built with the assumption of vector usage so that the relevant outlined functions are called. Tested on powerpc-darwin9, applied to mainline. thanks Iain 2019-06-06 Iain Sandoe * config/rs6000/t-darwin: Ensure that the

[Darwin, c++, testsuite] Fix alignas4.C for Darwin.

2019-06-06 Thread Iain Sandoe
Iain gcc/testsuite/ChangeLog: 2019-06-06 Iain Sandoe * g++.dg/cpp0x/alignas4.C: Amend test to check for zerofill syntax on Darwin. diff --git a/gcc/testsuite/g++.dg/cpp0x/alignas4.C b/gcc/testsuite/g++.dg/cpp0x/alignas4.C index b66fa65..1ef4870 100644 --- a/gcc/testsuite/g++

Backported fix for PR82920 to 8-branch

2019-06-07 Thread Iain Sandoe
, thanks Iain gcc/testsuite/ChangeLog (for the additional test changes). 2019-06-07 Iain Sandoe PR target/82920 * gcc.target/i386/indirect-thunk-bnd-1.c: Adjust scan-asms for Darwin, do not use -fno-pic on Darwin. * gcc.target/i386/indirect-thunk-bnd-2.c: Likewise

[PATCH, testsuite, obvious] Require alias support in a test using it.

2019-06-10 Thread Iain Sandoe
attr-copy-6.c fails on Darwin which doesn’t have alias support. Fixed by adding the dg-requires line. tested on x86_64-darwin16, x86_64-linux-gnu applied as obvious to mainline. thanks Iain 2019-06-10 Iain Sandoe * gcc.dg/attr-copy-6.c: Require alias support. diff --git a/gcc

[PATCH, Darwin, testsuite] Fix PR 65364 (uninit-19.c).

2019-06-11 Thread Iain Sandoe
This test currently fails on Darwin, because the port inlines fn2 for both PIC (and non-pic for m32). Fixed by adjusting the target condition. tested on x86_64-darwin6, x86_64-linux-gnu applied to mainline thanks Iain 2019-06-11 Iain Sandoe PR testsuite/65364 * gcc.dg/uninit

Results for 10.0.0 20190612 (experimental) [trunk revision 272202] (GCC) testsuite on x86_64-apple-darwin18

2019-06-13 Thread Iain Sandoe
LAST_UPDATED: Wed Jun 12 19:12:53 UTC 2019 (revision 272202) === acats tests === === acats Summary === # of expected passes2320 # of unexpected failures0 Native configuration is x86_64-apple-darwin18 === g++ tests === Running

[PATCH, testsuite] Require alias support for pr90760.c

2019-06-13 Thread Iain Sandoe
This test fails on Darwin, because it doesn’t support symbol aliases. Fixed by adding the dg-requires line, tested on x86_64-darwin16, applied as obvious, thanks Iain gcc/testsuite/ 2019-06-13 Iain Sandoe * gcc.dg/pr90760.c: Require alias support. diff --git a/gcc/testsuite/gcc.dg

[PATCH, Darwin, testsuite] Adjust two tests for modern OS versions.

2019-06-13 Thread Iain Sandoe
link test will be added as part of a follow-up. tested on x86_64-darwin16, 18, powerpc-darwin9, i686-darwin9. applied to mainline thanks Iain gcc/testsuite/ 2019-06-13 Iain Sandoe * gcc.dg/darwin-minversion-1.c: Use compile rather than link/run. * gcc.dg/darwin-minversion-2

[Darwin, testsuite] - Fix pr71694 fail for m32.

2019-06-13 Thread Iain Sandoe
This test fails for Darwin m32 because it's scanning for absence of an instruction that's validly used in PIC code. Fixed, in this case, by using non-PIC codegen. tested on x86_64-darwin16, x86_64-linux-gnu (m32, m64). applied to mainline thanks Iain 2019-06-13 Iain Sandoe

[PATCH, Darwin, Driver, committed] Improve processing of macosx-version-min=

2019-06-13 Thread Iain Sandoe
you try to link i686-darwin9 on an x86-64-darwin18 SDK, it will fail). tested across a range of Darwin boxes, applied to mainline, thanks Iain gcc/ 2019-06-13 Iain Sandoe * config/darwin-driver.c (validate_macosx_version_min): New. (darwin_default_min_version): Cleanup and va

[PATCH, sanitizer] Wrap rethrow_primary_exception (PR 87880).

2019-06-14 Thread Iain Sandoe
-06-14 Iain Sandoe PR libsanitizer/87880 * asan/asan_interceptors.h: (ASAN_INTERCEPT___CXA_RETHROW_PRIMARY_EXCEPTION): New. * asan/Makefile.am (DEFS): Add ASAN_HAS_CXA_RETHROW_PRIMARY_EXCEPTION, defined to 0. * asan/Makefile.in: Regenerated. diff

[Darwin, committed] opts processing - Initial tidy

2019-06-14 Thread Iain Sandoe
-mtarget-linker. Tested on darwin9, 16 and 18, applied to mainline. thanks Iain gcc/ 2019-06-14 Iain Sandoe * config/darwin.opt: Add RejectNegative where needed, reorder and add minimal functional descriptions. diff --git a/gcc/config/darwin.opt b/gcc/config/darwin.opt index

[objective-c/c++, testsuite, committed, 2/3] Workaround for PR90709.

2019-06-15 Thread Iain Sandoe
Use the CF-CFString.h, F-NS*.h proxy headers where needed in the objective-c testsuite. Make minor adjustments to tests as required, providing that those do not alter the test intent. applied to mainline thanks Iain 2019-06-15 Iain Sandoe PR objc/90709 * objc.dg/encode-7

[objective-c/c++, testsuite, committed 3/3] Workaround for PR90709.

2019-06-15 Thread Iain Sandoe
Use the CF-CFString.h, F-NS*.h proxy headers where needed in the objective-c++ testsuite. Make minor adjustments to tests as required, providing that those do not alter the test intent. applied to mainline thanks Iain 2019-06-15 Iain Sandoe PR objc/90709 * obj-c++.dg/proto

[Darwin, committed, opts] Add RejectNegative for cases with explict inverses.

2019-06-16 Thread Iain Sandoe
These cases specify the negative option specifically, so we should not accept a regular -no- for them. tested on x86_64-darwin16, applied to mainline, thanks Iain 2019-06-16 Iain Sandoe * config/darwin.opt (prebind, noprebind, seglinkedit, noseglinkedit): Add

[Darwin, committed] The need for picsym stubs is dependent on linker used, not OS rev.

2019-06-16 Thread Iain Sandoe
ve, branch islanding and a long branch opt for PowerPC Darwin has become conflated with the emission of these stubs (which is confusing, and will be rectified in a following patch). 2019-06-16 Iain Sandoe * config/darwin.c (machopic_indirect_call_target): Use renamed darwin_picsy

Re: [PATCH, sanitizer] Wrap rethrow_primary_exception (PR 87880).

2019-06-16 Thread Iain Sandoe
Hi Jakub, > On 14 Jun 2019, at 15:47, Jakub Jelinek wrote: > > On Fri, Jun 14, 2019 at 03:38:05PM +0100, Iain Sandoe wrote: >> For some Darwin versions the absence of the rethrow_primary_exception >> symbol causes almost all sanitizer tests to fail. >> >>

Re: [PATCH, sanitizer] Wrap rethrow_primary_exception (PR 87880).

2019-06-18 Thread Iain Sandoe
> On 17 Jun 2019, at 09:07, Jonathan Wakely wrote: > > On 16/06/19 20:58 +0200, Jakub Jelinek wrote: >> On Sun, Jun 16, 2019 at 07:54:42PM +0100, Iain Sandoe wrote: >>> So, I guess, unless Jonathan has plans to add >>> __cxa_rethrow_primary_exception >>&

[Darwin, committed] The need for FDE symbols is dependent on linker used, not OS rev.

2019-06-18 Thread Iain Sandoe
is needed. Tested on i686/powerpc darwin9, x86_64 darwin10, 16, 18. applied to mainline thanks Iain 2019-06-18 Iain Sandoe * config/darwin.c (darwin_emit_unwind_label): New default to false. (darwin_override_options): Set darwin_emit_unwind_label as needed. diff --git a/gcc

[Darwin, committed] Fix two off-by-one errors in the driver.

2019-06-19 Thread Iain Sandoe
Spotted by Dominique with a sanitised build. fixed thus on trunk - will backport as needed. thanks Iain 2019-06-19 Iain Sandoe * config/darwin-driver.c (darwin_driver_init): Fix off-by-one errors in computing the number of options to be moved. diff --git a/gcc/config

[Darwin, specs, committed] Tidy some more linker options.

2019-06-19 Thread Iain Sandoe
s for these, and a bunch of newer ones we are not yet handling. This fixes the fail of gcc.dg/pie-7.c, which is a result of failing to handle the no-pie driver option. tested on darwin9,10,16,18, applied to mainline, thanks Iain 2019-06-19 Iain Sandoe * config/dar

[objective-c/c++, testsuite, committed] Fix stubify tests for -fnext-runtime.

2019-06-20 Thread Iain Sandoe
applied to mainline, thanks Iain gcc/testsuite/ 2019-06-20 Iain Sandoe * obj-c++.dg/stubify-1.mm: Adjust options and scan-asm checks. * obj-c++.dg/stubify-2.mm: Likewise. * objc.dg/stubify-1.m: Likewise. * objc.dg/stubify-2.m: Likewise. diff --git a/gcc

[Darwin, fixincludes, comitted] Fix Darwin14 header issues.

2019-06-21 Thread Iain Sandoe
There are two issues with the Darwin14 (SDK) headers in which unguarded advanced syntax elements causes any code including these headers to fail. tested on several Darwin versions and x86-64-linux-gnu. applied to mainline, thanks Iain 2019-06-21 Iain Sandoe * inclhack.def: Guard

[Darwin, fixincludes, committed] Fix Darwin9/10 math.h issues.

2019-06-21 Thread Iain Sandoe
. tested on powerpc/i686-darwin9 and x86_64-darwin10 (plus other darwin versions and x86_64-linux-gnu). applied to mainline thanks Iain 2019-06-21 Iain Sandoe * inclhack.def: Replace the complex test using __STRICT_ANSI__ and __STDC_VERSION__ with a test using __DARWIN_NO_LONG_LONG

[Darwin, PPC, testsuite, committed] Fix darwin-bool-1.c.

2019-06-22 Thread Iain Sandoe
This test was failing because of a pedantic warning that is unrelated to the purpose of the test. Fixed by suppressing that warning. tested on powerpc-darwin9, applied to mainline. thanks Iain 2019-06-22 Iain Sandoe * gcc.target/powerpc/darwin-bool-1.c: Suppress the pedantic

[Darwin, PPC, testsuite, committed] Add requires for DFP to two tests.

2019-06-22 Thread Iain Sandoe
2019-06-22 Iain Sandoe * gcc.target/powerpc/pr64205.c: Require effective target dfp. * gcc.target/powerpc/pr79909.c: Likewise. diff --git a/gcc/testsuite/gcc.target/powerpc/pr64205.c b/gcc/testsuite/gcc.target/powerpc/pr64205.c index 3882e3f..c726fb7 100644 --- a/gcc/testsuite

[Darwin, PPC, testsuite, committed] Fix pr71785 testcase for Darwin.

2019-06-23 Thread Iain Sandoe
specific for Darwin - that it looks for absence of branches to local labels. Tested on powerpc-darwin9, powerpc-linux-gnu applied to mainline thanks, Iain 2019-06-23 Iain Sandoe * gcc.target/powerpc/pr71785.c: For Darwin, make test non-PIC, expect the out-of-line GPR restore, and

[Darwin, PPC, committed] Emit uppercase versions of ppc defines.

2019-06-23 Thread Iain Sandoe
Emit __PPC__ (32b) and __PPC64__ (64bit) as per the other members of the PowerPC port. Darwin has always emitted __ppc__ and __ppc64__ but some testcases rely on the upper case variants. tested on powerpc-darwin9, applied to mainline. thanks Iain 2019-06-23 Iain Sandoe * config

[Darwin, PPC, committed] Handle GCC target pragma.

2019-06-23 Thread Iain Sandoe
Primarily, for compatibility with other members of the port. Note, that we do not handle the longcall attribute, since longcall is not required/used on current Darwin (supported only for legacy cases). 2019-06-23 Iain Sandoe * config/rs6000/darwin.h: Handle GCC target pragma. diff

[Darwin, PPC, testsuite, committed] Fix builtins-1 testcase for Darwin.

2019-06-23 Thread Iain Sandoe
The test needs to account for Darwin's __USER_LABEL_PREFIX__. tested on powerpc-darwin9, powerpc-linux-gnu applied to mainline thanks Iain 2019-06-23 Iain Sandoe * gcc.target/powerpc/builtins-1.c: Account for Darwin's use of __USER_LABEL_PREFIX__. diff -

[Darwin, PPC, testsuite, committed] Fix pr80125 testcase for Darwin.

2019-06-23 Thread Iain Sandoe
Darwin (unlike most of the members of the PowerPC port family) defaults to signed chars, so the test was failing to compile with a "mismatched parameters" error. tested on powerpc-darwin9, powerpc-linux-gnu applied to mainline thanks Iain 2019-06-23 Iain Sandoe * gcc.targ

[Darwin, PPC, testsuite, committed] Fix builtins-2 Darwin.

2019-06-23 Thread Iain Sandoe
This cannot pass for current Darwin, since it requires VSX and we don't have any hardware supporting that. The “fix” is to add a dg-requires clause for this. 2019-06-23 Iain Sandoe * gcc.target/powerpc/builtins-2.c: Require VSX hardware support. diff --git a/gcc/test

Re: [PATCH] Add .gnu.lto_.meta section.

2019-06-24 Thread Iain Sandoe
> On 24 Jun 2019, at 14:31, Martin Liška wrote: > > On 6/24/19 2:44 PM, Richard Biener wrote: >> On Mon, Jun 24, 2019 at 2:12 PM Martin Liška wrote: >>> >>> On 6/24/19 2:02 PM, Richard Biener wrote: On Fri, Jun 21, 2019 at 4:01 PM Martin Liška wrote: > > On 6/21/19 2:57 PM, Jan

[Darwin] Fix build warnings for libstdc++ [NFC]

2018-12-02 Thread Iain Sandoe
Hi, GCC does not export construction vtable symbols from shared libraries**. The symbols are marked hidden in the objects; for Darwin that makes them also external (“private_extern” is Darwin’s hidden) which means that they show up in the list of possible symbols for export from libstdc++, and

[Patch, ppc/darwin 1/2] Fix bootstrap.

2018-12-02 Thread Iain Sandoe
sysv. From 38ea0dbe42816b4c464b64b68b5fd5140b1a8dea Mon Sep 17 00:00:00 2001 From: Iain Sandoe Date: Fri, 30 Nov 2018 09:10:43 + Subject: [PATCH] [PATCH,PPC] Fix up revised call handling for Darwin. --- gcc/config/rs6000/darwin.md | 60 - gcc/config/rs6000

[Patch, ppc/darwin 2/2] Make Darwin's call handling follow the style of AIX/ELFv2/sysv.

2018-12-02 Thread Iain Sandoe
. From cf45459dc7f317bcf5f415219884e6b846fe01a1 Mon Sep 17 00:00:00 2001 From: Iain Sandoe Date: Sat, 1 Dec 2018 16:23:20 + Subject: [PATCH] [darwin,ppc] Update call expansions to follow the new scheme. This also makes it a bit more apparent what we can remove when the mlongcall optimisation is

Re: [Patch, ppc/darwin 1/2] Fix bootstrap.

2018-12-03 Thread Iain Sandoe
> On 3 Dec 2018, at 06:18, Alan Modra wrote: > > On Mon, Dec 03, 2018 at 01:26:48AM +0000, Iain Sandoe wrote: >> The first patch makes Darwin share the sysv lowering, up until late in the >> process when we still use the macho_call_template. This means we need to >

Re: [Patch, ppc/darwin 2/2] Make Darwin's call handling follow the style of AIX/ELFv2/sysv.

2018-12-03 Thread Iain Sandoe
> On 3 Dec 2018, at 01:28, Iain Sandoe wrote: > The second patch normalises Darwin’s call handling to follow the same pattern > that Alan introduced recently. revised version, on top of the revised patch 1 attached. I’ve taken the opportunity to reduce the number of TAR

[committed, testsuite] Fix PR88310.

2018-12-04 Thread Iain Sandoe
=== --- gcc/testsuite/ChangeLog (revision 266784) +++ gcc/testsuite/ChangeLog (working copy) @@ -1,3 +1,9 @@ +2018-12-04 Iain Sandoe + + PR testsuite/88310 + * lib/target-supports.exp (check_effective_target_freorder

[PATCH, PPC] Fix PR88343.

2018-12-05 Thread Iain Sandoe
, bootstrapped on Darwin (testing continues). OK for trunk? Branches? Iain 2018-xx-xx Segher Boessenkool Iain Sandoe gcc/ * config/rs6000/rs6000.c (save_reg_p): Do not save the picbase reg unless it has been used. (first_reg_to_save): Remove dead code. diff --git a/gcc

[PATCH, committed] Fix PR libstdc++/64883

2018-12-06 Thread Iain Sandoe
ributes.cc: Likewise. * testsuite/17_intro/headers/c++2020/all_attributes.cc: Likewise. diff --git a/libstdc++-v3/ChangeLog b/libstdc++-v3/ChangeLog index 7e8df9db11d..74ef0b3ef06 100644 --- a/libstdc++-v3/ChangeLog +++ b/libstdc++-v3/ChangeLog @@ -1,5 +1,13 @@ +2018-12-06 Jonathan Wakel

[PATCH, PPC/Darwin] Fix long double symbol exports.

2018-12-06 Thread Iain Sandoe
Hi, During 8.x, the rs6000 target-specific mangling was reorganised which uncovered a long-standing bug in Darwin’s mangling for ‘IBM’ long double. Now the symbols are correctly mangled, and we end up with a bunch of test link fails. This patch adds the necessary subset of the Linux long double

Re: [PATCH, driver specs][2] Put -flto-partition= on the collect2 c/l

2018-12-06 Thread Iain Sandoe
Hi This got stuck in my stack of patches for LTO debug support, and I forgot to ping it… > On 22 Aug 2018, at 14:20, Richard Biener wrote: > > On Wed, Aug 22, 2018 at 2:56 PM Iain Sandoe wrote: >> >> >>> On 20 Aug 2018, at 11:01, Richard Biener wrote: >>

Re: [PATCH] Delete powerpcspe

2018-12-14 Thread Iain Sandoe
> On 14 Dec 2018, at 08:20, Segher Boessenkool > wrote: > > On Thu, Dec 13, 2018 at 09:49:51AM -0700, Jeff Law wrote: >> On 12/12/18 10:33 AM, Segher Boessenkool wrote: >>> On Wed, Dec 12, 2018 at 11:36:29AM +0100, Richard Biener wrote: On Tue, Dec 11, 2018 at 2:37 PM Jeff Law wrote: >>>

Re: [patch,openacc] Fix PR71959: lto dump of callee counts

2018-12-22 Thread Iain Sandoe
Hi Julian, > On 21 Dec 2018, at 16:47, Julian Brown wrote: > > On Fri, 21 Dec 2018 14:31:19 +0100 > Jakub Jelinek wrote: > >> On Fri, Dec 21, 2018 at 01:23:03PM +, Julian Brown wrote: >>> 2018-xx-yy Nathan Sidwell > >>> * testsuite/libgomp.oacc-c++/pr71959-a.C: New. >>> * tes

[PATCH, committed] Enable ident for X86 Darwin.

2018-12-23 Thread Iain Sandoe
vious, Iain 2018-12-23 Iain Sandoe gcc/ * config/i386/darwin.h (TARGET_ASM_OUTPUT_IDENT): New. diff --git a/gcc/config/i386/darwin.h b/gcc/config/i386/darwin.h index 53789e7c23..f760218bda 100644 --- a/gcc/config/i386/darwin.h +++ b/gcc/config/i386/darwin.h @@ -219,6 +219,11 @@ exter

[PATCH] Don't run ident tests on powerpc-darwin

2018-12-23 Thread Iain Sandoe
Hi The c-c++-common tests fail (or XPASS depending on which) on Darwin because it doesn't currently emit .ident marker. For powerpc darwin (and, I think, AIX - hence copying David), there’s no .ident support in the assembler, and we need to skip the tests. In this case, I suggest that it’s not

[PATCH] Fix Ada bootstrap for Darwin9 and earlier.

2018-12-23 Thread Iain Sandoe
Hi, This is a bootstrap regression on 7,8 and trunk for Ada on [X86 and PowerPC] Darwin9 (and earlier, although I don’t test much there). Changes were made to __gnat_lwp_self to use a facility that’s only available from Darwin10 onwards. The patch makes this conditional on the target Darwin ve

[PATCH, lto-wrapper] Don't pre-link the early-debug objects.

2018-12-23 Thread Iain Sandoe
Hi, As there was some discussion of this on IRC - I believe that Honza might want this patch sooner, rather than later I constructed it as part of the series to support LTO debug [PR 82005] on Darwin (it’s still needed there). The patch has been reg-strapped on x86_64-darwin, x86_64-linux, pow

[PATCH, Darwin, config] Check for DWARF debug line support with otool.

2018-12-23 Thread Iain Sandoe
Hi, This corrects a long-standing misconfiguration for Darwin. The assembler supports the “.file” and “.loc” directives, but the GCC configury was not detecting this because it was using objdump, which does not exist on most Darwin installations. We added support for “otool” to GCC and now we ca

[PATCH, Darwin] Fix PR67974.

2018-12-23 Thread Iain Sandoe
Hi, The PR is about a set of tests that were not executed because of missing asm support. However, the assembler can handle the insns now, so the tests are attempted (but with a missing asm shim they fail). This adds the shim. In principle (bugs notwithstanding) Darwin’s x86_64 ABI is suppose

Re: [PATCH] Don't run ident tests on powerpc-darwin

2018-12-26 Thread Iain Sandoe
> On 26 Dec 2018, at 16:07, David Edelsohn wrote: > > On Sun, Dec 23, 2018 at 6:16 AM Iain Sandoe wrote: >> >> Hi >> >> The c-c++-common tests fail (or XPASS depending on which) on Darwin >> because it doesn't currently emit .ident marker.

Re: v2 [PATCH] Fixes for PR68356, PR81210, and PR81693

2018-12-29 Thread Iain Sandoe
> On 29 Dec 2018, at 13:13, Dominique d'Humières wrote: > > New patch for taking into account the comments in > https://gcc.gnu.org/ml/gcc-patches/2017-11/msg01003.html > > 2018-12-29 Dominique d'Humieres > >PR tree-optimization/68356 >PR target/81210 >PR target/816

Re: [PATCH 4/4][libbacktrace] Add tests for unused formats

2019-01-02 Thread Iain Sandoe
> On 2 Jan 2019, at 13:20, Rainer Orth wrote: > > Gerald Pfeifer writes: > >> On Fri, 23 Nov 2018, Tom de Vries wrote: >>> When building libbacktrace, we typically use elf.c, and don't build >>> pecoff.c, xcoff.c or unknown.c >>> >>> Add testcases that use unused format to ensure that we al

Re: [PATCH 4/4][libbacktrace] Add tests for unused formats

2019-01-03 Thread Iain Sandoe
> On 2 Jan 2019, at 13:26, Iain Sandoe wrote: > > >> On 2 Jan 2019, at 13:20, Rainer Orth wrote: >> >> Gerald Pfeifer writes: >> >>> >>> >>> I believe that in addition to FreeBSD this probably also fails on >>> S

Re: [PATCH] restore CFString handling in attribute format (PR 88638)

2019-01-05 Thread Iain Sandoe
Hi Martin, > On 4 Jan 2019, at 22:30, Mike Stump wrote: > > On Jan 4, 2019, at 2:03 PM, Martin Sebor wrote: >> >> The improved handling of attribute positional arguments added >> in r266195 introduced a regression on Darwin where attribute >> format with the CFString archetype accepts CFString

Re: [PATCH] restore CFString handling in attribute format (PR 88638)

2019-01-05 Thread Iain Sandoe
> On 5 Jan 2019, at 17:39, Martin Sebor wrote: > > On 1/5/19 3:31 AM, Iain Sandoe wrote: >> Hi Martin, >>> On 4 Jan 2019, at 22:30, Mike Stump wrote: >>> >>> On Jan 4, 2019, at 2:03 PM, Martin Sebor wrote: >>>> >>>> The

Re: [PATCH] restore CFString handling in attribute format (PR 88638)

2019-01-07 Thread Iain Sandoe
dditional info, Iain. > > On 1/5/19 10:53 AM, Iain Sandoe wrote: >>> On 5 Jan 2019, at 17:39, Martin Sebor wrote: >>> >>> On 1/5/19 3:31 AM, Iain Sandoe wrote: >>>> Hi Martin, >>>>> On 4 Jan 2019, at 22:30, Mike Stump wrote: >>&

[PATCH, testsuite] Require alias support in three tests.

2019-01-07 Thread Iain Sandoe
Hi, These three tests fail on targets without alias support, OK to apply? Iain gcc/testsuite/ * gcc.dg/Wmissing-attributes.c: Require alias support. * gcc.dg/attr-copy-2.c: Likewise. * gcc.dg/attr-copy-5.c: Likewise. --- gcc/testsuite/gcc.dg/Wmissing-attributes.c | 1

[PATCH, testsuite] Allow builtin-has-attribute-* to run as far as possible on targets without alias support.

2019-01-07 Thread Iain Sandoe
Hi Martin, A) Some of the builtin-has-attribute tests fail because a sub-set of them need symbol alias support. Darwin has only support for weak aliases and therefore we need to skip these. However, the sub-set is small, and I am reluctant to throw out the entire set for the sake of a small num

Re: [PATCH 4/4][libbacktrace] Add tests for unused formats

2019-01-07 Thread Iain Sandoe
> On 3 Jan 2019, at 23:10, Ian Lance Taylor wrote: > > On Thu, Jan 3, 2019 at 3:49 AM Iain Sandoe wrote: >> >>> On 2 Jan 2019, at 13:26, Iain Sandoe wrote: >>> >>> >>>> On 2 Jan 2019, at 13:20, Rainer Orth wrote: >>>> &g

Re: [PATCH, testsuite] Allow builtin-has-attribute-* to run as far as possible on targets without alias support.

2019-01-07 Thread Iain Sandoe
Hi Martin, > On 8 Jan 2019, at 00:25, Martin Sebor wrote: > > On 1/7/19 9:55 AM, Iain Sandoe wrote: >> Hi Martin, >> A) >> Some of the builtin-has-attribute tests fail because a sub-set of them need >> symbol alias support. >> Darwin has only support fo

Re: [PATCH, rs6000] Fix PR91050 by adding a DRIVER_SELF_SPECS spec

2019-07-25 Thread Iain Sandoe
Hi Peter, > On 25 Jul 2019, at 15:41, Peter Bergner wrote: > > On 7/25/19 2:50 AM, Iain Sandoe wrote: >> This will break Darwin which has used DRIVER_SELF_SPECS in config/darwin.h >> since they were introduced (and the equivalent before). >> >> This is bec

[Darwin, testsuite, committed] Address PR91087 - XFAIL parts of pr16855.C.

2019-07-25 Thread Iain Sandoe
t when the target doesn’t support CTOR priorities - we might as well leave it as desired and at least that will DTRT within a single TU or under LTO. tested on x86-64-darwin16, x86_64-pc-linuc-gnu, applied to mainline thanks Iain 2019-07-25 Iain Sandoe PR gcov-profile/91087 * g

Re: [Darwin, testsuite, committed] Address PR91087 - XFAIL parts of pr16855.C.

2019-07-25 Thread Iain Sandoe
Hi Rainer, > On 25 Jul 2019, at 19:40, Rainer Orth wrote: > >> The testcase is failing to instrument part of the source because of a >> platform >> bug in the ordering of static DTORs. It seems unlikely that this is >> generically >> fixable in the toolchain (and given that it's likely to be

Re: [PATCH, rs6000] Fix PR91050 by adding a DRIVER_SELF_SPECS spec

2019-07-26 Thread Iain Sandoe
) thanks Iain > On 25 Jul 2019, at 18:34, Peter Bergner wrote: > > Uros and Jan, > > I should have CC'd you for the i386 portion of the patch. Are you ok with > the i386.h change if Iain's x86 Darwin testing comes out clean? > > On 7/25/19 9:41 AM, Peter Bergner

[Darwin, testsuite] Handle Darwin's size command.

2019-07-26 Thread Iain Sandoe
This one has been in my patch stack for a long time… Darwin's "size" command has a different header line, reflecting the Mach-O section naming conventions. This causes tests using the command to fail because scanasm.exp expects and checks specific layout of the header line. Tested on i686, x86_6

[Darwin, PPC, testsuite, committed] Fix fail for bmi2-bzhi64-1a.c

2019-07-27 Thread Iain Sandoe
:3: error: use of 'long long' in AltiVec types is invalid without '-mvsx' Fixed by adding -maltivec -mvsx to the options. tested on powerpc-darwin, powerpc-linux-gnu applied to mainline, thanks Iain gcc/testsuite/ 2019-07-27 Iain Sandoe * gcc.target/powerpc/bmi2-bzh

Re: [PATCH, Ada] Push -shared-libgcc where needed.

2019-08-04 Thread Iain Sandoe
Hi Eric, > On 30 Jun 2019, at 10:54, Eric Botcazou wrote: > >> 2019-06-30 Iain Sandoe >> >> * gnatlink.adb (Link_Step): Remove duplicate -static-libgcc switches. >> Push -shared-libgcc explicitly, when it is the target default (unless >> overidd

Re: [PATCH, Ada, Darwin, PPC] PPC Darwin has stack check probes.

2019-08-04 Thread Iain Sandoe
> On 1 Jul 2019, at 22:57, Eric Botcazou wrote: > >> 2019-07-01 Iain Sandoe >> >> * libgnat/system-darwin-ppc.ads: Set Stack_Check_Probes True for >> PPC Darwin. > > OK, thanks. This (PPC)Darwin-specific patch has been on mainline for some t

Darwin backports commited for 9.2

2019-08-04 Thread Iain Sandoe
Hi, It seems that we’ve fixed quite a few testsuite issues over the last months that exist on all the open branches. This has made for quite a large number of test-related backports. General stuff is much smaller in content. These were tested on i686,powerpc-darwin9, x86_64-darwin16, 18 powerpc

Re: [objective-c/c++, testsuite, committed, 1/3] Workaround for PR90709.

2019-08-04 Thread Iain Sandoe
> On 15 Jun 2019, at 15:08, Iain Sandoe wrote: > > Since we cannot parse the current NeXT headers, because of PR90709 and its > dependents, we have a large amount of testsuite noise for Darwin platforms. > In order to restore the usefulness of the testsuite, we are going add he

Re: [PATCH, Ada] Push -shared-libgcc where needed.

2019-08-05 Thread Iain Sandoe
> On 4 Aug 2019, at 21:42, Eric Botcazou wrote: > >> This patch has now been on mainline for some time without any apparent >> issue, the problem is also present on the open branches, may I backport it? > > OK, thanks. Done for 9.2. Iain

Re: [PATCH, Ada, Darwin, PPC] PPC Darwin has stack check probes.

2019-08-05 Thread Iain Sandoe
> On 4 Aug 2019, at 21:43, Eric Botcazou wrote: > >> This (PPC)Darwin-specific patch has been on mainline for some time now >> without issues, the problem is present on open branches, may I backport it? > > Yes, thanks. Done for 9.2 Iain

[Darwin, committed] There is no need to distinguish PIC/non-PIC symbol stubs.

2019-08-13 Thread Iain Sandoe
/testsuite/ 2019-08-13 Iain Sandoe * obj-c++.dg/stubify-1.mm: Rename symbol stub option. * obj-c++.dg/stubify-2.mm: Likewise. * objc.dg/stubify-1.m: Likewise. * objc.dg/stubify-2.m: Likewise. diff --git a/gcc/config/darwin.c b/gcc/config/darwin.c index 5ac092583b

Re: [PATCH 0/3] Libsanitizer: merge from trunk

2019-08-15 Thread Iain Sandoe
on/sanitizer_vector.h:18:10: fatal error: sanitizer_common/sanitizer_allocator_internal.h: No such file or directory 18 | #include "sanitizer_common/sanitizer_allocator_internal.h" | ^ Which is because the top

[libsanitizer, comitted] Fix PR bootstrap/91455

2019-08-15 Thread Iain Sandoe
Iain Sandoe PR bootstrap/91455 * Makefile.in: Regenerated. * aclocal.m4: Likewise. * asan/Makefile.in: Likewise. * configure: Likewise. * interception/Makefile.in: Likewise. * libbacktrace/Makefile.in: Likewise. * lsan/Makefile.in

[libsanitizer, committed] Reapply r272406.

2019-08-16 Thread Iain Sandoe
Iain Sandoe * asan/asan_interceptors.h: Reapply r272406. diff --git a/libsanitizer/asan/asan_interceptors.h b/libsanitizer/asan/asan_interceptors.h index 155ea4156a..035a84e1a4 100644 --- a/libsanitizer/asan/asan_interceptors.h +++ b/libsanitizer/asan/asan_interceptors.h @@ -80,7 +80,12

[Darwin, PPC, committed] Fix fail of cpp/assert4.c

2019-08-18 Thread Iain Sandoe
Despite that the cpp assert facility is deprecated, we do have a test for it. This test needs the cpu and machine asserts to be implemented which hadn't been done for PPC Darwin. Fixed thus. tested on powerpc-darwin9, applied to mainline, Iain gcc/ 2019-08-18 Iain Sandoe * c

<    6   7   8   9   10   11   12   13   14   15   >