[PATCH] Allow `gcc_jit_type_get_size` to work with pointers

Hi, Here's a little fix to allow the `gcc_jit_type_get_size` function to work on pointer types as well. Cordially. From 21e6e2d5ea897fc74d0e3194973093c58157e6fa Mon Sep 17 00:00:00 2001 From: Guillaume Gomez Date: Tue, 26 Mar 2024 17:56:36 +0100 Subject: [PATCH] [PATH]

Re: [PATCH] Allow `gcc_jit_type_get_size` to work with pointers

I can push it. Thanks for the (very quick) review! Le ven. 29 mars 2024 à 18:48, David Malcolm a écrit : > > On Thu, 2024-03-28 at 23:47 +0100, Guillaume Gomez wrote: > > Hi, > > > > Here's a little fix to allow the `gcc_jit_type_get_size` function to >

Re: [PATCH] Allow `gcc_jit_type_get_size` to work with pointers

Pushed as commit 4c18ace1cb69a31af4ac719850a66de79ed12e93. Le ven. 29 mars 2024 à 18:50, Guillaume Gomez a écrit : > > I can push it. Thanks for the (very quick) review! > > Le ven. 29 mars 2024 à 18:48, David Malcolm a écrit : > > > > On Thu, 2024-03-28 at 23:47 +010

Re: [PATCH] Add support for function attributes and variable attributes

h > comments explaining why. I added them with a comment on top of each of them. I joined the new patch version. Thanks again for the review! Le mar. 9 janv. 2024 à 20:59, David Malcolm a écrit : > > On Wed, 2023-11-15 at 17:53 +0100, Guillaume Gomez wrote: > > Hi, > > > &

Re: [PATCH] Add support for function attributes and variable attributes

just add a call to `asm` to prevent this from happening so I added it. So yes, all jit tests are passing as expected. :) Le jeu. 11 janv. 2024 à 19:46, David Malcolm a écrit : > > On Thu, 2024-01-11 at 01:00 +0100, Guillaume Gomez wrot

Re: [PATCH] Add support for function attributes and variable attributes

that the attributes are correctly applied. > Do you have push rights, or do you need me to push it for you? I have push rights so I'll merge the patch myself. But thanks for offering to do it. Le jeu. 11 janv. 2024 à 23:38, David Malcolm a écrit : > > On Thu, 2024-01-11 at 22:40 +0100

Re: [PATCH] Add support for function attributes and variable attributes

Just realized that you were asking for the patch I forgot to join... Here it is. Le ven. 12 janv. 2024 à 11:09, Guillaume Gomez a écrit : > > > It sounds like the patch you have locally is ready, but it has some > > nontrivial changes compared to the last version you pos

Re: [PATCH] Add support for function attributes and variable attributes

Ping David. :) Le sam. 9 déc. 2023 à 12:12, Guillaume Gomez a écrit : > > Added it. > > Le jeu. 7 déc. 2023 à 18:13, Antoni Boucher a écrit : > > > > It seems like you forgot to prefix the commit message with "libgccjit: > > ". > > > > On T

Re: [PATCH] Add support for function attributes and variable attributes

Ping David. :) Le lun. 18 déc. 2023 à 23:27, Guillaume Gomez a écrit : > > Ping David. :) > > Le sam. 9 déc. 2023 à 12:12, Guillaume Gomez > a écrit : > > > > Added it. > > > > Le jeu. 7 déc. 2023 à 18:13, Antoni Boucher a écrit : > > > >

Re: [PATCH] Add support for function attributes and variable attributes

Added it. Le jeu. 7 déc. 2023 à 18:13, Antoni Boucher a écrit : > > It seems like you forgot to prefix the commit message with "libgccjit: > ". > > On Thu, 2023-11-30 at 10:55 +0100, Guillaume Gomez wrote: > > Ping David. :) > > > > Le jeu. 23 nov

[PATCH] Add missing declaration of get_restrict in C++ interface

Hi, This patch adds the `get_restrict` method declaration for the C++ interface as it was forgotten. Thanks in advance for the review. From e819fd01cd3e79bfab28a77f4ce78f34156e7a83 Mon Sep 17 00:00:00 2001 From: Guillaume Gomez Date: Thu, 9 Nov 2023 17:53:08 +0100 Subject: [PATCH] Add missing

Re: [PATCH] Add missing declaration of get_restrict in C++ interface

I confirm it does. I realized it when finalizing our patch for attributes support. Le jeu. 9 nov. 2023 à 21:49, David Malcolm a écrit : > > On Thu, 2023-11-09 at 21:03 +0100, Guillaume Gomez wrote: > > Hi, > > > > This patch adds the `get_restrict` method declaration for

[PATCH] Add support for function attributes and variable attributes

a4 Mon Sep 17 00:00:00 2001 From: Guillaume Gomez Date: Mon, 20 Jun 2022 14:34:39 -0400 Subject: [PATCH] [PATCH] Add support for function attributes and variable attributes. gcc/jit/ChangeLog: * dummy-frontend.cc (handle_alias_attribute): New function. (handle_always_inline_attribute): Ne

Re: [PATCH] Add support for function attributes and variable attributes

should use a struct instead. > Can you please elaborate again? > Thanks. > > On Wed, 2023-11-15 at 17:53 +0100, Guillaume Gomez wrote: > > Hi, > > > > This patch adds the (incomplete) support for function and variable > > attributes. The added attributes are t

Re: [PATCH] Add support for function attributes and variable attributes

> or somesuch? But I think the API you currently have is OK. > > On Thu, 2023-11-23 at 22:52 +0100, Guillaume Gomez wrote: > > Ping David. :) > > > > Le mer. 15 nov. 2023 à 17:56, Antoni Boucher a > > écrit : > > > > > > David: another thing I

[PATCH] Add rvalue::get_name method (and its C equivalent)

Hi, I just encountered the need to retrieve the name of an `rvalue` (if there is one) while working on the Rust GCC backend. This patch adds a getter to retrieve the information. Cordially. From d2ddeec950f23533e5e18bc0c10c4b49eef3cda3 Mon Sep 17 00:00:00 2001 From: Guillaume Gomez Date: Sat

Re: [PATCH] Add rvalue::get_name method (and its C equivalent)

quate modifications to the inheriting classes. Good catch, thanks! Updated the patch and attached the new version to this email. Cordially. Le lun. 22 avr. 2024 à 11:51, Arthur Cohen a écrit : > > Hey Guillaume :) > > On 4/20/24 01:05, Guillaume Gomez wrote: > > Hi, > > > >

Re: [PATCH] Add rvalue::get_name method (and its C equivalent)

... I most definitely forgot. Thanks! ^^' Le lun. 22 avr. 2024 à 15:19, Antoni Boucher a écrit : > I believe you forgot to regenerate the ChangeLog. > > Le 2024-04-22 à 09 h 16, Guillaume Gomez a écrit : > > Good point! > > > > New patch attached. > > &g

Re: [PATCH] Add rvalue::get_name method (and its C equivalent)

Good point! New patch attached. Le lun. 22 avr. 2024 à 15:13, Antoni Boucher a écrit : > > Please move the function to be on lvalue since there are no rvalue types > that are not lvalues that have a name. > > Le 2024-04-22 à 09 h 04, Guillaume Gomez a écrit : > > Hey Arthur

Re: [PATCH] Add rvalue::get_name method (and its C equivalent)

RETURN_IF_FAIL (lvalue->is_global () || lvalue->is_local (), > NULL, > NULL, > "lvalue should be a variable"); > > > Le 2024-04-22 à 09 h 16, Guillaume Gomez a écrit : > > Good point! > > >

[PATCH] libgccjit: Add support for `restrict` attribute on function parameters

Hi, This patch adds the possibility to specify the __restrict__ attribute for function parameters. It is used by the Rust GCC backend. Thanks in advance for the review. From 8cafadb8409094c7fc66a1073397942a60cb27b3 Mon Sep 17 00:00:00 2001 From: Guillaume Gomez Date: Fri, 11 Aug 2023 22:48:11

Re: [PATCH] libgccjit: Add support for `restrict` attribute on function parameters

My apologies, forgot to run the commit checkers. Here's the commit with the errors fixed. Le mer. 16 août 2023 à 18:32, Guillaume Gomez a écrit : > > Hi, > > This patch adds the possibility to specify the __restrict__ attribute > for function parameters. It is used by

Re: [PATCH] libgccjit: Add support for `restrict` attribute on function parameters

gt; Thanks again for the patch; hope the above is constructive It was incredibly useful! Thanks for taking time to writing down the explanations. The new patch is attached to this email. Cordially. Le jeu. 17 août 2023 à 01:06, David Malcolm a écrit : > > On Wed, 2023-08-16 at 22:06 +02

Re: [PATCH] libgccjit: Add support for `restrict` attribute on function parameters

Antoni spot a typo I made: I added `LIBGCCJIT_HAVE_gcc_jit_type_get_size` instead of `LIBGCCJIT_HAVE_gcc_jit_type_get_restrict`. Fixed in this patch, sorry for the noise. Le jeu. 17 août 2023 à 11:30, Guillaume Gomez a écrit : > > Hi Dave, > > > What kind of testing has the patch

Re: [PATCH] libgccjit: Add support for `restrict` attribute on function parameters

And now I just discovered that a lot of commits from Antoni's fork haven't been sent upstream which is why the ABI count is so high in his repository. Fixed that as well. Le jeu. 17 août 2023 à 17:26, Guillaume Gomez a écrit : > > Antoni spot a typo I m

Re: [PATCH] libgccjit: Add support for `restrict` attribute on function parameters

Thanks for the review! Le jeu. 17 août 2023 à 17:50, David Malcolm a écrit : > > On Thu, 2023-08-17 at 17:41 +0200, Guillaume Gomez wrote: > > And now I just discovered that a lot of commits from Antoni's fork > > haven't been sent upstream which is why the ABI

Re: [PATCH] libgccjit: Add support for `restrict` attribute on function parameters

Quick question: do you plan to make the merge or should I ask Antoni? Le jeu. 17 août 2023 à 17:59, Guillaume Gomez a écrit : > Thanks for the review! > > Le jeu. 17 août 2023 à 17:50, David Malcolm a écrit > : > > > > On Thu, 2023-08-17 at 17:41 +0200, Guillaume Gome

Re: [PATCH] libgccjit: Fix a failing test

Ping David. Le lun. 16 janv. 2023 à 15:08, Guillaume Gomez a écrit : > Ping David. > > Le jeu. 5 janv. 2023 à 23:37, Guillaume Gomez > a écrit : > >> Ping David. >> >> Le sam. 24 déc. 2022 à 21:01, Guillaume Gomez >> a écrit : >> >>> Ping

Re: [PATCH] libgccjit: Fix a failing test

No problem, thanks for the explanations. I joined the patch with the fixed commit message. Le jeu. 2 mars 2023 à 22:58, David Malcolm a écrit : > On Thu, 2022-12-15 at 08:34 +0100, Guillaume Gomez via Jit wrote: > > Forgot it indeed, thanks for notifying me! > > > >

Re: [PATCH] libgccjit: Fix a failing test

Just realized I used whitespace and not a tab. Sorry about that. Here's the fixed version... Le jeu. 2 mars 2023 à 23:19, Guillaume Gomez a écrit : > No problem, thanks for the explanations. > > I joined the patch with the fixed commit message. > > Le jeu. 2 mars 2023 à 22:

Re: [PATCH] libgccjit: Fix a failing test

I don't have push rights so if you could push it, it'd be super appreciated! Le jeu. 2 mars 2023 à 23:33, David Malcolm a écrit : > On Thu, 2023-03-02 at 23:29 +0100, Guillaume Gomez wrote: > > Just realized I used whitespace and not a tab. Sorry about that. > > Her

Re: [PATCH] libgccjit: Fix a failing test

Thanks! Le jeu. 2 mars 2023 à 23:54, David Malcolm a écrit : > On Thu, 2023-03-02 at 23:35 +0100, Guillaume Gomez wrote: > > I don't have push rights so if you could push it, it'd be super > > appreciated! > > Done, as r13-6425-g6b432c0f777ab9; I took the lib

PATCH: c++tools: fix compilation

ock_fd >= 0 && FD_ISSET (sock_fd, &readers)) | ^~~ It was missing a preprocessor condition around this code to work as the "readers" variable is created only in a preprocessor condition. Signed-off-by: Guillaume Gomez From 39279d8b37287c09708d910921ce5cfa5b

[PATCH] libgccjit: Fix a failing test

Hi, This fixes bug 107999. Thanks in advance for the review. From e6db0cb107e54789095f4585dd279a2c984d2ca1 Mon Sep 17 00:00:00 2001 From: Guillaume Gomez Date: Wed, 14 Dec 2022 14:28:22 +0100 Subject: [PATCH] Fix a failing test by updating its error string. gcc/testsuite/ChangeLog: * jit.dg

Re: [PATCH] libgccjit: Fix a failing test

igned-off-by: Guillaume Gomez > > On Wed, 2022-12-14 at 14:39 +0100, Guillaume Gomez via Jit wrote: > > Hi, > > > > This fixes bug 107999. > > > > Thanks in advance for the review. > > From 30f049d4f39de392dbb3cff4b64779f2507fc914 Mon Sep 17 00:00:00 2001 Fro

Re: [PATCH] libgccjit: Fix a failing test

Ping David Le jeu. 15 déc. 2022 à 11:34, Guillaume Gomez a écrit : > Forgot it indeed, thanks for notifying me! > > I modified the commit message to add it and added it into this email. > > Le mer. 14 déc. 2022 à 16:12, Antoni Boucher a écrit : > >> Thanks! >> &g

Re: [PATCH] libgccjit: Fix a failing test

Ping David. Le sam. 24 déc. 2022 à 21:01, Guillaume Gomez a écrit : > Ping David > > Le jeu. 15 déc. 2022 à 11:34, Guillaume Gomez > a écrit : > >> Forgot it indeed, thanks for notifying me! >> >> I modified the commit message to add it and added it into this

Re: [PATCH] libgccjit: Fix a failing test

Ping David. Le jeu. 5 janv. 2023 à 23:37, Guillaume Gomez a écrit : > Ping David. > > Le sam. 24 déc. 2022 à 21:01, Guillaume Gomez > a écrit : > >> Ping David >> >> Le jeu. 15 déc. 2022 à 11:34, Guillaume Gomez >> a écrit : >> >>> Forgot

Re: [PATCH] libgccjit: Add support for `restrict` attribute on function parameters

t; On Thu, 2023-08-17 at 20:09 +0200, Guillaume Gomez via Jit wrote: > > Quick question: do you plan to make the merge or should I ask Antoni? > > > > Le jeu. 17 août 2023 à 17:59, Guillaume Gomez > > > > a écrit : > > > > > Thanks for t

Re: [PATCH] libgccjit: Add support for `restrict` attribute on function parameters

ists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20171218/512066.html * https://reviews.llvm.org/D40118 Le ven. 25 août 2023 à 22:47, Guillaume Gomez a écrit : > > After more investigations, it seems like the fault was on our side as > we were calling `gcc_jit_type_get_restrict` on types tha

Re: [PATCH] libgccjit: Add support for `restrict` attribute on function parameters

Thanks a lot! Le mar. 29 août 2023 à 17:35, David Malcolm a écrit : > > On Tue, 2023-08-29 at 17:15 +0200, Guillaume Gomez wrote: > > We finished the investigation and found out the issue: when passing > > arguments by value to functions, rustc still provides "NoAlias&q

Re: [PATH] [CLEANUP] Remove trailing whitespace characters

Hi David. Thanks for the feedback! Well, I think at this point, better to get "global approval" on the idea and on what you suggested (which I agree with) before I make any additional changes considering how big the patch is. Let's wait for others to also express their opinion here.