Re: [wwwdocs] Add feature-testing macros and std::is_final to gcc-5/changes.html

2014-10-02 Thread Ed Smith-Rowland
On 10/02/2014 06:14 AM, Jonathan Wakely wrote: On 02/10/14 11:12 +0100, Jonathan Wakely wrote: Note Ed's recent changes. Committed to CVS. And fix a markup error that I expected xmllint to catch :-( Thank you! I tried to do this and couldn't for permissions. I'm probably not doing it right.

std::is_final for gcc-4.9 branch.

2014-10-02 Thread Ed Smith-Rowland
Built and tested clean on x86_64-linux. OK? Ed 2014-10-03 Edward Smith-Rowland <3dw...@verizon.net> * include/std/type_traits: Add is_final<> type trait for C++14. * testsuite/util/testsuite_tr1.h: Add * testsuite/20_util/is_final/requirements/ explicit_insta

SD-6 C++ feature-testing macros for 4.9

2014-10-04 Thread Ed Smith-Rowland
trait going on the branch too). - Original Message - From: "Jason Merrill" To: "Ed Smith-Rowland" <3dw...@verizon.net>, "Jonathan Wakely" Cc: gcc-patches@gcc.gnu.org, "thiago macieira" Sent: Thursday, 2 October, 2014 4:40:03 PM Subject: Re

[C++ PR57640] Explicit call of system literal operator complains about leading underscore

2013-06-25 Thread Ed Smith-Rowland
This little nit was certainly latent all along but was only exposed once we got literal ops into the std library. A user who calls a operator explicitly get yelled at for not having anunderscore. OK after testing completes on x86_64-linux? Ed gcc/cp: 2013-06-25 Ed Smith-Rowland <

[C++] DR1473 - let literal operators be defined with empty user-defined string literal

2013-06-25 Thread Ed Smith-Rowland
This will allow such things as constexpr std::complex operator""if(long double imag); OK after testing completes on x86_64-linux. Ed gcc/cp: 2013-06-25 Ed Smith-Rowland <3dw...@verizon.net> * gcc/cp/parser.c (cp_parser_operator()): Parse user-defined string

Re: C++ 2014 status page for libstdc++

2013-06-25 Thread Ed Smith-Rowland
t the first paragraph should be changed (or removed.) Just removed this paragraph. Applied. Ed 2013-06-25 Ed Smith-Rowland <3dw...@verizon.net> Status page for C++2014 library features * doc/xml/faq.xml: Add link to new C++14 status page. * doc/xml/manual/intro.xml: Dit

Re: [C++] DR1473 - let literal operators be defined with empty user-defined string literal

2013-06-26 Thread Ed Smith-Rowland
On 06/25/2013 08:50 AM, Jason Merrill wrote: I had missed a few files in my patch anyway (I was doing too much at once). On 06/25/2013 08:27 AM, Ed Smith-Rowland wrote: + else if (token->type == CPP_KEYWORD) +{ + error ("unexpected keyword;" + " Re

Re: C++ 2014 status page for libstdc++

2013-06-27 Thread Ed Smith-Rowland
On 06/27/2013 07:01 AM, Jonathan Wakely wrote: On 26 June 2013 02:28, Ed Smith-Rowland wrote: On 06/25/2013 11:59 AM, Jonathan Wakely wrote: On 25 June 2013 16:45, <3dw...@verizon.net> wrote: Here is a C++2014 status page for fun and profit. Excellent, thanks! Tested with xmllint

Re: [C++] DR1473 - let literal operators be defined with empty user-defined string literal

2013-06-28 Thread Ed Smith-Rowland
On 06/26/2013 05:01 PM, Jason Merrill wrote: On 06/26/2013 09:43 AM, Ed Smith-Rowland wrote: + if (bad_encoding_prefix) +error ("invalid encoding prefix in literal operator"); + { +tree string_tree = USERDEF_LITERAL_VALUE (token->u.value); No need to open a nes

[PING] Re: C++ 2014 status page for libstdc++

2013-07-03 Thread Ed Smith-Rowland
On 06/27/2013 11:24 PM, Ed Smith-Rowland wrote: On 06/27/2013 07:01 AM, Jonathan Wakely wrote: On 26 June 2013 02:28, Ed Smith-Rowland wrote: On 06/25/2013 11:59 AM, Jonathan Wakely wrote: On 25 June 2013 16:45, <3dw...@verizon.net> wrote: Here is a C++2014 status page for fun and

Re: [patch] regex_traits implementation

2013-07-09 Thread Ed Smith-Rowland
On 07/09/2013 06:17 AM, Jonathan Wakely wrote: On 9 July 2013 11:13, Tim Shen wrote: On Tue, Jul 9, 2013 at 4:35 PM, Jonathan Wakely wrote: Sorry for the delay, I missed this latest version - it looks excellent and is fine to commit. Do you have svn write access or do you need someone to commi

[PR c++/58072][C++11]

2013-08-04 Thread Ed Smith-Rowland
rror() and inserts useful phrases in the error messages. Built and tested on x86-64-linux. OK? Ed gcc/c-family: 2013-08-04 Ed Smith-Rowland <3dw...@verizon.net> PR c++/58072 * c-common.c (c_parse_error): Catch user-defined literal tokens and provide usef

[C++11] There can be only one ref qualifier at most.

2013-04-04 Thread Ed Smith-Rowland
+++ gcc/testsuite/g++.dg/cpp0x/ref-qual-multi-neg.C (revision 0) @@ -0,0 +1,7 @@ +// { dg-require-effective-target c++11 } + +class Foo +{ +public: + void bar() const && & { } // { dg-error "multiple ref-qualifiers" } +}; gcc/cp: 2013-04-05 Ed

[C++1y] Support n3599 - Literal operator templates for strings for C++1y

2013-04-16 Thread Ed Smith-Rowland
rator"" _script() + { return 42; } // { dg-error "literal operator template|has invalid parameter list" } + +int i = "hi!"_script; gcc/cp: 2013-04-17 Ed Smith-Rowland <3dw...@verizon.net> Implement n3599 - Literal operator templates for strings.

[PATCH, PR C++/61038] - g++ -E is unusable with UDL strings

2014-05-12 Thread Ed Smith-Rowland
This patch is really a libcpp patch. But UDLs are like that ;-) Add string user-defined literals and char user-defined literals to the list of things to look out for while escaping strings in macro args. I'm not sure how to test this really. we want to write out *.ii files and verify that i

Re: [PATCH, PR C++/61038] - g++ -E is unusable with UDL strings

2014-05-13 Thread Ed Smith-Rowland
On 05/13/2014 01:29 PM, Joseph S. Myers wrote: On Mon, 12 May 2014, Ed Smith-Rowland wrote: This patch is really a libcpp patch. But UDLs are like that ;-) Add string user-defined literals and char user-defined literals to the list of things to look out for while escaping strings in macro

[PATCH, libstdc++/61166] overflow when parse number in std::duration operator""

2014-05-14 Thread Ed Smith-Rowland
Make the machinery in bits/parse_number.h unsigned long long. I had actually noticed this a while back but we were in stage 4. Then I forgot.. :-/ Built and tested on x84_64-linux. OK? 2014-05-14 Ed Smith-Rowland <3dw...@verizon.net> libstdc++/61166 overflow when parse num

Re: [PATCH, libstdc++/61166] overflow when parse number in std::duration operator""

2014-05-14 Thread Ed Smith-Rowland
On 05/14/2014 09:59 AM, Daniel Krügler wrote: 2014-05-14 15:38 GMT+02:00 Ed Smith-Rowland <3dw...@verizon.net>: Make the machinery in bits/parse_number.h unsigned long long. I had actually noticed this a while back but we were in stage 4. Then I forgot.. :-/ Built and tested on x84_64

Re: [PATCH, libstdc++/61166] overflow when parse number in std::duration operator""

2014-05-15 Thread Ed Smith-Rowland
On 05/15/2014 03:03 PM, Jonathan Wakely wrote: Here's a finished patch to simplify Tested x86_64-linux. Ed, any objection to this version? This looks great, thanks! Having done that should we actually stop using it as suggested in the bug trail? ;-)

[C++11, C++14 PATCH 0/3] Support for SD-6: SG10 Feature Test Recommendations

2014-05-30 Thread Ed Smith-Rowland
A group within the C++ standards committee was charged with the responibility of coming up with a way for users to test a C++ compiler and runtime for the availability of new features. These features are intended to aid users in a time of intense C++ evolution. These features are not really p

[C++11, C++14 PATCH 2/3] Support for SD-6: SG10 Feature Test Recommendations - c-family and testsuite

2014-05-30 Thread Ed Smith-Rowland
This is the c-family part: Setting the language feature macos and defining the __has_include macro. c-family: 2014-05-31 Ed Smith-Rowland <3dw...@verizon.net> Implement SD-6: SG10 Feature Test Recommendations * c-cppbuiltin.c (c_cpp_builtins()): Define language f

[C++11, C++14 PATCH 1/3] Support for SD-6: SG10 Feature Test Recommendations - libcpp

2014-05-30 Thread Ed Smith-Rowland
Here is the libcpp portion. 2014-05-31 Ed Smith-Rowland <3dw...@verizon.net> Implement SD-6: SG10 Feature Test Recommendations * directives.c: Support __has_include__ builtin. * expr.c (parse_has_include): New function to parse __has_include__ b

[C++11, C++14 PATCH 3/3] Support for SD-6: SG10 Feature Test Recommendations - libstdc++

2014-05-30 Thread Ed Smith-Rowland
This is the libstdc++ and libstdc++ testsuite part. 2014-05-31 Ed Smith-Rowland <3dw...@verizon.net> Implement SD-6: SG10 Feature Test Recommendations * include/bits/basic_string.h: Add __cpp_lib feature test macro. * include/bits/stl_algobase.h:

PR libstdc++/59529, 59530,59531 Various string_view bugs.

2014-01-24 Thread Ed Smith-Rowland
As committed: Same patch as discussed before all the holidays. Built and tested x86_64-linux. 2014-01-24 Ed Smith-Rowland <3dw...@verizon.net> Peter A. Bigot PR libstdc++/59529 * include/experimental/string_view (basic_string_view(const

[libstdc++-v3] Move shared_mutex to shared_timed_mutex - late C++14 change (n3891)

2014-02-21 Thread Ed Smith-Rowland
This are the patches as applied Built and tested x86_64-linux. 2014-02-20 Ed Smith-Rowland <3dw...@verizon.net> Rename shared_mutex to shared_timed_mutex per C++14 acceptance of N3891. * include/std/shared_mutex: Rename shared_mutex to shared_timed_mutex. * tes

[C++ Patch] PR 50025 - [DR 1288] C++0x initialization syntax doesn't work for class members of reference type

2014-03-01 Thread Ed Smith-Rowland
Built and tested on x86-64-linux. This is just a test case. 2014-03-01 Edward Smith-Rowland <3dw...@verizon.net> PR c++/50025 * g++.dg/cpp0x/pr50025.C: New. Index: g++.dg/cpp0x/pr50025.C === --- g++.dg/cpp0x/pr50

[PATCH, libstdc++] Add the logistic distribution as an extension

2014-07-10 Thread Ed Smith-Rowland
The title says it all. I've been bootstrapping and testing with this on x86_64-linux for a month. OK? Ed 2014-07-10 Edward Smith-Rowland <3dw...@verizon.net> Add the logistic_distribution as an extension. * include/ext/random: Add the logistic_distribution. * includ

[PATCH, C++, CPP] Add C++1z to the preprocessor. Rename C++1y to C++14.

2014-07-10 Thread Ed Smith-Rowland
Here are some C++ versioning changes reflecting C++14 status and adding c++1z. It is a followup to Jason's patch on 2014-06-26 adding std=c++1z, etc. This will allow us to start making C++1z changes to the preprocessor (n3981 remove trigraphs). In fact, I made trigraphs opt-in for both c++1z

[PATCH preprocessor/61389] - libcpp diagnostics shouldn't talk about ISO C99 for C++ input files

2014-07-10 Thread Ed Smith-Rowland
Here is a preprocessor patch to make error messages show C++11 and other relevant C++ language instead of C99. Built and tested on x86_64-linux. OK? libcpp/ 2014-07-09 Edward Smith-Rowland <3dw...@verizon.net> PR CPP/61389 * macro.c (_cpp_arguments_ok, parse_params, create

[PATCH libstdc++] Buglet in gcc/testsuite/g++.dg/cpp1y/digit-sep-neg.C

2014-07-10 Thread Ed Smith-Rowland
Index: gcc/testsuite/g++.dg/cpp1y/digit-sep-neg.C === --- gcc/testsuite/g++.dg/cpp1y/digit-sep-neg.C(revision 212440) +++ gcc/testsuite/g++.dg/cpp1y/digit-sep-neg.C(working copy) @@ -7,7 +7,7 @@ i = 1048''576; // { dg-error

Re: [PATCH, libstdc++] Add the logistic distribution as an extension

2014-07-11 Thread Ed Smith-Rowland
On 07/10/2014 06:16 AM, Paolo Carlini wrote: .. I have another comment: are we sure the usual strategy: template result_type operator()(_UniformRandomNumberGenerator& __urng) { return this->operator()(__urng, this->_M_param); } doesn't make sense here too? Paolo. >> Look OK

Re: [PATCH, libstdc++] Add the logistic distribution as an extension

2014-07-11 Thread Ed Smith-Rowland
On 07/11/2014 11:42 AM, Paolo Carlini wrote: Hi, On 07/11/2014 05:38 PM, Ed Smith-Rowland wrote: OK? Ok, thanks, but please adjust the dates you have on the testcases to the date of the actual commit (I suppose today or tomorrow) Thanks again! Paolo. As committed. Thanks all for looking

[PATCH] PR C++/60209 - Declaration of user-defined literal operator cause error

2014-07-12 Thread Ed Smith-Rowland
PING! Support operator"" ""(...) per CWG 1473. This brings full string parsing to literal operator declarations including string chunk concatenation and appropriate errors. Bootstrapped and tested on x86_64-linux. OK? I'm less sure if this is appropriate for 4.9 even when it opens. cp/

[PATCH] PR preprocessor/23827 - standard C++ should not have hex float preprocessing tokens

2014-07-12 Thread Ed Smith-Rowland
Greetings, This old bug involved C++98 accepting hex floats without complaint. I also split the error messages between C and C++ like in the recent PR 61389 patch. Bootstrapped and tested clean on x86_64-linux. OK? libcpp/ 2014-07-12 Edward Smith-Rowland <3dw...@verizon.net> PR

Re: [PATCH] libstdc++: add uniform on sphere distribution

2014-07-13 Thread Ed Smith-Rowland
> are these dummy implementations intended? Yes. There is no state. The only parameter is the dimensionality which is a template parameter. We do often serialize underlying helper distributions, in your case the normal distribution _M_n. While the normal distribution mean and stddev are tr

Re: [PATCH] libstdc++: add uniform on sphere distribution

2014-07-13 Thread Ed Smith-Rowland
On 07/13/2014 10:11 AM, Ulrich Drepper wrote: On Sun, Jul 13, 2014 at 9:55 AM, Ed Smith-Rowland <3dw...@verizon.net> wrote: So I would just serialize _M_n here. It has fixed parameters. This would mean unnecessary work. When you try to use the parameter of the sphere distribution the

Re: [PATCH] libstdc++: add uniform on sphere distribution

2014-07-16 Thread Ed Smith-Rowland
On 07/14/2014 04:14 AM, Paolo Carlini wrote: Hi, On 07/14/2014 09:58 AM, Andreas Schwab wrote: FAIL: ext/random/arcsine_distribution/cons/default.cc (test for excess errors) Excess errors: /daten/aranym/gcc/gcc-20140714/libstdc++-v3/include/ext/random.tcc:1587:22: error: '_M_n' was not declar

Re: Patch for constexpr variable templates

2014-07-21 Thread Ed Smith-Rowland
Braden, I've played with this and it seems to work nicely. Only one comment: Could you put the test cases in the C++14 subdirectory? g++.dg/template/cpp1y/var-templ1.C ^ We should CC Jason on all this. Also, do you have your FSF paperwork in place? Thanks, Ed

Implement N4051 - Allow typename in a template template parameter

2014-07-21 Thread Ed Smith-Rowland
This little annoyance has bugged me a couple of times over the years: template struct A {}; template using B = int; template class X> struct C; C ca; // ok C cb; // ok, not a class template template typename X> struct D; // error, cannot use typename here C++17 it seems allows typename in tem

Re: Implement N4051 - Allow typename in a template template parameter

2014-07-22 Thread Ed Smith-Rowland
On 07/22/2014 01:56 AM, Ville Voutilainen wrote: +/* Parse a type-parameter-key. + + type-parameter-key: + class + typedef + + Returns the kind of type-parameter-key specified, or none_type to indicate + error. */ + Typo above, should be typename, not typedef. Thanks! New patch

Re: Patch for constexpr variable templates

2014-07-23 Thread Ed Smith-Rowland
Braden, Great work on this. In addition to helping with constraints there is at least one new library feature that depends on constexpr variable templates. For my two cents it would be good to get just the constexpr variable templates, aka n3651, in now as a first stage - it's quite usable.

Re: Implement N4051 - Allow typename in a template template parameter

2014-07-23 Thread Ed Smith-Rowland
On 07/23/2014 06:05 AM, Jason Merrill wrote: On 07/22/2014 01:53 PM, Ed Smith-Rowland wrote: +if (cxx_dialect < cxx1z) + { +/* Look for the `class' keyword. */ +cp_parser_require_keyword (parser, RID_CLASS, RT_CLASS); + } +else + { +/*

Re: Implement N4051 - Allow typename in a template template parameter

2014-07-24 Thread Ed Smith-Rowland
On 07/24/2014 11:32 AM, Jason Merrill wrote: On 07/23/2014 10:31 PM, Ed Smith-Rowland wrote: +pedwarn (token->location, OPT_Wpedantic, + "ISO C++ forbids typename key in template template parameter"); This should mention -std=c++1z. + if (tag_type

Re: Make the string_view literal operators constexpr like the ctors they call.

2014-07-24 Thread Ed Smith-Rowland
On 03/08/2014 01:33 PM, Jonathan Wakely wrote: On 8 March 2014 16:29, Ed Smith-Rowland wrote: On 03/08/2014 11:27 AM, Ed Smith-Rowland wrote: The title says it all. This was just an oversight in the original patch. This could wait until stage 1 obviously. I just wanted to post it. There

Re: Patch for constexpr variable templates

2014-07-25 Thread Ed Smith-Rowland
How difficult would it be to make partial specializations work: // Write n*pi once for every possible type template constexpr Tp npi = N * Tp(3.1415926535897932385L); // Partial specialization for int type. template constexpr double npi = N * double(3.1415926535897932385L);

Re: [PATCH, C++, CPP] Add C++1z to the preprocessor. Rename C++1y to C++14.

2014-07-26 Thread Ed Smith-Rowland
On 07/16/2014 12:18 PM, Mike Stump wrote: On Jul 16, 2014, at 7:51 AM, Ed Smith-Rowland <3dw...@verizon.net> wrote: Deprecate c++1y. Chane language to reflect greater confidence in C++14 Chane -> Change. I looked at your patch, all seems fine. I like the documentation edit

Re: Patch for constexpr variable templates

2014-07-26 Thread Ed Smith-Rowland
On 07/26/2014 03:04 AM, Braden Obrzut wrote: Ed, I looked into partial specializations and it looks like, while not trivial, it would be easy enough for me to do them. However, it is not required for concepts (which can not be specialized), so should I fix them for this patch or as a separate

Re: [PATCH, C++, CPP] Add C++1z to the preprocessor. Rename C++1y to C++14.

2014-07-26 Thread Ed Smith-Rowland
On 07/16/2014 12:18 PM, Mike Stump wrote: On Jul 16, 2014, at 7:51 AM, Ed Smith-Rowland <3dw...@verizon.net> wrote: Deprecate c++1y. Chane language to reflect greater confidence in C++14 Chane -> Change. I looked at your patch, all seems fine. I like the documentation edit

[PATCH ] PR libstdc++/60037 - SIGFPE in std::generate_canonical

2014-07-29 Thread Ed Smith-Rowland
_Adaptor. Someday, it might be beneficial to discuss an _IntegralAdaptor and a corresponding __generate_canonical for use in our discreet distributions but I want to close this bug with this patch. Built and tested on x86_64-linux. OK? 2014-07-29 Ed Smith-Rowland <3dw...@verizon.

Re: [PATCH ] PR libstdc++/60037 - SIGFPE in std::generate_canonical

2014-07-29 Thread Ed Smith-Rowland
On 07/29/2014 04:29 AM, Jonathan Wakely wrote: On 29/07/14 04:11 -0400, Ed Smith-Rowland wrote: As discussed in the audit trail both _Adaptor and generate_canonical are both meant to use floating point values. Both are here given static_asserts to that effect. This would have prevented this

[libstdc++,docs] libstdc++ status doc updates for filesystem and fundamentals TSen.

2014-03-05 Thread Ed Smith-Rowland
On 03/05/2014 01:52 PM, Jonathan Wakely wrote: On 5 March 2014 18:16, Ed Smith-Rowland wrote: After the latest batch of papers came out I updated the status docs. OK? OK (CCing gcc-patches with the attachments again). Thanks. After the latest batch of papers came out I updated the status

PATCH to add -std=c++14

2014-03-11 Thread Ed Smith-Rowland
Why not also -std=gnu++14?

Try to catch up _GLIBCXX_RESOLVE_LIB_DEFECTS comments and documentation.

2014-03-15 Thread Ed Smith-Rowland
were more commentary. Then I added the new _GLIBCXX_RESOLVE_LIB_DEFECTS to the xml intro page. OK? Can anyone think of one I left out? Ed 2014-03-15 Ed Smith-Rowland <3dw...@verizon.net> * include/bits/allocator.h: Add CL_GLIBCXX_RESOLVE_LIB_DEFECTS. * include/bits/basic

Re: Try to catch up _GLIBCXX_RESOLVE_LIB_DEFECTS comments and documentation.

2014-03-16 Thread Ed Smith-Rowland
On 03/16/2014 08:43 AM, Jonathan Wakely wrote: On 15 March 2014 14:46, Ed Smith-Rowland wrote: I'm resending this because I forgot to dupe to gcc-patches and I'd like one thread. This should be pure commentary and documentation. I hope I got all these. I grepped for DR

Re: Make string_view operations involving CharT* *not* noexcept and consistent beween string_view and string_view.tcc.

2014-04-16 Thread Ed Smith-Rowland
On 04/15/2014 03:06 PM, Jonathan Wakely wrote: On 29/03/14 14:54 -0400, Ed Smith-Rowland wrote: All, In string_view I botched the noexcept specification of operations like find and friends with CharT* arguments. I'm a little surprised the inconsistency between string_vie

Re: [PATCH, PR56193] - Wrong test operator for basic_ios in C++11

2013-02-07 Thread Ed Smith-Rowland
On 02/07/2013 04:18 AM, Jonathan Wakely wrote: On 7 February 2013 03:05, Ed Smith-Rowland wrote: greetings, On SO someone noticed that g++ still has in the basic_ios class operator void*(); instead of explicit operator bool() const; The old C++98 operator allows things like std::cout

Re: [PATCH, PR] Crash of Bessel functions at x==0!

2013-02-08 Thread Ed Smith-Rowland
On 02/08/2013 08:18 AM, Paolo Carlini wrote: On 02/08/2013 05:09 AM, Ed Smith-Rowland wrote: Here is a reworked patch... The asyptotic stuff is removed for now. Builds and tests cleanon x86_64-unknown-linux. Please add a: bool test __attribute__((unused)) = true; at the beginning of

Re: [PATCH][C++11][ PR55582] Let string literals starting with lower-case 's' be a user-defined literal instead of string + macro.

2013-02-13 Thread Ed Smith-Rowland
literal and identifier"); } /* Grab user defined literal suffix. */ - else if (*cur == '_') + else if (ISIDST (*cur)) { type = cpp_userdef_char_add_type (type); type = cpp_userdef_string_add_type (type); gcc/libcpp/ 2013-02-13 Ed

Re: [v3] tr2: bool_set, dynamic_bitset, ratio

2011-10-19 Thread Ed Smith-Rowland
On 10/19/2011 06:48 PM, Benjamin Kosnik wrote: Hi Edward! I have reviewed and selectively merged your development branch, libstdcxx-tr2-ideas-branch, into trunk. As ISO C++ is now looking at new library efforts for TR2 (and N2965 has already been checked in to trunk) I thought it well-timed. Pl

Re: [C++-11] User defined literals

2011-10-23 Thread Ed Smith-Rowland
On 10/21/2011 05:20 PM, Jason Merrill wrote: I think we're down to minor cosmetic issues: On 10/21/2011 03:55 PM, Tom Tromey wrote: There are a few spots like this that are missing a space before an open paren. + if (DECL_LANGUAGE(decl) == lang_c) Another one. - if (warn_cx

Re: [C++-11] User defined literals

2011-10-27 Thread Ed Smith-Rowland
On 10/26/2011 03:38 PM, Jason Merrill wrote: On 10/26/2011 02:00 AM, Ed Smith-Rowland wrote: The patch was bootstrapped and regtested on x86_64-linux-gnu. Really? I ran into a warning about the unused "suffix" parameter to interpret_integer. So I've fixed that error. I also

Re: [C++-11] User defined literals

2011-10-27 Thread Ed Smith-Rowland
On 10/26/2011 03:38 PM, Jason Merrill wrote: On 10/26/2011 02:00 AM, Ed Smith-Rowland wrote: The patch was bootstrapped and regtested on x86_64-linux-gnu. Really? I ran into a warning about the unused "suffix" parameter to interpret_integer. So I've fixed that error. I also ad

Re: [C++-11] User defined literals

2011-10-30 Thread Ed Smith-Rowland
On 10/27/2011 03:47 PM, Jason Merrill wrote: On 10/27/2011 03:32 PM, Ed Smith-Rowland wrote: + if (TREE_CODE (TREE_TYPE (decl)) != LANG_TYPE) +argtypes = TYPE_ARG_TYPES (TREE_TYPE (decl)); If you have multiple overloaded operator"" _foo, you need to iterate over them looking f

[C++11 Patch] PR 50941

2011-11-03 Thread Ed Smith-Rowland
)); value = USERDEF_LITERAL_VALUE (literal); - len = TREE_STRING_LENGTH (value) - 1; - + len = TREE_STRING_LENGTH (value) + / TREE_INT_CST_LOW (TYPE_SIZE_UNIT ( TREE_TYPE(TREE_TYPE (value - 1; /* Build up a call to the user-defined operator */ /* Lookup the name we got back from

Re: [C++11 Patch] PR 50941

2011-11-03 Thread Ed Smith-Rowland
On 11/03/2011 08:50 AM, Paolo Carlini wrote: On 11/03/2011 12:56 PM, Ed Smith-Rowland wrote: + len = TREE_STRING_LENGTH (value) +/ TREE_INT_CST_LOW (TYPE_SIZE_UNIT ( TREE_TYPE(TREE_TYPE (value - 1; ... with open brackets in random positions ;) Paolo. Arrrgh! ;-) Here's

[C++ PATCH] PR 50958 and correct lookup of literal operators

2011-11-06 Thread Ed Smith-Rowland
nd string literal operator %qD with %qT, %qT" + " arguments", name, TREE_TYPE (value), size_type_node); + else + error ("unable to find valid string literal operator %qD." + " Possible missing length argument in string literal ope

Fwd: [C++ PATCH] PR 50958 and correct lookup of literal operators

2011-11-08 Thread Ed Smith-Rowland
| decl == error_mark_node) { - error ("unable to find user-defined string literal operator %qD", name); - release_tree_vector (vec); + if (have_size) + error ("unable to find string literal operator %qD with %qT, %qT" + " arguments&q

Re: random numbers in bulk

2012-08-25 Thread Ed Smith-Rowland
On 08/25/2012 07:39 PM, Ulrich Drepper wrote: On Sat, Aug 25, 2012 at 7:37 PM, Jonathan Wakely wrote: But iterators don't have to imply non-sequential storage. Using iterators instead of pointers would allow you to store them in a std::deque, for example, or in a std::vector using std::back_ins

Add Rice distribution to libstdc++

2012-09-16 Thread Ed Smith-Rowland
This adds the Rice distribution to the C++11 facility and a Gnu extension. 2012-09-14 Edward Smith-Rowland <3dw...@verizon.net> * include/ext/random: Add __gnu_cxx::rice_distribution<> class. * include/ext/random.tcc: Add out-of-line functions for __gnu_cxx::rice_dist

Re: Add Rice distribution to libstdc++

2012-09-16 Thread Ed Smith-Rowland
On 09/16/2012 06:29 PM, Paolo Carlini wrote: On 09/16/2012 11:18 PM, Paolo Carlini wrote: On 09/16/2012 10:02 PM, Marc Glisse wrote: On Sun, 16 Sep 2012, Ed Smith-Rowland wrote: This adds the Rice distribution to the C++11 facility and a Gnu extension. Hello, libstdc++ not in copy? The

Fix small paste-o in rice_distribution.

2012-09-16 Thread Ed Smith-Rowland
I initialized an adapted urng that was not needed or used in the rice_distribution extension. 2012-09-16 Edward Smith-Rowland <3dw...@verizon.net> * include/ext/random.tcc (__gnu_cxx::rice_distribution<> ::__generate_impl): Remove bogus _Adaptor usage. Index: include/ext/rand

Re: Implement Nakagami distribution as an extension.

2012-09-18 Thread Ed Smith-Rowland
On 09/18/2012 10:28 AM, Paolo Carlini wrote: On 09/18/2012 03:23 AM, Ed Smith-Rowland wrote: Here is another tweak for the Nakagami distribution. operator() is a one liner without a local variable. The template friend is fixed and the relevant test has been added. Changed dates. If this

Re: Implement Pareto distribution as an extension.

2012-09-21 Thread Ed Smith-Rowland
On 09/21/2012 05:33 AM, Paolo Carlini wrote: On 09/21/2012 11:02 AM, Ulrich Drepper wrote: On Thu, Sep 20, 2012 at 6:17 AM, Paolo Carlini wrote: Patch looks generally Ok to me. If Ulrich and the other interested parties don't have anything to add over the next 24 hrs or so, let's go ahead and

Re: Add noexcept and constexpr to tr2/dynamic_bitset.

2012-06-25 Thread Ed Smith-Rowland
On 06/24/2012 07:18 AM, Jonathan Wakely wrote: On 24 June 2012 12:18, Jonathan Wakely wrote: On 24 June 2012 05:00, Ed Smith-Rowland wrote: Subject says it. This looks good, please CC gcc-patches with a changelog entry and confirmation it was tested and it can go in. Thanks. And don&#

Re: constexpr for tr2/bool_set.

2012-06-25 Thread Ed Smith-Rowland
On 06/24/2012 07:19 AM, Jonathan Wakely wrote: This looks good too, again please CC gcc-patches with a changelog entry and confirmation it was tested and it can go in. Thanks. Built and tested on x86_64-linux-gnu. 2012-06-25 Edward Smith-Rowland <3dw...@verizon.net> * include/tr2/b

Re: [C++-11] User defined literals

2011-10-09 Thread Ed Smith-Rowland
On 10/08/2011 07:15 PM, Jason Merrill wrote: On 10/08/2011 07:25 PM, Ed Smith-Rowland wrote: Also, In spite of the documentation cp_parser_template_parameter_list returns a TREE_VEC not a TREE_LIST. This happens inside end_template_parm_list called inside the former. So parameter_list is a

Re: [C++-11] User defined literals

2011-10-11 Thread Ed Smith-Rowland
On 10/11/2011 12:57 PM, Jason Merrill wrote: On 10/11/2011 12:55 PM, Jason Merrill wrote: On 10/09/2011 07:19 PM, Ed Smith-Rowland wrote: Does cp_parser_identifier (parser) *not* consume the identifier token? I'm pretty sure it does. It does. Does it work to only compla

[C++11] Streamline user-defined literal error messages and some code reformatting.

2011-11-15 Thread Ed Smith-Rowland
I just wanted to do a little clean up on the user-defined literal code. Index: gcc/testsuite/g++.dg/cpp0x/udlit-raw-op-string-neg.C === --- gcc/testsuite/g++.dg/cpp0x/udlit-raw-op-string-neg.C(revision 181376) +++ gcc/testsu

[C++11] Ping on PR50958

2011-11-20 Thread Ed Smith-Rowland
Ping. There's a patch that should do the literal operator resolution correctly and resolve PR50958: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50958 Thanks, Ed

[C++ PATCH] ICE with invalid user-defined literals (PR c++/51420)

2011-12-06 Thread Ed Smith-Rowland
gcc/testsuite: 2011-12-06 Ed Smith-Rowland <3dw...@verizon.net> PR c++/51420 * g++.dg/cpp0x/pr51420.C: New. gcc/cp: 2011-12-06 Ed Smith-Rowland <3dw...@verizon.net> PR c++/51420 * parser.c (lookup_literal_operator): Check that current overload is function_type.

[C++ PATCH] ICE with invalid user-defined literals (PR c++/51420)

2011-12-06 Thread Ed Smith-Rowland
This time with patch. gcc/testsuite: 2011-12-06 Ed Smith-Rowland <3dw...@verizon.net> PR c++/51420 * g++.dg/cpp0x/pr51420.C: New. gcc/cp: 2011-12-06 Ed Smith-Rowland <3dw...@verizon.net> PR c++/51420 * parser.c (lookup_literal_operator): Check that current ove

Re: [C++ PATCH] ICE with invalid user-defined literals (PR c++/51420)

2011-12-06 Thread Ed Smith-Rowland
On 12/06/2011 02:27 PM, Jason Merrill wrote: On 12/06/2011 08:21 AM, Ed Smith-Rowland wrote: * parser.c (lookup_literal_operator): Check that current overload is function_type. Instead of checking here, let's check is_overloaded_fn (decl) right after the lookup name. Jason OK,

Re: We left out the check for param_type in random distributions

2012-02-22 Thread Ed Smith-Rowland
Hi, Built and tested on x86_64-linux-gnu. Seems safe enough to go in now, Ok. Thanks, Paolo. 2012-02-14 Edward Smith-Rowland <3dw...@verizon.net> * testsuite/26_numerics/random/ uniform_real_distribution/requirements/typedefs.cc: Check param_type. * testsuite/

Re: [C++-0x] User defined literals.

2011-07-17 Thread Ed Smith-Rowland
On 07/12/2011 04:56 PM, Jason Merrill wrote: A few more notes: + if (DECL_NAMESPACE_SCOPE_P (decl)) + { + if (!check_literal_operator_args(decl, + &long_long_unsigned_p, &long_double_p)) + { + error ("%qD has illegal argument list", decl); +

Re: [v3] add

2011-07-20 Thread Ed Smith-Rowland
All, Here is a trivial addition to include scoped_allocator in the precompiled headers. It bootstrapped and regtested on x86_64 linux. Ed 2011-07-20 Ed Smith-Rowland <3dw...@verizon.net> * include/precompiled/stdc++.h: Add scoped_allocator. Index: include/precompiled/st

Re: [C++-0x] User defined literals.

2011-07-20 Thread Ed Smith-Rowland
On 07/12/2011 04:56 PM, Jason Merrill wrote: A few more notes: + if (DECL_NAMESPACE_SCOPE_P (decl)) + { + if (!check_literal_operator_args(decl, + &long_long_unsigned_p, &long_double_p)) + { + error ("%qD has illegal argument list", decl); +

Re: [[C++ PATCH]] Implement C++2a P0330R2 - Literal Suffixes for ptrdiff_t and size_t

2021-01-27 Thread Ed Smith-Rowland via Gcc-patches
On 1/27/21 3:32 PM, Jakub Jelinek wrote: On Sun, Oct 21, 2018 at 04:39:30PM -0400, Ed Smith-Rowland wrote: This patch implements C++2a proposal P0330R2 Literal Suffixes for ptrdiff_t and size_t*.  It's not official yet but looks very likely to pass.  It is incomplete because I'm l

Re: [[C++ PATCH]] Implement C++2a P0330R2 - Literal Suffixes for ptrdiff_t and size_t

2021-01-30 Thread Ed Smith-Rowland via Gcc-patches
On 1/27/21 3:32 PM, Jakub Jelinek wrote: On Sun, Oct 21, 2018 at 04:39:30PM -0400, Ed Smith-Rowland wrote: This patch implements C++2a proposal P0330R2 Literal Suffixes for ptrdiff_t and size_t*.  It's not official yet but looks very likely to pass.  It is incomplete because I'm l

Re: [[C++ PATCH]] Implement C++2a P0330R2 - Literal Suffixes for ptrdiff_t and size_t

2021-02-01 Thread Ed Smith-Rowland via Gcc-patches
On 2/1/21 10:33 AM, Jason Merrill wrote: On 1/30/21 6:22 PM, Ed Smith-Rowland wrote: On 1/27/21 3:32 PM, Jakub Jelinek wrote: On Sun, Oct 21, 2018 at 04:39:30PM -0400, Ed Smith-Rowland wrote: This patch implements C++2a proposal P0330R2 Literal Suffixes for ptrdiff_t and size_t*.  It'

Re: [[C++ PATCH]] Implement C++2a P0330R2 - Literal Suffixes for ptrdiff_t and size_t

2021-02-01 Thread Ed Smith-Rowland via Gcc-patches
On 2/1/21 2:23 PM, Jakub Jelinek wrote: On Mon, Feb 01, 2021 at 01:46:13PM -0500, Ed Smith-Rowland wrote: @@ -0,0 +1,8 @@ +// { dg-do compile { target c++23 } } + +#include +#include + +static_assert(std::is_same_v); +static_assert(std::is_same_v); Shouldn't this be std::make_signed:

Re: [[C++ PATCH]] Implement C++2a P0330R2 - Literal Suffixes for ptrdiff_t and size_t

2021-02-01 Thread Ed Smith-Rowland via Gcc-patches
On 2/2/21 12:12 AM, Jason Merrill wrote: On 2/1/21 9:15 PM, Ed Smith-Rowland wrote: On 2/1/21 2:23 PM, Jakub Jelinek wrote: On Mon, Feb 01, 2021 at 01:46:13PM -0500, Ed Smith-Rowland wrote: @@ -0,0 +1,8 @@ +// { dg-do compile { target c++23 } } + +#include +#include + +static_assert(std

[wwwdocs] Mention C++23 flags and addition of size_t literals.

2021-02-03 Thread Ed Smith-Rowland via Gcc-patches
I pushed this patch to update changes to mention the C++23 flags and the size_t literals. Ed commit bfc68f3f88406a07757d111a0f894426a6bc4522 Author: Ed Smith-Rowland <3dw...@verizon.net <mailto:3dw...@verizon.net>> Date: Wed Feb 3 14:23:00 2021 -0500 Mention C++23 flags

Re: [[C++ PATCH]] Implement C++2a P0330R2 - Literal Suffixes for ptrdiff_t and size_t

2021-02-04 Thread Ed Smith-Rowland via Gcc-patches
On 2/4/21 6:31 AM, Tam S. B. wrote: `__cpp_size_t_suffix` is defined as 202006L, but the draft standard says 202011L: http://eel.is/c++draft/cpp.predefined#tab:cpp.predefined.ft-row-48 I looks like you're right. Both the latest draft and https://isocpp.org/std/standing-documents/sd-6-sg10-fea

[RFC, libstdc++] Implement C++20 P1208R6 - source_location.

2019-11-08 Thread Ed Smith-Rowland via gcc-patches
"works" and it might make useful fodder for the next round. Ed gcc/ChangeLog 2019-11-08 Ed Smith-Rowland <3dw...@verizon.net> Implement C++20 P1208R6 - source_location. Implement column with a __builtin_COLUMN for both std and experimental. The std curr

Re: [RFC] Remove include/precompiled/expc++.h

2020-10-16 Thread Ed Smith-Rowland via Gcc-patches
On 10/15/20 7:21 PM, Jonathan Wakely wrote: Ed, In commit r232377 (aka 2be75957b80b640c0aac4356ab861edd0c2f1b9d in the git repo) you added a new header to the include/precompiled directory. That wasn't mentioned in the ChangeLog, wasn't in the patch posted to https://gcc.gnu.org/legacy-ml/libstd

[PATCH, libstdc++] More

2019-11-15 Thread Ed Smith-Rowland via gcc-patches
First of all, the redo of the iterator portion in response to https://gcc.gnu.org/ml/gcc-patches/2019-11/msg01467.html passed testing. This patch contains constexpr char_traits. I also found an old extension that had been left out of the constexpr bandwagon that I caught up. This patch also

Fwd: [PATCH,libstdc++] C++ constexpr tuple is broken.

2019-11-16 Thread Ed Smith-Rowland via gcc-patches
I missed a file in my recent patch for C++20 constexpr tuple. Bestrafe Mich. Ed 2019-11-16 Edward Smith-Rowland <3dw...@verizon.net> Repair the part of C++20 p1032 Misc constexpr bits. * include/bits/uses_allocator.h (__uses_alloc0::_Sink::operaror=) (__use_alloc(const _Alloc&)) : Conste

[PATCH,libstdc++] C++-20 costexpr and

2019-05-30 Thread Ed Smith-Rowland via gcc-patches
concerns with the last patch attempts [https://gcc.gnu.org/ml/libstdc++/2019-03/msg00132.html]. The patch is large because of test cases but really just boils down to adding constexpr for c++2a. The patch passes for gnu++2a and pre-gnu++2a on x86_64-linux. OK for trunk? Ed Smith-Rowland 2019

Re: [PATCH,libstdc++] C++-20 costexpr and

2019-05-30 Thread Ed Smith-Rowland via gcc-patches
On 5/30/19 5:05 PM, Ed Smith-Rowland via libstdc++ wrote: Greetings, I was not quite able to finish this in for gcc9 but here is the patch for: ?? Implement C++20 p0202 - Add Constexpr Modifiers to Functions ??in and Headers. ??Implement C++20 p1023 - constexpr comparison

Test for C++20 p0858 - ConstexprIterator requirements.

2019-05-31 Thread Ed Smith-Rowland via gcc-patches
Greetings, Iterators for and are usabe in a constexpr context since C++2017. This just adds a compile test to make sure and check a box for C++20 p0858 - ConstexprIterator requirements. Ed 2019-06-03 Edward Smith-Rowland <3dw...@verizon.net> Test for C++20 p0858 - ConstexprIt

<    1   2   3   4   >