Re: Make the 2 versions of delete more similar

2013-10-02 Thread Christopher Jefferson
On 2 October 2013 13:28, Marc Glisse wrote: > Hello, > > I don't understand why those 2 files differ by more than 1 extra argument, > so I am changing that. > > Bootstrap and testsuite on x86_64. > > 2013-10-03 Marc Glisse > > * libsupc++/del_op.cc (operator delete): Don't test for 0 be

nth_element fix [58800]

2013-10-19 Thread Christopher Jefferson
A previous fix to a performance problem in std::sort unfortunately has lead to a crashing bug in std::nth_element. The following minimal patch fixes the problem (there are a couple of different ways of fixing it, this is the shortest and safest). 2013-09-19 Chris Jefferson PR libstdc++/58800 *

libstdc++ Testsuite extension for sort, partial_sort, partial_sort_copy, nth_element

2013-10-19 Thread Christopher Jefferson
The following patch (related to my 58800 patch) adds many more tests for several important functions. While 58800 is my fault, the reason it was not caught earlier is that many functions in libstdc++ have almost no testing. This works toward fixing that. These tests are kept to an acceptable amoun

Re: Rb tree node recycling patch

2014-01-03 Thread Christopher Jefferson
Personally, I consider the testing insufficent, although the testing was already insufficient! Note that this is my opinion, don't assume I talk for all of libstdc++! After I broke std::nth_element in 4.8.2 (woops), I am of the view that the libstdc++ testsuite is defficient -- many code paths are

Fwd: vector lightweight debug mode

2015-09-17 Thread Christopher Jefferson
-- Forwarded message -- From: Christopher Jefferson Date: 17 September 2015 at 18:59 Subject: Re: vector lightweight debug mode To: Jonathan Wakely On 16 September 2015 at 21:29, Jonathan Wakely wrote: > On 16/09/15 21:37 +0200, François Dumont wrote: > >>>>

Re: Remove unordered containers iterators default initialization

2013-11-25 Thread Christopher Jefferson
On 25 November 2013 21:02, François Dumont wrote: > > Hi > > Following N3644 discussion thread here is a patch proposal to remove > default zero-initialization of unordered containers iterator. I also took the > time to remove default zero-init of nodes _M_nxt pointer. > > 2013-11-25 Franço

Re: Enhance std::hash for pointers

2015-05-08 Thread Christopher Jefferson
My concern with accepting this patch is that many of libstdc++'s hash functions are awful from a mixing point of view -- you would get exactly the same problem from users who have integers which are always a multiple of a power of 2 (which is in practice not uncommon). This would give exactly the s

Re: [patch] New std::string implementation

2014-11-14 Thread Christopher Jefferson
Some (very small) questions / cleanups 1) Do you plan on supporting CXX11 ABI on C++03? There is some #if __cplusplus < 201103L inside the new basic_string. 2) Is there a need for the #if 0 _M_mutate? I tried bootstrapping on Mac OS X 10.10, and got lots of linking issues, the relevant part is:

Re: [Bug libstdc++/61107] stl_algo.h: std::__inplace_stable_partition() doesn't process the whole data range

2014-11-12 Thread Christopher Jefferson
it, but I think the algorithms need something beyond just one or two hardwired inputs. Chris On 10 November 2014 22:20, Jonathan Wakely wrote: > On 10/11/14 23:14 +0100, François Dumont wrote: >> >>I introduced the random tests after Christopher Jefferson request to >>

Re: [patch][google/integration] Add lightweight checks to vector::begin et. al. (issue4973065)

2011-09-06 Thread Christopher Jefferson
On 6 Sep 2011, at 21:19, Paul Pluzhnikov wrote: > On Tue, Sep 6, 2011 at 12:44 PM, Jonathan Wakely > wrote: >> On 6 September 2011 20:23, Jonathan Wakely wrote: >>> >>> What's a dangling vector anyway? One that has been moved from? >> >> Apparently not, since a moved-from vector would pass _

Re: [v3] constexpr tuple

2011-09-08 Thread Christopher Jefferson
On 8 Sep 2011, at 18:34, Paolo Carlini wrote: > On 09/07/2011 07:44 AM, Daniel Krügler wrote: >> Is tuple_cat now considered conforming? >> No, see: >> >> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=50159 > By the way, Daniel, I was considering giving that issue a try, if you have > tips (or ev

Re: RFA (libstdc++): C++/v3 PATCH for c++/24163 (lookup in dependent bases) and c++/29131

2011-05-20 Thread Christopher Jefferson
On 20 May 2011, at 20:30, Joe Buck wrote: > On Fri, May 20, 2011 at 09:32:16AM -0700, Jason Merrill wrote: >> G++ has had a long-standing bug with unqualified name resolution in >> templates: if we didn't find any declaration when looking up a name in >> the template definition, we would do an