Re: [committed] Add OpenMP 5 exclusive scan support for simd constructs

2019-06-24 Thread Christophe Lyon
On Fri, 21 Jun 2019 at 08:57, Jakub Jelinek wrote: > > Hi! > > The following patch adds exclusive scan support for simd, it is similar to > the inclusive scan, just we need to swap the input and scan phases and > use slightly different pattern at the start of the scan phase, so that it > computes

Re: [committed] C++ PATCH to add test for c++/83856

2018-12-03 Thread Christophe Lyon
On Sat, 1 Dec 2018 at 23:01, Marek Polacek wrote: > > Tested x86_64-linux, applying to trunk. > > 2018-12-01 Marek Polacek > > PR c++/83856 > * g++.dg/cpp1y/lambda-generic-83856.C: New test. > > diff --git gcc/testsuite/g++.dg/cpp1y/lambda-generic-83856.C > gcc/testsuite/g++.dg

Re: [ARM/FDPIC v4 00/20] FDPIC ABI for ARM

2018-12-03 Thread Christophe Lyon
Ping? The series started here: https://gcc.gnu.org/ml/gcc-patches/2018-11/msg01464.html Thanks, Christophe On Mon, 26 Nov 2018 at 11:14, Christophe Lyon wrote: > > Ping? > > Thanks > > On Fri, 16 Nov 2018 at 16:48, Christophe Lyon wrote: > > > > From:

Re: [PATCH] Fix PR64242

2018-12-03 Thread Christophe Lyon
On Mon, 3 Dec 2018 at 14:35, Richard Biener wrote: > > On Sat, Dec 1, 2018 at 12:07 AM Jeff Law wrote: > > > > On 11/29/18 12:26 PM, Wilco Dijkstra wrote: > > > Fix PR64242 - the middle end expansion for long jmp updates the > > > hard frame pointer before it reads the new stack pointer. This >

Re: [PATCH] Fix PR64242

2018-12-04 Thread Christophe Lyon
On Mon, 3 Dec 2018 at 17:26, Jakub Jelinek wrote: > > Hi! > > Here is a fix for the testcase, so that it doesn't FAIL pretty much > everywhere. > > On Fri, Nov 30, 2018 at 04:07:31PM -0700, Jeff Law wrote: > > > PR middle-end/64242 > > > * gcc.c-torture/execute/pr64242.c: New test. > > THa

Re: [committed] C++ PATCH to add test for c++/83856

2018-12-04 Thread Christophe Lyon
On Mon, 3 Dec 2018 at 17:05, Marek Polacek wrote: > > On Mon, Dec 03, 2018 at 10:14:11AM +0100, Christophe Lyon wrote: > > This new test fails on arm and other targets according to > > gcc-testresults. On arm, I can see: > > /gcc/testsuite/g++.dg/cpp1y/lambda-generic-8

Re: [PATCH] Fix PR88301

2018-12-04 Thread Christophe Lyon
Hi Richard, On Mon, 3 Dec 2018 at 14:37, Richard Biener wrote: > > > This fixes a missed optimization in EVRP by teaching the code > figuring out conditional asserts about conversions that preserve > the converted value. > > Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk > s

Re: [PATCH] Fix PR88301

2018-12-05 Thread Christophe Lyon
On Tue, 4 Dec 2018 at 14:17, Richard Biener wrote: > > On Tue, 4 Dec 2018, Christophe Lyon wrote: > > > Hi Richard, > > On Mon, 3 Dec 2018 at 14:37, Richard Biener wrote: > > > > > > > > > This fixes a missed optimization in EVRP by teaching the c

Re: [PING #4][PATCH] avoid warning on constant strncpy until next statement is reachable (PR 87028)

2018-12-06 Thread Christophe Lyon
On Thu, 6 Dec 2018 at 00:11, Jeff Law wrote: > > On 11/29/18 4:43 PM, Martin Sebor wrote: > > On 11/29/18 4:07 PM, Jeff Law wrote: > >> On 11/29/18 1:34 PM, Martin Sebor wrote: > >>> On 11/16/2018 02:07 AM, Richard Biener wrote: > On Fri, Nov 16, 2018 at 4:12 AM Martin Sebor wrote: > > >

Re: [ARM/FDPIC v4 00/20] FDPIC ABI for ARM

2018-12-11 Thread Christophe Lyon
Ping? On 03/12/2018 10:19, Christophe Lyon wrote: Ping? The series started here: https://gcc.gnu.org/ml/gcc-patches/2018-11/msg01464.html Thanks, Christophe On Mon, 26 Nov 2018 at 11:14, Christophe Lyon wrote: Ping? Thanks On Fri, 16 Nov 2018 at 16:48, Christophe Lyon wrote: From

Re: [PATCH] [RFC] PR target/52813 and target/11807

2018-12-12 Thread Christophe Lyon
On Tue, 11 Dec 2018 at 16:52, Richard Sandiford wrote: > > Dimitar Dimitrov writes: > > On понеделник, 10 декември 2018 г. 11:21:53 EET Richard Sandiford wrote: > >> Dimitar Dimitrov writes: > >> > I have tested this fix on x86_64 host, and found no regression in the C > >> > and C++ testsuites.

Re: [PATCH] [RFC] PR target/52813 and target/11807

2018-12-12 Thread Christophe Lyon
On Wed, 12 Dec 2018 at 10:42, Christophe Lyon wrote: > > On Tue, 11 Dec 2018 at 16:52, Richard Sandiford > wrote: > > > > Dimitar Dimitrov writes: > > > On понеделник, 10 декември 2018 г. 11:21:53 EET Richard Sandiford wrote: > > >> Dimitar Dimitrov

Re: [PATCH] [RFC] PR target/52813 and target/11807

2018-12-12 Thread Christophe Lyon
moved. Let me > > check the original code that lead to the PR why it's clobbering sp > > though. > > > > Best regards, > > > > Thomas > > On Wed, 12 Dec 2018 at 09:43, Christophe Lyon > > wrote: > > > > > > On Tue, 11 Dec 2018 at 1

Re: [PATCH] [RFC] PR target/52813 and target/11807

2018-12-12 Thread Christophe Lyon
On Wed, 12 Dec 2018 at 14:19, Christophe Lyon wrote: > > On Wed, 12 Dec 2018 at 12:21, Thomas Preudhomme > wrote: > > > > So my understanding is that the original code (CMSIS library) used to > > clobber sp because the asm statement was actually changing the sp. >

Re: [PATCH] PR libstdc++/80762 avoid ambiguous __constructible_from

2018-12-12 Thread Christophe Lyon
On Wed, 12 Dec 2018 at 17:13, Jonathan Wakely wrote: > > Ensure we don't try to instantiate __is_constructible_from, > because there are two partial specializations that are equally good > matches. > > PR libstdc++/80762 > * include/bits/fs_path.h (path::_Path): Use remove_cv_t and

Re: [PATCH] PR libstdc++/80762 avoid ambiguous __constructible_from

2018-12-13 Thread Christophe Lyon
On Thu, 13 Dec 2018 at 12:00, Jonathan Wakely wrote: > > On 13/12/18 08:56 +0100, Christophe Lyon wrote: > >On Wed, 12 Dec 2018 at 17:13, Jonathan Wakely wrote: > >> > >> Ensure we don't try to instantiate __is_constructible_from, > >> because th

Re: [PATCH] avoid folding snprintf calls with bounds > INT_MAX (PR 87096)

2018-12-17 Thread Christophe Lyon
Hi, On Thu, 13 Dec 2018 at 19:14, Jeff Law wrote: > > On 12/12/18 4:18 PM, Martin Sebor wrote: > > POSIX requires snprintf to fail with EOVERFLOW when the specified > > bound exceeds INT_MAX. This requirement conflicts with the C > > requirements on valid calls to the function and isn't universa

Re: [PATCH] [RFC] PR target/52813 and target/11807

2018-12-17 Thread Christophe Lyon
On Mon, 17 Dec 2018 at 12:47, Richard Sandiford wrote: > > Dimitar Dimitrov writes: > > On Sun, Dec 16 2018 at 14:36:26 EET Bernd Edlinger wrote: > >> Hi, > >> > >> if I understood that right, then clobbering sp is and has always been > >> ignored. > > PR77904 was about the clobber not being igno

Re: [PATCH] [RFC] PR target/52813 and target/11807

2018-12-17 Thread Christophe Lyon
On Mon, 17 Dec 2018 at 14:35, Richard Sandiford wrote: > > Christophe Lyon writes: > > On Mon, 17 Dec 2018 at 12:47, Richard Sandiford > > wrote: > >> > >> Dimitar Dimitrov writes: > >> > On Sun, Dec 16 2018 at 14:36:26 EET Bernd Edlinger wrote:

Re: [C++ Patch] [PR c++/88146] do not crash synthesizing inherited ctor(...)

2018-12-19 Thread Christophe Lyon
On Sat, 15 Dec 2018 at 23:11, Jason Merrill wrote: > > On Fri, Dec 14, 2018 at 6:05 PM Alexandre Oliva wrote: > > > > On Dec 14, 2018, Jason Merrill wrote: > > > > > Let's move the initialization of "fields" inside the 'then' block here > > > with the initialization of "cvquals", rather than cle

Re: [PATCH] LWG 2936: update path::compare logic and optimize string comparisons

2018-12-19 Thread Christophe Lyon
On Tue, 18 Dec 2018 at 16:51, Jonathan Wakely wrote: > > The resolution for LWG 2936 defines the comparison more precisely, which > this patch implements. The patch also defines comparisons with strings > to work without constructing a temporary path object (so avoids any > memory allocations). >

Re: [C++ Patch] [PR c++/88146] do not crash synthesizing inherited ctor(...)

2018-12-20 Thread Christophe Lyon
On Thu, 20 Dec 2018 at 01:04, Alexandre Oliva wrote: > > Christophe, > > Thanks again for the report. This was quite an adventure to figure > out ;-) See below. > Glad I've helped. I wouldn't have been able to do the analysis :) > > [PR88146] avoid diagnostics diffs if cdtor_returns_this > >

Re: [ARM/FDPIC v4 00/20] FDPIC ABI for ARM

2019-01-02 Thread Christophe Lyon
Hi, Ping^4 ? Thanks, Christophe On Tue, 11 Dec 2018 at 11:27, Christophe Lyon wrote: > > Ping? > > > On 03/12/2018 10:19, Christophe Lyon wrote: > > Ping? > > > > The series started here: > > https://gcc.gnu.org/ml/gcc-patches/2018-11/msg01464.

Re: [PATCH 2/2] PR libstdc++/86756 Move rest of std::filesystem to libstdc++.so

2019-01-07 Thread Christophe Lyon
Hi Jonathan On Sun, 6 Jan 2019 at 23:37, Jonathan Wakely wrote: > > Move std::filesystem directory iterators and operations from > libstdc++fs.a to main libstdc++ library. These components have many > dependencies on OS support, which is not available on all targets. Some > additional autoconf ch

Re: [PATCH 2/2] PR libstdc++/86756 Move rest of std::filesystem to libstdc++.so

2019-01-07 Thread Christophe Lyon
On Mon, 7 Jan 2019 at 13:39, Jonathan Wakely wrote: > > On 07/01/19 09:48 +, Jonathan Wakely wrote: > >On 07/01/19 10:24 +0100, Christophe Lyon wrote: > >>Hi Jonathan > >> > >>On Sun, 6 Jan 2019 at 23:37, Jonathan Wakely wrote: > >>>

[PATCH] PR target/85596 Add --with-multilib-list doc for aarch64

2019-01-07 Thread Christophe Lyon
Hi, This small patch adds a short description of --with-multilib-list for aarch64. OK? Thanks, Christophe 2019-01-07 Christophe Lyon PR target/85596 * doc/install.texi (with-multilib-list): Document for aarch64. diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi index

Re: [PATCH] Define new filesystem::__file_clock type

2019-01-07 Thread Christophe Lyon
On Sun, 6 Jan 2019 at 22:45, Jonathan Wakely wrote: > > On 05/01/19 20:03 +, Jonathan Wakely wrote: > >In C++17 the clock used for filesystem::file_time_type is unspecified, > >allowing it to be chrono::system_clock. The C++2a draft requires it to > >be a distinct type, with additional member

Re: [PATCH 2/2] PR libstdc++/86756 Move rest of std::filesystem to libstdc++.so

2019-01-08 Thread Christophe Lyon
On Mon, 7 Jan 2019 at 15:14, Christophe Lyon wrote: > > On Mon, 7 Jan 2019 at 13:39, Jonathan Wakely wrote: > > > > On 07/01/19 09:48 +, Jonathan Wakely wrote: > > >On 07/01/19 10:24 +0100, Christophe Lyon wrote: > > >>Hi Jonathan > > >>

Re: [C++ Patch] Fix four more locations

2019-01-08 Thread Christophe Lyon
On Mon, 7 Jan 2019 at 18:08, Paolo Carlini wrote: > > Hi, > > should be straightforward material. Tested x86_64-linux, as usual. > > Thanks, Paolo. > > / > Hi, The new g++.dg/diagnostic/thread1.C passes on aarch64, but fails on arm: FAIL: g++.dg/diagnostic/thread1.C -std=c++

Re: [PATCH][ARM] Switch to default sched pressure algorithm

2019-07-30 Thread Christophe Lyon
On Mon, 29 Jul 2019 at 18:49, Wilco Dijkstra wrote: > > Currently the Arm backend selects the alternative sched pressure algorithm. > The issue is that this doesn't take register pressure into account, and so > it causes significant additional spilling on Arm where there are only 14 > allocatable

Re: [PATCH] Add generic support for "noinit" attribute

2019-07-30 Thread Christophe Lyon
Hi, Thanks for the useful feedback. On Tue, 16 Jul 2019 at 11:54, Richard Sandiford wrote: > > Thanks for doing this in a generic way. > > Christophe Lyon writes: > > @@ -2224,6 +2234,50 @@ handle_weak_attribute (tree *node, tree name, > >return NULL_TREE; >

Re: [ARM/FDPIC v5 09/21] [ARM] FDPIC: Add support for taking address of nested function

2019-07-31 Thread Christophe Lyon
On Tue, 16 Jul 2019 at 14:42, Kyrill Tkachov wrote: > > > On 7/16/19 12:18 PM, Kyrill Tkachov wrote: > > Hi Christophe > > > > On 5/15/19 1:39 PM, Christophe Lyon wrote: > > > In FDPIC mode, the trampoline generated to support pointers

Re: [ARM/FDPIC v5 03/21] [ARM] FDPIC: Force FDPIC related options unless -mno-fdpic is provided

2019-08-01 Thread Christophe Lyon
On Tue, 16 Jul 2019 at 12:34, Richard Sandiford wrote: > > Christophe Lyon writes: > > On 22/05/2019 10:45, Christophe Lyon wrote: > >> On Wed, 22 May 2019 at 10:39, Szabolcs Nagy wrote: > >>> > >>> On 21/05/2019 16:28, Christophe Lyon wr

Re: [PATCH] Add generic support for "noinit" attribute

2019-08-13 Thread Christophe Lyon
Ping? On Tue, 30 Jul 2019 at 15:35, Christophe Lyon wrote: > > Hi, > > Thanks for the useful feedback. > > > On Tue, 16 Jul 2019 at 11:54, Richard Sandiford > wrote: > > > > Thanks for doing this in a generic way. > > > > Ch

Re: [PATCH] Add generic support for "noinit" attribute

2019-08-14 Thread Christophe Lyon
On Wed, 14 Aug 2019 at 14:14, Richard Sandiford wrote: > > Sorry for the slow response, I'd missed that there was an updated patch... > > Christophe Lyon writes: > > 2019-07-04 Christophe Lyon > > > > * lib/target-supports.exp (check_effective

Re: [PATCH] Add generic support for "noinit" attribute

2019-08-14 Thread Christophe Lyon
-target noinit */ (missing closing brace) Could it explain why it's failing on x86_64 ? > Thanks, > Tamar > > -Original Message- > From: gcc-patches-ow...@gcc.gnu.org On Behalf > Of Christophe Lyon > Sent: Wednesday, August 14, 2019 2:18 PM > To: Christophe

Re: [PATCH] Add generic support for "noinit" attribute

2019-08-14 Thread Christophe Lyon
On Wed, 14 Aug 2019 at 19:07, Christophe Lyon wrote: > > On Wed, 14 Aug 2019 at 17:59, Tamar Christina wrote: > > > > Hi Christoph, > > > > The noinit testcase is currently failing on x86_64. > > > > Is the test supposed to be running there? > &

Re: [ARM/FDPIC v5 04/21] [ARM] FDPIC: Add support for FDPIC for arm architecture

2019-08-20 Thread Christophe Lyon
On 16/07/2019 13:58, Richard Sandiford wrote: Christophe Lyon writes: The FDPIC register is hard-coded to r9, as defined in the ABI. We have to disable tailcall optimizations if we don't know if the target function is in the same module. If not, we have to set r9 to the value associated

[COMMITTED] [testsuite][arm] Add missing quotes to expected warning messages.

2019-08-21 Thread Christophe Lyon
Hi, The arm/cmse/cmse-9.c test was missing quotes in the expected warning messages. Fix as obvious with r274793. Christophe 2019-08-21 Christophe Lyon * gcc.target/arm/cmse/cmse-9.c: Add quotes to expected warning messages. Index: gcc/testsuite/gcc.target/arm/cmse/cmse-9.c

Re: [PATCH][ARM] Cleanup logical DImode operations

2019-08-26 Thread Christophe Lyon
On Thu, 22 Aug 2019 at 14:03, Kyrill Tkachov wrote: > > Hi Wilco, > > On 7/19/19 12:30 PM, Wilco Dijkstra wrote: > > > > Cleanup the logical DImode operations since the current implementation > > is way > > too complicated. Thumb-1, Thumb-2, VFP/Neon and iwMMXt all work > > differently, > > resul

Re: [PATCH] integrate sprintf pass into strlen (PR 83431)

2019-08-27 Thread Christophe Lyon
On Fri, 23 Aug 2019 at 04:14, Jeff Law wrote: > > On 8/12/19 4:09 PM, Martin Sebor wrote: > > > > > gcc-83431.diff > > > > PR tree-optimization/83431 - -Wformat-truncation may incorrectly report > > truncation > > > > gcc/ChangeLog: > > > > PR c++/83431 > > * gimple-ssa-sprintf.c (pas

Re: [PATCH] Sanitizing the middle-end interface to the back-end for strict alignment

2019-08-28 Thread Christophe Lyon
On Wed, 28 Aug 2019 at 11:42, Kyrill Tkachov wrote: > > > On 8/28/19 10:38 AM, Bernd Edlinger wrote: > > On 8/27/19 11:25 AM, Kyrill Tkachov wrote: > >> Hi Bernd, > >> > >> On 8/15/19 8:47 PM, Bernd Edlinger wrote: > >>> Hi, > >>> > >>> this is the split out part from the "Fix not 8-byte aligned l

Re: [PATCH] Sanitizing the middle-end interface to the back-end for strict alignment

2019-08-29 Thread Christophe Lyon
On Thu, 29 Aug 2019 at 10:58, Kyrill Tkachov wrote: > > Hi Bernd, > > On 8/28/19 10:36 PM, Bernd Edlinger wrote: > > On 8/28/19 2:07 PM, Christophe Lyon wrote: > >> Hi, > >> > >> This patch causes an ICE when building libgcc's unwind-arm.o > &

Re: [ARM/FDPIC v5 00/21] FDPIC ABI for ARM

2019-08-29 Thread Christophe Lyon
Hi, On 15/05/2019 14:39, Christophe Lyon wrote: Hello, This patch series implements the GCC contribution of the FDPIC ABI for ARM targets. This ABI enables to run Linux on ARM MMU-less cores and supports shared libraries to reduce the memory footprint. Without MMU, text and data segments

Re: [ARM/FDPIC v5 01/21] [ARM] FDPIC: Add -mfdpic option support

2019-08-29 Thread Christophe Lyon
On 16/07/2019 12:11, Richard Sandiford wrote: [This isn't really something that should be reviewed under global reviewership, but if it's either that or nothing, I'll do it anyway...] Christophe Lyon writes: 2019-XX-XX Christophe Lyon Mickaël Guêné gcc/

Re: [ARM/FDPIC v5 02/21] [ARM] FDPIC: Handle arm*-*-uclinuxfdpiceabi in configure scripts

2019-08-29 Thread Christophe Lyon
On 12/07/2019 08:49, Richard Sandiford wrote: Christophe Lyon writes: The new arm-uclinuxfdpiceabi target behaves pretty much like arm-linux-gnueabi. In order the enable the same set of features, we have to update several configure scripts that generally match targets like *-*-linux*: in most

Re: [ARM/FDPIC v5 03/21] [ARM] FDPIC: Force FDPIC related options unless -mno-fdpic is provided

2019-08-29 Thread Christophe Lyon
On 16/07/2019 12:34, Richard Sandiford wrote: Christophe Lyon writes: On 22/05/2019 10:45, Christophe Lyon wrote: On Wed, 22 May 2019 at 10:39, Szabolcs Nagy wrote: On 21/05/2019 16:28, Christophe Lyon wrote: --- a/gcc/config/arm/linux-eabi.h +++ b/gcc/config/arm/linux-eabi.h @@ -89,7

Re: [ARM/FDPIC v5 04/21] [ARM] FDPIC: Add support for FDPIC for arm architecture

2019-08-29 Thread Christophe Lyon
On 16/07/2019 13:58, Richard Sandiford wrote: Christophe Lyon writes: The FDPIC register is hard-coded to r9, as defined in the ABI. We have to disable tailcall optimizations if we don't know if the target function is in the same module. If not, we have to set r9 to the value associated

Re: [ARM/FDPIC v5 05/21] [ARM] FDPIC: Fix __do_global_dtors_aux and frame_dummy generation

2019-08-29 Thread Christophe Lyon
On 12/07/2019 08:06, Richard Sandiford wrote: Christophe Lyon writes: In FDPIC, we need to make sure __do_global_dtors_aux and frame_dummy are referenced by their address, not by pointers to the function descriptors. 2019-XX-XX Christophe Lyon Mickaël Guêné * libgcc

Re: [ARM/FDPIC v5 09/21] [ARM] FDPIC: Add support for taking address of nested function

2019-08-29 Thread Christophe Lyon
On 31/07/2019 16:44, Christophe Lyon wrote: On Tue, 16 Jul 2019 at 14:42, Kyrill Tkachov wrote: On 7/16/19 12:18 PM, Kyrill Tkachov wrote: Hi Christophe On 5/15/19 1:39 PM, Christophe Lyon wrote: In FDPIC mode, the trampoline generated to support pointers to nested functions looks like

Re: [ARM/FDPIC v5 12/21] [ARM] FDPIC: Restore r9 after we call __aeabi_read_tp

2019-08-29 Thread Christophe Lyon
Here is an updated version that makes use of the helper gen_restore_pic_register_after_call Christophe On 15/05/2019 14:39, Christophe Lyon wrote: We call __aeabi_read_tp() to get the thread pointer. Since this is a function call, we have to restore the FDPIC register afterwards. 2019-XX-XX

Re: [ARM/FDPIC v5 00/21] FDPIC ABI for ARM

2019-08-29 Thread Christophe Lyon
On 29/08/2019 15:57, Christophe Lyon wrote: Hi, On 15/05/2019 14:39, Christophe Lyon wrote: Hello, This patch series implements the GCC contribution of the FDPIC ABI for ARM targets. This ABI enables to run Linux on ARM MMU-less cores and supports shared libraries to reduce the memory

Re: [ARM/FDPIC v5 02/21] [ARM] FDPIC: Handle arm*-*-uclinuxfdpiceabi in configure scripts

2019-08-30 Thread Christophe Lyon
On Fri, 30 Aug 2019 at 11:00, Richard Sandiford wrote: > > Christophe Lyon writes: > > @@ -785,7 +785,7 @@ case ${target} in > >esac > >tmake_file="t-slibgcc" > >case $target in > > -*-*-linux* | frv-*-*linux* | *-*-kfreebsd*-gnu | *-

Re: [PATCH] Sanitizing the middle-end interface to the back-end for strict alignment

2019-08-30 Thread Christophe Lyon
On Thu, 29 Aug 2019 at 23:26, Bernd Edlinger wrote: > > On 8/29/19 11:08 AM, Christophe Lyon wrote: > > On Thu, 29 Aug 2019 at 10:58, Kyrill Tkachov > > wrote: > >> > >> Hi Bernd, > >> > >> On 8/28/19 10:36 PM, Bernd Edlinger wrote: >

Re: [ARM/FDPIC v5 02/21] [ARM] FDPIC: Handle arm*-*-uclinuxfdpiceabi in configure scripts

2019-09-02 Thread Christophe Lyon
On Fri, 30 Aug 2019 at 16:49, Richard Sandiford wrote: > > Christophe Lyon writes: > > On Fri, 30 Aug 2019 at 11:00, Richard Sandiford > > wrote: > >> > >> Christophe Lyon writes: > >> > @@ -785,7 +785,7 @@ case ${target} in > >>

Re: [ARM/FDPIC v5 04/21] [ARM] FDPIC: Add support for FDPIC for arm architecture

2019-09-02 Thread Christophe Lyon
On Mon, 2 Sep 2019 at 18:12, Richard Sandiford wrote: > > Sorry for the slow reply. > > Christophe Lyon writes: > > On 16/07/2019 13:58, Richard Sandiford wrote: > >> Christophe Lyon writes: > >>> +(define_insn "*restore_pic_register_after_call"

Re: [ARM/FDPIC v5 04/21] [ARM] FDPIC: Add support for FDPIC for arm architecture

2019-09-04 Thread Christophe Lyon
On Tue, 3 Sep 2019 at 10:40, Richard Sandiford wrote: > > Christophe Lyon writes: > > @@ -3485,6 +3485,14 @@ arm_option_override (void) > >if (flag_pic && TARGET_VXWORKS_RTP) > > arm_pic_register = 9; > > > > + /* If in FDPIC mode then fo

Re: [ARM/FDPIC v5 10/21] [ARM] FDPIC: Implement TLS support.

2019-09-04 Thread Christophe Lyon
On Wed, 4 Sep 2019 at 16:16, Kyrill Tkachov wrote: > > Hi Christophe, > > On 5/15/19 1:39 PM, Christophe Lyon wrote: > > Support additional relocations: TLS_GD32_FDPIC, TLS_LDM32_FDPIC, and > > TLS_IE32_FDPIC. > > > > We do not support the GNU2 TLS dialect.

Re: [ARM/FDPIC v5 13/21] [ARM] FDPIC: Force LSB bit for PC in Cortex-M architecture

2019-09-05 Thread Christophe Lyon
On Thu, 29 Aug 2019 at 17:32, Kyrill Tkachov wrote: > > Hi Christophe, > > On 5/15/19 1:39 PM, Christophe Lyon wrote: > > Without this, when we are unwinding across a signal frame we can jump > > to an even address which leads to an exception. &

Re: [ARM/FDPIC v5 13/21] [ARM] FDPIC: Force LSB bit for PC in Cortex-M architecture

2019-09-05 Thread Christophe Lyon
Sorry, I forgot again to cc: Ian. Thanks, Christophe On Thu, 5 Sep 2019 at 10:30, Christophe Lyon wrote: > > On Thu, 29 Aug 2019 at 17:32, Kyrill Tkachov > wrote: > > > > Hi Christophe, > > > > On 5/15/19 1:39 PM, Christophe Lyon wrote: > > > Wi

Re: [ARM/FDPIC v5 20/21] [ARM][testsuite] FDPIC: Skip tests using architectures unsupported by FDPIC

2019-09-06 Thread Christophe Lyon
On Fri, 19 Jul 2019 at 11:00, Kyrill Tkachov wrote: > > > On 5/15/19 1:39 PM, Christophe Lyon wrote: > > Since FDPIC currently supports arm and thumb-2 modes only, these tests > > fail because they enforce an architecture version that doesn't match > > these

Re: [ARM/FDPIC v5 20/21] [ARM][testsuite] FDPIC: Skip tests using architectures unsupported by FDPIC

2019-09-06 Thread Christophe Lyon
On Fri, 6 Sep 2019 at 10:28, Kyrill Tkachov wrote: > > > On 9/6/19 9:01 AM, Christophe Lyon wrote: > > On Fri, 19 Jul 2019 at 11:00, Kyrill Tkachov > > wrote: > >> > >> On 5/15/19 1:39 PM, Christophe Lyon wrote: > >>> Since FDPIC current

Re: [ARM/FDPIC v5 20/21] [ARM][testsuite] FDPIC: Skip tests using architectures unsupported by FDPIC

2019-09-06 Thread Christophe Lyon
On Fri, 6 Sep 2019 at 11:09, Christophe Lyon wrote: > > On Fri, 6 Sep 2019 at 10:28, Kyrill Tkachov > wrote: > > > > > > On 9/6/19 9:01 AM, Christophe Lyon wrote: > > > On Fri, 19 Jul 2019 at 11:00, Kyrill Tkachov > > > wrote: > >

Re: [ARM/FDPIC v5 20/21] [ARM][testsuite] FDPIC: Skip tests using architectures unsupported by FDPIC

2019-09-09 Thread Christophe Lyon
On Fri, 6 Sep 2019 at 19:43, Christophe Lyon wrote: > > On Fri, 6 Sep 2019 at 11:09, Christophe Lyon > wrote: > > > > On Fri, 6 Sep 2019 at 10:28, Kyrill Tkachov > > wrote: > > > > > > > > > On 9/6/19 9:01 AM, Christophe Lyon wrote

Re: [ARM/FDPIC v5 10/21] [ARM] FDPIC: Implement TLS support.

2019-09-09 Thread Christophe Lyon
On Wed, 4 Sep 2019 at 22:03, Christophe Lyon wrote: > > On Wed, 4 Sep 2019 at 16:16, Kyrill Tkachov > wrote: > > > > Hi Christophe, > > > > On 5/15/19 1:39 PM, Christophe Lyon wrote: > > > Support additional relocations: TLS_GD32_FDPIC, TLS_LDM32_FDPIC

Re: [ARM/FDPIC v5 13/21] [ARM] FDPIC: Force LSB bit for PC in Cortex-M architecture

2019-09-09 Thread Christophe Lyon
On Thu, 5 Sep 2019 at 11:03, Kyrill Tkachov wrote: > > Hi Christophe, > > On 9/5/19 9:30 AM, Christophe Lyon wrote: > > On Thu, 29 Aug 2019 at 17:32, Kyrill Tkachov > > wrote: > >> Hi Christophe, > >> > >> On 5/15/19 1:39 PM, Christophe Ly

Re: r272976 - in /trunk/gcc/ada: ChangeLog ali.adb ...

2019-09-09 Thread Christophe Lyon
On Thu, 5 Sep 2019 at 11:52, Arnaud Charlet wrote: > > > > Can someone please remind me in which repository I can find the GCC > > > prerequisites doc sources? > > > > Answering my own question: found it under gcc/doc/install.texi > > > > Working on it... > > Just installed the following change on

Re: r272976 - in /trunk/gcc/ada: ChangeLog ali.adb ...

2019-09-09 Thread Christophe Lyon
On Mon, 9 Sep 2019 at 17:18, Arnaud Charlet wrote: > > > > Just installed the following change on trunk, thanks again for your > > > feedback! > > > > > > 2019-09-05 Arnaud Charlet > > > > > > * doc/install.texi: Update and clarify requirements to build GNAT. > > > > > Hi Arnaud, > > >

[ARM/FDPIC v6 00/24] FDPIC ABI for ARM

2019-09-09 Thread Christophe Lyon
3a06 [6] https://cgit.uclibc-ng.org/cgi/cgit/uclibc-ng.git/commit/?id=13c46fbc1e5a021f2b9ed32d83aecc93ae5e655d Christophe Lyon (24): [ARM] FDPIC: Add -mfdpic option support [ARM] FDPIC: Handle arm*-*-uclinuxfdpiceabi in configure scripts [ARM] FDPIC: Force FDPIC related options unless -mno-fdpic is pro

[ARM/FDPIC v6 01/24] [ARM] FDPIC: Add -mfdpic option support

2019-09-09 Thread Christophe Lyon
From: Christophe Lyon 2019-XX-XX Christophe Lyon Mickaël Guêné gcc/ * config/arm/arm.opt: Add -mfdpic option. * doc/invoke.texi: Add documentation for -mfdpic. Change-Id: I05b98d6ae87c2b3fc04dd7fba415c730accdf33e diff --git a/gcc/config/arm/arm.opt b/gcc

[ARM/FDPIC v6 02/24] [ARM] FDPIC: Handle arm*-*-uclinuxfdpiceabi in configure scripts

2019-09-09 Thread Christophe Lyon
From: Christophe Lyon The new arm-uclinuxfdpiceabi target behaves pretty much like arm-linux-gnueabi. In order to enable the same set of features, we have to update several configure scripts that generally match targets like *-*-linux*: in most places, we add *-uclinux* where there is already

[ARM/FDPIC v6 03/24] [ARM] FDPIC: Force FDPIC related options unless -mno-fdpic is provided

2019-09-09 Thread Christophe Lyon
From: Christophe Lyon In FDPIC mode, we set -fPIE unless the user provides -fno-PIE, -fpie, -fPIC or -fpic: indeed FDPIC code is PIC, but we want to generate code for executables rather than shared libraries by default. We also make sure to use the --fdpic assembler option, and select the

[ARM/FDPIC v6 04/24] [ARM] FDPIC: Add support for FDPIC for arm architecture

2019-09-09 Thread Christophe Lyon
From: Christophe Lyon The FDPIC register is hard-coded to r9, as defined in the ABI. We have to disable tailcall optimizations if we don't know if the target function is in the same module. If not, we have to set r9 to the value associated with the target module. When generating a s

[ARM/FDPIC v6 05/24] [ARM] FDPIC: Fix __do_global_dtors_aux and frame_dummy generation

2019-09-09 Thread Christophe Lyon
From: Christophe Lyon In FDPIC, we need to make sure __do_global_dtors_aux and frame_dummy are referenced by their address, not by pointers to the function descriptors. 2019-XX-XX Christophe Lyon Mickaël Guêné libgcc/ * libgcc/crtstuff.c: Add support for FDPIC

[ARM/FDPIC v6 06/24] [ARM] FDPIC: Add support for c++ exceptions

2019-09-09 Thread Christophe Lyon
From: Christophe Lyon The main difference with existing support is that function addresses are function descriptor addresses instead. This means that all code dealing with function pointers now has to cope with function descriptors instead. For the same reason, Linux kernel helpers can no

[ARM/FDPIC v6 07/24] [ARM] FDPIC: Avoid saving/restoring r9 on stack since it is read-only

2019-09-09 Thread Christophe Lyon
From: Christophe Lyon 2019-XX-XX Christophe Lyon Mickaël Guêné gcc/ * config/arm/arm.h (PIC_REGISTER_MAY_NEED_SAVING): New helper. * config/arm/arm.c (arm_compute_save_reg0_reg12_mask): Handle FDPIC. Change-Id

[ARM/FDPIC v6 08/24] [ARM] FDPIC: Enforce local/global binding for function descriptors

2019-09-09 Thread Christophe Lyon
From: Christophe Lyon Use local binding rules to decide whether we can use GOTOFFFUNCDESC to compute the function address. 2019-XX-XX Christophe Lyon Mickaël Guêné gcc/ * config/arm/arm.c (arm_fdpic_local_funcdesc_p): New function. (legitimize_pic_address

[ARM/FDPIC v6 09/24] [ARM] FDPIC: Add support for taking address of nested function

2019-09-09 Thread Christophe Lyon
From: Christophe Lyon In FDPIC mode, the trampoline generated to support pointers to nested functions looks like: .wordtrampoline address .wordtrampoline GOT address ldr r12, [pc, #8] ldr r9, [pc, #8] ldr

[ARM/FDPIC v6 10/24] [ARM] FDPIC: Implement TLS support.

2019-09-09 Thread Christophe Lyon
From: Christophe Lyon Support additional relocations: TLS_GD32_FDPIC, TLS_LDM32_FDPIC, and TLS_IE32_FDPIC. We do not support the GNU2 TLS dialect. 2019-XX-XX Christophe Lyon Mickaël Guêné gcc/ * config/arm/arm.c (tls_reloc): Add TLS_GD32_FDPIC

[ARM/FDPIC v6 11/24] [ARM] FDPIC: Add support to unwind FDPIC signal frame

2019-09-09 Thread Christophe Lyon
From: Christophe Lyon 2019-XX-XX Christophe Lyon Mickaël Guêné libgcc/ * unwind-arm-common.inc (ARM_SET_R7_RT_SIGRETURN) (THUMB2_SET_R7_RT_SIGRETURN, FDPIC_LDR_R12_WITH_FUNCDESC) (FDPIC_LDR_R9_WITH_GOT, FDPIC_LDR_PC_WITH_RESTORER

[ARM/FDPIC v6 12/24] [ARM] FDPIC: Restore r9 after we call __aeabi_read_tp

2019-09-09 Thread Christophe Lyon
From: Christophe Lyon We call __aeabi_read_tp() to get the thread pointer. Since this is a function call, we have to restore the FDPIC register afterwards. 2019-XX-XX Christophe Lyon Mickaël Guêné gcc/ * config/arm/arm.c (arm_load_tp): Add FDPIC support

[ARM/FDPIC v6 13/24] [ARM] FDPIC: Force LSB bit for PC in Cortex-M architecture

2019-09-09 Thread Christophe Lyon
From: Christophe Lyon Without this, when we are unwinding across a signal frame we can jump to an even address which leads to an exception. This is needed in __gnu_persnality_sigframe_fdpic() when restoring the PC from the signal frame since the PC saved by the kernel has the LSB bit set to

[ARM/FDPIC v6 14/24] [ARM][testsuite] FDPIC: Skip unsupported tests

2019-09-09 Thread Christophe Lyon
From: Christophe Lyon Several tests cannot work on ARM-FDPIC for various reasons: skip them, or skip some directives. gcc.dg/20020312-2.c: Skip since it forces -fno-pic. gcc.target/arm/: * Skip since r9 is clobbered by assembly code: 20051215-1.c mmx-1.c pr61948.c pr77933-1.c pr77933

[ARM/FDPIC v6 15/24] [ARM][testsuite] FDPIC: Adjust scan-assembler patterns.

2019-09-09 Thread Christophe Lyon
From: Christophe Lyon In FDPIC mode, r9 is saved in addition to other registers, so update the expected patterns accordingly. 2019-XX-XX Christophe Lyon Mickaël Guêné * gcc/testsuite/ * gcc.target/arm/interrupt-1.c: Add scan-assembler pattern for arm

[ARM/FDPIC v6 16/24] [ARM][testsuite] FDPIC: Skip tests that don't work in PIC mode

2019-09-09 Thread Christophe Lyon
From: Christophe Lyon Some tests fail on arm*-*-uclinuxfdpiceabi because it generates PIC code and they don't support it: skip them. They also fail on arm*-linux* when forcing -fPIC. 2019-XX-XX Christophe Lyon gcc/testsuite/ * gcc.target/arm/eliminate.c: Accept only n

[ARM/FDPIC v6 17/24] [ARM][testsuite] FDPIC: Handle *-*-uclinux*

2019-09-09 Thread Christophe Lyon
From: Christophe Lyon Add *-*-uclinux* to tests that work on this target. 2019-XX-XX Christophe Lyon gcc/testsuite/ * g++.dg/abi/forced.C: Add *-*-uclinux*. * g++.dg/abi/guard2.C: Likewise. * g++.dg/ext/cleanup-10.C: Likewise. * g++.dg/ext/cleanup-11

[ARM/FDPIC v6 18/24] [ARM][testsuite] FDPIC: Enable tests on pie_enabled targets

2019-09-09 Thread Christophe Lyon
From: Christophe Lyon Some tests have the "nonpic" guard, but pass on arm*-*-uclinuxfdpiceabi because it is in PIE mode by default. Rather than adding this target to all these tests, add the "pie_enabled" effective target. 2019-XX-XX Christophe Lyon gcc/testsui

[ARM/FDPIC v6 19/24] [ARM][testsuite] FDPIC: Adjust pr43698.c to avoid clash with uclibc.

2019-09-09 Thread Christophe Lyon
From: Christophe Lyon uclibc defines bswap_32, so use a different name in this test. 2019-XX-XX Christophe Lyon gcc/testsuite/ * gcc.target/arm/pr43698.c (bswap_32): Rename as my_bswap_32. Change-Id: I2591bd911030814331cabf97ee5cf6cf8124b4f3 diff --git a/gcc/testsuite

[ARM/FDPIC v6 20/24] [ARM][testsuite] FDPIC: Skip tests using architectures unsupported by FDPIC

2019-09-09 Thread Christophe Lyon
From: Christophe Lyon Since FDPIC currently supports arm and thumb-2 modes only, these tests fail because they enforce an architecture version that doesn't match these restrictions. This patch introduces new values for the arm_arch effective-target (v4t_thumb, v5t_thumb, v5te_thumb, v6_

[ARM/FDPIC v6 21/24] [ARM] FDPIC: Handle stack-protector combined patterns

2019-09-09 Thread Christophe Lyon
From: Christophe Lyon The recent stack_protect_combined_set_insn and stack_protect_combined_test_insn force recomputing of GOT base, but need to take into account that in FDPIC mode, the PIC register is fixed by the ABI (r9). 2019-XX-XX Christophe Lyon gcc/ * config/arm

[ARM/FDPIC v6 22/24] [ARM][testsuite] FDPIC: Skip tests that require -static support

2019-09-09 Thread Christophe Lyon
From: Christophe Lyon Since FDPIC does not support -static, skip the related tests. 2019-XX-XX Christophe Lyon gcc/testsuite/ * lib/target-supports.exp (check_effective_target_static): Disable for ARM FDPIC target. Change-Id

[ARM/FDPIC v6 23/24] [ARM] FDPIC: Implement libitm support.

2019-09-09 Thread Christophe Lyon
From: Christophe Lyon The ldaddr macro in sjlj.S needs to be updated to support the FDPIC model. 2019-XX-XX Christophe Lyon libitm/ * config/arm/sjlj.S (ldaddr): Add FDPIC support. Change-Id: Ieb2c6613363341d109c3500af0575b133b17407d diff --git a/libitm/config/arm/sjlj.S b

[ARM/FDPIC v6 24/24] [ARM] FDPIC: Handle arm*-*-uclinuxfdpiceabi in libstdc++ configure scripts

2019-09-09 Thread Christophe Lyon
From: Christophe Lyon 2019-XX-XX Christophe Lyon libstdc++-v3/ * acinclude.m4: Handle uclinux*. * configure: Regenerate. * configure.host: Handle uclinux* Change-Id: Ia1b53693625e4153a090fcfc925a4d605bc98e59 diff --git a/libstdc++-v3/acinclude.m4 b/libstdc

Re: r272976 - in /trunk/gcc/ada: ChangeLog ali.adb ...

2019-09-10 Thread Christophe Lyon
On 10/09/2019 12:17, Arnaud Charlet wrote: It seems there's a problem with this patch: /snapshots/gcc.git~master/gcc/doc/install.texi:2730: @ref reference to nonexistent node `GNAT-prerequisite' Makefile:3300: recipe for target '/builds/armv8l-unknown-linux-gnueabihf/armv8l-unknown-linux-gnueabih

Re: [ARM/FDPIC v6 20/24] [ARM][testsuite] FDPIC: Skip tests using architectures unsupported by FDPIC

2019-09-16 Thread Christophe Lyon
Hi Kyrill, I didn't commit this patch yet: are you OK with it? Thanks, Christophe On Mon, 9 Sep 2019 at 17:52, Christophe Lyon wrote: > From: Christophe Lyon > > Since FDPIC currently supports arm and thumb-2 modes only, these tests > fail because they enforce an architec

[PATCH][PR91749][arm] FDPIC: Handle -mflip-thumb

2019-09-16 Thread Christophe Lyon
via attributes (either in the source code, or via -mflip-thumb). This patch adds the same error message when trying to apply the "thumb" attribute and the target does not support Thumb-2 (only if we are in FDPIC mode, of course). OK? Thanks, Christophe gcc/ChangeLog: 2019-09-16 Chris

Re: [ARM/FDPIC v6 13/24] [ARM] FDPIC: Force LSB bit for PC in Cortex-M architecture

2019-09-17 Thread Christophe Lyon
On 17/09/2019 13:38, Wilco Dijkstra wrote: Hi Christophe, Can you explain this in more detail - it doesn't make sense to me to force the Thumb bit during unwinding since it should already be correct, even on a Thumb-only CPU. Perhaps the kernel code that pushes an incorrect address on the stack

[wwwdocs] gcc-10/changes.html - Document new ARM FDPIC ABI support

2019-09-17 Thread Christophe Lyon
Hi, As Kyrill suggested, here is a patch to mention the new FDPIC ABI support for arm. OK? Thanks, Christophe Index: changes.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-10/changes.html,v retrieving revision 1.14 diff -r1.14 chang

Re: [wwwdocs] gcc-10/changes.html - Document new ARM FDPIC ABI support

2019-09-17 Thread Christophe Lyon
On Tue, 17 Sep 2019 at 17:40, Kyrill Tkachov wrote: > > Hi Christophe, > > On 9/17/19 4:38 PM, Christophe Lyon wrote: > > Hi, > > As Kyrill suggested, here is a patch to mention the new FDPIC ABI > support for arm. > OK? > > Thanks, > > Christop

Re: [wwwdocs] gcc-10/changes.html - Document new ARM FDPIC ABI support

2019-09-17 Thread Christophe Lyon
On Tue, 17 Sep 2019 at 17:54, Kyrill Tkachov wrote: > > > On 9/17/19 4:52 PM, Christophe Lyon wrote: > > On Tue, 17 Sep 2019 at 17:40, Kyrill Tkachov > wrote: > > > > Hi Christophe, > > > > On 9/17/19 4:38 PM, Christophe Lyon wrote: > > > &g

<    6   7   8   9   10   11   12   13   14   15   >