Re: [PATCH] aarch64: Add +lse128 architectural extension command-line flag

2024-03-15 Thread Christophe Lyon
On Fri, 15 Mar 2024 at 12:15, Victor Do Nascimento wrote: > > Given how, at present, the choice of using LSE128 atomic instructions > by the toolchain is delegated to run-time selection in the form of > Libatomic ifuncs, responsible for querying target support, the > `+lse128' target architecture

[PATCH] arm: [MVE intrinsics] Fix support for loads [PR target/114323]

2024-03-15 Thread Christophe Lyon
tribute instead, and solves the problem. 2024-03-15 Christophe Lyon PR target/114323 gcc/ * config/arm/arm-mve-builtins.cc (function_instance::reads_global_state_p): Take CP_READ_MEMORY into account. gcc/testsuite/ * gcc.target/arm/mve/pr114

Re: [PATCH v2 08/13] aarch64: Add Cygwin and MinGW environments for AArch64

2024-03-18 Thread Christophe Lyon
Hi! On Mon, 4 Mar 2024 at 18:44, Evgeny Karpov wrote: > > From: Zac Walker > Date: Fri, 1 Mar 2024 10:49:28 +0100 > Subject: [PATCH v2 08/13] aarch64: Add Cygwin and MinGW environments for > AArch64 > > Define Cygwin and MinGW environment such as types, SEH definitions, > shared libraries, etc.

Re: [PATCH v2 00/13] Add aarch64-w64-mingw32 target

2024-03-18 Thread Christophe Lyon
On Thu, 7 Mar 2024 at 21:48, Evgeny Karpov wrote: > > Monday, March 4, 2024 > Evgeny Karpov wrote: > > > > > Changes from v1 to v2: > > Adjust the target name to aarch64-*-mingw* to exclude the big-endian target > > from support. > > Exclude 64-bit ISA. > > Rename enum calling_abi to aarch64_calli

Re: [PATCH v2 08/13] aarch64: Add Cygwin and MinGW environments for AArch64

2024-03-19 Thread Christophe Lyon
On Mon, 18 Mar 2024 at 22:35, Evgeny Karpov wrote: > > Monday, March 18, 2024 2:27 PM > Christophe Lyon wrote: > > > > +/* Disable SEH and declare the required SEH-related macros that are > > > +still needed for compilation. */ #undef TARGET_SEH #define > > &g

Re: [PATCH] libgcc: arm: fix build for FDPIC target

2024-03-25 Thread Christophe Lyon
Hi, On 3/22/24 21:14, Max Filippov wrote: libgcc/ * unwind-arm-common.inc (__gnu_personality_sigframe_fdpic): Cast last argument of _Unwind_VRS_Set to void *. --- libgcc/unwind-arm-common.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libgcc/unwind-arm

[PATCH] aarch64: Fix typo in comment about FEATURE_STRING

2024-03-29 Thread Christophe Lyon
Fix the comment to document FEATURE_STRING instead of FEAT_STRING. 2024-03-29 Christophe Lyon gcc/ * config/aarch64/aarch64-option-extensions.def: Fix comment. --- gcc/config/aarch64/aarch64-option-extensions.def | 16 1 file changed, 8 insertions(+), 8

[committed] [aarch64, testsuite]: Fix lrcpc3 testcase

2024-03-29 Thread Christophe Lyon
There was a typo in the testcase, with GCC_CPUINFO pointing to the wrong file. Committed as obvious. 2024-03-29 Christophe Lyon gcc/testsuite/ * gcc.target/aarch64/cpunative/native_cpu_24.c: Fix GCC_CPUINFO. --- gcc/testsuite/gcc.target/aarch64/cpunative/native_cpu_24.c | 2

[PATCH 1/2] modula2: Add m2.install-html rule to gcc/m2/Make-lang.in

2024-03-29 Thread Christophe Lyon
This rule was missing, and 'make install-html' was failing. It is copied from the corresponding one in fortran. 2024-03-29 Christophe Lyon gcc/m2/ * Make-lang.in (install-html): New rule. --- gcc/m2/Make-lang.in | 19 +++ 1 file changed, 19 insertion

[PATCH 2/2] modula2: Fix m2.install-info in gcc/m2/Make-lang.in

2024-03-29 Thread Christophe Lyon
Fix a few typos: the generated filename is m2.info (not gm2.info, and gm2$(exeext) is a file not a directory (so test -d would always fail). 2024-03-29 Christophe Lyon gcc/m2/ * Make-lang.in (m2.install-info): Fix rule. --- gcc/m2/Make-lang.in | 14 +++--- 1 file

[PATCH] go: Add go.install-dvi rule in go/Make-lang.in

2024-04-04 Thread Christophe Lyon
go has a go.dvi build rule, but lacks the go.install-dvi one. 2024-04-04 Christophe Lyon gcc/go/ * Make-lang.in (go.install-dvi): New rule. --- gcc/go/Make-lang.in | 10 ++ 1 file changed, 10 insertions(+) diff --git a/gcc/go/Make-lang.in b/gcc/go/Make-lang.in index

[PATCH] modula2: Add m2.install-dvi in gcc/m2/Make-lang.in

2024-04-04 Thread Christophe Lyon
m2 has a m2.dvi build rule, but lacks the m2.install-dvi one. 2024-04-04 Christophe Lyon gcc/m2/ * Make-lang.in (m2.install-dvi): New rule. --- gcc/m2/Make-lang.in | 12 1 file changed, 12 insertions(+) diff --git a/gcc/m2/Make-lang.in b/gcc/m2/Make-lang.in

[PATCH] rust: Add rust.install-dvi and rust.install-html rules

2024-04-04 Thread Christophe Lyon
rust has the (empty) rust.dvi and rust.html rules, but lacks the (empty) rust.install-dvi and rust.install-html ones. 2024-04-04 Christophe Lyon gcc/rust/ * Make-lang.in (rust.install-dvi, rust.install-html): New rules. --- gcc/rust/Make-lang.in | 2 ++ 1 file changed, 2

Re: [PATCH] [testsuite] Fix pretty printers regexps for GDB output

2024-04-10 Thread Christophe Lyon
ping? On Tue, 6 Feb 2024 at 10:26, Christophe Lyon wrote: > > ping? > > On Thu, 25 Jan 2024 at 16:54, Christophe Lyon > wrote: > > > > On Wed, 24 Jan 2024 at 12:02, Jonathan Wakely wrote: > > > > > > On Wed, 24 Jan 2024 at 10:48, Christophe Lyon wro

[PATCH] gcc/configure: Re-introduce INSTALL_INFO

2024-02-01 Thread Christophe Lyon
in tm.texi and stopped). This is because 'install' depends on 'install-info', which depends on $(DESTDIR)$(infodir)/gccint.info (among others). This patch replaces the 'install-info' dependency in 'install' with $(INSTALL_INFO), thus enabling to skip this

Re: [PATCH] gcc/configure: Re-introduce INSTALL_INFO

2024-02-02 Thread Christophe Lyon
On Fri, 2 Feb 2024 at 11:10, wrote: > > On 1 February 2024 18:15:34 CET, Christophe Lyon > wrote: > >BUILD_INFO is currently a byproduct of checking makeinfo > >presence/version. INSTALL_INFO used to be defined similarly, but was > >re

[PATCH] gcc/Makefile.in: Fix install-info target if BUILD_INFO is empty

2024-02-05 Thread Christophe Lyon
in tm.texi and stopped). This is because 'install' depends on 'install-info', which depends on $(DESTDIR)$(infodir)/gccint.info (among others). This patch makes the 'install-info' dependency in 'install' conditioned by BUILD_INFO. 2024-02-05 Christophe Ly

Re: [PATCH] gcc/configure: Re-introduce INSTALL_INFO

2024-02-05 Thread Christophe Lyon
On Fri, 2 Feb 2024 at 11:40, Christophe Lyon wrote: > > On Fri, 2 Feb 2024 at 11:10, wrote: > > > > On 1 February 2024 18:15:34 CET, Christophe Lyon > > wrote: > > >BUILD_INFO is currently a byproduct of checking makeinfo > > >presence/version. INST

Re: [PATCH] [testsuite] Fix pretty printers regexps for GDB output

2024-02-06 Thread Christophe Lyon
ping? On Thu, 25 Jan 2024 at 16:54, Christophe Lyon wrote: > > On Wed, 24 Jan 2024 at 12:02, Jonathan Wakely wrote: > > > > On Wed, 24 Jan 2024 at 10:48, Christophe Lyon wrote: > > > > > > GDB emits end of lines as \r\n, we currently match the reverse \n

Re: [PATCH] gcc/Makefile.in: Fix install-info target if BUILD_INFO is empty

2024-02-10 Thread Christophe Lyon
Hi! On Tue, 6 Feb 2024 at 06:37, Alexandre Oliva wrote: > > Hello, Christophe, > > Thanks for the patch. > > On Feb 5, 2024, Christophe Lyon wrote: > > > In order to save build time, our CI overrides BUILD_INFO="", which > > works when invoking &#

Re: [PATCH] gcc/Makefile.in: Fix install-info target if BUILD_INFO is empty

2024-02-12 Thread Christophe Lyon
On Sun, 11 Feb 2024 at 06:56, Alexandre Oliva wrote: > > Hello, Christophe, > > On Feb 10, 2024, Christophe Lyon wrote: > > > gcc/ > > * Makefile.in: Add no-info dependency. > > * configure.ac: Set BUILD_INFO=no-info if makeinfo is not > >

Re: [PATCH] rtl-optimization/113597 - recover base term for argument pointers

2024-02-12 Thread Christophe Lyon
On Mon, 12 Feb 2024 at 09:00, Richard Biener wrote: > > On Sat, Feb 10, 2024 at 10:21 PM Toon Moene wrote: > > > > I managed to try this patch on aarch64-linux-gnu: > > > > This is the test run without your patch: > > > > https://gcc.gnu.org/pipermail/gcc-testresults/2024-February/807637.html > >

Re: [PATCH] gcc/Makefile.in: Fix install-info target if BUILD_INFO is empty

2024-02-12 Thread Christophe Lyon
On Mon, 12 Feb 2024 at 11:27, Jakub Jelinek wrote: > > On Mon, Feb 12, 2024 at 11:13:49AM +0100, Christophe Lyon wrote: > > On Sun, 11 Feb 2024 at 06:56, Alexandre Oliva wrote: > > > > > > Hello, Christophe, > > > > > > On Feb 10, 2024,

Re: [PATCH] c++: Fix ICE due to folding a call to constructor on cdtor_returns_this arches (aka arm32) [PR113083]

2024-02-23 Thread Christophe Lyon
On Fri, 23 Feb 2024 at 09:42, Jakub Jelinek wrote: > > Hi! > > When targetm.cxx.cdtor_returns_this () (aka on arm32 TARGET_AAPCS_BASED) > constructor is supposed to return this pointer, but when we cp_fold such > a call, we don't take that into account and just INIT_EXPR the object, > so we can la

Re: [PATCH] c++: Fix ICE due to folding a call to constructor on cdtor_returns_this arches (aka arm32) [PR113083]

2024-02-23 Thread Christophe Lyon
On Fri, 23 Feb 2024 at 10:13, Christophe Lyon wrote: > > On Fri, 23 Feb 2024 at 09:42, Jakub Jelinek wrote: > > > > Hi! > > > > When targetm.cxx.cdtor_returns_this () (aka on arm32 TARGET_AAPCS_BASED) > > constructor is supposed to return this pointer, but

Re: [PATCH] testsuite: Disable test for PR113292 on targets without TLS support

2024-01-19 Thread Christophe Lyon
On Fri, 19 Jan 2024 at 08:41, Nathaniel Shead wrote: > > Tested on x86_64-pc-linux-gnu using a cross-compiler to > arm-unknown-linux-gnueabihf with --enable-threads=0 that the link test > is correctly skipped. OK for trunk? > > -- >8 -- > > This disables the new test added by r14-8168 on machines

[PATCH] [testsuite] Fix pretty printers regexps for GDB output

2024-01-24 Thread Christophe Lyon
xp to match the right order implied fixing the second one, to skip the empty lines. Tested on aarch64-linux-gnu. [1] https//github.com/bminor/binutils-gdb/blob/master/gdb/testsuite/README#L269 2024-01-24 Christophe Lyon libstdc++-v3/ * testsuite/lib/gdb-test.exp (gdb-test): Fix re

Re: [PATCH] [testsuite] Fix pretty printers regexps for GDB output

2024-01-25 Thread Christophe Lyon
On Wed, 24 Jan 2024 at 12:02, Jonathan Wakely wrote: > > On Wed, 24 Jan 2024 at 10:48, Christophe Lyon wrote: > > > > GDB emits end of lines as \r\n, we currently match the reverse \n\r, > > We currently match [\n\r]+ which should match any of \n, \r, \n\r or \r\n > H

[PATCH] Allow overriding EXPECT

2023-12-21 Thread Christophe Lyon
rted from their respective upstream repo, so should not be patched here. [1] https://github.com/bminor/binutils-gdb/blob/master/gdb/testsuite/README#L269 2023-12-21 Christophe Lyon gcc/ * Makefile.in: Allow overriding EXEPCT. libgm2/ * Makefile.am: Allow ov

Re: [PATCH] testsuite, arm: Fix up pr112337.c test

2023-12-01 Thread Christophe Lyon
On Fri, 1 Dec 2023 at 13:44, Richard Earnshaw (lists) wrote: > > On 01/12/2023 11:28, Saurabh Jha wrote: > > Hey, > > > > I introduced this test "gcc/testsuite/gcc.target/arm/mve/pr112337.c" in > > this commit 2365aae84de030bbb006edac18c9314812fc657b before. This had an > > error which I unfortu

Re: [PATCH 5/5] aarch64: Add rsr128 and wsr128 ACLE tests

2023-11-08 Thread Christophe Lyon
On 11/7/23 23:51, Richard Sandiford wrote: Victor Do Nascimento writes: Extend existing unit tests for the ACLE system register manipulation functions to include 128-bit tests. gcc/testsuite/ChangeLog: * gcc/testsuite/gcc.target/aarch64/acle/rwsr.c (get_rsr128): New. (set_w

Re: [committed 01/22] arm: testsuite: correctly detect armv6t2 hardware for acle execution tests

2023-11-14 Thread Christophe Lyon
Hi, On 11/13/23 15:26, Richard Earnshaw wrote: diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp index 1a7bea96c1e..d414cddf4dc 100644 --- a/gcc/testsuite/lib/target-supports.exp +++ b/gcc/testsuite/lib/target-supports.exp @@ -5590,6 +5590,24 @@ proc che

[PATCH 1/6] arm: Fix arm_simd_types and MVE scalar_types

2023-11-16 Thread Christophe Lyon
le pointer type note: expected 'int *' but argument is of type 'int32_t *' {aka 'long int *'} This patch uses get_typenode_from_name (INT32_TYPE) instead, which defines the types as appropriate for the target/C library. 2023-11-16 Christophe Lyon g

[PATCH 4/6] arm: [MVE intrinsics] add load and store shapes

2023-11-16 Thread Christophe Lyon
This patch adds the load and store shapes descriptions. 2023-11-16 Christophe Lyon gcc/ * config/arm/arm-mve-builtins-shapes.cc (load, store): New. * config/arm/arm-mve-builtins-shapes.h (load, store): New. --- gcc/config/arm/arm-mve-builtins-shapes.cc | 67

[PATCH 2/6] arm: [MVE intrinsics] Add support for void and load/store pointers as argument types.

2023-11-16 Thread Christophe Lyon
This patch adds support for '_', 'al' and 'as' for void, load pointer and store pointer argument/return value types in intrinsic signatures. It also adds a mew memory_scalar_type() helper to function_instance, which is used by 'al' and 'as&

[PATCH 5/6] arm: [MVE intrinsics] fix vst1 tests

2023-11-16 Thread Christophe Lyon
vst1q intrinsics return void, so we should not do 'return vst1q_f16 (base, value);' This was OK so far, but will trigger an error/warning with the new implementation of these intrinsics. This patch just removes the 'return' keyword. 2023-11-16 Christophe Lyon

[PATCH 3/6] arm: [MVE intrinsics] Add support for contiguous loads and stores

2023-11-16 Thread Christophe Lyon
later as needed. 2023-11-16 Christophe Lyon gcc/ * config/arm/arm-mve-builtins-functions.h (multi_vector_function) (full_width_access): New classes. * config/arm/arm-mve-builtins.cc (find_type_suffix_for_scalar_type, infer_pointer

[PATCH 6/6] arm: [MVE intrinsics] rework vldq1 vst1q

2023-11-16 Thread Christophe Lyon
Implement vld1q, vst1q using the new MVE builtins framework. 2023-11-16 Christophe Lyon gcc/ * config/arm/arm-mve-builtins-base.cc (vld1_impl, vld1q) (vst1_impl, vst1q): New. * config/arm/arm-mve-builtins-base.def (vld1q, vst1q): New. * config/arm/arm

Re: [PATCH 5/6] arm: [MVE intrinsics] fix vst1 tests

2023-11-16 Thread Christophe Lyon
On Thu, 16 Nov 2023 at 16:30, Kyrylo Tkachov wrote: > > > > > -Original Message- > > From: Christophe Lyon > > Sent: Thursday, November 16, 2023 3:26 PM > > To: gcc-patches@gcc.gnu.org; Richard Sandiford > > ; Richard Earnshaw > > ; Kyrylo

Re: [PATCH] Add a REG_P check for inc and dec for Arm MVE

2023-11-20 Thread Christophe Lyon
Hi Saurabh, On Tue, 14 Nov 2023 at 15:51, Kyrylo Tkachov wrote: > > Hi Saurabh, > > > -Original Message- > > From: Saurabh Jha > > Sent: Thursday, November 9, 2023 10:12 AM > > To: gcc-patches@gcc.gnu.org; Richard Earnshaw > > ; Richard Sandiford > > > > Subject: [PATCH] Add a REG_P che

Re: [committed 03/22] arm: testsuite: avoid hard-float ABI incompatibility with -march

2023-11-20 Thread Christophe Lyon
Hi Richard, On Mon, 13 Nov 2023 at 15:28, Richard Earnshaw wrote: > > > A number of tests in the gcc testsuite, especially for arm-specific > targets, add various flags to control the architecture. These run > into problems when the compiler is configured with -mfpu=auto if the > new architectur

Re: [committed 02/22] arm: testsuite: correctly detect hard_float

2023-11-20 Thread Christophe Lyon
Hi Richard, On Mon, 13 Nov 2023 at 15:27, Richard Earnshaw wrote: > > > Add an arm-specific test to check_effective_target_hard_float for > Arm to handle cases where we only have single-precision FP in hardware. > > gcc/testsuite: > > * lib/target-supports.exp (check_effective_target_har

Re: [committed 03/22] arm: testsuite: avoid hard-float ABI incompatibility with -march

2023-11-20 Thread Christophe Lyon
On Mon, 20 Nov 2023 at 13:44, Richard Earnshaw wrote: > > > > On 20/11/2023 10:23, Christophe Lyon wrote: > > Hi Richard, > > > > On Mon, 13 Nov 2023 at 15:28, Richard Earnshaw wrote: > >> > >> > >> A number of tests in the gcc testsui

Re: [committed 03/22] arm: testsuite: avoid hard-float ABI incompatibility with -march

2023-11-20 Thread Christophe Lyon
On Mon, 20 Nov 2023 at 14:58, Richard Earnshaw wrote: > > > > On 20/11/2023 13:36, Christophe Lyon wrote: > > On Mon, 20 Nov 2023 at 13:44, Richard Earnshaw > > wrote: > >> > >> > >> > >> On 20/11/2023 10:23, Christophe Lyon wrote

Re: [committed 03/22] arm: testsuite: avoid hard-float ABI incompatibility with -march

2023-11-20 Thread Christophe Lyon
On Mon, 20 Nov 2023 at 15:39, Richard Earnshaw wrote: > > > > On 20/11/2023 14:24, Christophe Lyon wrote: > > On Mon, 20 Nov 2023 at 14:58, Richard Earnshaw > > wrote: > >> > >> > >> > >> On 20/11/2023 13:36, Christophe Lyon

Re: Propagate value ranges of return values

2023-11-21 Thread Christophe Lyon
Hi! On Sun, 19 Nov 2023 at 16:05, Jan Hubicka wrote: > > Hi, > this is updated version which also adds testuiste compensation > I lost earlier while maintaining the patch in my testing tree. > There are quite few testcases that use constant return values to hide > something from optimizer. > > Bo

Re: [PATCH] testsuite: Fix up pr111309-2.c on arm [PR111309]

2023-11-21 Thread Christophe Lyon
On Tue, 21 Nov 2023 at 09:48, Jakub Jelinek wrote: > > Hi! > > ARM defaults to -fshort-enums and the following testcase FAILs there in 2 > lines. The difference is that in C++, E0 has enum E type, which normally > has unsigned int underlying type, so it isn't int nor something that > promotes to

[PATCH] arm: [MVE intrinsics] Fix typo

2023-11-22 Thread Christophe Lyon
In commt 0c2037d9d93a8f768cb11698ff794278246bb31f (Add support for contiguous loads and stores), I added a spurious line which broke bootstrap because of an unused variable error. This patch removes it. Committed as obvious. 2023-11-22 Christophe Lyon gcc/ChangeLog: * config/arm

Re: Fix 'gcc.dg/tree-ssa/return-value-range-1.c' for 'char' defaulting to 'unsigned' (was: Propagate value ranges of return values)

2023-11-22 Thread Christophe Lyon
Hi! On Tue, 21 Nov 2023 at 22:24, Thomas Schwinge wrote: > > Hi! > > On 2023-11-19T16:05:42+0100, Jan Hubicka wrote: > > --- /dev/null > > +++ b/gcc/testsuite/gcc.dg/tree-ssa/return-value-range-1.c > > Pushed to master branch commit a0240662b22312ffb3e3fefb85f258ab0e7010f4 > "Fix 'gcc.dg/tree-ss

Re: [PATCH v2] gcov: Fix integer types in gen_counter_update()

2023-11-22 Thread Christophe Lyon
Hi, On Tue, 21 Nov 2023 at 12:22, Sebastian Huber wrote: > > On 21.11.23 11:46, Jakub Jelinek wrote: > > On Tue, Nov 21, 2023 at 11:42:06AM +0100, Sebastian Huber wrote: > >> > >> On 21.11.23 11:34, Jakub Jelinek wrote: > --- a/gcc/tree-profile.cc > +++ b/gcc/tree-profile.cc > @@ -

Re: [PATCH] testsuite, Darwin: Add support for Mach-O function body scans.

2023-11-23 Thread Christophe Lyon
Hi Iain, On Mon, 6 Nov 2023 at 11:58, Richard Sandiford wrote: > > Iain Sandoe writes: > > Hi Richard, > > > >> On 5 Nov 2023, at 12:11, Richard Sandiford > >> wrote: > >> > >> Iain Sandoe writes: > > > On 26 Oct 2023, at 21:00, Iain Sandoe wrote: > >>> > > On 26 Oct 2023, at 20:49,

Re: [PATCH] testsuite, Darwin: Add support for Mach-O function body scans.

2023-11-23 Thread Christophe Lyon
On Thu, 23 Nov 2023 at 10:09, Iain Sandoe wrote: > > Hi Christophe. > > > On 23 Nov 2023, at 09:02, Christophe Lyon > > wrote: > > > > Hi Iain, > > > > On Mon, 6 Nov 2023 at 11:58, Richard Sandiford > > wrote: > >> > >> Iai

[PATCH] arm: [MVE intrinsics] Add default clause to full_width_access::memory_vector_mode

2023-11-23 Thread Christophe Lyon
My recent commit 0c2037d9d93a8f768cb11698ff794278246bb31f added a switch statement lacking a default clause, leading to warnings or errors when building with --enable-werror-always. Fix by adding an empty default. Committed as obvious. 2023-11-23 Christophe Lyon gcc

Re: [PATCH 3/6] arm: [MVE intrinsics] Add support for contiguous loads and stores

2023-11-23 Thread Christophe Lyon
Hi! On Thu, 23 Nov 2023 at 14:29, Jan-Benedict Glaw wrote: > > On Thu, 2023-11-16 15:26:14 +, Christophe Lyon > wrote: > > diff --git a/gcc/config/arm/arm-mve-builtins-functions.h > > b/gcc/config/arm/arm-mve-builtins-functions.h > > index eba1f071af0..6d234

Re: [PATCH] testsuite, lib: Re-allow mulitple function start labels.

2023-11-23 Thread Christophe Lyon
Hi Iain, Thanks for dealing with this :-) On Thu, 23 Nov 2023 at 10:58, Iain Sandoe wrote: > > Tested on a cross to armv8l-unknown-linux-gnueabihf where the failing > testcase is restored, and on aarch64-linux-gnu where no change is seen > on the aarch64.exp suite. Also tested on arm64 Darwin f

Re: [PATCH] testsuite, lib: Re-allow mulitple function start labels.

2023-11-23 Thread Christophe Lyon
On Thu, 23 Nov 2023 at 17:35, Iain Sandoe wrote: > > Hi > > > On 23 Nov 2023, at 16:11, Christophe Lyon > > wrote: > > > > Hi Iain, > > > > Thanks for dealing with this :-) > > > > On Thu, 23 Nov 2023 at 10:58, Iain Sandoe wrote: >

Re: [patch] OpenMP: Add -Wopenmp and use it

2023-11-27 Thread Christophe Lyon
Hi! On Fri, 24 Nov 2023 at 15:08, Jakub Jelinek wrote: > > On Fri, Nov 24, 2023 at 02:51:28PM +0100, Tobias Burnus wrote: > > Following the general trend to add a "[-W...]" to the warning messages > > for both better grouping of the warnings and - more importantly - for > > providing > > a means

Re: [patch] OpenMP: Add -Wopenmp and use it

2023-11-27 Thread Christophe Lyon
On Mon, 27 Nov 2023 at 11:33, Tobias Burnus wrote: > > Hi, > > On 27.11.23 11:20, Christophe Lyon wrote: > > > I think the lack of final '.' in: > > Indeed - but you are lagging a bit behind: > > https://gcc.gnu.org/pipermail/gcc-patches/2023-November

[PATCH] testsuite/arm: Fix bfloat16_vector_typecheck_[12].c tests

2023-11-30 Thread Christophe Lyon
#x27;long ' before 'int' in the expected error message. 2023-11-30 Christophe Lyon gcc/testsuite/ * gcc.target/arm/bfloat16_vector_typecheck_1.c: Update expected error message. * gcc.target/arm/bfloat16_vector_typecheck_2.c: Likewise. --- gcc/tes

Re: [PATCH] i386: Fix regression after refactoring legitimize_pe_coff_symbol, ix86_GOT_alias_set and PE_COFF_LEGITIMIZE_EXTERN_DECL

2024-06-27 Thread Christophe Lyon
Hi Evgeny, Minor comments: - the patch title should end with [PRn, ...] (choose the most relevant bug number) - ChangeLog should mention every bug with PR component/n so that the bugzilla hooks will notice the commit. See https://gcc.gnu.org/contribute.html#patches (but I can do it for yo

[PATCH 1/2] arm: [MVE intrinsics] fix vdup iterator

2024-07-08 Thread Christophe Lyon
This patch fixes a bug where the mode iterator for mve_vdup should be MVE_VLD_ST instead of MVE_vecs: V2DI and V2DF (thus vdup.64) are not supported by MVE. 2024-07-02 Jolen Li Christophe Lyon gcc/ * config/arm/mve.md (mve_vdup): Fix mode iterator. --- gcc

[PATCH 2/2] arm: [MVE intrinsics] Improve vdupq_n implementation

2024-07-08 Thread Christophe Lyon
mode iterator for vdupq_n is now MVE_VLD_ST instead of MVE_vecs: V2DI and V2DF (thus vdup.64) are not supported by MVE. Tested on arm-linux-gnueabihf with no regression. 2024-07-02 Jolen Li Christophe Lyon gcc/ * config/arm/arm-mve-builtins-base.cc (vdupq_impl)

[PATCH v2 2/2] arm: [MVE intrinsics] Improve vdupq_n implementation

2024-07-11 Thread Christophe Lyon
ested on arm-linux-gnueabihf and arm-none-eabi with no regression. 2024-07-02 Jolen Li Christophe Lyon gcc/ * config/arm/arm-mve-builtins-base.cc (vdupq_impl): New class. (vdupq): Use new implementation. * config/arm/arm.cc (arm_rtx_costs_intern

[PATCH v2 1/2] arm: [MVE intrinsics] fix vdup iterator

2024-07-11 Thread Christophe Lyon
This patch fixes a bug where the mode iterator for mve_vdup should be MVE_VLD_ST instead of MVE_vecs: V2DI and V2DF (thus vdup.64) are not supported by MVE. 2024-07-02 Jolen Li Christophe Lyon gcc/ * config/arm/mve.md (mve_vdup): Fix mode iterator. --- gcc

[PATCH 02/15] arm: [MVE intrinsics] remove useless resolve from create shape

2024-07-11 Thread Christophe Lyon
vcreateq have no overloaded forms, so there's no need for resolve (). 2024-07-11 Christophe Lyon gcc/ * config/arm/arm-mve-builtins-shapes.cc (create_def): Remove resolve. --- gcc/config/arm/arm-mve-builtins-shapes.cc | 6 -- 1 file changed, 6 deletions(-)

[PATCH 01/15] arm: [MVE intrinsics] improve comment for orrq shape

2024-07-11 Thread Christophe Lyon
Add a comment about the lack of "n" forms for floating-point nor 8-bit integers, to make it clearer why we use build_16_32 for MODE_n. 2024-07-11 Christophe Lyon gcc/ * config/arm/arm-mve-builtins-shapes.cc (binary_orrq_def): Improve comment. --- gcc/config/a

[PATCH 04/15] arm: [MVE intrinsics] factorize vcvtq

2024-07-11 Thread Christophe Lyon
Factorize vcvtq so that they use the parameterized names. 2024-07-11 Christophe Lyon gcc/ * config/arm/iterators.md (mve_insn): Add VCVTQ_FROM_F_S, VCVTQ_FROM_F_U, VCVTQ_M_FROM_F_S, VCVTQ_M_FROM_F_U, VCVTQ_M_N_FROM_F_S, VCVTQ_M_N_FROM_F_U, VCVTQ_M_N_TO_F_S

[PATCH 09/15] arm: [MVE intrinsics] rework vcvtbq_f16_f32 vcvttq_f16_f32 vcvtbq_f32_f16 vcvttq_f32_f16

2024-07-11 Thread Christophe Lyon
Implement vcvtbq_f16_f32, vcvttq_f16_f32, vcvtbq_f32_f16 and vcvttq_f32_f16 using the new MVE builtins framework. 2024-07-11 Christophe Lyon gcc/ * config/arm/arm-mve-builtins-base.cc (class vcvtxq_impl): New. (vcvtbq, vcvttq): New. * config/arm/arm-mve-builtins

[PATCH 05/15] arm: [MVE intrinsics] add vcvt shape

2024-07-11 Thread Christophe Lyon
This patch adds the vcvt shape description. It needs to add a new type_suffix_info parameter to explicit_type_suffix_p (), because vcvt uses overloads for type suffixes for integer-> floating-point conversions, but not for floating-point to integer. 2024-07-11 Christophe Lyon

[PATCH 03/15] arm: [MVE intrinsics] Cleanup arm-mve-builtins-functions.h

2024-07-11 Thread Christophe Lyon
_insn, unspec_mve_function_exact_insn, unspec_mve_function_exact_insn_pred_p, unspec_mve_function_exact_insn_vshl no longer duplicate a lot of code. The patch also make most of PRED_m and PRED_x handling use the same code. 2024-07-11 Christophe Lyon gcc/ * config/arm/arm-mve-builtins-functi

[PATCH 13/15] arm: [MVE intrinsics] rework vbicq

2024-07-11 Thread Christophe Lyon
Implement vbicq using the new MVE builtins framework. 2024-07-11 Christophe Lyon gcc/ * config/arm/arm-mve-builtins-base.cc (vbicq): New. * config/arm/arm-mve-builtins-base.def (vbicq): New. * config/arm/arm-mve-builtins-base.h (vbicq): New. * config

[PATCH 14/15] arm: [MVE intrinsics] factorize vorn

2024-07-11 Thread Christophe Lyon
Factorize vorn so that they use the parameterized names. 2024-07-11 Christophe Lyon gcc/ * config/arm/iterators.md (MVE_INT_M_BINARY_LOGIC): Add VORNQ_M_S, VORNQ_M_U. (MVE_FP_M_BINARY_LOGIC): Add VORNQ_M_F. (mve_insn): Add VORNQ_M_S, VORNQ_M_U

[PATCH 11/15] arm: [MVE intrinsics] add vcvtx shape

2024-07-11 Thread Christophe Lyon
This patch adds the vcvtx shape description for vcvtaq, vcvtmq, vcvtnq, vcvtpq. 2024-07-11 Christophe Lyon gcc/ * config/arm/arm-mve-builtins-shapes.cc (vcvtx): New. * config/arm/arm-mve-builtins-shapes.h (vcvtx): New. --- gcc/config/arm/arm-mve-builtins-shapes.cc

[PATCH 07/15] arm: [MVE intrinsics] factorize vcvtbq vcvttq

2024-07-11 Thread Christophe Lyon
Factorize vcvtbq, vcvttq so that they use the same parameterized names. 2024-07-11 Christophe Lyon gcc/ * config/arm/iterators.md (mve_insn): Add VCVTBQ_F16_F32, VCVTTQ_F16_F32, VCVTBQ_F32_F16, VCVTTQ_F32_F16, VCVTBQ_M_F16_F32, VCVTTQ_M_F16_F32

[PATCH 15/15] arm: [MVE intrinsics] rework vorn

2024-07-11 Thread Christophe Lyon
Implement vorn using the new MVE builtins framework. 2024-07-11 Christophe Lyon gcc/ * config/arm/arm-mve-builtins-base.cc (vornq): New. * config/arm/arm-mve-builtins-base.def (vornq): New. * config/arm/arm-mve-builtins-base.h (vornq): New. * config/arm

[PATCH 10/15] arm: [MVE intrinsics] factorize vcvtaq vcvtmq vcvtnq vcvtpq

2024-07-11 Thread Christophe Lyon
Factorize vcvtaq vcvtmq vcvtnq vcvtpq builtins so that they use parameterized names. 2024-07-11 Christophe Lyon gcc/ * config/arm/iterators.md (mve_insn): Add VCVTAQ_M_S, VCVTAQ_M_U, VCVTAQ_S, VCVTAQ_U, VCVTMQ_M_S, VCVTMQ_M_U, VCVTMQ_S, VCVTMQ_U, VCVTNQ_M_S

[PATCH 08/15] arm: [MVE intrinsics] add vcvt_f16_f32 and vcvt_f32_f16 shapes

2024-07-11 Thread Christophe Lyon
This patch adds the vcvt_f16_f32 and vcvt_f32_f16 shapes descriptions. 2024-07-11 Christophe Lyon gcc/ * config/arm/arm-mve-builtins-shapes.cc (vcvt_f16_f32) (vcvt_f32_f16): New. * config/arm/arm-mve-builtins-shapes.h (vcvt_f16_f32) (vcvt_f32_f16): New

[PATCH 06/15] arm: [MVE intrinsics] rework vcvtq

2024-07-11 Thread Christophe Lyon
Implement vcvtq using the new MVE builtins framework. 2024-07-11 Christophe Lyon gcc/ * config/arm/arm-mve-builtins-base.cc (class vcvtq_impl): New. (vcvtq): New. * config/arm/arm-mve-builtins-base.def (vcvtq): New. * config/arm/arm-mve-builtins-base.h

[PATCH 12/15] arm: [MVE intrinsics] rework vcvtaq vcvtmq vcvtnq vcvtpq

2024-07-11 Thread Christophe Lyon
Implement vcvtaq vcvtmq vcvtnq vcvtpq using the new MVE builtins framework. 2024-07-11 Christophe Lyon gcc/ * config/arm/arm-mve-builtins-base.cc (vcvtaq): New. (vcvtmq): New. (vcvtnq): New. (vcvtpq): New. * config/arm/arm-mve-builtins-base.def

Re: [PATCH] [testsuite] conditionalize dg-additional-sources on target and type

2024-05-23 Thread Christophe Lyon
Hi Alexandre, On Thu, 23 May 2024 at 15:29, Alexandre Oliva wrote: > > On Apr 30, 2024, Christophe Lyon wrote: > > > On Tue, 30 Apr 2024 at 01:31, Alexandre Oliva wrote: > >> >> for gcc/testsuite/ChangeLog > >> >> > >> >>

Re: [PATCH] wwwdocs: contribute.html: Update consensus on patch content.

2024-05-23 Thread Christophe Lyon
On Mon, 20 May 2024 at 15:23, Nick Clifton wrote: > > Hi Christophe, > > > I have a follow-up one: I think the same applies to binutils, but I > > don't think any maintainer / contributor expressed an opinion, and > > IIUC patch policy for binutils is (lightly) documented at > > https://sourceware

Re: [PATCH] Arm: Fix disassembly error in Thumb-1 relaxed load/store [PR115188]

2024-06-03 Thread Christophe Lyon
Hi Wilco, On 6/3/24 15:42, Wilco Dijkstra wrote: A Thumb-1 memory operand allows single-register LDMIA/STMIA. This doesn't get printed as LDR/STR with writeback in unified syntax, resulting in strange assembler errors if writeback is selected. To work around this, use the 'Uw' constraint that

Re: [committed] testsuite: Prune warning about size of enums

2024-08-19 Thread Christophe Lyon
On 8/19/24 10:56, Torbjörn SVENSSON wrote: Committed as obvious in r15-3017 and r14-10602. > -- This fixes reported regression at https://linaro.atlassian.net/browse/GNU-1315. Thanks. This happens because libs/startup code are compiled with the default short-enums scheme for the target, w

[PATCH] arm: Always use vmov.f64 instead of vmov.f32 with MVE

2024-08-21 Thread Christophe Lyon
-mtune=cortex-m55/-mfloat-abi=hard/-mfpu=auto/-march=armv8.1-m.main+mve.fp+fp.dp 2024-08-21 Christophe Lyon gcc/ * config/arm/vfp.md (movdi_vfp, thumb2_movdf_vfp): Handle MVE case. gcc/testsuite/ * gcc.target/arm/armv8_1m-fp64-move-1.c: Update expected c

Re: [PATCH] testuite: Accept vmov.f64

2024-08-21 Thread Christophe Lyon
On Wed, 14 Aug 2024 at 22:04, Torbjörn SVENSSON wrote: > > Ok for trunk and releases/gcc-14? > > -- > > On Cortex-M55 with fpv5-d16, the vmov.f64 instruction is used. Hi Torbjorn, Thanks for the patch: after looking further I realized that we can always generate vmov.f64 with MVE, so I propose t

Re: [PATCH] arm: Zero/Sign extends for CMSE security on Armv8-M.baseline

2024-06-06 Thread Christophe Lyon
Hi Torbjörn! On Thu, 6 Jun 2024 at 18:47, Torbjörn SVENSSON wrote: > > I would like to push this patch to the following branches: > > - releases/gcc-11 > - releases/gcc-12 > - releases/gcc-13 > - releases/gcc-14 > - trunk > > Ok? > > The problem was highlighted by https://linaro.atlassian.net/bro

Re: [PATCH v2] [testsuite] [arm] [vect] adjust mve-vshr test [PR113281]

2024-06-20 Thread Christophe Lyon
Hi, On Thu, 20 Jun 2024 at 12:51, Alexandre Oliva wrote: > > On Jun 19, 2024, "Richard Earnshaw (lists)" wrote: > > > It looks like adding > > > if ((unsigned)b[i] >= 8*sizeof (TYPE##BITS##_t)) \ > > __builtin_unreachable(); \ > > Ah, yes, nice, good idea, than

Re: [PATCH v3] [testsuite] [arm] [vect] adjust mve-vshr test [PR113281]

2024-06-21 Thread Christophe Lyon
On Fri, 21 Jun 2024 at 12:14, Richard Earnshaw (lists) wrote: > > On 21/06/2024 08:57, Alexandre Oliva wrote: > > On Jun 20, 2024, Christophe Lyon wrote: > > > >> Maybe using > >> if ((unsigned)b[i] >= BITS) \ > >> would be clearer? > > >

Re: [PATCH v3 6/6] aarch64: Add DLL import/export to AArch64 target

2024-06-25 Thread Christophe Lyon
On Fri, 21 Jun 2024 at 15:51, Richard Sandiford wrote: > > Evgeny Karpov writes: > > Monday, June 10, 2024 7:03 PM > > Richard Sandiford wrote: > > > >> Thanks for the update. Parts 1-5 look good to me. Some minor comments > >> below about part 6: > >> > >> If the TARGET_DLLIMPORT_DECL_ATTRIBU

Re: [PATCH] i386: Remove declaration of unused functions

2024-06-26 Thread Christophe Lyon
On Wed, 26 Jun 2024 at 01:27, Iain Sandoe wrote: > > > > > On 25 Jun 2024, at 22:59, Evgeny Karpov wrote: > > > > The patch fixes the issue introduced in > > https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=63512c72df09b43d56ac7680cdfd57a66d40c636 > > and reported at > > https://gcc.gnu.org/pipermai

[PATCH v3] arm: [MVE intrinsics] Improve vdupq_n implementation

2024-07-30 Thread Christophe Lyon
0, r3 instead of the previous: vldr.64 d6, .L5 vldr.64 d7, .L5+8 vcmp.f16 eq, q0, q3 Tested on arm-linux-gnueabihf and arm-none-eabi with no regression. 2024-07-02 Jolen Li Christophe Lyon gcc/ * config/arm/arm-mve-builtins-base.cc (vd

Re: arm: Prevent ICE when doloop dec_set is not PLUS_EXPR

2024-07-30 Thread Christophe Lyon
Hi Andre, On 7/26/24 16:05, Andre Vieira (lists) wrote: This patch refactors and fixes an issue where arm_mve_dlstp_check_dec_counter was making an assumption about the form of what a candidate for a dec_insn. I think this lacks some verb? (eg what a candidate for a dec_insn "is" or "

[PATCH v4 1/2] arm: [MVE intrinsics] fix vdup iterator

2024-07-30 Thread Christophe Lyon
This patch fixes a bug where the mode iterator for mve_vdup should be MVE_VLD_ST instead of MVE_vecs: V2DI and V2DF (thus vdup.64) are not supported by MVE. 2024-07-02 Jolen Li Christophe Lyon gcc/ * config/arm/mve.md (mve_vdup): Fix mode iterator. --- gcc

[PATCH v4 2/2] arm: [MVE intrinsics] Improve vdupq_n implementation

2024-07-30 Thread Christophe Lyon
vldr.64 d7, .L5+8 vcmp.f16 eq, q0, q3 Tested on arm-linux-gnueabihf and arm-none-eabi with no regression. 2024-07-02 Jolen Li Christophe Lyon gcc/ * config/arm/arm-mve-builtins-base.cc (vdupq_impl): New class. (vdupq): Use new implement

Re: arm: Prevent ICE when doloop dec_set is not PLUS_EXPR

2024-07-31 Thread Christophe Lyon
from...     (arm_mve_dlstp_check_dec_counter): ... here. Use check_dec_insn to     check the validity of the candidate dec_insn. gcc/testsuite/ChangeLog:     * gcc.targer/arm/mve/dlstp-loop-form.c: New test. On 30/07/2024 21:31, Christophe Lyon wrote: I manually tried to exercise the testcase with a cross-com

Re: [PATCH 01/15] arm: [MVE intrinsics] improve comment for orrq shape

2024-07-31 Thread Christophe Lyon
ping for the series? On Thu, 11 Jul 2024 at 23:43, Christophe Lyon wrote: > > Add a comment about the lack of "n" forms for floating-point nor 8-bit > integers, to make it clearer why we use build_16_32 for MODE_n. > > 2024-07-11 Christophe Lyon > >

Re: arm: Prevent ICE when doloop dec_set is not PLUS_EXPR

2024-07-31 Thread Christophe Lyon
. Use check_dec_insn to     check the validity of the candidate dec_insn.     gcc/testsuite/ChangeLog:     * gcc.targer/arm/mve/dlstp-loop-form.c: New test. On 31/07/2024 15:15, Christophe Lyon wrote: Because I tested with a toolchain configured for cortex-m85, which has mve.fp en

Re: [PATCH] arm: Fix testism with mve/ivopts-3.c testcase

2024-08-01 Thread Christophe Lyon
Hi Andre On 8/1/24 10:46, Andre Vieira (lists) wrote: Hi, This patch ensures this testcase is ran for armv8.1-m.main+mve as this is testing that doloops with function calls that aren't intrinsics get rejected as potential doloop targets during ivopts.  For other targets this loop gets reject

Re: [PATCH] arm: Fix testism with mve/ivopts-3.c testcase

2024-08-01 Thread Christophe Lyon
On 8/1/24 12:02, Andre Vieira (lists) wrote: On 01/08/2024 10:09, Christophe Lyon wrote: It seems your attachment contains only the commit message but lacks the actual patch? I blame lack of coffee... Thanks. The patch LGTM. It seems patchwork didn't recognize it, so Lina

Re: [PATCH] arm: Fix testism with mve/ivopts-3.c testcase

2024-08-02 Thread Christophe Lyon
On 8/1/24 14:54, Christophe Lyon wrote: On 8/1/24 12:02, Andre Vieira (lists) wrote: On 01/08/2024 10:09, Christophe Lyon wrote: It seems your attachment contains only the commit message but lacks the actual patch? I blame lack of coffee... Thanks. The patch LGTM.  It seems

<    1   2   3   4   5   6   7   8   9   10   >