Re: [gofrontend-dev] Re: Go patch committed: Intrinsify runtime/internal/atomic functions

2019-05-22 Thread Cherry Zhang via gcc-patches
Jim, thank you for the fix! The patch looks good to me. Maybe we should also apply this to __atomic_add_fetch_4 and __atomic_add_fetch_8? Thanks, Cherry On Tue, May 21, 2019 at 11:25 PM Jim Wilson wrote: > On Sun, May 19, 2019 at 5:22 AM Andreas Schwab > wrote: > > ../../../libgo/go/runtime/

Re: libgo patch committed: Cheaper context switch on x86_64

2019-06-03 Thread Cherry Zhang via gcc-patches
On Mon, Jun 3, 2019 at 12:00 PM Jakub Jelinek wrote: > On Mon, Jun 03, 2019 at 05:51:26PM +0200, Thomas Schwinge wrote: > > Hi! > > > > On Fri, 31 May 2019 10:56:43 -0700, Ian Lance Taylor > wrote: > > > This libgo patch by Cherry Zhang implements cheaper goroutine context > > > switches on x86_

Re: [gofrontend-dev] Re: libgo patch committed: Add precise stack scan support

2018-12-07 Thread Cherry Zhang via gcc-patches
Sorry about the breakage. Thanks for the patch. On Fri, Dec 7, 2018 at 9:23 AM Ian Lance Taylor wrote: > On Fri, Dec 7, 2018 at 2:07 AM Rainer Orth > wrote: > > > > > This libgo patch by Cherry Zhang adds support for precise stack > > > scanning to the Go runtime. This uses per-function stack

Re: [gofrontend-dev] Re: libgo patch committed: Add precise stack scan support

2018-12-10 Thread Cherry Zhang via gcc-patches
On Mon, Dec 10, 2018 at 1:41 AM Matthias Klose wrote: > On 06.12.18 00:09, Ian Lance Taylor wrote: > > This libgo patch by Cherry Zhang adds support for precise stack > > scanning to the Go runtime. This uses per-function stack maps stored > > in the exception tables in the language-specific dat

Re: [gofrontend-dev] Re: libgo patch committed: Add precise stack scan support

2018-12-11 Thread Cherry Zhang via gcc-patches
On Tue, Dec 11, 2018 at 3:51 PM Ian Lance Taylor wrote: > On Tue, Dec 11, 2018 at 6:52 AM Matthias Klose wrote: > > > > On 10.12.18 16:54, Cherry Zhang wrote: > > > On Mon, Dec 10, 2018 at 1:41 AM Matthias Klose > wrote: > > > > > >> On 06.12.18 00:09, Ian Lance Taylor wrote: > > >>> This libgo

Re: [gofrontend-dev] Re: libgo patch committed: Add precise stack scan support

2018-12-12 Thread Cherry Zhang via gcc-patches
Thank you, Matthias! >From the log, essentially all the tests aborted. The only place the new code can cause abort on all programs that I can think of is in the runtime startup code, probestackmaps, which calls value_size, which aborts due to an unhandled case. I haven't been able to try out on an

Re: [gofrontend-dev] Re: libgo patch committed: Add precise stack scan support

2018-12-26 Thread Cherry Zhang via gcc-patches
Finally I found an ARM machine and was able to build ARM32 gcc on it, and reproduced the failures. The Go programs aborted, in parse_lsda_header, called from probestackmaps in the runtime startup. It seems that _Unwind_GetLanguageSpecificData doesn't return a valid LSDA when called from a callback