Re: [PATCH] PR other/91396 Fix static link error with -fvtable-verify

2019-08-12 Thread Caroline Tice via gcc-patches
The bootstrap succeeded. On Mon, Aug 12, 2019 at 11:51 AM Caroline Tice wrote: > > Hi, > > This patch is to fix a bug where linking with -fvtable-verify and > -static causes the linker to complain about multiple definitions of > things in the vtv_end*.o files (once from th

[PATCH] Disable vtable verification with LTO

2019-09-04 Thread Caroline Tice via gcc-patches
both options were specified and if so, tells the user that this is not supported. I have tested this by compiling hello world with each option separately and then trying to specify them both; it behaves as expected. Is this patch OK to commit? -- Caroline Tice cmt...@google.com ChangeLog entry

[PATCH] Fix testcase to not use vtable verification with LTO

2019-09-05 Thread Caroline Tice via gcc-patches
e.com ChangeLog entry (gcc/testsuite/ChangeLog): 2019-09-05 Caroline Tice PR testsuite/91670 * g++.dg/ubsan/pr59415.C: Disable LTO, since test uses -fvtable-verify, and the two options are no longer allowed together. Index: gcc/testsuite/g++.dg/ubsan/pr59

Re: [PATCH][C++] Fix ICE with VTV

2019-02-19 Thread Caroline Tice via gcc-patches
On Tue, Feb 19, 2019 at 1:57 AM Richard Biener wrote: > > Looks like vtv_generate_init_routine calls symtab->process_new_functions > () which has seriously bad effects on GCCs internal memory state. > > VTV has zero testsuite coverage it seems and besides its initial > commit didn't receive any l

[PATCH, libvtv] Fix testsuite issue.

2019-02-19 Thread Caroline Tice via gcc-patches
One of the testsuite tests for libvtv is failing due to an incorrect signature for the function "main". This patch fixes that. Testing: The libvtv testsuite failed 4 tests without this fix; it passes all of them with it. Ok to commit? -- Caroline Tice cmt...@google.com Ind

Re: [PATCH][C++] Fix ICE with VTV

2019-02-20 Thread Caroline Tice via gcc-patches
s_flto | grep GLOBAL 00601000 d _GLOBAL_OFFSET_TABLE_ But as said, that's a separate issue, which I will need to investigate (if anyone has any suggestions as to the proper way to propagate the functions through -flto, I would love to hear them). I approve Richard's patch for fixing

<    1   2