Looks good to me.
On Mon, Jul 23, 2018 at 1:50 PM David Edelsohn wrote:
>
> AIX unistd.h defines a static function without a parameter, which
> justifiably upsets C++ code when the header is included and
> referenced. This patch to fixincludes adjusts the header to declare
> the parameter as void.
On 1/25/20 9:34 AM, John David Anglin wrote:
> +/*
> + * Fix missing SCNuMAX defines in inttypes.h
> + */
> +fix = {
> +hackname = hpux_c99_inttypes4;
> +mach = "hppa*-hp-hpux11.[01]*";
> +files = inttypes.h;
> +sed = "/^[ \t]*#[ \t]*define[ \t]*SCNxMAX[ \t]*SCNx64/a
On 1/23/20 8:07 AM, Pétur Orri Ragnarsson wrote:
> Hi.
>
> I ran into a problem with fixincludes when building GCC. Your email is
> in the README file.
>
>
> When building a crosscompiling GCC 8.3.0 for powerpc the following "fix"
> is applied:
>
> $ diff /opt/pluto-targets/powerpc-rootfs/u
:-D Looks good to me. EXCEPT I think the test sample file would need a
change, too. I didn't see that.
On 6/7/24 02:37, FX Coudert wrote:
The fixincludes fix “math_exception” is being applied overly broadly, including
many targets which don’t need it, like darwin (and probably all non-glibc
t
Sure. Looks fine. Please apply to all active branches.
On Sat, Aug 31, 2013 at 4:40 PM, David Edelsohn wrote:
Does "make check" complain if a replacement/wrap fix doesn't have a test?
If so, I'll be fixing it when I have time -- towards the end of October.
(The patch I sent a few days ago ought to do it, but I've not fully tested yet.)
Anyway, looks pretty reasonable to me...
On Sat, Sep 29, 2012 at 9:45
Say, what? Anyone know what this is about?
cp ../.././gcc/../fixincludes/README-fixinc include-fixed/README
chmod a+r include-fixed/README
echo timestamp > stmp-int-hdrs
TARGET_CPU_DEFAULT="" \
HEADERS="auto-host.h ansidecl.h" DEFINES="USED_FOR_TARGET " \
/bin/sh ../.././gcc/mkconfig.sh tconfig.h
The first two patches I've applied. The remaining two are needed to fully
enable building the VxWorks flavor of GCC, but those bits affect parts
outside of fixincludes and there is some breakage somewhere.
All evidence seems to me to show fixincludes still doing its thing correctly,
but somewhere
On 01/31/16 17:03, John David Anglin wrote:
The attached hack fixes missing const from the first argument of the
declararation for vsscanf on hpux.
Approved for all active dev branches.
Looks good to me.
On Thu, Dec 5, 2013 at 2:18 AM, Richard Biener wrote:
>
> This fixes the issue in linux/vt.h that appears in SUSE SLE11 kernel
> headers which contain a pre-release variant that is broken and not
> compatible with C++ (using the 'new' keyword).
>
> The following fix simply repla
ision 204533)
+++ fixincludes/ChangeLog (working copy)
@@ -1,3 +1,9 @@
+2013-09-20 Bruce Korb
+
+ * inclhack.def: many of the headers found under "bits/" are
+ often stashed under architecture directories. Apply fixes
+ to those, too. Also, re-ordered a couple of misordered fixes.
+
2
Adjusted for Richard Biener's patch
Index: fixincludes/ChangeLog
===
--- fixincludes/ChangeLog (revision 205790)
+++ fixincludes/ChangeLog (working copy)
@@ -1,3 +1,14 @@
+2013-12-07 Bruce Korb
+
+ * inclhack.def: many o
On 12/08/13 13:06, Gerald Pfeifer wrote:
Lovely. Thank you very much!
$ svn diff
Index: configure.ac
===
--- configure.ac(revision 205790)
+++ configure.ac(working copy)
@@ -1319,10 +1319,17 @@
# Used for setting
Definitely much better. I won't apply it until the weekend, so
someone else will likely beat me to it. Thank you.
On Mon, Jul 27, 2015 at 7:36 PM, Eric Gallager wrote:
> On 7/27/15, Andreas Schwab wrote:
>> Eric Gallager writes:
>>
>>> Okay, I tried embedding "! -name CVS/ ! -name .svn/" into
On 08/15/2018 02:34 PM, Albert Chin-A-Young wrote:
Don't suppose you have time to help with:
https://gcc.gnu.org/ml/gcc/2018-08/msg00102.html
David Edelsohn is correct:
6. Now that you have the right things happening, synchronize the
$(srcdir)/tests/base directory with the $(builddir)/
On Mon, Sep 3, 2018 at 2:46 AM Olivier Hainque wrote:
> > -"#define ioctl(fd, func, arg) (ioctl)(fd, func, (int)(arg))\n";
> > +"#define ioctl(fd, func, arg) ioctl(fd, func, (int)(arg))\n";
>
> ok by me, thanks.
Shouldn't this qualify as "trivial"? :)
Ick. Looks like the right fix to me and it is clearly constrained to
vxworks platforms. Approved by me.
On Fri, May 25, 2018 at 1:58 AM, Rasmus Villemoes
wrote:
> In old VxWorks headers (5.5), ioLib.h includes unistd.h via
>
> #include "unistd.h"
>
> We copy ioLib to include-fixed, with a few fix
This looks pretty reasonable to me. I'm sure "set -- fixincl.x"
meant something two decades ago when I wrote it. :)
I should update my e-address since I can be off gnu mail for
weeks at a time nowadays. (We retired folk are less consistent
about checking project emails ...)
Oh, the assert.h thingy
On 11/06/13 15:29, Ian Lance Taylor wrote:
When fenv.h is not fixed, libquadmath does not build.
This patch works around the problem. Bootstrapped and tested on
x86_64-unknown-linux-gnu.
OK for mainline?
Hi Ian,
Yes, please.
This time, I'm on my dev box and looked at the code.
You remember
So is this the right patch?
$ svn diff inclhack.def
Index: inclhack.def
===
--- inclhack.def(revision 204533)
+++ inclhack.def(working copy)
@@ -1738,7 +1738,7 @@
versions. */
fix = {
hackname = glibc_str
e gccgo branch.
>
> Ian
>
> On Thu, Nov 7, 2013 at 10:16 AM, Ian Lance Taylor wrote:
>> On Thu, Nov 7, 2013 at 8:48 AM, Bruce Korb wrote:
>>>
>>> This time, I'm on my dev box and looked at the code.
>>> You remembered correctly that the first fil
Sure. Looks good to me. Thanks
On Fri, Nov 8, 2013 at 2:57 AM, Bernhard Reutner-Fischer
wrote:
> On 4 April 2013 22:20, Bruce Korb wrote:
>> Except as noted below, fine by me.
>>
>> On 04/04/13 12:56, Bernhard Reutner-Fischer wrote:
>>> Bootstrapped and regtest
On 10/21/14 02:30, Uros Bizjak wrote:
2014-10-21 Uros Bizjak
* inclhack.def (glibc_c99_inline_4): Add pthread.h to files.
* fixincl.x: Regenerate.
Bootstrapped and regression tested on CentOS 5.11 x86_64-linux-gnu {,-m32}.
OK for mainline?
On 10/25/14 10:40, Bruce Korb wrote:
On 10/21/14 02:30, Uros Bizjak wrote:
2014-10-21 Uros Bizjak
* inclhack.def (glibc_c99_inline_4): Add pthread.h to files.
* fixincl.x: Regenerate.
Bootstrapped and regression tested on CentOS 5.11 x86_64-linux-gnu {,-m32}.
OK for mainline
On 06/26/14 02:18, Rainer Orth wrote:
Ok for mainline?
Could you please reformat the c_fix_arg's and test-text to be "here strings" a
la:
c_fix_arg = <<- _EOS_
#undef signbit
#define signbit(x) (sizeof(x) == sizeof(float) \
\ ? __buil
Hi Rainer,
On Tue, Jul 1, 2014 at 4:22 AM, Rainer Orth
wrote:
>> It's not yet in autogen 5.9: I've diffed the fixincl.x generated with my
>> original patch and the amended one and those backslashes after the
>> leading tab are still there.
5.9 is 7 years old now. However, I just looked up the
OK. You might consider updating autogen. It seems 5.18 doesn't
handle the version test quite right. Any 5.18.n should do fine. I
guess I didn't test the version test with older versions. :)
On Thu, May 21, 2015 at 6:58 AM, David Edelsohn wrote:
> The AIX port of GCC is one of the few ports th
On 05/06/15 01:58, Michael Haubenwallner wrote:
Trivial patch for fixincludes.
A) sufficiently trivial that explicit permission ought not be required
B) it is now officially blessed that we can coalesce year lists.
Let's do so, okay?
Am 2015-05-05 um 18:03 schrieb Michael Haubenwallner:
H
Hi Rainer,
Sorry for the long delay. Anyway:
On 01/28/15 06:12, Rainer Orth wrote:
* In test_text, I had to backslash-escape the trailing \, otherwise they
were eaten up. Whether or not I do this makes no difference for the
generated fixincl.x, but only with the escaping does make check
On 01/28/15 10:13, Bruce Korb wrote:
Hi Rainer,
Sorry for the long delay. Anyway:
On 01/28/15 06:12, Rainer Orth wrote:
* In test_text, I had to backslash-escape the trailing \, otherwise they
were eaten up. Whether or not I do this makes no difference for the
generated fixincl.x, but
On 01/28/15 10:15, Bruce Korb wrote:
On 01/28/15 10:13, Bruce Korb wrote:
Hi Rainer,
Sorry for the long delay. Anyway:
On 01/28/15 06:12, Rainer Orth wrote:
* In test_text, I had to backslash-escape the trailing \, otherwise they
were eaten up. Whether or not I do this makes no
On 01/29/15 05:38, Rainer Orth wrote:
So I saw. If all else fails, we can still commit the (ugly/hard to
read) initial version, otherwise libgo won't build on Solaris before
some (quite recent) Solaris 11.2 patch, breaking bootstrap.
Having it work at all seems like a nice feature.
I think tha
On Mon, Feb 9, 2015 at 3:30 AM, Rainer Orth
wrote:
> That worked fine indeed and is considerably more readable than my
> previous version.
Excellent! Thank you.
> It produced the identical fixincl.x, passed fixincludes make check and
> Solaris 10 and 11 bootstraps.
>
> Ok for mainline now, I g
Looks good to me.
On Sun, Feb 15, 2015 at 12:49 PM, David Edelsohn wrote:
> The stdlib.h header in AIX 4.3 does not correctly declare strtof with
> a const char* argument. Users are building the latest releases of GCC
> on AIX 4.3 The appended patch from Richard G Daniel uses fixincludes
> to c
On 5/31/19 6:35 AM, Jonas Jelten wrote:
> This code snippet of mingw's stdio.h:
>
>
> #ifdef _WIN64
> _CRTIMP FILE *__cdecl __iob_func(void);
> #define _iob __iob_func()
> #else
> [.]
> #if (!defined(NO_OLDNAMES) || defined(__GNUC__))
> __MINGW_EXTENSION typedef __int64 fpos_t;
> #define
On 5/31/19 12:15 PM, Jonathan Wakely wrote:
>> Alright, thanks for the hint. I was just following the instructions in
>> gcc-9.1.0/fixincludes/README:
>>
>> """
>> Please also send relevant information to gcc-b...@gcc.gnu.org,
>> gcc-patches@gcc.gnu.org and,
>> please, to me: bk...@gnu.org.
>> """
Index: fixincludes/fixincl.tpl
===
--- fixincludes/fixincl.tpl (revision 239193)
+++ fixincludes/fixincl.tpl (working copy)
@@ -1,7 +1,7 @@
[= AutoGen5 Template -*- Mode: C -*-
x=fixincl.x =]
[=
- (if (version-compar
Looks good to me.
On Sat, Aug 13, 2016 at 9:55 AM, John David Anglin wrote:
> Currently, trunk fails to boot fortran on hpux because of the following error:
>
> /xxx/gnu/gcc/objdir/./prev-gcc/xg++ -B/xxx/gnu/gcc/objdir/./prev-gcc/
> -B/opt/gnu64/gcc/gcc-7/hppa64-hp-hpux11.00/bin/ -nostdinc++
>
BTW, OK by me :) Now that I'm retired, it is starting to look like
less time for this stuff... ;)
On Thu, Jun 9, 2016 at 10:25 AM, David Edelsohn wrote:
> Index: inclhack.def
> ===
> --- inclhack.def(revision 237258)
> +++
*I* would certainly argue that. I do occasionally shut down the
internet and go on vacation :). Looks good to me, not being a Solaris
person anymore.
BTW, tiny notational/formatting thing: the '<<-' "here text" marker says to
strip leading tabs on each line. In other words, the following can b
I will be unable to look at this for a couple of weeks, so I leave
this to others to look at.
On Wed, Apr 12, 2017 at 8:58 AM, Yvan Roux wrote:
> Hi,
>
> On 20 February 2017 at 18:53, Bruce Korb wrote:
>> On 02/18/17 01:01, Bernd Edlinger wrote:
>>> On 02/18/17 00:37, B
On 02/06/17 10:44, Bernd Edlinger wrote:
> I tested this change with different arm-linux-gnueabihf cross
> compilers, and verified that mkheaders still works on the host system.
>
> Bootstrapped and reg-tested on x86_64-pc-linux-gnu.
> Is it OK for trunk?
As long as you certify that this is corre
On 02/18/17 01:01, Bernd Edlinger wrote:
> On 02/18/17 00:37, Bruce Korb wrote:
>> On 02/06/17 10:44, Bernd Edlinger wrote:
>>> I tested this change with different arm-linux-gnueabihf cross
>>> compilers, and verified that mkheaders still works on the host system.
&
On 03/13/17 15:02, Gerald Pfeifer wrote:
> On Mon, 13 Mar 2017, Joseph Myers wrote:
> I am currently translating GCC into German. During that, I noticed that
> in some places the term "zero character" means '\0'. The official term
> though is "null character", as per the C standard.
>>>
I usually try to catch emails with "fixincludes" in the title.
Can I please get a copy of the original patch? Thanks.
On 09/29/16 11:44, Jeff Law wrote:
On 09/22/2016 11:26 PM, Tadek Kijkowski wrote:
The fixincl executable uses system function to call applyfix or to
direcly patch a header file
OK, I found it. Looks like my MUA is getting too aggressive with its filtering.
What Jeff said, plus I would prefer the tail end looking like:
+
+#else
+
+#define system_with_shell system // normal call
+
+#endif /* defined(__MINGW32__) */
and modifying the call to use "system_with_shell".
The p
Hi Tadek,
Looks good to me. Thank you.
Clear to send (push).
I'm curious about this. In the process of developing a code analysis
tool, I found some GCC code that was, basically:
switch (v) {
case 0:
if (e) {
do_something();
} else {
case 1:
do_something_else();
}
}
Does this patch mean that the above got fixed? I mean, if you're
going to f
> On Mon, Jul 11, 2016 at 01:36:02PM -0700, Bruce Korb wrote:
> [[putrid code deleted]]
>> Does this patch mean that the above got fixed? I mean, if you're
>> going to fret over linguistic tags to make falling through explicit,
>> it would seem the above code is pr
On Wed, Jul 13, 2016 at 11:39 AM, Marek Polacek wrote:
> Most likely what you saw was in cxx_pretty_printer::declaration_specifiers.
I only saw it once and, of course, it was once too often. ;)
If you fix it, it would sooth my sensibilities as the fixincludes maintainer,
making mine a small voice
Actually, it occurs to me:
On Wed, Jul 13, 2016 at 11:23 AM, Marek Polacek wrote:
> My current implementation warns here, but the warning can be suppressed
> by adding /* FALLTHRU */ or [...]
that the traditional "lint-ean" spelling is "/* FALLTHROUGH */", so
why would the abbrev be accepted and
Looks good to me...
On Thu, Aug 13, 2015 at 10:33 AM, David Edelsohn wrote:
> AIX stdio.h header includes code specific for C++ that looks like:
>
> extern "C" {
> #ifdef __cplusplus
> #ifdef ferror
> #undef ferror
> inline int ferror(FILE * _p)
> {
> return ((_p)->_flag & _IOERR);
> }
>
On 11/03/16 07:11, Rainer Orth wrote:
Ok for mainline now, and for backports to the gcc-6 and gcc-5 branches
after some soak time?
Yes, please. Thanks.
On Fri, Nov 11, 2016 at 3:18 AM, Mike Stump wrote:
>
> No objections from me.
>
Or me. Thanks!
I think restoring bootstrap is likely a good thing.
On Fri, Nov 18, 2016 at 2:45 AM, Rainer Orth
wrote:
>
> I guess this is ok for mainline now to restore bootstrap?
On Fri, Nov 18, 2016 at 9:42 AM, Mike Stump wrote:
> On Nov 18, 2016, at 2:45 AM, Rainer Orth
> wrote:
>> So the current suggestion is to combine my fixincludes patch and Jack's
>> patch to disable use if !__BLOCKS__.
>
>> I guess this is ok for mainline now to restore bootstrap?
>
> I think we
I missed the patch because the thread got too long. Also, I trust you
after all these years. :)
On Mon, Nov 21, 2016 at 1:48 AM, Rainer Orth
wrote:
> Hi Jonathan,
>
>>>Ok for mainline now and the backports after some soak time?
>>
>> Yes, the libstdc++ parts are OK, thanks.
>
> I assume Bruce is
>> This is the first time I've touched the "fixincludes" directory;
>> is this the correct way to make a change here?
Well, I'd like to see it -- especially since it's your first.
Please send to this gmail account or wait until I get my GNU email this weekend.
Thanks!
>> Successfully bootstrapped
On 12/05/14 12:32, Jeff Law wrote:1
fixincludes/ChangeLog:
PR other/63613
* inclhack.def (dejagnu_h_make_inline_functions_static): New fix.
* fixincl.x: Regenerate.
* tests/base/dejagnu.h: New.
OK.
No, actually not.
+fix = {
+hackname = dejagnu_h_make_inline_functions_stat
On 12/14/14 14:07, Uros Bizjak wrote:
Hello Bruce!
I have posted a small fixincludes patch [1] that fixes a warning
during the fixincludes build,
Please apply. However, I'm sure it is not "the last remaining warning"
since new warnings get invented. :)
Thank you - Bruce
2014-12-09 Uros Biz
===
--- fixincludes/ChangeLog (revision 218991)
+++ fixincludes/ChangeLog (working copy)
@@ -1,9 +1,20 @@
+2013-12-07 Bruce Korb
+
+ * fixincludes/fixincl.tpl: add handling for "sum" selection
+ criteria and clean up layout
+ * f
Hi Robert,
On Thu, Nov 1, 2012 at 6:35 AM, rbmj wrote:
> and now my patches will build on top of
> trunk. Bruce, can you give steps on how to reproduce the error you
> reported?
rm -rf gcc-bld gcc-ins
cp -l gcc-svn gcc-bld
pfx=$PWD/gcc-ins
cd gcc-bld
./configure --enable-languages=c,c++ --p
Index: gcc/gcov-io.c
===
--- gcc/gcov-io.c (revision 193123)
+++ gcc/gcov-io.c (working copy)
@@ -92,7 +92,8 @@
{
/* Read-only mode - acquire a read-lock. */
s_flock.l_type = F_RDLCK;
- fd = open (name, O_RDONL
Hi David,
Looks good to me, but for a small nit:
On Tue, Apr 30, 2013 at 7:40 AM, David Edelsohn wrote:
> +c_fix_arg = "#ifndef NULL\n"
> + "#ifdef __cplusplus\n"
> + "#ifdef __GNUG__\n"
> + "#define NULL\t__null\n"
> + "#else\t /* ! __
Hi,
On Tue, Apr 30, 2013 at 9:42 AM, David Edelsohn wrote:
> I coped c_fix_arg from openbsd_null_definition fix. I don't know if
> two different formats for similar fixes would be confusing, but I do
> not have a problem using the EOF version.
I haven't reviewed all patches and I don't always ra
On 05/16/13 06:41, Rainer Orth wrote:
Work is going on to incorporate all applicable fixincludes fixes into
the Solaris headers proper. One fix is currently problematic since it
uses an G++-internal macro (__GXX_EXPERIMENTAL_CXX0X__) where libstdc++
already switched to testing __cplusplus. The
Index: ChangeLog
===
--- ChangeLog (revision 200737)
+++ ChangeLog (working copy)
@@ -1,3 +1,7 @@
+2013-07-06 Bruce Korb
+
+ * inclhack.def (cdef_cplusplus): removed, per Bug 51776
+
2013-05-23 Alexander Ivchenko
prefer that the hacks get inserted
alphabetically. So, actually, there are a few small complaints.
$ fgrep -i fixincludes ../MAINTAINERS
fixincludes Bruce Korb bk...@gnu.org
The patch looks pretty reasonable, but I think someone else
should verify the obsolescence.
Hi,
On Mon, Jul 8, 2013 at 5:05 AM, Alexander Ivchenko wrote:
> Hi Bruce,
>
> That was my original letter:
>>Hi,
>>
>>Could you please take a look at the attached fixinclude patch
>>that addresses the problem:
>>
>>" We have test fail for gcc.dg/cpp/trad/include.c on Android. The
>>reason for th
On Mon, Jul 8, 2013 at 11:42 AM, Alexander Ivchenko wrote:
>> It sounds like it is better to fix the system headers instead. Via a
>> fixincludes for older headers and have the android folks fix them for
>> newer releases.
>
> Would that count for verifing? :)
:) Indeed. I confess I didn't look
On Mon, Jul 29, 2013 at 6:22 AM, Andrew Haley wrote:
> There should be a better diagnostic.
If you remember, the start of this thread was:
> Why is it that configure worked but stubs-32.h was not found?
That is the correct thing to do. The reply, basically, was:
It's too hard.
OK, fine,
Except as noted below, fine by me.
On 04/04/13 12:56, Bernhard Reutner-Fischer wrote:
> Bootstrapped and regtested on x86_64-unknown-linux-gnu and
> x86_64-mine-linux-uclibc without regressions, ok for trunk?
>
> fixincludes/ChangeLog:
>
> 2013-04-04 Bernhard Reutner-Fischer
>
> Makefi
On Sun, Jan 26, 2014 at 9:38 PM, Hans-Peter Nilsson wrote:
> On Sun, 8 Dec 2013, Bruce Korb wrote:
>> On 12/08/13 13:06, Gerald Pfeifer wrote:
>> > Lovely. Thank you very much!
>
> (Looks like nobody replied to this and it isn't committed.)
> No, flex isn't
On 01/27/14 18:20, Hans-Peter Nilsson wrote:
You'd need some additional conditions. There might be the
additional issue that any "lex" is expected to work too, not
just "flex".
It isn't committed 'cuz nobody said, "Okay."
I do wish either someone would say, "Okay." or come up with something
th
In retrospect, it occurs to me that a "am-i-ready-to-build.sh" script
in the contrib directory might be useful, too.
Hi,
On Tue, Aug 5, 2014 at 4:35 AM, Alexander Ivchenko wrote:
>> Testing for *android* is less than ideal, because of the possibility of
>> configuring a *-linux* toolchain to have multilibs using various different
>> C libraries (with -mandroid being used to select the Android multilib).
>> So,
Hi,
On Tue, Aug 5, 2014 at 10:36 AM, enh wrote:
> you can see the current version of bionic's stdio.h here:
>
> https://android.googlesource.com/platform/bionic/+/master/libc/include/stdio.h
>
> i'm happy to add any string to the header file that makes things
> easier. if you want 'x-gcc-no-fixin
ood to me.
On Tue, Aug 5, 2014 at 5:09 PM, enh wrote:
> does https://android-review.googlesource.com/103445 look okay?
>
> On Tue, Aug 5, 2014 at 12:01 PM, Bruce Korb wrote:
>> Hi,
>>
>> On Tue, Aug 5, 2014 at 10:36 AM, enh wrote:
>>> you can see the curre
Hi,
On Wed, Aug 6, 2014 at 4:51 AM, Alexander Ivchenko wrote:
> We still have to remove fix for compiler.h:
Correct. Thank you.
> Bruce, I think I formally have to ask for your approval again :)
I don't think so. You've selected one of the changes we wrote about,
so "With one of the two cha
On 04/16/14 04:16, Rainer Orth wrote:
I've already verified that trunk fails to build no sparc-sun-solaris2.9
and i386-pc-solaris2.9. Bootstraps on {i386,sparc}-*-solaris2.{10,11}
(and x86_64-unknown-linux-gnu for good measure) are in progress. I'll
verify that there are no unexpected fixinclud
On 12/30/12 01:42, Paolo Bonzini wrote:
> Not my territory anymore, but it looks much better! CCing Bruce.
Hi Alexandre,
Long time. It's no wonder you've forgotten this little world! :)
Anyway, please make the expressions more readable and strip
out the generated text from the review message.
On 01/06/13 12:12, Alexandre Oliva wrote:
> On Dec 30, 2012, Bruce Korb wrote:
>
>> On 12/30/12 01:42, Paolo Bonzini wrote:
>>> Not my territory anymore, but it looks much better! CCing Bruce.
>
>> Long time. It's no wonder you've forgotten this li
On Mon, Jan 7, 2013 at 11:49 AM, Richard Sandiford
wrote:
>> I think a patch for each directory will need posting separately for review
>> of such things as whether any imported / generated files are mistakenly
>> changed.
>
> So fixincludes/ separate from gcc/, and every library separate? OK.
S
HI,
On Mon, Jan 7, 2013 at 12:21 PM, Richard Sandiford
wrote:
> It was just a question of whether to submit the fixincludes/ and gcc/
> parts as one patch (as I'd originally done) or as two separate patches.
> Two separate patches probably makes more sense and I think is what
> Joseph was suggest
Hi,
On Mon, Jan 14, 2013 at 12:42 AM, Richard Biener wrote:
>
> fixincludes mixes common declarations (in fixlib.h) and non-common
> decls (where they are defined) for verbose_level and fixinc_mode.
> XCode on Mountain Lion doesn't like this and its linker (rightfully)
> complains.
It is not rig
On 02/03/13 02:19, Richard Sandiford wrote:
> Not exactly the most exciting patches, and certainly not worth more than
> one ping, but:
>
> fixincludes copyright
> http://gcc.gnu.org/ml/gcc-patches/2013-01/msg00442.html
You missed the file header. Why bother with dual update issues?
> --- m
On 02/03/13 09:42, Richard Sandiford wrote:
>> You missed the file header.
>
> That was deliberately in patch 2 though.
OK.
>> Why bother with dual update issues?
>
> Well, the point is that patch 2 is scripted.
OK:
> echo "$copyright" | sed 's/(C) 2002-/(C) /'
and now you print the right da
On Mon, Feb 4, 2013 at 11:55 AM, Ben Elliston wrote:
> On Mon, Feb 04, 2013 at 06:59:38PM +, Richard Sandiford wrote:
>> These days the guideline encourage updating all files, even ones
>> that haven't changed, so I was hoping we could do that gcc-wide.
>
> If that is what the guidelines say,
On Mon, Nov 7, 2011 at 12:59 PM, David Edelsohn wrote:
> Okay?
Well, okay, but I'd prefer one fix something like the following (and I confess
I've not had any test time...) because it looks simpler to me:
/*
* pthread.h on AIX defines PTHREAD_ONCE_INIT without enough braces.
* Rewrite the de
Hi David,
On Tue, Nov 8, 2011 at 10:20 AM, David Edelsohn wrote:
>>> Okay?
>>
>> Well, okay, but
>
> Also, there are other fixincludes fixes for missing braces that
> directly add the braces, not a wrapper. They are not multi-line
> macros, but there is a precedent on the style of solution.
On 08/22/12 17:05, rbmj wrote:
Hello Everyone,
I have ten patches which are approved or obvious but waiting on commit
The include fixing stuff looks fine to me.
However I think it might be simpler to tweak mkfixinc.sh to
sed '/if test -s .{MACRO_LIST}/s/$/ && false/' \
${srcdir}/fixin
On 08/24/12 11:50, rbmj wrote:
On 8/22/2012 8:52 PM, Bruce Korb wrote:
However I think it might be simpler to tweak mkfixinc.sh to
sed '/if test -s .{MACRO_LIST}/s/$/ && false/' \
${srcdir}/fixinc.in > ${target}
for vxworks rather than all that configury rigmarole.
Hi Robert,
If you are going to defer, then:
On Fri, Aug 24, 2012 at 1:20 PM, rbmj wrote:
> diff --git a/fixincludes/fixinc.in b/fixincludes/fixinc.in
> index e73aed9..de7be35 100755
> --- a/fixincludes/fixinc.in
> +++ b/fixincludes/fixinc.in
> @@ -128,6 +128,18 @@ fi
>
> # # # # # # # # # # # #
Hi Robert,
On Thu, Aug 30, 2012 at 6:30 AM, rbmj wrote:
>> Done, and patch is attached.
>>
>
> OK. make install doesn't seem to like it as much as I do. It complains
> because it tries to install macro_list and can't find it. Proposed
> solutions:
>
> 2. Change line to read test -f ${MACRO_LIS
On 09/09/12 08:54, rbmj wrote:
> Just because I *love* bothering everyone with emails...
I don't mind, as long as you don't expect me to do anything
until I'm certain you've stabilized the patch ;)
I'm glad you rolled it up into one patch, because I was
eventually going to ask you to do that. Tha
Hi,
On Mon, Sep 10, 2012 at 10:48 AM, rbmj wrote:
> On the other hand, I've read this on the website:
>
>> Don't mix together changes made for different reasons. Send them
>> individually. Ideally, each change you send should be impossible to
>> subdivide into
>
> parts that we might want to con
>From my part, I'm willing to push the patch, but I need confirmation
from Paolo and Nathan
because some of it affects code outside of my authority.
On Thu, Sep 20, 2012 at 7:02 PM, rbmj wrote:
> Ping? Just did a full pull and rebuild today and everything still works :)
>
> Robert Mason
"Huh?" Sorry. Don't know what else to say:
Per: http://gcc.gnu.org/wiki/GitMirror
$ git svn init -Ttrunk --prefix=origin/ svn+ssh://gcc.gnu.org/svn/gcc
Network connection closed unexpectedly: Unable to connect to a repository at \
URL 'svn+ssh://gcc.gnu.org/svn/gcc': To better debug SSH conn
On 09/22/12 12:49, Bruce Korb wrote:
> "Huh?" Sorry. Don't know what else to say:
Similar results using straight up svn:
$ bash contrib/gcc_update
Updating SVN tree
svn: E155036: Please see the 'svn upgrade' command
svn: E155036: Working copy '/u/gnu/pr
Hi Gaby,
On 09/22/12 13:07, Gabriel Dos Reis wrote:
>> SVN is behaving unexpectedly. Help, please?
>
> Have you upgraded your system or SVN recently?
Not deliberately. :) Switched openSuSE releases (12.2 now).
> If yes, you need to issue the command
>
> $ svn upgrade
It's been crunchin
1 - 100 of 141 matches
Mail list logo
