Re: [patch][PR/42955] Don't install $(target)/bin/gcc, gfortran, etc.

2013-08-22 Thread Brooks Moses
Ping? On 08/08/2013 02:10 PM, Brooks Moses wrote: As discussed in PR/42955, when GCC is built as a cross-compiler, it will install "gcc", "g++", "c++", and "gfortran" binaries in $(target)/bin, as well as installing the $target-gcc and so forth in bin.

Re: [patch][PR/42955] Don't install $(target)/bin/gcc, gfortran, etc.

2013-09-03 Thread Brooks Moses
Ping^2? On 08/22/2013 02:00 PM, Brooks Moses wrote: Ping? On 08/08/2013 02:10 PM, Brooks Moses wrote: As discussed in PR/42955, when GCC is built as a cross-compiler, it will install "gcc", "g++", "c++", and "gfortran" binaries in $(target)/bin, as w

[patch, bz #58312] Fix libssp handling of vsnprintf for cross-compilers

2013-09-03 Thread Brooks Moses
seems relatively innocuous. Jakub, I'm cc'ing you in hopes that you're a reasonably appropriate person to review this. Ok for trunk? Thanks, - Brooks ---- 2013-09-03 Brooks Moses * configure.ac: Replace runtime vsnprintf check with

Re: [patch, bz #58312] Fix libssp handling of vsnprintf for cross-compilers

2013-09-04 Thread Brooks Moses
On Wed, Sep 4, 2013 at 12:01 AM, Jakub Jelinek wrote: > That looks wrong, the test was intentionally looking for badly implemented > vsnprintf, see > http://www.gnu.org/software/gnulib/manual/html_node/snprintf.html > "This function does not return a byte count as specified in C99 on some > platfo

Re: [patch][PR/42955] Don't install $(target)/bin/gcc, gfortran, etc.

2013-09-11 Thread Brooks Moses
On Tue, Sep 3, 2013 at 9:32 AM, Brooks Moses wrote: > Ping^2? > > On 08/22/2013 02:00 PM, Brooks Moses wrote: >> Ping? >> >> On 08/08/2013 02:10 PM, Brooks Moses wrote: >>> As discussed in PR/42955, when GCC is built as a cross-compiler, it >>> will ins

Re: [patch][PR/42955] Don't install $(target)/bin/gcc, gfortran, etc.

2013-09-12 Thread Brooks Moses
On Thu, Sep 12, 2013 at 8:42 AM, Joseph S. Myers wrote: > On Wed, 11 Sep 2013, Brooks Moses wrote: >> Joseph, I'd been cc'ing you on this because it's driver-related and I >> didn't find a more-obvious reviewer. Is there someone else I should >> be ask

Re: [patch][PR/42955] Don't install $(target)/bin/gcc, gfortran, etc.

2013-09-12 Thread Brooks Moses
On Thu, Sep 12, 2013 at 11:19 AM, DJ Delorie wrote: > The patch is OK with me from a build machinery point of view. Thanks, DJ. Based on that and Joseph's comments elsewhere that removing these binaries is the right thing to do, I've committed the patch. At Ian Taylor's suggestion, I also confi

[google, patch] Google-local version of fix for PR58312, libssp cross-compiling

2013-09-20 Thread Brooks Moses
Diego - In http://gcc.gnu.org/ml/gcc-patches/2013-09/msg00174.html I proposed a patch to fix PR58312, which is that libssp when cross-compiled assumes that vnsprintf is broken [1]. This is causing our libssp.so to be missing some symbols that are referenced by some pre-existing binaries. The pro

[google, patch] Update powerpc64le xfails file.

2013-09-23 Thread Brooks Moses
This patch updates the powerpc64le xfails file on the google/gcc-4_8 branch to reflect two new failures caused by the addition of a new vectorization testcase. Committed as obvious. - Brooks 2013-09-23_powerpc64le-xfails.diff Description: Binary data

[patch] Fix altivec-7.C testsuite failure due to vector name mangling.

2013-10-11 Thread Brooks Moses
with versions 1, 2, and 3 it also emits duplicate symbols with the old mangling. Ok to commit? (An alternate approach would be to force -mabi-version=2, and check for the presence of both sets of symbols. That seems overkill to me, but I can alter the test to do that if desired.) Thanks, - Brooks

Re: [patch, Google, committed] update powerpc32 xfail file.

2013-10-11 Thread Brooks Moses
On Fri, Oct 11, 2013 at 4:59 PM, Brooks Moses wrote: > I committed a patch to update the xfail file for our 32-bit Power > build configuration. As with the others, this ends up being a > significant reorganization, so the diff is less interesting than the > revised file. Thus, I

[libiberty][PATCH] Avoid zero-length VLAs.

2016-06-13 Thread Brooks Moses
libiberty/ChangeLog --- a/libiberty/ChangeLog +++ b/libiberty/ChangeLog @@ -1,3 +1,8 @@ +2016-06-12 Brooks Moses + + * cp-demangle.c (cplus_demangle_print_callback): Avoid zero-length + VLAs. + 2016-05-31 Alan Modra * xmemdup.c (xmemdup): Use xmalloc rather

Re: [libiberty][PATCH] Avoid zero-length VLAs.

2016-07-11 Thread Brooks Moses
Ping? (I suspect I should have added a libiberty maintainer to cc in the first place.) On Mon, Jun 13, 2016 at 9:05 AM, Brooks Moses wrote: > Zero-length variable-length-arrays are not allowed in standard C99, > and perhaps more importantly, they cause ASAN to complain. (See, > e.

Re: [libiberty][PATCH] Avoid zero-length VLAs.

2016-07-11 Thread Brooks Moses
On Mon, Jul 11, 2016 at 4:27 PM, Ian Lance Taylor wrote: > On Mon, Jul 11, 2016 at 1:05 PM, Brooks Moses wrote: >> Ping? > > This is fine, but please add a comment explaining why the code avoids > 0-length VLAs. Thanks. Thanks! Committed as r238233. This is t

[patch] Update email, status in MAINTAINERS

2013-04-30 Thread Brooks Moses
rtran reviewer to the "Write After Approval" section. Committed. Index: ChangeLog === --- ChangeLog (revision 198467) +++ ChangeLog (working copy) @@ -1,3 +1,8 @@ +2013-04-30 Brooks Moses + + * MAINTAINERS: Update

[patch] Fix parsing bug in validate_patches.py

2013-05-31 Thread Brooks Moses
levant summary line in the DejaGnu output is ignored. This patch fixes the problem: If an entire line is a valid summary line, we don't try to split it. Ok to commit? - Brooks 2013-05-31 Brooks Moses * validate_failures.py: Don't split already-valid summary line

Re: [patch] Fix parsing bug in validate_patches.py

2013-06-05 Thread Brooks Moses
On 06/04/2013 03:57 PM, Diego Novillo wrote: OK with this predicate factored into a predicate function (maybe SummaryLineHasAttributes?) Thanks! Once I dove into that, I ended up doing a bit more refactoring; it really makes sense to pull the whole line-splitting into a separate function alo

Add more info to google/gcc-4_8 powerpc64 xfails file.

2013-07-22 Thread Brooks Moses
Diego - The attached patch adds a little more analysis info to the powerpc64 xfails file. Ok to commit? Thanks, - Brooks 2013-07-22_xfail-more-info.diff Description: Binary data

[patch, google-branches] Update and simplify GRTE spec files.

2013-07-31 Thread Brooks Moses
Diego - The attached patch corrects the fact that we were not picking up the GRTE-specific spec files in our non-x86 GCC builds, and incidentially simplifies the logic for these spec files since they do not appear to be changing from one GRTE version to another. * gcc/configs/linux-grtev2.h: Remo

[patch][google] Update libtool.m4 in google/gcc-4_8 branch.

2013-08-07 Thread Brooks Moses
A not-yet-reviewed libtool patch is needed for powerpc64le shared-library support: http://lists.gnu.org/archive/html/libtool-patches/2013-06/msg1.html (See also http://lists.gnu.org/archive/html/libtool-patches/2013-07/msg1.html) This patch merges that change into the google/gcc-4_8 branc

[patch][PR/42955] Don't install $(target)/bin/gcc, gfortran, etc.

2013-08-08 Thread Brooks Moses
tran are still present. Ok to commit? - Brooks 2013-08-08 Brooks Moses PR driver/42955 * Makefile.in: Do not install driver binaries in $(target)/bin. PR driver/42955 * Make-lang.in: Do not install driver binaries in $(target)/bin. 2013-08-08_remove-target-gcc-bins.diff Description: Binary data

[patch, google] Update powerpc64le xfails file.

2013-08-12 Thread Brooks Moses
One of the Fortran failures in the powerpc64le xfail file I committed to the Google 4.8 branch last week is no longer failing. This patch removes it from the xfails file. Committed as obvious. - Brooks 2013-08-12_xfail-fixup.diff Description: Binary data

[patch, google] Update powerpc64 xfail file.

2013-08-16 Thread Brooks Moses
I fixed the bits in our DejaGNU powerpc64 board file to transfer profile output back to the build system from the remote target, which means that a bunch of test failures now go away, and we uncover a small handful of new ones. This patch updates the xfail file accordingly. Committed as obvious.

[patch] Add missing generated file to contrib/gcc_update list.

2014-01-31 Thread Brooks Moses
copy) @@ -1,3 +1,7 @@ +2014-01-31 Brooks Moses + + * gcc_update (files_and_dependencies): Add aarch64-tune.md. + 2013-10-21 Mike Stump * gcc_update (configure): Update to handle svn 1.8.1. Index: contrib/gcc_update