Re: [PATCH] PR52665 do not let .ident confuse assembler scan tests

2023-05-31 Thread Bernhard Reutner-Fischer via Gcc-patches
On Wed, 5 Sep 2018 17:32:04 +0200 Bernhard Reutner-Fischer wrote: > On Tue, 21 Jun 2016 at 00:19, Jeff Law wrote: > > > > On 06/18/2016 01:31 PM, Bernhard Reutner-Fischer wrote: > > > gcc/testsuite/ChangeLog > > > > > > 2016-06-18 Bernhard Reutner-Fischer > > > > > > PR testsuite/526

Re: [PATCH v4] tree-ssa-sink: Improve code sinking pass

2023-05-31 Thread Bernhard Reutner-Fischer via Gcc-patches
Hi! On Wed, 31 May 2023 12:31:35 +0530 Ajit Agarwal via Gcc-patches wrote: > Hello All: > > This patch improves code sinking pass to sink statements before call to reduce > register pressure. > Review comments are incorporated. > > For example : > > void bar(); > int j; > void foo(int a, int

Re: [PATCH] jump: Change return type of predicate functions from int to bool

2023-05-31 Thread Bernhard Reutner-Fischer via Gcc-patches
On Wed, 31 May 2023 09:40:24 +0200 Uros Bizjak via Gcc-patches wrote: > On Wed, May 31, 2023 at 9:17 AM Richard Biener > wrote: > > Do we have a diagnostic that would point out places we > > assign the bool result to an integer variable? Do we want > > to change those places as well (did you i

Re: PATCH v5 4/4] ree: Improve ree pass for rs6000 target using defined ABI interfaces.

2023-05-31 Thread Bernhard Reutner-Fischer via Gcc-patches
On Thu, 1 Jun 2023 10:53:02 +0530 Ajit Agarwal via Gcc-patches wrote: > Hello All: > > This new version of patch 4 use improve ree pass for rs6000 target using > defined ABI interfaces. > Bootstrapped and regtested on power64-linux-gnu. > > Review comments incorporated. Not a review: /scratc

Re: [PATCH v5] tree-ssa-sink: Improve code sinking pass

2023-06-01 Thread Bernhard Reutner-Fischer via Gcc-patches
On 1 June 2023 09:20:08 CEST, Ajit Agarwal wrote: >Hello All: > >This patch improves code sinking pass to sink statements before call to reduce >register pressure. >Review comments are incorporated. Hi Ajit! I had two comments for v4 that you did not address in v5 or followed up. thanks,

Re: [PATCH 04/14] c++: use _P() defines from tree.h

2023-06-01 Thread Bernhard Reutner-Fischer via Gcc-patches
On Thu, 1 Jun 2023 11:24:06 -0400 Patrick Palka wrote: > On Sat, May 13, 2023 at 7:26 PM Bernhard Reutner-Fischer via > Gcc-patches wrote: > > diff --git a/gcc/cp/tree.cc b/gcc/cp/tree.cc > > index 131b212ff73..19dfb3ed782 100644 > > --- a/gcc/cp/tree.cc > > +++ b

Re: [PATCH 04/14] c++: use _P() defines from tree.h

2023-06-01 Thread Bernhard Reutner-Fischer via Gcc-patches
Hi David, Patrick, On Thu, 1 Jun 2023 18:33:46 +0200 Bernhard Reutner-Fischer wrote: > On Thu, 1 Jun 2023 11:24:06 -0400 > Patrick Palka wrote: > > > On Sat, May 13, 2023 at 7:26 PM Bernhard Reutner-Fischer via > > Gcc-patches wrote: > > > > diff --git

Re: [PATCH] libatomic: x86_64: Always try ifunc

2023-06-03 Thread Bernhard Reutner-Fischer via Gcc-patches
On 3 June 2023 13:25:32 CEST, Xi Ruoyao via Gcc-patches wrote: >There seems no good way to check if the CPU is Intel or AMD from >the built-in macros (maybe we can check every known model like __skylake, >__bdver2, ..., but it will be very error-prune and require an update >whenever we add the s

Re: [PATCH] libatomic: x86_64: Always try ifunc

2023-06-03 Thread Bernhard Reutner-Fischer via Gcc-patches
On 3 June 2023 15:46:02 CEST, Xi Ruoyao wrote: >Unfortunately __builtin_cpu_is performs CPU detection on runtime, not >compile time. Right, you were talking about configure, sorry.

Re: Splitting up 27_io/basic_istream/ignore/wchar_t/94749.cc (takes too long)

2023-06-09 Thread Bernhard Reutner-Fischer via Gcc-patches
On 9 June 2023 19:18:45 CEST, Mike Stump via Gcc-patches wrote: > simulation ports. Maybe a 20-100x speedup? If you want to go this way I'd > say do it in python at the bottom as it would be nice to switch over to > python in the next 5-20 years and away from tcl. Yes, i guess we have all pon

Re: Splitting up 27_io/basic_istream/ignore/wchar_t/94749.cc (takes too long)

2023-06-12 Thread Bernhard Reutner-Fischer via Gcc-patches
On Sat, 10 Jun 2023 11:29:36 -0700 Mike Stump wrote: > On Jun 9, 2023, at 2:47 PM, Bernhard Reutner-Fischer > wrote: > > But well. Either way, what > > should we do about remote env, if there is one? If the target > > supports it, send it and skip otherwise?

Re: [i386 PATCH] A minor code clean-up: Use NULL_RTX instead of nullptr

2023-06-14 Thread Bernhard Reutner-Fischer via Gcc-patches
plonk. On 26 May 2023 10:31:51 CEST, Bernhard Reutner-Fischer wrote: >On Thu, 25 May 2023 18:58:04 +0200 >Bernhard Reutner-Fischer wrote: > >> On Wed, 24 May 2023 18:54:06 +0100 >> "Roger Sayle" wrote: >> >> > My understanding is that GCC's preferred null value for rtx is NULL_RTX >> > (and f

Re: [PATCH] ipa: Self-DCE of uses of removed call LHSs (PR 108007)

2023-06-15 Thread Bernhard Reutner-Fischer via Gcc-patches
On 13 June 2023 17:11:13 CEST, Martin Jambor wrote: >Ping. s/funtction/function/ s/runing/running/ > >Thanks,

Re: [RFC] fortran: restore array indexing for all descriptor arrays [PR102043]

2022-07-03 Thread Bernhard Reutner-Fischer via Gcc-patches
On 2 July 2022 14:47:01 CEST, Mikael Morin wrote: >Le 02/07/2022 à 13:18, Thomas Koenig a écrit : >> >> One thought: If we have to bite the bullet and break the ABI, why not go >> all the way and use the C descriptors in ISO_Fortran_binding.h as >> gfortran's native format? >> >As far as I know,

Re: [PATCH] Introduce hardbool attribute for C

2023-06-19 Thread Bernhard Reutner-Fischer via Gcc-patches
On 16 June 2023 07:35:27 CEST, Alexandre Oliva via Gcc-patches wrote: index 0..634feaed4deef --- /dev/null +++ b/gcc/testsuite/gcc.dg/hardbool-err.c @@ -0,0 +1,28 @@ +/* { dg-do compile } */ +/* { dg-options "" } */ + +typedef _Bool __attribute__ ((__hardbool__)) +hbbl; /* { dg-error

Re: [Patch, fortran] PR107900 Select type with intrinsic type inside associate causes ICE / Segmenation fault

2023-06-21 Thread Bernhard Reutner-Fischer via Gcc-patches
Hi! First of all, many thanks for the patch! If i may, i have a question concerning the chosen style in the error message and one nitpick concerning a return type though, the latter primarily prompting this reply. On Tue, 20 Jun 2023 11:54:25 +0100 Paul Richard Thomas via Fortran wrote: > diff

Re: [PATCH] Introduce hardbool attribute for C

2023-06-22 Thread Bernhard Reutner-Fischer via Gcc-patches
On Wed, 21 Jun 2023 22:08:55 -0300 Alexandre Oliva wrote: > Thanks for the test. > > Did you mean for me to incorporate it into the patch, or do you mean to > contribute it separately, if the feature happens to be accepted? These were your tests that i quoted but i or my MUA botched to add one

Re: [PATCH V6] VECT: Apply LEN_MASK_{LOAD,STORE} into vectorizer

2023-06-23 Thread Bernhard Reutner-Fischer via Gcc-patches
On 23 June 2023 01:51:12 CEST, juzhe.zh...@rivai.ai wrote: >From: Ju-Zhe Zhong I am sorry but I somehow overlooked a trivial spot in V5. Nit which does not warrant an immediate next version, but please consider it before pushing iff approved: >+if (final_len) >+ { >+

Re: [PATCH V6] VECT: Apply LEN_MASK_{LOAD,STORE} into vectorizer

2023-06-23 Thread Bernhard Reutner-Fischer via Gcc-patches
On 23 June 2023 10:03:45 CEST, Richard Sandiford wrote: >> Fuse the block below into the one above as the condition seems to be >> identical? > >Yeah, true, but I think the idea is that the code above “Arguments are >ready” is calculating argument values, and the code after it is creating >code

Re: [PATCH 1/2] symtab: also change RTL decl name

2023-02-18 Thread Bernhard Reutner-Fischer via Gcc-patches
On Tue, 22 Nov 2022 12:54:01 +0100 Jan Hubicka wrote: > > > I am not quite sure how safe this is. We generally produce DECL_RTL > > > when we produce assembly file. So if DECL_RTL is set then we probably > > > already output the original function name and it is too late to change > > > it. >

[PATCH][stage1] Remove conditionals around free()

2023-03-01 Thread Bernhard Reutner-Fischer via Gcc-patches
Hi! Mere cosmetics. - if (foo != NULL) free (foo); With the caveat that coccinelle ruins replacement whitespace or i'm uneducated enough to be unable to _not_ run the diff through sed -e 's/^+\([[:space:]]*\)free(/+\1free (/' at least. If anybody knows how to improve replacement whitespace,

Re: [PATCH][stage1] Remove conditionals around free()

2023-03-01 Thread Bernhard Reutner-Fischer via Gcc-patches
On Wed, 1 Mar 2023 22:28:56 +0100 Bernhard Reutner-Fischer wrote: > Remarks: > 1) We should do this in if-conversion (?) on our own. >I suppose. Independently of -fdelete-null-pointer-checks and iff we can prove that ptr was NULL when passed to free(ptr) then we can elide the call, of course

Re: [PATCH][stage1] Remove conditionals around free()

2023-03-01 Thread Bernhard Reutner-Fischer via Gcc-patches
On Wed, 1 Mar 2023 22:58:59 +0100 Bernhard Reutner-Fischer wrote: > On Wed, 1 Mar 2023 22:28:56 +0100 > Bernhard Reutner-Fischer wrote: > > > Remarks: > > 1) We should do this in if-conversion (?) on our own. > >I suppose. Independently of -fdelete-null-pointer-checks > > and iff we can

Re: [PATCH 1/2] testsuite: Fix analyzer errors for newlib-errno

2023-03-01 Thread Bernhard Reutner-Fischer via Gcc-patches
On Wed, 1 Mar 2023 17:02:31 +0100 Hans-Peter Nilsson via Gcc-patches wrote: > > From: Hans-Peter Nilsson > > Date: Wed, 1 Mar 2023 16:36:46 +0100 > > > ... this is what I intend to commit later > > today, just keeping the added comment as brief as > > reasonable: > > Except I see the hook

Re: [PATCH][stage1] Remove conditionals around free()

2023-03-01 Thread Bernhard Reutner-Fischer via Gcc-patches
On Wed, 1 Mar 2023 14:59:44 -0800 Andrew Pinski wrote: > On Wed, Mar 1, 2023 at 1:31 PM Bernhard Reutner-Fischer via Fortran > wrote: > > > > Hi! > > > > Mere cosmetics. > > > > - if (foo != NULL) > > free (foo); > > > > With the caveat that coccinelle ruins replacement whitespace or i'm > >

Re: [PATCH, gfortran] Escalate failure when Hollerith constant to real conversion fails [PR103628]

2023-03-01 Thread Bernhard Reutner-Fischer via Gcc-patches
On Wed, 1 Mar 2023 10:40:15 +0100 Tobias Burnus wrote: > Hi, > > Please CC fortran@gcc for Fortran patches. > > --- a/gcc/fortran/target-memory.cc > > +++ b/gcc/fortran/target-memory.cc > > @@ -417,10 +417,13 @@ gfc_interpret_float (int kind, unsigned char *buffer, > > size_t buffer_size, > >

Re: [PATCH, gfortran] Escalate failure when Hollerith constant to real conversion fails [PR103628]

2023-03-01 Thread Bernhard Reutner-Fischer via Gcc-patches
On Wed, 1 Mar 2023 07:39:40 -0800 Steve Kargl via Gcc-patches wrote: > In fact, Hollerith should be hidden behind a -fallow-hollerith > option and added to -std=legacy. While i'd be all for that, in my mind this will block off literally all consultants and quite some scientists unless we error o

Re: [PATCH 1/2] testsuite: Fix analyzer errors for newlib-errno

2023-03-01 Thread Bernhard Reutner-Fischer via Gcc-patches
On Thu, 2 Mar 2023 00:54:33 +0100 Hans-Peter Nilsson wrote: > > Date: Thu, 2 Mar 2023 00:23:36 +0100 > > From: Bernhard Reutner-Fischer > > > On Wed, 1 Mar 2023 17:02:31 +0100 > > Hans-Peter Nilsson via Gcc-patches wrote: > > > > > > From: Hans-Peter Nilsson > > > > Date: Wed, 1 Mar 2023

Re: [PATCH][stage1] Remove conditionals around free()

2023-03-03 Thread Bernhard Reutner-Fischer via Gcc-patches
On 2 March 2023 02:23:10 CET, Jerry D wrote: >On 3/1/23 4:07 PM, Steve Kargl via Fortran wrote: >> On Wed, Mar 01, 2023 at 10:28:56PM +0100, Bernhard Reutner-Fischer via >> Fortran wrote: >>> libgfortran/caf/single.c |6 ++ >>> libgfortran/io/async.c |6 ++ >>> libgf

Re: [PATCH] [RFC] RAII auto_mpfr and autp_mpz

2023-03-07 Thread Bernhard Reutner-Fischer via Gcc-patches
On Mon, 6 Mar 2023 11:29:30 + (UTC) Richard Biener via Gcc-patches wrote: > On Mon, 6 Mar 2023, Jakub Jelinek wrote: > > > On Mon, Mar 06, 2023 at 11:01:18AM +, Richard Biener wrote: > > > + auto_mpfr &operator=(const auto_mpfr &) = delete; > > > + auto_mpz &operator=(const auto_mpz

Re: [PATCH] RISC-V: Add fault first load C/C++ support

2023-03-08 Thread Bernhard Reutner-Fischer via Gcc-patches
On 7 March 2023 07:21:23 CET, juzhe.zh...@rivai.ai wrote: >From: Ju-Zhe Zhong > >+class vleff : public function_base >+{ >+public: >+ unsigned int call_properties (const function_instance &) const override >+ { >+return CP_READ_MEMORY | CP_WRITE_CSR; >+ } >+ >+ gimple *fold (gimple_folder

Re: [PATCH] docs: Fix double 'See' in zero-length-bounds docs.

2023-03-11 Thread Bernhard Reutner-Fischer via Gcc-patches
On 11 March 2023 18:33:46 CET, Sean Bright via Gcc-patches wrote: >Hi, > >This fixes a minor issue where the zero-length-bound docs read "See See >Zero Length." > >gcc/ChangeLog: >    * doc/invoke.texi (Warning Options): Remove errant 'See' >    before @xref. >--- > gcc/doc/invoke.texi | 2 +- > 1

Re: [PATCH] docs: Fix double 'See' in zero-length-bounds docs.

2023-03-12 Thread Bernhard Reutner-Fischer via Gcc-patches
On 12 March 2023 03:47:08 CET, Sean Bright via Gcc-patches wrote: >On 3/11/2023 6:39 PM, Bernhard Reutner-Fischer wrote: >> On 11 March 2023 18:33:46 CET, Sean Bright via Gcc-patches >> wrote: >>> Hi, >>> >>> This fixes a minor issue where the zero-length-bound docs read "See See >>> Zero Lengt

Re: [PATCH take #3] match.pd: Simplify popcount/parity of bswap/rotate.

2023-05-10 Thread Bernhard Reutner-Fischer via Gcc-patches
Hi Roger! On 10 May 2023 16:46:10 CEST, Roger Sayle wrote: Just a nit: +/* { dg-final { scan-tree-dump-times "bswap" 0 "optimized" } } */ Can you please use scan-tree-dump-not instead? thanks,

[PATCH v2] Fortran: Narrow return types [PR78798]

2023-05-10 Thread Bernhard Reutner-Fischer via Gcc-patches
From: Bernhard Reutner-Fischer gcc/fortran/ChangeLog: PR fortran/78798 * array.cc (compare_bounds): Use narrower return type. (gfc_compare_array_spec): Likewise. (is_constant_element): Likewise. (gfc_constant_ac): Likewise. * check.cc (dim_rank_che

[PATCH 1/2] Fortran: dump-parse-tree attribs: fix unbalanced braces [PR109624]

2023-05-10 Thread Bernhard Reutner-Fischer via Gcc-patches
From: Bernhard Reutner-Fischer gcc/fortran/ChangeLog: PR fortran/109624 * dump-parse-tree.cc (debug): New function for gfc_namespace. (gfc_debug_code): Delete forward declaration. (show_attr): Make sure to print balanced braces. --- (gdb) call debug(gfc_current_n

[PATCH 2/2] Fortran: dump-parse-tree: Mark debug functions with DEBUG_FUNCTION

2023-05-10 Thread Bernhard Reutner-Fischer via Gcc-patches
From: Bernhard Reutner-Fischer gcc/fortran/ChangeLog: * dump-parse-tree.cc (gfc_debug_expr): Remove forward declaration. (debug): Add DEBUG_FUNCTION. (show_code_node): Remove erroneous whitespace. --- Regression tested on x86_64-linux, OK for trunk? --- gcc/fortran/dump

Re: [PATCH 1/2] Fortran: dump-parse-tree attribs: fix unbalanced braces [PR109624]

2023-05-10 Thread Bernhard Reutner-Fischer via Gcc-patches
[re-adding the lists, i hope you don't mind] On Wed, 10 May 2023 18:52:54 +0200 Thomas Koenig wrote: > Hi Bernhard, > > both patches look good to me. Pushed as r14-664-g39f7c0963a9c00 and r14-665-gbdc10c2bfaceb3 Thanks! > > No user impact, so they should have the lowest possible impact :-) >

Re: [PATCH v2 4/7] fortran: use grep instead of fgrep

2023-05-10 Thread Bernhard Reutner-Fischer via Gcc-patches
On Mon, 27 Jun 2022 14:10:36 +0800 Xi Ruoyao wrote: > fgrep has been deprecated in favor of grep -F for a long time, and the > next grep release (3.8 or 4.0) will print a warning of fgrep is used. > Stop using fgrep so we won't see the warning. > > We can't hard code grep -F here or it may break

RE: [PATCH v3] Var-Tracking: Typedef pointer_mux as decl_or_value

2023-05-10 Thread Bernhard Reutner-Fischer via Gcc-patches
On 11 May 2023 04:30:16 CEST, "Li, Pan2 via Gcc-patches" wrote: >../../gcc/var-tracking.cc:3233:28: error: no match for 'operator!=' (operand >types are 'rtx' {aka 'rtx_def*'} and 'decl_or_value' {aka >'pointer_mux'}). Wouldn't you usually declare operator!= by !(left == right) ? thanks,

Re: [PATCH] Machine_Mode: Extend machine_mode from 8 to 16 bits

2023-05-12 Thread Bernhard Reutner-Fischer via Gcc-patches
On 12 May 2023 08:49:53 CEST, Richard Biener via Gcc-patches wrote: >> gcc/ChangeLog: >> >> * combine.cc (struct reg_stat_type): Extended machine mode to 16 bits. >> * cse.cc (struct qty_table_elem): Ditto. >> (struct table_elt): Ditto. >> (struct set): Ditto. >> * geno

Re: [PATCH] ipa: Self-DCE of uses of removed call LHSs (PR 108007)

2023-05-12 Thread Bernhard Reutner-Fischer via Gcc-patches
On 12 May 2023 14:45:14 CEST, Martin Jambor wrote: >gcc/ChangeLog: > >2023-05-11 Martin Jambor > > PR ipa/108007 > * cgraph.h (cgraph_edge): Add a parameter to > redirect_call_stmt_to_callee. > * ipa-param-manipulation.h (ipa_param_adjustments): Added a > paramete

[PATCH 02/14] analyzer: use _P() defines from tree.h

2023-05-13 Thread Bernhard Reutner-Fischer via Gcc-patches
From: Bernhard Reutner-Fischer gcc/analyzer/ChangeLog: * region-model-manager.cc (get_code_for_cast): Use _P defines from tree.h. (region_model_manager::get_or_create_cast): Ditto. (region_model_manager::get_region_for_global): Ditto. * region-model.cc (re

[PATCH 07/14] d: use _P() defines from tree.h

2023-05-13 Thread Bernhard Reutner-Fischer via Gcc-patches
From: Bernhard Reutner-Fischer gcc/d/ChangeLog: * d-codegen.cc (underlying_complex_expr): Use _P defines from tree.h. * d-convert.cc (convert): Ditto. (convert_for_rvalue): Ditto. --- gcc/d/d-codegen.cc | 2 +- gcc/d/d-convert.cc | 9 - 2 files changed, 5 inserti

[PATCH 10/14] c: use _P() defines from tree.h

2023-05-13 Thread Bernhard Reutner-Fischer via Gcc-patches
From: Bernhard Reutner-Fischer gcc/c-family/ChangeLog: * c-ada-spec.cc (has_static_fields): Use _P() defines from tree.h. (dump_ada_declaration): Ditto. (dump_ada_structure): Ditto. * c-common.cc (unsafe_conversion_p): Ditto. (shorten_compare): Ditto.

[PATCH 13/14] omp: use _P() defines from tree.h

2023-05-13 Thread Bernhard Reutner-Fischer via Gcc-patches
From: Bernhard Reutner-Fischer gcc/ChangeLog: * omp-low.cc (scan_sharing_clauses): Use _P() defines from tree.h. (lower_reduction_clauses): Ditto. (lower_send_clauses): Ditto. (lower_omp_task_reductions): Ditto. * omp-oacc-neuter-broadcast.cc (install_var_

[PATCH 12/14] go: use _P() defines from tree.h

2023-05-13 Thread Bernhard Reutner-Fischer via Gcc-patches
From: Bernhard Reutner-Fischer gcc/go/ChangeLog: * go-gcc.cc (Gcc_backend::fill_in_array): Use _P() defines from tree.h. (Gcc_backend::named_type): Ditto. (Gcc_backend::convert_expression): Ditto. (operator_to_tree_code): Ditto. (Gcc_backend::init_statemen

[PATCH 11/14] objc: use _P() defines from tree.h

2023-05-13 Thread Bernhard Reutner-Fischer via Gcc-patches
From: Bernhard Reutner-Fischer gcc/objc/ChangeLog: * objc-act.cc (objc_volatilize_decl): Use _P() defines from tree.h. (objc_is_global_reference_p): Ditto. (objc_generate_write_barrier): Ditto. (objc_gimplify_property_ref): Ditto. * objc-next-runtime-abi-0

[PATCH 05/14] m2: use _P() defines from tree.h

2023-05-13 Thread Bernhard Reutner-Fischer via Gcc-patches
From: Bernhard Reutner-Fischer gcc/m2/ChangeLog: * gm2-gcc/m2builtins.cc (doradix): Use _P defines from tree.h. (doplaces): Ditto. (doexponentmin): Ditto. (doexponentmax): Ditto. (dolarge): Ditto. (dosmall): Ditto. (dogUnderflow): Ditto.

[PATCH 08/14] fortran: use _P() defines from tree.h

2023-05-13 Thread Bernhard Reutner-Fischer via Gcc-patches
From: Bernhard Reutner-Fischer gcc/fortran/ChangeLog: * trans-array.cc (is_pointer_array): Use _P() defines from tree.h. (gfc_conv_scalarized_array_ref): Ditto. (gfc_conv_array_ref): Ditto. * trans-decl.cc (gfc_finish_decl): Ditto. (gfc_get_symbol_decl): D

[PATCH 03/14] gcc/config/*: use _P() defines from tree.h

2023-05-13 Thread Bernhard Reutner-Fischer via Gcc-patches
From: Bernhard Reutner-Fischer gcc/ChangeLog: * config/aarch64/aarch64.cc (aarch64_short_vector_p): Use _P defines from tree.h. (aarch64_mangle_type): Ditto. * config/alpha/alpha.cc (alpha_in_small_data_p): Ditto. (alpha_gimplify_va_arg_1): Ditto.

[PATCH 04/14] c++: use _P() defines from tree.h

2023-05-13 Thread Bernhard Reutner-Fischer via Gcc-patches
From: Bernhard Reutner-Fischer gcc/cp/ChangeLog: * call.cc (promoted_arithmetic_type_p): Use _P defines from tree.h. (build_conditional_expr): Ditto. (convert_like_internal): Ditto. (convert_arg_to_ellipsis): Ditto. (build_over_call): Ditto. (compa

[PATCH 01/14] ada: use _P() defines from tree.h

2023-05-13 Thread Bernhard Reutner-Fischer via Gcc-patches
From: Bernhard Reutner-Fischer gcc/ada/ChangeLog: * gcc-interface/decl.cc (gnat_to_gnu_entity): Use _P defines from tree.h. (constructor_address_p): Ditto. (elaborate_expression_1): Ditto. * gcc-interface/trans.cc (Identifier_to_gnu): Ditto. (is_nr

[PATCH 09/14] rust: use _P() defines from tree.h

2023-05-13 Thread Bernhard Reutner-Fischer via Gcc-patches
From: Bernhard Reutner-Fischer gcc/rust/ChangeLog: * backend/rust-compile-expr.cc (CompileExpr::type_cast_expression): Use _P() defines from tree.h * backend/rust-tree.cc (build_cplus_array_type): Ditto. * backend/rust-tree.h (ARITHMETIC_TYPE_P): Ditto. (g

[PATCH 00/14] use _P() defines from tree.h

2023-05-13 Thread Bernhard Reutner-Fischer via Gcc-patches
From: Bernhard Reutner-Fischer Dear maintainers I propose the following mechanical change to use the defines in tree.h. (Common convention is to use the defines as per tree.h, which is what we keep telling people.) Exceptions applied to the generator here: NULL_TREE # we want to retain "NULL"

[PATCH 14/14] gcc: use _P() defines from tree.h

2023-05-13 Thread Bernhard Reutner-Fischer via Gcc-patches
From: Bernhard Reutner-Fischer gcc/ChangeLog: * alias.cc (ref_all_alias_ptr_type_p): Use _P() defines from tree.h. * attribs.cc (diag_attr_exclusions): Ditto. (decl_attributes): Ditto. (build_type_attribute_qual_variant): Ditto. * builtins.cc (fold_builtin

[PATCH 06/14] lto: use _P() defines from tree.h

2023-05-13 Thread Bernhard Reutner-Fischer via Gcc-patches
From: Bernhard Reutner-Fischer gcc/ChangeLog: * lto-streamer-in.cc (lto_input_var_decl_ref): Use _P defines from tree.h. (lto_read_body_or_constructor): Ditto. * lto-streamer-out.cc (tree_is_indexable): Ditto. (lto_output_var_decl_ref): Ditto. (DFS

Re: [PATCH v2] Fortran: Narrow return types [PR78798]

2023-05-14 Thread Bernhard Reutner-Fischer via Gcc-patches
On Sun, 14 May 2023 15:04:15 +0200 Thomas Koenig wrote: > On 14.05.23 14:27, Mikael Morin wrote: > > > > (...) > >> @@ -2098,7 +2098,7 @@ ref_same_as_full_array (gfc_ref *full_ref, > >> gfc_ref *ref) > >>   there is some kind of overlap. > >>   0 : array references are identical o

Re: Re: [PATCH] RISC-V: Add rounding mode operand for fixed-point patterns

2023-05-15 Thread Bernhard Reutner-Fischer via Gcc-patches
On 15 May 2023 10:25:30 CEST, "juzhe.zh...@rivai.ai" wrote: >Address comments. s/VXRM_RENUM/VXRM_REGNUM/g thanks,

Re: [PATCH] Add auto-resizing capability to irange's [PR109695]

2023-05-15 Thread Bernhard Reutner-Fischer via Gcc-patches
On Mon, 15 May 2023 12:35:23 +0200 Aldy Hernandez via Gcc-patches wrote: > +// For resizable ranges, resize the range up to HARD_MAX_RANGES if the > +// NEEDED pairs is greater than the current capacity of the range. > + > +inline void > +irange::maybe_resize (int needed) > +{ > + if (!m_resizab

Re: [PATCH 1/3] gcc: Fix nonportable shell syntax in "test" and "[" commands [PR105831]

2023-05-18 Thread Bernhard Reutner-Fischer via Gcc-patches
On 18 May 2023 14:56:45 CEST, Jonathan Wakely via Gcc-patches wrote: >From: Michael B��uerle > >POSIX sh does not support the == for string comparisons, use = instead. > >gcc/ChangeLog: > > PR bootstrap/105831 > >diff --git a/gcc/configure.ac b/gcc/configure.ac >index 075424669c9..cc8dd9

Re: [PATCH 08/14] fortran: use _P() defines from tree.h

2023-05-18 Thread Bernhard Reutner-Fischer via Gcc-patches
On Sun, 14 May 2023 15:10:12 +0200 Mikael Morin wrote: > Le 14/05/2023 à 01:23, Bernhard Reutner-Fischer via Gcc-patches a écrit : > > From: Bernhard Reutner-Fischer > > > > gcc/fortran/ChangeLog: > > > > * trans-array.cc (is_pointer_arr

Re: [PATCH v2] Fortran: Narrow return types [PR78798]

2023-05-18 Thread Bernhard Reutner-Fischer via Gcc-patches
On Sun, 14 May 2023 14:27:42 +0200 Mikael Morin wrote: > Le 10/05/2023 à 18:47, Bernhard Reutner-Fischer via Fortran a écrit : > > From: Bernhard Reutner-Fischer > > > > gcc/fortran/ChangeLog: > > > > PR fortran/78798 > > * array.cc (compare_bounds): Use narrower return type. > > (

Re: [PATCH 01/14] ada: use _P() defines from tree.h

2023-05-18 Thread Bernhard Reutner-Fischer via Gcc-patches
On Mon, 15 May 2023 12:05:10 +0200 Eric Botcazou wrote: > > && DECL_RETURN_VALUE_P (inner)) > > diff --git a/gcc/ada/gcc-interface/utils.cc b/gcc/ada/gcc-interface/utils.cc > > index 0c4f8b90c8e..460ef6f1f01 100644 > > --- a/gcc/ada/gcc-interface/utils.cc > > +++ b/gcc/ada/gcc-int

Re: [PATCH 01/14] ada: use _P() defines from tree.h

2023-05-18 Thread Bernhard Reutner-Fischer via Gcc-patches
On Sun, 14 May 2023 17:03:55 -0600 Jeff Law wrote: > On 5/13/23 17:23, Bernhard Reutner-Fischer via Gcc-patches wrote: > > From: Bernhard Reutner-Fischer > > > > gcc/ada/ChangeLog: > > > > * gcc-interface/decl.cc (gnat_to_gnu_entity): Use _P defines >

Re: [PATCH] avr: Set param_min_pagesize to 0 [PR105523]

2023-05-19 Thread Bernhard Reutner-Fischer via Gcc-patches
On 19 May 2023 07:58:48 CEST, "SenthilKumar.Selvaraj--- via Gcc-patches" wrote: Just a nit: >+static bool >+avr_addr_space_zero_address_valid (addr_space_t as ATTRIBUTE_UNUSED) >+{ >+ return flag_delete_null_pointer_checks == 0; >+} Since we are c++ nowadays, you can omit the parameter name f

Re: [PATCH 08/14] fortran: use _P() defines from tree.h

2023-05-19 Thread Bernhard Reutner-Fischer via Gcc-patches
On Thu, 18 May 2023 21:20:41 +0200 Mikael Morin wrote: > Le 18/05/2023 à 17:18, Bernhard Reutner-Fischer a écrit : > > I've fed gfortran.h into the script and found some CLASS_DATA spots, > > see attached bootstrapped and tested patch. > > Do we want to have that? > Some of it makes sense, but

Re: [V7][PATCH 1/2] Handle component_ref to a structre/union field including flexible array member [PR101832]

2023-05-19 Thread Bernhard Reutner-Fischer via Gcc-patches
On Fri, 19 May 2023 20:49:47 + Qing Zhao via Gcc-patches wrote: > GCC extension accepts the case when a struct with a flexible array member > is embedded into another struct or union (possibly recursively). Do you mean TYPE_TRAILING_FLEXARRAY()? > diff --git a/gcc/tree.h b/gcc/tree.h > inde

Re: [V7][PATCH 1/2] Handle component_ref to a structre/union field including flexible array member [PR101832]

2023-05-24 Thread Bernhard Reutner-Fischer via Gcc-patches
On 24 May 2023 16:09:21 CEST, Qing Zhao wrote: >Bernhard, > >Thanks a lot for your comments. > >> On May 19, 2023, at 7:11 PM, Bernhard Reutner-Fischer >> wrote: >> >> On Fri, 19 May 2023 20:49:47 + >> Qing Zhao via Gcc-patches wrote: >> >>> GCC extension accepts the case when a struct wi

Re: [i386 PATCH] A minor code clean-up: Use NULL_RTX instead of nullptr

2023-05-25 Thread Bernhard Reutner-Fischer via Gcc-patches
On Wed, 24 May 2023 18:54:06 +0100 "Roger Sayle" wrote: > My understanding is that GCC's preferred null value for rtx is NULL_RTX > (and for tree is NULL_TREE), and by being typed allows strict type checking, > and use with function polymorphism and template instantiation. > C++'s nullptr is pref

Re: [i386 PATCH] A minor code clean-up: Use NULL_RTX instead of nullptr

2023-05-26 Thread Bernhard Reutner-Fischer via Gcc-patches
On Thu, 25 May 2023 18:58:04 +0200 Bernhard Reutner-Fischer wrote: > On Wed, 24 May 2023 18:54:06 +0100 > "Roger Sayle" wrote: > > > My understanding is that GCC's preferred null value for rtx is NULL_RTX > > (and for tree is NULL_TREE), and by being typed allows strict type checking, > > and u

Re: gfortran.dg/PR82376.f90: Avoid matching a file-path.

2021-08-12 Thread Bernhard Reutner-Fischer via Gcc-patches
On Thu, 12 Aug 2021 00:09:21 +0200 Hans-Peter Nilsson via Fortran wrote: > I had a file-path to sources with the substring "new" in it, > and (only) this test regressed compared to results from > another build without "new" in the name. > > The test does > ! { dg-final { scan-tree-dump-times "n

Re: [PATCH] [i386] Optimize (a & b) | (c & ~b) to vpternlog instruction.

2021-08-24 Thread Bernhard Reutner-Fischer via Gcc-patches
On Tue, 24 Aug 2021 17:53:27 +0800 Hongtao Liu via Gcc-patches wrote: > On Tue, Aug 24, 2021 at 9:36 AM liuhongt wrote: > > > > Also optimize below 3 forms to vpternlog, op1, op2, op3 are > > register_operand or unary_p as (not reg) > > gcc/ChangeLog: > > > > PR target/101989 > >

Re: [PATCH] warn for integer overflow in allocation calls (PR 96838)

2020-09-16 Thread Bernhard Reutner-Fischer via Gcc-patches
On 15 September 2020 21:47:46 CEST, Martin Sebor via Gcc-patches wrote: >Overflowing the size of a dynamic allocation (e.g., malloc or VLA) >can lead to a subsequent buffer overflow corrupting the heap or >stack. The attached patch diagnoses a subset of these cases where >the overflow/wraparound

Re: [ Preprocessor ] [ Common ] Feature: Macros for identifying the wide and narrow execution string literal encoding

2020-10-09 Thread Bernhard Reutner-Fischer via Gcc-patches
On 8 October 2020 23:39:15 CEST, JeanHeyd Meneide via Gcc-patches wrote: >Dear Joseph, > >On Thu, Oct 8, 2020 at 1:36 PM Joseph Myers >wrote: >> >> This documentation doesn't seem sufficient to use the macros. Do >they >> expand to (narrow) string literals? To an unquoted sequence of >> charac

Re: [PATCH] c++: modules ICE with typename friend declaration

2022-09-16 Thread Bernhard Reutner-Fischer via Gcc-patches
On 16 September 2022 17:54:32 CEST, Patrick Palka via Gcc-patches wrote: >+++ b/gcc/testsuite/g++.dg/modules/typename-friend_a.C >@@ -0,0 +1,11 @@ >+// { dg-additional-options "-fmodules-ts" } >+export module foo; >+// { dg-module-cmi foo } >+ If that's a constant, repeating pain, you could ins

Re: [PATCH 09/10] fortran: Support clobbering of variable subreferences [PR88364]

2022-09-17 Thread Bernhard Reutner-Fischer via Gcc-patches
On 17 September 2022 21:33:22 CEST, Mikael Morin wrote: >Le 17/09/2022 à 19:03, Thomas Koenig via Fortran a écrit : >> >> Hi Mikael, >> >>> This adds support for clobbering of partial variable references, when >>> they are passed as actual argument and the associated dummy has the >>> INTENT(OUT

Re: [PATCH 09/10] fortran: Support clobbering of variable subreferences [PR88364]

2022-09-17 Thread Bernhard Reutner-Fischer via Gcc-patches
On 17 September 2022 21:50:20 CEST, Mikael Morin wrote: >Le 17/09/2022 à 21:33, Mikael Morin a écrit : >> The testcase from the patch was not specifically checking lack of >> side-effect clobbers, so I have double-checked with the following testcase, >> which should lift your concerns. >> >The

Re: [patch] libgompd: Add thread handles

2022-09-26 Thread Bernhard Reutner-Fischer via Gcc-patches
On Tue, 27 Sep 2022 03:20:51 +0200 Ahmed Sayed Mousse via Gcc-patches wrote: > diff --git a/libgomp/Makefile.am b/libgomp/Makefile.am > index 6d913a93e7f..23f5bede1bf 100644 > --- a/libgomp/Makefile.am > +++ b/libgomp/Makefile.am > @@ -94,7 +94,7 @@ libgomp_la_SOURCES = alloc.c atomic.c barrier.c

Re: c++: Add DECL_NTTP_OBJECT_P lang flag

2022-09-29 Thread Bernhard Reutner-Fischer via Gcc-patches
On Wed, 28 Sep 2022 16:44:29 -0400 Nathan Sidwell via Gcc-patches wrote: > + else if (TREE_CODE (arg) == VAR_DECL && DECL_NTTP_OBJECT_P (arg)) Cosmetics, but I think the first part of the condition could be spelled as VAR_P (arg) thanks,

Re: [PATCH] Refine ranges using relations in GORI.

2022-09-30 Thread Bernhard Reutner-Fischer via Gcc-patches
Hi Andrew! On Thu, 29 Sep 2022 18:36:53 -0400 Andrew MacLeod via Gcc-patches wrote: > diff --git a/gcc/gimple-range-gori.cc b/gcc/gimple-range-gori.cc > index 57a7e820749..b37d03cddda 100644 > --- a/gcc/gimple-range-gori.cc > +++ b/gcc/gimple-range-gori.cc > @@ -934,6 +934,115 @@ gori_compute::c

Re: [PATCH] Process unsigned overflow relations for plus and minus in range-ops.

2022-10-01 Thread Bernhard Reutner-Fischer via Gcc-patches
On Thu, 29 Sep 2022 18:38:10 -0400 Andrew MacLeod via Gcc-patches wrote: > diff --git a/gcc/range-op.cc b/gcc/range-op.cc > index 9bb04c361d0..830c64bd6b9 100644 > --- a/gcc/range-op.cc > +++ b/gcc/range-op.cc > @@ -1305,22 +1305,123 @@ operator_plus::wi_fold (irange &r, tree type, >value_ran

Re: [committed] More gimple const/copy propagation opportunities

2022-10-01 Thread Bernhard Reutner-Fischer via Gcc-patches
On Fri, 30 Sep 2022 17:32:34 -0600 Jeff Law wrote: > + /* This looks good from a CFG standpoint. Now look at the guts > + of PRED. Basically we want to verify there are no PHI nodes > + and no real statements. */ > + if (! gimple_seq_empty_p (phi_nodes (pred))) > +return false;

Re: Adding a new thread model to GCC

2022-10-01 Thread Bernhard Reutner-Fischer via Gcc-patches
On 1 October 2022 20:34:45 CEST, LIU Hao via Gcc-patches wrote: >Greetings. >The first patch is necessary because somewhere in libgfortran, `pthread_t` is >referenced. If the thread model is not `posix`, it fails to compile. One of several shortcomings mentioned already on Sun, 02 Sep 2018 15:

Re: Adding a new thread model to GCC

2022-10-02 Thread Bernhard Reutner-Fischer via Gcc-patches
On 2 October 2022 14:54:54 CEST, LIU Hao wrote: >在 2022-10-02 04:02, Bernhard Reutner-Fischer 写道: >> On 1 October 2022 20:34:45 CEST, LIU Hao via Gcc-patches >> wrote: >>> Greetings. >> >>> The first patch is necessary because somewhere in libgfortran, `pthread_t` >>> is referenced. If the thr

Re: Adding a new thread model to GCC

2022-10-04 Thread Bernhard Reutner-Fischer via Gcc-patches
On 4 October 2022 10:06:00 CEST, LIU Hao wrote: >在 2022-10-03 13:03, Bernhard Reutner-Fischer 写道: >> >> No, sorry for my brevity. >> Using __gthread_t like in your patch is correct. >> > >I see. In 'libgfortran/io/async.c' there is > > ``` >async_unit *au = u->au; >LOCK (&au->lock); >

Re: [PATCH][PUSHED] Support --compress-debug-sections for ld.mold.

2022-04-21 Thread Bernhard Reutner-Fischer via Gcc-patches
On 21 April 2022 10:18:48 CEST, "Martin Liška" wrote: >Pushed to master. >- if test "$gcc_cv_gld_major_version" -eq 2 -a "$gcc_cv_gld_minor_version" >-ge 19 -o "$gcc_cv_gld_major_version" -gt 2 \ >+ if test $ld_is_mold = yes; then >+gcc_cv_ld_compress_debug=3 >+gcc_cv_ld_compress_debug

Re: libgo patch committed: redirect mkrsysinfo.sh grep output to /dev/null

2021-11-19 Thread Bernhard Reutner-Fischer via Gcc-patches
On Fri, 28 Oct 2016 10:55:18 -0700 Ian Lance Taylor wrote: > This patch to libgo redirects the output of a grep command in > mkrsysinfo.sh to /dev/null. The output otherwise appears in the grep -q exists since at least SUSv2, fwiw. thanks, > middle of a build log, where it is harmless but conf

Re: [PATCH] Do not abort compilation when dump file is /dev/*

2021-11-19 Thread Bernhard Reutner-Fischer via Gcc-patches
On Fri, 19 Nov 2021 10:35:26 +0100 (CET) Richard Biener via Gcc-patches wrote: > On Fri, 19 Nov 2021, Alexandre Oliva wrote: > > > On Nov 18, 2021, Richard Biener wrote: > > > > > IMHO a more reasonable thing to do would be to not treat > > > -o /dev/null as a source for -dumpdir and friends

Re: [PATCH v3] Do not abort compilation when dump file is /dev/*

2021-11-19 Thread Bernhard Reutner-Fischer via Gcc-patches
On Fri, 19 Nov 2021 15:12:35 +0100 (CET) Richard Biener via Gcc-patches wrote: > On Fri, 19 Nov 2021, Giuliano Belinassi wrote: > > -It defaults to the location of the output file; options > > +It defaults to the location of the output file, unless the output > > +file is a special file like @co

Re: [PATCH] gfortran: Improve translation of POPPAR intrinsic

2021-11-20 Thread Bernhard Reutner-Fischer via Gcc-patches
Roger pinged this on gcc-patches some time ago fwiw. [The commit-hooks will likely fix or ignore s/bext/next/ in his mail-addr] On Sun, 14 Jun 2020 23:39:32 +0100 "Roger Sayle" wrote: > > > The following patch to gfortran's trans-instrinsic.c tweaks the generic that > is produced > > for po

Re: [PATCH] gfortran: Improve translation of POPPAR intrinsic

2021-11-21 Thread Bernhard Reutner-Fischer via Gcc-patches
On Sun, 21 Nov 2021 19:59:35 +0100 Harald Anlauf wrote: > Let's have a look at the tree-dump of the existing testcase: > > integer(kind=4) runtime_poppar (integer(kind=16) & restrict i) > { >integer(kind=4) res; > >{ > uint128_t D.4221; > > D.4221 = (uint128_t) *i; > res

Re: [PATCH] PR fortran/87851 - [9/10/11/12 Regression] Wrong return type for len_trim

2021-11-22 Thread Bernhard Reutner-Fischer via Gcc-patches
On Mon, 22 Nov 2021 19:17:51 +0100 Harald Anlauf via Gcc-patches wrote: > Am 21.11.21 um 12:46 schrieb Mikael Morin: > > Le 19/11/2021 à 20:47, Harald Anlauf via Fortran a écrit : > >> Dear Fortranners, > >> > >> scalariziation of the elemental intrinsic LEN_TRIM was ICEing > >> when the option

Re: Improve -fprofile-report

2021-12-03 Thread Bernhard Reutner-Fischer via Gcc-patches
On Sat, 27 Nov 2021 16:56:32 +0100 Jan Hubicka via Gcc-patches wrote: > --- a/gcc/cfghooks.h > +++ b/gcc/cfghooks.h > @@ -36,22 +36,25 @@ along with GCC; see the file COPYING3. If not see > and one CFG hook per CFG mode. */ > struct profile_record > { > - /* Likewise for a basic block's

Re: Compare guessed profile frequencies to actual profile feedback in profile dump file

2021-12-03 Thread Bernhard Reutner-Fischer via Gcc-patches
On Sun, 28 Nov 2021 19:52:08 +0100 Jan Hubicka via Gcc-patches wrote: > Basic block 136 guessed freq: 17.548 cummulative: 0.60% feedback > freq: 51.848 cummulative: 1.94% cnt: 101811269914 > diff --git a/gcc/profile.c b/gcc/profile.c > index d07002d265e..dbf42ff7b2b 100644 > -

Re: Limit inlining functions called once

2021-12-08 Thread Bernhard Reutner-Fischer via Gcc-patches
On Tue, 7 Dec 2021 16:07:01 +0100 Jan Hubicka via Gcc-patches wrote: > Hi, > as dicussed in PR ipa/103454 there are several benchmarks that regresses > for -finline-functions-called once. Runtmes: > - tramp3d with -Ofast. 31% > - exchange2 with -Ofast 11-21% > - roms O2 9%-10% > - tonto 2.5-3

Re: [PATCH 0/6] Add Intel Sierra Forest Instructions

2022-10-16 Thread Bernhard Reutner-Fischer via Gcc-patches
On 17 October 2022 03:02:22 CEST, Hongtao Liu via Gcc-patches >> >> Do you have this series as a branch somewhere that I can try on one of the >> >> like affected platforms? >> > >> > Not yet. >> > Do we have any external place to put those patches so folks from the >> > community can validate be

Re: [GCC][PATCH] arm: Add cde feature support for Cortex-M55 CPU.

2022-10-17 Thread Bernhard Reutner-Fischer via Gcc-patches
On 17 October 2022 15:29:33 CEST, Christophe Lyon via Gcc-patches wrote: >Hi Srinath, > > >On 10/10/22 10:20, Srinath Parvathaneni via Gcc-patches wrote: >> Hi, >> >> This patch adds cde feature (optional) support for Cortex-M55 CPU, please >> refer >> [1] for more details. To use this feature

Re: Adding a new thread model to GCC

2022-10-19 Thread Bernhard Reutner-Fischer via Gcc-patches
On Wed, 19 Oct 2022 at 15:56, Jonathan Yong via Gcc-patches wrote: > Just pushed to master branch. Wouldn't you want to cut down on the libs respectively refine the order of the libs, though? You've now got: +#define MCFGTHREAD_SPEC " -lmcfgthread -lkernel32 -lntdll " +#else +#define MCFGTHREAD

Re: [PATCH] RISC-V: Recognized Svinval and Svnapot extensions

2022-10-25 Thread Bernhard Reutner-Fischer via Gcc-patches
On 25 October 2022 08:17:33 CEST, Monk Chiang wrote: >gcc/ChangeLog: > >diff --git a/gcc/config/riscv/riscv-opts.h b/gcc/config/riscv/riscv-opts.h >index 55e0bc0a0e9..63ac56a8ca0 100644 >--- a/gcc/config/riscv/riscv-opts.h >+++ b/gcc/config/riscv/riscv-opts.h >@@ -162,6 +162,12 @@ enum stack_prot

  1   2   3   4   >