[PATCH 0/2] Commentary typo fixes

Two typos and remove two unneeded forward declarations for static functions in tree-tailcall.c. These patches were applied when doing a config-list.mk build and showed no negative effect. I'd usually consider them obvious but given current stage.. Ok for trunk now? Bernhard Reutner-Fisch

[PATCH 1/2] tree.h: Commentary typo fix

gcc/ChangeLog: 2015-04-01 Bernhard Reutner-Fischer * tree.h (CONVERT_EXPR_P): Commentary typo fix. Signed-off-by: Bernhard Reutner-Fischer --- gcc/tree.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/tree.h b/gcc/tree.h index 4fcc272..bedf103 100644 --- a

[PATCH 2/2] tree-tailcall: Commentary typo fix, remove fwd declaration

gcc/ChangeLog: 2015-04-01 Bernhard Reutner-Fischer * tree-tailcall.c (suitable_for_tail_opt_p, find_tail_calls): Remove unneeded forward declarations. (suitable_for_tail_call_opt_p): Commentary typo fix. Signed-off-by: Bernhard Reutner-Fischer --- gcc/tree

[PATCH] PR target/55144: bfin: fix opening glibc-c.o: No such file or directory

les. Signed-off-by: Bernhard Reutner-Fischer Cc: Bernd Schmidt Cc: Jie Zhang Signed-off-by: Bernhard Reutner-Fischer --- gcc/config.gcc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/config.gcc b/gcc/config.gcc index cb08a5c..ddbd57b 100644 --- a/gcc/config.gcc +++ b/

Re: [PATCH 1/2] tree.h: Commentary typo fix

On 8 April 2015 at 20:34, Gerald Pfeifer wrote: > On Wed, 8 Apr 2015, Bernhard Reutner-Fischer wrote: >> 2015-04-01 Bernhard Reutner-Fischer >> >> * tree.h (CONVERT_EXPR_P): Commentary typo fix. > > Go ahead. Pure comment fixes still should be fine at this p

[PATCH] mklog: Fallback to env author name and addr

contrib/ChangeLog: 2015-04-08 Bernhard Reutner-Fischer * mklog ($name, $addr): Fallback to env author settings. --- contrib/mklog | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/mklog b/contrib/mklog index f7974a7..4cad351 100755 --- a/contrib/mklog

Re: [PATCH] mklog: Fallback to env author name and addr

On 8 April 2015 at 21:45, Diego Novillo wrote: > On Wed, Apr 8, 2015 at 3:36 PM, Bernhard Reutner-Fischer > wrote: >> contrib/ChangeLog: >> >> 2015-04-08 Bernhard Reutner-Fischer >> >> * mklog ($name, $addr): Fallback to env author settings. >

Re: [PATCH, c6x] handle unk_isa in TARGET_CPU_CPP_BUILTINS

ping On 2 April 2015 at 22:49, Bernhard Reutner-Fischer wrote: > On Wed, Apr 01, 2015 at 11:37:41PM +0200, Bernhard Reutner-Fischer wrote: >>Bernd, >> >>same for c6x for unk_isa, fwiw. > > Attached. > > Ok for trunk for the c6x bits? > Ok for trunk for the bfin bits? > > thanks,

Re: [PATCH, bfin] handle BFIN_CPU_UNKNOWN in TARGET_CPU_CPP_BUILTINS

ping On 1 April 2015 at 23:34, Bernhard Reutner-Fischer wrote: > Hi, > > gcc/c-family/c-cppbuiltin.c > In file included from ./tm.h:21:0, > from > ../../../../../../home/me/src/gcc-5.0.mine/gcc/c-family/c-cppbuiltin.c:23: > ../../../../../../home/me/src/gcc-

[PATCH] PR target/55143: undefined reference to `c_default_pointer_mode'

gcc/ChangeLog: 2015-04-08 Bernhard Reutner-Fischer PR target/55143 * c/c-tree.h (c_default_pointer_mode): Move declaration ... * c-family/c-common.h (c_default_pointer_mode): ... here. * c/c-decl.c (c_default_pointer_mode): Move definition ... * c

[PATCH] Makefile.tpl: Remove surplus whitespace

essentially s/[[:space:]]*[[:space:]];/;/g ChangeLog (attn: to src, IIRC no write-access, ask someone to commit) Ok for trunk now? 2015-04-01 Bernhard Reutner-Fischer * Makefile.tpl: Remove surplus whitespace throughout. * Makefile.in: Regenerate. Signed-off-by: Bernhard

Re: [PATCH] PR target/55143: undefined reference to `c_default_pointer_mode'

On 9 April 2015 at 21:41, Jakub Jelinek wrote: > On Thu, Apr 09, 2015 at 09:27:34PM +0200, Bernhard Reutner-Fischer wrote: >> gcc/ChangeLog: >> >> 2015-04-08 Bernhard Reutner-Fischer >> >> PR target/55143 >> * c/c-tree.h (c_default_pointer_m

[PATCH] PR target/47098 OBSD_LIB_SPEC on i686-openbsd3 missing

ase Managers or something. gcc/ChangeLog: 2015-04-10 Bernhard Reutner-Fischer PR target/47098 * config/openbsd-oldgas.h (OBSD_LIB_SPEC): Add. --- gcc/config/openbsd-oldgas.h |4 1 file changed, 4 insertions(+) diff --git a/gcc/config/openbsd-oldgas.h b/gcc/config/open

patch ping

Hi, I'd like to ask an RM or global reviewer to kindly consider the following patches preventing one or the other target in config-list.mk to build: [PATCH, bfin] handle BFIN_CPU_UNKNOWN in TARGET_CPU_CPP_BUILTINS https://gcc.gnu.org/ml/gcc-patches/2015-04/msg00034.html [PATCH, c6x] handle unk_i

Re: invert_tree_comparsion tweek for bettter inline predicates

On April 14, 2015 1:36:14 AM GMT+02:00, Jan Hubicka wrote: >Hi, >while looking on a testcase, i noticed that for simple code > > if (param > 6.0) >BB1; > else >BB2; >the inline predicates currectly determine (param > 6.0) predicate >for BB1, but they give (true) predicate to BB2 unless >

Re: [PATCH, stage1] Make parloops gate more strict

On June 14, 2015 10:55:59 AM GMT+02:00, Tom de Vries wrote: >On 13/03/15 11:36, Richard Biener wrote: >> On Fri, Mar 13, 2015 at 11:32 AM, Tom de Vries > wrote: >>> Hi, >>> >>> this patch moves a bunch of early-out tests from the parloops pass >to the >>> gate function. >>> >>> The only effect is

Re: [PATCH] Move ~X | X -> -1 folding

On June 30, 2015 10:46:21 AM GMT+02:00, Marek Polacek wrote: >--- gcc/testsuite/gcc.dg/fold-ior-2.c >+++ gcc/testsuite/gcc.dg/fold-ior-2.c >@@ -0,0 +1,47 @@ >+/* { dg-do compile } */ >+/* { dg-options "-O -fdump-tree-cddce1" } */ >+ >+int >+fn1 (int x) >+{ >+ return ~x | x; >+} >+ >+int >+fn2 (

Re: [Patch,tree-optimization]: Add new path Splitting pass on tree ssa representation

On June 30, 2015 10:16:01 AM GMT+02:00, Ajit Kumar Agarwal wrote: >All: > >The below patch added a new path Splitting optimization pass on SSA >representation. The Path Splitting optimization >Pass moves the join block of if-then-else same as loop latch to its >predecessors and get merged with th

RE: [Patch,tree-optimization]: Add new path Splitting pass on tree ssa representation

On June 30, 2015 12:38:13 PM GMT+02:00, Ajit Kumar Agarwal wrote: >>6. Added 2 tests. >>a) compilation check tests. >> b) execution tests. > >>>The 2 tests seem to be identical, so why do you have both? >>>Also, please remove cleanup-tree-dump, this is now done >automatically. > >The test

Re: [PR66726] Factor conversion out of COND_EXPR

On Sat, Jul 04, 2015 at 12:58:58PM +1000, Kugan wrote: > Please find a patch that attempt to FIX PR66726 by factoring conversion > out of COND_EXPR as explained in the PR. > > Bootstrapped and regression tested on x86-64-none-linux-gnu with no new > regressions. Is this OK for trunk? > > Thanks,

Re: [PR66726] Factor conversion out of COND_EXPR

On July 4, 2015 2:32:11 PM GMT+02:00, Kugan wrote: >On 04/07/15 18:51, Bernhard Reutner-Fischer wrote: >> On Sat, Jul 04, 2015 at 12:58:58PM +1000, Kugan wrote: >>> Please find a patch that attempt to FIX PR66726 by factoring >conversion >>> out of CO

[PATCH] fold builtin_tolower, builtin_toupper

gcc/ChangeLog 2015-07-09 Bernhard Reutner-Fischer * builtins.c (fold_builtin_tolower, fold_builtin_toupper): New static functions. (fold_builtin_1): Handle BUILT_IN_TOLOWER, BUILT_IN_TOUPPER. Signed-off-by: Bernhard Reutner-Fischer --- gcc/builtins.c | 99

Re: [PATCH] fold builtin_tolower, builtin_toupper

On 9 July 2015 at 15:46, Richard Biener wrote: > On Thu, 9 Jul 2015, Bernhard Reutner-Fischer wrote: > >> gcc/ChangeLog >> >> 2015-07-09 Bernhard Reutner-Fischer >> >> * builtins.c (fold_builtin_tolower, fold_builtin_toupper): New >>

Re: [wwwdocs] Mention ipa-ICF and auto-FDO

On 21 January 2015 at 22:58, Jan Hubicka wrote: > Hi, > these two rather noticeable features are not mentioned. > > Honza > > Index: changes.html > === > RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-5/changes.html,v > retrieving revision 1.6

Re: #pragma GCC unroll support

On January 30, 2015 5:36:16 PM GMT+01:00, Marek Polacek wrote: >On Fri, Jan 30, 2015 at 08:27:06AM -0800, Mike Stump wrote: >> > >> +static bool >> +c_parse_pragma_ivdep (c_parser *parser) >> +{ >> + c_parser_consume_pragma (parser); >> + c_parser_skip_to_pragma_eol (parser); >> + return tru

Re: [PATCH, testsuite]: Cleanup dumps

On January 31, 2015 10:53:39 AM GMT+01:00, Uros Bizjak wrote: >Hello! Reminds me of just auto-wiping dump files: https://gcc.gnu.org/ml/gcc-patches/2013-10/msg02506.html Mike, WDYT? Thanks, > >2015-01-31 Uros Bizjak > >* g++.dg/ipa/pr64146.C (dg-final): Cleanup icf ipa dump. >* gcc.targ

Re: [PATCH, testsuite]: Cleanup dumps

On January 31, 2015 9:17:57 PM GMT+01:00, Mike Stump wrote: >On Jan 31, 2015, at 11:50 AM, Bernhard Reutner-Fischer > wrote: >> On January 31, 2015 10:53:39 AM GMT+01:00, Uros Bizjak > wrote: >>> Hello! >> >> Reminds me of just auto-wiping dump files: >&g

Re: [PATCH, testsuite]: Cleanup dumps

On January 31, 2015 10:10:27 PM GMT+01:00, Bernhard Reutner-Fischer wrote: >On January 31, 2015 9:17:57 PM GMT+01:00, Mike Stump > wrote: >>On Jan 31, 2015, at 11:50 AM, Bernhard Reutner-Fischer >> wrote: >>> On January 31, 2015 10:53:39 AM GMT+01:00, Uros

[PATCH, RFC] fortran [was Re: #pragma GCC unroll support]

tches/2015-01/msg02733.html ). Just stage-1 tinkering here. Cheers, Bernhard Reutner-Fischer (1): fortran: !GCC$ unroll for DO gcc/fortran/decl.c | 38 gcc/fortran/gfortran.h | 2 ++ gcc/fortran/ma

[PATCH, v0] fortran: !GCC$ unroll for DO

fortran/ChangeLog: 2015-02-02 Bernhard Reutner-Fischer * match.h (gfc_match_gcc_unroll): New prototype. * decl.c (directive_unroll): New global variable. (gfc_match_gcc_unroll): New function. * gfortran.h (directive_unroll): New extern declaration

Re: [PATCH x86_64] Optimize access to globals in "-fpie -pie" builds with copy relocations

On February 4, 2015 11:37:01 PM GMT+01:00, "H.J. Lu" wrote: >On Wed, Feb 4, 2015 at 1:53 PM, Sriraman Tallam >wrote: >> On Wed, Feb 4, 2015 at 10:57 AM, H.J. Lu wrote: >>> On Wed, Feb 4, 2015 at 10:51 AM, Sriraman Tallam > wrote: On Wed, Feb 4, 2015 at 10:45 AM, H.J. Lu >wrote: > On W

Re: [PATCH x86_64] Optimize access to globals in "-fpie -pie" builds with copy relocations

On February 5, 2015 12:29:40 AM GMT+01:00, "H.J. Lu" wrote: >On Wed, Feb 4, 2015 at 3:10 PM, H.J. Lu wrote: >> On Wed, Feb 4, 2015 at 2:47 PM, Bernhard Reutner-Fischer >> wrote: >>> On February 4, 2015 11:37:01 PM GMT+01:00, "H.J. Lu" > wrot

Re: Strenghten aliasing_component_refs_p

On 20 May 2019 11:40:17 CEST, Richard Biener wrote: >On Sun, 19 May 2019, Jan Hubicka wrote: > >> > On Fri, 17 May 2019, Jan Hubicka wrote: >> > >> > > Hi, >> > > this patch cuts walks in aliasing_component_refs_p if the type we >look for >> > > can not fit into a given type by comparing their si

Re: Fix alias oracle stats

Hi honza, On 20 May 2019 11:38:14 CEST, Richard Biener wrote: >On Mon, 20 May 2019, Jan Hubicka wrote: > >> Hi, >> at the moment the alias stats outputs mostly 0 for res_may_alias_p >> (which is supposed to be main entry point to the alias oracle). >> I think this is because of code refactoring w

Re: [PATCH] Move VEC_PERM_EXPR folding to match.pd

On 20 May 2019 12:31:46 CEST, Richard Biener wrote: > >So the following is what I have applied. Typo in the guard? s/GCC_VEC_PERN_INDICES_H/GCC_VEC_PERM_INDICES_H/ ? I.e. not pern but perm, with an 'M' thanks, >Bootstrapped / tested on x86_64-unknown-linux-gnu. > >Richard. > >2019-05-20 Rich

Re: [PATCH][Preprocessor]patch to fix PR 90581

On 30 May 2019 18:23:43 CEST, Qing Zhao wrote: >Hi, > >PR 90581 (provide an option to adjust the maximum depth of nested >#include) >https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90581 > >is to add a new cpp option -fmax-inlcude-depth Typo inl vs inc. Why isn't this a param? Wouldn't a param ease

Re: Do not ask alias subset query when access patch can not extend

Honza, On 31 May 2019 11:44:09 CEST, Jan Hubicka wrote: >Bootstrapped/regtested x86_64-linux (all languages > * tree-ssa-alias.c (access_patch_may_continue_p): New function. > (aliasing_component_refs_p): Use it. s/patch/path/g I suspect your fingers play tricks on you on

Re: [PATCH,RFC,V2 2/3] Add CTF command line options : -gtLEVEL

On 12 June 2019 20:00:09 CEST, Indu Bhagat wrote: >-gtLEVEL is used to request CTF debug information and also to specify >how much >CTF debug information. The option name is way too generic IMO. -gctfLEVEL or some such would at least indicate its intended purpose, fwiw. thanks > >[Changes from

Re: [PATCH] Automatics in equivalence statements

On Fri, 21 Jun 2019 07:10:11 -0700 Steve Kargl wrote: > On Fri, Jun 21, 2019 at 02:31:51PM +0100, Mark Eggleston wrote: > > Currently variables with the AUTOMATIC attribute can not appear in an > > EQUIVALENCE statement. However its counterpart, STATIC, can be used in > > an EQUIVALENCE stateme

Re: [PATCH] Improve predictions for hot and cold labels ([[likely]], [[unlikely]]).

On 30 November 2018 10:47:45 CET, "Martin Liška" wrote: >Hi. > >This patch is a reaction to Jason's commit where he introduced new C++ >attributes. >First I would like to align cold/hot to __builtin_expect, so I adjusted >probability >and made the predictors first match predictors. > >Second I fix

Re: [PATCH] PR fortran/88227 -- Revenge of the BOZ

Hi Steve, I know you already committed this but please let me add a remark or two. On Sun, 28 Jul 2019 16:41:02 -0700 Steve Kargl wrote: > Index: gcc/fortran/check.c > === > --- gcc/fortran/check.c (revision 273766) > +++ gcc

Re: [PR fortran/91496] !GCC$ directives error if mistyped or unknown

On Tue, 27 Aug 2019 21:49:38 +0200 Harald Anlauf wrote: > Committed to trunk as svn revision 274966, after removing some > accidentally left-over unused variable declarations (copy&paste). > The actual committed version is attached. > > Thanks, Paul, for the quick review! > > Unless there are s

Re: [patch, fortan] PR87103 - [OOP] ICE in gfc_new_symbol() due to overlong symbol name

2018 12:35:04 PM PDT Bernhard Reutner-Fischer > wrote: > > On Wed, 5 Sep 2018 at 03:30, Jerry DeLisle wrote: > > > On 09/04/2018 10:43 AM, Bernhard Reutner-Fischer wrote: > > > > On Tue, 4 Sep 2018 at 18:43, Andrew Benson > > > > > wr

Re: [Preprocessor] small cleanups

On Wed, 28 Aug 2019 14:42:57 -0400 Nathan Sidwell wrote: >/* If opened with #import or contains #pragma once. */ > - bool once_only; > + bool once_only : 1; I'm curious why you have them as bool and not unsigned? thanks,

Re: [OG9, committed] Backport GCN expcnt patches

On 5 September 2019 18:07:25 CEST, Andrew Stubbs wrote: >I just committed the attached patch to the openacc-gcc-9-branch. + /* Store that requires input registers are not overwritten by +following instruction. */ + if ((prev_insn->age + nops_rqd) < 1 + &&

Re: [PATCH 3/5] Rewrite part of and_comparisons_1 into match.pd.

On 9 September 2019 15:41:05 CEST, "Martin Liška" wrote: >On 9/9/19 2:24 PM, Martin Liška wrote: >> Hi. >> >> The patch is about transition of and_comparisons_1 matching >> into match.pd. >> >> Patch can bootstrap on x86_64-linux-gnu and survives regression >tests. >> >> Ready to be installed?

Re: [PATCH] Come up with debug counter for store-merging.

On Wed, 18 Sep 2019 11:01:59 +0200 Richard Biener wrote: > On Wed, Sep 18, 2019 at 9:22 AM Martin Liška wrote: > > > > Hi. > > > > After I spent quite some time with PR91758, I would like > > to see a debug counter in store merging for the next time. > > > > Ready to be installed? > OK. > @@

Re: [PATCH, Fortran] Optionally suppress no-automatic overwrites recursive warning - for review

On Thu, 19 Sep 2019 17:46:29 +0200 Tobias Burnus wrote: > Hi Mark, > > On 9/19/19 3:40 PM, Mark Eggleston wrote: > > The following warning is produced when -fno-automatic and -frecursive > > are used at the same time: > > > > f951: Warning: Flag '-fno-automatic' overwrites '-frecursive' > > > >

Re: [patch, libgfortran] Bug 91593 - Implicit enum conversions in libgfortran/io/transfer.c

On 22 September 2019 22:51:46 CEST, Jerry DeLisle wrote: >Hi all, > >The attached patch eliminates several warnings by adjusting which >enumerator is >used in the subject offending code. I fixed this by adding an >enumerator at the >end of the file_mode definition. This then triggered a warning

Re: [PATCH] PR libstdc++/80538 Only call sleep for non-zero values

On 11 October 2018 23:36:15 CEST, Jonathan Wakely wrote: >But I'm assuming that systems with no usleep are probably rare, and >can live with rounding up to sleep for a full second. Well conforming implementations usually won't have usleep which was obscolencent in SUSv3 and removed from SUSv4.

Re: [PATCH] PR libstdc++/80538 Only call sleep for non-zero values

On 13 October 2018 12:56:14 CEST, Jonathan Wakely wrote: >Yes, of course. We don't even look for usleep unless nanosleep isn't >available, so I mean systems with no nanosleep *and* no usleep. Right. Wasn't obvious to me from just the patch. Sorry for the noise..

[PATCH,FORTRAN] Fix memory leak in finalization wrappers

ine.vg- still reachable: 572,278 bytes in 2,142 blocks at4.mine.vg-suppressed: 0 bytes in 0 blocks at4.mine.vg- at4.mine.vg-ERROR SUMMARY: 3 errors from 3 contexts (suppressed: 0 from 0) at4.mine.vg-ERROR SUMMARY: 3 errors from 3 contexts (suppressed: 0 from 0) gcc/fortran/ChangeLog: 201

Re: [RFC] GCC support for live-patching

On 18 October 2018 19:34:52 CEST, Qing Zhao wrote: >A. an option to control GCC's IPA optimizations to provide a safe >compilation for live-patching purpose. At the same time, provides >multiple-level control of patch code-size and run time performance >tradeoff. > >-fease-live-patching={none|

Re: Avoid unnecessarily numbered clone symbols

On 20 October 2018 00:26:15 CEST, Michael Ploujnikov wrote: >While working on >https://gcc.gnu.org/ml/gcc-patches/2018-09/msg00228.html I've >accumulated a few easy patches. +/* Return decl name IDENTIFIER with string SUFFIX appended. */ + +tree +suffixed_function_name (tree identifier, const

[PATCH,FORTRAN] Fix memory leak of gsymbol

- still reachable: 1,576,174 bytes in 2,277 blocks + still reachable: 1,576,078 bytes in 2,276 blocks suppressed: 0 bytes in 0 blocks gcc/fortran/ChangeLog: 2018-10-21 Bernhard Reutner-Fischer * parse.c (clean_up_modules): Free gsym. --- gcc/fortran/parse.c | 18

Re: [PATCH 4/6] [ARC] Add peephole rules to combine store/loads into double store/loads

On 22 October 2018 19:49:35 CEST, Andrew Burgess wrote: >* Claudiu Zissulescu [2018-10-10 11:00:14 +0300]: >> --- a/gcc/config/arc/arc.c >> +++ b/gcc/config/arc/arc.c >> @@ -10803,6 +10803,169 @@ arc_cannot_substitute_mem_equiv_p (rtx) >>return true; >> } >> >> +/* Checks whether the ope

Re: [patch, fortran] Implement FINDLOC

On Mon, 22 Oct 2018 at 23:01, Thomas Koenig wrote: > Anyway, the attached patch fixes this, plus the print *, instead > of test for return values, plus the whitespace issues mentioned > by Bernhard. Patch gzipped this time to let it go through to > gcc-patches. Thanks, The few remainin issues ar

Re: Cleanup handling of variants in ipa-devirt

On 26 October 2018 09:18:39 CEST, Jan Hubicka wrote: @@ -1094,10 +1133,15 @@ warn_types_mismatch (tree t1, tree t2, l gcc_assert (TYPE_NAME (t1) && TYPE_NAME (t2) && TREE_CODE (TYPE_NAME (t1)) == TYPE_DECL && TREE_CODE (TYPE_NAME (t2)) == TYPE_DECL); + tree n1 =

Re: Fix failure with the odr-1.C test

On 26 October 2018 09:46:52 CEST, Jan Hubicka wrote: >Hi, >@@ -1138,7 +1139,7 @@ warn_types_mismatch (tree t1, tree t2, l > if (TREE_CODE (n1) == TYPE_DECL) > n1 = DECL_NAME (n1); > if (TREE_CODE (n2) == TYPE_DECL) >- n1 = DECL_NAME (n2); >+ n2 = DECL_NAME (n2); > /* M

Re: [gofrontend-dev] Re: Go patch committed: Improve name mangling for package paths

On 26 October 2018 18:13:32 CEST, Rainer Orth wrote: >Hi Than, > >> OK, thanks again. Another fix sent: >> >> https://go-review.googlesource.com/c/gofrontend/+/145021 > >great, thanks again. While the two previous patches were enough to get >decent Solaris 11 results, on Solaris 10 all libgo te

Re: [Patch, fortran] PR40196 - [F03] [F08] Type parameter inquiry (str%len, a%kind) and Complex parts (z%re, z%im)

On Sat, 27 Oct 2018 20:03:47 +0100 Paul Richard Thomas wrote: A few nits. > + /* Pull an inquiry result out of an expression. */ > + > + static bool > + find_inquiry_ref (gfc_expr *p, gfc_expr **newp) > + { > + gfc_ref *ref; > + gfc_ref *inquiry = NULL; > + gfc_expr *tmp; > + > + tmp

Re: [patch, doc, fortran] Document FINDLOC

Hi! On Sun, 28 Oct 2018 15:13:49 +0100 Thomas König wrote: One question and some nits below. > === > --- intrinsic.texi(Revision 265569) > +++ intrinsic.texi(Arbeitskopie) > @@ -6021,8 +6022,68 @@ END PROGRAM > @ref{FGET}

Re: [fortran, patch, committed] Adjust error message

On Thu, 1 Nov 2018 13:05:39 +0100 Thomas Koenig wrote: > Hello world, > > I just adjusted the error message for BIND(C) functions which > return strings of length > 1. I just used the suggestion from > the PR. Committed as obvious and simple (although I managed > to use up three revisions to d

Re: [patch, libgfortran] PR78351 comma not terminating READ of formatted input field

On Sat, 3 Nov 2018 15:33:07 -0700 Jerry DeLisle wrote: > diff --git a/libgfortran/io/transfer.c b/libgfortran/io/transfer.c > index 31198a3cc39..0d26101cef0 100644 > --- a/libgfortran/io/transfer.c > +++ b/libgfortran/io/transfer.c > @@ -260,22 +250,80 @@ read_sf_internal (st_parameter_dt *dtp,

Re: Free TYPE_VALUES of enums

On Wed, 7 Nov 2018 14:09:24 +0100 Richard Biener wrote: > On Wed, Nov 7, 2018 at 1:34 PM Jan Hubicka wrote: > > Bootstrapped/regtested x86_64-linux, will commit it after > > lto-bootstrapping uneless there are complains. > > +/* Save some WPA->ltrans streaming by freeing enum values. */ > >

Re: [PATCH][RFC] Come up with -flive-patching master option.

On 9 November 2018 16:33:22 CET, "Martin Liška" wrote: >Hi. > >After I added 2 new options, I would like to include a new master >option. >It's minimal version which only disables optimizations that we are >aware of >and can potentially cause problems for live-patching. I think you attached the w

Re: [PATCH PR84648]Adjust loop exit conditions for loop-until-wrap cases.

On Sun, 11 Nov 2018 16:02:33 +0800 "bin.cheng" wrote: Quick observation unrelated to the real patch. I think the coding style mandates to use the type itself and not the underlying structure. I know there are alot of places from before our switch to C++ that still use enum tree_code or enum mac

Re: [PATCH 3/3] OpenACC 2.6 manual deep copy support (attach/detach)

On Sat, 10 Nov 2018 09:11:20 -0800 Julian Brown wrote: Two nits. > diff --git a/gcc/fortran/openmp.c b/gcc/fortran/openmp.c > index 6430e61..ebba7ca 100644 > --- a/gcc/fortran/openmp.c > +++ b/gcc/fortran/openmp.c > @@ -3781,9 +3805,6 @@ check_array_not_assumed (gfc_symbol *sym, locus loc, > c

Re: [PATCH] Support simd function declarations via a pre-include. (was: [PATCH][RFC]Overloading intrinsics)

On 14 November 2018 12:35:27 CET, Jakub Jelinek wrote: >> --- a/gcc/config/gnu-user.h >> +++ b/gcc/config/gnu-user.h >> @@ -170,3 +170,6 @@ see the files COPYING3 and COPYING.RUNTIME >respectively. If not, see >>LD_STATIC_OPTION " --whole-archive -llsan --no-whole-archive " \ >>LD_DYNAMI

Re: [PATCH] Support simd function declarations via a pre-include.

Hi >I'm sending version, I changed the container to hash_map that should >provide >faster look up. > >I've been testing the patch right now. In find_fortran_preinclude_file() you allocate the filename. diff --git a/gcc/fortran/scanner.c b/gcc/fortran/scanner.c index 55d6dafdb5d..4e500f88174 1006

Re: [PATCH] Support simd function declarations via a pre-include. (was: [PATCH][RFC]Overloading intrinsics)

On 15 November 2018 21:54:23 CET, Jakub Jelinek wrote: >> Can we use plain -include like in C? > >Wouldn't that be confusing whether it is included in preprocessor only >or if >it is included as a magic fortran include line at the beginning? Yes, of course. Forgot that its a cpp argument. So -f

Re: [PATCH 3/6] [og8] OpenACC 2.6 manual deep copy support (attach/detach)

On 20 November 2018 22:54:49 CET, Julian Brown wrote: > >Previously posted upstream: >https://gcc.gnu.org/ml/gcc-patches/2018-11/msg00826.html As said in https://gcc.gnu.org/ml/gcc-patches/2018-11/msg00861.html + bool array_only_p = true; + /* Disallow duplicate bare variable ref

Re: Stream TREE_TYPE of TYPE_DECLs again

Honza, One nit. On 21 November 2018 19:08:43 CET, Jan Hubicka wrote: >> >Index: ipa-devirt.c >=== >--- ipa-devirt.c (revision 266334) >+++ ipa-devirt.c (working copy) >@@ -2289,27 +2291,43 @@ dump_type_inheritance_gr

Re: [patch, libfortran] Adjust block size for libgfortran for unformatted reads

On Mon, 8 Jul 2019 09:05:04 -0700 Steve Kargl wrote: > On Mon, Jul 08, 2019 at 04:02:17PM +0300, Janne Blomqvist wrote: > > > > Good point. If you happen to have a USB stick handy, can you try the > > simple C benchmark program at > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91030#c38 ? > >

Re: Make nonoverlapping_component_refs work with duplicated main variants

On 9 July 2019 15:37:30 CEST, Richard Biener wrote: >On Tue, 9 Jul 2019, Jan Hubicka wrote: > >> Hi, >> this is updated variant I am testing. >> It documents better how function works and streamlines the checks. >> >> OK assuming it passes the tests? >> >> Honza >> >> Index: tree-ssa-alias.c >>

Re: [PATCH PR Fortran/89286] Intrinsic sign and GNU Extension

On 10 July 2019 17:52:40 CEST, Steve Kargl wrote: >On Wed, Jul 10, 2019 at 02:50:47PM +0100, Mark Eggleston wrote: >> The attached patch treats the intrinsic SIGN in the same way as MOD >and >> DIM as it has the same arguments. >> >> Tested using make -j 8 check-fortran on x86_64 >> >> Conditi

Re: [PATCH] Fix 3 generic vector lowering issues with VECTOR_BOOLEAN_TYPE_P SSA_NAMEs with scalar modes (PR tree-optimization/91157)

On 17 July 2019 09:01:36 CEST, Jakub Jelinek wrote: >Hi! > >On the following testcase we end up with a comparison (EQ_EXPR in this >case) >with unsupported vector operands, but supported result (vector boolean >type with scalar mode, i.e. the AVX512F-ish integer bitmask) and later >a VEC_COND_EXPR

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

On 19 February 2019 19:18:21 CET, Steve Kargl wrote: >On Mon, Feb 18, 2019 at 02:23:34PM +0100, Martin Liška wrote: >> >> As I installed all needed patches, I'm sending a documentation entry >> for the new functionality. >> >> Thoughts? > >See below. Ok to commit with suggested changes. > >> T

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

Marin, > >>> + > >>> +@smallexample > >>> +!GCC$ builtin (sinf) attributes simd (notinbranch) if('x86_64') > >>> +@end smallexample > >>> + > >>> +The purpose of the directive is to provide an API among the GCC > >> compiler and > >>> +the GNU C Library which would define vector implementation of

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

On 20 February 2019 10:57:29 CET, "Martin Liška" wrote: >On 2/20/19 10:52 AM, Bernhard Reutner-Fischer wrote: >> Marin, >> >>>>>> + >>>>>> +@smallexample >>>>>> +!GCC$ builtin (sinf) attributes simd (notinbra

Re: [patch, fortran] Fix PR 66089, ICE (plus wrong code) in dependency handling

On 6 March 2019 19:49:59 CET, Thomas Koenig wrote: >Hello world, > >the attached patch fixes a 7/8/9 regression where dependency checking >was for class arrays and a scalar value was mishandled when the >dependency happened in an elemental function. > >There was an ICE for the test case which is h

Re: [PATCH] Make hashtab/hash-table elt removal not fail on removing non-existent entry

On Thu, 14 Mar 2019 10:19:17 +0100 Jakub Jelinek wrote: > On Thu, Mar 14, 2019 at 09:57:27AM +0100, Richard Biener wrote: > > I'd say make it work, thus your patch below is OK. > > Ok, here is an updated patch with some self-tests coverage as well that I'll > bootstrap/regtest. I had the simp

Re: Fix a case in which the vector cost model was ignored

On 18 March 2019 10:58:53 CET, Richard Sandiford wrote: >This patch fixes a case in which we vectorised something with a >fully-predicated loop even after the cost model had rejected it. >E.g. the loop in the testcase has the costs: > > Vector inside of loop cost: 27 > Vector prologue cost: 0 >

Re: Fix a case in which the vector cost model was ignored

On Tue, 19 Mar 2019 08:47:49 + Richard Sandiford wrote: > > ... this identical condition, AFAICS? > > So this second conditions else arm should be dead, shouldn't it? > > Yeah, that's what: > > /* ??? The "if" arm is written to handle all cases; see below for what > we would do for

Re: Issue with webpage

On 7 April 2019 14:08:39 CEST, Ann Sykes wrote: >Good Afternoon! > >I’ve just been looking at your website and I came across this webpage: >http://gcc.gnu.org/ml/gcc-patches/2004-10/msg02198.html > >Unfortunately, when I click the link ‘ >http://www.cuj.com/documents/s=8011/cuj0207stroustr/,’ it r

Re: [PATCH][DOC] Define email limit for gcc-patches mailing list.

On 26 April 2019 16:08:19 CEST, Gerald Pfeifer wrote: >On Fri, 26 Apr 2019, Martin Liška wrote: >> The patch clarifies that gcc-patches mailing list allows up to 400kB >> size of an email. > >Thanks, yes. Maybe drop references to gcc-prs while at it as: https://gcc.gnu.org/ml/gcc/2017-05/msg6

Re: [RFC] Come up with is_empty for hash_{table,map,set}.

On 26 April 2019 14:07:20 CEST, Richard Biener wrote: >On Fri, Apr 26, 2019 at 11:26 AM Martin Liška wrote: >> >> Hi. >> >> We do have vec<...>::is_empty function, but not for >hash_{table,map,set}. >> Would you mind adding the function and using it? If so, I can prepare >> a complete patch that

Re: [PATCH] Prep for PR88828 fix

On 3 May 2019 18:48:09 CEST, "H.J. Lu" wrote: >On Fri, May 3, 2019 at 6:02 AM Richard Biener >wrote: >> >> >> The following refactors simplify_vector_constructor and adds >> handling of constants to it in a straight-forward way. >> >> A followup will handle the testcases posted in HJs patch. >> >

Re: [PATCH 1/2] or1k: Fix code quality for volatile memory loads

On 6 May 2019 15:16:20 CEST, Stafford Horne wrote: >Volatile memory does not match the memory_operand predicate. This >causes extra extend/mask instructions instructions when reading >from volatile memory. On OpenRISC loading volitile memory can be s/volitile/volatile/g also at least in the te

Re: [PATCH][stage1] Support profile (BB counts and edge probabilities) in GIMPLE FE.

On 7 May 2019 14:00:32 CEST, "Martin Liška" wrote: /The parameters is/s/parameters/parameter/ thanks,

Re: [PATCH] libgfortran: Use proper gthr.h API

On 25 January 2019 12:44:30 CET, Sebastian Huber wrote: >libgfortran/ > > * io/async.c (init_adv_cond): Use > __GTHREAD_COND_INIT_FUNCTION(). LGTM. Please CC the FORTRAN list for FORTRAN patches. thanks, >--- > libgfortran/io/async.c | 2 +- > 1 file changed, 1 insertion(+), 1 delet

Re: Record likely upper bounds for loops

On May 27, 2016 1:14:09 PM GMT+02:00, Jan Hubicka wrote: >+ fprintf (dump_file, "Loop likely %d iterates at most %i >times.\n", loop->num, >+ (int)likely_max_loop_iterations_int (loop)); s/Loop likely %d/Loop %d likely/ please. thanks,

Re: Fix profile updating in loop peeling

On Mon, May 30, 2016 at 02:38:40PM +0200, Jan Hubicka wrote: > Hi, > this patch fixes profile updates in loop peeling pass. First it correctly > set wont_exit which can only be set when we know the number of iterations > tested by EXIT and this number is higher than maximal number of iterations >

Re: [PATCH] Fix 416.gamess miscompare (PR71311)

On June 1, 2016 9:37:26 AM GMT+02:00, Richard Biener wrote: >> PR tree-optimization/71311 >> * genmatch.c (comparison_code_p): New predicate. TREE_CODE_CLASS (code) == tcc_comparison ? thanks,

Re: [PATCH] Fix 416.gamess miscompare (PR71311)

On June 2, 2016 9:05:36 PM GMT+02:00, Richard Biener wrote: >On June 2, 2016 7:47:19 PM GMT+02:00, Bernhard Reutner-Fischer > wrote: >>On June 1, 2016 9:37:26 AM GMT+02:00, Richard Biener >> wrote: >> >>>>PR tree-optimization/71311 >>>>

Re: [patch, avr] Fix PR67353

On June 13, 2016 5:48:43 PM GMT+02:00, Georg-Johann Lay wrote: >Pitchumani Sivanupandi schrieb: >> Hi, >> >> This patch introduces new flags for warning 'misspelled interrupt/ >> signal handler'. Flag -Wmisspelled-isr is enabled by default and it >> will warn user if the interrupt/ signal handler

Re: [DOC PATCH, i386]: Document -m80387 and -mhard-float

On Thu, Jun 16, 2016 at 07:58:59PM +0200, Uros Bizjak wrote: > Hello! > > These two options were missing from the documentation. > > 2016-06-16 Uros Bizjak > > * doc/invoke.texi (x86 Options): Document -m80387 and -mhard-float. > > Bootstrapped on x86_64-linux-gnu, committed to mainline

[PATCH] PR52665 do not let .ident confuse assembler scan tests

n a fixups-testsuite branch where it fixes several false FAILs without regressions. gcc/testsuite/ChangeLog 2016-06-18 Bernhard Reutner-Fischer PR testsuite/52665 * lib/gcc-dg.exp (gcc-dg-test-1): Iterate over _required_options. * lib/target-supports.exp (scan-assemb

Re: [PATCH] Derive interface buffers from max name length

On December 3, 2015 10:46:09 AM GMT+01:00, Janne Blomqvist wrote: >On Tue, Dec 1, 2015 at 6:51 PM, Bernhard Reutner-Fischer > wrote: >> On 1 December 2015 at 15:52, Janne Blomqvist > wrote: >>> On Tue, Dec 1, 2015 at 2:54 PM, Bernhard Reutner-Fischer >>> wrote:

Re: [PATCH] Use gfc_add_*_component defines where appropriate

Ping. On December 1, 2015 1:54:58 PM GMT+01:00, Bernhard Reutner-Fischer wrote: >A couple of places used gfc_add_component_ref(expr, "string") instead >of >the defines from gfortran.h > >Regstrapped without regressions, ok for trunk stage3 now / next stage1? > >g

<    1   2   3   4   5   6   7   8   9   10   >