Re: [PATCH] i386: Don't use frame pointer without stack access

2017-08-07 Thread Arjan van de Ven
On 8/7/2017 8:43 AM, Jakub Jelinek wrote: On Mon, Aug 07, 2017 at 08:39:24AM -0700, H.J. Lu wrote: When Linux/x86-64 kernel is compiled with -fno-omit-frame-pointer. this optimization removes more than 730 pushq %rbp movq %rsp, %rbp popq %rbp If you don't want the frame pointer, why are you c

Re: [PATCH] i386: Don't use frame pointer without stack access

2017-08-07 Thread Arjan van de Ven
On 8/7/2017 9:16 AM, Michael Matz wrote: Hi, On Mon, 7 Aug 2017, Arjan van de Ven wrote: wanting a framepointer is very nice and desired... ... but if the optimizer/ins scheduler moves instructions outside of the frame'd portion, (it does it for cases like below as well), the value is al

Re: [PATCH] i386: Don't use frame pointer without stack access

2017-08-09 Thread Arjan van de Ven
On 8/9/2017 8:04 AM, Andi Kleen wrote: I would add a new option -fforce-frame-pointer that gives the old -fno-omit-frame-pointer back, so that users relying on frame pointers everywhere have a workaround. that function should also fix the current situation where the framepointer is not useful