Re: [Fortran, Patch] (RFC, Coarray) Implement TS18508's EVENTS

2016-02-11 Thread Alessandro Fanfarillo
Dear all, in attachment the EVENT patch for gcc-5-branch directly back-ported from the trunk. Built and regtested on x86_64-pc-linux-gnu. I plan to commit this patch this evening (Feb 12th, CET). Cheers, Alessandro 2015-12-17 17:19 GMT+01:00 Alessandro Fanfarillo : > Great! Thanks. >

Re: [Fortran, Patch] (RFC, Coarray) Implement TS18508's EVENTS

2016-02-12 Thread Alessandro Fanfarillo
Committed on gcc-5-branch as rev. 233379. 2016-02-12 0:04 GMT+01:00 Alessandro Fanfarillo : > Dear all, > > in attachment the EVENT patch for gcc-5-branch directly back-ported > from the trunk. > > Built and regtested on x86_64-pc-linux-gnu. I plan to commit this > patch t

[Fortran, Patch] (Coarrays) Wrong events size

2016-02-20 Thread Alessandro Fanfarillo
nt variable be different from a lock variable when LIBCAF_SINGLE is used? The patch has been built and regtested on x86_64-pc-linux-gnu. Ok for trunk and gcc-5-branch? gcc/fortran/Changelog 2016-02-20 Alessandro Fanfarillo * trans.c (gfc_allocate_allocatable): size conversion

Re: [Fortran, Patch] (Coarrays) Wrong events size

2016-02-25 Thread Alessandro Fanfarillo
* PING * 2016-02-20 18:25 GMT+01:00 Alessandro Fanfarillo : > Dear all, > > currently, the compiler doesn't pass the right size to the > registration routine of OpenCoarrays for event variables: > > size.15 = 0; > > ev.data = (void * restrict) _gfortran_caf_registe

Re: [Fortran, Patch] (Coarrays) Wrong events size

2016-02-27 Thread Alessandro Fanfarillo
Thanks! Patch committed as revision 233779 on trunk and as revision 233780 on gcc-5-branch. 2016-02-26 19:14 GMT+01:00 Paul Richard Thomas : > Dear Alessandro, > > Seconded! I saw your ping on my phone and was going to respond. > well, now :-) > > Thanks for the patch > > Paul > > On 26 Febru

[Fortran, Patch] Passing function pointer to co_reduce

2015-07-13 Thread Alessandro Fanfarillo
; where simple_reduction is the pure function that has to be used by co_reduce. The attached patch seems to fix the issue, any comments? Regards Alessandro PS: I also attach the test case commit a12b6ce6993df109c81a32d5684b4b9f41f69ea4 Author: Alessandro Fanfarillo Date: Mon Jul 13 15:46

Re: [Fortran, Patch] Passing function pointer to co_reduce

2015-07-17 Thread Alessandro Fanfarillo
Thanks a lot! 2015-07-17 15:50 GMT+02:00 Mikael Morin : > Le 17/07/2015 11:02, Mikael Morin a écrit : >> Le 16/07/2015 16:34, Damian Rouson a écrit : >>> Alternatively, if it’s easy, please feel free to add the directives and >>> commit. >>> > >> Never mind, I'll take care of it all. >> > This is

Re: [Fortran, Patch] (RFC, Coarray) Implement TS18508's EVENTS

2015-11-25 Thread Alessandro Fanfarillo
> type(lock_type) :: LK > end type1 > type t2 > type(t1) :: a(5) > end type t2 > type t3 > type(t2) :: b(8) > end type t3 > > type(t3), save :: caf(3)[*] > > For those, I need to call _gfortran_caf_register for > caf(:)%b(:)%a(:)%ev and caf(:)%b(:)%

Re: [Fortran, Patch] (RFC, Coarray) Implement TS18508's EVENTS

2015-11-26 Thread Alessandro Fanfarillo
Hi all, in attachment the patch for tests and missing functions in libcaf_single (needed by the test suite). Built and regtested on x86_64-pc-linux-gnu. 2015-11-26 17:51 GMT+01:00 Steve Kargl : > On Wed, Nov 25, 2015 at 06:24:49PM +0100, Alessandro Fanfarillo wrote: >> Dear all,

Re: [Fortran, Patch] (RFC, Coarray) Implement TS18508's EVENTS

2015-12-02 Thread Alessandro Fanfarillo
*PING* 2015-11-26 17:51 GMT+01:00 Steve Kargl : > On Wed, Nov 25, 2015 at 06:24:49PM +0100, Alessandro Fanfarillo wrote: >> Dear all, >> >> in attachment the previous patch compatible with the current trunk. >> The patch also includes the changes introduced in the lates

Re: [Fortran, Patch] (RFC, Coarray) Implement TS18508's EVENTS

2015-12-03 Thread Alessandro Fanfarillo
Yes please. Thanks. 2015-12-02 23:00 GMT+01:00 Steve Kargl : > Committed as revision 231208. > > Alessandro, Tobias, is this a candidate for a commit to > the 5-branch when it is re-opened? > > -- > steve > > On Wed, Dec 02, 2015 at 03:16:05PM +0100, Alessandro

[Fortran, Patch] Memory sync after coarray image control statements and assignment

2015-12-06 Thread Alessandro Fanfarillo
the __sync_synchronize() after get/put and sync statements fix all the problems reported by Deepak. I do the same also for locks, critical and events. Suggestions are warmly welcome. commit 75c93d3085116748115c8f69ad5ad58f4ad9369c Author: Alessandro Fanfarillo Date: Sun Dec 6 18:50:51 2015 +0100

Re: [Fortran, Patch] Memory sync after coarray image control statements and assignment

2015-12-07 Thread Alessandro Fanfarillo
Hi, 2015-12-07 8:20 GMT+01:00 Tobias Burnus : > Always - or only with optimization? > Only with optimization. > I wonder whether using > > __asm__ __volatile__ ("":::"memory"); > > would be sufficient as it has a way lower overhead than > __sync_synchronize(). > > > That would be something like:

Re: [Fortran, Patch] Memory sync after coarray image control statements and assignment

2015-12-07 Thread Alessandro Fanfarillo
2.html > It should work as -fcoarray=lib -lcaf_single "dg-do run" test. > > Tobias commit 69e650945454491bbaf81513a1eed10b5b6b0f45 Author: Alessandro Fanfarillo Date: Mon Dec 7 15:46:10 2015 +0100 Introducing __asm__ __volatile__ (:::memory) after image control statements, s

Re: [Fortran, Patch] Memory sync after coarray image control statements and assignment

2015-12-08 Thread Alessandro Fanfarillo
right? 2015-12-08 11:01 GMT+01:00 Tobias Burnus : > Dear Alessandro, dear all, > > On Mon, Dec 07, 2015 at 03:48:17PM +0100, Alessandro Fanfarillo wrote: >> Your patch fixes the issues. In attachment patch, test case and changelog. > > Regarding the ChangeLog: Please include

Re: [Fortran, Patch] Memory sync after coarray image control statements and assignment

2015-12-09 Thread Alessandro Fanfarillo
Done. I have permission for contributing but I don't have write permission on the repository. 2015-12-09 8:23 GMT+01:00 Tobias Burnus : > Alessandro Fanfarillo wrote: >> >> in attachment the new patch. I also checked the behavior with >> move_alloc: it synchronizes righ

Re: [Fortran, Patch] Memory sync after coarray image control statements and assignment

2015-12-10 Thread Alessandro Fanfarillo
2015-12-09 23:16 GMT+01:00 Tobias Burnus : > Thanks. Committed as r231476. Thanks. > > Do we need to do anything about GCC 5 or is this only a GCC 6 issue? > Yes, the patch should be applied to GCC 5 too. > That can be changed: Simply fill out the form and list me (burnus (at] > gcc.gnu.org) as

[Fortran, Patch} Fix ICE for coarray Critical inside module procedure

2015-12-10 Thread Alessandro Fanfarillo
() fixed the issue. The latter solution is proposed in the attached patch. Built and regtested on x86_64-pc-linux-gnu Cheers Alessandro PS: This patch should be also included in GCC 5. 2015-12-10 Alessandro Fanfarillo * resolve.c (resolve_critical): Committing symbols of lock

Re: [Patch, Fortran] CO_BROADCAST for derived types with allocatable components

2019-09-26 Thread Alessandro Fanfarillo
ul > > PS Sometime before very long, something will have to be done about the > exponential code bloat that structure_alloc_comps. The more users that > there are for it the tougher it is going to get! > > On Thu, 22 Aug 2019 at 18:41, Alessandro Fanfarillo > wrote: > > >

Re: [PATCH, fortran] Support Fortran 2018 teams

2018-01-19 Thread Alessandro Fanfarillo
; + team_just_seen = false; >stat_just_seen = false; > - if (gfc_match(" , stat = %e",&tmp) == MATCH_YES && ar->stat == NULL) > + if (gfc_match (" , team = %e", &tmp) == MATCH_YES && ar->stat == NULL) > > > Is

Re: [PATCH, fortran] Support Fortran 2018 teams

2018-01-19 Thread Alessandro Fanfarillo
at, Steve, and for responding, Alessandro. >> >> Anything else? >> > > I've only just started to look at the patch. Unfortunately, > I know zero about teams, so need to read the patch and F2018 > standard simultaneously. > > -- > Steve -- Alessand

Re: [PATCH, fortran] Support Fortran 2018 teams

2018-01-26 Thread Alessandro Fanfarillo
; > Ok from RM POV. > > Jakub -- Alessandro Fanfarillo, Ph.D. Postdoctoral Researcher National Center for Atmospheric Research Mesa Lab, Boulder, CO, USA 303-497-1229

[PATCH, Fortran]

2014-09-08 Thread Alessandro Fanfarillo
Dear all, the following code produces a wrong invocation to libcaf for caf_atomic_op (atomic_add): program atomic use iso_fortran_env implicit none integer :: me integer(atomic_int_kind) :: atom[*] me = this_image() call atomic_define(atom[1],0) sync all call ATOMIC_ADD (atom[1], me) if(me == 1)

[PATCH, Fortran] Sync memory action delegated to OpenCoarrays

2015-03-06 Thread Alessandro Fanfarillo
ry. Any suggestions? Best regards Alessandro commit fdb560e3f548fe60edf26717b8de6bb92f3fd555 Author: Alessandro Fanfarillo Date: Fri Mar 6 10:25:56 2015 -0800 Sync memory is translated into an invokation to _gfortran_caf_sync_memory() diff --git a/gcc/fortran/trans-decl.c b/gcc/fortra

Re: [PATCH, Fortran] Sync memory action delegated to OpenCoarrays

2015-03-09 Thread Alessandro Fanfarillo
ngle. Please let me know if I have to change the patch for -fcoarray=single. 2015-03-06 11:20 GMT-08:00 Tobias Burnus : > Dear Alessandro, > > Alessandro Fanfarillo wrote: > > so far a "sync memory" statement is translated into a local > "__sync_synchronize ()&qu

Re: [PATCH, Fortran] Sync memory action delegated to OpenCoarrays

2015-03-10 Thread Alessandro Fanfarillo
Totally fine with me. Thanks. 2015-03-10 0:20 GMT-07:00 Tobias Burnus : > Hi Alessandro, > > Alessandro Fanfarillo wrote: >> >> Thanks for the quick response. Patch built and regtested on >> x86_64-unknown-linux-gnu. > > > Actually, I also was about t

[Patch, Fortran] CO_BROADCAST for derived types with allocatable components

2019-08-22 Thread Alessandro Fanfarillo
b9458ff4414615263ed92d8965c93fd0a953f4a9 Author: Alessandro Fanfarillo Date: Thu Aug 22 10:50:17 2019 -0600 Co_broadcast derived types with allocatable components diff --git a/gcc/fortran/trans-array.c b/gcc/fortran/trans-array.c index c8d74e588dd..005646f1359 100644 --- a/gcc/fortran/trans-array.c +++ b/gcc/fortran/trans

Re: [Fortran, Patch] First patch for coarray FAILED IMAGES (TS 18508)

2016-08-03 Thread Alessandro Fanfarillo
* PING * 2016-07-21 13:05 GMT-06:00 Alessandro Fanfarillo : > Dear Mikael and all, > > in attachment the new patch, built and regtested on x86_64-pc-linux-gnu. > > Cheers, > Alessandro > > 2016-07-20 13:17 GMT-06:00 Mikael Morin : >> Le 20/07/2016 à 11:39, Andre Ve

Re: [Fortran, Patch] First patch for coarray FAILED IMAGES (TS 18508)

2016-08-09 Thread Alessandro Fanfarillo
-fdump-tree-original without making use of the > tree dump. > > Mikael asked you to provide an executable test with -fcoarray=single. > Is this not possible for some reason? > > Otherwise, this is OK for trunk. > > Thanks for the patch. > > Paul > > On 4 August

[Fortran, Patch] First patch for coarray FAILED IMAGES (TS 18508)

2016-06-06 Thread Alessandro Fanfarillo
list of failed images (failed_images). The patch has been built and regtested on x86_64-pc-linux-gnu. Ok for trunk? Alessandro commit b3bca5b09f4cbcf18f2409dae2485a16a7c06498 Author: Alessandro Fanfarillo Date: Mon Jun 6 14:27:37 2016 -0600 First patch Failed Images CAF TS-18508 diff --git

Re: [Fortran, Patch] First patch for coarray FAILED IMAGES (TS 18508)

2016-06-21 Thread Alessandro Fanfarillo
* PING * 2016-06-06 15:05 GMT-06:00 Alessandro Fanfarillo : > Dear all, > > please find in attachment the first patch (of n) for the FAILED IMAGES > capability defined in the coarray TS 18508. > The patch adds support for three new intrinsic functions defined in > the TS for si

[Fortran, Patch, CAF] Failed Images patch (TS 18508)

2017-02-11 Thread Alessandro Fanfarillo
Dear all, please find in attachment a new patch following the discussion at https://gcc.gnu.org/ml/fortran/2017-01/msg00054.html. Suggestions on how to fix potential issues are more than welcome. Regards, Alessandro commit e2dad3cc56447daea85c147f08b3f58a8e70617f Author: Alessandro Fanfarillo

Re: [Fortran, Patch, CAF] Failed Images patch (TS 18508)

2017-02-13 Thread Alessandro Fanfarillo
Thanks Jerry. That test case is supposed only to be compiled (it never runs). Anyway, the attached patch has been modified according to your suggestion. Patch built and regtested on x86_64-pc-linux-gnu. 2017-02-12 10:24 GMT-07:00 Jerry DeLisle : > On 02/11/2017 03:02 PM, Alessandro Fanfari

Re: [Fortran, Patch, CAF] Failed Images patch (TS 18508)

2017-02-13 Thread Alessandro Fanfarillo
Now with the patch attached. 2017-02-13 13:35 GMT-07:00 Alessandro Fanfarillo : > Thanks Jerry. That test case is supposed only to be compiled (it never > runs). Anyway, the attached patch has been modified according to your > suggestion. > > Patch built and regtested on x86_

Re: [PATCH, Fortran, Coarray, v1] Add support for failed images

2017-03-04 Thread Alessandro Fanfarillo
Hi Andre, thanks for your work on the patch. I agree with you about exit(0) statement in libcaf_single. Could you please add my name and contact (Alessandro Fanfarillo ) below yours in the changelog? Thanks, Alessandro 2017-03-04 10:58 GMT-07:00 Andre Vehreschild : > Hi all, > > attac

[Patch, Fortran] STOP issue with coarrays

2016-03-27 Thread Alessandro Fanfarillo
and gcc-5-branch? gcc/fortran/ChangeLog 2016-03-27 Alessandro Fanfarillo * trans-decl.c (gfc_build_builtin_function_decls): caf_stop_numeric and caf_stop_str definition. * trans-stmt.c (gfc_trans_stop): invoke external functions for stop and stop_str when coarrays

Re: [Patch, Fortran] STOP issue with coarrays

2016-03-28 Thread Alessandro Fanfarillo
going on trivial, I would > say! Are you going to add the testcase? > > Thanks a lot! I am impressed that you are doing these between > celebrating your doctorate and preparing for your move :-) > > Paul > > On 27 March 2016 at 17:10, Alessandro Fanfarillo > wrote: >>

Re: [Fortran, Patch] First patch for coarray FAILED IMAGES (TS 18508)

2016-09-07 Thread Alessandro Fanfarillo
me reason? > > Otherwise, this is OK for trunk. > > Thanks for the patch. > > Paul > > On 4 August 2016 at 05:07, Alessandro Fanfarillo > wrote: >> * PING * >> >> 2016-07-21 13:05 GMT-06:00 Alessandro Fanfarillo : >>> Dear Mikael a

Re: [Fortran, Patch] First patch for coarray FAILED IMAGES (TS 18508)

2016-09-21 Thread Alessandro Fanfarillo
> Andre > > On Mon, 19 Sep 2016 08:30:12 -0700 > Alessandro Fanfarillo wrote: > >> * PING * >> >> On Sep 7, 2016 3:01 PM, "Alessandro Fanfarillo" >> wrote: >> >> > Dear all, >> > the attached patch supports

Re: [Fortran, Patch] First patch for coarray FAILED IMAGES (TS 18508)

2016-09-28 Thread Alessandro Fanfarillo
* PING * 2016-09-21 19:03 GMT+01:00 Alessandro Fanfarillo : > Thanks Andre. > > 2016-09-19 9:55 GMT-06:00 Andre Vehreschild : >> Hi Alessandro, > >> The if in resolve.c at 8837: resolve_failed_image (... is intentional? It is >> doing nothing. So do you plan to add

Re: [Fortran] Help with STAT= attribute in coarray reference

2016-06-29 Thread Alessandro Fanfarillo
. In the meantime, is this patch OK for trunk? 2016-06-23 14:45 GMT-06:00 Mikael : > Le 20/06/2016 22:01, Alessandro Fanfarillo a écrit : >> >> Hi Mikael and all, >> >> in attachment the new version of the patch. >> I've addressed all the suggestions except

Re: [Fortran, Patch] First patch for coarray FAILED IMAGES (TS 18508)

2016-07-04 Thread Alessandro Fanfarillo
* PING * 2016-06-21 10:59 GMT-06:00 Alessandro Fanfarillo : > * PING * > > 2016-06-06 15:05 GMT-06:00 Alessandro Fanfarillo : >> Dear all, >> >> please find in attachment the first patch (of n) for the FAILED IMAGES >> capability defined in the coarray TS 185

Re: [Fortran] Help with STAT= attribute in coarray reference

2016-07-05 Thread Alessandro Fanfarillo
Thanks, committed as rev. 238007. 2016-07-04 14:41 GMT-06:00 Mikael Morin : > Le 30/06/2016 06:05, Alessandro Fanfarillo a écrit : >> >> Dear Mikael, >> >> thanks for your review and for the test. The attached patch, built and >> regtested for x86_64-pc-linux-g

Re: [Fortran, Patch] First patch for coarray FAILED IMAGES (TS 18508)

2016-07-15 Thread Alessandro Fanfarillo
Third *PING* 2016-07-04 16:46 GMT-06:00 Alessandro Fanfarillo : > * PING * > > 2016-06-21 10:59 GMT-06:00 Alessandro Fanfarillo : >> * PING * >> >> 2016-06-06 15:05 GMT-06:00 Alessandro Fanfarillo : >>> Dear all, >>> >>> please find in a

Re: [Fortran, Patch] First patch for coarray FAILED IMAGES (TS 18508)

2016-07-21 Thread Alessandro Fanfarillo
gs = XALLOCAVEC (tree, num_args); >>>> + >>>> + gfc_conv_intrinsic_function_args (se, expr, args, num_args); >>>> + >>>> + if (flag_coarray == GFC_FCOARRAY_LIB) >>>> +{ >>> >>> Can everything be put under the if? &g

[COMMITTED] Add myself to MAINTAINERS (Write After Approval)

2015-12-15 Thread Alessandro Fanfarillo
rmann Doug Evans Chris Fairles +Alessandro Fanfarillo Changpeng Fang Li Feng Max Filippov Index: Chan

Re: [Fortran, Patch} Fix ICE for coarray Critical inside module procedure

2015-12-15 Thread Alessandro Fanfarillo
Committed as revision 231649 on trunk and as revision 231650 on gcc-5-branch. Thanks. 2015-12-14 20:02 GMT+01:00 Tobias Burnus : > Dear Alessandro, > > Alessandro Fanfarillo wrote: >> >> the compiler returns an ICE when a coarray critical section is used >> inside

Re: [COMMITTED] Add myself to MAINTAINERS (Write After Approval)

2015-12-15 Thread Alessandro Fanfarillo
Sorry about that. Committed revision 231657 Index: ChangeLog === --- ChangeLog(revision 231656) +++ ChangeLog(working copy) @@ -1,4 +1,4 @@ -2015-12-15 Alessandro Fanfarillo +2015-12-15 Alessandro Fanfarillo

Re: [Fortran, Patch] (RFC, Coarray) Implement TS18508's EVENTS

2015-12-17 Thread Alessandro Fanfarillo
branch when it is re-opened? > > -- > steve > > On Wed, Dec 02, 2015 at 03:16:05PM +0100, Alessandro Fanfarillo wrote: >> *PING* >> >> 2015-11-26 17:51 GMT+01:00 Steve Kargl : >> > On Wed, Nov 25, 2015 at 06:24:49PM +0100, Alessandro Fanfarillo wrote: &

Re: [Fortran, Patch] (RFC, Coarray) Implement TS18508's EVENTS

2015-12-17 Thread Alessandro Fanfarillo
Great! Thanks. 2015-12-17 15:57 GMT+01:00 Steve Kargl : > On Thu, Dec 17, 2015 at 01:22:06PM +0100, Alessandro Fanfarillo wrote: >> >> I've noticed that this patch has been applied only on trunk and not on >> the gcc-5-branch. Is it a problem to include EVENTS in gcc-5?

Re: [PATCH, Fortran]

2014-09-08 Thread Alessandro Fanfarillo
Thanks, your suggestion fixes the problem. I just noticed that I missed the subject description; I'll send the new patch in a different email. 2014-09-08 15:50 GMT-06:00 Tobias Burnus : > Alessandro Fanfarillo wrote: > > the following code produces a wrong invocation

[PATCH, Fortran] Wrong invocation of caf_atomic_op

2014-09-08 Thread Alessandro Fanfarillo
call ATOMIC_ADD (atom[1], me) if(me == 1) call atomic_ref(me,atom[1]) sync all write(*,*) me end program Ok for trunk? 2014-09-08 Alessandro Fanfarillo Tobias Burnus * trans-intrinsic.c (conv_intrinsic_atomic_op): Check for indirect reference for caf_atomic_op value

Re: [PATCH, Fortran] Wrong invocation of caf_atomic_op

2014-09-15 Thread Alessandro Fanfarillo
New patch after the update. Cheers 2014-09-09 0:30 GMT-06:00 Tobias Burnus : > Alessandro Fanfarillo wrote: >> >> This email follows the previous without subject (sorry about that). > > > I think I'd prefer the following patch, which avoids a temporary if none is >

Re: [PATCH, Fortran] Wrong invocation of caf_atomic_op

2014-09-15 Thread Alessandro Fanfarillo
In attachment a test case which fails with the current gcc-trunk version but works when the patch is applied. coarray_35.f90 is my attempt to write a gcc test case. The problem is related with atomic_add. 2014-09-15 12:55 GMT-06:00 Tobias Burnus : > On 15.09.2014 19:18, Alessandro Fanfari

Re: [PATCH, Fortran] Wrong invocation of caf_atomic_op

2014-09-22 Thread Alessandro Fanfarillo
ort and the patch Alessandro! > > Tobias > > > On 15.09.2014 23:29, Tobias Burnus wrote: >> >> On 15.09.2014 22:23, Alessandro Fanfarillo wrote: >>> >>> In attachment a test case which fails with the current gcc-trunk >>> version but works when the pa

Re: [Patch, Fortran] Add CO_BROADCAST

2014-09-25 Thread Alessandro Fanfarillo
Hi, I'm implementing the co_broadcast on libcafmpi right now. 2014-09-25 8:08 GMT+02:00 Tobias Burnus : > Hi Paul, > > Paul Richard Thomas wrote: >> >> In the check.c error messages, you use 'A argument'. Should you not >> use 'SOURCE argument', following CO BROADCAST (SOURCE, SOURCE IMAGE [, >>

Re: [Patch, Fortran] -fcoarray=lib - support CRITICAL, prepare for locking support

2014-08-01 Thread Alessandro Fanfarillo
Hello, I was implementing lock/unlock on the library side when I found a possible problem in the patch: if (is_lock_type == GFC_CAF_CRITICAL) +reg_type = sym->attr.artificial ? GFC_CAF_CRITICAL : GFC_CAF_LOCK_STATIC; + else +reg_type = GFC_CAF_COARRAY_STATIC; the if statement cannot be

Re: [Patch, fortran] PR46897 - [OOP] type-bound defined ASSIGNMENT(=) not used for derived type component in intrinsic assign

2012-08-13 Thread Alessandro Fanfarillo
ould > happen isn't it? > > Thanks for the review. I believe, in summary, that I should handle > 'this_code' consistently so that multiple component defined > assignments work correctly. I should also verify that pointers do > what they are supposed to do, although it is rather trivial. > > Cheers > > Paul -- Dott. Alessandro Fanfarillo Verificatore Ellisse Cell: 339/2428012 Email: alessandro.fanfari...@gmail.com

Re: [Fortran] PR37336 - FIINAL patch [1/n]: Implement the finalization wrapper subroutine

2012-08-24 Thread Alessandro Fanfarillo
Dear Tobias, there are some problems with the final-wrapper-v2.diff patch; I get the following error final2.f90:71.15: end module test 1 Internal Error at (1): gfc_code2string(): Bad code for every test case that I use; in attachment final2.f90. Regards Alessandro 2012/8/19 To

Re: [Fortran, DRAFT patch] PR 46321 - [OOP] Polymorphic deallocation

2012-06-13 Thread Alessandro Fanfarillo
Dear all, in attachment the new draft which also supports the polymorphic deallocation via INTENT(OUT). Tomorrow I'll try to realize a draft for the deallocation at the end of the scope. Regards 2012/6/12 Alessandro Fanfarillo : > I don't know if there's already a PR but I ge

[Fortran, patch] PR 52158 - Regression on character function with gfortran 4.7

2012-05-06 Thread Alessandro Fanfarillo
st regards. gcc/fortran/ChangeLog 2012-05-06 Alessandro Fanfarillo Paul Thomas Tobias Burnus PR fortran/52158 * resolve.c (resolve_fl_derived0): Add a new condition in the if st

Re: [Fortran, patch] PR 52158 - Regression on character function with gfortran 4.7

2012-05-12 Thread Alessandro Fanfarillo
-linux-gnu. gcc version 4.8.0 20120512 (experimental). Have a nice weekend. Alessandro. 2012/5/7 Tobias Burnus : > Hello, > > > On 05/06/2012 09:37 PM, Alessandro Fanfarillo wrote: >> >> The patch is bootstrapped and tested on x86_64-unknown-linux-gnu - gcc >&

Re: [Fortran, patch] PR 52158 - Regression on character function with gfortran 4.7

2012-05-15 Thread Alessandro Fanfarillo
2012/5/13 Tobias Burnus : > > Committed as Rev. 187436. Thanks for the patch and congratulation to your > first GCC contribution! Thank you for your priceless support! Alessandro

[Fortran, patch] PR 48831 - Constant expression (PARAMETER array element) rejected as nonconstant

2012-05-15 Thread Alessandro Fanfarillo
Hi All, in attachment there's a patch for PR 48831, it also includes a new test case suggested by Tobias Burnus. The patch is bootstrapped and tested on x86_64-unknown-linux-gnu. Regards. Alessandro Fanfarillo patch.diff Description: Binary data

[Fortran, DRAFT patch] PR 46321 - [OOP] Polymorphic deallocation

2012-06-02 Thread Alessandro Fanfarillo
Dear all, I have realized a draft patch for the PR 46321, currently it works only with the explicit DEALLOCATE. Running the regression tests it doesn't pass the following: - gfortran.dg/class_19.f03 (too much "__builtin_free") - gfortran.dg/auto_dealloc_2.f90 (too much "__builtin_free") - gfortr

Re: [Fortran, DRAFT patch] PR 46321 - [OOP] Polymorphic deallocation

2012-06-02 Thread Alessandro Fanfarillo
Hi Janus, > Sorry, I don't understand the last sentence. Why should it call some > "__free..." instead of "doit"? And why is that test case even affected > by your patch (you said it would only work with explicit DEALLOCATE, > which does not appear in that test case)? Yes, it is as I said... In h

Re: [Fortran, patch] PR 48831 - Constant expression (PARAMETER array element) rejected as nonconstant

2012-06-03 Thread Alessandro Fanfarillo
Hi all, in attachment the patch which includes the review comments provided by Tobias. The patch is bootstrapped and tested on x86_64-unknown-linux-gnu. Regards. Alessandro 2012/5/20 Tobias Burnus : > Hi Alessandro, > > > Alessandro Fanfarillo wrote: >> >> in attachmen

Re: [Fortran, DRAFT patch] PR 46321 - [OOP] Polymorphic deallocation

2012-06-03 Thread Alessandro Fanfarillo
> Right, the problem is that the _free component is missing. Just as the > _copy component, _free should be present for *every* vtype, no matter > if there are allocatable components or not. If the _free component is > not needed, it should be initialized to EXPR_NULL. With an "empty" _free functi

Re: [Fortran, patch] PR 48831 - Constant expression (PARAMETER array element) rejected as nonconstant

2012-06-03 Thread Alessandro Fanfarillo
Thank you Tobias, I thought that "Change name in gfc_check_init_expr" was sufficient. 2012/6/3 Tobias Burnus : > Hi Alessandro, hi all, > > > Alessandro Fanfarillo wrote: >> >> in attachment the patch which includes the review comments provided by >> Tob

Re: [Fortran, DRAFT patch] PR 46321 - [OOP] Polymorphic deallocation

2012-06-09 Thread Alessandro Fanfarillo
-) > > Once we have the separate function, we could at later stage replace it > by a TREE_SSA version. > > Cheers > > Paul > > On 3 June 2012 12:15, Alessandro Fanfarillo wrote: >>> Right, the problem is that the _free component is missing. Just as the >>

Re: [Fortran, DRAFT patch] PR 46321 - [OOP] Polymorphic deallocation

2012-06-11 Thread Alessandro Fanfarillo
compiler error: in build_int_cst_wide, at tree.c:1219 deallocate (taa, tpa, caa, cpa) ^ Please submit a full bug report, with preprocessed source if appropriate. See <http://gcc.gnu.org/bugs.html> for instructions. 2012/6/10 Tobias Burnus : > Alessandro Fanfarillo wrote: >> &g

Re: [Fortran, DRAFT patch] PR 46321 - [OOP] Polymorphic deallocation

2012-06-12 Thread Alessandro Fanfarillo
I don't know if there's already a PR but I get an ICE compiling this with a non-patched version. If x is not an array everything goes ok. 2012/6/11 Tobias Burnus : > On 06/11/2012 11:24 AM, Alessandro Fanfarillo wrote: >> >> gfortran.dg/coarray/poly_run_3.f90 > >