Re: [PATCH v3] i386: Prefer PLT indirection for __fentry__ calls under -fPIC

2025-04-10 Thread Ard Biesheuvel
On Wed, 9 Apr 2025 at 09:12, Uros Bizjak wrote: > > On Tue, Apr 8, 2025 at 6:59 PM Ard Biesheuvel wrote: > > > > On Tue, 8 Apr 2025 at 18:44, H.J. Lu wrote: > > > > > > On Tue, Apr 8, 2025 at 9:39 AM Ard Biesheuvel wrote: > > > > > > > > On Tue, 8 Apr 2025 at 15:33, H.J. Lu wrote: > > > > > >

Re: .ACCESS_WITH_SIZE and pointer ranges

2025-04-10 Thread Qing Zhao
> On Apr 8, 2025, at 13:13, Siddhesh Poyarekar wrote: > > On 2025-04-08 12:41, Qing Zhao wrote: >> For the following small example: >> [ counted_by_whole]$ cat t.c >> #include >> #include >> struct annotated { >> size_t count; >> char other; >> char array[] __attribute__((counted_by (co

Re: [PATCH] c++: Properly mangle CONST_DECL without a INTEGER_CST value [PR116511]

2025-04-10 Thread Jason Merrill
On 9/6/24 7:15 AM, Simon Martin wrote: We ICE upon the following *valid* code when mangling the requires clause === cut here === template struct s1 { enum { e1 = 1 }; }; template struct s2 { enum { e1 = s1::e1 }; s2() requires(0 != e1) {} }; s2<8> a; === cut here === The problem is t

Re: [PATCH] Add std::deque shrink_to_fit test

2025-04-10 Thread Jonathan Wakely
On 10/04/25 22:36 +0200, François Dumont wrote: After running the test with -fno-exceptions option we rather need this patch. Ok to commit ? François On 10/04/2025 21:08, François Dumont wrote: Hi     No problem detected now that we really test std::deque shrink_to_fit implementation.  

[Stage 1][Middle-end][PATCH v5 0/3] Provide more contexts for -Warray-bounds and -Wstringop-* warning messages

2025-04-10 Thread Qing Zhao
Hi, These are the patches for fixing PR109071 for GCC16 stage1: Adding -fdiagnotics-details into GCC to provide more hints to the end users on how the warnings come from, in order to help the user to locate the exact location in source code on the specific warnings due to compiler optimizations.

Re: combine: Re-enable 2->2 combinations, with limits [PR116398]

2025-04-10 Thread Jeff Law
On 4/7/25 1:57 AM, Richard Sandiford wrote: Sam James writes: Richard Sandiford writes: This series is an update of: https://gcc.gnu.org/pipermail/gcc-patches/2025-April/679924.html As discussed in that thread, the changes since last time are to make distribute_links start from the l

[PATCH] aarch64: Fix CFA offsets in non-initial stack probes [PR119610]

2025-04-10 Thread Richard Sandiford
PR119610 is about incorrect CFI output for a stack probe when that probe is not the initial allocation. The main aarch64 stack probe function, aarch64_allocate_and_probe_stack_space, implicitly assumed that the incoming stack pointer pointed to the top of the frame, and thus held the CFA. aarch64

Re: [PATCH] Add std::deque shrink_to_fit test

2025-04-10 Thread François Dumont
After running the test with -fno-exceptions option we rather need this patch. Ok to commit ? François On 10/04/2025 21:08, François Dumont wrote: Hi     No problem detected now that we really test std::deque shrink_to_fit implementation.     libstdc++: Add std::deque<>::shrink_to_fit tes

Re: [Patch] libgomp: Add -Wno-c-binding-type for omp_lib.f90 compilation

2025-04-10 Thread Jakub Jelinek
On Tue, Apr 08, 2025 at 11:57:46AM +0200, Tobias Burnus wrote: > libgomp/ChangeLog: > > * Makefile.am (%.mod): Add -Wno-c-binding-type. > * Makefile.in: Regenerate. LGTM. Jakub

Re: [PATCH 2/2] libgcobol: Allow libgcobol to use libquadmath [PR119244].

2025-04-10 Thread Jakub Jelinek
On Sun, Apr 06, 2025 at 09:02:07AM +0100, Iain Sandoe wrote: > > + > +#if !defined (HAVE_STRTOF128) > +# if USE_QUADMATH > +# define strtof128 strtoflt128 > +# else > +# error "no available string to float 128" > +# endif > +#endif If there is no strtof128 and not using libquadmath, there is a

Re: Questions on replacing a structure pointer reference to a call to .ACCESS_WITH_SIZE in C FE

2025-04-10 Thread Siddhesh Poyarekar
On 2025-04-10 01:41, Martin Uecker wrote: I have some questions about this: The access would add new reads to the size field. For counted_by, so far, those are somehow coupled to the access to the member. From this you would assume For the currently implemented subset, updates to the storage

Re: [PATCH] [PR119706] aarch64: Add test case.

2025-04-10 Thread Jennifer Schmitz
> On 10 Apr 2025, at 19:31, Richard Biener wrote: > > External email: Use caution opening links or attachments > > >> Am 10.04.2025 um 17:27 schrieb Jennifer Schmitz : >> >> This patch adds a test case to the testsuite for PR119706. >> The bug was already fixed by >> https://gcc.gnu.org/pip

[PATCH] LRA: Backport PR115568 and PR119689 to release branches

2025-04-10 Thread Uros Bizjak
Hello! I would like to backport PR115568 and PR119689 to release branches. Author: Richard Biener Date: Wed Apr 9 14:36:19 2025 +0200 rtl-optimization/119689 - compare-debug failure with LRA The previous change to fix LRA rematerialization broke compare-debug for i586 bootstrap. Fi

[PATCH] RISCV :Added MIPS P8700 Subtarget.

2025-04-10 Thread Umesh Kalappa
P8700 is a high-performance processor from MIPS by extending RISCV with the MIPS custom instructions. Tested with dejagnu riscv.exp tests for --mtune=mips-p8700. Please refer @ https://mips.com/products/hardware/p8700/ --- gcc/ChangeLog| 21 +++ gcc/common/confi

Re: [PATCH] bitintlower: Fix up handling of nested casts in m_upward_2limbs cases [PR119707]

2025-04-10 Thread Richard Biener
On Thu, 10 Apr 2025, Jakub Jelinek wrote: > Hi! > > The following testcase is miscompiled I believe starting with > PR112941 r14-6742. That commit fixed the bitint-55.c testcase. > The m_first initialization for such conversion initializes 2 SSA_NAMEs, > one is PHI result on the loop (m_data[sav

Re: [PATCH v2] c++/modules: More fixes for merging DECL_MAYBE_DELETED functions

2025-04-10 Thread Nathaniel Shead
On Thu, Apr 10, 2025 at 12:19:57PM -0400, Jason Merrill wrote: > On 4/10/25 8:46 AM, Nathaniel Shead wrote: > > Regression raised with my by private correspondance. > > Bootstrapped and regtested on x86_64-pc-linux-gnu, OK for trunk? > > > > -- >8 -- > > > > My change in r15-9216 broke the case w

[PATCH v3] i386: Prefer PLT indirection for __fentry__ calls under -fPIC

2025-04-10 Thread Ard Biesheuvel
From: Ard Biesheuvel Commit bde21de1205 ("i386: Honour -mdirect-extern-access when calling __fentry__") updated the logic that emits mcount() / __fentry__() calls into function prologues when profiling is enabled, to avoid GOT-based indirect calls when a direct call would suffice. There are two

[PATCH] libbacktrace: Use correct type in backtrace_atomic_store_int

2025-04-10 Thread Jonathan Wakely
libbacktrace/ChangeLog: * atomic.c (backtrace_atomic_store_int): Use int for old value. --- Ian approved this when I submitted a pull request to the libbacktrace github repo. Tested x86_64-linux. Pushed to trunk. libbacktrace/atomic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

Re: [PATCH v1 4/4] libstdc++: Add tests for std::extents.

2025-04-10 Thread Luc Grosheintz
diff --git a/libstdc++-v3/testsuite/23_containers/mdspan/extents/assign_copy_01_neg.cc b/libstdc++-v3/testsuite/23_containers/mdspan/extents/assign_copy_01_neg.cc new file mode 100644 index 000..8a514f2207b --- /dev/null +++ b/libstdc++-v3/testsuite/23_containers/mdspan/extents/assign_co

[PATCH V2] RISC-V: Add support for Zalasr extension

2025-04-10 Thread Edwin Lu
[1] https://github.com/riscv/riscv-zalasr Add minimal support for the zalasr (load-acquire/store-release) extension Currently there is no toggle to opt into the abi-breaking note 3 mappings in the PSABI doc so support for that has been omitted from this patch. gcc/ChangeLog: * common/co

Re: [PATCH] libgcobol, v2: Handle long double as an alternate IEEE754 128b

2025-04-10 Thread Jakub Jelinek
On Thu, Apr 10, 2025 at 07:21:23PM +0100, Iain Sandoe wrote: > > So, here is an updated patch based on your patch, so far briefly > > tested on x86_64 with recent glibc (i.e. with the *f128 APIs). > > makes sense to me - and builds and tests on x86_64-darwin (which needs > libquadmath) without iss

Re: [PATCH] Locality cloning pass (was: Introduce -flto-partition=locality)

2025-04-10 Thread Kyrylo Tkachov
> On 26 Mar 2025, at 08:42, Kyrylo Tkachov wrote: > > Ping. Ping. https://gcc.gnu.org/pipermail/gcc-patches/2025-March/676958.html I’ve ran a profiled LTO bootstrap of GCC with the new bootstrap-lto-locality bootstrap config And compared it against a GCC produced by the existing lto-bootstra

[PATCH v1 1/4] libstdc++: Setup internal FTM for mdspan.

2025-04-10 Thread Luc Grosheintz
Uses the FTM infrastructure to create an internal feature testing macro for partial availability of mdspan; which is then used to hide the contents of the header mdspan when compiling against a standard prior to C++23. libstdc++-v3/ChangeLog: * include/bits/version.def: Add internal featu

Re: GCN, nvptx libstdc++: Force use of '__atomic' builtins [PR119645] (was: GCN, nvptx: Allow for "hosted" libstdc++ build)

2025-04-10 Thread Jonathan Wakely
On Mon, 7 Apr 2025 at 09:08, Thomas Schwinge wrote: > > Hi! > > On 2025-03-14T11:39:20+0100, I wrote: > > As the first of a few patches to enable libstdc++ for GCN, nvptx targets, > > [...] > > > some more fine-tuning is to follow later on.) > > Any comments before I push the attached > "GCN, nvpt

Re: [PATCH v1 3/4] libstdc++: Implement std::extents [PR107761].

2025-04-10 Thread Tomasz Kaminski
On Thu, Apr 10, 2025 at 1:21 PM Tomasz Kaminski wrote: > > > On Wed, Apr 9, 2025 at 9:28 AM Luc Grosheintz > wrote: > >> This implements std::extents from according to N4950 and >> contains partial progress towards PR107761. >> >> If an extent changes its type, there's a precondition in the sta

Re: ping: COBOL: testsuite and running NIST85

2025-04-10 Thread Jakub Jelinek
On Mon, Apr 07, 2025 at 09:30:59AM +0200, Richard Biener wrote: > On Mon, Apr 7, 2025 at 9:00 AM Simon Sobisch wrote: > > My question stands on integrating COBOLworx' UAT as-is for now > > (Copyright is all on FSF; built automatically [it is autoconf, which is > > a requirement for VCS checkouts],

Re: [PATCH] Avoid using POINTER_DIFF_EXPR for overlap checks [PR119399]

2025-04-10 Thread Jakub Jelinek
On Thu, Apr 10, 2025 at 10:32:57AM +0100, Richard Sandiford wrote: > In r10-4803-g8489e1f45b50600c I'd used POINTER_DIFF_EXPR to subtract > the two pointers involved in an overlap test. I'm not sure whether > I'd specifically chosen that over MINUS_EXPR or not; if so, the only > reason I can think

Re: Questions on replacing a structure pointer reference to a call to .ACCESS_WITH_SIZE in C FE

2025-04-10 Thread Qing Zhao
> On Apr 10, 2025, at 15:22, Qing Zhao wrote: > > > >> On Apr 10, 2025, at 13:43, Martin Uecker wrote: >> >> Am Donnerstag, dem 10.04.2025 um 17:05 + schrieb Qing Zhao: >>> Hi, Martin, >>> >>> Thanks a lot for all your comments and questions, really helpful. >>> >>> >> >> ...

Re: [PATCH] lto: lto-opts fixes [PR119625]

2025-04-10 Thread Jakub Jelinek
On Mon, Apr 07, 2025 at 01:38:19PM -0400, Marek Polacek wrote: > On Fri, Apr 04, 2025 at 08:56:40PM +0200, Jakub Jelinek wrote: > > On Fri, Apr 04, 2025 at 08:52:10PM +0200, Richard Biener wrote: > > > > Or do you want something further (like > > > > switch (global_options.x_flag_cf_protection & ~C

Re: [PATCH 2/2] libgcobol: Allow libgcobol to use libquadmath [PR119244].

2025-04-10 Thread Rainer Orth
Hi Iain, >> On 9 Apr 2025, at 09:00, Rainer Orth wrote: >> >> Jakub Jelinek writes: >> >>> On Sun, Apr 06, 2025 at 09:02:07AM +0100, Iain Sandoe wrote: + +#if !defined (HAVE_STRTOF128) +# if USE_QUADMATH +# define strtof128 strtoflt128 +# else +# error "no

[pushed] c++: constinit and value-initialization [PR119652]

2025-04-10 Thread Jason Merrill
Tested x86_64-pc-linux-gnu, applying to trunk and 14. -- 8< -- Value-initialization built an AGGR_INIT_EXPR to set AGGR_INIT_ZERO_FIRST on. Passing that AGGR_INIT_EXPR to maybe_constant_value returned a TARGET_EXPR, which potential_constant_expression_1 mistook for a temporary. We shouldn't add

[committed] [RISC-V] Fix more fallout from combine.c changes -- correct patch attached this time

2025-04-10 Thread Jeff Law
Whoops, attached wrong patch to last message. This is the right patch. Trivial fallout from the recent combine work. We end up with a srai rather than an xor in some of the saturation sequences. Both variants look equally performant, so I'm just adjusting the expected test output. Pushing

[COMMITTED 07/32] gccrs: Fix ICE on invalid match arms

2025-04-10 Thread arthur . cohen
From: Philip Herron We hit assertions on empty enum or unknown variant, this catches the error and emits a new diagnostic. Fixes Rust-GCC#3656 gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-pattern.cc (TypeCheckPattern::visit): emit error gcc/testsuite/ChangeLog: * rust

Re: [PATCH] libgomp: Update SVE tests

2025-04-10 Thread Richard Sandiford
Tejas Belagod writes: > On 4/10/25 5:56 PM, Richard Sandiford wrote: >> Tejas Belagod writes: >>> Sorry, forgot to ask - Richard, are you happy for me to work on a >>> separate patch to fix the test alongside your target +sve fix as a >>> couple more functions (eg simd_reduction () and inscan.. (

[pushed] c++: nested lambda capture pack [PR119345]

2025-04-10 Thread Jason Merrill
Tested x86_64-pc-linux-gnu, applying to trunk. -- 8< -- tsubst_stmt already registers a local capture proxy as a local_specialization of both an outer capture proxy and the captured variable; we also need to do that in add_extra_args. PR c++/119345 gcc/cp/ChangeLog: * pt.cc (ad

[PATCH] libstdc++: Add P1206R7 from_range members to std::string [PR111055]

2025-04-10 Thread Jonathan Wakely
This is the last piece of P1206R7, adding new members to std::basic_string. libstdc++-v3/ChangeLog: PR libstdc++/111055 * include/bits/basic_string.h (_S_copy_range): New function. (basic_string(from_range_t, R%%, const Alloc&)): New constructor. (append_ra

<    1   2