[PATCH] c++/modules: Handle chaining already-imported local types [PR114630]

2025-01-09 Thread Nathaniel Shead
Bootstrapped and regtested on x86_64-pc-linux-gnu, OK for trunk/14? -- >8 -- In the linked testcase, an ICE occurs because when reading the (duplicate) function definition for _M_do_parse from module Y, the local type definitions have already been streamed from module X and setup as regular backr

Re: [PATCH] ipa-cp: Fold-convert values when necessary (PR 118138)

2025-01-09 Thread Jan Hubicka
> Hi, > > PR 118138 and quite a few duplicates that it has acquired in a short > time show that even though we are careful to make sure we do not loose > any bits when newly allowing type conversions in jump-functions, we > still need to perform the fold conversions during IPA constant > propagati

Re: [Patch, Fortran, PR118337, v1] Fortran: Fix Fortran *.mod compatibility [PR118337]

2025-01-09 Thread Jakub Jelinek
On Thu, Jan 09, 2025 at 03:28:28PM +0100, Jakub Jelinek wrote: > So like this? Thomas mentioned bad wording in a private mail. Here is a better patch: 2025-01-09 Jakub Jelinek PR fortran/118337 * module.cc (use_iso_fortran_env_module): Add a comment explaining the opt

RE: [PATCH]AArch64: Fix costing of emulated gathers/scatters [PR118188]

2025-01-09 Thread Tamar Christina
> -Original Message- > From: Richard Sandiford > Sent: Thursday, January 9, 2025 3:09 PM > To: Tamar Christina > Cc: gcc-patches@gcc.gnu.org; nd ; Richard Earnshaw > ; ktkac...@gcc.gnu.org > Subject: Re: [PATCH]AArch64: Fix costing of emulated gathers/scatters > [PR118188] > > Tamar Chri

Re: [PATCH] c++: Suppress note linked to error suppressed by -Wno-template-body [PR118163]

2025-01-09 Thread Patrick Palka
On Wed, 8 Jan 2025, Jason Merrill wrote: > On 12/21/24 11:35 AM, Simon Martin wrote: > > When erroring out due to an incomplete type, we add a contextual note > > about the type. However, when the error is suppressed by > > -Wno-template-body, the note remains, making the compiler output quite > >

Re: [Patch, Fortran, PR118337, v1] Fortran: Fix Fortran *.mod compatibility [PR118337]

2025-01-09 Thread Andre Vehreschild
Hi Jakub, Yes, that is what I had in mind. Being German I don't see any problem with the explanation, but that is better judged by a native English speaker. Is the send patch hunk intentional where only indentation is changed? I haven't applied it though. Thanks for the patch, Andre On

Re: [Patch, Fortran, PR118337, v1] Fortran: Fix Fortran *.mod compatibility [PR118337]

2025-01-09 Thread Jakub Jelinek
On Thu, Jan 09, 2025 at 06:12:51PM +0100, Andre Vehreschild wrote: > Yes, that is what I had in mind. Being German I don't see any problem with the > explanation, but that is better judged by a native English speaker. > > Is the send patch hunk intentional where only indentation is changed? I > h

Re: [PATCH v3 1/2] aarch64: Use standard names for saturating arithmetic

2025-01-09 Thread Kyrylo Tkachov
Hi Akram > On 8 Jan 2025, at 16:23, Akram Ahmad wrote: > > Hi Kyrill, > > Thanks for the feedback on V2. I found a pattern which works for > the open-coded signed arithmetic, and I've implemented the other > feedback you provided as well. > > I've send the modified patch in this thread as the

Re: [PATCH] match.pd: Fold pattern of round semantics.

2025-01-09 Thread Richard Biener
On Thu, 9 Jan 2025, Zhou Zhao wrote: > > 在 2025/1/9 下午3:33, Richard Biener 写道: > > On Thu, 9 Jan 2025, Zhou Zhao wrote: > > > >> 在 2025/1/8 下午6:30, Richard Biener 写道: > >>> On Wed, 8 Jan 2025, Zhou Zhao wrote: > >>> > 在 2025/1/8 下午5:04, Richard Biener 写道: > > On Wed, 8 Jan 2025, Zhou Zha

Re: [PATCH] gcc/configure: Fix check for assembler section merging support on Arm

2025-01-09 Thread Richard Earnshaw (lists)
On 08/01/2025 21:47, Thiago Jung Bauermann wrote: > "Richard Earnshaw (lists)" writes: > >> On 27/12/2024 21:47, Thiago Jung Bauermann wrote: >>> In 32-bit Arm assembly, the @ character is the start of a comment so >>> the section type needs to use the % character instead. >>> >>> configure.ac at

Re: [PATCH] match.pd: Fold pattern of round semantics.

2025-01-09 Thread Zhou Zhao
在 2025/1/9 下午3:33, Richard Biener 写道: On Thu, 9 Jan 2025, Zhou Zhao wrote: 在 2025/1/8 下午6:30, Richard Biener 写道: On Wed, 8 Jan 2025, Zhou Zhao wrote: 在 2025/1/8 下午5:04, Richard Biener 写道: On Wed, 8 Jan 2025, Zhou Zhao wrote: 在 2025/1/7 下午10:45, Richard Biener 写道: On Thu, 2 Jan 2025, 赵洲

Re: [PATCH] testsuite: arm: Use -Os in memset-inline-8* tests

2025-01-09 Thread Richard Earnshaw (lists)
On 22/12/2024 15:27, Torbjörn SVENSSON wrote: > Ok for trunk and releases/gcc-14? > > -- > > When the test was initially created, -fcommon was the default, but in > commit r10-4867-g6271dd984d7 the default value changed to -fno-common. > This change made the test start failing. To counter the ove

Re: [PATCH] testsuite: arm: Align function prototype and implementation

2025-01-09 Thread Richard Earnshaw (lists)
On 27/12/2024 08:32, Torbjörn SVENSSON wrote: > Ok for trunk? > > -- > > The implementation of the functions in the test case expects there to be > a few arguments to the helper functions, but the prototype does not have > any arguments at all. Align these to avoid these errors: > > .../pr59858.

[PATCH] c++: Ignore default arguments for friend functions that cannot have any [PR118319]

2025-01-09 Thread Simon Martin
We segfault upon the following invalid code === cut here === template struct S { friend void foo (int a = []{}()); }; void foo (int a) {} int main () { S<0> t; foo (); } === cut here === The problem is that we end up with a LAMBDA_EXPR callee in set_flags_from_callee, and dereference its N

[patch, Fortran] -fc-prototypes fixes.

2025-01-09 Thread Thomas Koenig
Hello world, This patch fixes and reorganizes dumping C prototypes. It makes the following changes: - BIND(C) types are now always output before any global symbols - CFI_cdesc_t is issued for assumed shape and assumed rank arguments. - BIND(C,NAME="...") entities were no

Re: [patch, Fortran] -fc-prototypes fixes.

2025-01-09 Thread Thomas Koenig
Am 09.01.25 um 14:34 schrieb Thomas Koenig: This patch fixes and reorganizes dumping C prototypes. And here is the "five seconds later, I realized I had forgotten to attach the patch" e-mail... diff --git a/gcc/fortran/dump-parse-tree.cc b/gcc/fortran/dump-parse-tree.cc index 8d31ddfcffb..826f

'git mv gcc/testsuite/gcc.dg/{,torture/}crc-linux-3.c' (was: [committed] Move some CRC tests into the gcc.dg/torture directory)

2025-01-09 Thread Thomas Schwinge
Hi! On 2024-12-03T12:32:35-0700, Jeff Law wrote: > Jakub noted that these tests were using dg-skip-if directives that > implied the tests were expected to run under multiple optimization > options, which means they probably should be in gcc.dg/torture rather > than in the gcc.dg directory. > >

Re: [PATCH] c++: Suppress note linked to error suppressed by -Wno-template-body [PR118163]

2025-01-09 Thread Simon Martin
On 9 Jan 2025, at 20:00, Marek Polacek wrote: > On Thu, Jan 09, 2025 at 12:05:43PM -0500, Patrick Palka wrote: >> On Wed, 8 Jan 2025, Jason Merrill wrote: >> >>> On 12/21/24 11:35 AM, Simon Martin wrote: When erroring out due to an incomplete type, we add a contextual note about th

RE: [PATCH] COBOL 3/8 gen: GENERIC interface

2025-01-09 Thread Robert Dubner
I am going to trim back some of the older stuff. > -Original Message- > From: Richard Biener > Sent: Tuesday, January 7, 2025 08:32 > To: Robert Dubner > Cc: jklow...@symas.com; Joseph Myers ; gcc- > patc...@gcc.gnu.org > Subject: RE: [PATCH] COBOL 3/8 gen: GENERIC interface > > On Mon,

Re: [PATCH] c/c++: UX improvements to 'too {few,many} arguments' errors (v2) [PR118112]

2025-01-09 Thread Jason Merrill
On 1/9/25 2:11 PM, David Malcolm wrote: Here's v2 of the patch. I only changed the C++ parts, for the nits identified by Marek. I didn't attempt to add coverage for the objc++ method stuff. Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Are the C++ parts OK for trunk? (Joseph

Re: [PATCH] c++: Suppress note linked to error suppressed by -Wno-template-body [PR118163]

2025-01-09 Thread Marek Polacek
On Thu, Jan 09, 2025 at 12:05:43PM -0500, Patrick Palka wrote: > On Wed, 8 Jan 2025, Jason Merrill wrote: > > > On 12/21/24 11:35 AM, Simon Martin wrote: > > > When erroring out due to an incomplete type, we add a contextual note > > > about the type. However, when the error is suppressed by > > >

Re: [RFC/RFA] [PR tree-optimization/92539] Improve code and avoid Warray-bounds false positive

2025-01-09 Thread Jeff Law
On 1/9/25 10:48 AM, Qing Zhao wrote: I think Jeff's patch is not reasonable since it boils down to not diagnose -Warray-bounds but instead remove those stmts. If these stmts are dead-code that are generated by compiler optimization (NOT from source code), removing them before diagnosis is

[PATCH] c/c++: UX improvements to 'too {few, many} arguments' errors (v2) [PR118112]

2025-01-09 Thread David Malcolm
Here's v2 of the patch. I only changed the C++ parts, for the nits identified by Marek. I didn't attempt to add coverage for the objc++ method stuff. Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Are the C++ parts OK for trunk? (Joseph already approved the C parts) Thanks Dave

[PATCH] c, c++: preserve type name in conversion [PR116060]

2025-01-09 Thread Jason Merrill
I spent way too long poking at various adjustments of this; here's what I settled on for GCC 15. Tested x86_64-pc-linux-gnu, applying to trunk. -- 8< -- When the program requests a conversion to a typedef, let's try harder to remember the new name. Torbjörn's original patch changed the type of

Re: [RFC/RFA] [PR tree-optimization/92539] Improve code and avoid Warray-bounds false positive

2025-01-09 Thread Qing Zhao
> On Jan 9, 2025, at 14:10, Jeff Law wrote: > > > > On 1/9/25 10:48 AM, Qing Zhao wrote: > >>> >>> I think Jeff's patch is not reasonable since it boils down to not diagnose >>> -Warray-bounds but instead remove those stmts. >> If these stmts are dead-code that are generated by compiler op

<    1   2