[PATCH v2] c++/modules: Remove unnecessary errors when not writing compiled module

2024-08-20 Thread Nathaniel Shead
On Mon, Aug 19, 2024 at 12:55:22PM -0400, Jason Merrill wrote: > On 8/18/24 8:11 AM, Nathaniel Shead wrote: > > Bootstrapped and regtested on x86_64-pc-linux-gnu, OK for trunk? > > > > Or should we even just remove the warning entirely? I'm not sure it > > really adds all that much, since it's us

Re: [PATCH] c++/modules: Avoid rechecking initializers when streaming NTTPs [PR116382]

2024-08-20 Thread Nathaniel Shead
On Mon, Aug 19, 2024 at 01:38:56PM -0400, Jason Merrill wrote: > On 8/16/24 2:55 AM, Nathaniel Shead wrote: > > Bootstrapped and regtested on x86_64-pc-linux-gnu, OK for trunk? > > Maybe also skip the unshare_constructor when !check_init? OK either way. > Makes sense, thanks. This is what I'll

Re: [Ping x 3, Fortran, Patch, coarray, PR84246, v2] Fix for [Coarray] ICE in conv_caf_send, at fortran/trans-intrinsic.c:1950

2024-08-20 Thread Andre Vehreschild
Hi Jerry, thanks for the review. Committed as: gcc-15-3035-g35f56012806 Thanks again, Andre On Mon, 19 Aug 2024 08:46:45 -0700 Jerry D wrote: > On 8/19/24 4:43 AM, Andre Vehreschild wrote: > > Hi all, > > > > another ping on this patch. > > > > Regtests ok on x86_64-pc-linux-gnu on upd

RE: [optc-save-gen.awk] Fix streaming of command line options for offloading

2024-08-20 Thread Prathamesh Kulkarni
> -Original Message- > From: Richard Biener > Sent: Monday, August 19, 2024 6:51 PM > To: Prathamesh Kulkarni > Cc: Andrew Pinski ; gcc-patches@gcc.gnu.org; Thomas > Schwinge > Subject: RE: [optc-save-gen.awk] Fix streaming of command line options > for offloading > > External email:

[PATCH v1] Match: Support form 4 for unsigned integer .SAT_TRUNC

2024-08-20 Thread pan2 . li
From: Pan Li This patch would like to support the form 4 of the unsigned integer .SAT_TRUNC. Aka below example: Form 4: #define DEF_SAT_U_TRUC_FMT_4(NT, WT) \ NT __attribute__((noinline)) \ sat_u_truc_##WT##_to_##NT##_fmt_4 (WT x) \ {

Re: [PATCH 4/4] rs6000, Add tests and documentation for vector, conversions between integer and float

2024-08-20 Thread Kewen.Lin
Hi Carl, on 2024/8/8 01:15, Carl Love wrote: > > >  GCC maintainers: > > The following patch fixes errors in the definition of the > __builtin_vsx_uns_floate_v2di, __builtin_vsx_uns_floato_v2di and > __builtin_vsx_uns_float2_v2di built-ins.  The arguments should be unsigned > but are listed

RE: [PATCH v1] Vect: Promote unsigned .SAT_ADD constant operand for vectorizable_call

2024-08-20 Thread Tamar Christina
Hi Pan, > -Original Message- > From: Li, Pan2 > Sent: Tuesday, August 20, 2024 1:58 AM > To: Tamar Christina ; Jakub Jelinek > > Cc: Richard Biener ; gcc-patches@gcc.gnu.org; > juzhe.zh...@rivai.ai; kito.ch...@gmail.com; jeffreya...@gmail.com; > rdapp@gmail.com; Liu, Hongtao > Subje

Re: [PATCH ver 2] rs6000,extend and document built-ins vec_test_lsbb_all_ones and vec_test_lsbb_all_zeros

2024-08-20 Thread Kewen.Lin
Hi Carl, on 2024/8/9 23:57, Carl Love wrote: > > Gcc maintainers: > > Version 2, based on discussion additional overloaded instances of the > vec_test_lsbb_all_ones and, vec_test_lsbb_all_zeros built-ins has been added.  > The additional instances are for arguments of vector signed char and ve

Re: [PATCH 3/3] libcpp: add AVX2 helper

2024-08-20 Thread Richard Biener
On Thu, Aug 8, 2024 at 7:44 PM Alexander Monakov wrote: > > > > On Wed, 7 Aug 2024, Richard Biener wrote: > > > > > OK with that change. > > > > > > Did you think about a AVX512 version (possibly with 32 byte vectors)? > > > In case there's a more efficient variant of pshufb/pmovmskb available > >

Re: [PATCH]: Fix PR testsuite/116271, gcc.dg/vect/tsvc/vect-tsvc-s176.c fails

2024-08-20 Thread Richard Biener
On Fri, Aug 9, 2024 at 2:03 AM Joern Wolfgang Rennecke wrote: > > In the previous patch to reduce iteration counts, I have overlooked > that, in the inner loop of s176, the array index i+m-j-1 > turns negativeat for higher iterations of the middle loop for small m. > m and the iteration end of the

Re: [PATCH] MATCH: add abs support for half float

2024-08-20 Thread Richard Biener
On Fri, Aug 9, 2024 at 2:39 AM Kugan Vivekanandarajah wrote: > > Thanks for the comments. > > > On 2 Aug 2024, at 8:36 pm, Richard Biener > > wrote: > > > > External email: Use caution opening links or attachments > > > > > > On Fri, Aug 2, 2024 at 11:20 AM Kugan Vivekanandarajah > > wrote: > >

Re: [PATCH] vect: Multistep float->int conversion only with no trapping math

2024-08-20 Thread Richard Biener
On Fri, Aug 9, 2024 at 2:58 PM Juergen Christ wrote: > > Am Thu, Aug 08, 2024 at 02:06:44PM +0200 schrieb Richard Biener: > > On Mon, Aug 5, 2024 at 4:02 PM Juergen Christ wrote: > > > > > > Am Mon, Aug 05, 2024 at 01:00:31PM +0200 schrieb Richard Biener: > > > > On Fri, Aug 2, 2024 at 2:43 PM Ju

Re: [PR middle-end/114635] Set OMP safelen handling to INT_MAX when the pragma didn’t provide one.

2024-08-20 Thread Kugan Vivekanandarajah
ping? Any feedback. Thanks, Kugan From: Kugan Vivekanandarajah Sent: Monday, 5 August 2024 3:05 PM To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org ; richard.guent...@gmail.com ; richard.sandif...@arm.com Subject: Re: [PR middle-end/114635] Set OMP safelen handl

[pushed] wwwdocs: gcc-12: Editorial changes to the D section

2024-08-20 Thread Gerald Pfeifer
I pushed these three changes to the D section in the GCC 12 release notes. (The C in GDC already stands for compiler, so GDC compiler is redundant.) Gerald --- htdocs/gcc-12/changes.html | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/htdocs/gcc-12/changes.html b/

Re: [PATCH 3/3] Match: Add pattern for `(a ? b : 0) | (a ? 0 : c)` into `a ? b : c` [PR103660]

2024-08-20 Thread Richard Biener
On Tue, Aug 13, 2024 at 6:31 AM Andrew Pinski wrote: > > This adds a pattern to convert `(a ? b : 0) | (a ? 0 : c)` into `a ? b : c` > which is simplier. It adds both for cond and vec_cond; even though vec_cond is > handled via a different pattern currently but requires extra steps for > matching

Re: [PATCH 1/3] testsuite: Add testcases for part of PR 103660

2024-08-20 Thread Richard Biener
On Tue, Aug 13, 2024 at 6:31 AM Andrew Pinski wrote: > > IOR part of the bug report was fixed by r13-4620-g4d9db4bdd458 but > that added only aarch64 specific testcases. This adds 4 > generic testcases for this to check to make sure they are optimized. > The C++ testcases are the vector type versi

Re: [PATCH 2/3] match: extend the `((a CMP b) ? c : 0) | ((a CMP' b) ? d : 0)` patterns to support ^ and + [PR103660]

2024-08-20 Thread Richard Biener
On Tue, Aug 13, 2024 at 6:31 AM Andrew Pinski wrote: > > r13-4620-g4d9db4bdd458 Added a few patterns and some of them can be extended > to support XOR and PLUS. > This extends the patterns to support XOR and PLUS instead of just IOR. > > Bootstrapped and tested on x86_64-linux-gnu. OK. >

RE: [PATCH v1] Vect: Promote unsigned .SAT_ADD constant operand for vectorizable_call

2024-08-20 Thread Li, Pan2
Thanks Tamar for comments and explanations. > But because you've now matched here, another pattern can't match > anymore, and more importantly, it prevents is from trying any alternative way > to vectorize this (if there was one). > That's why the pattern matcher shouldn't knowingly accept somet

Re: FIXED_REGISTERS / ira_no_alloc_regs: aarch64 vs. risc-v (was Re: sched1 pathology on RISC-V : PR/114729)

2024-08-20 Thread Richard Sandiford
Vineet Gupta writes: > On 8/19/24 14:52, Richard Sandiford wrote: >>> 2. On RISC-V sched1 is counter intuitively assuming HARD_FP is live due to >>> the weird interaction of DF infra (which always marks HARD_FP with >>> artificial def) and ira_no_alloc_regs. >> In general, it isn't possible to pr

Re: [PATCH] rust: avoid clobbering LIBS

2024-08-20 Thread dkm
August 12, 2024 at 4:09 PM, "Arthur Cohen" wrote: > > Hi Marc, > > Patch looks good to me :) Thanks! > Hello, thanks for the Ack :) I'm still waiting for a maintainer review... I've been told this may qualify as "trivial", but again, I would prefer a formal Ack as I'm not really an exper

Re: [PATCH] Update LDPT_REGISTER_CLAIM_FILE_HOOK_V2 linker plugin hook

2024-08-20 Thread Richard Biener
On Wed, Aug 14, 2024 at 3:15 PM H.J. Lu wrote: > > The new hook allows the linker plugin to distinguish calls to > claim_file_handler that know the object is being used by the linker > (from ldmain.c:add_archive_element), from calls that don't know it's > being used by the linker (from elf_link_is

Re: [PATCH] vect: Multistep float->int conversion only with no trapping math

2024-08-20 Thread Juergen Christ
Am Tue, Aug 20, 2024 at 10:15:22AM +0200 schrieb Richard Biener: > On Fri, Aug 9, 2024 at 2:58 PM Juergen Christ wrote: > > > > Am Thu, Aug 08, 2024 at 02:06:44PM +0200 schrieb Richard Biener: > > > On Mon, Aug 5, 2024 at 4:02 PM Juergen Christ > > > wrote: > > > > > > > > Am Mon, Aug 05, 2024 a

Re: [PATCH V3 08/10] rs6000: Adjust altivec dot-product backend patterns

2024-08-20 Thread Kewen.Lin
Hi Victor, on 2024/8/15 16:44, Victor Do Nascimento wrote: > Following the migration of the dot_prod optab from a direct to a > conversion-type optab, ensure all back-end patterns incorporate the > second machine mode into pattern names. This patch is OK, thanks! BR, Kewen > > gcc/ChangeLog: >

Re: [PATCH] Use add_name_and_src_coords_attributes in modified_type_die

2024-08-20 Thread Richard Biener
On Wed, Jul 24, 2024 at 9:32 PM Tom Tromey wrote: > > While working on a patch to the Ada compiler, I found a spot in > dwarf2out.cc that calls add_name_attribute where a call to > add_name_and_src_coords_attributes would be better, because the latter > respects DECL_NAMELESS. If the point is DEC

Re: [PATCH v4] diagnostics: Follow DECL_ORIGIN in lhd_print_error_function [PR102061]

2024-08-20 Thread Richard Biener
On Sun, Aug 11, 2024 at 5:46 AM Peter Damianov wrote: > > Currently, if a warning references a cloned function, the name of the cloned > function will be emitted in the "In function 'xyz'" part of the diagnostic, > which users aren't supposed to see. This patch follows the DECL_ORIGIN link > to ge

Re: [PATCH V3 10/10] autovectorizer: Test autovectorization of different dot-prod modes.

2024-08-20 Thread Richard Biener
On Thu, Aug 15, 2024 at 10:46 AM Victor Do Nascimento wrote: > > From: Victor Do Nascimento > > Given the novel treatment of the dot product optab as a conversion, we > are now able to targe different relationships between output modes and > input modes. > > This is made clearer by way of example

Re: [PATCH] Tweak base/index disambiguation in decompose_normal_address [PR116236]

2024-08-20 Thread Richard Biener
On Thu, Aug 15, 2024 at 4:57 PM Jeff Law wrote: > > > > On 8/15/24 2:50 AM, Richard Sandiford wrote: > > The PR points out that, for an address like: > > > >(plus (zero_extend X) Y) > > > > decompose_normal_address doesn't establish a strong preference > > between treating X as the base or Y a

Re: [PATCH 0/7] v3 of libdiagnostics

2024-08-20 Thread Richard Biener
On Thu, Aug 15, 2024 at 8:13 PM David Malcolm wrote: > > Here's v3 of my patch kit for "libdiagnostics", which makes GCC's > diagnostics subsystem available as a shared library; see: > https://gcc.gnu.org/wiki/libdiagnostics So this is to make use of this from gas? Is the plan to move sources

Re: [PATCH v2 10/10] fortran: Add -finline-intrinsics flag for MINLOC/MAXLOC [PR90608]

2024-08-20 Thread Mikael Morin
Hello, Le 19/08/2024 à 21:44, Harald Anlauf a écrit : Hi Mikael, apart from patch #04/10, which did not apply cleanly here, I was able to test your patch.  It seems to work with a manual workaround (-fno-frontend-optimize) to work around this problem. Might be a local issue... Huh? That's unex

Re: [PATCH v1] Provide new GCC builtin __builtin_get_counted_by [PR116016]

2024-08-20 Thread Richard Biener
On Tue, Aug 13, 2024 at 5:34 PM Qing Zhao wrote: > > With the addition of the 'counted_by' attribute and its wide roll-out > within the Linux kernel, a use case has been found that would be very > nice to have for object allocators: being able to set the counted_by > counter variable without knowi

Re: [PATCH] Tweak base/index disambiguation in decompose_normal_address [PR116236]

2024-08-20 Thread Richard Sandiford
Richard Biener writes: > On Thu, Aug 15, 2024 at 4:57 PM Jeff Law wrote: >> >> >> >> On 8/15/24 2:50 AM, Richard Sandiford wrote: >> > The PR points out that, for an address like: >> > >> >(plus (zero_extend X) Y) >> > >> > decompose_normal_address doesn't establish a strong preference >> > b

RE: [PATCH V3 10/10] autovectorizer: Test autovectorization of different dot-prod modes.

2024-08-20 Thread Tamar Christina
> -Original Message- > From: Richard Biener > Sent: Tuesday, August 20, 2024 10:37 AM > To: Victor Do Nascimento > Cc: gcc-patches@gcc.gnu.org; Tamar Christina ; > claz...@gmail.com; hongtao@intel.com; s...@gcc.gnu.org; bernds_cb1@t- > online.de; al...@redhat.com; Victor Do Nascimento

[PATCH] Align predicates for operands[1] between mov and *mov_internal.

2024-08-20 Thread liuhongt
>From [1] > > It's not obvious to me why movv16qi requires a nonimmediate_operand > > source, especially since ix86_expand_vector_mode does have code to > > cope with constant operand[1]s. emit_move_insn_1 doesn't check the > > predicates anyway, so the predicate will have little effect. > > > > A

Re: [PATCH] Align predicates for operands[1] between mov and *mov_internal.

2024-08-20 Thread Hongtao Liu
On Tue, Aug 20, 2024 at 6:25 PM liuhongt wrote: > > From [1] [1] https://gcc.gnu.org/pipermail/gcc-patches/2024-August/660575.html > > > It's not obvious to me why movv16qi requires a nonimmediate_operand > > > source, especially since ix86_expand_vector_mode does have code to > > > cope with con

[RFC] early vector boolean lowering

2024-08-20 Thread Tamar Christina
Hi, As you know I've been working on removing the code that demotes GIMPLE COND_EXPR to GENERIC during vect_recog_bool_pattern. To restate why, The issue we currently have today is that the mask (boolean argument of a COND_EXPR) is not always available during pattern matching. This is a problem

[RFC] Support single lane SLP early break

2024-08-20 Thread Tamar Christina
Hi, I've been working on a prototype of moving early break to SLP. As we've discussed on IRC I've decided to first try adding the gconds as roots and start SLP discovery using them as roots. This works great and doesn't require any changed to build_slp, it also has the additional benefit in that

Re: [PATCH] Do not emit a redundant DW_TAG_lexical_block for inlined subroutines

2024-08-20 Thread Richard Biener
On Fri, Aug 16, 2024 at 12:49 PM Bernd Edlinger wrote: > > While this already works correctly for the case when an inlined > subroutine contains only one subrange, a redundant DW_TAG_lexical_block > is still emitted when the subroutine has multiple blocks. Huh. The point is that the inline conte

Re: [PATCH] Align predicates for operands[1] between mov and *mov_internal.

2024-08-20 Thread Uros Bizjak
On Tue, Aug 20, 2024 at 12:25 PM liuhongt wrote: > > From [1] > > > It's not obvious to me why movv16qi requires a nonimmediate_operand > > > source, especially since ix86_expand_vector_mode does have code to > > > cope with constant operand[1]s. emit_move_insn_1 doesn't check the > > > predicate

Re: [PATCH] testsuite: Add -fwrapv to signbit-5.c

2024-08-20 Thread Richard Biener
On Fri, Aug 16, 2024 at 4:30 PM Torbjorn SVENSSON wrote: > > > > On 2024-08-16 16:07, Jeff Law wrote: > > > > > > On 8/16/24 4:12 AM, Torbjörn SVENSSON wrote: > >> Ok for trunk and releases/gcc-14? > >> > >> Verified this on x86_64 and arm-none-eabi. > >> Don't know if the other "truth type" dg-li

Re: [RFC/RFA] [PATCH v2 09/12] Add symbolic execution support.

2024-08-20 Thread Richard Biener
On Fri, Aug 16, 2024 at 4:33 PM Jeff Law wrote: > > > > On 8/12/24 5:13 AM, Matevos Mehrabyan wrote: > > > > On Fri, Aug 2, 2024, 14:25 Richard Biener > > mailto:richard.guent...@gmail.com>> wrote: > > > On Wed, Jul 31, 2024 at 12:42 PM Mariam Arutunian > > > mailto:mariamarutun.

Re: [PATCH] libcpp: Adjust lang_defaults

2024-08-20 Thread Richard Biener
On Fri, Aug 16, 2024 at 7:58 PM Jakub Jelinek wrote: > > Hi! > > Here it is in patch form, at the same time I've turned it into bit-fields. > On x86_64-linux, this reduced .rodata by 532 bytes (so 5.75x reduction > of the variable) and grew the cpp_set_lang function by 26 bytes (8.4% > growth). >

Re: [PATCH v1] Vect: Promote unsigned .SAT_ADD constant operand for vectorizable_call

2024-08-20 Thread Richard Biener
On Sat, Aug 17, 2024 at 11:18 PM Jakub Jelinek wrote: > > On Sat, Aug 17, 2024 at 05:03:14AM +, Li, Pan2 wrote: > > Please feel free to let me know if there is anything I can do to fix this > > issue. Thanks a lot. > > There is no bug. The operands of .{ADD,SUB,MUL}_OVERFLOW don't have to ha

[Fortran, Patch, PR86468, v1] Fix propagation of corank to array components in derived types.

2024-08-20 Thread Andre Vehreschild
Hi all, attached patch fixes an ICE in gimplify by assuring that the corank of a non-pointer, non-coarray array component in a derived type is zero. Previously (erroneously) the full corank of the type has been used. There is one exception for pointer typed array components in coarray derived type

[RFC/RFA][PATCH v4 06/12] aarch64: Implement new expander for efficient CRC computation

2024-08-20 Thread Mariam Arutunian
This patch introduces two new expanders for the aarch64 backend, dedicated to generate optimized code for CRC computations. The new expanders are designed to leverage specific hardware capabilities to achieve faster CRC calculations, particularly using the crc32, crc32c and pmull instructions when

[PATCH] PR target/116365: Add user-friendly arguments to --param aarch64-autovec-preference=N

2024-08-20 Thread Jennifer Schmitz
The param aarch64-autovec-preference=N is a useful tool for testing auto-vectorisation in GCC as it allows the user to force a particular strategy. So far, N could be an numerical value between 0 and 4. This patch adds more user-friendly names to distinguish the options. For backwards compatibility

Re: [RFC/RFA][PATCH v3 06/12] aarch64: Implement new expander for efficient CRC computation

2024-08-20 Thread Mariam Arutunian
I sent the new version and added you as a co-author. Thanks, Mariam On Fri, Aug 16, 2024 at 7:25 PM Mariam Arutunian wrote: > > > On Fri, Aug 9, 2024 at 7:22 PM Richard Sandiford < > richard.sandif...@arm.com> wrote: > >> Sorry again for the slow review. :( >> >> I only really looked at the unr

Re: [PATCH] Re-add calling emit_clobber in lower-subreg.cc's resolve_simple_move.

2024-08-20 Thread Xianmiao Qu
On Fri, Aug 16, 2024 at 10:29:23PM +0800, Xianmiao Qu wrote: > On Tue, Aug 13, 2024 at 09:58:31PM -0600, Jeff Law wrote: > > Note this changes target independent code. So it needs to be bootstrapped > > and regression tested on one of the primary platforms: > > > > > The primary platforms are: >

Re: [PATCH 2/2] phiopt: Reject non gimple val inside factor_out_conditional_operation [PR116412]

2024-08-20 Thread Richard Biener
On Mon, Aug 19, 2024 at 8:38 PM Andrew Pinski wrote: > > After the conversion to use maybe_push_res_to_seq, sometimes (REALPART_EXPR > and IMAGPART_EXPR and VCE) the argument will not be a gimple value and > then phiopt here would create an invalid PHI. > Just add a check for gimple val is the way

Re: [PATCH 1/2] phi-opt: Fix for non-const functions for factor_out_conditional_operation [PR 116409]

2024-08-20 Thread Richard Biener
On Mon, Aug 19, 2024 at 8:38 PM Andrew Pinski wrote: > > Currently maybe_push_res_to_seq does not handle non-const builtins (it does > handle internal > functions though). I think it simply assumes they are const ... if we can indeed verify this we should make it match the builtin behavior. > S

Re: [Ping x2 , Fortran, Patch, PR77518, (coarray), v4] Fix ICE in sizeof(coarray)

2024-08-20 Thread Andre Vehreschild
Hi all, pinging this patch. Regtests ok on x86_64-pc-linux-gnu / Fedora 39. Ok for mainline? Regards, Andre On Fri, 9 Aug 2024 16:30:52 +0200 Andre Vehreschild wrote: > Ping! > > @Paul, you already had a look at this patch, but I made some changes. Or they > ok? > > - Andre > > On Fri

RE: [PATCH] testsuite: Add -fwrapv to signbit-5.c

2024-08-20 Thread Tamar Christina
> -Original Message- > From: Richard Biener > Sent: Tuesday, August 20, 2024 12:33 PM > To: Torbjorn SVENSSON > Cc: Jeff Law ; gcc-patches@gcc.gnu.org; Richard > Earnshaw ; quic_apin...@quicinc.com; > yvan.r...@foss.st.com; Tamar Christina > Subject: Re: [PATCH] testsuite: Add -fwrapv to

Re: [PATCH] vect: Multistep float->int conversion only with no trapping math

2024-08-20 Thread Richard Biener
On Tue, Aug 20, 2024 at 11:16 AM Juergen Christ wrote: > > Am Tue, Aug 20, 2024 at 10:15:22AM +0200 schrieb Richard Biener: > > On Fri, Aug 9, 2024 at 2:58 PM Juergen Christ wrote: > > > > > > Am Thu, Aug 08, 2024 at 02:06:44PM +0200 schrieb Richard Biener: > > > > On Mon, Aug 5, 2024 at 4:02 PM

Re: [PATCH V3 10/10] autovectorizer: Test autovectorization of different dot-prod modes.

2024-08-20 Thread Richard Biener
On Tue, Aug 20, 2024 at 12:04 PM Tamar Christina wrote: > > > -Original Message- > > From: Richard Biener > > Sent: Tuesday, August 20, 2024 10:37 AM > > To: Victor Do Nascimento > > Cc: gcc-patches@gcc.gnu.org; Tamar Christina ; > > claz...@gmail.com; hongtao@intel.com; s...@gcc.gnu

RE: [PATCH V3 10/10] autovectorizer: Test autovectorization of different dot-prod modes.

2024-08-20 Thread Tamar Christina
> -Original Message- > From: Richard Biener > Sent: Tuesday, August 20, 2024 1:54 PM > To: Tamar Christina > Cc: Victor Do Nascimento ; gcc- > patc...@gcc.gnu.org; claz...@gmail.com; hongtao@intel.com; > s...@gcc.gnu.org; bernds_...@t-online.de; al...@redhat.com; Victor Do > Nasciment

[PATCH] testsuite: i386: Fix g++.target/i386/pr116275-2.C on Solaris/x86

2024-08-20 Thread Rainer Orth
The new g++.target/i386/pr116275-2.C test FAILs on 32-bit Solaris/x86: FAIL: g++.target/i386/pr116275-2.C scan-assembler vpslld This happens because Solaris defaults to -mstackrealign, disabling -mstv. Fixed by disabling the former and enabling the latter. Tested on i386-pc-solaris2.11 and x8

[PATCH 1/2]middle-end: refactor type to be explicit in operand_equal_p [PR114932]

2024-08-20 Thread Tamar Christina
Hi All, This is a refactoring with no expected behavioral change. The goal with this is to make the type of the expressions being used explicit. I did not change all the recursive calls to operand_equal_p () to recurse directly to the new function but instead this goes through the top level call

[PATCH 2/2]middle-end: use two's complement equality when comparing IVs during candidate selection [PR114932]

2024-08-20 Thread Tamar Christina
Hi All, IVOPTS normally uses affine trees to perform comparisons between different IVs, but these seem to have been missing in two key spots and instead normal tree equivalencies used. In some cases where we have a two-complements equivalence but not a strict signedness equivalencies we end up ge

Re: [PATCH] testsuite: i386: Fix g++.target/i386/pr116275-2.C on Solaris/x86

2024-08-20 Thread Uros Bizjak
On Tue, Aug 20, 2024 at 3:06 PM Rainer Orth wrote: > > The new g++.target/i386/pr116275-2.C test FAILs on 32-bit Solaris/x86: > > FAIL: g++.target/i386/pr116275-2.C scan-assembler vpslld > > This happens because Solaris defaults to -mstackrealign, disabling -mstv. > > Fixed by disabling the for

Re: [PATCH v4] Improve bad error message with stray semicolon in initializer (and related) [PR101232]

2024-08-20 Thread Franciszek Witt
Thanks for the feedback. I am attatching fixed patch as a file. Regards Franciszek On Mon, 19 Aug 2024, 18:32 Jason Merrill, wrote: > On 8/19/24 12:01 PM, Jason Merrill wrote: > > On 8/19/24 6:01 AM, Jonathan Wakely wrote: > >> On 05/08/24 09:32 +0200, Franciszek Witt wrote: > >>> Author: Franc

[PATCH v1] RISC-V: Fix one typo in .SAT_TRUNC test func name [NFC]

2024-08-20 Thread pan2 . li
From: Pan Li Fix one typo `sat_truc` to `sat_trunc`, as well as `SAT_TRUC` to `SAT_TRUNC`. gcc/testsuite/ChangeLog: * gcc.target/riscv/sat_arith.h: Fix SAT_TRUNC typo. * gcc.target/riscv/sat_u_trunc-1.c: Ditto. * gcc.target/riscv/sat_u_trunc-13.c: Ditto. * gcc.ta

Re: [PATCH] (Re: Splitting up 27_io/basic_istream/ignore/wchar_t/94749.cc (takes too long))

2024-08-20 Thread Jonathan Wakely
On Wed, 14 Aug 2024 at 15:47, Hans-Peter Nilsson wrote: > > > From: Vaseeharan Vinayagamoorthy > > Date: Sat, 22 Jun 2024 01:38:09 + > > Sorry for the late reply. I sort of hoped somebody else > would chime in. Maybe the issue has resolved itself in the > meantime? > > > Hi, > > > > I have

Re: [PATCH] Update LDPT_REGISTER_CLAIM_FILE_HOOK_V2 linker plugin hook

2024-08-20 Thread H.J. Lu
On Tue, Aug 20, 2024 at 2:03 AM Richard Biener wrote: > > On Wed, Aug 14, 2024 at 3:15 PM H.J. Lu wrote: > > > > The new hook allows the linker plugin to distinguish calls to > > claim_file_handler that know the object is being used by the linker > > (from ldmain.c:add_archive_element), from call

Re: [PATCH 5/5] libstdc++: Restore unrolling in std::find using pragma [PR116140]

2024-08-20 Thread Jonathan Wakely
On Fri, 9 Aug 2024 at 10:29, Alex Coplan wrote: > > Together with the preparatory compiler patches, this patch restores > unrolling in std::__find_if, but this time relying on the compiler to do > it by using: > > #pragma GCC unroll 4 > > which should restore the majority of the regression relat

Re: [PATCH,c++,wwwdocs] bugs: Remove old "export" non-bug

2024-08-20 Thread Jonathan Wakely
On Mon, 5 Aug 2024 at 19:36, Gerald Pfeifer wrote: > > On Mon, 22 Jul 2024, Jonathan Wakely wrote: > >> We have been carrying this note on the "original" export feature for ages, > >> and I believe it's not actually a FAQ, if it ever was. > >> > >> Jonathan moved this down when adding a note on AD

Re: [PATCH] vect: Multistep float->int conversion only with no trapping math

2024-08-20 Thread Juergen Christ
Am Tue, Aug 20, 2024 at 02:51:02PM +0200 schrieb Richard Biener: > On Tue, Aug 20, 2024 at 11:16 AM Juergen Christ wrote: > > > > Am Tue, Aug 20, 2024 at 10:15:22AM +0200 schrieb Richard Biener: > > > On Fri, Aug 9, 2024 at 2:58 PM Juergen Christ > > > wrote: > > > > > > > > Am Thu, Aug 08, 2024

Re: [wwwdocs] gcc-15: Mention c++ header dependency changes () in porting_to.html

2024-08-20 Thread Jonathan Wakely
On Wed, 7 Aug 2024 at 08:09, Filip Kastl wrote: > > On Tue 2024-08-06 17:00:24, Gerald Pfeifer wrote: > > > + > > > +The following headers are used less widely in libstdc++ and may need to I like Gerald's suggestion to change this to "within libstdc++" as that is more precise about that change.

Re: [PATCH v1] Provide new GCC builtin __builtin_get_counted_by [PR116016]

2024-08-20 Thread Qing Zhao
> On Aug 20, 2024, at 05:58, Richard Biener wrote: > > On Tue, Aug 13, 2024 at 5:34 PM Qing Zhao wrote: >> >> With the addition of the 'counted_by' attribute and its wide roll-out >> within the Linux kernel, a use case has been found that would be very >> nice to have for object allocators: b

Re: [RFC] early vector boolean lowering

2024-08-20 Thread Richard Biener
On Tue, 20 Aug 2024, Tamar Christina wrote: > Hi, > > As you know I've been working on removing the code that demotes GIMPLE > COND_EXPR to GENERIC during vect_recog_bool_pattern. > > To restate why, The issue we currently have today is that the mask (boolean > argument of a COND_EXPR) is not al

Re: Subject: [PATCH 0/8] Masked load else operand.

2024-08-20 Thread Richard Biener
On Sun, 11 Aug 2024, Robin Dapp wrote: > I figured it's easier to parse this as a series rather than one big > patch, in particular since target-specific code is involved. > > This adds an else operand to masked-load operations in order to avoid > implicit dependencies on zeroed masked-out elemen

Re: [PATCH 3/8] tree-ifcvt: Enforce zero else value after maskload.

2024-08-20 Thread Richard Biener
On Tue, 13 Aug 2024, Jeff Law wrote: > > > On 8/11/24 3:00 PM, Robin Dapp wrote: > > When predicating a load we implicitly assume that the else value is > > zero. In order to formalize this this patch queries the target for > > its supported else operand and uses that for the maskload call. > >

[PATCH] ifcvt: Do not overwrite results in noce_convert_multiple_sets [PR116372, PR116405]

2024-08-20 Thread Manolis Tsamis
Now that more operations are allowed for noce_convert_multiple_sets, it is possible that the same register appears multiple times as target in a basic block. After noce_convert_multiple_sets_1 is called we potentially also emit register moves from temporaries back to the original targets. In some

[pushed] doc: Normalize reference to binutils version for C6X

2024-08-20 Thread Gerald Pfeifer
We generally do not use a hyphen between project name and version. gcc: * doc/install.texi (Specific) : Normalize reference to binutils. --- gcc/doc/install.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi index 4

Re: [PATCH v4] Improve bad error message with stray semicolon in initializer (and related) [PR101232]

2024-08-20 Thread Jason Merrill
On 8/20/24 9:11 AM, Franciszek Witt wrote: Thanks for the feedback. I am attatching fixed patch as a file. Pushed, thanks. Regards Franciszek On Mon, 19 Aug 2024, 18:32 Jason Merrill, > wrote: On 8/19/24 12:01 PM, Jason Merrill wrote: > On 8/19/24 6:01 AM,

Re: [PATCH v2] c++/modules: Remove unnecessary errors when not writing compiled module

2024-08-20 Thread Jason Merrill
On 8/20/24 3:02 AM, Nathaniel Shead wrote: On Mon, Aug 19, 2024 at 12:55:22PM -0400, Jason Merrill wrote: On 8/18/24 8:11 AM, Nathaniel Shead wrote: Bootstrapped and regtested on x86_64-pc-linux-gnu, OK for trunk? Or should we even just remove the warning entirely? I'm not sure it really adds

Re: [PATCH v1] RISC-V: Fix one typo in .SAT_TRUNC test func name [NFC]

2024-08-20 Thread Jeff Law
On 8/20/24 7:11 AM, pan2...@intel.com wrote: From: Pan Li Fix one typo `sat_truc` to `sat_trunc`, as well as `SAT_TRUC` to `SAT_TRUNC`. gcc/testsuite/ChangeLog: * gcc.target/riscv/sat_arith.h: Fix SAT_TRUNC typo. * gcc.target/riscv/sat_u_trunc-1.c: Ditto. * gcc.targ

[PATCH v4 0/2] Add support for AdvSIMD faminmax

2024-08-20 Thread saurabh.jha
From: Saurabh Jha This patch series is a respin of the previous patch here: https://gcc.gnu.org/pipermail/gcc-patches/2024-August/659749.html. This new version is rebased with latest master after the merging of this patch series: https://gcc.gnu.org/pipermail/gcc-patches/2024-August/660532.html.

[PATCH v4 1/2] aarch64: Add AdvSIMD faminmax intrinsics

2024-08-20 Thread saurabh.jha
The AArch64 FEAT_FAMINMAX extension is optional from Armv9.2-a and mandatory from Armv9.5-a. It introduces instructions for computing the floating point absolute maximum and minimum of the two vectors element-wise. This patch introduces AdvSIMD faminmax intrinsics. The intrinsics of this extensio

[PATCH v4 2/2] aarch64: Add codegen support for AdvSIMD faminmax

2024-08-20 Thread saurabh.jha
The AArch64 FEAT_FAMINMAX extension is optional from Armv9.2-a and mandatory from Armv9.5-a. It introduces instructions for computing the floating point absolute maximum and minimum of the two vectors element-wise. This patch adds code generation support for famax and famin in terms of existing R

[PATCH] c++: local class memfn synth from noexcept context [PR113063]

2024-08-20 Thread Patrick Palka
Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK for trunk only? -- >8 -- Extending the PR113063 testcase to additionally constant evaluate the <=> expression causes us to trip over the assert in cxx_eval_call_expression /* We used to shortcut trivial constructor/op= here,

Re: [PATCH v3 2/7] OpenMP: middle-end support for dispatch + adjust_args

2024-08-20 Thread Paul-Antoine Arras
Hi Tobias, Thanks for the review. Please find attached an updated patch following your comments. Since further adjustments to other patches of the series were required, I'll post them shortly. See also my replies below. On 09/08/2024 13:51, Tobias Burnus wrote: Paul-Antoine Arras wrote: Thi

[r15-2991 Regression] FAIL: gcc.target/i386/avx10_2-rounding-1.c (test for excess errors) on Linux/x86_64

2024-08-20 Thread haochen.jiang
On Linux/x86_64, e22e3af1954469c40b139b7cfa8e7708592f4bfd is the first bad commit commit e22e3af1954469c40b139b7cfa8e7708592f4bfd Author: Hu, Lin1 Date: Mon Aug 19 10:08:51 2024 +0800 AVX10.2 ymm rounding: Support vadd{s,d,h} and vcmp{s,d,h} intrins caused FAIL: gcc.target/i386/avx10_2-r

[r15-3000 Regression] FAIL: gcc.target/i386/avx10_2-rounding-3.c (test for excess errors) on Linux/x86_64

2024-08-20 Thread haochen.jiang
On Linux/x86_64, 3d1b5530ea1d23e26dc5ab70aa4a2e7b9dc19b50 is the first bad commit commit 3d1b5530ea1d23e26dc5ab70aa4a2e7b9dc19b50 Author: Hu, Lin1 Date: Mon Aug 19 10:09:03 2024 +0800 AVX10.2 ymm rounding: Support vcvt{,u}w2ph and vdivp{s,d,h} intrins caused FAIL: gcc.target/i386/avx10_2

[r15-2997 Regression] FAIL: gcc.target/i386/avx10_2-rounding-2.c (test for excess errors) on Linux/x86_64

2024-08-20 Thread haochen.jiang
On Linux/x86_64, 6e231f8504874828b23bbe89f3ef4086dcc15a44 is the first bad commit commit 6e231f8504874828b23bbe89f3ef4086dcc15a44 Author: Hu, Lin1 Date: Mon Aug 19 10:08:59 2024 +0800 AVX10.2 ymm rounding: Support vcvtqq2p{s,d,h} and vcvttpd2{,u}{dq,qq} intrins caused FAIL: gcc.target/i

Re: [Ping x2 , Fortran, Patch, PR77518, (coarray), v4] Fix ICE in sizeof(coarray)

2024-08-20 Thread Jerry D
On 8/20/24 5:35 AM, Andre Vehreschild wrote: Hi all, pinging this patch. Regtests ok on x86_64-pc-linux-gnu / Fedora 39. Ok for mainline? Regards, Andre Your approach looks reasonable so I think OK to push. Thanks, Jerry

Re: [PATCH 1/2] builtins: Don't expand bit query builtins for __int128_t if the target supports an optab for it

2024-08-20 Thread Richard Sandiford
Andrew Pinski writes: > On aarch64 (without !CSSC instructions), since popcount is implemented using > the SIMD instruction cnt, > instead of using two SIMD cnt (V8QI mode), it is better to use one 128bit cnt > (V16QI mode). And only one > reduction addition instead of 2. Currently fold_builtin_

[PATCH] Libquadmath: update doc for some constants

2024-08-20 Thread FX Coudert
As reported by Peter Randall, the description of three constants in libquadmath is wrong. Attached patch fixes them. OK to push? FX libquadmath/ChangeLog: * libquadmath.texi (M_LOG2Eq, M_LOG10Eq, M_2_PIq): Fix description of these constants. 0001-Libquadmath-update-doc-for

Re: [PATCH 2/2] aarch64: Implement popcountti2 pattern [PR113042]

2024-08-20 Thread Richard Sandiford
Andrew Pinski writes: > When CSSC is not enabled, 128bit popcount can be implemented > just via the vector (v16qi) cnt instruction followed by a reduction, > like how the 64bit one is currently implemented instead of > splitting into 2 64bit popcount. > > Build and tested for aarch64-linux-gnu. >

Re: [PATCH] PR target/116365: Add user-friendly arguments to --param aarch64-autovec-preference=N

2024-08-20 Thread Richard Sandiford
Jennifer Schmitz writes: > The param aarch64-autovec-preference=N is a useful tool for testing > auto-vectorisation in GCC as it allows the user to force a particular > strategy. So far, N could be an numerical value between 0 and 4. > This patch adds more user-friendly names to distinguish the op

Re: [PATCH] libcpp, v3: Add support for gnu::base64 #embed parameter

2024-08-20 Thread Joseph Myers
On Thu, 15 Aug 2024, Jakub Jelinek wrote: > +#embed __FILE__ gnu::base64(1) prefix() suffix() /* { dg-error "expected > character string literal" } */ > +#embed __FILE__ gnu::base64() prefix() suffix() /* { dg-error "expected > character string literal" } */ Maybe also test this error with a no

Re: [PATCH v2 10/10] fortran: Add -finline-intrinsics flag for MINLOC/MAXLOC [PR90608]

2024-08-20 Thread Harald Anlauf
Hi Mikael, Am 20.08.24 um 11:51 schrieb Mikael Morin: Hello, Le 19/08/2024 à 21:44, Harald Anlauf a écrit : Hi Mikael, apart from patch #04/10, which did not apply cleanly here, I was able to test your patch.  It seems to work with a manual workaround (-fno-frontend-optimize) to work around t

Re: [PATCH] Do not emit a redundant DW_TAG_lexical_block for inlined subroutines

2024-08-20 Thread Bernd Edlinger
On 8/20/24 13:00, Richard Biener wrote: > On Fri, Aug 16, 2024 at 12:49 PM Bernd Edlinger > wrote: >> >> While this already works correctly for the case when an inlined >> subroutine contains only one subrange, a redundant DW_TAG_lexical_block >> is still emitted when the subroutine has multiple b

Re: [PATCH v10 1/3] gcc/: Rename array_type_nelts() => array_type_nelts_minus_one()

2024-08-20 Thread Alejandro Colomar
Hi Jason, On Mon, Aug 19, 2024 at 12:46:13PM GMT, Jason Merrill wrote: > On 8/19/24 6:58 AM, Alejandro Colomar wrote: > > > > Link: > > https://inbox.sourceware.org/gcc-patches/9fffd80-dca-2c7e-14b-6c9b509a7...@redhat.com/T/#m2f661c67c8f7b2c405c8c7fc3152dd85dc729120 > > Cc: Gabriel Ravier > > C

[PATCH] aarch64: Fix caller saves of VNx2QI [PR116238]

2024-08-20 Thread Richard Sandiford
The testcase contains a VNx2QImode pseudo that is live across a call and that cannot be allocated a call-preserved register. LRA quite reasonably tried to save it before the call and restore it afterwards. Unfortunately, the target told it to do that in SImode, even though punning between SImode a

Re: [Committed] RISC-V: Remove testcase XFAIL

2024-08-20 Thread Edwin Lu
Thanks! Edwin On 8/19/2024 1:17 PM, Jeff Law wrote: On 8/19/24 2:14 PM, Edwin Lu wrote: The testcase has been modified to include the -fwrapv flag which now causes the test to pass. Remove the xfail exception gcc/testsuite/ChangeLog: * gcc.dg/signbit-5.c: Remove riscv xfail exception

Re: [PATCH 2/2] aarch64: Implement popcountti2 pattern [PR113042]

2024-08-20 Thread Richard Sandiford
Richard Sandiford writes: > Andrew Pinski writes: >> When CSSC is not enabled, 128bit popcount can be implemented >> just via the vector (v16qi) cnt instruction followed by a reduction, >> like how the 64bit one is currently implemented instead of >> splitting into 2 64bit popcount. >> >> Build a

[PATCH] gm2: export all libc number conversion functions

2024-08-20 Thread Wilken Gottwalt
Export all string to integral and floating point number conversion functions (atof, atoi, atol, atoll, strtod, strtof, strtold, strtol, strtoll, strtoul, strtoull). gcc/gm2: * gm2-libs/libc.def: Export all string to number conversion functions. Signed-off-by: Wilken Gottwalt --- gcc/m2/

[PATCH v11 0/4] c: Add __nelementsof__ operator

2024-08-20 Thread Alejandro Colomar
Hi! v11 changes: - Add patch for the commit checker, to allow Cc: and Link: tags. - CC += Doug, Jason - Fix changelog entries to pass the checker, following advice from Jason to remove some colons. - Move Cc: and Link: tags to below the changelog, since thanks to the new patch 1/4 th

[PATCH v11 1/4] contrib/: Add support for Cc: and Link: tags

2024-08-20 Thread Alejandro Colomar
contrib/ChangeLog: * gcc-changelog/git_commit.py: (GitCommit): Add support for 'Cc: ' and 'Link: ' tags. Cc: Jason Merrill Signed-off-by: Alejandro Colomar --- contrib/gcc-changelog/git_commit.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/contrib/gc

[PATCH v11 2/4] gcc/: Rename array_type_nelts() => array_type_nelts_minus_one()

2024-08-20 Thread Alejandro Colomar
The old name was misleading. While at it, also rename some temporary variables that are used with this function, for consistency. Link: gcc/ChangeLog: *

[PATCH v11 4/4] c: Add __nelementsof__ operator

2024-08-20 Thread Alejandro Colomar
This operator is similar to sizeof but can only be applied to an array, and returns its number of elements. FUTURE DIRECTIONS: - We should make it work with array parameters to functions, and somehow magically return the number of elements of the array, regardless of it being really a poin

  1   2   >