Re: [PATCH 2/4] c++/modules: Track module purview for deferred instantiations [PR114630]

2024-07-18 Thread Nathaniel Shead
On Thu, Jul 18, 2024 at 02:33:56PM -0400, Jason Merrill wrote: > On 7/18/24 12:33 AM, Nathaniel Shead wrote: > > On Wed, Jul 17, 2024 at 11:36:26PM -0400, Jason Merrill wrote: > > > On 7/17/24 11:04 PM, Nathaniel Shead wrote: > > > > On Wed, Jul 17, 2024 at 01:12:34PM -0400, Jason Merrill wrote: >

Re: [PATCH v10 1/3] C++: Support clang compatible [[musttail]] (PR83324)

2024-07-18 Thread Andi Kleen
Updated patch with the !retval bug fix identified by Marek. This patch implements a clang compatible [[musttail]] attribute for returns. musttail is useful as an alternative to computed goto for interpreters. With computed goto the interpreter function usually ends up very big which causes pr

RE: [PATCH v1] Match: Only allow single use of MIN_EXPR for SAT_TRUNC form 2 [PR115863]

2024-07-18 Thread Li, Pan2
Thanks Tamar for comments. The :s flag is somehow ignored in matching according the gccint doc. "The second supported flag is s which tells the code generator to fail the pattern if the expression marked with s does have more than one use and the simplification results in an expression with mor

RE: [PATCH v1] Match: Only allow single use of MIN_EXPR for SAT_TRUNC form 2 [PR115863]

2024-07-18 Thread Li, Pan2
> Otherwise the patch looks good to me. Thanks Richard, will commit with the log updated. Pan -Original Message- From: Richard Biener Sent: Thursday, July 18, 2024 9:27 PM To: Li, Pan2 Cc: gcc-patches@gcc.gnu.org; juzhe.zh...@rivai.ai; kito.ch...@gmail.com; tamar.christ...@arm.com; j

[PATCH] testsuite: Add dg-do run to even more tests, fix typo

2024-07-18 Thread Sam James
All of these are for wrong-code bugs. Confirmed to be used before but with no execution. Tested on x86_64-pc-linux-gnu and checked test logs before/after. 2024-07-18 Sam James PR target/7559 PR c++/9704 PR c++/16115 PR c++/19317 PR rtl-optimization/1153

Re: [PATCH v2] rs6000: Fix .machine cpu selection w/ altivec [PR97367]

2024-07-18 Thread Kewen.Lin
on 2024/7/18 22:14, Peter Bergner wrote: > On 7/18/24 4:14 AM, Kewen.Lin wrote: >>> +/* { dg-final { scan-assembler {\.\mmachine power4\M} } } */ >>> +/* { dg-final { scan-assembler {\.\mmachine altivec\M} } } */ >> >> Nit: Both \m looks useless and can be removed. > > Fine with me. Is that becau

RE: [r15-2135 Regression] FAIL: libgomp.oacc-fortran/privatized-ref-2.f90 -DACC_DEVICE_TYPE_host=1 -DACC_MEM_SHARED=1 -foffload=disable -Os at line 32 (test for warnings, line 31) on Linux/x86_64

2024-07-18 Thread Jiang, Haochen
Hi Paul, I suspect it is not the correct way to do that, those lines are ok since they are XFAIL. The problem is that specific warning test. Thx, Haochen From: Paul Richard Thomas Sent: Friday, July 19, 2024 12:28 AM To: haochen.jiang Cc: pa...@gcc.gnu.org; gcc-regress...@gcc.gnu.org; gcc-pat

RE: [r15-2135 Regression] FAIL: libgomp.oacc-fortran/privatized-ref-2.f90 -DACC_DEVICE_TYPE_host=1 -DACC_MEM_SHARED=1 -foffload=disable -Os at line 32 (test for warnings, line 31) on Linux/x86_64

2024-07-18 Thread Jiang, Haochen
Just did a quick test. Correct myself previously. Those lines also needs to be removed since they are XPASS now. However the real issue is the dg-note at Line 32, that is the warning disappeared. diff --git a/libgomp/testsuite/libgomp.oacc-fortran/privatized-ref-2.f90 b/libgomp/testsuite/libgomp

[PATCH] rs6000: Use standard name uabd for vabsdu insns

2024-07-18 Thread Kewen.Lin
Hi, r14-1832 adds recognition pattern, ifn and optab for ABD (ABsolute Difference), we have some vector absolute difference unsigned instructions since ISA 3.0, as the associated test cases shown, they are not exploited well as we don't define it (them) with a standard name. So this patch is to r

Re: [PATCH v6] c++: Fix constrained auto deduction in templ spec scopes [PR114915]

2024-07-18 Thread Jason Merrill
On 7/18/24 12:03 PM, Seyed Sajad Kahani wrote: When deducing auto for `adc_return_type`, `adc_variable_type`, and `adc_decomp_type` contexts (at the usage time), we try to resolve the outermost template arguments to be used for satisfaction. This is done by one of the following, depending on the

[PATCH] Reduce iteration counts of tsvc tests

2024-07-18 Thread Joern Wolfgang Rennecke
As discussed before on gcc@gcc,gnu.org, this patch reduces the iteration counts of the tsvc tests to avoid timeouts when using simulators. A few tests needed special attention because they divided "iterations" by some constant, so putting 10 in there would lead to zero iteration count, and thus

Re: [PATCH] c++: Add [dcl.init.aggr] examples to testsuite

2024-07-18 Thread Jason Merrill
On 7/18/24 8:49 AM, Jakub Jelinek wrote: Hi! When working on the #embed optimization support, I went recently through all of reshape_init_r* and today I read in detail all the P3106R1 changes and I believe we implement it that way for years. To double check that, I've added tests with the curren

Re: [PATCH v3] c++: Hash placeholder constraint in ctp_hasher

2024-07-18 Thread Jason Merrill
On 7/18/24 11:01 AM, Seyed Sajad Kahani wrote: This patch addresses a difference between the hash function and the equality function for canonical types of template parameters (ctp_hasher). The equality function uses comptypes (typeck.cc) (with COMPARE_STRUCTURAL) and checks constraint equality f

Re: [PATCH 1/2] PR 115800: Fix libgfortran build using --with-cpu=power5

2024-07-18 Thread Kewen.Lin
Hi Mike, I guess you should CC fort...@gcc.gnu.org as well. on 2024/7/11 01:25, Michael Meissner wrote: > If you build a little endian compiler and select a default CPU of power5 > (i.e. --with-cpu=power5), GCC cannot be built. The reason is that both the > libgfortran and libstdc++-v3 libraries

Re: Re: [PATCH] RISC-V: Support __mulbc3 and __divbc3 in libgcc for __bf16

2024-07-18 Thread Xiao Zeng
2024-07-18 01:53  Jeff Law wrote: > > > >On 7/17/24 2:01 AM, Xiao Zeng wrote: >> libgcc/ChangeLog: >> >> * Makefile.in: Support __divbc3 and __mulbc3. >> * libgcc2.c (if): Support BC mode for __bf16. >> (defined): Ditto. >> (MTYPE): Ditto. >> (CTYPE): Ditto. >> (AMTYPE): Ditto. >> (MODE): Ditto. >

[PATCH] testsuite: powerpc: fix dg-do run typo

2024-07-18 Thread Sam James
'dg-run' is not a valid dejagnu directive, 'dg-do run' is needed here for the test to be executed. 2024-07-18 Sam James PR target/108699 * gcc.target/powerpc/pr108699.c: Fix 'dg-run' typo. --- Kewen, could you check this on powerpc to ensure it doesn't execute beforehand and no

[PATCH v1] Internal-fn: Only allow modes describe types for internal fn[PR115961]

2024-07-18 Thread pan2 . li
From: Pan Li The direct_internal_fn_supported_p has no restrictions for the type modes. For example the bitfield like below will be recog as .SAT_TRUNC. struct e { unsigned pre : 12; unsigned a : 4; }; __attribute__((noipa)) void bug (e * v, unsigned def, unsigned use) { e & defE = *v;

RE: [PATCH] c-family: Introduce the -Winvalid-noreturn flag from clang with extra tuneability

2024-07-18 Thread Tay Joseph
Hi Jason, I’ve managed to address your review comments, and rewrite the patch to include both -Winvalid-noreturn and -Winvalid-noreturn= but have trouble figuring out how to format invoke.texi and where to add the documentation for the new warning options. I’ve also made this a Common option, since

Re: [PATCH] testsuite: powerpc: fix dg-do run typo

2024-07-18 Thread Kewen.Lin
Hi Sam, on 2024/7/19 11:28, Sam James wrote: > 'dg-run' is not a valid dejagnu directive, 'dg-do run' is needed here > for the test to be executed. > > 2024-07-18 Sam James > > PR target/108699 > * gcc.target/powerpc/pr108699.c: Fix 'dg-run' typo. > --- > Kewen, could you check th

Re: [PATCH] c-family: Introduce the -Winvalid-noreturn flag from clang with extra tuneability

2024-07-18 Thread Julian Waters
Darn, not even sending it from my friend's mail account worked to combat the patch formatting issues. Not only is the patch a complete wreck on the mailing list archive, but my friend's mail account has now somehow merged into mine on the list, resulting in a truly confusing author display name. I

Re: [PATCH] c-family: Introduce the -Winvalid-noreturn flag from clang with extra tuneability

2024-07-18 Thread Sam James
Julian Waters writes: > Darn, not even sending it from my friend's mail account worked to combat the > patch formatting issues. Not only is the > patch a complete wreck on the mailing list archive, but my friend's mail > account has now somehow merged into mine on the > list, resulting in a tru

<    1   2