[committed] testsuite: Require lra effective target for pr107385.c

2024-02-15 Thread Jakub Jelinek
Hi! Old reload doesn't support asm goto with output operands. We have lra effective target (though, strangely it returns 0 just for 2 targets out of at least 16 targets with no LRA support), so this patch uses it, similarly how it is done in other asm goto tests with output operands. Tested on x8

Re: [PATCH] libgccjit: Clear pending_assemble_externals_processed

2024-02-15 Thread Antoni Boucher
It's OK to merge even though it touches files outside of the jit directory and we're in stage 4? Or do we need some kind of approval? On Thu, 2024-02-15 at 10:35 -0500, David Malcolm wrote: > On Thu, 2024-02-08 at 17:09 -0500, Antoni Boucher wrote: > > Hi. > > This patch fixes the bug 113842. > >

Re: [PATCH] libgccjit: Clear pending_assemble_externals_processed

2024-02-15 Thread David Malcolm
On Thu, 2024-02-15 at 14:14 -0500, Antoni Boucher wrote: > It's OK to merge even though it touches files outside of the jit > directory and we're in stage 4? > Or do we need some kind of approval? I think this patch is sufficiently low-risk that you can go ahead and merge it. Dave > > On Thu, 2

Re: [PATCH] Turn on LRA on all targets

2024-02-15 Thread Sam James
Sam James writes: > [[PGP Signed Part:Undecided]] > > "Maciej W. Rozycki" writes: > >> On Sun, 23 Apr 2023, Segher Boessenkool wrote: >> >>> > There are extra ICEs in regression testing and code quality is poor; cf. >>> > .

[PATCH] libgccjit: Do not treat warnings as errors

2024-02-15 Thread Antoni Boucher
Hi. This patch makes libgccjit treat warnings as warnings instead of errors in order to continue the compilation when there are warnings. One thing I'm not sure what to do about is that warnings will keep overriding first_error as long as there are no errors. What behavior should we have here? Th

[PATCH] bpf: add inline memmove and memcpy expansion

2024-02-15 Thread David Faust
BPF programs are not typically linked, which means we cannot fall back on library calls to implement __builtin_{memmove,memcpy} and should always expand them inline if possible. GCC already successfully expands these builtins inline in many cases, but failed to do so for a few for simple cases inv

[pushed] analyzer: remove offset_region size overloads [PR111266]

2024-02-15 Thread David Malcolm
PR analyzer/111266 reports a missing -Wanalyzer-out-of-bounds when accessing relative to a concrete byte offset. Root cause is that offset_region::get_{byte,bit}_size_sval were attempting to compute the size that's valid to access, rather than the size of the access attempt. Fixed by removing the

[PATCH] c++/modules: relax diagnostic about GMF contents

2024-02-15 Thread Patrick Palka
Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK for trunk? -- >8 -- Issuing a hard error when the GMF doesn't contain preprocessing directives is inconvenient for automated testcase reduction via cvise. This patch relaxes this diagnostic into a pedwarn. gcc/cp/ChangeLog:

[PATCH] c++/modules: stream TREE_UNAVAILABLE and LAMBDA_EXPR_REGEN_INFO

2024-02-15 Thread Patrick Palka
Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK for trunk? -- >8 -- gcc/cp/ChangeLog: * module.cc (trees_out::core_bools): Stream TREE_UNAVAILABLE. (trees_in::core_bools): Likewise. (trees_out::core_vals): Stream LAMBDA_EXPR_REGEN_INFO. (trees

Re: [PATCH] c++/modules: stream TREE_UNAVAILABLE and LAMBDA_EXPR_REGEN_INFO

2024-02-15 Thread Jason Merrill
On 2/15/24 16:11, Patrick Palka wrote: Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK for trunk? OK. -- >8 -- gcc/cp/ChangeLog: * module.cc (trees_out::core_bools): Stream TREE_UNAVAILABLE. (trees_in::core_bools): Likewise. (trees_out::core_vals

Re: [PATCH] c++/modules: relax diagnostic about GMF contents

2024-02-15 Thread Jason Merrill
On 2/15/24 16:10, Patrick Palka wrote: Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look OK for trunk? -- >8 -- Issuing a hard error when the GMF doesn't contain preprocessing directives is inconvenient for automated testcase reduction via cvise. This patch relaxes this diagnost

Re: [PATCH] c++: implicit move with throw [PR113853]

2024-02-15 Thread Jason Merrill
On 2/15/24 10:19, Marek Polacek wrote: Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? -- >8 -- Here we have template auto is_throwable(T t) -> decltype(throw t, true) { ... } where we didn't properly mark 't' as IMPLICIT_RVALUE_P, which caused the wrong overload to have bee

[COMMITTED] libgomp: Update documentation for indirect calls in target regions

2024-02-15 Thread Kwok Cheung Yeung
Hi, I have committed this patch to the libgomp documentation to reflect that indirect calls in offloaded target regions are now supported in C, C++ and Fortran. KwokFrom b3b3bd250f0a7c22b7d46d3522c8b94c6a35d22a Mon Sep 17 00:00:00 2001 From: Kwok Cheung Yeung Date: Thu, 15 Feb 2024 21:22:26

Re: [PATCH v5 13/14] c++: Implement __rank built-in trait

2024-02-15 Thread Patrick Palka
On Thu, 15 Feb 2024, Ken Matsui wrote: > This patch implements built-in trait for std::rank. > > gcc/cp/ChangeLog: > > * cp-trait.def: Define __rank. > * semantics.cc (trait_expr_value): Handle CPTK_RANK. > (finish_trait_expr): Likewise. > > gcc/testsuite/ChangeLog: > >

Re: [PATCH] c++/modules: relax diagnostic about GMF contents

2024-02-15 Thread Patrick Palka
On Thu, 15 Feb 2024, Jason Merrill wrote: > On 2/15/24 16:10, Patrick Palka wrote: > > Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look > > OK for trunk? > > > > -- >8 -- > > > > Issuing a hard error when the GMF doesn't contain preprocessing > > directives is inconvenient for a

[PATCH] libgccjit: Add option to allow special characters in function names

2024-02-15 Thread Antoni Boucher
Hi. This patch adds a new option to allow special characters like . and $ in function names. This is useful to allow for mangling using those characters. Thanks for the review. From 89a92e561ca83a622dcc22a6500ca2b17551edb1 Mon Sep 17 00:00:00 2001 From: Antoni Boucher Date: Thu, 15 Feb 2024 17:03:

[PATCH] c++: wrong looser exception spec with deleted fn

2024-02-15 Thread Marek Polacek
Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? IMHO trivial enough to go ahead now seeing as it doesn't introduce new errors. -- >8 -- I noticed we don't implement the "unless the overriding function is defined as deleted" wording added to [except.spec] via CWG 1351. DR 135

[PATCH] c++: wrong looser excep spec for dep noexcept [PR113158]

2024-02-15 Thread Marek Polacek
Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? By the ??? below I mean that maybe_instantiate_noexcept could return a tristate, and then maybe_check_overriding_exception_spec could check if (maybe_instantiate_noexcept ().is_unknown ()) return true; and we don't have to add an

Re: [PATCH] Turn on LRA on all targets

2024-02-15 Thread Paul Koning
> On May 15, 2023, at 5:09 PM, Maciej W. Rozycki wrote: > > ... > > I may choose to implement a non-DWARF unwinder instead, as the VAX stack > frame is always fully described by the hardware and there is never ever a > need for debug information to be able to decode any VAX stack frame (the

Re: [PATCH] Turn on LRA on all targets

2024-02-15 Thread Segher Boessenkool
On Thu, Feb 15, 2024 at 07:34:32PM +, Sam James wrote: > I have now started doing this in PR113932. Thank you! Segher

[PATCH] testsuite: Fix vfprintf-chk-1.c with -fhardened

2024-02-15 Thread Sam James
With _FORTIFY_SOURCE >= 2 (enabled by -fhardened), vfprintf-chk-1.c's __vfprintf_chk ends up calling __vprintf_chk rather than vprintf. ``` --- a/fortify.s +++ b/no-fortify.s @@ -8,27 +8,28 @@ [...] __vfprintf_chk: [...] movl$1, should_optimize(%rip) - jmp __vfprintf_chk +

Re: [PATCH] Notes on the warnings-as-errors change in GCC 14

2024-02-15 Thread Gerald Pfeifer
On Thu, 15 Feb 2024, Florian Weimer wrote: >> Naive questions: Can definitions really be prototypes (in C)? > Yes, I think so: definitions can be declarations, and function > prototypes are declarations. The standard uses the phrase “function > definition that does not include a function prototype

Re: Question on -fwrapv and -fwrapv-pointer

2024-02-15 Thread Kees Cook
On Thu, Feb 15, 2024 at 12:32:17AM -0800, Fangrui Song wrote: > On Fri, Sep 15, 2023 at 11:43 AM Kees Cook via Gcc-patches > wrote: > > > > On Fri, Sep 15, 2023 at 05:47:08PM +, Qing Zhao wrote: > > > > > > > > > > On Sep 15, 2023, at 1:26 PM, Richard Biener > > > > wrote: > > > > > > > > >

Re: [PATCH] Turn on LRA on all targets

2024-02-15 Thread Paul Koning
> On Feb 15, 2024, at 5:56 PM, Segher Boessenkool > wrote: > > On Thu, Feb 15, 2024 at 07:34:32PM +, Sam James wrote: >> I have now started doing this in PR113932. > > Thank you! > > Segher Presumably this isn't for version 14 since it's in a late stage, right? I have my bits about r

[PATCH v6 13/14] c++: Implement __rank built-in trait

2024-02-15 Thread Ken Matsui
This patch implements built-in trait for std::rank. gcc/cp/ChangeLog: * cp-trait.def: Define __rank. * semantics.cc (trait_expr_value): Handle CPTK_RANK. (finish_trait_expr): Likewise. gcc/testsuite/ChangeLog: * g++.dg/ext/has-builtin-1.C: Test existence of __ran

Re: [PATCH v5 13/14] c++: Implement __rank built-in trait

2024-02-15 Thread Ken Matsui
On Thu, Feb 15, 2024 at 1:48 PM Patrick Palka wrote: > > On Thu, 15 Feb 2024, Ken Matsui wrote: > > > This patch implements built-in trait for std::rank. > > > > gcc/cp/ChangeLog: > > > > * cp-trait.def: Define __rank. > > * semantics.cc (trait_expr_value): Handle CPTK_RANK. > >

Re: [PATCH v5 13/14] c++: Implement __rank built-in trait

2024-02-15 Thread Ken Matsui
On Thu, Feb 15, 2024 at 6:14 PM Ken Matsui wrote: > > On Thu, Feb 15, 2024 at 1:48 PM Patrick Palka wrote: > > > > On Thu, 15 Feb 2024, Ken Matsui wrote: > > > > > This patch implements built-in trait for std::rank. > > > > > > gcc/cp/ChangeLog: > > > > > > * cp-trait.def: Define __rank. >

Re: [PATCH] RISC-V: Add new option -march=help to print all supported extensions

2024-02-15 Thread Kito Cheng
Thanks for the test and review, pushed :) On Thu, Feb 15, 2024 at 6:43 PM Christoph Müllner wrote: > > On Thu, Feb 15, 2024 at 10:56 AM Kito Cheng wrote: > > > > The output of -march=help is like below: > > > > ``` > > All available -march extensions for RISC-V: > > NameV

[PATCH 2/2 V2] rs6000: Load store fusion for rs6000 target using common infrastructure

2024-02-15 Thread Ajit Agarwal
Hello All: This patch is for load store fusion for rs6000 target using common infrastructure. Common infrastructure using generic code for load store fusion of rs6000 target. Generic code are implemented and defined that can be used in target specific code for aarch64 and rs6000 target. Gene

[PATCH] bpf: Add documentation for the -mcpu option

2024-02-15 Thread Will Hawkins
Add documentation describing the meaning and values for the -mcpu command-line option. Tested for bpf-unknown-none on x86_64-linux-gnu host. gcc/ChangeLog: * config/bpf/bpf.opt: Add help information for -mcpu. Signed-off-by: Will Hawkins --- gcc/config/bpf/bpf.opt | 2 ++ 1 file chang

<    1   2