Re: [PATCH] tree-object-size: Always set computed bit for bdos [PR113012]

2023-12-19 Thread Siddhesh Poyarekar
On 2023-12-19 17:57, Jakub Jelinek wrote: On Mon, Dec 18, 2023 at 11:42:52AM -0500, Siddhesh Poyarekar wrote: It is always safe to set the computed bit for dynamic object sizes at the end of collect_object_sizes_for because even in case of a dependency loop encountered in nested calls, we have a

[PATCH #2v2/2] strub: sparc64: unbias the stack address [PR112917]

2023-12-19 Thread Alexandre Oliva
On Dec 15, 2023, Richard Biener wrote: > It might be worth amending the documentation in case this > is unexpected to users? Oh, yes indeed, thanks! Here's a patch that brings relevant parts of the implementation comment to the user-facing documentation, so that it reflects the change in implem

Re: [PATCH] strub: avoid lto inlining

2023-12-19 Thread Alexandre Oliva
On Dec 15, 2023, Richard Biener wrote: > I think __noipa__ is more complete and will make the libgcc functions appear > as black boxes to callers. I was hesitant to use __noipa__ because I thought it might disable relevant optimizations even when not using LTO, but it is likely safer in the long

Re: [PATCH 1/4; v3] options: add gcc/regenerate-opt-urls.py

2023-12-19 Thread Joseph Myers
On Thu, 14 Dec 2023, David Malcolm wrote: > diff --git a/gcc/doc/sourcebuild.texi b/gcc/doc/sourcebuild.texi > index 26a7e9c35070..9a394b3e2c77 100644 > --- a/gcc/doc/sourcebuild.texi > +++ b/gcc/doc/sourcebuild.texi > @@ -813,6 +813,10 @@ options supported by this target (@pxref{Run-time > Targe

Re: [PATCH 0/4] v3 of: Option handling: add documentation URLs

2023-12-19 Thread Joseph Myers
On Thu, 14 Dec 2023, David Malcolm wrote: > Are these OK for trunk, assuming I followup with adding CI for this? > (that said, I disappear for the rest of 2023 at the end of this week, so > I'd work on the CI in early January) Patches 2 (updated at the time of commit to reflect the latest options

Re: [PATCH] fold-const: Handle AND, IOR, XOR with stepped vectors [PR112971].

2023-12-19 Thread Andrew Pinski
On Tue, Dec 19, 2023 at 2:40 AM Richard Sandiford wrote: > > Richard Biener writes: > > On Tue, 19 Dec 2023, juzhe.zh...@rivai.ai wrote: > > > >> Hi, Richard. > >> > >> After investigating the codes: > >> /* Return true if EXPR is the integer constant zero or a complex constant > >>of zero, o

Re: [PATCH] i386: Allow 64 bit mask register for -mno-evex512

2023-12-19 Thread Hongtao Liu
On Fri, Dec 15, 2023 at 10:34 AM Haochen Jiang wrote: > > Hi all, > > There is a recent change in AVX10 documentation which allows 64 bit mask > register instructions in AVX10-256, the documentation comes following: > > Intel Advanced Vector Extensions 10 (Intel AVX10) Architecture Specification >

Re: Re: [PATCH] fold-const: Handle AND, IOR, XOR with stepped vectors [PR112971].

2023-12-19 Thread juzhe.zh...@rivai.ai
Thanks Andrew. Ok. I think I can apply suggestions from both you and Richards. That is, fix it in const_binop but with creating new helper function simplify_const_binop (suggestion from Richard). But I don't know how to write codes in simplify_const_ binop... Could you give me some hints ?

[PATCH FYI] -finline-stringops: copy timeout factor from memcmp-1.c test

2023-12-19 Thread Alexandre Oliva
Hi, Jeff, On Dec 18, 2023, Jeff Law wrote: > These are timing sporadically on the embedded platforms. Given they > include a test that has a timeout factor, it seems to me you should > duplicate the timeout factor in the new tests. > Remember when you include another file, the dg- directives

[PATCH v1] RISC-V: Bugfix for the const vector in single steps

2023-12-19 Thread pan2 . li
From: Pan Li For generating the const vector with single step, we have code gen similar as below. We have npatterns = 4. v1= {3, 2, 1, 0, 7, 6, 5, 4, 11, 10, 9, 8... } v2 (diff) = {3 - 0, 2 - 1, 1 - 2, 0 - 3, 7 - 4, 6 - 5, 5 - 6, 4 - 7...} = {3, 1, -1, 3, 3, 1, -1, 3 ...} v1 = vd +

Re: [PATCH v1] RISC-V: Bugfix for the const vector in single steps

2023-12-19 Thread juzhe.zh...@rivai.ai
+ if (known_eq (ele_0 - 0, ele_n - v.npatterns ())) -> for (i = 0; i < v.npatterns (); ) check each nelt of npatterns is equal to vid. juzhe.zh...@rivai.ai From: pan2.li Date: 2023-12-20 10:39 To: gcc-patches CC: juzhe.zhong; pan2.li; yanzhang.wang; kito.cheng Subject: [PATCH v1] RI

[PATCH] -finline-stringops: allow expansion into edges [PR113002]

2023-12-19 Thread Alexandre Oliva
Builtin expanders for memset and memcpy may involve conditionals and loops, but their sequences may be end up emitted in edges. Alas, commit_one_edge_insertion rejects sequences that end with a jump, a requirement that makes sense for insertions after expand, but not so much during expand. Duri

Re: [PATCH v26 00/23] Optimize type traits compilation performance

2023-12-19 Thread Sandra Loosemore
On 12/6/23 22:11, Ken Matsui wrote: This patch series optimizes type traits compilation performance by implementing built-in type traits and using them in libstdc++. I'm finding that all the new g++.dg/ext/is_*.C testcases added by this patch series are failing due to the "#include ". If that

Re: [PATCH FYI] -finline-stringops: copy timeout factor from memcmp-1.c test

2023-12-19 Thread Jeff Law
On 12/19/23 19:32, Alexandre Oliva wrote: Hi, Jeff, On Dec 18, 2023, Jeff Law wrote: These are timing sporadically on the embedded platforms. Given they include a test that has a timeout factor, it seems to me you should duplicate the timeout factor in the new tests. Remember when you

Re: [PATCH 0/2] LoongArch: Fix PR113033 and clean up code

2023-12-19 Thread Chenghui Pan
The patches are look ok and no problem in spec2017 correctness check. On 2023/12/19 15:26, chenglulu wrote: We will read and test these patches as soon as possible. Thanks! 在 2023/12/19 下午2:59, Xi Ruoyao 写道: Superseds https://gcc.gnu.org/pipermail/gcc-patches/2023-December/640871.html. Per J

Re: [PATCH v1] RISC-V: Bugfix for the const vector in single steps

2023-12-19 Thread Jeff Law
On 12/19/23 19:50, juzhe.zh...@rivai.ai wrote: +   if (known_eq (ele_0 - 0, ele_n - v.npatterns ())) -> for (i = 0; i < v.npatterns (); )   check each nelt of npatterns is equal to vid. Pan -- please indicate what testing was performed. The standard is to test with and without the p

[committed] Stop forcing unsigned bitfields on mcore

2023-12-19 Thread Jeff Law
The GCC manual has a whole section on signedness of bitfields with the ultimate conclusion that the property really isn't an ABI issue, but instead a C dialect issue (agreed). Furthermore it concludes that all targets should behave the same by default. So it was a mistake for the mcore port

[committed][gcc-wwwdocs] Add blurb about bitfield signedness on mcore

2023-12-19 Thread Jeff Law
Pushed to the trunk. jeffcommit e56dc0003729ea6f7d26594dae34d218543edb49 Author: Jeff Law Date: Tue Dec 19 21:28:03 2023 -0700 Document that bitfields are signed on mcore now. diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html index eb14e09d..11c7ca7e 100644 --- a/htdo

RE: [PATCH v1] RISC-V: Bugfix for the const vector in single steps

2023-12-19 Thread Li, Pan2
Oh, I see. Thanks Jeff for suggestion, will refine the commit log in V2. Pan -Original Message- From: Jeff Law Sent: Wednesday, December 20, 2023 12:03 PM To: juzhe.zh...@rivai.ai; Li, Pan2 ; gcc-patches Cc: Wang, Yanzhang ; kito.cheng Subject: Re: [PATCH v1] RISC-V: Bugfix for the c

Fortran: Use non conflicting file extensions for intermediates [PR81615]

2023-12-19 Thread Rimvydas Jasinskas
Dear all, In the spirit of c/c++ using the .i/.ii extensions for intermediates, use the .fi/.fii intermediate extensions for gfortran fixed/free form sources when -save-temps is invoked to avoid various issues. The documentation part will be submitted separately, because it involves adding a "Dev

Problems with strub tests

2023-12-19 Thread Jeff Law
So the strub tests in c-c++-common are problematical. They get run twice, once for C, once for C++. Yet the name of the test is the same in both runs. (by the name, I mean the name emitted into the dejagnu summary and log files). Thus if you have a test in there which passes in one contex

Re: [PATCH] untyped calls: enable target switching [PR112334]

2023-12-19 Thread Jeff Law
On 12/11/23 21:44, Alexandre Oliva wrote: untyped calls: use wrapper class type for implicit plus_one Instead of get and set macros to apply a delta, use a single macro that resorts to a temporary wrapper class to apply it. To be combined (or not) with the previous patch. I'd be OK with

Re: [PATCH] contrib: add git gcc-style alias

2023-12-19 Thread Jeff Law
On 12/11/23 20:00, Jason Merrill wrote: OK for trunk? -- 8< -- I thought it could be easier to use check_GNU_style.py. With this alias, 'git gcc-style' will take a git revision as argument instead of a file, or check HEAD if no argument is given. contrib/ChangeLog: * gcc-git-custo

Re: [PATCH] tree-object-size: Clean up unknown propagation

2023-12-19 Thread Jeff Law
On 12/19/23 10:21, Siddhesh Poyarekar wrote: Narrow down scope of the unknowns bitmap so that it is only accessible within the reexamination process. This also removes any role of unknown propagation from object_sizes_set, thus simplifying that code path a bit. gcc/ChangeLog: * tree

Re: [PATCH v2 1/3] RISC-V: movmem for RISCV with V extension

2023-12-19 Thread Jeff Law
On 12/19/23 02:53, Sergei Lewis wrote: gcc/ChangeLog * config/riscv/riscv.md (movmem): Use riscv_vector::expand_block_move, if and only if we know the entire operation can be performed using one vector load followed by one vector store gcc/testsuite/ChangeLog PR target

Re: [PATCH v2 2/3] RISC-V: setmem for RISCV with V extension

2023-12-19 Thread Jeff Law
On 12/19/23 02:53, Sergei Lewis wrote: gcc/ChangeLog * config/riscv/riscv-protos.h (riscv_vector::expand_vec_setmem): New function declaration. * config/riscv/riscv-string.cc (riscv_vector::expand_vec_setmem): New function: this generates an inline vectorised memory set,

Re: [PATCH 5/5][_Hashtable] Prefer to insert after last node

2023-12-19 Thread François Dumont
Here is a new version of this patch. The previous one had some flaws that were unnoticed by testsuite tests, only the performance tests were spotting it. So I'm adding checks on the consistency of the unordered containers in this patch. I also forget to signal that after this patch gnu versio

[PATCH] compare_tests: distinguish c-c++-common results by tool

2023-12-19 Thread Alexandre Oliva
On Dec 20, 2023, Jeff Law wrote: > So the strub tests in c-c++-common are problematical. They get run > twice, once for C, once for C++. Yet the name of the test is the same > in both runs. (by the name, I mean the name emitted into the dejagnu > summary and log files). > Thus if you have a t

[PATCH] RISC-V: Fix bug of VSETVL fusion

2023-12-19 Thread Juzhe-Zhong
This patch fixes bugs in the fusion of this following case: li a5,-1 vmv.s.x v0,a5 -> demand any non-zero AVL vsetvli a5, ... Incorrect fusion after VSETVL PASS: li a5,-1 vsetvli a5... vmv.s.x v0, a5 --> a5 is modified as incorrect value. We disallow this incorrect fusion above. Full coverage

[PATCH] RISC-V: Optimize SELECT_VL codegen when length is known as smaller than VF

2023-12-19 Thread Juzhe-Zhong
While trying to fix bugs of PR113097, notice this following situation we generate redundant vsetvli _255 = SELECT_VL (3, POLY_INT_CST [4, 4]); COND_LEN (..., _255) Before this patch: vsetivli a5, 3... ... vadd.vv (use a5) After this patch: ... vadd.vv (use AVL = 3) The reason we can do this i

[PATCH v2] RISC-V: Bugfix for the const vector in single steps

2023-12-19 Thread pan2 . li
From: Pan Li This patch would like to fix the below execution failure. FAIL: gcc.dg/vect/pr92420.c -flto -ffat-lto-objects execution test The will be one single step const vector like { -4, 4, -3, 5, -2, 6, -1, 7, ...}. For such const vector generation with single step, we will generate vid +

Re: [PATCH v2] RISC-V: Bugfix for the const vector in single steps

2023-12-19 Thread juzhe.zh...@rivai.ai
+ bool diff_seq_repeated_p = true; + + for (unsigned i = 0; i < v.npatterns (); i++) + { + poly_int64 diff_0 = rtx_to_poly_int64 (builder.elt (i)) - i; + poly_int64 diff_1 = rtx_to_poly_int64 ( + builder.elt (v.

Re: [aarch64] PR111702 - ICE in insert_regs after interleave+zip1 vector initialization patch

2023-12-19 Thread Prathamesh Kulkarni
On Mon, 4 Dec 2023 at 14:44, Prathamesh Kulkarni wrote: > > On Thu, 23 Nov 2023 at 17:06, Prathamesh Kulkarni > wrote: > > > > Hi Richard, > > For the test-case mentioned in PR111702, compiling with -O2 > > -frounding-math -fstack-protector-all results in following ICE during > > cse2 pass: > > >

[PATCH v4 1/3] RISC-V: Add crypto vector builtin function.

2023-12-19 Thread Feng Wang
Patch v4:Merge crypto vector function.def into vector. Patch v3:Define a shape for vaesz and merge vector-crypto-types.def into riscv-vector-builtins-types.def. Patch v2:Optimize function_shape class for crypto_vector. This patch add the intrinsic funtions of crypto vector based on the in

[PATCH v4 2/3] RISC-V: Add crypto machine descriptions

2023-12-19 Thread Feng Wang
Patch v4: Add process of SEW=64 in RV32 system. Patch v3: Moidfy constrains for crypto vector. Patch v2: Add crypto vector ins into RATIO attr and use vr as destination register. This patch add the crypto machine descriptions(vector-crypto.md) and some new iterators which are used by crypto vector

[PATCH v4 3/3] RISC-V: Add crypto vector api-testing cases.

2023-12-19 Thread Feng Wang
Patch v4: Add some RV32 vx constraint testcase. Patch v3: Refine crypto vector api-testing cases. Patch v2: Update march info according to the change of riscv-common.c This patch add crypto vector api-testing cases based on https://github.com/riscv-non-isa/rvv-intrinsic-doc/blob/eopc/vector-crypto

Re: [PATCH v4 2/3] RISC-V: Add crypto machine descriptions

2023-12-19 Thread juzhe.zh...@rivai.ai
+ (and:VI + (match_operand:VI 3 "register_operand" "vr, vr, vr, vr") + (not:VI (match_operand:VI 4 "register_operand" "vr, vr, vr, vr"))) Swap the order: (not:VI (match_operand:VI 4 "register_operand" "vr, vr, vr, vr") (and:VI (match_operand:VI 3 "regi

Re: [PATCH] fold-const: Handle AND, IOR, XOR with stepped vectors [PR112971].

2023-12-19 Thread Richard Biener
On Tue, 19 Dec 2023, Andrew Pinski wrote: > On Tue, Dec 19, 2023 at 2:40?AM Richard Sandiford > wrote: > > > > Richard Biener writes: > > > On Tue, 19 Dec 2023, juzhe.zh...@rivai.ai wrote: > > > > > >> Hi, Richard. > > >> > > >> After investigating the codes: > > >> /* Return true if EXPR is the

Re: Ping Re: [PATCH] contrib: add git gcc-style alias

2023-12-19 Thread Richard Biener
On Tue, Dec 19, 2023 at 6:41 PM Jason Merrill wrote: > > On 12/11/23 22:00, Jason Merrill wrote: > > OK for trunk? > > Ping. CCing Alex because this could plausibly be considered build > machinery, and he's had useful feedback on my sh code before. OK in case Alex doesn't have any comments. Btw

Re: [PATCH] gprofng: a new GNU profiler

2023-12-19 Thread Richard Biener
On Thu, Dec 14, 2023 at 2:23 AM wrote: > > From: Vladimir Mezentsev > > This is fixes for releases/gcc-13 for 31109 gprofng not built and installed > in a combined binutils+gcc build > I only cherry-picked 24552056fd5fc677c0d032f54a5cad1c4303d312 and tested my > build. I don't think a combined

Re: [PATCH #2v2/2] strub: sparc64: unbias the stack address [PR112917]

2023-12-19 Thread Richard Biener
On Wed, Dec 20, 2023 at 12:51 AM Alexandre Oliva wrote: > > On Dec 15, 2023, Richard Biener wrote: > > > It might be worth amending the documentation in case this > > is unexpected to users? > > Oh, yes indeed, thanks! > > Here's a patch that brings relevant parts of the implementation comment >

Re: [PATCH] -finline-stringops: allow expansion into edges [PR113002]

2023-12-19 Thread Richard Biener
On Wed, Dec 20, 2023 at 3:54 AM Alexandre Oliva wrote: > > > Builtin expanders for memset and memcpy may involve conditionals and > loops, but their sequences may be end up emitted in edges. Alas, > commit_one_edge_insertion rejects sequences that end with a jump, a > requirement that makes sense

<    1   2