Re: [PATCH] testsuite: Tweak xfail bogus g++.dg/warn/Wstringop-overflow-4.C:144, PR106120

2023-11-22 Thread Richard Biener
On Wed, Nov 22, 2023 at 3:04 AM Hans-Peter Nilsson wrote: > > I added that xfail in February for { ilp32 && c++98_only } and it > looks like it's moved on to lp64 now. :-/ Noted by Rainer > Orth, see the PR. > > Tested cris-elf and x86_64-pc-linux-gnu w/wo. -m32. > Ok to commit? OK > -- >8 -- >

Re: [PATCH v4] DSE: Allow vector type for get_stored_val when read < store

2023-11-22 Thread Richard Biener
On Wed, Nov 22, 2023 at 3:30 AM Li, Pan2 wrote: > > Hi Richard S, > > Thanks a lot for reviewing and comments. May I know is there any concern or > further comments for landing this patch to GCC-14? It looks like Jeff approved the patch? Richard. > Pan > > -Original Message- > From: Li

Re: [PATCH #2/4] c++: mark short-enums as packed

2023-11-22 Thread Alexandre Oliva
On Nov 20, 2023, Jason Merrill wrote: > I think the warning is wrong here. Interesting... Yeah, your analysis makes perfect sense. Still, we're left with a divergence WRT the TYPE_PACKED status of enum types between C and C++. It sort of kind of makes sense to mark short enums as packed, beca

Re: [PATCH] call maybe_return_this in build_clone

2023-11-22 Thread Alexandre Oliva
On Nov 20, 2023, Jason Merrill wrote: > So it only passed on that platform before because of the bug? I'm not sure it passed (we've had patches for that testcase before), but I didn't look closely enough into their history to tell. I suspected the warning suppression machinery changed, or detai

Re: [PATCH V2 1/3]rs6000: update num_insns_constant for 2 insns

2023-11-22 Thread Kewen.Lin
Hi, on 2023/11/15 11:02, Jiufu Guo wrote: > Hi, > > Trunk gcc supports more constants to be built via two instructions: e.g. > "li/lis; xori/xoris/rldicl/rldicr/rldic". > And then num_insns_constant should also be updated. > > Function "rs6000_emit_set_long_const" is used to build complicate > c

Re: [committed] sanitizer: Fix build on SPARC/Solaris with Solaris as [PR112562]

2023-11-22 Thread Rainer Orth
Hi Jakub, > Solaris as apparently doesn't accept %function and requires @function > instead. actually, it's the other way round: Solaris/x86 as cannot handle %function, but requires @function. Solaris/SPARC as is similar (requires #function instead), but is unaffected: sanitizer_asm.h disables A

Re: [PATCH V2 2/3] Using pli to split 34bits constant

2023-11-22 Thread Kewen.Lin
Hi, on 2023/11/15 11:02, Jiufu Guo wrote: > Hi, > > For constants with 16bit values, 'li or lis' can be used to generate > the value. For 34bit constant, 'pli' is ok to generate the value. > For example: 0xULL, "pli 3,1717986918; rldimi 3,3,32,0" > can be used. Since now if emit

Re: PING^1 [PATCH v3] sched: Change no_real_insns_p to no_real_nondebug_insns_p [PR108273]

2023-11-22 Thread Kewen.Lin
on 2023/11/17 20:55, Alexander Monakov wrote: > > On Fri, 17 Nov 2023, Kewen.Lin wrote: >>> I don't think you can run cleanup_cfg after sched_init. I would suggest >>> to put it early in schedule_insns. >> >> Thanks for the suggestion, I placed it at the beginning of haifa_sched_init >> instead, s

Re: [PATCH, v3] Fortran: restrictions on integer arguments to SYSTEM_CLOCK [PR112609]

2023-11-22 Thread Mikael Morin
Le 21/11/2023 à 23:09, Harald Anlauf a écrit : Uhh, it happened again.  Attached a wrong patch. Only looked at the -v3 ...  My bad. Sorry! Harald On 11/21/23 22:54, Harald Anlauf wrote: Hi Mikael, Steve, On 11/21/23 12:33, Mikael Morin wrote: Harald, you mentioned the lack of GFC_STD_F2023

Re: [PATCH] ARM/testsuite: Use non-capturing parentheses with pr53447-5.c

2023-11-22 Thread Richard Earnshaw
On 22/11/2023 01:40, Maciej W. Rozycki wrote: Use non-capturing parentheses for the subexpressions used with `scan-assembler-times', to avoid a quirk with double-counting.     gcc/testsuite/     * gcc.target/arm/pr53447-5.c: Use non-capturing parentheses with     `scan-assemble

[PATCH 0/5] Add support for operand-specific alignment requirements

2023-11-22 Thread juzhe.zh...@rivai.ai
Hi, Richard. Thanks for supporting register filter in IRA/LRA. I found it is useful for RVV since we have a set of widen operations that allow source register overlap highpart of dest register group For example, if vsext.vf2 v0(dest consume reg v0 and reg v1), v1 (source consume v1 only) I want

[PATCH] arm: [MVE intrinsics] Fix typo

2023-11-22 Thread Christophe Lyon
In commt 0c2037d9d93a8f768cb11698ff794278246bb31f (Add support for contiguous loads and stores), I added a spurious line which broke bootstrap because of an unused variable error. This patch removes it. Committed as obvious. 2023-11-22 Christophe Lyon gcc/ChangeLog: * config/arm/arm

[PATCH] c++, v4: Implement C++26 P2741R3 - user-generated static_assert messages [PR110348]

2023-11-22 Thread Jakub Jelinek
On Tue, Nov 21, 2023 at 10:51:36PM -0500, Jason Merrill wrote: > Actually, let's go back to the previous message, but change the tf_nones > above to 'complain' so that we see those errors and then this explanation. > Likewise with the conversion checks later in the function. So like this? Besides

Re: RISC-V: Support XTheadVector extensions

2023-11-22 Thread Christoph Müllner
Hi Juzhe, Sorry for the late reply, but I was not on CC, so I missed this email. On Fri, Nov 17, 2023 at 2:41 PM juzhe.zh...@rivai.ai wrote: > > Ok. I just read the theadvector extension. > > https://github.com/T-head-Semi/thead-extension-spec/blob/master/xtheadvector.adoc > > Theadvector is not

Re: [PATCH 0/5] Add support for operand-specific alignment requirements

2023-11-22 Thread Richard Sandiford
"juzhe.zh...@rivai.ai" writes: > Hi, Richard. > > Thanks for supporting register filter in IRA/LRA. > I found it is useful for RVV since we have a set of widen operations that > allow source register overlap highpart of dest register group > > For example, if vsext.vf2 v0(dest consume reg v0 and

[PATCH]AArch64: fix aarch64_usubw pattern

2023-11-22 Thread Tamar Christina
Hi All, It looks like during my pre-commit testrun I forgot to apply this patch to the patch stack. It had a typo in the element size. It also looks like since the hi/lo operations take different element counts for the assembler syntax that I can't have a unified pattern. This splits it into tw

RE: [PATCH]AArch64: fix aarch64_usubw pattern

2023-11-22 Thread Kyrylo Tkachov
Hi Tamar, > -Original Message- > From: Tamar Christina > Sent: Wednesday, November 22, 2023 10:20 AM > To: gcc-patches@gcc.gnu.org > Cc: nd ; Richard Earnshaw ; > Marcus Shawcroft ; Kyrylo Tkachov > ; Richard Sandiford > Subject: [PATCH]AArch64: fix aarch64_usubw pattern > > Hi All, >

Re: PING^1 [PATCH v3] sched: Change no_real_insns_p to no_real_nondebug_insns_p [PR108273]

2023-11-22 Thread Richard Biener
On Wed, Nov 22, 2023 at 10:31 AM Kewen.Lin wrote: > > on 2023/11/17 20:55, Alexander Monakov wrote: > > > > On Fri, 17 Nov 2023, Kewen.Lin wrote: > >>> I don't think you can run cleanup_cfg after sched_init. I would suggest > >>> to put it early in schedule_insns. > >> > >> Thanks for the suggesti

[PATCH] tree: Fix up try_catch_may_fallthru [PR112619]

2023-11-22 Thread Jakub Jelinek
Hi! The following testcase ICEs with -std=c++98 since r14-5086 because block_may_fallthru is called on a TRY_CATCH_EXPR whose second operand is a MODIFY_EXPR rather than STATEMENT_LIST, which try_catch_may_fallthru apparently expects. I've been wondering whether that isn't some kind of FE bug and

[committed] testsuite: Add testcase for already fixed PR112518

2023-11-22 Thread Jakub Jelinek
Hi! This PR has been fixed by the PR112526 fix. Tested on x86_64-linux and i686-linux, committed to trunk as obvious. 2023-11-22 Jakub Jelinek PR target/65368 * gcc.target/i386/bmi2-pr112518.c: New test. --- gcc/testsuite/gcc.target/i386/bmi2-pr112518.c.jj2023-11-21 19:

Re: Fix 'gcc.dg/tree-ssa/return-value-range-1.c' for 'char' defaulting to 'unsigned' (was: Propagate value ranges of return values)

2023-11-22 Thread Christophe Lyon
Hi! On Tue, 21 Nov 2023 at 22:24, Thomas Schwinge wrote: > > Hi! > > On 2023-11-19T16:05:42+0100, Jan Hubicka wrote: > > --- /dev/null > > +++ b/gcc/testsuite/gcc.dg/tree-ssa/return-value-range-1.c > > Pushed to master branch commit a0240662b22312ffb3e3fefb85f258ab0e7010f4 > "Fix 'gcc.dg/tree-ss

Re: Darwin: Replace environment runpath with embedded [PR88590]

2023-11-22 Thread Iain Sandoe
Hi FX, > On 17 Nov 2023, at 14:20, FX Coudert wrote: > >>> I have done a full rebuild, and having looked more at the structure of >>> libtool.m4 I am now convinced that having that line outside of the scope of >>> _LT_DARWIN_LINKER_FEATURES is simply wrong (probably a copy-pasto or >>> leftov

[PATCH] RISC-V: Fix incorrect use of vcompress in permutation auto-vectorization

2023-11-22 Thread Juzhe-Zhong
This patch fixes following FAILs on zvl512b of RV32 system: FAIL: gcc.target/riscv/rvv/autovec/struct/struct_vect_run-12.c execution test FAIL: gcc.target/riscv/rvv/autovec/struct/struct_vect_run-9.c execution test The root cause is that for permutation indice = {0,3,7,0} use vcompress optimizat

Re: Darwin: Replace environment runpath with embedded [PR88590]

2023-11-22 Thread FX Coudert
Hi, > I believe this can be applied as a partial reversion of a previously approved > patch, Yes, that makes sense. Pushed as https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=ce966ae66067d8d365431ef7a323f4207fcb729a FX

Re: Fix 'gcc.dg/tree-ssa/return-value-range-1.c' for 'char' defaulting to 'unsigned' (was: Propagate value ranges of return values)

2023-11-22 Thread Thomas Schwinge
Hi! On 2023-11-22T11:51:02+0100, Christophe Lyon wrote: > On Tue, 21 Nov 2023 at 22:24, Thomas Schwinge wrote: >> On 2023-11-19T16:05:42+0100, Jan Hubicka wrote: >> > --- /dev/null >> > +++ b/gcc/testsuite/gcc.dg/tree-ssa/return-value-range-1.c >> >> Pushed to master branch commit a0240662b2231

Re: [PATCH 10/11] aarch64: Add new load/store pair fusion pass.

2023-11-22 Thread Richard Sandiford
Alex Coplan writes: > This is a v3 of the aarch64 load/store pair fusion pass. > v2 was posted here: > - https://gcc.gnu.org/pipermail/gcc-patches/2023-October/633601.html > > The main changes since v2 are as follows: > > We now handle writeback opportunities as well. E.g. for this testcase: > >

[PATCH v3 1/8] sched-deps.cc (find_modifiable_mems): Avoid exponential behavior

2023-11-22 Thread Maxim Kuvyrkov
This patch avoids sched-deps.cc:find_inc() creating exponential number of dependencies, which become memory and compilation time hogs. Consider example (simplified from PR96388) ... === sp=sp-4 // sp_insnA mem_insnA1[sp+A1] ... mem_insnAN[sp+AN] sp=sp-4 // sp_insnB mem_insnB1[sp+B1] ... mem_insnBM[

[PATCH v3 0/8] Avoid exponential behavior in scheduler and better logging

2023-11-22 Thread Maxim Kuvyrkov
Compared to v1 and v2 this is a complete patch series. The debugging/dumping improvements gently touch IRA, RTL lists, and sel-sched bits to avoid re-inventing or copy-pasting the wheel. Bootstrapping and regtesting these patches on aarch64-linux-gnu. OK to merge? Thanks! === This patch seri

[PATCH v3 5/8] Add a bit more logging scheduler's dependency analysis

2023-11-22 Thread Maxim Kuvyrkov
gcc/ChangeLog: * sched-deps.cc (sd_add_dep, find_inc): Add logging about dependency creation. --- gcc/sched-deps.cc | 30 ++ 1 file changed, 26 insertions(+), 4 deletions(-) diff --git a/gcc/sched-deps.cc b/gcc/sched-deps.cc index 4d357079a7a..2a87158b

[PATCH v3 6/8] sched_deps.cc: Simplify initialization of dependency contexts

2023-11-22 Thread Maxim Kuvyrkov
gcc/ChangeLog: * sched-deps.cc (init_deps, init_deps_reg_last): Simplify. (free_deps): Remove useless code. --- gcc/sched-deps.cc | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/gcc/sched-deps.cc b/gcc/sched-deps.cc index 2a87158ba4b..e0d3c97d935

[PATCH v3 2/8] Unify implementations of print_hard_reg_set()

2023-11-22 Thread Maxim Kuvyrkov
We currently have 3 implementations of print_hard_reg_set() (all with the same name!) in ira-color.cc, ira-conflicts.cc, and sel-sched-dump.cc. This patch generalizes implementation in ira-color.cc, and uses it in all other places. The declaration is added to hard-reg-set.h. The motivation for t

[PATCH v3 8/8] Improve logging of scheduler dependency analysis context

2023-11-22 Thread Maxim Kuvyrkov
Scheduler dependency analysis uses two main data structures: 1. reg_pending_* data contains effects of INSN on the register file, which is then incorporated into ... 2. deps_desc object, which contains commulative information about all instructions processed from deps_desc object's initializa

[PATCH v3 3/8] Simplify handling of INSN_ and EXPR_LISTs in sched-rgn.cc

2023-11-22 Thread Maxim Kuvyrkov
This patch simplifies logic behind deps_join(), which will be important for the upcoming improvements of sched-deps.cc logging. The only functional change is that when deps_join() is called with empty state for the 2nd argument, it will not reverse INSN_ and EXPR_LISTs in the 1st argument. Before

[PATCH v3 4/8] Improve and fix sched-deps.cc: dump_dep() and dump_lists().

2023-11-22 Thread Maxim Kuvyrkov
Better propagate flags from dump_lists() into dump_dep() and add a missing "]" in dump_lists(). gcc/ChangeLog: * sched-deps.cc (DUMP_DEP_PRO): Improve comment. (dump_dep_flags): Remove. (DUMP_LISTS_SIZE, DUMP_LISTS_DEPS, DUMP_LISTS_ALL): Continue numbering from DUM

[PATCH v3 7/8] Improve logging of register data in scheduler dependency analysis

2023-11-22 Thread Maxim Kuvyrkov
Scheduler dependency analysis uses two main data structures: 1. reg_pending_* data contains effects of INSN on the register file, which is then incorporated into ... 2. deps_desc object, which contains commulative information about all instructions processed from deps_desc object's initializa

Re: [PATCH 11/11] aarch64: Use individual loads/stores for mem{cpy, set} expansion

2023-11-22 Thread Richard Sandiford
Alex Coplan writes: > This patch adjusts the mem{cpy,set} expansion in the aarch64 backend to use > individual loads/stores instead of ldp/stp at expand time. The idea is to > rely > on the ldp fusion pass to fuse the accesses together later in the RTL > pipeline. > > The earlier parts of the R

Re: [PATCH] tree: Fix up try_catch_may_fallthru [PR112619]

2023-11-22 Thread Richard Biener
On Wed, 22 Nov 2023, Jakub Jelinek wrote: > Hi! > > The following testcase ICEs with -std=c++98 since r14-5086 because > block_may_fallthru is called on a TRY_CATCH_EXPR whose second operand > is a MODIFY_EXPR rather than STATEMENT_LIST, which try_catch_may_fallthru > apparently expects. > I've b

[PATCH] c++/modules: Prevent overwriting arguments for duplicates [PR112588]

2023-11-22 Thread Nathaniel Shead
Bootstrapped and regtested on x86_64-pc-linux-gnu. I don't have write access. -- >8 -- When merging duplicate instantiations of function templates, currently read_function_def overwrites the arguments with that of the existing duplicate. This is problematic, however, since this means that the PAR

RE: [PATCH v4] DSE: Allow vector type for get_stored_val when read < store

2023-11-22 Thread Li, Pan2
> It looks like Jeff approved the patch? Yes, just would like to double check the way of this patch is expected as following the suggestion of Richard S. Pan -Original Message- From: Richard Biener Sent: Wednesday, November 22, 2023 4:02 PM To: Li, Pan2 Cc: richard.sandif...@arm.com;

Re: [PATCH] tree: Fix up try_catch_may_fallthru [PR112619]

2023-11-22 Thread Jakub Jelinek
On Wed, Nov 22, 2023 at 11:32:10AM +, Richard Biener wrote: > > hack in gcc 13 and triggered on hundreds of tests there within just 5 > > seconds of running make check-g++ -j32 (and in cases I looked at had nothing > > to do with the r14-5086 backports), so I believe this is just bad > > assump

Gcc

2023-11-22 Thread Suma Luther
Hi Gcc, I'm following up to confirm if you are interested in acquiring the Registrants/Attendees/Members list. * CMAA Annual Conference (Washington, USA, Oct 29-31, 2023) * 1,000+ Contacts Let me know your thoughts so that I can share the price & more infor

Re: [PATCH v5] Introduce attribute sym_alias

2023-11-22 Thread Richard Biener
On Mon, Nov 20, 2023 at 1:54 PM Alexandre Oliva wrote: > > On Sep 20, 2023, Alexandre Oliva wrote: > > > This patch introduces an attribute to add extra asm names (aliases) > > for a decl when its definition is output. > > Ping? > https://gcc.gnu.org/pipermail/gcc-patches/2023-September/630971.ht

Re: [PATCH] tree: Fix up try_catch_may_fallthru [PR112619]

2023-11-22 Thread Jakub Jelinek
On Wed, Nov 22, 2023 at 01:06:28PM +0100, Jakub Jelinek wrote: > Looking at a trivial example > void bar (); > void > foo (void) > { > try { bar (); } catch (int) {} > } > it seems it is even more complicated, because what e.g. the gimplification > sees is not TRY_CATCH_EXPR with CATCH_EXPR secon

Re: [PATCH] RISC-V: Fix incorrect use of vcompress in permutation auto-vectorization

2023-11-22 Thread juzhe.zh...@rivai.ai
Committed as it is obvious bug fix. juzhe.zh...@rivai.ai From: Juzhe-Zhong Date: 2023-11-22 18:53 To: gcc-patches CC: kito.cheng; kito.cheng; jeffreyalaw; rdapp.gcc; Juzhe-Zhong Subject: [PATCH] RISC-V: Fix incorrect use of vcompress in permutation auto-vectorization This patch fixes followin

Re: [PATCH] mingw: Exclude utf8 manifest [PR111170, PR108865]

2023-11-22 Thread Costas Argyris
Attached a new patch. A couple things to note: 1) I changed your host_extra_objs=utf8-mingw32.o to host_extra_objs_mingw=utf8-mingw32.o to match the other two, since I believe that's what you meant. 2) This approach has the complication that the variables in configure.ac need to be set befor

Re: [PATCH v5] Introduce attribute sym_alias (was: Last call for bikeshedding on attribute sym/exalias/reverse_alias)

2023-11-22 Thread Jan Hubicka
Hi, it seems that interface to symbol table is fairly minimal here reduced to... > (create_sym_alias_decl, create_sym_alias_decls): New. > * cgraphunit.cc (cgraph_node::analyze): Create alias_target > node if needed. called from here... > (analyze_functions): Fixup visibilit

Re: Re: RISC-V: Support XTheadVector extensions

2023-11-22 Thread 钟居哲
I am totally ok to approve theadvector on GCC-14 before stage 3 close as long as it doesn't touch the current RVV codes too much and binutils supports theadvector. I have provided the draft approach: https://gcc.gnu.org/pipermail/gcc-patches/2023-November/637349.html which turns out doesn't need

Re: [PATCH] Fix PR ada/111909 On Darwin, determine filesystem case sensitivity at runtime

2023-11-22 Thread Simon Wright
On 21 Nov 2023, at 23:13, Iain Sandoe wrote: >> #if defined (__APPLE__) >> -#include > > If removing unistd.h is intentional (i.e. you determined that it’s no longer > needed for Darwin), then we should make that a separate patch. I thought that I’d had to include unistd.h for the first patch

Re: [PATCH] Fix PR ada/111909 On Darwin, determine filesystem case sensitivity at runtime

2023-11-22 Thread Arnaud Charlet
> >> #if defined (__APPLE__) > >> -#include > > > > If removing unistd.h is intentional (i.e. you determined that it’s no longer > > needed for Darwin), then we should make that a separate patch. > > I thought that I’d had to include unistd.h for the first patch in this > thread; clearly not! >

[pushed] [PR112610] [IRA]: Fix using undefined dump file in IRA code during insn scheduling

2023-11-22 Thread Vladimir Makarov
The following patch fixes https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112610 The patch was successfully tested and bootstrapped on x86-64. commit 95f61de95bbcc2e4fb7020e27698140abea23788 Author: Vladimir N. Makarov Date: Wed Nov 22 09:01:02 2023 -0500 [IRA]: Fix using undefined dump fi

Re: [PATCH v4] Introduce strub: machine-independent stack scrubbing

2023-11-22 Thread Richard Biener
On Mon, Nov 20, 2023 at 1:40 PM Alexandre Oliva wrote: > > On Oct 26, 2023, Alexandre Oliva wrote: > > >> This is a refreshed and improved version of the version posted back in > >> June. https://gcc.gnu.org/pipermail/gcc-patches/2023-June/621936.html > > > Ping? https://gcc.gnu.org/pipermail/gc

Re: [PATCH v2] A new copy propagation and PHI elimination pass

2023-11-22 Thread Filip Kastl
Hi Richard, > Can you name the new file gimple-ssa-sccopy.cc please? Yes, no problem. Btw, I thought that it is standard that gimple ssa passes have the tree-ssa- prefix. Do I understand it correctly that this is not true and many tree-ssa-*.cc passes should actually be named gimple-ssa-*.cc but

Re: [PATCH v2] gcov: Fix integer types in gen_counter_update()

2023-11-22 Thread Christophe Lyon
Hi, On Tue, 21 Nov 2023 at 12:22, Sebastian Huber wrote: > > On 21.11.23 11:46, Jakub Jelinek wrote: > > On Tue, Nov 21, 2023 at 11:42:06AM +0100, Sebastian Huber wrote: > >> > >> On 21.11.23 11:34, Jakub Jelinek wrote: > --- a/gcc/tree-profile.cc > +++ b/gcc/tree-profile.cc > @@ -

Re: [PATCH v2] gcov: Fix integer types in gen_counter_update()

2023-11-22 Thread Sebastian Huber
On 22.11.23 15:22, Christophe Lyon wrote: On Tue, 21 Nov 2023 at 12:22, Sebastian Huber wrote: On 21.11.23 11:46, Jakub Jelinek wrote: On Tue, Nov 21, 2023 at 11:42:06AM +0100, Sebastian Huber wrote: On 21.11.23 11:34, Jakub Jelinek wrote: --- a/gcc/tree-profile.cc +++ b/gcc/tree-profile.cc

Re: Re: RISC-V: Support XTheadVector extensions

2023-11-22 Thread Christoph Müllner
On Wed, Nov 22, 2023 at 2:52 PM 钟居哲 wrote: > > I am totally ok to approve theadvector on GCC-14 before stage 3 close > as long as it doesn't touch the current RVV codes too much and binutils > supports theadvector. > > I have provided the draft approach: > https://gcc.gnu.org/pipermail/gcc-patche

Re: [PATCH v2 1/6] libgomp: basic pinned memory on Linux

2023-11-22 Thread Tobias Burnus
Hi Andrew, Side remark: -#define MEMSPACE_CALLOC(MEMSPACE, SIZE) \ - calloc (1, (((void)(MEMSPACE), (SIZE This fits a bit more to previous patch, but I wonder whether that should use (MEMSPACE, NMEMB, SIZE) instead - to fit to the actual calloc arguments. I think the main/only difference

[committed] amdgcn: Fix vector TImode reload loop

2023-11-22 Thread Andrew Stubbs
This patch fixes a reload bug that's hard to reproduce reliably (so far I've only observed it on the OG13 branch, with testcase gcc.c-torture/compile/pr70355.c), but causes an infinite loop in reload when it fails. For some reason it wants to save a value from AVGPRs to memory, this can't hap

[PATCH] libgcc: mark __hardcfr_check_fail as always_inline

2023-11-22 Thread Jose E. Marchesi
The function __hardcfr_check_fail in hardcfr.c is internal and static inline. It receives many arguments, which require more than five registers to be passed in bpf-none-unknown targets. BPF is limited to that number of registers to pass arguments, and therefore libgcc fails to build in that targ

[PATCH] tree-optimization/112344 - wrong final value replacement

2023-11-22 Thread Richard Biener
When performing final value replacement chrec_apply that's used to compute the overall effect of niters to a CHREC doesn't consider that the overall increment of { -2147483648, +, 2 } doesn't fit in a signed integer when the loop iterates until the value of the IV of 20. The following fixes this m

Re: [PATCH] Fix PR ada/111909 On Darwin, determine filesystem case sensitivity at runtime

2023-11-22 Thread Paul Koning
> On Nov 22, 2023, at 8:54 AM, Simon Wright wrote: > > On 21 Nov 2023, at 23:13, Iain Sandoe wrote: > >>> #if defined (__APPLE__) >>> -#include >> >> If removing unistd.h is intentional (i.e. you determined that it’s no longer >> needed for Darwin), then we should make that a separate patc

Re: [PATCH 01/11] rtl-ssa: Support for inserting new insns

2023-11-22 Thread Alex Coplan
On 21/11/2023 11:51, Richard Sandiford wrote: > Alex Coplan writes: > > N.B. this is just a rebased (but otherwise unchanged) version of the > > same patch already posted here: > > > > https://gcc.gnu.org/pipermail/gcc-patches/2023-October/633348.html > > > > this is the only unreviewed dependency

Re: [PATCH] Fix PR ada/111909 On Darwin, determine filesystem case sensitivity at runtime

2023-11-22 Thread Iain Sandoe
> On 22 Nov 2023, at 13:55, Arnaud Charlet wrote: > #if defined (__APPLE__) -#include >>> >>> If removing unistd.h is intentional (i.e. you determined that it’s no longer >>> needed for Darwin), then we should make that a separate patch. >> >> I thought that I’d had to include uni

Re: [PATCH RFC] c++: mangle function template constraints

2023-11-22 Thread Jonathan Wakely
On Mon, 20 Nov 2023 at 02:56, Jason Merrill wrote: > > Tested x86_64-pc-linux-gnu. Are the library bits OK? Any comments before I > push this? The library parts are OK. The variable template is_trivially_copyable_v just uses __is_trivially_copyable so should be just as efficient, and the change

Re: [PATCH v3] aarch64: SVE/NEON Bridging intrinsics

2023-11-22 Thread Richard Sandiford
Richard Ball writes: > ACLE has added intrinsics to bridge between SVE and Neon. > > The NEON_SVE Bridge adds intrinsics that allow conversions between NEON and > SVE vectors. > > This patch adds support to GCC for the following 3 intrinsics: > svset_neonq, svget_neonq and svdup_neonq > > gcc/Chan

[pushed] testsuite: Update path to intl include.

2023-11-22 Thread Iain Sandoe
Tested on i686, x86_64 and aarch64 Darwin, aarch64 and x86_64 Linux, pushed to master as obvious, thanks Iain --- 8< --- When we are building libintl in-tree, we need to pass the path to the generated libintl.h include to the plugin tests. This path has changed with the use of gettext directly.

Re: [PATCH RFC] c++: mangle function template constraints

2023-11-22 Thread Jonathan Wakely
On Wed, 22 Nov 2023 at 14:50, Jonathan Wakely wrote: > > On Mon, 20 Nov 2023 at 02:56, Jason Merrill wrote: > > > > Tested x86_64-pc-linux-gnu. Are the library bits OK? Any comments before I > > push this? > > The library parts are OK. > > The variable template is_trivially_copyable_v just uses

Re: [PATCH] Fix PR ada/111909 On Darwin, determine filesystem case sensitivity at runtime

2023-11-22 Thread Iain Sandoe
> On 22 Nov 2023, at 14:48, Iain Sandoe wrote: > > > >> On 22 Nov 2023, at 13:55, Arnaud Charlet wrote: >> > #if defined (__APPLE__) > -#include If removing unistd.h is intentional (i.e. you determined that it’s no longer needed for Darwin), then we should ma

Re: [PATCH v3 2/8] Unify implementations of print_hard_reg_set()

2023-11-22 Thread Vladimir Makarov
On 11/22/23 06:14, Maxim Kuvyrkov wrote: We currently have 3 implementations of print_hard_reg_set() (all with the same name!) in ira-color.cc, ira-conflicts.cc, and sel-sched-dump.cc. This patch generalizes implementation in ira-color.cc, and uses it in all other places. The declaration is a

Re: [PATCH] Fix PR ada/111909 On Darwin, determine filesystem case sensitivity at runtime

2023-11-22 Thread Simon Wright
> On 22 Nov 2023, at 15:03, Iain Sandoe wrote: > > > >> On 22 Nov 2023, at 14:48, Iain Sandoe wrote: >> >> >> >>> On 22 Nov 2023, at 13:55, Arnaud Charlet wrote: >>> >> #if defined (__APPLE__) >> -#include > > If removing unistd.h is intentional (i.e. you determined th

[PATCH] AArch64/testsuite: Use non-capturing parentheses with ccmp_1.c

2023-11-22 Thread Maciej W. Rozycki
Use non-capturing parentheses for the subexpressions used with `scan-assembler-times', to avoid a quirk with double-counting. gcc/testsuite/ * gcc.target/aarch64/ccmp_1.c: Use non-capturing parentheses with `scan-assembler-times'. --- Hi, Here's another one. I realised

Re: [PATCH 2/2] testsuite/unroll-8: Disable vectorization for varibale-factor targets

2023-11-22 Thread Jeff Law
On 11/21/23 16:27, Palmer Dabbelt wrote: The vectorizer picks up these loops and disables unrolling on targets with variable vector factors. That result in better code here, but it trips up the unrolling tests. So just disable vectorization for these. gcc/testsuite/ChangeLog: PR ta

Re: [committed] d: Merge upstream dmd ff57fec515, druntime ff57fec515, phobos 17bafda79.

2023-11-22 Thread Iain Buclaw
Excerpts from Rainer Orth's message of November 21, 2023 4:59 pm: > Hi Iain, > >> This patch merges the D front-end and runtime library with upstream dmd >> ff57fec515, and the standard library with phobos 17bafda79. >> >> Synchronizing with the upstream release candidate of v2.106.0. >> >> D fron

Re: [PATCH v4] DSE: Allow vector type for get_stored_val when read < store

2023-11-22 Thread Richard Sandiford
"Li, Pan2" writes: >> It looks like Jeff approved the patch? > > Yes, just would like to double check the way of this patch is expected as > following the suggestion of Richard S. Yeah, it looks good to me, thanks. Richard > Pan > > -Original Message- > From: Richard Biener > Sent: W

[PATCHv2] Clean up by_pieces_ninsns

2023-11-22 Thread HAO CHEN GUI
Hi, This patch cleans up by_pieces_ninsns and does following things. 1. Do the length and alignment adjustment for by pieces compare when overlap operation is enabled. 2. Replace unnecessary mov_optab checks with gcc assertions. Compared to last version, the main change is to replace unnecessa

Re: [PATCH] tree: Fix up try_catch_may_fallthru [PR112619]

2023-11-22 Thread Jakub Jelinek
On Wed, Nov 22, 2023 at 01:21:12PM +0100, Jakub Jelinek wrote: > So, pedantically perhaps just assuming TRY_CATCH_EXPR where second argument > is not STATEMENT_LIST to be the CATCH_EXPR/EH_FILTER_EXPR case could work > for C++, but there are other FEs and it would be fragile (and weird, given > tha

RE: [PATCH v4] DSE: Allow vector type for get_stored_val when read < store

2023-11-22 Thread Li, Pan2
Committed, thanks all. Pan -Original Message- From: Richard Sandiford Sent: Thursday, November 23, 2023 2:39 AM To: Li, Pan2 Cc: Richard Biener ; juzhe.zh...@rivai.ai; Wang, Yanzhang ; kito.ch...@gmail.com; Jeff Law ; gcc-patches@gcc.gnu.org Subject: Re: [PATCH v4] DSE: Allow vector

Re: [PATCH v5 1/1] c++: Initial support for P0847R7 (Deducing This) [PR102609]

2023-11-22 Thread waffl3x
> > > > /* Nonzero for FUNCTION_DECL means that this decl is a non-static > > > > - member function. */ > > > > + member function, use DECL_IOBJ_MEMBER_FUNC_P instead. */ > > > > #define DECL_NONSTATIC_MEMBER_FUNCTION_P(NODE) \ > > > > (TREE_CODE (TREE_TYPE (NODE)) == METHOD_TYPE) > > > > > > > >

Re: RISC-V: Support XTheadVector extensions

2023-11-22 Thread Jeff Law
On 11/22/23 07:24, Christoph Müllner wrote: On Wed, Nov 22, 2023 at 2:52 PM 钟居哲 wrote: I am totally ok to approve theadvector on GCC-14 before stage 3 close as long as it doesn't touch the current RVV codes too much and binutils supports theadvector. I have provided the draft approach: ht

[PATCH 2/2] c-family: rename warn_for_address_or_pointer_of_packed_member

2023-11-22 Thread Jason Merrill
Following the last patch, let's rename the functions to reflect the change in behavior. gcc/c-family/ChangeLog: * c-warn.cc (check_address_or_pointer_of_packed_member): Rename to check_address_of_packed_member. (check_and_warn_address_or_pointer_of_packed_member):

[pushed] wwwdocs: releasing: No longer refer to buildstat.html

2023-11-22 Thread Gerald Pfeifer
That's the counterpart to the branching.html change I just made, also reported by Thomas. Pushed. Gerald --- htdocs/releasing.html | 3 --- 1 file changed, 3 deletions(-) diff --git a/htdocs/releasing.html b/htdocs/releasing.html index 1cd56f72..c7365e64 100644 --- a/htdocs/releasing.html +++

Re: [PATCH] Clean up by_pieces_ninsns

2023-11-22 Thread Richard Sandiford
"Kewen.Lin" writes: > Hi, > > on 2023/11/15 10:26, HAO CHEN GUI wrote: >> Hi, >> This patch cleans up by_pieces_ninsns and does following things. >> 1. Do the length and alignment adjustment for by pieces compare when >> overlap operation is enabled. >> 2. Remove unnecessary mov_optab checks. >>

[PATCH V2 3/3] OpenMP: Use enumerators for names of trait-sets and traits

2023-11-22 Thread Sandra Loosemore
This patch introduces enumerators to represent trait-set names and trait names, which makes it easier to use tables to control other behavior and for switch statements to dispatch on the tags. The tags are stored in the same place in the TREE_LIST structure (OMP_TSS_ID or OMP_TS_ID) and are encode

[pushed] wwwdocs: branching: No longer refer to buildstat.html

2023-11-22 Thread Gerald Pfeifer
Thomas spotted this (among others) not being necessary any longer and kindly reported it. Pushed. --- htdocs/branching.html | 3 --- 1 file changed, 3 deletions(-) diff --git a/htdocs/branching.html b/htdocs/branching.html index 0d48dce1..23ff92e8 100644 --- a/htdocs/branching.html +++ b/htdocs

[PATCH 1/2] c-family: -Waddress-of-packed-member and casts

2023-11-22 Thread Jason Merrill
Tested x86_64-pc-linux-gnu, OK for trunk? -- 8< -- -Waddress-of-packed-member, in addition to the documented warning about taking the address of a packed member, also warns about casting from a pointer to a TYPE_PACKED type to a pointer to a type with greater alignment. This wrongly warns if the

Re: [PATCH v5 1/1] c++: Initial support for P0847R7 (Deducing This) [PR102609]

2023-11-22 Thread waffl3x
On Tuesday, November 21st, 2023 at 8:22 PM, Jason Merrill wrote: > > > On 11/21/23 08:04, waffl3x wrote: > > > Bootstrapped and tested on x86_64-linux with no regressions. > > > > Hopefully this patch is legible enough for reviewing purposes, I've not > > been feeling the greatest so it w

Re: [PATCH, v3] Fortran: restrictions on integer arguments to SYSTEM_CLOCK [PR112609]

2023-11-22 Thread Harald Anlauf
Hi Steve, On 11/22/23 19:03, Steve Kargl wrote: On Wed, Nov 22, 2023 at 10:36:00AM +0100, Mikael Morin wrote: OK with this fixed (and the previous comments as you wish), if Steve has no more comments. No further comments. Thanks for your patients, Harald. As side note, I found John Reid's

[committed] hppa: Fix integer REG+D address reloads

2023-11-22 Thread John David Anglin
Tested on hppa-unknown-linux-gnu and hppa64-hp-hpux11.11. Fixes testcase in PR. Committed to trunk. Dave --- hppa: Fix integer REG+D address reloads I made a mistake in the previous change to integer_store_memory_operand. There is no support pa_emit_move sequence to handle secondary reloads of

Re: [PATCH 2/2] bugzilla: remove `gcc-bugs@` mailing list address

2023-11-22 Thread Joseph Myers
On Mon, 20 Nov 2023, Ben Boeckel wrote: > Bugzilla is preferred today. > > ChangeLog: > > * config-ml.in: Replace gcc-bugs@ with Bugzilla link. > * symlink-tree: Replace gcc-bugs@ with Bugzilla link. I don't think we should use a URL that redirects (i.e. https://gcc.gnu.org/bugzill

Re: [PATCH v3 00/11] : More warnings as errors by default

2023-11-22 Thread Jeff Law
On 11/20/23 02:55, Florian Weimer wrote: This revision addresses Marek's comment about handing -Wdeclaration-missing-parameter-type properly in conjunction with -fpermissive. A new test (permerror-fpermissive-nowarning.c) demonstrates the expected behavior. I added a test for -std=gnu89 -fno

Re: [PATCH v3 00/11] : More warnings as errors by default

2023-11-22 Thread Florian Weimer
* Jeff Law: > On 11/20/23 02:55, Florian Weimer wrote: >> This revision addresses Marek's comment about handing >> -Wdeclaration-missing-parameter-type properly in conjunction with >> -fpermissive. A new test (permerror-fpermissive-nowarning.c) >> demonstrates the expected behavior. I added a te

Re: [PATCH 1/2] testsuite/unroll-8: Avoid triggering undefined behavior

2023-11-22 Thread Andrew Pinski
On Tue, Nov 21, 2023 at 3:29 PM Palmer Dabbelt wrote: > > I was poking around with this test failure and noticed it was exercising > undefined behavior. The return type doesn't matter for what's being > tested, so just mark it as void. Just a quick note, this is NOT undefined behavior in C to re

Re: [PATCH 2/2] bugzilla: remove `gcc-bugs@` mailing list address

2023-11-22 Thread Ben Boeckel
On Wed, Nov 22, 2023 at 23:15:56 +, Joseph Myers wrote: > On Mon, 20 Nov 2023, Ben Boeckel wrote: > > > Bugzilla is preferred today. > > > > ChangeLog: > > > > * config-ml.in: Replace gcc-bugs@ with Bugzilla link. > > * symlink-tree: Replace gcc-bugs@ with Bugzilla link. > > I don't

Re: [PATCH v3 03/11] gm2: Add missing declaration of m2pim_M2RTS_Terminate to test

2023-11-22 Thread Joseph Myers
On Mon, 20 Nov 2023, Florian Weimer wrote: > gcc/testsuite/ > > * gm2/link/externalscaffold/pass/scaffold.c (m2pim_M2RTS_Terminate): > Declare. OK in the absence of Modula-2 maintainer objections within 48 hours. -- Joseph S. Myers jos...@codesourcery.com

[PATCH, testsuite, fortran] fix invalid testcases (missing MOLD argument to NULL)

2023-11-22 Thread Harald Anlauf
Dear all, testcases assumed_rank_8.f90 and assumed_rank_10.f90 are invalid: NULL() is passed without MOLD to an assumed-rank dummy argument. This is detected by NAG, but not yet by gfortran (see pr104819). gfortran even ignores the MOLD argument; the dump-tree is identical if MOLD is there or not

[committed] hppa: Define MAX_FIXED_MODE_SIZE

2023-11-22 Thread John David Anglin
Tested on hppa-unknown-linux-gnu and hppa64-hp-hpux11.11. Committed to trunk. Fixes FAIL: c-c++-common/pr111309-1.c ICE. Dave --- hppa: Define MAX_FIXED_MODE_SIZE Replace default define. We support TImode when TARGET_64BIT is true. 2023-11-22 John David Anglin gcc/ChangeLog: PR

Re: [PATCH v3 01/11] aarch64: Avoid -Wincompatible-pointer-types warning in Linux unwinder

2023-11-22 Thread Joseph Myers
On Mon, 20 Nov 2023, Florian Weimer wrote: > * config/aarch64/linux-unwind.h > (aarch64_fallback_frame_state): Add cast to the expected type > in sc assignment. OK in the absence of AArch64 maintainer objections within 48 hours. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH] mingw: Exclude utf8 manifest [PR111170, PR108865]

2023-11-22 Thread Jonathan Yong
On 11/22/23 12:34, Costas Argyris wrote: Attached a new patch. A couple things to note: 1) I changed your host_extra_objs=utf8-mingw32.o to host_extra_objs_mingw=utf8-mingw32.o to match the other two, since I believe that's what you meant. 2) This approach has the complication that the var

Re: [PATCH, v3] Fortran: restrictions on integer arguments to SYSTEM_CLOCK [PR112609]

2023-11-22 Thread Steve Kargl
On Wed, Nov 22, 2023 at 10:36:00AM +0100, Mikael Morin wrote: > > OK with this fixed (and the previous comments as you wish), if Steve has no > more comments. > No further comments. Thanks for your patients, Harald. As side note, I found John Reid's "What's new" document where it is noted that

Re: [RFA] New pass for sign/zero extension elimination

2023-11-22 Thread Jeff Law
On 11/20/23 11:26, Richard Sandiford wrote: + +/* If we know the destination of CODE only uses some low bits + (say just the QI bits of an SI operation), then return true + if we can propagate the need for just the subset of bits + from the destination to the sources. */ + +static bool

Re: [PATCH 1/2] testsuite/unroll-8: Avoid triggering undefined behavior

2023-11-22 Thread Jeff Law
On 11/21/23 16:27, Palmer Dabbelt wrote: I was poking around with this test failure and noticed it was exercising undefined behavior. The return type doesn't matter for what's being tested, so just mark it as void. gcc/testsuite/ChangeLog: * gcc.dg/unroll-8.c: Remove UB. I just revi

  1   2   >