[committed] d: Add warning for call expression without side effects

2023-10-28 Thread Iain Buclaw
Hi, In the last merge of the dmd front-end with upstream (r14-4830), this warning got removed from the semantic passes. Reimplement the warning for the code generation pass instead, where it cannot have an effect on conditional compilation. Bootstrapped and regression tested on x86_64-linux-gnu/

Re: [Ready to commit V3] RISC-V: Add AVL propagation PASS for RVV auto-vectorization

2023-10-28 Thread Andreas Schwab
../../gcc/config/riscv/riscv-avlprop.cc: In member function 'virtual unsigned int pass_avlprop::execute(function*)': ../../gcc/config/riscv/riscv-avlprop.cc:346:23: error: loop variable 'candidate' creates a copy from type 'const std::pair' [-Werror=range-loop-construct] 346 | for (const

RE: [PATCH v2] aarch64: SVE/NEON Bridging intrinsics

2023-10-28 Thread Richard Ball
Hi all, Please disregard patch v2, some necessary changes have become apparent after submission. I will make these changes and submit as patch v3. Apologies, Richard Ball -Original Message- From: Richard Ball Sent: Friday, October 27, 2023 6:18 PM To: gcc-patches@gcc.gnu.org; Richard

Re: Ping: [PATCH v2 0/2] Replace intl/ with out-of-tree GNU gettext

2023-10-28 Thread Arsen Arsenović
Hi Andrew, Andrew Pinski writes: > One comment from me. It would be nice to update install.texi in > gcc/doc/ to make a mention of this requirement for non-glibc hosts. What do you think of the following: diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi index a17016cd8977..e5137f9d7a1

Re: Ping: [PATCH v2 0/2] Replace intl/ with out-of-tree GNU gettext

2023-10-28 Thread Iain Sandoe
Hi Arsen, > On 28 Oct 2023, at 10:22, Arsen Arsenović wrote: > Andrew Pinski writes: > >> One comment from me. It would be nice to update install.texi in >> gcc/doc/ to make a mention of this requirement for non-glibc hosts. > > What do you think of the following: The hiccup for me is that w

[PATCH V15 4/4] ree: Improve ree pass using defined abi interfaces

2023-10-28 Thread Ajit Agarwal
Hello Vineet, Jeff and Bernhard: This version 15 of the patch uses abi interfaces to remove zero and sign extension elimination. Bootstrapped and regtested on powerpc-linux-gnu. In this version (version 15) of the patch following review comments are incorporated. a) Removal of hard code zero_e

Re: [PATCH v9 4/4] ree: Improve ree pass for rs6000 target using defined ABI interfaces

2023-10-28 Thread Ajit Agarwal
On 27/10/23 10:46 pm, Bernhard Reutner-Fischer wrote: > On Wed, 25 Oct 2023 16:41:07 +0530 > Ajit Agarwal wrote: > >> On 25/10/23 2:19 am, Vineet Gupta wrote: >>> On 10/24/23 13:36, rep.dot@gmail.com wrote: As said, I don't see why the below was not cleaned up before the V1 >>>

Re: [PATCH v9 4/4] ree: Improve ree pass for rs6000 target using defined ABI interfaces

2023-10-28 Thread Ajit Agarwal
On 28/10/23 4:09 am, Vineet Gupta wrote: > > > On 10/27/23 10:16, Bernhard Reutner-Fischer wrote: >> On Wed, 25 Oct 2023 16:41:07 +0530 >> Ajit Agarwal wrote: >> >>> On 25/10/23 2:19 am, Vineet Gupta wrote: On 10/24/23 13:36, rep.dot@gmail.com wrote: > As said, I don't see wh

Re: Ping: [PATCH v2 0/2] Replace intl/ with out-of-tree GNU gettext

2023-10-28 Thread Arsen Arsenović
Hi Iain, Iain Sandoe writes: > Hi Arsen, > >> On 28 Oct 2023, at 10:22, Arsen Arsenović wrote: > >> Andrew Pinski writes: >> >>> One comment from me. It would be nice to update install.texi in >>> gcc/doc/ to make a mention of this requirement for non-glibc hosts. >> >> What do you think of

[ARC PATCH] Improve DImode left shift by a single bit.

2023-10-28 Thread Roger Sayle
This patch improves the code generated for X << 1 (and for X + X) when X is 64-bit DImode, using the same two instruction code sequence used for DImode addition. For the test case: long long foo(long long x) { return x << 1; } GCC -O2 currently generates the following code: foo:lsr r2,

Remove redundant partial specialization in _Nth_type

2023-10-28 Thread Feng Jisen
This patch remove a redundant partial specialization in class _Nth_type. For the original metafunction _Nth_type code, # 0 template struct _Nth_type<0, _Tp0, _Rest...> { using type = _Tp0; };  # 1 template struct _Nth_type<0, _Tp0, _Tp1, _Rest...> { using type = _Tp0; }; #

[PATCH v1] RISC-V: Fix one range-loop-construct warning of avlprop

2023-10-28 Thread pan2 . li
From: Pan Li This patch would like to fix one warning of avlprop as below. ../../gcc/config/riscv/riscv-avlprop.cc: In member function 'virtual unsigned int pass_avlprop::execute(function*)': ../../gcc/config/riscv/riscv-avlprop.cc:346:23: error: loop variable 'candidate' creates a copy from typ

Re: [PATCH v1] RISC-V: Fix one range-loop-construct warning of avlprop

2023-10-28 Thread Jeff Law
On 10/28/23 08:51, pan2...@intel.com wrote: From: Pan Li This patch would like to fix one warning of avlprop as below. ../../gcc/config/riscv/riscv-avlprop.cc: In member function 'virtual unsigned int pass_avlprop::execute(function*)': ../../gcc/config/riscv/riscv-avlprop.cc:346:23: error:

[ARC PATCH] Convert (signed<<31)>>31 to -(signed&1) without barrel shifter.

2023-10-28 Thread Roger Sayle
This patch optimizes PR middle-end/101955 for the ARC backend. On ARC CPUs with a barrel shifter, using two shifts is (probably) optimal as: asl_s r0,r0,31 asr_s r0,r0,31 but without a barrel shifter, GCC -O2 -mcpu=em currently generates: and r2,r0,1 ror

[RFC PATCH v1] c: Do not warn about external declaration following inline definition

2023-10-28 Thread Barnabás Pőcze
An external declaration following an inline definition is not redundant because it forces the compiler to emit an external definition for the function. That is, inline void f(void) { } [extern] void f(void); should not trigger the redundant redeclaration of ... warning. gcc/c/ChangeLog:

[PATCH,resend] hurd: Add multilib paths for gnu-x86_64

2023-10-28 Thread Samuel Thibault
We need the multilib paths in gcc to find e.g. glibc crt files on Debian. This is essentially based on t-linux64 version. gcc/ChangeLog: * gcc/config/i386/t-gnu64: New file. * gcc/config.gcc [x86_64-*-gnu*): Add i386/t-gnu64 to tmake_file. diff --git a/gcc/config.gcc b/g

[PATCH,resend] hurd: Ad default-pie and static-pie support

2023-10-28 Thread Samuel Thibault
This fixes the Hurd spec in the default-pie case, and adds static-pie support. gcc/ChangeLog: * gcc/config/i386/gnu.h: Use PIE_SPEC, add static-pie case. * gcc/config/i386/gnu64.h: Use PIE_SPEC, add static-pie case. diff --git a/gcc/config/i386/gnu.h b/gcc/config/i386/gnu.h index

Re: [PATCH] tree-optimization/109334: Improve computation for access attribute

2023-10-28 Thread Martin Uecker
Thanks, Sid! (one comment below) Am Donnerstag, dem 26.10.2023 um 07:51 -0400 schrieb Siddhesh Poyarekar: > On 2023-10-26 04:37, Martin Uecker wrote: > > > /* ... and either PARM is void * or has a type that is complete and > > has a > > constant size... */ > > && ((type

[committed] d: Fix ICE: in verify_gimple_in_seq on powerpc-darwin9 [PR112270]

2023-10-28 Thread Iain Buclaw
Hi, This patch fixes an ICE seen during stage2 on powerpc-darwin9 only. There were still some uses of GCC's boolean_type_node in the D front-end, which caused a type mismatch to trigger as D bool size is fixed to 1 byte on all targets. So two new nodes have been introduced - d_bool_false_node and

Re: [PATCH v3 1/2] c++: Initial support for P0847R7 (Deducing This) [PR102609]

2023-10-28 Thread waffl3x
I woke up today and figured it out in about 30 minutes, I don't know if this solution would be okay but I am running away from cp_build_addr_expr_1 for now. I think this is another place I will have the urge to refactor in the future, but if I keep looking at it right now I am just going to waste a

RE: [PATCH v1] RISC-V: Fix one range-loop-construct warning of avlprop

2023-10-28 Thread Li, Pan2
Committed, thanks Jeff. Pan -Original Message- From: Jeff Law Sent: Saturday, October 28, 2023 11:00 PM To: Li, Pan2 ; gcc-patches@gcc.gnu.org Cc: juzhe.zh...@rivai.ai; Wang, Yanzhang ; kito.ch...@gmail.com Subject: Re: [PATCH v1] RISC-V: Fix one range-loop-construct warning of avlprop

[PATCH] c++: fix noexcept checking for trivial operations [PR96090]

2023-10-28 Thread Nathaniel Shead
Bootstrapped and regtested on x86_64-pc-linux-gnu. -- >8 -- This patch stops eager folding of trivial operations (construction and assignment) from occurring when checking for noexceptness. This was previously done in PR c++/53025, but only for copy/move construction, and the __is_nothrow_xible b

[COMMITTED] gcc: xtensa: fix salt/saltu version check

2023-10-28 Thread Max Filippov
gcc/ * config/xtensa/xtensa.h (TARGET_SALT): Change HW version from 26 (which corresponds to RF-2014.0) to 27 (which corresponds to RG-2015.0, the release where salt/saltu opcodes were introduced). --- gcc/config/xtensa/xtensa.h | 2 +- 1 file changed, 1 ins

Re: [PATCH v2] swap: Fix incorrect lane extraction by vec_extract() [PR106770]

2023-10-28 Thread Segher Boessenkool
Hi! Please say "rs6000/p8swap:" in the subject, not "swap:" :-) On Sun, Sep 10, 2023 at 10:58:32PM +0530, Surya Kumari Jangala wrote: > Another issue with always handling swappable instructions is that it is > incorrect to do so in webs where loads/stores on quad word aligned > addresses are chan