Re: [PATCH] libstdc++: Workaround for LLVM-61763 in ranges

> I don't think this patch counts as legally significant, but if you contribute > again in future you should be aware of > https://gcc.gnu.org/contribute.html#legal and either complete the copyright > assignment paperwork, or add a DCO sign-off to the commit message. Thanks for the reminder. I

Re: [V3][PATCH 0/3] New attribute "counted_by" to annotate bounds for C99 FAM(PR108896)

On Fri, Oct 20, 2023 at 11:50:11AM +0200, Martin Uecker wrote: > Am Donnerstag, dem 19.10.2023 um 16:33 -0700 schrieb Kees Cook: > > On Wed, Oct 18, 2023 at 09:11:43PM +, Qing Zhao wrote: > > > As I replied to Martin in another email, I plan to do the following to > > > resolve this issue: > >

Re: HELP: Will the reordering happen? Re: [V3][PATCH 0/3] New attribute "counted_by" to annotate bounds for C99 FAM(PR108896)

> On Oct 20, 2023, at 2:22 PM, Richard Biener > wrote: > > > >> Am 20.10.2023 um 19:09 schrieb Qing Zhao : >> >> Sid, >> >> (Richard, can you please help me to make sure this? Thanks a lot) >> >> I studied a little bit more on the following question you raised during the >> review proce

Re: [V3][PATCH 0/3] New attribute "counted_by" to annotate bounds for C99 FAM(PR108896)

> On Oct 20, 2023, at 2:34 PM, Kees Cook wrote: > > On Fri, Oct 20, 2023 at 11:50:11AM +0200, Martin Uecker wrote: >> Am Donnerstag, dem 19.10.2023 um 16:33 -0700 schrieb Kees Cook: >>> On Wed, Oct 18, 2023 at 09:11:43PM +, Qing Zhao wrote: As I replied to Martin in another email, I pl

[PATCH] C99 testsuite readiness: Some unverified test case reductions

gcc/testsuite/ * gcc.c-torture/compile/2412-2.c (f): Call __builtin_strleninstead of strlen. * gcc.c-torture/compile/2427-1.c (FindNearestPowerOf2): Declare. * gcc.c-torture/compile/2802-1.c (bar): Call __builtin_memcpyins

[PATCH] C99 testsuite readiness: Compile more tests with -std=gnu89

gcc/testsuite/ * gcc.c-torture/compile/2403-1.c: Compile with -std=gnu89. * gcc.c-torture/compile/2511-1.c: Likewise. * gcc.c-torture/compile/2804-1.c: Likewise. * gcc.c-torture/compile/20020418-1.c: Likewise. * gcc.c-torture/compile/20020927-1.c

Re: [PATCH] c: -Wint-conversion should cover pointer/integer mismatches in ?:

On Fri, 20 Oct 2023, Florian Weimer wrote: > gcc/c/ > > PR c/109827 > PR other/44209 > * c-typeck.cc (build_conditional_expr): Use OPT_Wint_conversion > for pointer/integer mismatch warnings. > > gcc/testsuite/ > > * gcc.dg/Wint-conversion-3.c: New. OK. -- Josep

Re: [PATCH] c: -Wincompatible-pointer-types should cover mismatches in ?:

On Fri, 20 Oct 2023, Florian Weimer wrote: > gcc/c/ > > PR c/109826 > PR other/44209 > * c-typeck.cc (build_conditional_expr): Use > OPT_Wincompatible_pointer_types for pointer mismatches. > Emit location information for the operand. > > gcc/testsuite/ > > *

Re: [PATCH] c-family: char8_t and aliasing in C vs C++ [PR111884]

On 10/20/23 12:31, Marek Polacek wrote: Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? OK. -- >8 -- In the PR, Joseph says that in C char8_t is not a distinct type. So we should behave as if it can alias anything, like ordinary char. In C, unsigned_char_type_node == char8_type_

Re: HELP: Will the reordering happen? Re: [V3][PATCH 0/3] New attribute "counted_by" to annotate bounds for C99 FAM(PR108896)

On 2023-10-20 14:38, Qing Zhao wrote: How about the following: Add one more parameter to __builtin_dynamic_object_size(), i.e __builtin_dynamic_object_size (_1,1,array_annotated->foo)? When we see the structure field has counted_by attribute. Or maybe add a barrier preventing any assignme

Re: [PATCH v23 02/33] c-family, c++: Look up built-in traits via identifier node

On Fri, Oct 20, 2023 at 10:02 AM Ken Matsui wrote: > > Since RID_MAX soon reaches 255 and all built-in traits are used approximately > once in a C++ translation unit, this patch removes all RID values for built-in > traits and uses the identifier node to look up the specific trait. Rather > than

Re: [PATCH] c++/modules: ICE with lambda initializing local var [PR105322]

On Fri, 20 Oct 2023, Nathan Sidwell wrote: > Thanks for looking at this, but your patch is essentially papering over the > problem. > > It took me a while to figure out, but the clue was that things like > 'decltype(f()).m' worked, but 'decltype(f()){0}' did not. The CONSTRUCTOR > node is the ex

Re: [V3][PATCH 0/3] New attribute "counted_by" to annotate bounds for C99 FAM(PR108896)

Am Freitag, dem 20.10.2023 um 18:48 + schrieb Qing Zhao: > > > On Oct 20, 2023, at 2:34 PM, Kees Cook wrote: > > > > On Fri, Oct 20, 2023 at 11:50:11AM +0200, Martin Uecker wrote: > > > Am Donnerstag, dem 19.10.2023 um 16:33 -0700 schrieb Kees Cook: > > > > On Wed, Oct 18, 2023 at 09:11:43PM

Re: [PATCH v3] Control flow redundancy hardening

SPARC target header requires memmodel.h. David * gimple-harden-control-flow.cc: Include memmodel.h. *diff --git a/gcc/gimple-harden-control-flow.cc b/gcc/gimple-harden-control-flow.cc* *index 1b345dab766..441df5ac21c 100644* *--- a/gcc/gimple-harden-control-flow.cc* *+++ b/gcc/gimp

Re: [PATCH v23 02/33] c-family, c++: Look up built-in traits via identifier node

On Fri, Oct 20, 2023 at 12:12 PM Patrick Palka wrote: > > On Fri, Oct 20, 2023 at 10:02 AM Ken Matsui wrote: > > > > Since RID_MAX soon reaches 255 and all built-in traits are used > > approximately > > once in a C++ translation unit, this patch removes all RID values for > > built-in > > trait

Re: [PATCH] c++: Implement C++26 P2361R6 - Unevaluated strings [PR110342]

On 8/24/23 09:58, Jakub Jelinek wrote: Hi! The following patch implements C++26 unevaluated-string. As it seems to me just extra pedanticity, it is implemented only for -std=c++26 or -std=gnu++26 and later and only if -pedantic/-pedantic-errors. Hmm, I assumed it was accepted as a DR, but appa

[pushed] c++: fix tourney logic

Tested x86_64-pc-linux-gnu, applying to trunk. Patrick, sorry I didn't apply this sooner. -- 8< -- In r13-3766 I changed the logic at the end of tourney to avoid redundant comparisons, but the change also meant skipping any less-good matches between the champ_compared_to_predecessor candidate an

[pushed] testsuite: constexpr-diag1.C and implicit constexpr

Tested x86_64-pc-linux-gnu, applying to trunk. -- 8< -- This test doesn't break as expected with implicit constexpr. gcc/testsuite/ChangeLog: * g++.dg/cpp1y/constexpr-diag1.C: Add -fno-implicit-constexpr. --- gcc/testsuite/g++.dg/cpp1y/constexpr-diag1.C | 2 +- 1 file changed, 1 insert

Re: [PATCH] C99 testsuite readiness: Compile more tests with -std=gnu89

OK. -- Joseph S. Myers jos...@codesourcery.com

Re: HELP: Will the reordering happen? Re: [V3][PATCH 0/3] New attribute "counted_by" to annotate bounds for C99 FAM(PR108896)

> On Oct 20, 2023, at 3:10 PM, Siddhesh Poyarekar wrote: > > On 2023-10-20 14:38, Qing Zhao wrote: >> How about the following: >> Add one more parameter to __builtin_dynamic_object_size(), i.e >> __builtin_dynamic_object_size (_1,1,array_annotated->foo)? >> When we see the structure field has

Re: [PATCH] libstdc++ Add cstdarg to freestanding

Updated patch, added the requested files, hopefully wrote the commit better. Den tors. 7. sep. 2023 kl. 18.28 skrev Jonathan Wakely : > On Fri, 18 Aug 2023 at 20:14, Paul M. Bendixen > wrote: > > > > Hi > > Jonathan, I just went over the proposal again as well as [compliance], > which Arsen me

ping: [PATCH] libcpp: Improve the diagnostic for poisoned identifiers [PR36887]

Hello- May I please ping this one? Thanks... https://gcc.gnu.org/pipermail/gcc-patches/2023-September/630967.html -Lewis On Wed, Sep 20, 2023 at 12:12 AM Lewis Hyatt wrote: > > Hello- > > This patch implements the PR's request to add more information to the > diagnostic issued for using a poiso

Re: [PATCH v23 32/33] c++: Implement __is_invocable built-in trait

On Fri, 20 Oct 2023, Ken Matsui wrote: > This patch implements built-in trait for std::is_invocable. Nice! My email client unfortunately ate my first review attempt, so apologies for my brevity this time around. > gcc/cp/ChangeLog: > > * cp-trait.def: Define __is_invocable. > * con

Re: [PATCH v23 32/33] c++: Implement __is_invocable built-in trait

On Fri, 20 Oct 2023, Patrick Palka wrote: > On Fri, 20 Oct 2023, Ken Matsui wrote: > > > This patch implements built-in trait for std::is_invocable. > > Nice! My email client unfortunately ate my first review attempt, so > apologies for my brevity this time around. > > > gcc/cp/ChangeLog: > >

Re: [PATCH v23 32/33] c++: Implement __is_invocable built-in trait

On Fri, 20 Oct 2023, Patrick Palka wrote: > On Fri, 20 Oct 2023, Patrick Palka wrote: > > > On Fri, 20 Oct 2023, Ken Matsui wrote: > > > > > This patch implements built-in trait for std::is_invocable. > > > > Nice! My email client unfortunately ate my first review attempt, so > > apologies for

[pushed] c++: abstract class and overload resolution

Tested x86_64-pc-linux-gnu, applying to trunk. -- 8< -- In my implementation of P0929 I treated a conversion to an rvalue of abstract class type as a bad conversion, but that's still too soon to check it; we need to wait until we're done with overload resolution. gcc/cp/ChangeLog: * cal

Re: [PATCH] c++: Implement C++26 P2361R6 - Unevaluated strings [PR110342]

On Fri, Oct 20, 2023 at 04:12:48PM -0400, Jason Merrill wrote: > On 8/24/23 09:58, Jakub Jelinek wrote: > > The following patch implements C++26 unevaluated-string. > > As it seems to me just extra pedanticity, it is implemented only for > > -std=c++26 or -std=gnu++26 and later and only if -pedanti

Re: [PATCH v9 4/4] ree: Improve ree pass for rs6000 target using defined ABI interfaces

On 10/19/23 23:50, Ajit Agarwal wrote: Hello All: This version 9 of the patch uses abi interfaces to remove zero and sign extension elimination. Bootstrapped and regtested on powerpc-linux-gnu. In this version (version 9) of the patch following review comments are incorporated. a) Removal of

Re: [PATCH] c++: Implement C++26 P2361R6 - Unevaluated strings [PR110342]

On 10/20/23 17:59, Jakub Jelinek wrote: On Fri, Oct 20, 2023 at 04:12:48PM -0400, Jason Merrill wrote: On 8/24/23 09:58, Jakub Jelinek wrote: The following patch implements C++26 unevaluated-string. As it seems to me just extra pedanticity, it is implemented only for -std=c++26 or -std=gnu++26

RE: [PATCH v2] RISC-V: Support partial VLS mode when preference fixed-vlmax [PR111857]

Committed, thanks Juzhe. Pan

Re: Darwin: Replace environment runpath with embedded [PR88590]

On Aug 29, 2023, FX Coudert wrote: >> I think a build machinery review is needed. > Thanks. CC’ing the relevant maintainers for review of the build part. > The driver part and the darwin-specific part are already okayed. The build machinery bits look reasonable to me. I have no specific knowled

Re: [PATCH RESEND] libatomic: drop redundant all-multi command

On Aug 1, 2023, Jan Beulich via Gcc-patches wrote: > * Makefile.am (all-multi): Drop commands. > * Makefile.in: Update accordingly. LGTM, thanks, -- Alexandre Oliva, happy hackerhttps://FSFLA.org/blogs/lxo/ Free Software Activist GN

[PATCH] RISC-V: 'Zfa' extension is now ratified

From: Tsukasa OI Since this extension is ratified, it now has the version number 1.0. Reference: gcc/ChangeLog: * common/config/riscv/riscv-common.cc (riscv_ext_version_table): Change version number of the 'Zfa' extension to

[PATCH] RISC-V: Prohibit combination of 'E' and 'H'

From: Tsukasa OI According to the ratified privileged specification (version 20211203), it says: > The hypervisor extension depends on an "I" base integer ISA with 32 x > registers (RV32I or RV64I), not RV32E, which has only 16 x registers. Also in the latest draft, it also prohibits RV64E with

Re: Remove stale Autoconf checks for Perl

On May 16, 2023, Thomas Schwinge wrote: > OK to push the attached "Remove stale Autoconf checks for Perl"? LGTM, thanks, -- Alexandre Oliva, happy hackerhttps://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer Disinformation fl

<    1   2